D21220: [Touchpad KCM] Fix libinput-less build and warnings

[Vlad Zagorodniy]

zzag added inline comments.

INLINE COMMENTS

> libinputcommon.h:28
>  template
> -T valueLoaderPart(QVariant const &reply) { Q_UNUSED(reply); return T(); }
> +inline T valueLoaderPart(QVariant const &reply) { Q_UNUSED(reply); return 
> T(); }
>  

Just a note for the future: you don't have to define this function. It's enough 
to do

  template 
  T valueLoaderPart(QVariant const &reply);

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21220

To: romangg, #plasma, davidedmundson
Cc: zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[David Edmundson]

davidedmundson added a comment.


  I love use of layouts for everything, so in general ++

INLINE COMMENTS

> CompactApplet.qml:34
>  subText: plasmoid.toolTipSubText
> -location: if (plasmoid.parent && plasmoid.parent.parent.objectName === 
> "hiddenTasksColumn" && plasmoid.location !== PlasmaCore.Types.LeftEdge) {
> -return PlasmaCore.Types.RightEdge;

When you say it did nothing, You'd need to test every hidden applet whilst 
having the panel on the left.

See D1253 

If it ain't broke...

> PlasmoidItem.qml:45
>  if (applet && mouse.button === Qt.LeftButton) {
> -applet.expanded = true;
> +applet.expanded = !applet.expanded;
>  }

Huh? how did this work before?

> main.qml:66
>  
> +// Shouldn't it be part of Qt?
> +function findParentNamed(object, objectName) {

Not really.
Using objectNames is a bit of an anti pattern, especially when QML has so the 
built-in component scope hierachy.

We use it in the system tray already, and it's arguably no worse than the 
existing applet.parent.parent.

So fine here, but only because the system is mad.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> davidedmundson wrote in PlasmoidItem.qml:45
> Huh? how did this work before?

Applets do it by itself, when it not do, it does not work like Weather Widget 
embed in systray.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  So, I've merged done git rebase on master — just one conflicting line, 
rewritten after me in a better way.  But now I have no way to test it, because 
CMake Error `Could not find a configuration file for package "ECM" that is 
compatible with requested version "5.58.0"` and even all-up-to-date Arch Linux 
does not provide those pieces. I've installed the latest CMake from the 
`testing` repository, but other versioning issues showed up.
  
  I'm not a big fan of submitting without checking, but I don't see any other 
way around.

INLINE COMMENTS

> davidedmundson wrote in CompactApplet.qml:34
> When you say it did nothing, You'd need to test every hidden applet whilst 
> having the panel on the left.
> 
> See D1253 
> 
> If it ain't broke...

As far as I remember, one of the branches never got executed in my environment. 
Could you point to specific use case which requires this "almost dead" code?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:66
> Not really.
> Using objectNames is a bit of an anti pattern, especially when QML has so the 
> built-in component scope hierachy.
> 
> We use it in the system tray already, and it's arguably no worse than the 
> existing applet.parent.parent.
> 
> So fine here, but only because the system is mad.

Pattern or not — Qt provides us with this `objectName` property so we can do 
stuff. But Qt itself is not engaged in providing further support for it. That's 
frustrating.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, 
GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[David Redondo]

davidre added a comment.


  In D19745#465569 , @ratijastk 
wrote:
  
  > So, I've merged done git rebase on master — just one conflicting line, 
rewritten after me in a better way.  But now I have no way to test it, because 
CMake Error `Could not find a configuration file for package "ECM" that is 
compatible with requested version "5.58.0"` and even all-up-to-date Arch Linux 
does not provide those pieces. I've installed the latest CMake from the 
`testing` repository, but other versioning issues showed up.
  >
  > I'm not a big fan of submitting without checking, but I don't see any other 
way around.
  
  
  ECM is an KDE project https://api.kde.org/ecm/ and part of frameworks. Try 
installing extra-cmake-modules (don't know the exact name on arch).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  ~~Even with extra-cmake-modules 5.58, kcoreaddons needs to be updated as 
well... work in progress... please, be patient: i have autism^W slow hardware.~~
  
  5.58.0 releases just rolled out, upgrading...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Nathaniel Graham]

ngraham updated this revision to Diff 58121.
ngraham added a comment.


  Bring back old text switch method (it was less buggy)

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21221?vs=58113&id=58121

BRANCH
  modernize-notes-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21221

AFFECTED FILES
  applets/notes/package/contents/ui/configAppearance.qml

To: ngraham, #vdg, #plasma, GB_2, ndavis
Cc: ndavis, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Marco Martin]

mart accepted this revision.
mart added a comment.


  I'm not 100% sure about using kcm components outside actual kcms, but i guess 
to fix that properly it would need those components in a more abstract manner 
somewhere else like in kirigami and then the kcm import only specializing it.
  
  So for now don't worry about that and go for it.

REPOSITORY
  R114 Plasma Addons

BRANCH
  modernize-notes-settings-window (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21221

To: ngraham, #vdg, #plasma, GB_2, ndavis, mart
Cc: mart, ndavis, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:4f163efbc4c4: [Notes] Port to QQC2 and use GridView KCM 
components for the color chooser (authored by ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21221?vs=58121&id=58122

REVISION DETAIL
  https://phabricator.kde.org/D21221

AFFECTED FILES
  applets/notes/package/contents/ui/configAppearance.qml

To: ngraham, #vdg, #plasma, GB_2, ndavis, mart
Cc: mart, ndavis, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Nathaniel Graham]

ngraham added a comment.


  Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  
$  cat /etc/X11/xorg.conf.d/99-libinput.conf
Section "InputClass"
Identifier "libinput touchpad catchall"
MatchIsTouchpad "on"
MatchDevicePath "/dev/input/event*"
Driver "libinput"
Option "ClickMethod" "clickfinger" # other option is "buttonareas"
Option "DisableWhileTyping" "false"
Option "AccelSpeed" "0.2"
#Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
EndSection
  
  Others may have similar settings. If possible, it might be nice to read these 
config files to determine the default option state in the KCM. Then once the 
user modifies anything, a new user-specific config file gets written that takes 
priority.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> configAppearance.qml:79
> +color: {
> +if (modelData == "black" || modelData == 
> "translucent-light") {
> +return "#dfdfdf"

this looks like it's a bad merge

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21221

To: ngraham, #vdg, #plasma, GB_2, ndavis, mart
Cc: davidedmundson, mart, ndavis, GB_2, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk updated this revision to Diff 58123.
ratijastk added a comment.


  Rebase on most recent master

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19745?vs=53851&id=58123

BRANCH
  fix-system-tray

REVISION DETAIL
  https://phabricator.kde.org/D19745

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/StatusNotifierItemModel.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

[Nathaniel Graham]

ngraham marked an inline comment as done.
ngraham added inline comments.

INLINE COMMENTS

> davidedmundson wrote in configAppearance.qml:79
> this looks like it's a bad merge

Fixed in 61ab2de7bf19a496e11085245b2fa65a48bd6408 
, 
sorry about that.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D21221

To: ngraham, #vdg, #plasma, GB_2, ndavis, mart
Cc: davidedmundson, mart, ndavis, GB_2, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Review Request: plasma-thunderbolt

[Daniel Vrátil]

Hi all,

plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM 
for Plasma. I initially submitted the code as a patch against plasma-desktop 
[0], where it got reviewed, but it was ultimately decided to better put it 
into a separate repository, since it's not just a KCM but also a library and a 
KDED module. I have backported all the changes from the Phabricator review 
back to the repository, so the code in the repo is identical to the one in the 
Phab review (minus buildsystem changes and a small build fix for clang).

However, since this is still a new code, it must formally pass through 
kdereview before I can submit it into Plasma as a new module.

Thus I'd kindly ask you to take one more look at the codebase [1] and let me 
know if there are any more issues to fix, or if we can proceed to include this 
in the next Plasma release.

Thanks,
- Dan

[0] https://phabricator.kde.org/D19011
[1] https://cgit.kde.org/plasma-thunderbolt.git

-- 
Daniel Vrátil
www.dvratil.cz | dvra...@kde.org
IRC: dvratil on Freenode (#kde, #kontact, #akonadi, #fedora-kde)

GPG Key: 0x4D69557AECB13683
Fingerprint: 0ABD FA55 A4E6 BEA9 9A83 EA97 4D69 557A ECB1 3683

signature.asc
Description: This is a digitally signed message part.

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 205 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/205/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 15 May 2019 00:01:18 +
 Build duration:
5 min 50 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/81)16%
(64/390)16%
(64/390)12%
(/36060)10%
(2403/23922)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kicker.plugin0%
(0/37)0%
(0/37)0%
(0/3321)0%
(0/2622)applets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/349)0%
(0/232)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/246)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/111)0%
(0/54)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2345)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 146 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/146/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 10 May 2019 20:45:32 +
 Build duration:
57 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)Name: projectroot.autotests Failed: 4 test(s), Passed: 104 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDebugConsoleFailed: projectroot.autotests.integration.kwin_testInternalWindowFailed: projectroot.autotests.integration.kwin_testInternalWindow_waylandonlyFailed: projectroot.autotests.integration.kwin_testMoveResizeName: projectroot.autotests.integration Failed: 0 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 18 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)58%
(322/555)58%
(322/555)42%
(30911/73566)32%
(14310/45313)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionals87%
(133/153)87%
(133/153)64%
(19086/29942)48%
(9954/20580)colorcorrection100%
(5/5)100%
(5/5)82%
(438/535)59%
(195/328)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)79%
(429/541)65%
(132/204)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/380)4%
(12/296)effects.blur20%
(1/5)20%
(1/5)2%
(14/683)3%
(13/403)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(4/1285)0%
(0/1017)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)7%
(73/1023)3%
(27/962)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/232)2%
(3/160)effects.fallapart100%
(2/2)100%
(2/2)34%
(38/111)26%
(17/66)effects.flipswitch33%
(1/3)33%
(1/3)7%
(45/655)1%
(5/554)effects.glide67%
(2/3)67%
(2/3)7

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 199 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/199/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 09 May 2019 09:59:33 +
 Build duration:
5 min 34 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/80)17%
(66/390)17%
(66/390)12%
(4386/36004)10%
(2399/23904)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kicker.plugin0%
(0/37)0%
(0/37)0%
(0/3321)0%
(0/2622)applets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/349)0%
(0/232)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/246)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/111)0%
(0/54)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2345)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%

D21225: set the wallpaper when applying look and feel

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  A LNF package can optionally define a wallpaper
  which can be either a wallpaper package name or a
  file name to be found in either of the standard wallpaper locations
  (/usr/share/wallpapers, ~/.local/share wallpapers and so on)
  
  when a lnf is switched and the new one contains a wallpaper,
   the wallpaper of the primary screen of the current activity of plasma
  (and only that one) will be switched to the new wallpaper

TEST PLAN
  tested with both themes that specify a wallpaper and those who don't
  also tested with themes with an invalid wallpaper in which case it notices and
  doesn't try to switch

REPOSITORY
  R119 Plasma Desktop

BRANCH
  mart/wallpaperLoolAndFeel

REVISION DETAIL
  https://phabricator.kde.org/D21225

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Review Request: plasma-thunderbolt

[Friedrich W. H. Kossebau]

Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil:
> Thus I'd kindly ask you to take one more look at the codebase [1] and let me
> know if there are any more issues to fix, or if we can proceed to include
> this in the next Plasma release.

Pushed some small fixes to toplevel CMakeLists.txt

Other things seen on quick look at code (also not tested runtime):
* kded misses a Messages.sh file.
* no COPYRIGHT license files in the repo
* kde_enable_exceptions() duplicated a few times, perhaps only do in subdirs 
where needed or use of kde_target_enable_exceptions() if fitting
* libkbolt being a private library could be reflected in the libname, also get  
   
install(TARGETS kbolt ${KDE_INSTALL_TARGETS_DEFAULT_ARGS} LIBRARY 
NAMELINK_SKIP)

Cheers
Friedrich

D21226: search for a default wallpaper in lookandfeel

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  now look and feel packages can specify a default image wallpaper.
  when a new containment is created at first plasma start or at activity 
creation
  search for a default wallpaper inthe order:
  look and feel package
  if fails, from the plasma theme
  
  we are sure to find a default after it as if neither of those specify one,
  the wallpaper specified by the breeze plasma theme (Next) will be used

TEST PLAN
  tested to start plasma with an empty config file with different themes
  that do or don't include wallpapers

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mart/wallpaperFromLnf

REVISION DETAIL
  https://phabricator.kde.org/D21226

AFFECTED FILES
  lookandfeel/contents/defaults
  wallpapers/image/image.cpp

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21226: search for a default wallpaper in lookandfeel

[David Edmundson]

davidedmundson added a comment.


  Didn't we move contents/layout.js to be part of the lookandfeel and that was 
the previous way to set a default wallpaper?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21226

To: mart, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21225: set the wallpaper when applying look and feel

[Marco Martin]

mart updated this revision to Diff 58128.
mart added a comment.


  - add property for applyWallpaper

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21225?vs=58126&id=58128

BRANCH
  mart/wallpaperLoolAndFeel

REVISION DETAIL
  https://phabricator.kde.org/D21225

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm.h

To: mart, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21226: search for a default wallpaper in lookandfeel

[Marco Martin]

mart added a comment.


  In D21226#465633 , @davidedmundson 
wrote:
  
  > Didn't we move contents/layout.js to be part of the lookandfeel and that 
was the previous way to set a default wallpaper?
  
  
  layout.js is mostly to create a whole layout from scratch (like, put all my 
panels like in Unity) you can also set a wallpaper in the js, but necessitates 
to destroy the current plasma layout.
  
  that is supported too, and is necessary if one wants to put something not 
image,  it's quite overkill for simple themes
  also, in layout.js works only if in the kcm one checks the box of resetting 
the plasma layout, meaning is necessary to lose the whole plasma setup in order 
to apply the wallpaper.
  this makes it for a simpler way not mutually exclusive.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21226

To: mart, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14147: Port from GConf to GSettings

[Nicolas Fella]

nicolasfella closed this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D14147

To: nicolasfella, drosca, davidedmundson
Cc: fvogt, kossebau, ngraham, pino, lbeltrame, evpokp, rikmills, broulik, 
asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21226: search for a default wallpaper in lookandfeel

[Marco Martin]

mart updated this revision to Diff 58130.
mart added a comment.


  - use proper path of the package

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21226?vs=58127&id=58130

BRANCH
  mart/wallpaperFromLnf

REVISION DETAIL
  https://phabricator.kde.org/D21226

AFFECTED FILES
  lookandfeel/contents/defaults
  wallpapers/image/image.cpp

To: mart, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Atul Bisht]

atulbi added a comment.


  In D20186#465586 , @ngraham wrote:
  
  > Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  >
  >   $  cat /etc/X11/xorg.conf.d/99-libinput.conf
  >   Section "InputClass"
  >   Identifier "libinput touchpad catchall"
  >   MatchIsTouchpad "on"
  >   MatchDevicePath "/dev/input/event*"
  >   Driver "libinput"
  >   Option "ClickMethod" "clickfinger" # other option is "buttonareas"
  >   Option "DisableWhileTyping" "false"
  >   Option "AccelSpeed" "0.2"
  >   #Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
  >   EndSection
  >
  >
  > Others may have similar settings. If possible, it might be nice to read 
these config files to determine the default option state in the KCM. Then once 
the user modifies anything, a new user-specific config file gets written that 
takes priority.
  
  
  Is there any specific library which could read these files ??

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21228: [Touchpad KCM] Load previous setting on reboot

[Atul Bisht]

atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  Earlier Previous setting were not loaded on reboot instead default settings 
were loaded.
  So, added config file for saving the settings.
  
  Now on startup, settings from config file will be loaded.

TEST PLAN
  Tested using kcminit and manually rebooting.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  AddConfig

REVISION DETAIL
  https://phabricator.kde.org/D21228

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/src/kcm/touchpadconfigcontainer.h

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21226: search for a default wallpaper in lookandfeel

[Friedrich W. H. Kossebau]

kossebau added a comment.


  BTW, there is also still code in place to support Plasma Themes defining a 
default wallpaper (or even deploy some more). Though the default & the further 
are not listed in the Image wallpaper config, also is the config not offering 
any hint about the default or to reset to using any default.
  
  Has this been considered already? Only noticed recently, but did not want to 
create a new theme work can for me :)
  
  Given lookandfeel also allows to set Plasma Theme, should the default 
wallpaper image really be duplicated as another property also with the 
LookAndFeel theme?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21226

To: mart, #plasma
Cc: kossebau, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21097: Handle apps which set the desktopFileName property with filename suffix

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:0e50f23c4c43: Handle apps which set the desktopFileName 
property with filename suffix (authored by kossebau).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21097?vs=57805&id=58132

REVISION DETAIL
  https://phabricator.kde.org/D21097

AFFECTED FILES
  src/platformtheme/x11integration.cpp

To: kossebau, #plasma, broulik, davidedmundson
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21229: Use view background color for sidebar to match other sidebars

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Generally, left sidebars in Kirigami-style apps (e.g. System Settings) use 
the view
  background color. Let's do the same in Discover.

TEST PLAN
  Sidebar is now a pleasing off-white, same as System Settings
  F6824729: view background color for sidebar.png 


REPOSITORY
  R134 Discover Software Store

BRANCH
  view-bg-color-for-sidebars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21229

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21226: search for a default wallpaper in lookandfeel

[Marco Martin]

mart added a comment.


  In D21226#465681 , @kossebau wrote:
  
  > Has this been considered already? Only noticed recently, but did not want 
to create a new theme work can for me :)
  
  
  That's what the code in that function i left untouched does line 285 onwards.
  
  This makes me think that probably i should not define a default wallpaper in 
the breeze lnf, but rather in the lnf kcm when i'm re-setting the wallpaper to 
also look in the plasma theme if the lnf does not specify any. this way when 
using the breeze lnf the default wallpaper would still come from the plasma 
theme

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21226

To: mart, #plasma
Cc: kossebau, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21229: Use view background color for sidebar to match other sidebars

[Marco Martin]

mart added a comment.


  +1

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21229

To: ngraham, #vdg, #discover_software_store, apol
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D21229: Use view background color for sidebar to match other sidebars

[Nathaniel Graham]

ngraham updated this revision to Diff 58135.
ngraham added a comment.


  Only for desktop view

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21229?vs=58134&id=58135

BRANCH
  view-bg-color-for-sidebars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21229

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D21229: Use view background color for sidebar to match other sidebars

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:1658a360040c: Use view background color for sidebar to 
match other sidebars (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21229?vs=58135&id=58136

REVISION DETAIL
  https://phabricator.kde.org/D21229

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D21229: Use view background color for sidebar to match other sidebars

[Filip Fila]

filipf added a comment.


  You were too quick for me but just wanted to say: nice!
  
  I also saw that we needed to fix the color errors in the System Settings 
sidebar and you solved that as well :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21229

To: ngraham, #vdg, #discover_software_store, apol
Cc: filipf, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D21027: [Notes] Fix icons being almost invisible with light backgrounds

[Filip Fila]

filipf added a comment.


  In D21027#464443 , @broulik wrote:
  
  > > I tried to set  icon.width and icon.height but it doesn't do anything.
  >
  > In desktop style that should work since D20418 

  
  
  Tried it in Neon unstable as well but the icons always remained the same. 
Does it work for you if you modify this patch?

REPOSITORY
  R114 Plasma Addons

BRANCH
  background-appropriate-icon-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21027

To: filipf, #plasma, #vdg, ngraham, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

[Filip Fila]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:6d0289d7b284: [QQC2 Slider Style] Fix wrong handle 
positioning when initial value is 1 (authored by filipf).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21075?vs=57752&id=58137

REVISION DETAIL
  https://phabricator.kde.org/D21075

AFFECTED FILES
  org.kde.desktop/Slider.qml

To: filipf, mart, #plasma, ngraham, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21229: Use view background color for sidebar to match other sidebars

[Nathaniel Graham]

ngraham added a comment.


  :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21229

To: ngraham, #vdg, #discover_software_store, apol
Cc: filipf, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D19745: Fix system tray UI/UX & refactor

[ivan tkachenko]

ratijastk added a comment.


  Double checked on my system. Nothing bad happened so far.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

[Fabian Vogt]

fvogt added a comment.


  In D20186#465586 , @ngraham wrote:
  
  > Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  >
  >   $  cat /etc/X11/xorg.conf.d/99-libinput.conf
  >   Section "InputClass"
  >   Identifier "libinput touchpad catchall"
  >   MatchIsTouchpad "on"
  >   MatchDevicePath "/dev/input/event*"
  >   Driver "libinput"
  >   Option "ClickMethod" "clickfinger" # other option is "buttonareas"
  >   Option "DisableWhileTyping" "false"
  >   Option "AccelSpeed" "0.2"
  >   #Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
  >   EndSection
  >
  >
  > Others may have similar settings. If possible, it might be nice to read 
these config files to determine the default option state in the KCM. Then once 
the user modifies anything, a new user-specific config file gets written that 
takes priority.
  
  
  AFAIK those options are what
  
  In D20186#465670 , @atulbi wrote:
  
  > In D20186#465586 , @ngraham 
wrote:
  >
  > > Also keep in mind that it's possible to have global config files in 
`/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work 
around the lack of this feature being implemented yet:
  > >
  > >   $  cat /etc/X11/xorg.conf.d/99-libinput.conf
  > >   Section "InputClass"
  > >   Identifier "libinput touchpad catchall"
  > >   MatchIsTouchpad "on"
  > >   MatchDevicePath "/dev/input/event*"
  > >   Driver "libinput"
  > >   Option "ClickMethod" "clickfinger" # other option is 
"buttonareas"
  > >   Option "DisableWhileTyping" "false"
  > >   Option "AccelSpeed" "0.2"
  > >   #Option "MiddleEmulation" "true" # Only use this with the 
"buttonareas" clickmethod
  > >   EndSection
  > >
  > >
  > > Others may have similar settings. If possible, it might be nice to read 
these config files to determine the default option state in the KCM. Then once 
the user modifies anything, a new user-specific config file gets written that 
takes priority.
  >
  >
  > Is there any specific library which could read these files ??
  
  
  AFAIK this is not necessary. The configuration here simply specifies the 
default values for the properties used until overwritten during runtime.
  So storing it in whatever format and applying them on device discovery is 
fine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D20186

To: atulbi, ngraham, romangg, davidedmundson, #plasma
Cc: fvogt, GB_2, jriddell, knambiar, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Review Request: plasma-thunderbolt

[Luca Beltrame]

In data mercoledì 15 maggio 2019 15:27:07 CEST, Daniel Vrátil ha scritto:

> Thus I'd kindly ask you to take one more look at the codebase [1] and let me
> know if there are any more issues to fix, or if we can proceed to include
> this in the next Plasma release.

The repository at this point is missing either a LICENSE or a COPYING file 
with the correct license (there is none).

-- 
Luca Beltrame
GPG key ID:  A29D259B

signature.asc
Description: This is a digitally signed message part.

D21228: [Touchpad KCM] Load previous setting on reboot

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> libinputtouchpad.cpp:415
> +
> +if (replyValue!=savedValue) {
> +replyValue = savedValue;

Coding style: Space around !=

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: atulbi, ngraham, romangg
Cc: nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Discover uses the `Kirigami.GlobalDrawer` for its navigation sidebar. This 
component is
  designed to be used for showing global actions and hiding when not in use, 
and displays
  a big banner image on top. This banner concept is borrowed from Android, 
which has the
  same kind of global drawers full of actions with banners on top. So the 
concept is
  somewhat familiar on mobile. However on the desktop, this "sidebar with 
banner image on
  top" UI is not used and feels out of place.
  
  This patch adjusts the sidebar appearance to look and feel more conventional 
in the
  desktop view, keeping the banner version only for the mobile view.

TEST PLAN
  Desktop view: F6826087: Desktop view.png 

  Mobile view: F6826086: Mobile view.png 
  
  Now Discover's sidebar looks quite similar to System Settings' sidebar, which 
is very
  visually appealing: F6826091: Discover and System Settings.png 


REPOSITORY
  R134 Discover Software Store

BRANCH
  more-conventional-sidebar-header-appearance

REVISION DETAIL
  https://phabricator.kde.org/D21234

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #vdg, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21228: [Touchpad KCM] Load previous setting on reboot

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> libinputtouchpad.cpp:217
> +KSharedConfigPtr configPtr = 
> KSharedConfig::openConfig(QStringLiteral("XlibinputConfigrc"));
> +m_config = configPtr.data();
> +touchpadConfig = m_config->group(m_name);

This can be left dangling

Store the KSharedConfigPtr as the member variable then you'll keep a reference

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: atulbi, ngraham, romangg, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Noah Davis]

ndavis added a comment.


  I noticed that there is a difference between the padding around the search 
bar in SySe and Discover. Do you know why this is?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21234

To: ngraham, #vdg, #discover_software_store, apol
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Nathaniel Graham]

ngraham updated this revision to Diff 58150.
ngraham added a comment.


  Fix margins

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21234?vs=58143&id=58150

BRANCH
  more-conventional-sidebar-header-appearance

REVISION DETAIL
  https://phabricator.kde.org/D21234

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Nathaniel Graham]

ngraham added a comment.


  In D21234#465818 , @ndavis wrote:
  
  > I noticed that there is a difference between the padding around the search 
bar in SySe and Discover. Do you know why this is?
  
  
  Fixed in Discover. Any remaining divergence is now System Settings' fault. :)

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21234

To: ngraham, #vdg, #discover_software_store, apol
Cc: ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Filip Fila]

filipf added a comment.


  +1 from a visual POV
  
  In D21234#465818 , @ndavis wrote:
  
  > I noticed that there is a difference between the padding around the search 
bar in SySe and Discover. Do you know why this is?
  
  
  See: https://phabricator.kde.org/D20972#459899

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D21234

To: ngraham, #vdg, #discover_software_store, apol
Cc: filipf, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Nathaniel Graham]

ngraham added a comment.


  In D20972#460812 , @filipf wrote:
  
  > While the proposed `Layout.rightMargin` is not an ideal solution, in these 
circumstances I think it's a legitimate way to compensate for the separator 
eating into the width.
  
  
  Yeah, that's what I had to do for Discover in D21234 
.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Review Request: plasma-thunderbolt

[Albert Astals Cid]

El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure:
> Hi all,
> 
> plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM 
> for Plasma. I initially submitted the code as a patch against plasma-desktop 
> [0], where it got reviewed, but it was ultimately decided to better put it 
> into a separate repository, since it's not just a KCM but also a library and 
> a 
> KDED module. I have backported all the changes from the Phabricator review 
> back to the repository, so the code in the repo is identical to the one in 
> the 
> Phab review (minus buildsystem changes and a small build fix for clang).
> 
> However, since this is still a new code, it must formally pass through 
> kdereview before I can submit it into Plasma as a new module.
> 
> Thus I'd kindly ask you to take one more look at the codebase [1] and let me 
> know if there are any more issues to fix, or if we can proceed to include 
> this 
> in the next Plasma release.

There's this cmake warning

CMake Warning at /usr/lib64/cmake/KF5Package/KF5PackageMacros.cmake:74 
(message):
  KPackage components should be specified in reverse domain notation.
  Appstream information won't be generated for kcm_bolt.
Call Stack (most recent call first):
  src/kcm/CMakeLists.txt:22 (kpackage_install_package)




clazy complains about a few Q_PROPERTY that should ideally either have a NOTIFY 
signal or be marked as CONSTANT

it also complains about a few const slots that return values. Seems like what 
you want is to actually mark them as invokable/scriptable and not as slots?

Cheers,
  Albert

> 
> Thanks,
> - Dan
> 
> [0] https://phabricator.kde.org/D19011
> [1] https://cgit.kde.org/plasma-thunderbolt.git
> 
> 

D21228: [Touchpad KCM] Load previous setting on reboot

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> libinputtouchpad.cpp:216
>  }
> +KSharedConfigPtr configPtr = 
> KSharedConfig::openConfig(QStringLiteral("XlibinputConfigrc"));
> +m_config = configPtr.data();

The name of the config file should be something similar to the other one and 
only lower case: `touchpadxlibinputrc`

> libinputtouchpad.cpp:426
> +touchpadConfig.config()->sync();
> +}
>  return true;

Why this write back? What's configProps.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: atulbi, ngraham, romangg, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21228: [Touchpad KCM] Load previous setting on reboot

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> libinputtouchpad.cpp:56
> +QStringLiteral("clickMethodClickfinger")
> +};
> +

In best case these should be in some way shared with libinputProperties array 
to minimize code duplication. But as long as these names are the same as in 
libinputProperties, we can leave it like that for now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21228

To: atulbi, ngraham, romangg, davidedmundson
Cc: davidedmundson, nicolasfella, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20972: [sidebar] Make search field not glued to the separator

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D20972

To: filipf, #vdg, ngraham, davidedmundson
Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  I think this is much better. I like the inclusion of a home button as well.

REPOSITORY
  R134 Discover Software Store

BRANCH
  more-conventional-sidebar-header-appearance

REVISION DETAIL
  https://phabricator.kde.org/D21234

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: filipf, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21234: Use a more conventional sidebar header apparance in desktop view

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:75e24b05e768: Use a more conventional sidebar header 
apparance in desktop view (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21234?vs=58150&id=58153

REVISION DETAIL
  https://phabricator.kde.org/D21234

AFFECTED FILES
  discover/qml/DiscoverDrawer.qml

To: ngraham, #vdg, #discover_software_store, apol, ndavis
Cc: filipf, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart