D19745: Fix system tray UI/UX & refactor

2019-05-18 Thread Nathaniel Graham 
ngraham added a subscriber: aacid.
ngraham added a comment.


  In D19745#466760 , @davidedmundson 
wrote:
  
  > > Please, check whether 'LayoutMirroring' works properly.
  >
  > To test layout mirroring run "plasmashell --reverse"
  >  Layouts will auto handle most things, so things should be fine.
  >
  > Do you have commit access?
  
  
  BTW @aacid recently taught me that it's possible to find out this information 
for oneself by searching for a username, real name, or email address on 
https://websvn.kde.org/trunk/kde-common/accounts?view=markup.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-system-tray

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, 
plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

2019-05-18 Thread Alejandro Valdes 
avaldes marked 3 inline comments as done.
avaldes added a comment.


  Updated with latest comments.
  
  Please land, I don't have permissions.

REPOSITORY
  R122 Powerdevil

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

To: avaldes, broulik, ngraham
Cc: reverendhomer, meven, soriano, abalaji, graesslin, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16425: Added new Suspend then Hibernate option

2019-05-18 Thread Alejandro Valdes 
avaldes updated this revision to Diff 58273.
avaldes added a comment.


  Added new Suspend then Hibernate option
  

  
  Summary:
  See bug 399727  for a good 
description of what this code is for.
  
  The new ui will show a new option like the following image F6349860: 
screenshot.png 
  

  
  Reviewers: broulik, ngraham
  
   
  
  Subscribers: soriano, abalaji, graesslin, ngraham, plasma-devel
  

  
  Tags: #plasma 
  

  
  Differential Revision: https://phabricator.kde.org/D16425

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16425?vs=58091=58273

BRANCH
  arcpatch-D16425_1

REVISION DETAIL
  https://phabricator.kde.org/D16425

AFFECTED FILES
  daemon/actions/bundled/suspendsession.cpp
  daemon/actions/bundled/suspendsession.h
  daemon/actions/bundled/suspendsessionconfig.cpp
  daemon/actions/bundled/suspendsessionconfig.h
  daemon/backends/upower/login1suspendjob.cpp
  daemon/backends/upower/powerdevilupowerbackend.cpp
  daemon/backends/upower/upowersuspendjob.cpp
  daemon/org.freedesktop.PowerManagement.xml
  daemon/powerdevilbackendinterface.h
  daemon/powerdevilfdoconnector.cpp
  daemon/powerdevilfdoconnector.h
  daemon/powerdevilpowermanagement.cpp
  daemon/powerdevilpowermanagement.h

To: avaldes, broulik, ngraham
Cc: reverendhomer, meven, soriano, abalaji, graesslin, ngraham, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21274: Don't assign a QtObject to a model

2019-05-18 Thread Aleix Pol Gonzalez 
apol added a comment.


  To do this in the past I've used an object array which would read a bit less 
hacky.
  
userListModel: [ QtObject { /*...*/} ]

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21274

To: davidedmundson, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21268: Add missing includes

2019-05-18 Thread Michael Palimaka 
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:fbf0fc710cfb: Add missing includes (authored by palimaka).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21268?vs=58234=58270

REVISION DETAIL
  https://phabricator.kde.org/D21268

AFFECTED FILES
  libs/editor/settings/wireguardinterfacewidget.cpp
  libs/editor/settings/wireguardpeerwidget.cpp

To: palimaka, jgrulich, davidedmundson
Cc: asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

2019-05-18 Thread Filip Fila 
filipf updated this revision to Diff 58269.
filipf added a comment.


  height=width

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21279?vs=58267=58269

BRANCH
  add-spacing-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21279

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf, #vdg, #plasma, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21279: [sddm-theme] Add spacing between action buttons' labels

2019-05-18 Thread Filip Fila 
filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Currently there is no spacing between the labels of action buttons, leading 
to crammed text with longer translations which are not split up into more rows.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  add-spacing-action-buttons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21279

AFFECTED FILES
  sddm-theme/Main.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

2019-05-18 Thread Roman Gilg 
romangg added a comment.


  I believe we don't call the `XcbAtom::intern` function in the X libinput 
backend, what we do in the evdev/synaptics constructor part. Question is if we 
just don't want to not send the relevant call on keypress after all in X 
libinput. Because libinput does the disable-on-keyboard thing internally and we 
don't need to send anything like we did before.
  
  > by kded on key press other than Kded Keyboard shortcuts
  
  Do you mean it's sent on shortcut or not? Just wondering why I couldn't 
replicate the issue in my testing.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

2019-05-18 Thread David Edmundson 
davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  > m_connection seems to be having null or 0x0 value.
  
  Which means we're calling XcbAtom::atom after being constructed from the 
default constructor not the proper one.
  
  That doesn't sound right. If you can explain why we end up in this situation 
and it's legit, I'll accept, otherwise it looks like we're just treating a 
symptom.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21278

To: atulbi, romangg, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21278: [Touchpad KCM] Fix kded crashing at startup

2019-05-18 Thread Atul Bisht 
atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  When XcbAtom::atom() is called (by kded on key press other than Kded Keyboard 
shortcuts), m_connection seems to be having null or 0x0 value.
  Small check on m_connection solves the issue for me.

TEST PLAN
  kded5 do not crashed at startup.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D21278

AFFECTED FILES
  kcms/touchpad/src/backends/x11/xcbatom.cpp

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

2019-05-18 Thread David Edmundson 
davidedmundson added a comment.


  > Please, check whether 'LayoutMirroring' works properly.
  
  To test layout mirroring run "plasmashell --reverse"
  Layouts will auto handle most things, so things should be fine.
  
  Do you have commit access?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-system-tray

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D19745: Fix system tray UI/UX & refactor

2019-05-18 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> ratijastk wrote in CompactApplet.qml:34
> As far as I remember, one of the branches never got executed in my 
> environment. Could you point to specific use case which requires this "almost 
> dead" code?

You will enter this branch if the system tray is on the left.

It doesn't make a difference now since Dialog gained support to not not overlap 
panels and to switch edges if it doesn't fit.

This puts the location in a "wrong" way we hit the conflict detection in Dialog 
and it fixes it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix-system-tray

REVISION DETAIL
  https://phabricator.kde.org/D19745

To: ratijastk, #vdg, #plasma, broulik, mart, hein, davidedmundson
Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D21274: Don't assign a QtObject to a model

2019-05-18 Thread David Edmundson 
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It's a weird thing to do, and that's causing us to hit
  https://bugreports.qt.io/browse/QTBUG-75900 when it tries to lookup a
  property (icon) that we don't have.
  
  BUG: 407220

TEST PLAN
  Opened sddm-greeter --test-mode --theme  clicked button

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21274

AFFECTED FILES
  sddm-theme/Main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21269: [Touchpad KCM] Fixed loading of wrong qml file

2019-05-18 Thread Atul Bisht 
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3e0fd10ddc27: [Touchpad KCM] Fixed loading of wrong qml 
file (authored by atulbi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21269?vs=58248=58260#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21269?vs=58248=58260

REVISION DETAIL
  https://phabricator.kde.org/D21269

AFFECTED FILES
  CMakeLists.txt
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpad.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/resources.qrc

To: atulbi, romangg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

2019-05-18 Thread Alexey Min 
alexeymin added a comment.


  Hm, looks ideologically similar to how it was done in SDL2...
  https://hg.libsdl.org/SDL/file/792c26401463/src/power/linux/SDL_syspower.c

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D21273

To: luc4, davidedmundson
Cc: alexeymin, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21273: Add support for newer linux kernel power_supply API. Keep backwardcompatibility with older procfs API.

2019-05-18 Thread Luca Carlon 
luc4 created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
luc4 requested review of this revision.

REPOSITORY
  R106 KSysguard

BRANCH
  batt

REVISION DETAIL
  https://phabricator.kde.org/D21273

AFFECTED FILES
  ksysguardd/Linux/acpi.c

To: luc4
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-05-18 Thread Topi Miettinen 
topimiettinen updated this revision to Diff 58257.
topimiettinen added a comment.


  Updated to reflect that this is also useful for AppArmor

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20853?vs=57094=58257

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21269: [Touchpad KCM] Fixed loading of wrong qml file

2019-05-18 Thread Roman Gilg 
romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Good find. Also backport to beta branch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  touchpad-mouse

REVISION DETAIL
  https://phabricator.kde.org/D21269

To: atulbi, romangg, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21269: [Touchpad KCM] Fixed loading of wrong qml file

2019-05-18 Thread Atul Bisht 
atulbi created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
atulbi requested review of this revision.

REVISION SUMMARY
  On system settings, If Mouse KCM is opened first, then touchpad KCM loads the 
same Mouse QML file (qrc::/libinput/main.qml) instead of Touchpad Qml file.
  Having same url (qrc::/libinput/main.qml).
  
  Fix: simply renaming qml files fixed the issue.There could be better 
solutions though.

TEST PLAN
  1. Renamed main.qml to touchpad.qml .
  2. Edited resource file to reflect change.
  3. When compiled with these changes and opened touchpad setting, it was all 
blank, which was expected (because i did not changed the source).But opening 
mouse and then
  
  touchpad shows mouse settigs. So it Confirmed the cause.
  
  4. Now changing source and compiling it fixes the issue. Now, no more mouse 
on Touchpad and vice-versa.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  touchpad-mouse

REVISION DETAIL
  https://phabricator.kde.org/D21269

AFFECTED FILES
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/kcm/libinput/main.qml
  kcms/touchpad/src/kcm/libinput/touchpad.qml
  kcms/touchpad/src/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/src/kcm/resources.qrc

To: atulbi
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20787: process: add support for cgroups

2019-05-18 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R111:3eb5e842ae64: process: add support for cgroups (authored 
by topimiettinen).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20787?vs=57196=58245

REVISION DETAIL
  https://phabricator.kde.org/D20787

AFFECTED FILES
  processcore/process.cpp
  processcore/process.h
  processcore/processes_linux_p.cpp
  processcore/processes_remote_p.cpp
  processui/ProcessModel.cpp
  processui/ProcessModel.h
  processui/ksysguardprocesslist.cpp

To: topimiettinen, #plasma, hein, davidedmundson
Cc: davidedmundson, apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D20786: ProcessList: add support for cgroups

2019-05-18 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:11af9d11a457: ProcessList: add support for cgroups 
(authored by topimiettinen).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20786?vs=57093=58244

REVISION DETAIL
  https://phabricator.kde.org/D20786

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, #plasma, hein, davidedmundson
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20584: ProcessList: add NoNewPrivileges

2019-05-18 Thread Topi Miettinen 
This revision was automatically updated to reflect the committed changes.
Closed by commit R106:892c895bda83: ProcessList: add NoNewPrivileges (authored 
by topimiettinen).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20584?vs=56322=58243

REVISION DETAIL
  https://phabricator.kde.org/D20584

AFFECTED FILES
  ksysguardd/Linux/ProcessList.c

To: topimiettinen, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20853: ProcessList: show SELinux context

2019-05-18 Thread Topi Miettinen 
topimiettinen added a comment.


  Like D20854 , this should be also 
applicable to AppArmor.

REPOSITORY
  R106 KSysguard

BRANCH
  processlist-add-cgroup

REVISION DETAIL
  https://phabricator.kde.org/D20853

To: topimiettinen, davidedmundson
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20854: process: show SELinux context

2019-05-18 Thread Topi Miettinen 
topimiettinen added a comment.


  I noticed that when the system uses AppArmor instead of SELinux, this also 
happens to show AppArmor profile and status. Then at least user facing bits 
should not be so SELinux oriented to avoid confusion. I suppose AppArmor is 
more widely used than SELinux.

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D20854

To: topimiettinen, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart