D22162: taskmanager: performance

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Don't do queries on unknown values.
  Don't create a KDesktopFile until we know we're going to need it

TEST PLAN
  Ran plasma with debugs, didn't see any regressions.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22162

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: apol, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10362: Change reveal password button logic

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, starbuck, 
plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22162: taskmanager: performance

[Nathaniel Graham]

ngraham added a comment.


  Not sure if it's related, but while you're at it, would you be able to also 
fix these errors when hovering over a pinned item:
  

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347:
 Unable to assign [undefined] to int

file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375:
 TypeError: Type error

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22162

To: apol, #plasma
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10362: Change reveal password button logic

[Noah Davis]

ndavis added a comment.


  -1 for the current version
  
  How am I supposed to type with 2 hands and see the password at the same time 
if I have to hold down the left mouse button?
  
  -0.75 for the previous version of the patch
  
  We normally show the action that will happen when a button is clicked. Why 
change the behavior here? The state is already know to the user simply by 
seeing that their password is exposed.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10362: Change reveal password button logic

[Noah Davis]

ndavis added a comment.


  In D10362#202435 , @starbuck wrote:
  
  > Would further be also likely more consistent with other toggles in the 
future, like imagined on mobile "wifi crossed out=disabled", etc.
  
  
  The difference between the WiFi toggle and the visibility toggle is that the 
WiFi toggle has a checkbox next to it while this doesn't.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10362: Change reveal password button logic

[Nathaniel Graham]

ngraham added a comment.


  I think the idea is that you're not supposed to be typing with the characters 
visible as you type because then anyone else who might be around could just see 
your password. If you're in an environment where security concerns are 
sufficiently low as to permit this, it would probably make more sense to not 
even set a password, or use auto-login.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22167: [plasma-workspace] Use new activities icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the new icon added in D22155 .
  F6948276: plasma-workspace Activities Icon Desktop Context Menu.png 

  F6948277: plasma-workspace Activities Icon KRunner.png 


TEST PLAN
  Open the desktop context menu and also search for "activity" in KRunner.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  use-new-activities-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22167

AFFECTED FILES
  runners/activities/activityrunner.cpp
  shell/shellcorona.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22168: [plasma-desktop] Use new activities icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the new icon added in D22155 .
  F6948267: plasma-desktop Activities Icon.png 


TEST PLAN
  Open the context menu of an activity pager and also add an activity manager 
widget.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22168

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/showActivityManager/package/contents/ui/main.qml
  applets/showActivityManager/package/metadata.desktop
  kcms/activities/imports/qml/activityDialog/components/IconChooser.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22169: [plasma-active-window-control] Use new activities icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the new icon added in D22155  and use 
an alternative icon for the "Buttons" category.
  F6948331: plasma-active-window-control Activities Icon.png 


TEST PLAN
  Open the context menu of the active window control widget and also open the 
widget settings.

REPOSITORY
  R884 Active Window Control Applet for Plasma

BRANCH
  use-new-activities-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22169

AFFECTED FILES
  package/contents/config/config.qml
  package/contents/ui/main.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22170: [latte-dock] Use new activities icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the new icon added in D22155 .
  F6948355: latte-dock Activities Icon.png 


TEST PLAN
  Open the Latte layout settings.

REPOSITORY
  R878 Latte Dock

BRANCH
  use-new-activities-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22170

AFFECTED FILES
  app/settings/settingsdialog.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Nathaniel Graham]

ngraham added a comment.


  That fixed my crash, yay!
  
  I see a UX issues with the Random mode though: since the list re-sorts itself 
randomly, it becomes harder to locale any given wallpaper in there (say, for 
the purposes of unchecking it). Also, when you scroll all the way to the bottom 
and then back up to the top, the order has changed to a new random order. While 
you're scrolling, the delegates are visible changing before your eyes. It's all 
a bit odd.
  
  I wonder if in the Random mode, we should just keep the view sorted 
alphabetically?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  In D22121#488479 , @ngraham wrote:
  
  > That fixed my crash, yay!
  >
  > I see a UX issues with the Random mode though: since the list re-sorts 
itself randomly, it becomes harder to locale any given wallpaper in there (say, 
for the purposes of unchecking it). Also, when you scroll all the way to the 
bottom and then back up to the top, the order has changed to a new random 
order. While you're scrolling, the delegates are visible changing before your 
eyes. It's all a bit odd.
  >
  > I wonder if in the Random mode, we should just keep the view sorted 
alphabetically?
  
  
  Yes I had the same thoughts about random. Another way would be to not resort 
the slides at all in the config view when you change it and alphabetically/how 
we get them when you open the config view. Either way I guess I will have to 
change `filterUncheckedSlides` to a generic `isUsedinConfig` to enable that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10362: Change reveal password button logic

[Noah Davis]

ndavis added a comment.


  In D10362#488389 , @ngraham wrote:
  
  > I think the idea is that you're not supposed to be typing with the 
characters visible as you type because then anyone else who might be around 
could just see your password.
  
  
  I understand this, but I think this is one of those cases where a marginal 
increase in security should take a backseat to usability. If one is afraid of 
others looking over their shoulder, they shouldn't use the reveal password 
button in the first place, regardless of how it functions. It's not like people 
can't quickly hide the password again if they already know about the button.
  
  > If you're in an environment where security concerns are sufficiently low as 
to permit this, it would probably make more sense to not even set a password, 
or use auto-login.
  
  I disagree. Just because you aren't likely to have someone looking over your 
shoulder, doesn't mean nobody will attempt to access your computer while you're 
not around.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D10362: Change reveal password button logic

[Nathaniel Graham]

ngraham added a comment.


  In D10362#488571 , @ndavis wrote:
  
  > In D10362#488389 , @ngraham 
wrote:
  >
  > > I think the idea is that you're not supposed to be typing with the 
characters visible as you type because then anyone else who might be around 
could just see your password.
  >
  >
  > I understand this, but I think this is one of those cases where a marginal 
increase in security should take a backseat to usability. It's not like people 
can't quickly hide the password again if they already know about the button. If 
one is afraid of others looking over their shoulder, they shouldn't use the 
reveal password button in the first place, regardless of how it functions.
  
  
  Yeah, I guess that makes sense.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  change-reveal-password-button-logic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D10362

To: GB_2, #plasma, #vdg, ngraham, broulik
Cc: ndavis, kde-frameworks-devel, rizzitello, elvisangelaccio, ngraham, 
starbuck, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, michaelh, ZrenBot, bruns, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[Nathaniel Graham]

ngraham added a comment.


  Yeah maybe we should always show them in alphabetical order, or maybe we 
should show them in alphabetical order just for the alphabetical and random 
modes?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

[David Redondo]

davidre added a comment.


  Ah I forgot a word there.
  I wanted to say don't change the current order if the sort order is switched 
to random. And when opened and the current mode is random whatever.
  Displaying the order for the other modes is quite good I think.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22121

To: davidre, #plasma
Cc: ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22176: Rework system tray settings

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The current system tray settings has two pages with two slightly different 
lists. The first page shows a list of all available plasmoids and allows to 
en/disable them.
  The second list shows the in the previous page enabled plasmoids plus the 
available statusnotifieritems and offers configuration (visibility and 
shortcuts for plasmoids).
  
  This patch combines both into a single list. Therefor it:
  
  - Has a new model that holds both plasmoids and SNIs
  - Replaces the QQC1 Tableview with a ListView + Rowlayout
  - Adds an entry 'Disabled' to the visibility combobox to disable plasmoids 
(functionality from the former first list)
  - Removes the old 'General' page
  
  This removes the ability to (de-)select entire categories, but I don't 
consider this a particularly useful feature. The categories are intransparent 
to the user and the individual elements can still be en/disabled
  
  Currently it has a slight visual bug. The scrollbar overlaps the shortcut 
clear buttons. Help to resolve this is welcome
  
  BUG: 360307
  BUG: 397950

TEST PLAN
  Open system tray. Change the visibility of a plasmoid. Apply. Verify 
visibility in system tray. Add a shortcut to plasmoid. Verify shortcut

REPOSITORY
  R120 Plasma Workspace

BRANCH
  systray

REVISION DETAIL
  https://phabricator.kde.org/D22176

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/entrymodel.cpp
  applets/systemtray/entrymodel.h
  applets/systemtray/package/contents/config/config.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h

To: nicolasfella, #plasma, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22176: Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  Nice!!!
  
  Let's give the scrollview that holds this list a visible frame, like we did 
in the Purpose job dialog. Also maybe rename the "General" tab to say "Entries" 
since that's all there is there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22128: [Kickoff] Redo tab bar separator's geometry

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  In D22128#487965 , @ndavis wrote:
  
  > Sorry, my bad once again. I hadn't actually applied D22108 
. It works for me now. The tab highlight 
width problem must be somewhere else since this patch didn't introduce that bug.
  
  
  Oh, I must have made the same mistake, because upon trying again it now works.
  
  We should also make the tab highlight look like the new style in T11124 
. :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-tabbarseparator-geometr (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22128

To: filipf, #plasma, #vdg, ndavis, ngraham
Cc: ngraham, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21510: Filter KNewStuff Plasma Themes by Download Tag

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yep, seems to work and makes sense. Let's get this in so we can start tagging 
things.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  filter-themes-by-download-tags (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21510

To: leinir, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22178: [mobile/wifi] Fix some qml warnings in ConnectionItemDelegate

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Using anchors on items managed by layouts is undefined behaviour.
  
  This fixes a few warnings and also improves the visual appearance

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  warnings

REVISION DETAIL
  https://phabricator.kde.org/D22178

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml

To: nicolasfella, #plasma, bshah, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22179: [mobile/wifi] Move network en/disable into main action

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  The current switch at the top is both not very visually appealing and 
violates the Kirigami principle of putting relevant controls on the bottom 
where they are easily reachable

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  networklist

REVISION DETAIL
  https://phabricator.kde.org/D22179

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkListView.qml

To: nicolasfella, #vdg, #plasma, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Tipping the apple cart?

[Valorie Zimmerman]

Hello folks, as you know, I'm not a coder. However, I'm interested in our
code quality, and there has been some observation that "lots of patches get
missed, and submitters get confused due to a lack of auto-populated
reviewers" on Phabricator. Nate Graham has been adding groups to the
reviewers by hand, and would like to not do that any more.

However, many developers simply route all Phab emails to folders where they
sit unread, because Phab sends out an email for every event and comment!
This is far too spammy. In our move to Gitlab, we can do better. Right now,
the devel email lists get these emails -- but it is assumed that they are
often not read, because of the number of patches sitting unreviewed, and
unused. This is bad for our community, and very discouraging to newcomers.
One of our best recent initiatives has been the improve our onboarding
process, and this needs to be part of it.

Improving the workflow on Phabricator is almost pointless, since we're
leaving it. However, please give your ideas, thoughts and even opinions on
how best to improve this in Gitlab. I think if we engineer this well, we
can get more newbie contributors and more new *reviewers.*

I'm ok with starting Yet Another discussion which threatens to tip the
apple cart, because right now, the apples are already on the ground,
rotting.

Valorie

-- 
http://about.me/valoriez - pronouns: she/her

D22106: [Separator] Match Breeze borders' color

[Filip Fila]

filipf added a comment.


  In D22106#487287 , @mglb wrote:
  
  > Widgets style: 
https://cgit.kde.org/breeze.git/tree/kstyle/breezehelper.cpp#n76
  >
  > Qtquickcontrols style is pretty inconsistent and uses 0.2, 0.25, 0.3 alpha 
and either color mixing or transparent text color.
  
  
  Hmm I tried to copy that code and it also produced good results with Breeze 
and Breeze Dark, but could be way off with other themes.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D22106

To: filipf, #kirigami, #vdg, ngraham
Cc: ndavis, mglb, apol, plasma-devel, fbampaloukas, domson, dkardarakos, 
davidedmundson, mart, hein

D22180: [mobile/wifi] Use default height for ConnectionItemDelegate

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Using the default height of SwipeListItem gives a more sensible and 
consistent with other lists look

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  height

REVISION DETAIL
  https://phabricator.kde.org/D22180

AFFECTED FILES
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml

To: nicolasfella, #plasma, #vdg, jgrulich
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22181: Fix typo in documentation

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22181

AFFECTED FILES
  src/controls/ApplicationItem.qml

To: nicolasfella, mart
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22181: Fix typo in documentation

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e508c78fbdb9: Fix typo in documentation (authored by 
nicolasfella).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22181?vs=60895&id=60897

REVISION DETAIL
  https://phabricator.kde.org/D22181

AFFECTED FILES
  src/controls/ApplicationItem.qml

To: nicolasfella, mart, ngraham
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein

D22179: [mobile/wifi] Move network en/disable into main action

[Nathaniel Graham]

ngraham added a comment.


  +1 for porting to use the correct Kirigami paradigm.
  
  I feel like trying to do this exposes problems with our general general style 
(toggle-able toolbar button don't have a special appearance to indicate this) 
as well as the "floating text-less button" paradigm for mobile (same problem, 
plus the lack of text makes it even harder to tell what it's going to do for 
semi-complex actions). I won't block it, but the matter might require more 
discussion.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22179

To: nicolasfella, #vdg, #plasma, jgrulich, mkacej
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22179: [mobile/wifi] Move network en/disable into main action

[Nicolas Fella]

nicolasfella added a comment.


  In D22179#488748 , @ngraham wrote:
  
  > +1 for porting to use the correct Kirigami paradigm.
  >
  > I feel like trying to do this exposes problems with our general general 
style (toggle-able toolbar button don't have a special appearance to indicate 
this) as well as the "floating text-less button" paradigm for mobile (same 
problem, plus the lack of text makes it even harder to tell what it's going to 
do for semi-complex actions). I won't block it, but the matter might require 
more discussion.
  
  
  I agree. I'm not particularly happy with the current solution

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22179

To: nicolasfella, #vdg, #plasma, jgrulich, mkacej
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22179: [mobile/wifi] Move network en/disable into main action

[Nathaniel Graham]

ngraham added a comment.


  I kind of feel like on mobile, the toolbar itself should just move to the 
bottom. No need to use a whole new paradigm of floating text-less buttons that 
obscure the content and don't have labels. I know this is basically copied from 
Android, but I don't really like it there either. It just seems like an 
over-complicated and over-designed solution to a simple problem.
  
  Anyway, I'll shut up now, and we should have that discussion somewhere else, 
not in the comments section of your patch here. :)

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D22179

To: nicolasfella, #vdg, #plasma, jgrulich, mkacej
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg added a comment.


  In D10750#486570 , @romangg wrote:
  
  > Multi-plane support is needed. See @fredrik's inline comment on how to do 
that:
  >
  > > We would need to create a separate EGL image and a separate texture for 
each plane.
  > >  The scene would need to bind each of those textures to separate texture 
binding points, and we would need to generate and use a shader that samples 
texels from each plane and performs YUV to RGB conversion.
  
  
  Going through Weston's code this seems only true for original multi-plane 
formats, but not for dma-bufs with multiple planes via modifier.
  See: 
https://gitlab.freedesktop.org/wayland/weston/blob/5d7877adfd31956bdad98da4a937059260da1f69/libweston/renderer-gl/gl-renderer.c#L2291
  
  While allowing multi-plane for the former would involve some more fundamental 
changes to KWin since we when need to save multiple textures per WindowPixmap, 
doing the modifier multi-plane it seems we just receive a single EGLImage which 
we can then texture from. At least the following revision works with both 
`weston-simple-dmabuf-egl` and `weston-simple-dmabuf-drm`. And session starts 
including XWayland (didn't work before).

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D10750

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart

D10750: wayland: Add support for zwp_linux_dmabuf

[Roman Gilg]

romangg updated this revision to Diff 60898.
romangg added a comment.


  - Import dma-bufs with multi-plane via modifier

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10750?vs=60655&id=60898

BRANCH
  dmaBuf

REVISION DETAIL
  https://phabricator.kde.org/D10750

AFFECTED FILES
  platformsupport/scenes/opengl/CMakeLists.txt
  platformsupport/scenes/opengl/abstract_egl_backend.cpp
  platformsupport/scenes/opengl/abstract_egl_backend.h
  platformsupport/scenes/opengl/drm_fourcc.h
  platformsupport/scenes/opengl/linux_dmabuf.cpp
  platformsupport/scenes/opengl/linux_dmabuf.h

To: romangg, #kwin, #plasma, davidedmundson, mart, graesslin, fredrik
Cc: meven, zzag, romangg, anthonyfieroni, plasma-devel, kwin, LeGast00n, 
sbergeron, jraleigh, fbampaloukas, GB_2, mkulinski, ragreen, jackyalcine, 
Pitel, iodelay, crozbo, bwowk, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart