D22191: Implement syncing of theme preferences between SDDM and Plasma

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> kcm_sddm.actions:301
> +Name=Sync Settings
> +Description=Syncs user settings with SDDM settings
> +Policy=auth_admin

I think the long form of sync would be better in the description: Synchronizes

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> advanceconfig.ui:226
> +   
> +
> + 

It would be nice if you added the icon `view-refresh` to this button...

> advanceconfig.ui:233
> +   
> +
> + 

...and here the icon `document-revert` or `edit-undo`.

> advanceconfig.ui:256
> +   
> +Settings synchronization allows you to transfer you theme 
> customization (color scheme, font, font rendering, desktop and icon theme) to 
> SDDM.
> 

you theme -> your theme
desktop -> Plasma

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Björn Feber]

GB_2 added a comment.


  In D22191#489838 , @ndavis wrote:
  
  > > Settings UI:
  > >  F6953661: Screenshot_20190701_234413.png 

  >
  > This control layout seems to imply that a user must press the "Sync" button 
every time they change their user settings.
  >
  > Wouldn't a checkbox for continual synchronization and a button for 
resetting make more sense?
  
  
  I think then you would have to type in your password every time you change a 
setting.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: GB_2, ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Noah Davis]

ndavis added a comment.


  > Settings UI:
  >  F6953661: Screenshot_20190701_234413.png 

  
  This control layout seems to imply that a user must press the "Sync" button 
every time they change their user settings.
  
  Wouldn't a checkbox for continual synchronization and a button for resetting 
make more sense?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Tipping the apple cart?

[Valorie Zimmerman]

Please lets keep in mind that this is not a thread to complain about
Gitlab. No platform is perfect, and we're not yet on production machines.

This thread is about how to make our review process great for both newbies
and experienced developers, *and reviewers* - on Gitlab.

On Sun, Jun 30, 2019 at 2:53 PM Valorie Zimmerman <
valorie.zimmer...@gmail.com> wrote:

> Hello folks, as you know, I'm not a coder. However, I'm interested in our
> code quality, and there has been some observation that "lots of patches get
> missed, and submitters get confused due to a lack of auto-populated
> reviewers" on Phabricator. Nate Graham has been adding groups to the
> reviewers by hand, and would like to not do that any more.
>
> However, many developers simply route all Phab emails to folders where
> they sit unread, because Phab sends out an email for every event and
> comment! This is far too spammy. In our move to Gitlab, we can do better.
> Right now, the devel email lists get these emails -- but it is assumed that
> they are often not read, because of the number of patches sitting
> unreviewed, and unused. This is bad for our community, and very
> discouraging to newcomers. One of our best recent initiatives has been the
> improve our onboarding process, and this needs to be part of it.
>
> Improving the workflow on Phabricator is almost pointless, since we're
> leaving it. However, please give your ideas, thoughts and even opinions on
> how best to improve this in Gitlab. I think if we engineer this well, we
> can get more newbie contributors and more new *reviewers.*
>
> I'm ok with starting Yet Another discussion which threatens to tip the
> apple cart, because right now, the apples are already on the ground,
> rotting.
>
> Valorie
>

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[David Edmundson]

davidedmundson added a comment.


  Yeah, I understand the situation.
  
  
  
  LightDM (when I worked on it at least) used to support the Icon property in 
the .desktop file. 
  That'd be a quick and easy way to add an extra clarification on which one is 
wayland in the short term.
  
  -
  
  Unless you get an SDDM release exactly in sync with the Plasma change, you 
still have "(wayland)" twice or potentially never.
  
  This patch only helps with the case where SDDM is updated first, but the UX 
is messy as the additional qualifier moves, which is very confusing. And it'll 
end up staying there forever just to solve a few weeks of hypothetics crossover.
  
  Given we need to do something horrific, the other option is we patch our 
.desktop file right now and then just manipulate the text to remove one 
"(wayland)" if needed. That's at least atomic, and then we can patch SDDM at 
our leisure later.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22223: Seek to end as mpris next action

[Markus Ebner]

seijikun created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
seijikun requested review of this revision.

REVISION SUMMARY
  Most pages where the mpris functionality is used will probably have an 
auto-continue feature for when the end of a media is reached.
  Now, if mpris sends the next-signal, seeking to the end of the video is 
probably the most reliable way of continuing to the next in line.
  Works like a charm on YouTube.
  
  Sorry if anything is wrong, this is my first contribution.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D3

AFFECTED FILES
  extension/content-script.js

To: seijikun
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 61015.
davidedmundson marked an inline comment as done.
davidedmundson added a comment.


  whitespace

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=61014=61015

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  libkworkspace/CMakeLists.txt
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Shutdown.xml
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D21995: Split ksmserver into a small application that handles startup and ksmserver

[David Edmundson]

davidedmundson updated this revision to Diff 61014.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21995?vs=60421=61014

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21995

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/autostart.cpp
  ksmserver/autostart.h
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.KSMServerInterface.xml
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h
  ksmserver/startup.cpp
  ksmserver/startup.h
  libkworkspace/CMakeLists.txt
  startkde/CMakeLists.txt
  startkde/plasma-session/CMakeLists.txt
  startkde/plasma-session/autostart.cpp
  startkde/plasma-session/autostart.h
  startkde/plasma-session/main.cpp
  startkde/plasma-session/org.kde.Shutdown.xml
  startkde/plasma-session/org.kde.Startup.xml
  startkde/plasma-session/shutdown.cpp
  startkde/plasma-session/shutdown.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma.cpp

To: davidedmundson, #plasma
Cc: apol, bshah, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D19389: Rewrite kworkspace logout, shutdown and suspend API

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:cd3e9a291a66: Rewrite kworkspace logout, shutdown and 
suspend API (authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19389?vs=60969=61013#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19389?vs=60969=61013

REVISION DETAIL
  https://phabricator.kde.org/D19389

AFFECTED FILES
  libkworkspace/CMakeLists.txt
  libkworkspace/kworkspace.cpp
  libkworkspace/kworkspace.h
  libkworkspace/kworkspace_p.h
  libkworkspace/login1_manager_interface.cpp
  libkworkspace/loginddbustypes.h
  libkworkspace/org.freedesktop.ConsoleKit.Manager.xml
  libkworkspace/org.freedesktop.UPower.xml
  libkworkspace/org.freedesktop.login1.Manager.xml
  libkworkspace/org.freedesktop.login1.Seat.xml
  libkworkspace/org.freedesktop.login1.Session.xml
  libkworkspace/org.freedesktop.login1.User.xml
  libkworkspace/sessionmanagement.cpp
  libkworkspace/sessionmanagement.h
  libkworkspace/sessionmanagementbackend.cpp
  libkworkspace/sessionmanagementbackend.h
  libkworkspace/tests/CMakeLists.txt
  libkworkspace/tests/sessiontest.cpp

To: davidedmundson, #plasma, broulik
Cc: pino, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D19389: Rewrite kworkspace logout, shutdown and suspend API

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> loginddbustypes.h:105
> +{
> +public:
> +uint userId;

It's a `struct` already

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19389

To: davidedmundson, #plasma, broulik
Cc: pino, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22162: taskmanager: performance

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:50c391cc6c1b: taskmanager: performance (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22162?vs=60854=61012

REVISION DETAIL
  https://phabricator.kde.org/D22162

AFFECTED FILES
  libtaskmanager/tasktools.cpp

To: apol, #plasma, hein
Cc: hein, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22162: taskmanager: performance

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  In D22162#488378 , @ngraham wrote:
  
  > Not sure if it's related, but while you're at it, would you be able to also 
fix these errors when hovering over a pinned item:
  >
  >   
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347:
 Unable to assign [undefined] to int
  >   
file:///home/nate/kde/usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375:
 TypeError: Type error
  >
  
  
  They're not related, so shouldn't be handled in this review (see also fregl's 
patches).

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22162

To: apol, #plasma, hein
Cc: hein, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22214: doc: Some different phrasing, one instance of s/KDE/Plasma/

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added projects: Plasma, Documentation.
Herald added subscribers: kde-doc-english, plasma-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22214

AFFECTED FILES
  doc/kcontrol/autostart/index.docbook

To: asturmlechner, #plasma
Cc: plasma-devel, kde-doc-english, LeGast00n, jraleigh, gennad, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22213: [Tab] Fix sizing

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Repliaces `QTabBar::tabSizeHint` for desktop style. Not every style 
implements custom size hints for tabs, where it would just fall through to 
returning `sizeFromContents` as it is passed in, leading to tiny tabs.
  
  BUG: 409390

TEST PLAN
  Before (Breeze)
  F6956383: Screenshot_20190702_161243.png 

  Before (Fusion, slightly broken, we might not take into account the vertical 
offset for inactive tabs?)
  F6956385: Screenshot_20190702_161253.png 

  Before (Kvantum, hideous as usual)
  F6956389: Screenshot_20190702_161302.png 

  Before (QtCurve, unusable)
  F6956390: Screenshot_20190702_161344.png 

  
  After (Breeze, no change)
  F6956391: Screenshot_20190702_161209.png 

  After (Fusion, more correct now, doesn't fall back to 2 * grid unit anymore)
  F6956392: Screenshot_20190702_161140.png 

  After (Kvantum, even more hideous)
  F6956395: Screenshot_20190702_161159.png 

  After (QtCurve, now mostly correct, not sure why the width is off)
  F6956397: Screenshot_20190702_161149.png 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D22213

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Fabian Vogt]

fvogt added a comment.


  This is a necessary step to avoid having two indistinguishable "Plasma" 
options in SDDM with the linked PR merged and all other DMs , the other option 
is to have a "Plasma (Wayland) (Wayland)" in sddm only.
  
  AFAICT the translations for Name need to be removed though as they're wrong 
now.
  
  In openSUSE downstream we could do it the other way as we can change sddm and 
plasma-workspace simultaneously, so we have "Plasma" and "Plasma (Wayland)" in 
the desktop files with sddm not adding any suffix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: fvogt, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22212: change username labels to e-mail address instead

[Harald Sitter]

sitter created this revision.
sitter added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  users in bugzilla are always identified by their email address so it makes
  no sense to label the input username.
  
  calling it email address is also consistent with the bugzilla webui itself.
  
  that said, we actually spell it inconstantly email or e-mail across
  software. the most prominent cases in kdepim though spell it
  "E-mail Address" for input labels. so, going with that
  
  for ease of reading I'm leaving the code variables and the likes to say
  username as this more obviously ties to the related password variables.
  
  BUG: 375462
  FIXED-IN: 5.17.0

TEST PLAN
  login page now has an email address label

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22212

AFFECTED FILES
  src/aboutbugreportingdialog.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/ui/assistantpage_bugzilla_login.ui

To: sitter, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> davidedmundson wrote in advanceconfig.cpp:179
> If it's empty, you print a message, which is fine, but then we still add an 
> empty entry to our map, and still try to copy the file?

Should I just bring back the code that only does the copy operation if the 
entry is not empty or would it also be good to not even add the entry to the 
map if there is no file/folder?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22190: auto log in if username and password have been loaded from kwallet

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:add2ad75e362: auto log in if username and password have 
been loaded from kwallet (authored by sitter).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22190?vs=60933=61000#toc

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22190?vs=60933=61000

REVISION DETAIL
  https://phabricator.kde.org/D22190

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h

To: sitter, #plasma, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/14/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 02 Jul 2019 11:39:47 +
 Build duration:
5 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 223 lines...][2019-07-02T11:45:00.500Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-02T11:45:00.500Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-02T11:45:00.500Z] PROCESSOR_LEVEL   = '6'[2019-07-02T11:45:00.500Z] PROCESSOR_REVISION= '5e03'[2019-07-02T11:45:00.500Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-02T11:45:00.500Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-02T11:45:00.500Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-02T11:45:00.500Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-02T11:45:00.500Z] PROMPT= '$P$G'[2019-07-02T11:45:00.500Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-02T11:45:00.500Z] PUBLIC= 'C:\Users\Public'[2019-07-02T11:45:00.500Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/14/display/redirect?page=changes'[2019-07-02T11:45:00.500Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/14/display/redirect'[2019-07-02T11:45:00.500Z] STAGE_NAME= 'Configuring Build'[2019-07-02T11:45:00.500Z] SYSTEMDRIVE   = 'C:'[2019-07-02T11:45:00.500Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-02T11:45:00.500Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-02T11:45:00.500Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-02T11:45:00.500Z] UCRTVERSION   = '10.0.17763.0'[2019-07-02T11:45:00.500Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-02T11:45:00.500Z] USERDOMAIN= 'DESKTOP-66R8QOQ'[2019-07-02T11:45:00.500Z] USERNAME  = 'Jenkins'[2019-07-02T11:45:00.500Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-02T11:45:00.500Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-02T11:45:00.500Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-02T11:45:00.500Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-02T11:45:00.500Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-02T11:45:00.500Z] VCTOOLSVERSION= '14.16.27023'[2019-07-02T11:45:00.500Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-02T11:45:00.500Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-02T11:45:00.500Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-02T11:45:00.500Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-02T11:45:00.500Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-02T11:45:00.500Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-02T11:45:00.500Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-02T11:45:00.500Z] VSCMD_VER = '16.0.3'[2019-07-02T11:45:00.500Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-02T11:45:00.500Z] WINDIR= 'C:\WINDOWS'[2019-07-02T11:45:00.500Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-02T11:45:00.500Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-02T11:45:00.500Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-02T11:45:00.500Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-02T11:45:00.500Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-02T11:45:00.500Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-02T11:45:00.500Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\stable-kf5-qt5 WindowsMSVCQt5.11'[2019-07-02T11:45:00.500Z] __DOTNET_ADD_64BIT= '1'[2019-07-02T11:45:00.500Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-02T11:45:00.500Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program 

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 47 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/47/
 Project:
kf5-qt5 WindowsMSVCQt5.11
 Date of build:
Tue, 02 Jul 2019 11:39:50 +
 Build duration:
4 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 220 lines...][2019-07-02T11:44:14.992Z] PROCESSOR_ARCHITECTURE= 'AMD64'[2019-07-02T11:44:14.992Z] PROCESSOR_IDENTIFIER  = 'Intel64 Family 6 Model 94 Stepping 3, GenuineIntel'[2019-07-02T11:44:14.992Z] PROCESSOR_LEVEL   = '6'[2019-07-02T11:44:14.992Z] PROCESSOR_REVISION= '5e03'[2019-07-02T11:44:14.992Z] PROGRAMDATA   = 'C:\ProgramData'[2019-07-02T11:44:14.992Z] PROGRAMFILES  = 'C:\Program Files'[2019-07-02T11:44:14.992Z] PROGRAMFILES(X86) = 'C:\Program Files (x86)'[2019-07-02T11:44:14.992Z] PROGRAMW6432  = 'C:\Program Files'[2019-07-02T11:44:14.992Z] PROMPT= '$P$G'[2019-07-02T11:44:14.992Z] PSMODULEPATH  = 'C:\WINDOWS\system32\WindowsPowerShell\v1.0\Modules\'[2019-07-02T11:44:14.992Z] PUBLIC= 'C:\Users\Public'[2019-07-02T11:44:14.992Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/47/display/redirect?page=changes'[2019-07-02T11:44:14.992Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/47/display/redirect'[2019-07-02T11:44:14.992Z] STAGE_NAME= 'Configuring Build'[2019-07-02T11:44:14.993Z] SYSTEMDRIVE   = 'C:'[2019-07-02T11:44:14.993Z] SYSTEMROOT= 'C:\WINDOWS'[2019-07-02T11:44:14.993Z] TEMP  = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-02T11:44:14.993Z] TMP   = 'C:\Users\Jenkins\AppData\Local\Temp'[2019-07-02T11:44:14.993Z] UCRTVERSION   = '10.0.17763.0'[2019-07-02T11:44:14.993Z] UNIVERSALCRTSDKDIR= 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-02T11:44:14.993Z] USERDOMAIN= 'DESKTOP-UA3NMTP'[2019-07-02T11:44:14.993Z] USERNAME  = 'Jenkins'[2019-07-02T11:44:14.993Z] USERPROFILE   = 'C:\Users\Jenkins'[2019-07-02T11:44:14.993Z] VCIDEINSTALLDIR   = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\IDE\VC\'[2019-07-02T11:44:14.993Z] VCINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\'[2019-07-02T11:44:14.993Z] VCTOOLSINSTALLDIR = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Tools\MSVC\14.16.27023\'[2019-07-02T11:44:14.993Z] VCTOOLSREDISTDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC\Redist\MSVC\14.20.27508\'[2019-07-02T11:44:14.993Z] VCTOOLSVERSION= '14.16.27023'[2019-07-02T11:44:14.993Z] VISUALSTUDIOVERSION   = '16.0'[2019-07-02T11:44:14.993Z] VS140COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio 14.0\Common7\Tools\'[2019-07-02T11:44:14.993Z] VS160COMNTOOLS= 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\Common7\Tools\'[2019-07-02T11:44:14.993Z] VSCMD_ARG_APP_PLAT= 'Desktop'[2019-07-02T11:44:14.993Z] VSCMD_ARG_HOST_ARCH   = 'x64'[2019-07-02T11:44:14.993Z] VSCMD_ARG_TGT_ARCH= 'x64'[2019-07-02T11:44:14.993Z] VSCMD_ARG_VCVARS_VER  = '14.16'[2019-07-02T11:44:14.993Z] VSCMD_VER = '16.0.3'[2019-07-02T11:44:14.993Z] VSINSTALLDIR  = 'C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\'[2019-07-02T11:44:14.993Z] WINDIR= 'C:\WINDOWS'[2019-07-02T11:44:14.993Z] WINDOWSLIBPATH= 'C:\Program Files (x86)\Windows Kits\10\UnionMetadata\10.0.17763.0;C:\Program Files (x86)\Windows Kits\10\References\10.0.17763.0'[2019-07-02T11:44:14.993Z] WINDOWSSDKBINPATH = 'C:\Program Files (x86)\Windows Kits\10\bin\'[2019-07-02T11:44:14.993Z] WINDOWSSDKDIR = 'C:\Program Files (x86)\Windows Kits\10\'[2019-07-02T11:44:14.993Z] WINDOWSSDKLIBVERSION  = '10.0.17763.0\'[2019-07-02T11:44:14.993Z] WINDOWSSDKVERBINPATH  = 'C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\'[2019-07-02T11:44:14.993Z] WINDOWSSDKVERSION = '10.0.17763.0\'[2019-07-02T11:44:14.993Z] WORKSPACE = 'C:\CI\workspace\Plasma\drkonqi\kf5-qt5 WindowsMSVCQt5.11'[2019-07-02T11:44:14.993Z] __DOTNET_ADD_64BIT= '1'[2019-07-02T11:44:14.993Z] __DOTNET_PREFERRED_BITNESS = '64'[2019-07-02T11:44:14.993Z] __VSCMD_PREINIT_PATH  = 'C:\Program Files (x86)\Common Files\Oracle\Java\javapath;C:\Program Files\Python36-32\Scripts\;C:\Program Files\Python36-32\;C:\ProgramData\Oracle\Java\javapath;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\Program Files\Git\cmd;C:\WINDOWS\System32\OpenSSH\;C:\Users\Jenkins\AppData\Local\Microsoft\WindowsApps'[2019-07-02T11:44:14.993Z] 

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  Well, what's the current situation - SDDM have made the decision on their 
part to append that tech-garbage for Wayland sessions, users end up with:
  
  - Plasma
  - Plasma (Wayland)
  
  Per linked issue it is not going to be like that forever; on every(?) other 
DM, like lightdm, users can choose between:
  
  - Plasma
  - Plasma
  
  ...unless whatever downstream patching has been done to alleviate that issue. 
That's a real problem, not only because it relies on downstreams to do 
something, maybe not the right thing, and for users who do not know what to 
report when they have a problem entering a session (and frustration to decide 
which is which). Both choices will remain available in the foreseeable future.
  
  I'd like to get us to a situation where the session naming is consistent on 
all DMs, the SDDM hack can be dropped and no one needs to patch anything. 
`Plasma (Wayland)` would eventually become the default choice anyway, then be 
displayed just as `Plasma` if we don't do anything on our side and only fix 
SDDM.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22065: Introduce PluginManager

[Kai Uwe Broulik]

broulik updated this revision to Diff 60997.
broulik added a comment.


  - Also remove `pluginProtocolVersion`, can just call 
`AbstractBrowserPlugin::protocolVersion()`

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22065?vs=60996=60997

REVISION DETAIL
  https://phabricator.kde.org/D22065

AFFECTED FILES
  host/CMakeLists.txt
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/main.cpp
  host/pluginmanager.cpp
  host/pluginmanager.h
  host/settings.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22065: Introduce PluginManager

[Kai Uwe Broulik]

broulik updated this revision to Diff 60996.
broulik added a comment.


  - Operate on `AbstractBrowserPlugin *` exclusively
  - Cleanup

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22065?vs=60554=60996

REVISION DETAIL
  https://phabricator.kde.org/D22065

AFFECTED FILES
  host/CMakeLists.txt
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/main.cpp
  host/pluginmanager.cpp
  host/pluginmanager.h
  host/settings.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  This means most our normal users in an office who don't know/care if they're 
running X11 or wayland have some extra tech-garbage after the name.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner created this revision.
asturmlechner added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
asturmlechner requested review of this revision.

REVISION SUMMARY
  SDDM as of 0.18.1 appends " (Wayland)" to the Name of any session file it
  finds in wayland-sessions dir, and Plasma is relying on that behaviour to
  distinguish between its X11 and Wayland sessions. This leads to duplicate
  "Plasma" entries on any other DM not applying the same hack, e.g. lightdm,
  and users are lost without downstream patching.
  
  Instead of waiting for which of (SDDM, Plasma) is doing something about
  it first, renaming X11 session to "Plasma (X11)" appears to be the most
  elegant solution out of the deadlock. SDDM can be fixed any time later.
  
  CCBUG: https://bugs.kde.org/show_bug.cgi?id=368409
  See also: https://github.com/sddm/sddm/pull/997

REPOSITORY
  R120 Plasma Workspace

BRANCH
  session-rename

REVISION DETAIL
  https://phabricator.kde.org/D22210

AFFECTED FILES
  login-sessions/plasma.desktop.cmake

To: asturmlechner, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:54-55
> +{
> +KUser sddmUser(QStringLiteral("sddm"));
> +KUser sddmGroup(QStringLiteral("sddm"));
> +

do we need two objects representing the same user?

> advanceconfig.cpp:179
> +
> +if (fontconfigPath.isEmpty()) {
> +qDebug() << "fontconfig folder not found";

If it's empty, you print a message, which is fine, but then we still add an 
empty entry to our map, and still try to copy the file?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 60993.
filipf added a comment.


  remove 2 unused imports

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=60992=60993

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf marked an inline comment as done.
filipf added inline comments.

INLINE COMMENTS

> ngraham wrote in sddmauthhelper.cpp:37
> This change to alphabetize the includes is good, but should be done in 
> another commit (feel free to commit directly) as it doesn't directly pertain 
> to the changes here.

https://cgit.kde.org/sddm-kcm.git/commit/?id=edaae61c36de21dda224b3e40d9abc1d5e8c057a

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 60992.
filipf added a comment.


  get rid of KDevelop files that accidentally got added to the diff

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=60991=60992

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  kcm_sddm.actions
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22191: Implement syncing of theme preferences between SDDM and Plasma

[Filip Fila]

filipf updated this revision to Diff 60991.
filipf marked an inline comment as done.
filipf added a comment.


  - Merge branch 'master' into sddm-theme-syncing

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22191?vs=60978=60991

BRANCH
  sddm-theme-syncing (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22191

AFFECTED FILES
  SYNCINGsddm-kcm.kdev4
  kcm_sddm.actions
  sddm-kcm.kdev4
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h
  src/ui/advanceconfig.ui

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22208: Fix toolTipDelegate.virtualDesktopParent

[Frederik Gladhorn]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b7affafa425b: Fix toolTipDelegate.virtualDesktopParent 
(authored by gladhorn).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22208?vs=60987=60990

REVISION DETAIL
  https://phabricator.kde.org/D22208

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: gladhorn, #plasma, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22207: Silence qml error message

[Frederik Gladhorn]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d80d3aaebadf: Silence qml error message (authored by 
gladhorn).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22207?vs=60986=60989

REVISION DETAIL
  https://phabricator.kde.org/D22207

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: gladhorn, #plasma, broulik, hein
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21927: Use window.postMessage instead of creating a wrapper item

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:b1ea6f2de39a: Use window.postMessage instead of creating 
a wrapper item (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21927?vs=60186=60988

REVISION DETAIL
  https://phabricator.kde.org/D21927

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22208: Fix toolTipDelegate.virtualDesktopParent

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  The logic tried to do an early return, but that doesn't work with ||, so
  use && and check if there are >0 elements in the list, otherwise return
  a list containing only 0.
  
  This fixes a qml error message:
  
file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:375:
 TypeError: Type error

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22208

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: gladhorn, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22207: Silence qml error message

[Frederik Gladhorn]

gladhorn created this revision.
gladhorn added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gladhorn requested review of this revision.

REVISION SUMMARY
  model.AppPid is documented to not always exist, so use the same check
  that is used in othere places in the file.
  
file:///usr/share/plasma/plasmoids/org.kde.plasma.taskmanager/contents/ui/Task.qml:347:
 Unable to assign [undefined] to int

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22207

AFFECTED FILES
  applets/taskmanager/package/contents/ui/Task.qml

To: gladhorn, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D21968: Set desktopFileName

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:22a0e85e807d: Set desktopFileName (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D21968?vs=60251=60985#toc

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21968?vs=60251=60985

REVISION DETAIL
  https://phabricator.kde.org/D21968

AFFECTED FILES
  host/mprisplugin.cpp
  host/settings.cpp
  host/settings.h

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22068: Send downloads when downloads plugin is loaded

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:76d4b765f4f1: Send downloads when downloads plugin is 
loaded (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22068?vs=60557=60984

REVISION DETAIL
  https://phabricator.kde.org/D22068

AFFECTED FILES
  extension/extension.js
  host/downloadplugin.cpp
  host/downloadplugin.h

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

Re: notes for monday meeting 1/7/2019

[Jan Grulich]

Hi,

On pondělí 1. července 2019 12:43:15 CEST Marco Martin wrote:
> David:
> * at the plasma sprint
> * ok so, not only is Qt5.13.0 wayland completely broken
> so is 5.12.4
> * I've fixed all upstream, but I'll need to do some work with
> packagers to avoid this becoming an issue I think.
> * SHM buffers after show/restore  due to one bug (so all QMenus)
> * And QtQuick buffers after show/restore (due to another bug!) that's
> something unrelated due to the SRGB stuf

David, do you plan to drop an email to the packagers list about this ? We had 
same problem in Fedora and I saw your patches on review so I backported them. 
The issue introduced in Qt 5.12.4 / 5.13.0 with the menus not appearing again 
or Yakuake or Spectacle not showing is pretty annoying.

Here are all patches picked from current 5.12 branch or from your reviews. 
https://src.fedoraproject.org/rpms/qt5-qtwayland/tree/master

Regards,
Jan