KDE CI: Plasma » plymouth-kcm » stable-kf5-qt5 SUSEQt5.12 - Build # 21 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plymouth-kcm/job/stable-kf5-qt5%20SUSEQt5.12/21/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 11 Aug 2019 06:16:41 +
 Build duration:
5 min 44 sec and counting
   CONSOLE OUTPUT
  [...truncated 243 lines...][2019-08-11T06:22:07.634Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/plymouth-kcm/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-08-11T06:22:07.634Z] WORKSPACE = '/home/jenkins/workspace/Plasma/plymouth-kcm/stable-kf5-qt5 SUSEQt5.12'[2019-08-11T06:22:07.634Z] HUDSON_URL= 'https://build.kde.org/'[2019-08-11T06:22:07.634Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-08-11T06:22:07.634Z] NODE_NAME = 'Docker Swarm-cb4b269b44e3'[2019-08-11T06:22:07.634Z] HOST  = 'cb4b269b44e3'[2019-08-11T06:22:07.634Z] LESSOPEN  = 'lessopen.sh %s'[2019-08-11T06:22:07.634Z] USER  = 'jenkins'[2019-08-11T06:22:07.634Z] MORE  = '-sl'[2019-08-11T06:22:07.634Z] CSHEDIT   = 'emacs'[2019-08-11T06:22:07.634Z] SHLVL = '2'[2019-08-11T06:22:07.634Z] BUILD_TAG = 'jenkins-Plasma-plymouth-kcm-stable-kf5-qt5 SUSEQt5.12-21'[2019-08-11T06:22:07.634Z] WINDOWMANAGER = 'xterm'[2019-08-11T06:22:07.634Z] PAGER = 'less'[2019-08-11T06:22:07.634Z] EXECUTOR_NUMBER   = '0'[2019-08-11T06:22:07.634Z] CVS_RSH   = 'ssh'[2019-08-11T06:22:07.634Z] LIBGL_DEBUG   = 'quiet'[2019-08-11T06:22:07.634Z] STAGE_NAME= 'Configuring Build'[2019-08-11T06:22:07.634Z] NODE_LABELS   = 'Docker Swarm-cb4b269b44e3 SUSEQt5.12'[2019-08-11T06:22:07.634Z] XCURSOR_THEME = 'DMZ-Black'[2019-08-11T06:22:07.634Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-08-11T06:22:07.634Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-08-11T06:22:07.634Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-08-11T06:22:07.634Z] PROFILEREAD   = 'true'[2019-08-11T06:22:07.634Z] MAIL  = '/var/mail/jenkins'[2019-08-11T06:22:07.634Z] HOSTTYPE  = 'x86_64'[2019-08-11T06:22:07.634Z] BUILD_ID  = '21'[2019-08-11T06:22:07.634Z] LESSKEY   = '/etc/lesskey.bin'[2019-08-11T06:22:07.634Z] OLDPWD= '/home/jenkins'[2019-08-11T06:22:07.634Z] LC_CTYPE  = 'C.UTF-8'[2019-08-11T06:22:07.634Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-08-11T06:22:07.634Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-08-11T06:22:07.634Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-08-11T06:22:07.634Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-08-11T06:22:07.634Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-08-11T06:22:07.634Z] QT_SELECT = 'qt5'[2019-08-11T06:22:07.634Z] LANG  = 'en_US.UTF-8'[2019-08-11T06:22:07.634Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-08-11T06:22:07.634Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-08-11T06:22:07.634Z] [2019-08-11T06:22:07.634Z] [2019-08-11T06:22:07.634Z] == Commencing Configuration:[2019-08-11T06:22:07.634Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plymouth-kcm/stable-kf5-qt5 SUSEQt5.12"[2019-08-11T06:22:08.695Z] -- The C compiler identification is GNU 9.1.1[2019-08-11T06:22:08.695Z] -- The CXX compiler identification is GNU 9.1.1[2019-08-11T06:22:08.695Z] -- Check for working C compiler: /usr/bin/cc[2019-08-11T06:22:09.198Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-08-11T06:22:09.198Z] -- Detecting C compiler ABI info[2019-08-11T06:22:09.198Z] -- Detecting C compiler ABI info - done[2019-08-11T06:22:09.198Z] -- Detecting C compile features[2019-08-11T06:22:09.700Z] -- Detecting C compile features - done[2019-08-11T06:22:09.700Z] -- Check for working CXX compiler: /usr/bin/c++[2019-08-11T06:22:10.199Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-08-11T06:22:10.199Z] -- Detecting CXX compiler ABI info[2019-08-11T06:22:10.199Z] -- Detecting CXX compiler ABI info - done[2019-08-11T06:22:10.199Z] -- Detecting CXX compile features[2019-08-11T06:22:11.874Z] -- Detecting CXX compile features - done[2019-08-11T06:22:12.392Z] Installing in /home/j

D23082: Allow to set maximum volume < 100%

2019-08-10 Thread Kishore Gopalakrishnan
kishoreg created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kishoreg requested review of this revision.

REVISION SUMMARY
  Currently one cannot set the maximum volume < 100%. This feature is required 
because some earphones / speakers are more sensitive than others and may get 
damaged at high volumes. In particular, one easily ends up overshooting safe 
volume levels when using the mouse scroll wheel to change the volume. After 
this change, one can safely use the mouse wheel to change volume.
  
  BUG: 404387

TEST PLAN
  1. Right-click on applet > 'Configure audio volume'.
  2. Try to set maximum volume < 100% and click 'OK'.
  3. Scroill on the systray icon to change maximum volume. Check if it is 
limited to the configured maximum.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D23082

AFFECTED FILES
  applet/contents/ui/ConfigGeneral.qml

To: kishoreg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23081: remove references from the icon qrc to missing icons.

2019-08-10 Thread Camilo Higuita
camiloh created this revision.
camiloh added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
camiloh requested review of this revision.

REVISION SUMMARY
  this issue was affecting the building of app when using kirigami static linked

REPOSITORY
  R169 Kirigami

BRANCH
  qrc_missing_icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23081

AFFECTED FILES
  kirigami-icons.qrc

To: camiloh, #kirigami
Cc: plasma-devel, fbampaloukas, domson, dkardarakos, apol, davidedmundson, 
mart, hein


D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  TBH I don't like it with the standard Breeze color scheme--or any color 
scheme where the titlebar is a bold or highly contrasting color. The top part 
of the window starts to feel overwhelming IMO. I think it looks out of place 
with other windows where that area of color is much smaller.
  
  Could we make the tab bar background and inactive tabs have better contrast 
with the active tabs without going this far?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23080

To: cblack, #breeze, #vdg
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


KDE CI: Plasma » plymouth-kcm » kf5-qt5 SUSEQt5.12 - Build # 26 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plymouth-kcm/job/kf5-qt5%20SUSEQt5.12/26/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sun, 11 Aug 2019 02:58:41 +
 Build duration:
2 min 48 sec and counting
   CONSOLE OUTPUT
  [...truncated 241 lines...][2019-08-11T03:01:23.644Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/plymouth-kcm/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2019-08-11T03:01:23.644Z] WORKSPACE = '/home/jenkins/workspace/Plasma/plymouth-kcm/kf5-qt5 SUSEQt5.12'[2019-08-11T03:01:23.644Z] HUDSON_URL= 'https://build.kde.org/'[2019-08-11T03:01:23.644Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-08-11T03:01:23.644Z] NODE_NAME = 'Docker Swarm-e08a2e74cd58'[2019-08-11T03:01:23.644Z] HOST  = 'e08a2e74cd58'[2019-08-11T03:01:23.644Z] LESSOPEN  = 'lessopen.sh %s'[2019-08-11T03:01:23.644Z] USER  = 'jenkins'[2019-08-11T03:01:23.644Z] MORE  = '-sl'[2019-08-11T03:01:23.644Z] CSHEDIT   = 'emacs'[2019-08-11T03:01:23.644Z] SHLVL = '2'[2019-08-11T03:01:23.644Z] BUILD_TAG = 'jenkins-Plasma-plymouth-kcm-kf5-qt5 SUSEQt5.12-26'[2019-08-11T03:01:23.644Z] WINDOWMANAGER = 'xterm'[2019-08-11T03:01:23.644Z] PAGER = 'less'[2019-08-11T03:01:23.644Z] EXECUTOR_NUMBER   = '0'[2019-08-11T03:01:23.644Z] CVS_RSH   = 'ssh'[2019-08-11T03:01:23.644Z] LIBGL_DEBUG   = 'quiet'[2019-08-11T03:01:23.644Z] STAGE_NAME= 'Configuring Build'[2019-08-11T03:01:23.644Z] NODE_LABELS   = 'Docker Swarm-e08a2e74cd58 SUSEQt5.12'[2019-08-11T03:01:23.644Z] XCURSOR_THEME = 'DMZ-Black'[2019-08-11T03:01:23.644Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-08-11T03:01:23.644Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-08-11T03:01:23.644Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-08-11T03:01:23.644Z] PROFILEREAD   = 'true'[2019-08-11T03:01:23.644Z] MAIL  = '/var/mail/jenkins'[2019-08-11T03:01:23.644Z] HOSTTYPE  = 'x86_64'[2019-08-11T03:01:23.644Z] BUILD_ID  = '26'[2019-08-11T03:01:23.644Z] LESSKEY   = '/etc/lesskey.bin'[2019-08-11T03:01:23.644Z] OLDPWD= '/home/jenkins'[2019-08-11T03:01:23.644Z] LC_CTYPE  = 'C.UTF-8'[2019-08-11T03:01:23.644Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-08-11T03:01:23.644Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-08-11T03:01:23.644Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-08-11T03:01:23.644Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-08-11T03:01:23.644Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-08-11T03:01:23.644Z] QT_SELECT = 'qt5'[2019-08-11T03:01:23.644Z] LANG  = 'en_US.UTF-8'[2019-08-11T03:01:23.644Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-08-11T03:01:23.644Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-08-11T03:01:23.644Z] [2019-08-11T03:01:23.644Z] [2019-08-11T03:01:23.644Z] == Commencing Configuration:[2019-08-11T03:01:23.644Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/plymouth-kcm/kf5-qt5 SUSEQt5.12"[2019-08-11T03:01:23.644Z] -- The C compiler identification is GNU 9.1.1[2019-08-11T03:01:24.146Z] -- The CXX compiler identification is GNU 9.1.1[2019-08-11T03:01:24.146Z] -- Check for working C compiler: /usr/bin/cc[2019-08-11T03:01:24.146Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-08-11T03:01:24.146Z] -- Detecting C compiler ABI info[2019-08-11T03:01:24.649Z] -- Detecting C compiler ABI info - done[2019-08-11T03:01:24.649Z] -- Detecting C compile features[2019-08-11T03:01:24.649Z] -- Detecting C compile features - done[2019-08-11T03:01:24.649Z] -- Check for working CXX compiler: /usr/bin/c++[2019-08-11T03:01:25.149Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-08-11T03:01:25.149Z] -- Detecting CXX compiler ABI info[2019-08-11T03:01:25.149Z] -- Detecting CXX compiler ABI info - done[2019-08-11T03:01:25.149Z] -- Detecting CXX compile features[2019-08-11T03:01:26.809Z] -- Detecting CXX compile features - done[2019-08-11T03:01:26.809Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/w

D23080: [GTK3 -> Chrome/ium] Tweak tab stylings

2019-08-10 Thread Carson Black
cblack created this revision.
cblack added reviewers: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Tabs have had their colors changed to make it easier to tell which is active.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  chromium-tweaks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23080

AFFECTED FILES
  src/gtk3/applications/_chromium.scss
  src/gtk3/gtk.scss

To: cblack, #breeze, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D17464: [Timer applet] Minor fixes for the applet

2019-08-10 Thread Alexander Kernozhitsky
gepardo added a comment.


  Still waiting for the feedback.

REPOSITORY
  R114 Plasma Addons

BRANCH
  arcpatch-D17464

REVISION DETAIL
  https://phabricator.kde.org/D17464

To: gepardo, muhlenpfordt, mmazur, friedreich, #plasma, ngraham
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This also happens with Thunderbird too. I think we need to go back to the 
earlier version, come up with something different or fix Firefox itself. :/

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze, ngraham
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  And it really really really doesn't work with Wonton soup at all:
  
  F7203531: Screenshot_20190810_171455.png 


REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  With certain color schemes, this new style looks... special. :)
  
  Oxygen: F7203525: Oxygen.png 
  
  Honeycomb: F7203526: Honeycomb.png 

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  Hmm, now the rest of the tab bar and menubar backgrounds have started to use 
the titlebar color:
  
  F7203516: Screenshot_20190810_170538.png 

  
  It's not a terrible look, but I'm not sure it's intended...

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  Hmm, definitely looks better with CSDs, but with SSDs, this happens:
  
  F7203504: Screenshot_20190810_170312.png 

  
  I could live with the inactive tab titles getting lighter, but not the 
menubar.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: ngraham, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack updated this revision to Diff 63515.
cblack added a comment.


  Add background color to make SSD decorations more legible with patch

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23079?vs=63514&id=63515

BRANCH
  firefox-csd-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23079

AFFECTED FILES
  src/gtk3/applications/_firefox.scss
  src/gtk3/gtk.scss

To: cblack, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Vlad Zagorodniy
zzag added a comment.


  How does it look when Firefox has a server side-decoration?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D23079

To: cblack, #vdg, #breeze
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D23079: [GTK3] Fix Firefox's CSD colors, kinda

2019-08-10 Thread Carson Black
cblack created this revision.
cblack added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This fixes the CSD colors of Firefox to be more legible, but not without some 
caveats due to upstream issues.
  
  - The inactive titlebar foreground color is used regardless of window state.
  - #MozillaGtkWidget does not have any visible way to discriminate between CSD 
on and CSD off unlike normal GTK windows, so any style changes apply to both.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  firefox-csd-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23079

AFFECTED FILES
  src/gtk3/applications/_firefox.scss
  src/gtk3/gtk.scss

To: cblack, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23078: Remove persistence from the kauth helper

2019-08-10 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:2ce7ccd2dff8: Remove persistence from the kauth helper 
(authored by fvogt).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23078?vs=63511&id=63512

REVISION DETAIL
  https://phabricator.kde.org/D23078

AFFECTED FILES
  kcm_sddm.actions

To: fvogt, #plasma, davidedmundson, filipf, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22535: Make kimpanel a system tray applet

2019-08-10 Thread Yunhe Guo
guoyunhe added a comment.


  Making the layout of status panel:
  
  F7203378: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas


D23078: Remove persistence from the kauth helper

2019-08-10 Thread Fabian Vogt
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  The way the helper works allows everyone with access to elevate to root
  trivially, so persistence needs to be avoided.

TEST PLAN
  .policy file has auth_admin now.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23078

AFFECTED FILES
  kcm_sddm.actions

To: fvogt, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 added a comment.


  In D22896#509989 , @ngraham wrote:
  
  > Maybe the show most used action should go in a separate patch. This one 
feels like it's getting overloaded with too many different changes.
  
  
  Yeah, we that feature is also not ready yet, because it currently doesn't 
reset the sidebar selection.

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  Maybe the show most used action should go in a separate patch. This one feels 
like it's getting overloaded with too many different changes.

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Marco Martin
mart accepted this revision.
mart added a comment.


  Cool, tough I'm a bit hesitant on using qt.labs.platform as it may break any 
moment in any future release

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D22981: Minor code improvements

2019-08-10 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R123:c1c4e03b0003: Minor code improvements (authored by 
filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22981?vs=63250&id=63503

REVISION DETAIL
  https://phabricator.kde.org/D22981

AFFECTED FILES
  sddmauthhelper.cpp
  sddmauthhelper.h
  src/advanceconfig.cpp
  src/advanceconfig.h

To: filipf, davidedmundson, ngraham, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23063: [lockscreen] Fit album art to defined geometry

2019-08-10 Thread Filip Fila
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:953f72e42f6c: [lockscreen] Fit album art to defined 
geometry (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23063?vs=63453&id=63502

REVISION DETAIL
  https://phabricator.kde.org/D23063

AFFECTED FILES
  lookandfeel/contents/lockscreen/MediaControls.qml

To: filipf, #plasma, #vdg, ngraham
Cc: ndavis, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D22535: Make kimpanel a system tray applet

2019-08-10 Thread Yunhe Guo
guoyunhe added a comment.


  In D22535#509917 , @ngraham wrote:
  
  > Did you delete the old KCM first? If not, it will take precedence and you 
won't see the new one. The old one is located in the following location:
  >
  > - Ubuntu-based distros: `[install 
prefix]/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_keyboard.so`
  > - Other distros: `[install prefix]/usr/lib/qt/plugins/kcm_keyboard.so`
  >
  >   Regardless, I'm super excited to see @gpark's work get revived!
  
  
  No, I didn't know that. Thanks for the tip, will keep trying!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas


D22535: Make kimpanel a system tray applet

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  Did you delete the old KCM first? If not, it will take precedence and you 
won't see the new one. The old one is located in the following location:
  
  - Ubuntu-based distros: `[install 
prefix]/usr/lib/x86_64-linux-gnu/qt5/plugins/kcm_keyboard.so`
  - Other distros: `[install prefix]/usr/lib/qt/plugins/kcm_keyboard.so`
  
  Regardless, I'm super excited to see @gpark's work get revived!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas


D23064: Fix duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  Great job, @iasensio! May it be the first of many. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D23064

To: iasensio, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23043: Include xkb.h

2019-08-10 Thread Frederik Gladhorn
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5ea41a794f68: Include xkb.h (authored by gladhorn).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23043?vs=63402&id=63500

REVISION DETAIL
  https://phabricator.kde.org/D23043

AFFECTED FILES
  kcms/keyboard/x11_helper.cpp
  kcms/keyboard/x11_helper.h

To: gladhorn, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23042: When implementing assignment, also implement copy ctor

2019-08-10 Thread Frederik Gladhorn
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:937a0cedf227: When implementing assignment, also 
implement copy ctor (authored by gladhorn).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23042?vs=63401&id=63499

REVISION DETAIL
  https://phabricator.kde.org/D23042

AFFECTED FILES
  kcms/keyboard/xkb_rules.h

To: gladhorn, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


Re: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

2019-08-10 Thread Ben Cooksley
On Sat, Aug 10, 2019 at 4:36 PM Ömer Fadıl USTA  wrote:

> https://phabricator.kde.org/D22976
>

While that does appear to be the fix, please note that this build was for
the stable branch, and that fix is only in the master branch at the moment.
I guess it needs to be cherry-picked across?

Cheers,
Ben


>
>
> On Fri, Aug 9, 2019, 23:21 Ben Cooksley  wrote:
>
>> Hi folks,
>>
>> Could someone please look into the below QMutex include problem within
>> plasma-workspace?
>>
>> Thanks,
>> Ben
>>
>> -- Forwarded message -
>> From: CI System 
>> Date: Sat, Aug 10, 2019 at 8:18 AM
>> Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5
>> SUSEQt5.12 - Build # 46 - Still Failing!
>> To: 
>>
>>
>> *BUILD FAILURE*
>> Build URL
>> https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20SUSEQt5.12/46/
>> Project: Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12
>> Date of build: Fri, 09 Aug 2019 18:51:11 +
>> Build duration: 1 hr 26 min and counting
>> * CONSOLE OUTPUT *
>> [...truncated 94439 lines...]
>> [2019-08-09T20:18:04.390Z]
>> /home/jenkins/workspace/Administration/Dependency Build Plasma
>> stable-kf5-qt5
>> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:41:
>> warning: ���void
>> Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState,
>> QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
>> [2019-08-09T20:18:04.390Z] 259 |
>> Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState,
>> nullptr, nullptr);
>> [2019-08-09T20:18:04.390Z] | ^~~~
>> [2019-08-09T20:18:04.390Z] In file included from
>> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
>> [2019-08-09T20:18:04.390Z] from
>> /home/jenkins/workspace/Administration/Dependency Build Plasma
>> stable-kf5-qt5
>> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
>> [2019-08-09T20:18:04.390Z]
>> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40:
>> note: declared here
>> [2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void
>> requestSleep(SleepState state, QObject *receiver, const char *member);
>> [2019-08-09T20:18:04.390Z] | ^~~~
>> [2019-08-09T20:18:04.390Z]
>> /home/jenkins/workspace/Administration/Dependency Build Plasma
>> stable-kf5-qt5
>> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:110:
>> warning: ���void
>> Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState,
>> QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
>> [2019-08-09T20:18:04.390Z] 259 |
>> Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState,
>> nullptr, nullptr);
>> [2019-08-09T20:18:04.390Z] | ^
>> [2019-08-09T20:18:04.390Z] In file included from
>> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
>> [2019-08-09T20:18:04.390Z] from
>> /home/jenkins/workspace/Administration/Dependency Build Plasma
>> stable-kf5-qt5
>> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
>> [2019-08-09T20:18:04.390Z]
>> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40:
>> note: declared here
>> [2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void
>> requestSleep(SleepState state, QObject *receiver, const char *member);
>> [2019-08-09T20:18:04.390Z] | ^~~~
>> [2019-08-09T20:18:04.390Z]
>> /home/jenkins/workspace/Administration/Dependency Build Plasma
>> stable-kf5-qt5
>> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:110:
>> warning: ���void
>> Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState,
>> QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
>> [2019-08-09T20:18:04.390Z] 259 |
>> Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState,
>> nullptr, nullptr);
>> [2019-08-09T20:18:04.390Z] | ^
>> [2019-08-09T20:18:04.390Z] In file included from
>> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
>> [2019-08-09T20:18:04.390Z] from
>> /home/jenkins/workspace/Administration/Dependency Build Plasma
>> stable-kf5-qt5
>> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
>> [2019-08-09T20:18:04.390Z]
>> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40:
>> note: declared here
>> [2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void
>> requestSleep(SleepState state, QObject *receiver, const char *member);
>> [2019-08-09T20:18:04.390Z] | ^~~~
>> [2019-08-09T20:18:04.390Z]
>> /home/jenkins/workspace/Administration/Dependency Build Plasma
>> stable-kf5-qt5
>> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:253:16:
>> warning: enumeration value ���HybridSuspendState��� not handled in switch
>> [-Wswitch]
>> [2

Re: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

2019-08-10 Thread Ömer Fadıl USTA
https://phabricator.kde.org/D22976

On Fri, Aug 9, 2019, 23:21 Ben Cooksley  wrote:

> Hi folks,
>
> Could someone please look into the below QMutex include problem within
> plasma-workspace?
>
> Thanks,
> Ben
>
> -- Forwarded message -
> From: CI System 
> Date: Sat, Aug 10, 2019 at 8:18 AM
> Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5
> SUSEQt5.12 - Build # 46 - Still Failing!
> To: 
>
>
> *BUILD FAILURE*
> Build URL
> https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20SUSEQt5.12/46/
> Project: Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12
> Date of build: Fri, 09 Aug 2019 18:51:11 +
> Build duration: 1 hr 26 min and counting
> * CONSOLE OUTPUT *
> [...truncated 94439 lines...]
> [2019-08-09T20:18:04.390Z]
> /home/jenkins/workspace/Administration/Dependency Build Plasma
> stable-kf5-qt5
> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:41:
> warning: ���void
> Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState,
> QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
> [2019-08-09T20:18:04.390Z] 259 |
> Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState,
> nullptr, nullptr);
> [2019-08-09T20:18:04.390Z] | ^~~~
> [2019-08-09T20:18:04.390Z] In file included from
> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
> [2019-08-09T20:18:04.390Z] from
> /home/jenkins/workspace/Administration/Dependency Build Plasma
> stable-kf5-qt5
> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
> [2019-08-09T20:18:04.390Z]
> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40:
> note: declared here
> [2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void
> requestSleep(SleepState state, QObject *receiver, const char *member);
> [2019-08-09T20:18:04.390Z] | ^~~~
> [2019-08-09T20:18:04.390Z]
> /home/jenkins/workspace/Administration/Dependency Build Plasma
> stable-kf5-qt5
> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:110:
> warning: ���void
> Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState,
> QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
> [2019-08-09T20:18:04.390Z] 259 |
> Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState,
> nullptr, nullptr);
> [2019-08-09T20:18:04.390Z] | ^
> [2019-08-09T20:18:04.390Z] In file included from
> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
> [2019-08-09T20:18:04.390Z] from
> /home/jenkins/workspace/Administration/Dependency Build Plasma
> stable-kf5-qt5
> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
> [2019-08-09T20:18:04.390Z]
> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40:
> note: declared here
> [2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void
> requestSleep(SleepState state, QObject *receiver, const char *member);
> [2019-08-09T20:18:04.390Z] | ^~~~
> [2019-08-09T20:18:04.390Z]
> /home/jenkins/workspace/Administration/Dependency Build Plasma
> stable-kf5-qt5
> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:110:
> warning: ���void
> Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState,
> QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
> [2019-08-09T20:18:04.390Z] 259 |
> Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState,
> nullptr, nullptr);
> [2019-08-09T20:18:04.390Z] | ^
> [2019-08-09T20:18:04.390Z] In file included from
> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
> [2019-08-09T20:18:04.390Z] from
> /home/jenkins/workspace/Administration/Dependency Build Plasma
> stable-kf5-qt5
> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
> [2019-08-09T20:18:04.390Z]
> /home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40:
> note: declared here
> [2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void
> requestSleep(SleepState state, QObject *receiver, const char *member);
> [2019-08-09T20:18:04.390Z] | ^~~~
> [2019-08-09T20:18:04.390Z]
> /home/jenkins/workspace/Administration/Dependency Build Plasma
> stable-kf5-qt5
> SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:253:16:
> warning: enumeration value ���HybridSuspendState��� not handled in switch
> [-Wswitch]
> [2019-08-09T20:18:04.390Z] 253 | switch
> ((Solid::PowerManagement::SleepState)match.data().toInt()) {
> [2019-08-09T20:18:04.390Z] | ^
> [2019-08-09T20:18:04.390Z] Scanning dependencies of target
> plasma_applet_appmenu
> [2019-08-09T20:18:04.390Z] [ 55%] Building CXX object
> applets/appmenu/lib/CMakeFiles/plasma_applet_appmenu.dir/plasma_applet_appmenu_autogen/mocs_compilati

KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 SUSEQt5.12 - Build # 149 - Unstable!

2019-08-10 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20SUSEQt5.12/149/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 10 Aug 2019 14:04:41 +
 Build duration:
9 min 32 sec and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.16.4.xmlacc/LibKWorkspace-5.16.4.xmlacc/LibNotificationManager-5.16.4.xmlacc/LibTaskManager-5.16.4.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.16.4/log.txtlogs/LibKWorkspace/5.16.4/log.txtlogs/LibNotificationManager/5.16.4/log.txtlogs/LibTaskManager/5.16.4/log.txt
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/122)12%
(50/402)12%
(50/402)7%
(2540/36342)5%
(1266/25214)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.notifications0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/78)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/271)0%
(0/277)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.keyboardlayout0%
(0/2)0%
(0/2)0%
(0/76)0%
(0/32)components.sessionsprivate0%
(0/3)0%
(0/3)0%
(0/163)0%

Re: Fwd: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Still Failing!

2019-08-10 Thread Nate Graham

Done and fixed.

Nate


On 8/9/19 2:20 PM, Ben Cooksley wrote:

Hi folks,

Could someone please look into the below QMutex include problem within 
plasma-workspace?


Thanks,
Ben

-- Forwarded message -
From: *CI System* mailto:nore...@kde.org>>
Date: Sat, Aug 10, 2019 at 8:18 AM
Subject: KDE CI: Administration » Dependency Build Plasma stable-kf5-qt5 
SUSEQt5.12 - Build # 46 - Still Failing!

To: mailto:bcooks...@kde.org>>


*BUILD FAILURE*
Build URL 
https://build.kde.org/job/Administration/job/Dependency%20Build%20Plasma%20stable-kf5-qt5%20SUSEQt5.12/46/

Project:Dependency Build Plasma stable-kf5-qt5 SUSEQt5.12
Date of build:  Fri, 09 Aug 2019 18:51:11 +
Build duration: 1 hr 26 min and counting


*CONSOLE OUTPUT *
[...truncated 94439 lines...]
[2019-08-09T20:18:04.390Z] 
/home/jenkins/workspace/Administration/Dependency Build Plasma 
stable-kf5-qt5 
SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:41: 
warning: ���void 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, 
QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
[2019-08-09T20:18:04.390Z] 259 | 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, 
nullptr, nullptr);

[2019-08-09T20:18:04.390Z] | ^~~~
[2019-08-09T20:18:04.390Z] In file included from 
/home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
[2019-08-09T20:18:04.390Z] from 
/home/jenkins/workspace/Administration/Dependency Build Plasma 
stable-kf5-qt5 
SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
[2019-08-09T20:18:04.390Z] 
/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: 
note: declared here
[2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void 
requestSleep(SleepState state, QObject *receiver, const char *member);

[2019-08-09T20:18:04.390Z] | ^~~~
[2019-08-09T20:18:04.390Z] 
/home/jenkins/workspace/Administration/Dependency Build Plasma 
stable-kf5-qt5 
SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:110: 
warning: ���void 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, 
QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
[2019-08-09T20:18:04.390Z] 259 | 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, 
nullptr, nullptr);

[2019-08-09T20:18:04.390Z] | ^
[2019-08-09T20:18:04.390Z] In file included from 
/home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
[2019-08-09T20:18:04.390Z] from 
/home/jenkins/workspace/Administration/Dependency Build Plasma 
stable-kf5-qt5 
SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
[2019-08-09T20:18:04.390Z] 
/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: 
note: declared here
[2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void 
requestSleep(SleepState state, QObject *receiver, const char *member);

[2019-08-09T20:18:04.390Z] | ^~~~
[2019-08-09T20:18:04.390Z] 
/home/jenkins/workspace/Administration/Dependency Build Plasma 
stable-kf5-qt5 
SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:259:110: 
warning: ���void 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::SleepState, 
QObject*, const char*)��� is deprecated [-Wdeprecated-declarations]
[2019-08-09T20:18:04.390Z] 259 | 
Solid::PowerManagement::requestSleep(Solid::PowerManagement::HibernateState, 
nullptr, nullptr);

[2019-08-09T20:18:04.390Z] | ^
[2019-08-09T20:18:04.390Z] In file included from 
/home/jenkins/install-prefix/include/KF5/KDELibs4Support/KDE/Solid/PowerManagement:1,
[2019-08-09T20:18:04.390Z] from 
/home/jenkins/workspace/Administration/Dependency Build Plasma 
stable-kf5-qt5 
SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:34:
[2019-08-09T20:18:04.390Z] 
/home/jenkins/install-prefix/include/KF5/KDELibs4Support/solid/powermanagement.h:83:40: 
note: declared here
[2019-08-09T20:18:04.390Z] 83 | KDELIBS4SUPPORT_DEPRECATED_EXPORT void 
requestSleep(SleepState state, QObject *receiver, const char *member);

[2019-08-09T20:18:04.390Z] | ^~~~
[2019-08-09T20:18:04.390Z] 
/home/jenkins/workspace/Administration/Dependency Build Plasma 
stable-kf5-qt5 
SUSEQt5.12/plasma-workspace/runners/powerdevil/PowerDevilRunner.cpp:253:16: 
warning: enumeration value ���HybridSuspendState��� not handled in 
switch [-Wswitch]
[2019-08-09T20:18:04.390Z] 253 | switch 
((Solid::PowerManagement::SleepState)match.data().toInt()) {

[2019-08-09T20:18:04.390Z] | ^
[2019-08-09T20:18:04.390Z] Scanning dependencies of target 
plasma_applet_appmenu
[2019-08-09T20:18:04.390Z] [ 55%] Building CXX object 
applets/appmenu/lib/CMakeFiles/plasma_applet_appmenu.dir/plasma_applet_appmenu_autogen/mocs_compilation.cpp.o

[2019-08-09T20:18:04.390Z] [ 55%] Built target plasma_applet_icon_autogen

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 SUSEQt5.12 - Build # 52 - Fixed!

2019-08-10 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20SUSEQt5.12/52/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 10 Aug 2019 15:56:15 +
 Build duration:
5 min 18 sec and counting
   BUILD ARTIFACTS
  acc/PlasmaPotdProvider-1.0.0.xml
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/26)0%
(0/96)0%
(0/96)0%
(0/4957)0%
(0/2468)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.colorpicker.plugin0%
(0/3)0%
(0/3)0%
(0/88)0%
(0/28)applets.comic0%
(0/14)0%
(0/14)0%
(0/1130)0%
(0/537)applets.dict.plugin0%
(0/3)0%
(0/3)0%
(0/71)0%
(0/21)applets.diskquota.plugin0%
(0/6)0%
(0/6)0%
(0/249)0%
(0/135)applets.fifteenPuzzle.plugin0%
(0/2)0%
(0/2)0%
(0/50)0%
(0/28)applets.grouping0%
(0/1)0%
(0/1)0%
(0/61)0%
(0/66)applets.grouping.container0%
(0/1)0%
(0/1)0%
(0/54)0%
(0/40)applets.mediaframe.plugin0%
(0/3)0%
(0/3)0%
(0/198)0%
(0/94)applets.notes.plugin0%
(0/7)0%
(0/7)0%
(0/250)0%
(0/80)applets.quicklaunch.plugin0%
(0/2)0%
(0/2)0%
(0/117)0%
(0/64)applets.quickshare.plugin0%
(0/2)0%
(0/2)0%
(0/54)0%
(0/20)applets.timer.plugin0%
(0/2)0%
(0/2)0%
(0/8)0%
(0/2)applets.weather0%
(0/2)0%
(0/2)0%
(0/132)0%
(0/66)applets.weather.plugin0%
(0/8)0%
(0/8)0%
(0/260)0%
(0/147)dataengines.comic0%
(0/7)0%
(0/7)0%
(0/938)0%
(0/530)dataengines.konsoleprofiles0%
(0/2)0%
(0/2)0%
(0/52)0%
(0/14)dataengines.potd0%
(0/17)0%
(0/17)0%
(0/451)0%
(0/204)plasmacalendarplugins.astronomical0%
(0/1)0%
(0/1)0%
(0/29)0%
(0/10)plasmacalendarplugins.astronomical.config.plugin0

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 SUSEQt5.12 - Build # 51 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20SUSEQt5.12/51/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 10 Aug 2019 15:48:46 +
 Build duration:
7 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 1226 lines...][2019-08-10T15:55:58.223Z] [ 48%] Building CXX object applets/weather/CMakeFiles/plasma_applet_weather.dir/plasma_applet_weather_autogen/mocs_compilation.cpp.o[2019-08-10T15:55:59.293Z] [ 49%] Linking CXX shared library ../../bin/libtimerplugin.so[2019-08-10T15:55:59.804Z] [ 50%] Building CXX object applets/notes/CMakeFiles/notesplugin.dir/plugin/notesplugin.cpp.o[2019-08-10T15:55:59.804Z] [ 50%] Building CXX object applets/weather/CMakeFiles/plasma_applet_weather.dir/weatherapplet.cpp.o[2019-08-10T15:55:59.804Z] [ 50%] Built target timerplugin[2019-08-10T15:55:59.804Z] Scanning dependencies of target weatherplugin[2019-08-10T15:55:59.804Z] [ 51%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/weatherplugin_autogen/mocs_compilation.cpp.o[2019-08-10T15:55:59.804Z] [ 52%] Linking CXX shared library ../../../bin/libquicklaunchplugin.so[2019-08-10T15:56:00.315Z] [ 53%] Linking CXX shared library ../../../bin/libpurposeplugin.so[2019-08-10T15:56:00.315Z] [ 53%] Built target quicklaunchplugin[2019-08-10T15:56:00.315Z] Scanning dependencies of target plasma_packagestructure_comic[2019-08-10T15:56:00.315Z] [ 53%] Building CXX object dataengines/comic/CMakeFiles/plasma_packagestructure_comic.dir/plasma_packagestructure_comic_autogen/mocs_compilation.cpp.o[2019-08-10T15:56:00.826Z] Scanning dependencies of target plasmacomicprovidercore[2019-08-10T15:56:00.826Z] [ 54%] Building CXX object dataengines/comic/CMakeFiles/plasmacomicprovidercore.dir/plasmacomicprovidercore_autogen/mocs_compilation.cpp.o[2019-08-10T15:56:00.826Z] [ 54%] Building CXX object dataengines/comic/CMakeFiles/plasmacomicprovidercore.dir/comicprovider.cpp.o[2019-08-10T15:56:00.826Z] [ 54%] Built target purposeplugin[2019-08-10T15:56:00.827Z] Scanning dependencies of target plasmapotdprovidercore[2019-08-10T15:56:00.827Z] [ 55%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/plasmapotdprovidercore_autogen/mocs_compilation.cpp.o[2019-08-10T15:56:02.518Z] [ 55%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/potdprovider.cpp.o[2019-08-10T15:56:02.518Z] [ 56%] Linking CXX shared module ../../bin/plasma_applet_weather.so[2019-08-10T15:56:02.518Z] [ 57%] Building CXX object dataengines/comic/CMakeFiles/plasma_packagestructure_comic.dir/comic_package.cpp.o[2019-08-10T15:56:02.518Z] [ 57%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/plugin.cpp.o[2019-08-10T15:56:02.518Z] [ 57%] Linking CXX shared library ../../bin/libnotesplugin.so[2019-08-10T15:56:03.029Z] [ 57%] Built target plasma_applet_weather[2019-08-10T15:56:03.029Z] [ 57%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/util.cpp.o[2019-08-10T15:56:03.029Z] [ 57%] Built target notesplugin[2019-08-10T15:56:03.544Z] Scanning dependencies of target plasma_engine_konsoleprofiles[2019-08-10T15:56:03.544Z] [ 57%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/plasma_engine_konsoleprofiles_autogen/mocs_compilation.cpp.o[2019-08-10T15:56:04.054Z] [ 57%] Linking CXX shared library ../../bin/libplasmacomicprovidercore.so[2019-08-10T15:56:04.054Z] [ 57%] Linking CXX shared library ../../bin/libplasmapotdprovidercore.so[2019-08-10T15:56:04.565Z] [ 57%] Built target plasmapotdprovidercore[2019-08-10T15:56:04.565Z] [ 58%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/konsoleprofilesengine.cpp.o[2019-08-10T15:56:04.565Z] [ 58%] Linking CXX shared module ../../bin/plasma_packagestructure_comic.so[2019-08-10T15:56:04.565Z] [ 58%] Built target plasmacomicprovidercore[2019-08-10T15:56:04.565Z] [ 58%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/konsoleprofilesservice.cpp.o[2019-08-10T15:56:05.076Z] Scanning dependencies of target krunner_converter[2019-08-10T15:56:05.076Z] [ 58%] Building CXX object runners/converter/CMakeFiles/krunner_converter.dir/krunner_converter_autogen/mocs_compilation.cpp.o[2019-08-10T15:56:05.076Z] [ 59%] Building CXX object runners/converter/CMakeFiles/krunner_converter.dir/converterrunner.cpp.o[2019-08-10T15:56:05.076Z] [ 59%] Built target plasma_packagestructure_comic[2019-08-10T15:56:05.076Z] [ 60%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/abstractunitlistmodel.cpp.o[2019-08-10T15:56:05.587Z] Scanning dependencies of target krunner_datetime[2019-08-10T15:56:05.587Z] [ 61%] Building CXX object runners/datetime/CMakeFiles/krunner_datetime.dir/krunner_datetime_autogen/mocs_compilation.cpp.o[2019-08-10T15:56:06.102Z] [ 61%] Building CXX object runners/datetime/CMakeFiles/krunn

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 FreeBSDQt5.13 - Build # 15 - Fixed!

2019-08-10 Thread CI System
BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20FreeBSDQt5.13/15/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 10 Aug 2019 15:53:06 +
 Build duration:
1 min 19 sec and counting

KDE CI: Plasma » kdeplasma-addons » stable-kf5-qt5 FreeBSDQt5.13 - Build # 14 - Failure!

2019-08-10 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kdeplasma-addons/job/stable-kf5-qt5%20FreeBSDQt5.13/14/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 10 Aug 2019 15:48:46 +
 Build duration:
1 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 1194 lines...][2019-08-10T15:49:46.244Z] [ 56%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/plasmapotdprovidercore_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:46.523Z] [ 56%] Linking CXX shared library ../../bin/libnotesplugin.so[2019-08-10T15:49:46.523Z] [ 57%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/abstractunitlistmodel.cpp.o[2019-08-10T15:49:46.523Z] [ 57%] Built target notesplugin[2019-08-10T15:49:46.787Z] Scanning dependencies of target plasma_engine_konsoleprofiles[2019-08-10T15:49:46.787Z] [ 57%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/plasma_engine_konsoleprofiles_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:46.787Z] Scanning dependencies of target krunner_converter[2019-08-10T15:49:46.787Z] [ 57%] Building CXX object runners/converter/CMakeFiles/krunner_converter.dir/krunner_converter_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:46.787Z] Scanning dependencies of target krunner_datetime[2019-08-10T15:49:46.787Z] [ 58%] Building CXX object runners/datetime/CMakeFiles/krunner_datetime.dir/krunner_datetime_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:47.051Z] [ 59%] Building CXX object runners/converter/CMakeFiles/krunner_converter.dir/converterrunner.cpp.o[2019-08-10T15:49:47.051Z] [ 59%] Linking CXX shared library ../../bin/libplasmacomicprovidercore.so[2019-08-10T15:49:47.051Z] [ 59%] Building CXX object dataengines/potd/CMakeFiles/plasmapotdprovidercore.dir/potdprovider.cpp.o[2019-08-10T15:49:47.051Z] [ 59%] Built target plasmacomicprovidercore[2019-08-10T15:49:47.051Z] [ 59%] Building CXX object applets/comic/CMakeFiles/plasma_applet_comic.dir/activecomicmodel.cpp.o[2019-08-10T15:49:47.315Z] [ 59%] Linking CXX shared module ../../bin/plasma_packagestructure_comic.so[2019-08-10T15:49:47.315Z] [ 59%] Building CXX object runners/datetime/CMakeFiles/krunner_datetime.dir/datetimerunner.cpp.o[2019-08-10T15:49:47.315Z] [ 59%] Built target plasma_packagestructure_comic[2019-08-10T15:49:47.315Z] [ 59%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/locationlistmodel.cpp.o[2019-08-10T15:49:47.315Z] Scanning dependencies of target krunner_katesessions[2019-08-10T15:49:47.315Z] [ 59%] Building CXX object runners/katesessions/CMakeFiles/krunner_katesessions.dir/krunner_katesessions_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:47.581Z] [ 60%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/konsoleprofilesengine.cpp.o[2019-08-10T15:49:47.848Z] [ 60%] Linking CXX shared library ../../bin/libplasmapotdprovidercore.so[2019-08-10T15:49:47.848Z] [ 60%] Building CXX object dataengines/konsoleprofiles/CMakeFiles/plasma_engine_konsoleprofiles.dir/konsoleprofilesservice.cpp.o[2019-08-10T15:49:47.848Z] [ 61%] Building CXX object runners/katesessions/CMakeFiles/krunner_katesessions.dir/katesessions.cpp.o[2019-08-10T15:49:47.848Z] [ 61%] Built target plasmapotdprovidercore[2019-08-10T15:49:47.848Z] Scanning dependencies of target krunner_spellcheck[2019-08-10T15:49:47.848Z] [ 62%] Building CXX object runners/spellchecker/CMakeFiles/krunner_spellcheck.dir/krunner_spellcheck_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:48.116Z] [ 63%] Linking CXX shared module ../../bin/plasma_applet_comic.so[2019-08-10T15:49:48.116Z] [ 63%] Linking CXX shared module ../../bin/krunner_converter.so[2019-08-10T15:49:48.382Z] [ 63%] Built target krunner_converter[2019-08-10T15:49:48.382Z] [ 63%] Generating ui_spellcheck_config.h[2019-08-10T15:49:48.382Z] [ 63%] Built target plasma_applet_comic[2019-08-10T15:49:48.382Z] [ 64%] Generating ui_charrunner_config.h[2019-08-10T15:49:48.382Z] [ 65%] Linking CXX shared module ../../bin/krunner_datetime.so[2019-08-10T15:49:48.382Z] Scanning dependencies of target kcm_krunner_spellcheck[2019-08-10T15:49:48.382Z] Scanning dependencies of target kcm_krunner_charrunner[2019-08-10T15:49:48.382Z] [ 66%] Building CXX object runners/spellchecker/CMakeFiles/kcm_krunner_spellcheck.dir/kcm_krunner_spellcheck_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:48.382Z] [ 66%] Building CXX object runners/characters/CMakeFiles/kcm_krunner_charrunner.dir/kcm_krunner_charrunner_autogen/mocs_compilation.cpp.o[2019-08-10T15:49:48.382Z] [ 67%] Building CXX object applets/weather/CMakeFiles/weatherplugin.dir/plugin/servicelistmodel.cpp.o[2019-08-10T15:49:48.382Z] [ 67%] Built target krunner_datetime[2019-08-10T15:49:48.648Z] Scanning dependencies of target kcm_krunner_dictionary[2019-08-10T15:49:48.648Z] Scanning dependencies of target krunner_dictionary[2019-08-10T15:49:48.648Z] [ 68%] Building CXX object runn

D23064: Fix duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Nathaniel Graham
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:239f574c5b2f: Fix #410744: Duplicate results when a 2nd 
unit is partially written in krunner (authored by iasensio, committed by 
ngraham).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23064?vs=63456&id=63488

REVISION DETAIL
  https://phabricator.kde.org/D23064

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: iasensio, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23064: Fix duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Ismael Asensio
iasensio added a comment.


  Sure about the email. Thanks!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D23064

To: iasensio, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23064: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.


  I'll do it :)
  
  Very nice job indeed!

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D23064

To: iasensio, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22976: Fix compilation

2019-08-10 Thread Ömer Fadıl Usta
usta added a comment.


  In D22976#509675 , @aacid wrote:
  
  > And what are you or ben waiting for? You've both got commit access :)
  
  
  @aacid:
  ;) in here we are in sacrifice feast , and i dont have my laptop with me  ( 
sorry about that )
  
  And @ngraham thank you

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22976

To: ngraham, #plasma, aacid
Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D23064: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Kai Uwe Broulik
broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Well done! :)
  I'll land this (or Nate is probably quicker) once I find the time to do it. 
Can I use the email address you used in the bugreport for this?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D23064

To: iasensio, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22976: Fix compilation

2019-08-10 Thread Nathaniel Graham
ngraham added a comment.


  Done.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22976

To: ngraham, #plasma, aacid
Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


KDE CI: Plasma » plasma-workspace » stable-kf5-qt5 FreeBSDQt5.13 - Build # 22 - Still unstable!

2019-08-10 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/stable-kf5-qt5%20FreeBSDQt5.13/22/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 10 Aug 2019 14:04:41 +
 Build duration:
4 min 51 sec and counting
   JUnit Tests
  Name: projectroot.kioslave.desktop Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.kioslave.desktop.tests.testdesktopName: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D23028: Wayland: set KWayland outputs data in output class

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:137ec11fe2a6: Wayland: set KWayland outputs data in 
output class (authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23028?vs=63348&id=63482

REVISION DETAIL
  https://phabricator.kde.org/D23028

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23026: Wayland: unfriend config and output classes

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:4d698bd16d41: Wayland: unfriend config and output classes 
(authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23026?vs=63346&id=63481

REVISION DETAIL
  https://phabricator.kde.org/D23026

AFFECTED FILES
  backends/kwayland/waylandoutput.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23025: Wayland: output device name as create function argument only

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:6a1aef331f7e: Wayland: output device name as create 
function argument only (authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23025?vs=63345&id=63480

REVISION DETAIL
  https://phabricator.kde.org/D23025

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D23024: Wayland: save pointers in initializing list

2019-08-10 Thread Roman Gilg
This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R110:e4bb0192df42: Wayland: save pointers in initializing list 
(authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23024?vs=63342&id=63479

REVISION DETAIL
  https://phabricator.kde.org/D23024

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp
  backends/kwayland/waylandconfig.h

To: romangg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22535: Make kimpanel a system tray applet

2019-08-10 Thread Yunhe Guo
guoyunhe added a comment.


  I tried to merge @gpark 's branch. It is compiled but I cannot reproduce the 
UI as shown in demo video. I am not sure how it is connected. So I leave that 
part untouched for now. I hope I can get in touch with @gpark to understand how 
the code works. Then we can make another patch for KCM and OSD modules.
  
  In this patch, I will only implement the system tray icon, context menu, and 
expanded widget. Keep it small. So I can make it with my very limited 
C++/Qt5/KF5 knowledge.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22535

To: guoyunhe, ngraham, #vdg, #plasma
Cc: xuetianweng, gpark, hein, mart, ngraham, apol, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas


D22976: Fix compilation

2019-08-10 Thread Albert Astals Cid
aacid added a comment.


  And what are you or ben waiting for? You've both got commit access :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22976

To: ngraham, #plasma, aacid
Cc: usta, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart


D23064: Fix #410744: Duplicate results when a 2nd unit is partially written in krunner

2019-08-10 Thread Ismael Asensio
iasensio created this revision.
iasensio added reviewers: ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  When typing a conversion, and the second unit is partially written (i.e. "10€ 
to ru..." the results are duplicated by several times. This behavior happens 
with different categories of units (lenght, currency, ...) and on different 
languages.
  
  The problem is that a new result is being added not once for every matching 
unit, but once for every matching stringUnit, generating the duplicates.
  
  Before:
  F7202568: krunner_before.png 
  
  After:
  F7202571: krunner_after.png 
  
  This is my first attempt to build kde from source and commit the diff to 
phabricator, so please excuse any possible mistakes.
  
  BUG: 410744

TEST PLAN
  Open krunner and type any conversion with a letter for the second unit: "10€ 
to r"
  Result for each matching second unit is only shown one time

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D23064

AFFECTED FILES
  runners/converter/converterrunner.cpp

To: iasensio, ngraham, broulik
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart


D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 updated this revision to Diff 63460.
GB_2 added a comment.


  "Configure" -> "Configure..."

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63458&id=63460

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  app/SettingsBase.cpp
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, mart
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D22896: [WIP] Port System Settings sidebar to QQC2 and add "Show Most Used Page" button

2019-08-10 Thread Björn Feber
GB_2 added a subscriber: mart.
GB_2 added a comment.


  Ping @mart, can you please help here?

REPOSITORY
  R124 System Settings

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

To: GB_2, #plasma, #vdg, ngraham
Cc: mart, filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol


D22896: Port System Settings sidebar to QQC2 and make QML imports consistent

2019-08-10 Thread Björn Feber
GB_2 updated this revision to Diff 63458.
GB_2 added a comment.


  Add a "Show Most Used Page" button

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22896?vs=63404&id=63458

BRANCH
  port-system-settings-sidebar-to-qqc2-and-make-qml-imports-consistent 
(branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22896

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/ActionMenu.qml
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/IntroIcon.qml
  sidebar/package/contents/ui/SubCategoryPage.qml
  sidebar/package/contents/ui/introPage.qml
  sidebar/package/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, ngraham, broulik, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart