D24683: [KWindowSystem] in icon() return realistic icon size

[Méven Car]

meven added a subscriber: ngraham.
meven added a comment.


  @ngraham In Wayland this allows the Tooltips from the taskmanager to display 
centered icon for wayland windows.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D24683

To: meven, #kwin, davidedmundson
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24683: [KWindowSystem] in icon() return realistic icon size

[Méven Car]

meven updated this revision to Diff 68012.
meven added a comment.


  Clean up

REPOSITORY
  R130 Frameworks integration plugin using KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24683?vs=68011=68012

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24683

AFFECTED FILES
  src/windowsystem/windowsystem.cpp

To: meven, #kwin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24683: [KWindowSystem] in icon() return realistic icon size

[Méven Car]

meven created this revision.
meven added reviewers: KWin, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  The icon function did not take into account the fact that icons have limited 
size options available.
  Also take into account scale parameter.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24683

AFFECTED FILES
  .kdev4/kwayland-integration.kdev4
  CMakeLists.txt.user
  kwayland-integration.kdev4
  src/windowsystem/windowsystem.cpp

To: meven, #kwin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Vladimir Yerilov]

yerilov added a comment.


  Thanks @apol 
  I've built it from your branch and testing it now. Here is a list of issues I 
have faced so far:
  
  1. Layout switch doesn't work on Lock screen. Visually layouts are shown as 
switched, but actually it's always English.
  2. I have 3 layouts: EurKey, Russian and Mozc (fcitx). All work fine except 
for normal layouts are not indicated in tray with their respective names (ru, 
eu). When switching to Mozc, it's icon shows up as expected.
  3. Switching laouts with "Main shift key" (like Alt+Shift or Win+Space) only 
works for ru<->eu, mozc isn't triggered, although "Cycle through layouts" 
shortcut (Ctrl+Alt+K as by default) allows switching to Mozc.
  4. This is of course more of design thing but adding new layout is such a 
pain now: the dialog window is small, list area inside is tiny, searching for 
"Russian" shows huge amount of possible variants and to find and select a 
needed one is not a simple task, given the fact that the scrollbar is small and 
navigation with keyboard arrow keys is not possible.
  5. Each layout in Keyboard kcm has its settings invoked by "Configure" 
button, but when trying to configure Mozc this way its dialog appears blank, 
then entire systemsettings5 segfaults:
  
$ systemsettings5
Icon theme "elementary" not found.
Icon theme "elementary" not found.
QVariant(FcitxQtInputMethodItemList, )
Icon theme "elementary" not found.
"grp" "Switching to another layout"
"lv3" "Key to choose the 3rd level"
QQmlExpression: Expression 
file:///home/openm/kde/usr/share/kpackage/kcms/kcm_keyboard/contents/ui/Layouts.qml:187:13
 depends on non-NOTIFYable properties:
LayoutConfigModel::thirdLevelShortcutModel
QQmlExpression: Expression 
file:///home/openm/kde/usr/share/kpackage/kcms/kcm_keyboard/contents/ui/Layouts.qml:173:13
 depends on non-NOTIFYable properties:
LayoutConfigModel::mainShiftKeyModel
"Keyboard model \"\" not detected"

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/templates/InlineMessage.qml:136:
 TypeError: Value is undefined and could not be converted to an object

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/private/globaltoolbar/PageRowGlobalToolBarUI.qml:71:
 TypeError: Cannot read property 'actions' of null

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/templates/AbstractApplicationHeader.qml:46:5:
 Unable to assign QQuickItem_QML_136 to Page_QMLTYPE_28

file:///home/openm/kde/usr/lib/qml/org/kde/kirigami.2/private/globaltoolbar/BreadcrumbControl.qml:71:21:
 Unable to assign QQuickItem_QML_136 to Page_QMLTYPE_28
QQmlEngine::setContextForObject(): Object already has a QQmlContext
kcm_touchpad: Using X11 backend
QQmlEngine::setContextForObject(): Object already has a QQmlContext
qml: Touchpad configuration of device '1 : ETD2303:00 04F3:3083 Touchpad' 
opened
"eu" false ""
"ru" false ""
"fcitx:mozc" false ""
"1 instead of 2 arguments to message {The input support fo...} supplied 
before conversion."
"eu"
0
Cannot open config description file
Cannot open config description file
fish: “systemsettings5” terminated by signal SIGSEGV (Address boundary 
error)
  
  In order to have fcitx working I used to have .pam_environment with the 
following content:
  
XMODIFIERS=@im=fcitx
GTK_IM_MODULE=fcitx
QT_IM_MODULE=fcitx
DefaultIMModule=fcitx
  
  I don't know if I still need it.
  
  My overall impression is there's lot of things to polish but in general this 
is a //huge// step in the right direction.
  I am ready to test it anytime.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham, apol, 
plasma-devel, hein, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, ahiemstra, mart

Re: Monday meeting notes for 14/10/2019

[Nate Graham]

Leinir:
* The new Qt Quick components for KNewStuff were released as part of
Frameworks 5.63, so whenever Plasma's able to depend on that we can
start scattering that all over the place :)


Plasma 5.18 will depend on Frameworks 5.66, so that means this porting 
work can start to happen in master!


Nate

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

[Nathaniel Graham]

ngraham added a comment.


  In D24635#547820 , @apol wrote:
  
  > I understand what you say but I don't think that's even feasible. Does it 
really make sense that from e.g. KMail you need to ask the Plasma KCM for 
permission to send feedback?
  >  Furthermore, a KMail user may not even be on Plasma, how would you enable 
feedback then?
  
  
  The global on/off switch would be in the KCM, which I think is where people 
would expect it to be. Once it's turned on, then I suppose the settings for 
whether or not KMail should send feedback would live in KMail (but it could 
also be visible in a central location, in the KCM). That's my vision for how it 
should work, at least.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24635

To: apol, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

[Aleix Pol Gonzalez]

apol added a comment.


  > Ok, just tried this out. The problem is that the global on/off switch 
that's presented to the user is still reversed from what it should be: instead 
of saying, "forbid KDE software from bla bla bla", it should say "allow KDE 
software to bla bla bla". Otherwise the user looks at the unchecked checkbox 
and wonders, "is KDE software able to send information unless I check this?" 
And it's a valid concern because apparently that is in fact possible.
  > 
  > IMO we need to make the global killswitch be on by default (so all 
telemetry is forced off, which is what I thought we'd all agreed to). If we do 
that, then it's actually safe to have apps and Plasma turn telemetry on by 
default, because the global killswitch will be overriding them. And then when a 
user enables telemetry in this KCM, the global killswitch turns off and then 
apps and Plasma will instantly start sending information.
  > 
  > Does that make any sense?
  
  I understand what you say but I don't think that's even feasible. Does it 
really make sense that from e.g. KMail you need to ask the Plasma KCM for 
permission to send feedback?
  Furthermore, a KMail user may not even be on Plasma, how would you enable 
feedback then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24635

To: apol, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Aleix Pol Gonzalez]

apol added a comment.


  So I decided to rebase the patch onto current master. I pushed it rebased 
into a branch called `apol/D14796` because I didn't know whether to take over 
this review.
  
  I would appreciate it if someone could help me tell why it wasn't merged. I 
see:
  
  > It needs a lot of review, VDG feedback on the KCM UIs, and practically 
speaking an ibus backend to be coded. Both @gpark and me are currently a bit 
busy (exchange studies in his case, work in my case) and I think much progress 
before Xmas isn't that likely unless more people participate.
  
  KCM uis is something we can polish even after the fact. @eikehein, you have 
made it clear that you believe this is the way to go. I can see into helping 
making this a thing but I need to know that even if the ibus backend is there 
this won't be stalled forever.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham, apol, 
plasma-devel, hein, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, ahiemstra, mart

D13243: [applet] Add checkbox to show virtual streams

[Nathaniel Graham]

ngraham added a comment.


  Now that I think about this some more, might it make sense to have the option 
in the KCM, and then checking it would show virtual streams in both the applet 
and the KCM? Otherwise it might be a bit odd to have this apply only to the 
applet.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  arcpatch-D13243

REVISION DETAIL
  https://phabricator.kde.org/D13243

To: sefaeyeoglu, #plasma, drosca, #vdg, ngraham
Cc: baberts, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24447: Fix compatibility of build_theme.sh with Dash

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:91c16f284c18: Fix compatibility of build_theme.sh with 
Dash (authored by gepardo, committed by cblack).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24447?vs=67392=68004

REVISION DETAIL
  https://phabricator.kde.org/D24447

AFFECTED FILES
  src/build_theme.sh

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24447: Fix compatibility of build_theme.sh with Dash

[Carson Black]

cblack added a comment.


  In D24447#547774 , @gepardo wrote:
  
  > Thanks. Can you please merge it? I don't have a developer access to KDE 
repos.
  
  
  Sure, I'll do that.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24447: Fix compatibility of build_theme.sh with Dash

[Alexander Kernozhitsky]

gepardo added a comment.


  Thanks. Can you please merge it? I don't have a developer access to KDE repos.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24447: Fix compatibility of build_theme.sh with Dash

[Carson Black]

cblack accepted this revision.
cblack added a comment.


  LGTM 

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24447

To: gepardo, cblack, svuorela
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24679: [Notifications] Also consider enabled and connected for screen to be checked against

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Fixes erroneously enabling do not disturb mode in some situations when having 
screens mirrored and then closing the lid. You'll have two overlapping screens 
but one of them is disabled so should be ignored.
  Depending on the order of outputs this may or may not happen (which is why I 
didn't notice earlier when I tested with my new laptop).

TEST PLAN
  5.17 branch
  
  - Didn't actually test it yet but I'll give it some testing the other day

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24679

AFFECTED FILES
  libnotificationmanager/mirroredscreenstracker.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24635: feedback kcm: Improve wording and presentation of the user feedback settings

[Nathaniel Graham]

ngraham added a comment.


  In D24635#547168 , @apol wrote:
  
  > In D24635#547136 , @ngraham 
wrote:
  >
  > > Thanks. Can we just surface that then? We'd show a UI for the global 
on/off switch and than additionally allow turning telemetry on or off for apps 
and Plasma. That seems like it might be less confusing than coming up with an 
abstraction surrounding it.
  >
  >
  > That's exactly what we are doing right now.
  >  We probably need better wording for it.
  
  
  Ok, just tried this out. The problem is that the global on/off switch that's 
presented to the user is still reversed from what it should be: instead of 
saying, "forbid KDE software from bla bla bla", it should say "allow KDE 
software to bla bla bla". Otherwise the user looks at the unchecked checkbox 
and wonders, "is KDE software able to send information unless I check this?" 
And it's a valid concern because apparently that is in fact possible.
  
  IMO we need to make the global killswitch be on by default (so all telemetry 
is forced off, which is what I thought we'd all agreed to). If we do that, then 
it's actually safe to have apps and Plasma turn telemetry on by default, 
because the global killswitch will be overriding them. And then when a user 
enables telemetry in this KCM, the global killswitch turns off and then apps 
and Plasma will instantly start sending information.
  
  Does that make any sense?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24635

To: apol, #plasma
Cc: ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24677: Add `sudo` to the lines in install-sessions.sh that need it so you don't need to sudo the whole thing

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Because this script copies things to /, it needs to be run with `sudo`. But 
two of the
  copy operations also copy things to your home directory, and if you `sudo` 
the whole
  script, this results in those files being copied with root ownership, which 
can cause
  problems later.
  
  This patch prepends `sudo` to just the copy operations that need it so that 
the ones
  that don't aren't run with inappropriately elevated permissions.

TEST PLAN
  - Run `~/kde/build/plasma-workspace/login-sessions/install-sessions.sh`
  - Get prompted for the root password
  - Enter it
  - See that `plasma-dev-prefix.sh` and `startplasma-dev.sh` in 
`~/kde/usr/lib64/libexec/` have user ownership, not root ownership

REPOSITORY
  R120 Plasma Workspace

BRANCH
  moar-sudo (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24677

AFFECTED FILES
  login-sessions/install-sessions.sh.cmake

To: ngraham, apol, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0

[Fabian Vogt]

fvogt added a comment.


  In D24664#547710 , @broulik wrote:
  
  > Since we watch the file, we will update it as neccessary once kconf_update 
has written it, right?
  
  
  Yup.
  
  > When it is deleted after that, we won't ever recreate it, though?
  
  Yup.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24664

To: fvogt, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0

[Kai Uwe Broulik]

broulik added a comment.


  Since we watch the file, we will update it as neccessary once kconf_update 
has written it, right?
  When it is deleted after that, we won't ever recreate it, though?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24664

To: fvogt, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24674: Fix Kirigami template image

[Dimitris Kardarakos]

dkardarakos created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
dkardarakos requested review of this revision.

REVISION SUMMARY
  Kirigami template image file is empty. An image file that shows a Kirigami 
application was added.

TEST PLAN
  Try to create a Kirigami application with kdevelop or kapptemplate, using the 
template found in Qt > Graphical > Kirigami Application; an image is shown, 
showing how the application will look like.

REPOSITORY
  R169 Kirigami

BRANCH
  TemplateImage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24674

AFFECTED FILES
  templates/kirigami/kirigami-app.png

To: dkardarakos
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D24483: [Weather data engine] Handle windy conditions in NOAA backend

[Shawn Starr]

spstarr added a comment.


  When those land I'll have a PR for EnvCan provider/ion to support those too

REPOSITORY
  R120 Plasma Workspace

BRANCH
  windy (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24483

To: ngraham, kossebau, #plasma, spstarr
Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24503: Integrate the normal keyboard layout switcher

[Aleix Pol Gonzalez]

apol added a comment.


  This got landed by arc together with another patch. I didn't mean to land it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24503

To: apol, #plasma
Cc: hein, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24666: Be explicit about X11 or Wayland for the dev session names

[Nathaniel Graham]

ngraham added a comment.


  @davidedmundson is this okay now given the decision in D22210 
? Or should we massage the strings some 
more?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24666

To: ngraham, fvogt, davidedmundson, apol, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D22210#547637 , @davidedmundson 
wrote:
  
  > 1. A period where both X and wayland say "Plasma".
  >
  >   1 is super super bad. Which means we need to patch one of the Plasma 
entries first. I would block this happening.
  
  
  It is the status quo for everyone using a DM other than SDDM on 
, so any decision here is going to be an improvement.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  +1
  but wait for fvogt and whoever else to ack.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner updated this revision to Diff 67992.
asturmlechner added a comment.


  Switch back to Plasma (Wayland)

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22210?vs=62165=67992

BRANCH
  arcpatch-D22210

REVISION DETAIL
  https://phabricator.kde.org/D22210

AFFECTED FILES
  login-sessions/plasmawayland.desktop.cmake

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Nathaniel Graham]

ngraham added a comment.


  In D22210#547637 , @davidedmundson 
wrote:
  
  > Ok, so there are exactly 3 outcomes of events.
  >
  > 1. A period where both X and wayland say "Plasma".
  > 2. A period where we see Plasma (X11) and Plasma
  > 3. A period where we see Plasma (wayland) (wayland) (a combo of 2 & 3 is 
also possible, but that seems pointless)
  >
  > 1 is super super bad. Which means we need to patch one of the Plasma 
entries first. I would block this happening.
  >
  > 2 (this patch) I don't like. It's not comparable with gnome because they 
have their wayland session by default. We currently do not. 
  >  I really don't like this, but if group concensus from Plasma is 
this...then ok.
  >
  > 3 not great, obviously looks super stupid, but it affects the fewest users. 
My preference.
  >
  > Hopefully it's mostly a non issue and we're overthinking it as all the 
really good distros can patch in sync if we send an email upfront.
  
  
  My thoughts exactly.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[David Edmundson]

davidedmundson added a comment.


  Ok, so there are exactly 3 outcomes of events.
  
  1. A period where both X and wayland say "Plasma".
  2. A period where we see Plasma (X11) and Plasma
  3. A period where we see Plasma (wayland) (wayland)
  
  (a combo of 2 & 3 is also possible, but that seems pointless)
  
  1 is super super bad. Which means we need to patch one of the Plasma entries 
first. I would block this happening.
  
  2 (this patch) I don't like. It's not comparable with gnome because they have 
their wayland session by default. We currently do not. 
  I really don't like this, but if group concensus from Plasma is this...then 
ok.
  
  3 not great, obviously looks super stupid, but it affects the fewest users. 
My preference.
  
  Hopefully it's mostly a non issue and we're overthinking it as all the really 
good distros can patch in sync if we send an email upfront.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24530: [XembedSNIProxy] If available, always use 32-bit color.

[Konrad Materka]

kmaterka added a comment.


  In D24530#547085 , @ngraham wrote:
  
  > FWIW since you landed this on master rather than `Plasma/5.17`, it will 
only be in Plasma 5.18, not 5.17.1.
  >
  > At this point, if it's critical to go into 5.17.1, you should cherry-pick 
the commit onto the `Plasma/5.17` branch since landing it there and merging 
forward is no longer possible.
  
  
  It is not critical, it can wait for 5.18.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24530

To: kmaterka, davidedmundson, #plasma_workspaces, #plasma
Cc: ngraham, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Andreas Sturmlechner]

asturmlechner added a comment.


  In D22210#547621 , @ngraham wrote:
  
  > "Plasma on Xorg" is a yucky string to display to users.
  
  
  well, it is what Gnome apparently does, so at least it would have lead to 
some uniformity. But no strong opinion here.
  
  In D22210#547621 , @ngraham wrote:
  
  > IMO it would be preferable to display "Plasma on Wayland (Wayland) for a 
limited period of time while the Plasma and SDDM versions aren't yet aligned.
  
  
  ...except I wasn't sure if you could call Plasma running "on" Wayland in the 
same sense as it is running "on" Xorg.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24666: Be explicit about X11 or Wayland for the dev session names

[Nathaniel Graham]

ngraham added a comment.


  In D24666#547625 , @davidedmundson 
wrote:
  
  > > Ideally https://github.com/sddm/sddm/pull/997 would get done first.
  >
  > Why would we want that first? It'd put us in the situation where we have 
two different things with the same name.
  
  
  My understanding of the SDDM PR in question is that it removes the 
"(Wayland)" suffix, which is desirable for this PR because then the dev session 
wouldn't have the word "Wayland" in it twice.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24666

To: ngraham, fvogt, davidedmundson, apol, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24666: Be explicit about X11 or Wayland for the dev session names

[David Edmundson]

davidedmundson added a comment.


  > Ideally https://github.com/sddm/sddm/pull/997 would get done first.
  
  Why would we want that first? It'd put us in the situation where we have two 
different things with the same name.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24666

To: ngraham, fvogt, davidedmundson, apol, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Nathaniel Graham]

ngraham added a comment.


  Got it.
  
  My very strong preference is to append the session name for Wayland, not X11. 
"Plasma on Xorg" is a yucky string to display to users. IMO it would be 
preferable to display "Plasma on Wayland (Wayland) for a limited period of time 
while the Plasma and SDDM versions aren't yet aligned. This redundancy would 
then have a built-in expiration date.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Fabian Vogt]

fvogt added a comment.


  In D22210#547608 , @ngraham wrote:
  
  > I thought this change was introduced with  0.18.1 though? Aren't distros 
with an old SDDM using something older than that?
  
  
  That pull request hasn't been merged yet, so all distros which haven't 
applied it manually would be affected.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Nathaniel Graham]

ngraham added a comment.


  I thought this change was introduced with  0.18.1 though? Aren't distros with 
an old SDDM using something older than that?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24666: Be explicit about X11 or Wayland for the dev session names

[Nathaniel Graham]

ngraham added a comment.


  In D24666#547565 , @fvogt wrote:
  
  > See https://phabricator.kde.org/D22210 for a discussion about this.
  >
  > > Maybe @fvogt can shed some light on the situation.
  >
  > We have https://github.com/sddm/sddm/pull/997 in sddm for consistency with 
non-Plasma sessions.
  
  
  Thank, all that makes sense. Ideally https://github.com/sddm/sddm/pull/997 
would get done first but I think this can go in now IMO. Better to be clear and 
redundant than confusing and terse, and developers who are the target users of 
this feature won't be confused if "Wayland" gets shown twice.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24666

To: ngraham, fvogt, davidedmundson, apol, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Fabian Vogt]

fvogt added a comment.


  In D22210#547602 , @ngraham wrote:
  
  > FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we 
would rename the sessions upstream here. My preference would be to make the 
Wayland session say "Plasma (Wayland)" rather than renaming the X11 session 
("Plasma on Xorg" sounds pretty awkward IMO)
  
  
  Which then results in "Plasma (Wayland) (Wayland)" on distros with old sddm. 
That's why this patch does it the other way around.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D22210: Fix Name conflict between plasma.desktop and plasmawayland.desktop

[Nathaniel Graham]

ngraham added a comment.


  FWIW to me https://github.com/sddm/sddm/pull/997 seems correct, and then we 
would rename the sessions upstream here. My preference would be to make the 
Wayland session say "Plasma (Wayland)" rather than renaming the X11 session 
("Plasma on Xorg" sounds pretty awkward IMO)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22210

To: asturmlechner, #plasma, davidedmundson, fvogt
Cc: ngraham, pino, rdieter, fvogt, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D24670: KCM fonts : Rearrange code

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Don't mix KFonts and FontAASettings method implementation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24670

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bport, #plasma, ervin, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24669: Port fonts KCM to KConfigXT

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24669

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontssettings.kcfg
  kcms/fonts/fontssettings.kcfgc
  kcms/fonts/package/contents/ui/main.qml

To: bport, #plasma, ervin, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24668: Simplify kcms cmake file

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24668

AFFECTED FILES
  kcms/CMakeLists.txt

To: bport, #plasma, ervin, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24666: [RFC] Be explicit about X11 or Wayland for the dev session names

[Fabian Vogt]

fvogt added a comment.


  See https://phabricator.kde.org/D22210 for a discussion about this.
  
  > Maybe @fvogt can shed some light on the situation.
  
  We have https://github.com/sddm/sddm/pull/997 in sddm for consistency with 
non-Plasma sessions.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24666

To: ngraham, fvogt, davidedmundson, apol, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24666: [RFC] Be explicit about X11 or Wayland for the dev session names

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: fvogt, davidedmundson, apol, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  I just switched to openSUSE Tumbleweed and noticed that the session names in 
SDDM's
  chooser don't include "X11" or "Wayland" like they do in other distros I've 
used before.
  
  This patch adds those identifiers into the translated string so it's always 
clear.
  
  This will probably result in the string being duplicated for other distros 
that manage
  to add the type automatically, which is why this is an RFC patch, Maybe 
@fvogt can shed
  some light on the situation.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  mention-x11-or-wayland (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24666

AFFECTED FILES
  login-sessions/plasmawayland-dev.desktop.cmake
  login-sessions/plasmax11-dev.desktop.cmake

To: ngraham, fvogt, davidedmundson, apol, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24664: [gmenu-dbusmenu-proxy] Don't create ~/.gtkrc-2.0

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
fvogt requested review of this revision.

REVISION SUMMARY
  BUG: 412970

TEST PLAN
  Not tested yet.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  gtkfix

REVISION DETAIL
  https://phabricator.kde.org/D24664

AFFECTED FILES
  gmenu-dbusmenu-proxy/menuproxy.cpp

To: fvogt, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24653: discover: check package status before trying to install/update it

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:dd9ba961d7e9: discover: check package status before 
trying to install/update it (authored by alnikiforov, committed by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24653?vs=67961=67977

REVISION DETAIL
  https://phabricator.kde.org/D24653

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

To: alnikiforov, jriddell, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Plasma 5.17 out

[Jonathan Riddell]

Plasma 5.17 is out now

https://kde.org/announcements/plasma-5.17.0.php

D24653: discover: check package status before trying to install/update it

[Aleksei Nikiforov]

alnikiforov added a comment.


  In D24653#547385 , @apol wrote:
  
  > Please submit to master.
  
  
  I've updated patch and removed additional parenthesis in condition. But I 
don't see how I can submit this change to repository, I probably don't have 
permissions for that action.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24653

To: alnikiforov, jriddell, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24649: Set new icon for battery applet

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6ae88953a37e: Set new icon for battery applet (authored 
by nicolasfella).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24649?vs=67935=67963

REVISION DETAIL
  https://phabricator.kde.org/D24649

AFFECTED FILES
  applets/batterymonitor/package/metadata.desktop

To: nicolasfella, #plasma, bshah, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24653: discover: check package status before trying to install/update it

[Aleksei Nikiforov]

alnikiforov updated this revision to Diff 67961.

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24653?vs=67941=67961

REVISION DETAIL
  https://phabricator.kde.org/D24653

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

To: alnikiforov, jriddell, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24653: discover: check package status before trying to install/update it

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Please submit to master.

INLINE COMMENTS

> PackageKitBackend.cpp:586
>  
> +if ((info == PackageKit::Transaction::InfoRemoving) || (info == 
> PackageKit::Transaction::InfoObsoleting)) {
> +// Don't try updating packages which need to be removed

Could you drop the unnecessary parenthesis?

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24653

To: alnikiforov, jriddell, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24517: Port kcm cursor to KConfigXT

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f53d7844fbb5: Port kcm cursor to KConfigXT (authored by 
bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24517?vs=67948=67951

REVISION DETAIL
  https://phabricator.kde.org/D24517

AFFECTED FILES
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24516: Cleanup CursorThemeConfig remove uneeded ; and remove unused variable / method

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:29f8346063a4: Cleanup CursorThemeConfig remove uneeded ; 
and remove unused variable / method (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24516?vs=67604=67950

REVISION DETAIL
  https://phabricator.kde.org/D24516

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, mart, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24519: Delegate KCM cursor theme config management to KConfigXT

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fec538fb02e0: Delegate KCM cursor theme config management 
to KConfigXT (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24519?vs=67949=67953

REVISION DETAIL
  https://phabricator.kde.org/D24519

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/cursortheme/package/contents/ui/main.qml

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24520: Fix a bug in KCM cursor theme, after applying change, cursor preview don't work

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8b2f75f13e0e: Fix a bug in KCM cursor theme, after 
applying change, cursor preview dont work (authored by bport).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24520?vs=67607=67954#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24520?vs=67607=67954

REVISION DETAIL
  https://phabricator.kde.org/D24520

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/cursortheme/xcursor/previewwidget.cpp
  kcms/cursortheme/xcursor/previewwidget.h

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24518: On KCM cursor theme update attribute name

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:186ab6e9b75e: On KCM cursor theme update attribute name 
(authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24518?vs=67608=67952

REVISION DETAIL
  https://phabricator.kde.org/D24518

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, mart, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24519: Delegate KCM cursor theme config management to KConfigXT

[Benjamin Port]

bport updated this revision to Diff 67949.
bport added a comment.


  Add notify to setPreferredSize

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24519?vs=67606=67949

REVISION DETAIL
  https://phabricator.kde.org/D24519

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/Delegate.qml
  kcms/cursortheme/package/contents/ui/main.qml

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24517: Port kcm cursor to KConfigXT

[Benjamin Port]

bport updated this revision to Diff 67948.
bport added a comment.


  Move install line to the good section

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24517?vs=67605=67948

REVISION DETAIL
  https://phabricator.kde.org/D24517

AFFECTED FILES
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/cursorthemesettings.kcfg
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 421 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/421/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 10 Oct 2019 11:41:07 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/79)19%
(67/350)19%
(67/350)15%
(4732/32415)12%
(2566/21044)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/355)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/242)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(915/2351)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
(0/3)0%
(0/386)0%
(0/224)kaccess0%
(0/3)0%
(0/3)0%

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 440 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/440/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 10 Oct 2019 03:37:07 +
 Build duration:
16 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.17.80.xmlacc/LibKWorkspace-5.17.80.xmlacc/LibNotificationManager-5.17.80.xmlacc/LibTaskManager-5.17.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.17.80/log.txtlogs/LibKWorkspace/5.17.80/log.txtlogs/LibNotificationManager/5.17.80/log.txtlogs/LibTaskManager/5.17.80/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/125)11%
(51/462)11%
(51/462)6%
(2566/41369)4%
(1260/28413)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.kicker.plugin0%
(0/38)0%
(0/38)0%
(0/3365)0%
(0/2630)applets.notifications0%
(0/6)0%
(0/6)0%
(0/185)0%
(0/78)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/278)0%
(0/223)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.containmentlayoutmanager0%
(0/10)0%
(0/10)0%
(0/1398)0%

D24519: Delegate KCM cursor theme config management to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kcmcursortheme.cpp:157
>  {
> -return m_selectedThemeRow;
> -}
> -
> -void CursorThemeConfig::setSelectedSizeRow(int row)
> -{
> -Q_ASSERT (row < m_sizesModel->rowCount() && row >= 0);
> -
> -// we don't return early if m_selectedSizeRow == row as this is called 
> after the model is changed
> -m_selectedSizeRow = row;
> -emit selectedSizeRowChanged();
> -
> -int size = m_sizesModel->item(row)->data().toInt();
> -
>  m_preferredSize = size;
>  }

Once you got the NOTIFY part of the property it'll be emitted from here.

> kcmcursortheme.h:50
>  Q_PROPERTY(bool downloadingFile READ downloadingFile NOTIFY 
> downloadingFileChanged)
> +Q_PROPERTY(int preferredSize READ preferredSize WRITE setPreferredSize)
>  

Should also have the NOTIFY part.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24519

To: bport, #plasma, mart, ervin
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24517: Port kcm cursor to KConfigXT

[Kevin Ottens]

ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.


  Just a last nitpick.

INLINE COMMENTS

> CMakeLists.txt:24
> +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc 
> GENERATE_MOC)
> +install(FILES cursorthemesettings.kcfg DESTINATION ${KDE_INSTALL_KCFGDIR})
>  add_library(kcm_cursortheme MODULE ${kcm_cursortheme_PART_SRCS})

Could that be moved in the install file section of the file? Everything related 
to file installs (but not target installs...) seems to be at the end of that 
file.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24517

To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24654: [Notifications] Don't bind model inside headerItem

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since Qt 5.12.5 and newer this causes infinite recursion in component 
creation as setting the `model` has `ListView` recreate its header item (among 
other things) since 
https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?h=5.12=692b2da77427259a3589cf8a1311075863f2f5ec
  
  See also https://bugzilla.redhat.com/show_bug.cgi?id=1758263

TEST PLAN
  5.12 only
  
  - Notifications work again and don't crash*
  - Turning on and off history works
  - Turning on and off notifications works
  
  I failed to reproduce in a simple test case for submitting a bug report. I 
tried having a `ListView` with a `header` that sets the `model` and `delegate` 
but all I could get was "Cannot create new component instance before completing 
the previous" but none of the recursion havoc or aborting component creation as 
in the notification applet :(

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24654

AFFECTED FILES
  applets/notifications/package/contents/ui/Notifications.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24653: discover: check package status before trying to install/update it

[Aleksei Nikiforov]

alnikiforov created this revision.
alnikiforov added reviewers: jriddell, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alnikiforov requested review of this revision.

REVISION SUMMARY
  With latest changes to packagekit, it may now return more packages from 
'pkcon get-updates' command with new statuses: "removed" or "obsoleted". This 
change is needed to filter such packages since Discover is using list of 
packages similar to the output of mentioned command but ignores package 
statuses. Otherwise, Discover would try to install all packages, including 
removed and obsoleted, and fail while trying to resolve such transaction due to 
package conflicts, if there are such packages present.
  
  packagekit changes:
  https://github.com/hughsie/PackageKit/pull/341

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24653

AFFECTED FILES
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp

To: alnikiforov, jriddell, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart