D25976: Use a default non-administrator user Type for new users in model

[Méven Car]

meven added a comment.


  In D25976#577353 , @ngraham wrote:
  
  > Thanks Méven! This fixes the case of creating a non-admin user. However 
while testing it, I found a regression from D25439 
: when I create an admin user that has a 
space in the Real Name field, the "Enable administror privileges for this user" 
checkbox becomes unchecked and it isn't actually created as an admin user. Do 
you think you could also fix that in this patch?
  
  
  This should be fixed now. Thanks for pointing this nasty bug.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D25976

To: meven, ngraham, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25976: Use a default non-administrator user Type for new users in model

[Méven Car]

meven updated this revision to Diff 71568.
meven added a comment.


  Code simplification

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25976?vs=71567&id=71568

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25976

AFFECTED FILES
  src/lib/accountmodel.cpp

To: meven, ngraham, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25976: Use a default non-administrator user Type for new users in model

[Méven Car]

meven updated this revision to Diff 71567.
meven added a comment.


  Set always a default value for role Administrator in m_newUserData

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25976?vs=71489&id=71567

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25976

AFFECTED FILES
  src/lib/accountmodel.cpp

To: meven, ngraham, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25952: [applets/taskmanager] Keep tooltip open when clicking on a thumbnail

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25952

To: ngraham, #plasma, #vdg, hein, ndavis
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25998: [Panel] Use open/closed grabby hand to communicate that panel widgets are draggable

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3044e078458b: [Panel] Use open/closed grabby hand to 
communicate that panel widgets are… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25998?vs=71532&id=71564

REVISION DETAIL
  https://phabricator.kde.org/D25998

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: ngraham, #vdg, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-framework » kf5-qt5 SUSEQt5.12 - Build # 256 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/kf5-qt5%20SUSEQt5.12/256/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Dec 2019 23:02:01 +
 Build duration:
4 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 1132 lines...][2019-12-14T23:05:18.232Z] Scanning dependencies of target plasma_appletscript_declarative_autogen[2019-12-14T23:05:18.232Z] [ 88%] Generating plasma-scriptengine-applet-declarative.json[2019-12-14T23:05:18.232Z] Scanning dependencies of target corebindingsplugin_autogen[2019-12-14T23:05:18.232Z] About to parse service type file "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/src/plasma/data/servicetypes/plasma-scriptengine.desktop"[2019-12-14T23:05:18.232Z] Found property definition "X-Plasma-ComponentTypes" with type "QStringList"[2019-12-14T23:05:18.232Z] Found property definition "X-Plasma-PackageFormat" with type "QString"[2019-12-14T23:05:18.232Z] Unknown property type for key "X-EngineName" -> falling back to string[2019-12-14T23:05:18.232Z] Unknown property type for key "X-Plasma-API" -> falling back to string[2019-12-14T23:05:18.232Z] Generated  "/home/jenkins/workspace/Plasma/plasma-framework/kf5-qt5 SUSEQt5.12/build/src/scriptengines/qml/plasma-scriptengine-applet-declarative.json" [2019-12-14T23:05:18.232Z] [2019-12-14T23:05:18.232Z] [ 88%] Automatic MOC for target corebindingsplugin[2019-12-14T23:05:18.232Z] [ 89%] Automatic MOC for target plasma_appletscript_declarative[2019-12-14T23:05:19.611Z] [ 89%] Built target plasma_appletscript_declarative_autogen[2019-12-14T23:05:19.611Z] Scanning dependencies of target configmodeltest[2019-12-14T23:05:19.611Z] [ 89%] Building CXX object autotests/CMakeFiles/configmodeltest.dir/configmodeltest_autogen/mocs_compilation.cpp.o[2019-12-14T23:05:19.611Z] Scanning dependencies of target dialognativetest[2019-12-14T23:05:19.611Z] [ 89%] Building CXX object autotests/CMakeFiles/dialognativetest.dir/dialognativetest_autogen/mocs_compilation.cpp.o[2019-12-14T23:05:19.871Z] [ 89%] Built target corebindingsplugin_autogen[2019-12-14T23:05:19.871Z] [ 89%] Building CXX object autotests/CMakeFiles/configmodeltest.dir/configmodeltest.cpp.o[2019-12-14T23:05:19.871Z] Scanning dependencies of target framesvgtest[2019-12-14T23:05:19.871Z] [ 90%] Building CXX object autotests/CMakeFiles/framesvgtest.dir/framesvgtest_autogen/mocs_compilation.cpp.o[2019-12-14T23:05:20.437Z] [ 91%] Linking CXX executable ../bin/dialogstatetest[2019-12-14T23:05:20.437Z] [ 91%] Linking CXX shared module ../../../bin/kpackage/packagestructure/plasmageneric_packagestructure.so[2019-12-14T23:05:21.012Z] [ 91%] Built target plasmageneric_packagestructure[2019-12-14T23:05:21.276Z] [ 91%] Built target dialogstatetest[2019-12-14T23:05:21.920Z] [ 92%] Linking CXX executable ../bin/dialogqmltest[2019-12-14T23:05:22.196Z] [ 92%] Linking CXX executable ../bin/themetest[2019-12-14T23:05:22.196Z] [ 93%] Building CXX object autotests/CMakeFiles/dialognativetest.dir/dialognativetest.cpp.o[2019-12-14T23:05:22.196Z] [ 93%] Building CXX object autotests/CMakeFiles/framesvgtest.dir/framesvgtest.cpp.o[2019-12-14T23:05:22.782Z] [ 93%] Built target dialogqmltest[2019-12-14T23:05:22.782Z] [ 93%] Linking CXX executable ../bin/configmodeltest[2019-12-14T23:05:23.057Z] [ 93%] Built target themetest[2019-12-14T23:05:23.651Z] [ 93%] Built target configmodeltest[2019-12-14T23:05:24.247Z] [ 93%] Linking CXX executable ../bin/framesvgtest[2019-12-14T23:05:24.521Z] [ 93%] Linking CXX executable ../bin/dialognativetest[2019-12-14T23:05:24.783Z] [ 93%] Built target framesvgtest[2019-12-14T23:05:25.355Z] [ 93%] Built target dialognativetest[2019-12-14T23:05:25.355Z] [ 93%] Generating qrc_shaders.cpp[2019-12-14T23:05:25.355Z] Scanning dependencies of target corebindingsplugin[2019-12-14T23:05:25.355Z] [ 93%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin_autogen/mocs_compilation.cpp.o[2019-12-14T23:05:28.633Z] [ 93%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/svgitem.cpp.o[2019-12-14T23:05:30.552Z] [ 93%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/fadingnode.cpp.o[2019-12-14T23:05:32.466Z] [ 94%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/framesvgitem.cpp.o[2019-12-14T23:05:34.373Z] [ 94%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/quicktheme.cpp.o[2019-12-14T23:05:35.748Z] [ 94%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/tooltip.cpp.o[2019-12-14T23:05:37.121Z] [ 94%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/tooltipdialog.cpp.o[2019-12-14T23:05:38.055Z] [ 95%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/serviceoperationstatus.cpp.o[2019-12-14T23:05:38.986Z] [ 95%] Building CXX 

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 SUSEQt5.12 - Build # 251 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20SUSEQt5.12/251/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Dec 2019 23:02:01 +
 Build duration:
3 min 27 sec and counting
   CONSOLE OUTPUT
  [...truncated 1103 lines...][2019-12-14T23:05:14.303Z] [ 86%] Generating plasma-scriptengine-applet-declarative.json[2019-12-14T23:05:14.567Z] [ 86%] Automatic MOC for target corebindingsplugin[2019-12-14T23:05:14.567Z] About to parse service type file "/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/src/plasma/data/servicetypes/plasma-scriptengine.desktop"[2019-12-14T23:05:14.567Z] Found property definition "X-Plasma-ComponentTypes" with type "QStringList"[2019-12-14T23:05:14.567Z] Found property definition "X-Plasma-PackageFormat" with type "QString"[2019-12-14T23:05:14.567Z] Unknown property type for key "X-EngineName" -> falling back to string[2019-12-14T23:05:14.567Z] Unknown property type for key "X-Plasma-API" -> falling back to string[2019-12-14T23:05:14.567Z] Generated  "/home/jenkins/workspace/Plasma/plasma-framework/stable-kf5-qt5 SUSEQt5.12/build/src/scriptengines/qml/plasma-scriptengine-applet-declarative.json" [2019-12-14T23:05:14.567Z] [2019-12-14T23:05:14.567Z] [ 87%] Automatic MOC for target plasma_appletscript_declarative[2019-12-14T23:05:15.154Z] [ 87%] Built target plasma_appletscript_declarative_autogen[2019-12-14T23:05:15.154Z] Scanning dependencies of target dialognativetest_autogen[2019-12-14T23:05:15.154Z] [ 87%] Automatic MOC for target dialognativetest[2019-12-14T23:05:15.419Z] [ 87%] Built target corebindingsplugin_autogen[2019-12-14T23:05:15.419Z] Scanning dependencies of target configmodeltest_autogen[2019-12-14T23:05:15.419Z] [ 88%] Automatic MOC for target configmodeltest[2019-12-14T23:05:15.419Z] [ 88%] Built target dialognativetest_autogen[2019-12-14T23:05:15.419Z] [ 88%] Generating qrc_shaders.cpp[2019-12-14T23:05:15.678Z] Scanning dependencies of target corebindingsplugin[2019-12-14T23:05:15.678Z] [ 88%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin_autogen/mocs_compilation.cpp.o[2019-12-14T23:05:15.678Z] [ 88%] Built target configmodeltest_autogen[2019-12-14T23:05:15.678Z] [ 88%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin.cpp.o[2019-12-14T23:05:15.678Z] Scanning dependencies of target plasma_appletscript_declarative[2019-12-14T23:05:15.678Z] [ 88%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasma_appletscript_declarative_autogen/mocs_compilation.cpp.o[2019-12-14T23:05:17.060Z] Scanning dependencies of target themetest_autogen[2019-12-14T23:05:17.060Z] [ 89%] Automatic MOC for target themetest[2019-12-14T23:05:17.060Z] [ 90%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/declarativeappletscript.cpp.o[2019-12-14T23:05:17.060Z] [ 90%] Built target themetest_autogen[2019-12-14T23:05:17.060Z] [ 91%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/colorscope.cpp.o[2019-12-14T23:05:17.060Z] Scanning dependencies of target dialogstatetest_autogen[2019-12-14T23:05:17.060Z] Scanning dependencies of target dialogqmltest_autogen[2019-12-14T23:05:17.060Z] [ 91%] Automatic MOC for target dialogstatetest[2019-12-14T23:05:17.382Z] [ 91%] Automatic MOC for target dialogqmltest[2019-12-14T23:05:17.641Z] [ 91%] Built target dialogstatetest_autogen[2019-12-14T23:05:17.641Z] [ 91%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datamodel.cpp.o[2019-12-14T23:05:17.641Z] Scanning dependencies of target iconitemtest_autogen[2019-12-14T23:05:17.641Z] [ 91%] Automatic MOC for target iconitemtest[2019-12-14T23:05:17.641Z] [ 91%] Built target dialogqmltest_autogen[2019-12-14T23:05:17.641Z] [ 91%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/appletinterface.cpp.o[2019-12-14T23:05:17.641Z] Scanning dependencies of target pluginloadertest_autogen[2019-12-14T23:05:17.641Z] [ 91%] Automatic MOC for target pluginloadertest[2019-12-14T23:05:18.207Z] [ 91%] Built target pluginloadertest_autogen[2019-12-14T23:05:18.207Z] Scanning dependencies of target framesvgtest_autogen[2019-12-14T23:05:18.207Z] [ 91%] Automatic MOC for target framesvgtest[2019-12-14T23:05:18.207Z] [ 91%] Built target iconitemtest_autogen[2019-12-14T23:05:18.466Z] Scanning dependencies of target dialognativetest[2019-12-14T23:05:18.466Z] [ 91%] Building CXX object autotests/CMakeFiles/dialognativetest.dir/dialognativetest_autogen/mocs_compilation.cpp.o[2019-12-14T23:05:18.466Z] [ 91%] Built target framesvgtest_autogen[2019-12-14T23:05:18.726Z] Scanning dependencies of target configmodeltest[2019-12-14T23:05:18.726Z] [ 91%] Building CXX object autotests/CMakeFiles/configmodeltest.dir/con

KDE CI: Plasma » plasma-framework » stable-kf5-qt5 FreeBSDQt5.13 - Build # 121 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-framework/job/stable-kf5-qt5%20FreeBSDQt5.13/121/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Dec 2019 23:02:01 +
 Build duration:
2 min 49 sec and counting
   CONSOLE OUTPUT
  [...truncated 1094 lines...][2019-12-14T23:04:26.577Z] Scanning dependencies of target pluginloadertest[2019-12-14T23:04:26.577Z] [ 90%] Building CXX object autotests/CMakeFiles/pluginloadertest.dir/pluginloadertest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:26.577Z] [ 90%] Built target iconitemtest_autogen[2019-12-14T23:04:26.577Z] [ 90%] Built target themetest_autogen[2019-12-14T23:04:26.577Z] [ 90%] Built target plasma_appletscript_declarative_autogen[2019-12-14T23:04:26.577Z] [ 90%] Built target dialognativetest_autogen[2019-12-14T23:04:26.577Z] [ 90%] Built target framesvgtest_autogen[2019-12-14T23:04:26.577Z] [ 90%] Building CXX object autotests/CMakeFiles/pluginloadertest.dir/pluginloadertest.cpp.o[2019-12-14T23:04:26.577Z] Scanning dependencies of target dialogstatetest[2019-12-14T23:04:26.577Z] Scanning dependencies of target themetest[2019-12-14T23:04:26.577Z] [ 90%] Building CXX object autotests/CMakeFiles/dialogstatetest.dir/dialogstatetest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:26.577Z] [ 90%] Building CXX object autotests/CMakeFiles/dialogstatetest.dir/dialogstatetest.cpp.o[2019-12-14T23:04:26.577Z] [ 90%] Building CXX object autotests/CMakeFiles/themetest.dir/themetest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:26.577Z] [ 90%] Building CXX object autotests/CMakeFiles/themetest.dir/themetest.cpp.o[2019-12-14T23:04:26.577Z] Scanning dependencies of target iconitemtest[2019-12-14T23:04:26.577Z] Scanning dependencies of target dialogqmltest[2019-12-14T23:04:26.577Z] [ 90%] Built target corebindingsplugin_autogen[2019-12-14T23:04:26.577Z] [ 90%] Generating qrc_shaders.cpp[2019-12-14T23:04:26.577Z] [ 91%] Building CXX object autotests/CMakeFiles/iconitemtest.dir/iconitemtest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:26.577Z] [ 91%] Building CXX object autotests/CMakeFiles/dialogqmltest.dir/dialogqmltest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:27.182Z] [ 91%] Built target configmodeltest_autogen[2019-12-14T23:04:27.182Z] Scanning dependencies of target corebindingsplugin[2019-12-14T23:04:27.182Z] [ 91%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:27.182Z] Scanning dependencies of target plasma_appletscript_declarative[2019-12-14T23:04:27.445Z] [ 91%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasma_appletscript_declarative_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:28.391Z] [ 91%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/corebindingsplugin.cpp.o[2019-12-14T23:04:28.391Z] [ 91%] Linking CXX executable ../bin/pluginloadertest[2019-12-14T23:04:28.391Z] [ 91%] Building CXX object autotests/CMakeFiles/dialogqmltest.dir/dialogqmltest.cpp.o[2019-12-14T23:04:28.391Z] [ 91%] Building CXX object autotests/CMakeFiles/iconitemtest.dir/iconitemtest.cpp.o[2019-12-14T23:04:28.665Z] Scanning dependencies of target dialognativetest[2019-12-14T23:04:28.665Z] [ 91%] Linking CXX executable ../bin/themetest[2019-12-14T23:04:28.665Z] [ 91%] Building CXX object autotests/CMakeFiles/dialognativetest.dir/dialognativetest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:28.665Z] [ 91%] Built target pluginloadertest[2019-12-14T23:04:28.665Z] [ 92%] Building CXX object src/scriptengines/qml/CMakeFiles/plasma_appletscript_declarative.dir/plasmoid/declarativeappletscript.cpp.o[2019-12-14T23:04:28.665Z] [ 93%] Linking CXX executable ../bin/dialogstatetest[2019-12-14T23:04:28.665Z] Scanning dependencies of target framesvgtest[2019-12-14T23:04:28.938Z] [ 93%] Built target themetest[2019-12-14T23:04:28.938Z] [ 93%] Building CXX object autotests/CMakeFiles/framesvgtest.dir/framesvgtest.cpp.o[2019-12-14T23:04:28.938Z] [ 94%] Building CXX object autotests/CMakeFiles/framesvgtest.dir/framesvgtest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:28.938Z] [ 94%] Built target dialogstatetest[2019-12-14T23:04:29.197Z] Scanning dependencies of target configmodeltest[2019-12-14T23:04:29.197Z] [ 94%] Building CXX object autotests/CMakeFiles/configmodeltest.dir/configmodeltest_autogen/mocs_compilation.cpp.o[2019-12-14T23:04:30.622Z] [ 95%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/colorscope.cpp.o[2019-12-14T23:04:30.623Z] [ 96%] Building CXX object autotests/CMakeFiles/dialognativetest.dir/dialognativetest.cpp.o[2019-12-14T23:04:30.623Z] [ 96%] Building CXX object src/declarativeimports/core/CMakeFiles/corebindingsplugin.dir/datamodel.cpp.o[2019-12-14T23:04:30.623Z] [ 96%] Linking CXX executable ../bin/framesvgtest[2019-12-14T23:04:30.623Z] [ 97%] Linking CXX executable ../bi

D25967: Emit panelTakesFocus for other plamsashell types

[Aleix Pol Gonzalez]

apol added a comment.


  I'm not sure that I'm misunderstanding, does this mean that notifications 
might steal focus?

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25967

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25584: [TabBar] Add a border property

[Nathaniel Graham]

ngraham added a comment.


  Well, there's a use case for a tab bar with a line below the tabs, but not a 
full frame. See for example tabs in Dolphin, Konsole, and Okular. I guess the 
question is whether it makes sense to have the tab bar draw the line itself.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25584

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: mart, ahiemstra, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D25584: [TabBar] Add a border property

[Filip Fila]

filipf added a comment.


  Ping, anyone know if we can just delete this Rectangle I called "frame"?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25584

To: filipf, #plasma, #vdg, ngraham, broulik
Cc: mart, ahiemstra, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23876: [applets/kickoff] Tweak padding for lists

[Filip Fila]

filipf abandoned this revision.
filipf added a comment.


  Don't want to go through with this anymore because I've had a look at other 
views and they always sharply cut off content horizontally. For example:
  
  F7818671: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23876

To: filipf, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25971: Use text color for "No preview image" text

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R123:7e13183d044b: Use text color for "No preview 
image" text (authored by filipf).

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25971?vs=71482&id=71560

REVISION DETAIL
  https://phabricator.kde.org/D25971

AFFECTED FILES
  src/themesdelegate.cpp

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Noah Davis]

ndavis added a comment.


  In D19890#577833 , 
@hpereiradacosta wrote:
  
  > As a side remark: did you check how it looks when one selects "text under 
icon" or "text beside icon" for toolbar button ?
  
  
  There is no problem with text, even if you set the font size to something 
outrageous like 20pts.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D26002: [KCMs/Night Color] Fix 1-digit minutes representation

[Ismael Asensio]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:275195373cf1: [KCMs/Night Color] Fix 1-digit minutes 
representation (authored by iasensio).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26002?vs=71549&id=71554

REVISION DETAIL
  https://phabricator.kde.org/D26002

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/TimingsView.qml

To: iasensio, #plasma, #vdg, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26002: [nightcolor] Fix 1-digit minutes representation

[Ismael Asensio]

iasensio created this revision.
iasensio added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
iasensio requested review of this revision.

REVISION SUMMARY
  On automatic time modes, minutes 0-9 were represented only with 1-digit
  (i.e 8:0 instead of 8:00)

TEST PLAN
  Example Lat: 40.4 Lon: -3.7 
  (or travel to a place where sunrise starts at 8:00AM)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix_pretty_time

REVISION DETAIL
  https://phabricator.kde.org/D26002

AFFECTED FILES
  kcms/nightcolor/package/contents/ui/TimingsView.qml

To: iasensio, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:80650e0e873d: Fix rubberband selection outline position 
(authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26001?vs=71547&id=71548

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis updated this revision to Diff 71547.
ndavis added a comment.


  fix code style

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26001?vs=71546&id=71547

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis updated this revision to Diff 71546.
ndavis edited the test plan for this revision.
ndavis added a comment.


  Remove opacity change

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26001?vs=71545&id=71546

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis added a comment.


  In D26001#577830 , 
@hpereiradacosta wrote:
  
  > I would avoid changing the alpha of the color though because: it makes no 
difference, and it is unrelated to the issue. Should be a different commit 
(which you can do without review if you really think it is important)
  
  
  It's not important, it's just nice if I can move it slightly up to an easy to 
express percentage (19.60784313725490% vs 20%)

REPOSITORY
  R31 Breeze

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D19890: Reduce the indicator arrow size for press-and-hold menus in QToolButtons

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  As a side remark: did you check how it looks when one selects "text under 
icon" or "text beside icon" for toolbar button ?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19890

To: hallas, #vdg, #breeze, ngraham, abetts, ndavis
Cc: ndavis, abetts, hpereiradacosta, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D26001: Fix rubberband selection outline position

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Fix is legit. Thanks ! 
  I would avoid changing the alpha of the color though because: it makes no 
difference, and it is unrelated to the issue. Should be a different commit 
(which you can do without review if you really think it is important)
  
  Fix it then ship it !

REPOSITORY
  R31 Breeze

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis added a reviewer: broulik.
ndavis added a comment.


  @broulik Does this fix the problem for you?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26001

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, broulik
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, 
ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, 
ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, 
mbohlender, mart

D26001: Fix rubberband selection outline position

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze, Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Before this patch, the outline of the rubberband selection control was down 
and to the right half a pixel too far.
  This wasn't visible at 1x scaling because of the lack of antialiasing, but 
resulted in the top/left being too thin and bottom/right being too thick on 
high DPI displays.
  To fix the issue, I enabled antialiasing and moved all sides inwards by half 
a pixel so that the outline would be pixel perfect.
  I also added a function to get a QRectF with the correct size and position 
for rectangles with pen strokes.

TEST PLAN
  - Open dolphin and make a selection with the mouse
  - Go to a Folder View Plasma widget and make a selection with the mouse

REPOSITORY
  R31 Breeze

BRANCH
  fix-rubberband (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26001

AFFECTED FILES
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

[Filip Fila]

filipf updated this revision to Diff 71542.
filipf added a comment.


  - Use grid delegate subtitle to state "Follows color scheme"
  - Consequently remove the icon tooltip that said the same

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25785?vs=71018&id=71542

BRANCH
  little-color-sign (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25785

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/ThemePreview.qml
  kcms/desktoptheme/package/contents/ui/main.qml

To: filipf, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Lovely

REPOSITORY
  R120 Plasma Workspace

BRANCH
  circular_timeout

REVISION DETAIL
  https://phabricator.kde.org/D25993

To: ahiemstra, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Luuurvley!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  circular_timeout

REVISION DETAIL
  https://phabricator.kde.org/D25993

To: ahiemstra, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> bruns wrote in kfileplacesmodel.cpp:758
> you have dropped the `allowedHere` check. Probably just `if (!allowedHere) 
> continue`.
> 
> And for reasons unknown to me, `tags:` is not filtered per app - move the 
> allowedHere check to the very beginning of the `while(...)` loop.

Devices are always allowed. The old check was

  if (isSupportedScheme && ((isSupportedUrl && ... && allowedHere) || 
deviceAvailable)) 

so `deviceAvailable` trumps `allowedHere`

> bruns wrote in kfileplacesmodel.cpp:759
> Does KFilePlacesItem have a move constructor? You can do the heap allocation 
> then only if necessary.

It does not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham, bruns
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  UI and functionality seem spot-on to me!

REPOSITORY
  R114 Plasma Addons

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

To: zzag, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 71539.
ahiemstra added a comment.


  - Explicitly set opacity

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25993?vs=71534&id=71539

BRANCH
  circular_timeout

REVISION DETAIL
  https://phabricator.kde.org/D25993

AFFECTED FILES
  CMakeLists.txt
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ahiemstra, #plasma, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25947: Add applet for controlling Night Color

[Vlad Zahorodnii]

zzag updated this revision to Diff 71537.
zzag added a comment.


  Nate's suggestion.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25947?vs=71479&id=71537

BRANCH
  nightcolor-applet

REVISION DETAIL
  https://phabricator.kde.org/D25947

AFFECTED FILES
  applets/CMakeLists.txt
  applets/nightcolor/CMakeLists.txt
  applets/nightcolor/Messages.sh
  applets/nightcolor/package/contents/ui/main.qml
  applets/nightcolor/package/metadata.desktop
  applets/nightcolor/plugin/CMakeLists.txt
  applets/nightcolor/plugin/inhibitor.cpp
  applets/nightcolor/plugin/inhibitor.h
  applets/nightcolor/plugin/monitor.cpp
  applets/nightcolor/plugin/monitor.h
  applets/nightcolor/plugin/monitor_p.h
  applets/nightcolor/plugin/plugin.cpp
  applets/nightcolor/plugin/plugin.h
  applets/nightcolor/plugin/qmldir

To: zzag, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

[Nathaniel Graham]

ngraham added a comment.


  Never mind, I decided to submit it: D25999 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25785

To: filipf, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> NotificationHeader.qml:220
> +
> +opacity: notificationHeading.remainingTime > 0 && 
> notificationHeading.remainingTime < notificationHeading.timeout
> +Behavior on opacity {

explicitly set to 0 and 1 rather than relying on implicit type conversion

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25993

To: ahiemstra, #plasma, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25945: Sync dark theme preference for GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D25945#577677 , @cblack wrote:
  
  > For flatpaks not respecting the setting preference, have you checked that 
the dark theme variant is installed?
  
  
  Yes, I have installed the theme. But after changing the value in gtk configs 
nothing happens. It could also be the result of my local setup bugs (because as 
the @GB_2 said, the patch works for him flawlessly). So I think he (or someone 
else) should test it.
  
  There is a bug  about flatpak 
not using selected GTK theme on X11. It is because it can only be done by 
letting the xsettingd to control the theme of the flatpak app. So, to test 
dark-theme preference sync you need to add to the 
`~/.config/xsettingsd/xsettingsd.conf` this line:
  
Net/ThemeName "Adwaita"
  
  check the dark theme preference checkbox in old GTK KCM and then relaunch 
xsettingsd. The flatpak app should be dark.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  sync-dark-gtk3-theme-preference (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25945

To: gikari, apol, cblack, broulik, #vdg
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 71534.
ahiemstra added a comment.


  - Re-add hiding behaviour on mouse over

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25993?vs=71533&id=71534

BRANCH
  circular_timeout

REVISION DETAIL
  https://phabricator.kde.org/D25993

AFFECTED FILES
  CMakeLists.txt
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ahiemstra, #plasma, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Nathaniel Graham]

ngraham added a comment.


  Yay, the alignment is perfect now. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25993

To: ahiemstra, #plasma, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 71533.
ahiemstra added a comment.


  - Remove limiting to just showing the last 10 seconds
  - Replace ToolButton IconItem with custom to fix alignment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25993?vs=71526&id=71533

BRANCH
  circular_timeout

REVISION DETAIL
  https://phabricator.kde.org/D25993

AFFECTED FILES
  CMakeLists.txt
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ahiemstra, #plasma, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25998: [Panel] Use open/closed grabby hand to communicate that panel widgets are draggable

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Improve the visual hints that widgets are draggable while in panel edit mode. 
Needed to
  bump the QtQuick import to make `mouseArea.containsPress` available.

TEST PLAN
  F7818223: demo-2019-12-14_17.48.30.webm 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-grabby-hand (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25998

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> kfileplacesmodel.cpp:758
> +KFilePlacesItem *item = nullptr;
> +if (deviceAvailable) {
> +item = new KFilePlacesItem(bookmarkManager, 
> bookmark.address(), udi);

you have dropped the `allowedHere` check. Probably just `if (!allowedHere) 
continue`.

And for reasons unknown to me, `tags:` is not filtered per app - move the 
allowedHere check to the very beginning of the `while(...)` loop.

> kfileplacesmodel.cpp:759
> +if (deviceAvailable) {
> +item = new KFilePlacesItem(bookmarkManager, 
> bookmark.address(), udi);
> +if (!item->hasSupportedScheme(supportedSchemes)) {

Does KFilePlacesItem have a move constructor? You can do the heap allocation 
then only if necessary.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham
Cc: bruns, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25945: Sync dark theme preference for GTK3 applications

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  Code looks fine to me.
  
  For flatpaks not respecting the setting preference, have you checked that the 
dark theme variant is installed? f-d-o runtime doesn't offer an Adwaita-dark 
stub, while GNOME runtime does.
  
  As for xsettingsd, I'm not sure if it synchronises the dark theme preference. 
That doesn't appear to be in the xsettings spec afaik.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  sync-dark-gtk3-theme-preference (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25945

To: gikari, apol, cblack, broulik, #vdg
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25670: Synchronize decorations buttons order in GTK headerbars

[Björn Feber]

GB_2 added a comment.


  Works great!

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25670

To: gikari, #vdg, cblack, #plasma
Cc: GB_2, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25992: [Wizard] Allow choosing device by double click

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  True enough. This is for sure a nice improvement. I always appreciate it when 
double-click is a shortcut for "select this thing and the open/apply it."

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D25992

To: broulik, #plasma, drosca, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25945: Sync dark theme preference for GTK3 applications

[Björn Feber]

GB_2 added a comment.


  Works perfectly fine for me without waiting.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25945

To: gikari, apol, cblack, broulik, #vdg
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25992: [Wizard] Allow choosing device by double click

[Kai Uwe Broulik]

broulik added a comment.


  I think you can't. It is potentially a long list, so not sure if just 
clicking it should advance the list, since it is clearly a "wizard" pattern 
page. If it were a bunch of "command links" it would be obvious that clicking a 
single item would advance the wizard.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D25992

To: broulik, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Nathaniel Graham]

ngraham added a comment.


  So lovely! Because the layout respects the font metrics, aligning it 
perfectly within the close button might be a bit of a bear though. I'm using 
Ubuntu 11 as my font and I see this: F7818159: Screenshot_20191214_170729.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25993

To: ahiemstra, #plasma, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25992: [Wizard] Allow choosing device by double click

[Nathaniel Graham]

ngraham added a comment.


  Is there anything you can do with an item here other than selecting it? If 
not, then we should just always choose by single-click. Double-click only makes 
sense for items that have a distinct selection state that lets you do more 
things with the item (or when using the apply/cancel model, as in KCMs).

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D25992

To: broulik, #plasma, drosca, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25993: Use KQuickCharts to render notification timeout as a circular progress bar

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added reviewers: Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This uses the new KQuickCharts framework to render the notification timeout 
bar as a small
  circular progress bar, around the close button.
  
  Video:

TEST PLAN
  notify-send -t 15000 test will first show a notification with no indicator, 
then once the 
  timeout gets to 10s or less it will show a decreasing circular progress bar.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  circular_timeout

REVISION DETAIL
  https://phabricator.kde.org/D25993

AFFECTED FILES
  CMakeLists.txt
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  applets/notifications/package/contents/ui/NotificationPopup.qml

To: ahiemstra, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25992: [Wizard] Allow choosing device by double click

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, drosca, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Instead of having to select one and clicking "Next"

TEST PLAN
  Clicked New device, double clicked some device and got it paired

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D25992

AFFECTED FILES
  src/wizard/pages/discover.cpp
  src/wizard/pages/discover.h

To: broulik, #plasma, drosca, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh so nice.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

To: broulik, #frameworks, dfaure, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25970: [applet] Make details text fully opaque and normal style

[Nathaniel Graham]

ngraham added a comment.


  And done in Bluedevil as well with 6f27fd5027a67b52f44222eb5e4a03dbaace4dd7 
.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D25970

To: ngraham, #vdg, jgrulich, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25970: [applet] Make details text fully opaque and normal style

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:00be92a520e6: [applet] Make details text fully opaque and 
normal style (authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25970?vs=71478&id=71524

REVISION DETAIL
  https://phabricator.kde.org/D25970

AFFECTED FILES
  applet/contents/ui/DetailsText.qml

To: ngraham, #vdg, jgrulich, ndavis
Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25991: [KFilePlacesModel] Fix supported scheme check for devices

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Frameworks, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  A device doesn't usually have a URL so we need to actutally check the 
underlying device (e.g. StorageAccess or NetworkShare) for whether it is 
supported.

TEST PLAN
  - `kdialog --getopenfilename ~` now has my mounted ISOs and external storage 
now
  - didn't test with CD drives or network shares
  - KFilePlaces tests stil pass

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25991

AFFECTED FILES
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp

To: broulik, #frameworks, dfaure
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Nathaniel Graham]

ngraham added a comment.


  Oh, I see.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: fabianr, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Christian]

Fuchs added a comment.


  Then as soon as you actually run the app there will be a duplicate, the 
launcher and the entry in the task manager. If I understood correctly, pinned 
tabs in browsers avoid that. You have a small, icon only variant when not open 
and a full variant (at the same position) when open.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: fabianr, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Nathaniel Graham]

ngraham added a comment.


  I'm talking about an actual launcher widget in the panel, nothing to do with 
the Task Manager's own pinning support. Launcher widgets in the panel are used 
for launching apps and will never move around, which is exactly what this patch 
is implementing within the Task Manager, if I'm understanding it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: fabianr, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Christian]

Fuchs added a comment.


  If I remember correctly, the main argument against the launcher was that 
pinned apps should be pinned and thus not change their location / order, but 
exactly that would happen with a launcher once you open the app (that, or a 
duplicate entry in the window list)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: fabianr, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Nathaniel Graham]

ngraham added a comment.


  It occurs to me that this is basically the exact use case for adding a 
launcher widget to the panel, and using it would be an almost identical final 
user experience. In both cases, you wind up with an immovable launcher that 
doesn't change its location in response to launching the app. Since we can't 
really get rid of the concept of the launcher widget, I worry that if we add 
this, we'll have two ways to accomplish the exact same goal.
  
  Thoughts?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: fabianr, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25785: [Plasma Style KCM] Add a color-wheel sign denoting the theme supports the system color scheme

[Nathaniel Graham]

ngraham added a comment.


  How about this?
  
  F7818015: Screenshot_20191214_151602.png 

  
  Here's a KDeclarative patch to add an optional subtitle that you can use if 
you think this looks good is is a good starting point: 
  P508 KDeclarative patch in support of D25785 

  
  And then you'd just add `subtitle: model.followsSystemColors ? i18n("Follows 
color scheme") : undef` to the delegate in this patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25785

To: filipf, #plasma, #vdg
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25990: Simplify android checks in cmake

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R169 Kirigami

BRANCH
  andro

REVISION DETAIL
  https://phabricator.kde.org/D25990

AFFECTED FILES
  CMakeLists.txt
  examples/staticcmake/src/CMakeLists.txt
  src/CMakeLists.txt
  src/libkirigami/CMakeLists.txt

To: nicolasfella, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25989: Don't build and install app templates on android

[Jonah Brüchert]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:3bc41934f9d6: Don't build and install app templates 
on android (authored by jbbgameich).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25989?vs=71517&id=71518

REVISION DETAIL
  https://phabricator.kde.org/D25989

AFFECTED FILES
  CMakeLists.txt

To: jbbgameich, #kirigami, #android, nicolasfella
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik added a comment.


  Sounds good to me lol

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25989: Don't build and install app templates on android

[Jonah Brüchert]

jbbgameich updated this revision to Diff 71517.
jbbgameich added a comment.


  Follow suggestion

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25989?vs=71516&id=71517

BRANCH
  android-no-app-templates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25989

AFFECTED FILES
  CMakeLists.txt

To: jbbgameich, #kirigami, #android
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25989: Don't build and install app templates on android

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> CMakeLists.txt:123
>  add_subdirectory(src)
> -add_subdirectory(templates)
> +if (NOT CMAKE_SYSTEM_NAME STREQUAL "Android")
> +add_subdirectory(templates)

if(ANDROID) is enough

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25989

To: jbbgameich, #kirigami, #android
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25989: Don't build and install app templates on android

[Nicolas Fella]

nicolasfella added inline comments.

INLINE COMMENTS

> nicolasfella wrote in CMakeLists.txt:123
> if(ANDROID) is enough

if (NOT ANDROID) obviously

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25989

To: jbbgameich, #kirigami, #android
Cc: nicolasfella, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, mart, hein

D25989: Don't build and install app templates on android

[Jonah Brüchert]

jbbgameich created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
jbbgameich requested review of this revision.

REVISION SUMMARY
  They increase apk sizes and are really not required in an apk.

REPOSITORY
  R169 Kirigami

BRANCH
  android-no-app-templates (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25989

AFFECTED FILES
  CMakeLists.txt

To: jbbgameich
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25889: Polish the "review this review" UI and presentation

[Nathaniel Graham]

ngraham added a comment.


  I find that the current one takes up too much vertical space and the top line 
of text blends too much into the review itself. I feel like those issues should 
be addressed somehow. Maybe this isn't the right way, so suggestions would be 
appreciated.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D25889

To: ngraham, #vdg, apol, #discover_software_store
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23876: [applets/kickoff] Tweak padding for lists

[Nathaniel Graham]

ngraham added a comment.


  Ping!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23876

To: filipf, #vdg, #plasma, ngraham
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25374: [ResultDelegate] Fix bad text legiblity with certain 3rd party themes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me, and the code looks like it's doing the right thing. Did you 
kill and relaunch krunner?

REPOSITORY
  R112 Milou

BRANCH
  fix-bad-text-legibility (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25374

To: filipf, #plasma, #vdg, ngraham
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25986: Resize file dialog window before size restore

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:2e9f96847432: Resize file dialog window before size 
restore (authored by davidedmundson).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25986?vs=71509&id=71511

REVISION DETAIL
  https://phabricator.kde.org/D25986

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25986: Resize file dialog window before size restore

[Nathaniel Graham]

ngraham added a comment.


  Could this go on the stable branch?

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25986

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25986: Resize file dialog window before size restore

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Fantastic!!! This fixes the file dialogs being way too tiny by default. 
Marvelous.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25986

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25986: Resize file dialog window before size restore

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KDEPlatformDialogHelper explicitly resizes the window contents to the
  window as part of a bug fix. This means we lose the common path where
  the window resizes to the content's size hints that happens later.
  
  If we resize the window to the size hint in advance we keep our size
  hint.
  
  (alternatively it seems to be me we can remove that old hack...but it
  needs testing by people with Qt5.12)

TEST PLAN
  KWrite -> open
  
  Size is 900x600, the size hint
  not 640x480 the QPA default

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25986

AFFECTED FILES
  src/platformtheme/kdeplatformfiledialoghelper.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25978: Don't hardcode the margin of the CardsListView

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2757a17bb089: Don't hardcode the margin of the 
CardsListView (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25978?vs=71491&id=71504

REVISION DETAIL
  https://phabricator.kde.org/D25978

AFFECTED FILES
  src/controls/private/CardsListViewPrivate.qml

To: apol, #kirigami, mart
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[Harald Sitter]

sitter added a comment.


  Seems a bit meh to have a verbatim copy of the auto generated functions. 
Perhaps it'd be better to add an option to the ECM generator to export a loader 
function for use in plugins?
  Then we could just call that from the plugin init instead of having to copy 
it.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25978: Don't hardcode the margin of the CardsListView

[Aleix Pol Gonzalez]

apol added a comment.


  The path is private but the class is directly inherited. 🤷

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25978

To: apol, #kirigami
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25984: Load translations

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Kirigami, Frameworks, kossebau, aacid.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The ECM QM Loader uses `Q_COREAPP_STARTUP_FUNCTION` which doesn't work for 
things loaded as plugins like QML modules.
  This copies the logic over to the plugin so the translations are loaded when 
the QML plugin is loaded.
  Not really like it, so I'm open to suggestions how to do that better in ECM 
or I don't know?

TEST PLAN
  - The Search field in Kirigami is translated now
  - The AboutPage in Kirigami is translated now

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: broulik, #kirigami, #frameworks, kossebau, aacid
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25983: Update size hint when font changes

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yup.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25983

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25983: Update size hint when font changes

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Ensures controls update their size when font changes.
  The Labels inside would but the control around them not, leading to broken 
rendering until causing it to update by interacting with it.
  It has to be queued for some reason or else by the time the signal is 
invoked, the style hasn't caught up yet.

TEST PLAN
  *Changed from 10pt to 12pt
  Before:
  The one I hovered updated half-way
  F7817652: Screenshot_20191214_114627.png 

  After:
  All controls update immediately
  F7817653: Screenshot_20191214_114546.png 


REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25983

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24238: Port the pager applet away from QtWidgets

[David Faure]

dfaure added a comment.


  Ah, right. Thanks.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: davidedmundson, hein, apol, dfaure
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24238: Port the pager applet away from QtWidgets

[David Edmundson]

davidedmundson closed this revision.
davidedmundson added a comment.


  @dfaure You can commandeer and then click close

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24238

To: davidedmundson, hein, apol, dfaure
Cc: ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25978: Don't hardcode the margin of the CardsListView

[David Edmundson]

davidedmundson added a comment.


  Makes sense, but I don't understand how this helps, given the path is 
"private/" ?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25978

To: apol, #kirigami
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 71495.
leinir added a comment.


  - Add the provider and service files (these use temp client data for now)
  - Actually install the service and provider files

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=71463&id=71495

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 315 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/315/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Dec 2019 09:21:20 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testClientMachineFailed: projectroot.autotests.kwin_testPluginEffectLoaderName: projectroot.autotests Failed: 13 test(s), Passed: 95 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testDontCrashAuroraeDestroyDecoFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testModiferOnlyShortcutFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXdgShellClientFailed: projectroot.autotests.integration.kwin_testXdgShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 8 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimationFailed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimation_waylandonlyFailed: projectroot.autotests.integration.effects.kwin_testScriptedEffectsFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucencyFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScriptFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScript_waylandonly

D25935: [Notifications] Add hint for showing a notification even in do not disturb mode

[Kai Uwe Broulik]

broulik added a comment.


  It was suggested to make it more semantic, i.e. be about "this is feedback 
for user-initiated task" which will then imply showing in dnd mode. Suggestions 
on how to phrase that as a key name?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25935

To: broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-integration » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-integration/job/kf5-qt5%20FreeBSDQt5.13/20/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 14 Dec 2019 09:21:04 +
 Build duration:
1 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 8 test(s), Skipped: 0 test(s), Total: 8 test(s)Name: projectroot.usr.home.jenkins.workspace.Plasma.plasma-integration.kf5-qt5_FreeBSDQt513 Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 27 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/27/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Sat, 14 Dec 2019 09:21:29 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 271 lines...][2019-12-14T09:22:19.366Z] BUILD_ID  = '27'[2019-12-14T09:22:19.366Z] LESSKEY   = '/etc/lesskey.bin'[2019-12-14T09:22:19.366Z] OLDPWD= '/home/jenkins'[2019-12-14T09:22:19.366Z] LC_CTYPE  = 'C.UTF-8'[2019-12-14T09:22:19.366Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-12-14T09:22:19.366Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-12-14T09:22:19.366Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-12-14T09:22:19.366Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-12-14T09:22:19.366Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-12-14T09:22:19.366Z] QT_SELECT = 'qt5'[2019-12-14T09:22:19.366Z] LANG  = 'en_US.UTF-8'[2019-12-14T09:22:19.366Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-12-14T09:22:19.366Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-12-14T09:22:19.366Z] [2019-12-14T09:22:19.366Z] [2019-12-14T09:22:19.366Z] == Commencing Configuration:[2019-12-14T09:22:19.366Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12"[2019-12-14T09:22:19.366Z] -- The C compiler identification is GNU 9.2.1[2019-12-14T09:22:19.628Z] -- The CXX compiler identification is GNU 9.2.1[2019-12-14T09:22:19.628Z] -- Check for working C compiler: /usr/bin/cc[2019-12-14T09:22:19.628Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-12-14T09:22:19.628Z] -- Detecting C compiler ABI info[2019-12-14T09:22:19.628Z] -- Detecting C compiler ABI info - done[2019-12-14T09:22:19.628Z] -- Detecting C compile features[2019-12-14T09:22:19.628Z] -- Detecting C compile features - done[2019-12-14T09:22:19.628Z] -- Check for working CXX compiler: /usr/bin/c++[2019-12-14T09:22:19.628Z] -- Check for working CXX compiler: /usr/bin/c++ -- works[2019-12-14T09:22:19.628Z] -- Detecting CXX compiler ABI info[2019-12-14T09:22:19.885Z] -- Detecting CXX compiler ABI info - done[2019-12-14T09:22:19.885Z] -- Detecting CXX compile features[2019-12-14T09:22:19.885Z] -- Detecting CXX compile features - done[2019-12-14T09:22:19.885Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/kgamma5/stable-kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for kgamma.[2019-12-14T09:22:19.885Z] -- Looking for __GLIBC__[2019-12-14T09:22:19.885Z] -- Looking for __GLIBC__ - found[2019-12-14T09:22:19.885Z] -- Performing Test _OFFT_IS_64BIT[2019-12-14T09:22:19.885Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-12-14T09:22:19.885Z] -- Performing Test HAVE_DATE_TIME[2019-12-14T09:22:19.885Z] -- Performing Test HAVE_DATE_TIME - Success[2019-12-14T09:22:19.885Z] -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.65.0") [2019-12-14T09:22:19.885Z] -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.65.0") [2019-12-14T09:22:19.885Z] -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.65.0") [2019-12-14T09:22:19.885Z] -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") [2019-12-14T09:22:19.885Z] -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.65.0") [2019-12-14T09:22:19.885Z] -- Found KF5: success (found suitable version "5.65.0", minimum required is "5.62.0") found components:  Config ConfigWidgets DocTools I18n [2019-12-14T09:22:20.141Z] -- Found X11: /usr/include   [2019-12-14T09:22:20.141Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so[2019-12-14T09:22:20.141Z] -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found[2019-12-14T09:22:20.141Z] -- Looking for gethostbyname[2019-12-14T09:22:20.141Z] -- Looking for gethostbyname - found[2019-12-14T09:22:20.141Z] -- Looking for connect[2019-12-14T09:22:20.141Z] -- Looking for connect - found[2019-12-14T09:22:20.141Z] -- Looking for remove[2019-12-14T09:22:20.141Z] -- Looking for remove - found[2019-12-14T09:22:20.141Z] -- Looking for shmat[2019-12-14T09:22:20.399Z] -- Looking for shmat - found[2019-12-14T09:22:20.399Z] -- Looking for IceConnectionNumber in ICE[2019-12-14T09:22:20.399Z] -- L

D25976: Use a default non-administrator user Type for new users in model

[Nathaniel Graham]

ngraham added a comment.


  Thanks Méven! This fixes the case of creating a non-admin user. However while 
testing it, I found a regression from D25439 
: when I create an admin user that has a 
space in the Real Name field, the "Enable administror privileges for this user" 
checkbox becomes unchecked and it isn't actually created as an admin user. Do 
you think you could also fix that in this patch?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D25976

To: meven, ngraham, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25978: Don't hardcode the margin of the CardsListView

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Use the left/rightMargin properties with a default value, in case it makes
  sense to override it.

TEST PLAN
  Used it on okular, works correctly

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25978

AFFECTED FILES
  src/controls/private/CardsListViewPrivate.qml

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25973: Make the theme info QuickWidget transparent

[Filip Fila]

filipf added a comment.


  There might be an unfortunate side effect: 
https://forum.qt.io/topic/57634/qt-wa_alwaysstackontop-influences-font-rendering-in-qml/5
  
  Which is acceptable here in my opinion since blending doesn't even exists 
with Breeze, but could become a problem if present everywhere and in prominent 
places.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  transparent-quick-widget (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25973

To: filipf, #plasma, davidedmundson, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25976: Use a default non-administrator user Type for new users in model

[Méven Car]

meven created this revision.
meven added reviewers: ngraham, Plasma, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  If the administrator role was not set for the index assume the default normal 
user type.
  
  Regression was introduced in D25398 .
  
  BUG: 414860
  FIXED-IN: 5.18

TEST PLAN
  Created a user as described in https://bugs.kde.org/show_bug.cgi?id=414860

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25976

AFFECTED FILES
  src/lib/accountmodel.cpp

To: meven, ngraham, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart