KDE CI: Plasma » plasma-phone-components » kf5-qt5 FreeBSDQt5.13 - Build # 9 - Still Failing!

2020-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-phone-components/job/kf5-qt5%20FreeBSDQt5.13/9/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Sat, 18 Jan 2020 07:39:05 +
 Build duration:
1 min 8 sec and counting
   CONSOLE OUTPUT
  [...truncated 635 lines...][2020-01-18T07:40:07.411Z] [ 50%] Building CXX object containments/panel/CMakeFiles/plasma_applet_phonepanel.dir/phonepanel.cpp.o[2020-01-18T07:40:07.411Z] Scanning dependencies of target plasma_containment_phone_homescreen[2020-01-18T07:40:07.411Z] [ 52%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/plasma_containment_phone_homescreen_autogen/mocs_compilation.cpp.o[2020-01-18T07:40:07.411Z] [ 52%] Built target plasma_containment_phone_taskpanel_autogen[2020-01-18T07:40:07.411Z] [ 55%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/homescreen.cpp.o[2020-01-18T07:40:07.411Z] [ 58%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/colouraverage.cpp.o[2020-01-18T07:40:07.411Z] [ 61%] Building CXX object containments/homescreen/CMakeFiles/plasma_containment_phone_homescreen.dir/applicationlistmodel.cpp.o[2020-01-18T07:40:07.667Z] Scanning dependencies of target plasma_containment_phone_taskpanel[2020-01-18T07:40:07.667Z] [ 64%] Building CXX object containments/taskpanel/CMakeFiles/plasma_containment_phone_taskpanel.dir/plasma_containment_phone_taskpanel_autogen/mocs_compilation.cpp.o[2020-01-18T07:40:07.667Z] [ 67%] Building CXX object containments/taskpanel/CMakeFiles/plasma_containment_phone_taskpanel.dir/taskpanel.cpp.o[2020-01-18T07:40:07.929Z] Scanning dependencies of target plasmaphonedialer[2020-01-18T07:40:08.201Z] [ 70%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/plasmaphonedialer_autogen/mocs_compilation.cpp.o[2020-01-18T07:40:08.771Z] [ 73%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/main.cpp.o[2020-01-18T07:40:08.771Z] gmake[2]: Warning: File '/usr/local/include/phonenumbers/phonemetadata.pb.h' has modification time 530 s in the future[2020-01-18T07:40:08.771Z] [ 76%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/dialerutils.cpp.o[2020-01-18T07:40:08.771Z] [ 79%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/call-handler.cpp.o[2020-01-18T07:40:08.771Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/dialer/src/plasmaphonedialer_autogen/mocs_compilation.cpp:2:[2020-01-18T07:40:08.771Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/build/dialer/src/plasmaphonedialer_autogen/EWIEGA46WW/moc_call-handler.cpp:10:[2020-01-18T07:40:08.771Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/dialer/src/call-handler.h:20:[2020-01-18T07:40:08.771Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/AbstractClientHandler:8:[2020-01-18T07:40:08.771Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/abstract-client.h:31:[2020-01-18T07:40:08.771Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/SharedPtr:8:[2020-01-18T07:40:08.771Z] /usr/local/include/telepathy-qt5/TelepathyQt/shared-ptr.h:112:13: warning: 'register' storage class specifier is deprecated and incompatible with C++17 [-Wdeprecated-register][2020-01-18T07:40:08.771Z] register int tmp = sc->strongref.fetchAndAddOrdered(0);[2020-01-18T07:40:08.771Z] ^[2020-01-18T07:40:08.771Z] [ 82%] Linking CXX shared module ../../bin/plasma_applet_phonepanel.so[2020-01-18T07:40:09.027Z] [ 85%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/callhistorymodel.cpp.o[2020-01-18T07:40:09.027Z] [ 85%] Built target plasma_applet_phonepanel[2020-01-18T07:40:09.027Z] [ 88%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/call-manager.cpp.o[2020-01-18T07:40:09.027Z] [ 91%] Building CXX object dialer/src/CMakeFiles/plasmaphonedialer.dir/plasmaphonedialer_autogen/EWIEGA46WW/qrc_resources.cpp.o[2020-01-18T07:40:09.593Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/dialer/src/call-handler.cpp:17:[2020-01-18T07:40:09.593Z] In file included from /usr/home/jenkins/workspace/Plasma/plasma-phone-components/kf5-qt5 FreeBSDQt5.13/dialer/src/call-handler.h:20:[2020-01-18T07:40:09.593Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/AbstractClientHandler:8:[2020-01-18T07:40:09.593Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/abstract-client.h:31:[2020-01-18T07:40:09.593Z] In file included from /usr/local/include/telepathy-qt5/TelepathyQt/SharedPtr:8:[2020-01-18T07:40:09.593Z] /usr/local/include/telepathy-qt5/TelepathyQt/shared-ptr.h:112:13: warning: 'register' storage 

D26747: Fix typo

2020-01-17 Thread Alexander Lohnau
alex created this revision.
alex added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The word editing had one "t" to much

TEST PLAN
  /

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26747

AFFECTED FILES
  HACKING

To: alex, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26738: Fix typo, launch plugin with argument, change signals

2020-01-17 Thread Alexander Lohnau
alex updated this revision to Diff 73814.
alex added a comment.


  As requested the update of the HACKING file will be committed separately.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26738?vs=73794=73814

REVISION DETAIL
  https://phabricator.kde.org/D26738

AFFECTED FILES
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: alex, broulik
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  In D26739#596363 , @ndavis wrote:
  
  > You can't shrink the size of it to fit within the blue border?
  
  
  That's what this patch does in its current form.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Noah Davis
ndavis added a comment.


  In D26739#596355 , @ngraham wrote:
  
  > Yeah. I don't disagree. But if I just ensure that the highlight effect is 
the highest item, the borders still get obscured by the player controls and 
album art. And the rounded corners of the highlight leave a pixel or two of the 
art to escape the bounds too.
  >
  > F7889322: Screenshot_20200117_213837.png 

  
  
  You can't shrink the size of it to fit within the blue border?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Noah Davis
ndavis added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:185
>  pressed: hoverHandler.containsPress
> +z: 
>  }

I recall seeing a QML dos and don'ts webinar that said not to use large z 
values.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  Yeah. I don't disagree. But if I just ensure that the highlight effect is the 
highest item, the borders still get obscured by the player controls and album 
art. And the rounded corners of the highlight leave a pixel or two of the art 
to escape the bounds too.
  
  F7889322: Screenshot_20200117_213837.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Filip Fila
filipf added a comment.


  In D26739#596320 , @ndavis wrote:
  
  > Not a fan of the inner frame. We should avoid making frames within frames. 
I don't think it really needs changing, except that the sides cover the blue 
border frame.
  >
  > F7889165: Screenshot_20200117_211120.PNG 

  
  
  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: filipf, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26746: Add active, link, visited, negative, neutral and positive background colors

2020-01-17 Thread Noah Davis
ndavis created this revision.
ndavis added reviewers: Kirigami, Plasma.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  These colors were added to Kirigami and qqc2-desktop-style, so I had to add 
them here too.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  more-background-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26746

AFFECTED FILES
  src/data/contents/ui/gallery/ColorsGallery.qml

To: ndavis, #kirigami, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart, hein


D26745: Add active, link, visited, negative, neutral and positive background colors

2020-01-17 Thread Noah Davis
ndavis created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Buttons colored with special text role colors as backgrounds don't always 
look nice with black text on light themes. They should have been using 
background role colors for the background, but the background role colors they 
needed weren't available. This patch adds the missing background role colors.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  more-background-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26745

AFFECTED FILES
  kirigami-plasmadesktop-integration/plasmadesktoptheme.cpp

To: ndavis
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Noah Davis
ndavis added a comment.


  Not a fan of the inner frame. We should avoid making frames within frames. I 
don't think it really needs changing, except that the sides cover the blue 
border frame.
  
  F7889165: Screenshot_20200117_211120.PNG 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26743: Add active, link, visited, negative, neutral and positive background colors

2020-01-17 Thread Noah Davis
ndavis created this revision.
ndavis added reviewers: mart, Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Buttons colored with special text colors didn't look very good with black 
text on light themes. They should have been using background colors for the 
background, but the background colors they needed weren't available. This patch 
adds the missing background colors.

REPOSITORY
  R169 Kirigami

BRANCH
  more-background-colors (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26743

AFFECTED FILES
  src/controls/Theme.qml
  src/controls/plugins.qmltypes
  src/libkirigami/basictheme.cpp
  src/libkirigami/platformtheme.cpp
  src/libkirigami/platformtheme.h
  src/styles/Material/Theme.qml
  src/styles/org.kde.desktop/Theme.qml

To: ndavis, mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

2020-01-17 Thread Victor Ryzhykh
victorr added a comment.


  Now there are a lot of errors with localization.
  There is a message about them.
  https://bugs.kde.org/show_bug.cgi?id=415541
  Temporarily fixed this problem with attached patches when building packages.
  This error was originally described here 
https://phabricator.kde.org/D26665#594287
  
  F7889061: knewstuff-5.66-tr.patch 
  F7889062: plasma-desktop-5.17.90-tr.patch 

  F7889063: plasma-workspace-5.17.90-fix.patch 

  F7889077: Before.jpeg 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart, ngraham
Cc: victorr, meven, bcooksley, davidedmundson, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D26738: Fix typo, launch plugin with argument, change signals

2020-01-17 Thread Aleix Pol Gonzalez
apol added a comment.


  Looks good to me overall. Can you commit the HACKING change separately? it's 
completely unrelated.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26738

To: alex, broulik
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D26719: [Battery Monitor] Glow icon on hover

2020-01-17 Thread Konrad Materka
kmaterka marked an inline comment as done.
kmaterka added a comment.


  The question is: should I move this component somewhere else? 
PlasmaComponents3?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26719

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26719: [Battery Monitor] Glow icon on hover

2020-01-17 Thread Konrad Materka
kmaterka updated this revision to Diff 73799.
kmaterka added a comment.


  Remove leftovers from tests

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26719?vs=73767=73799

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26719

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  components/workspace/IconEffects.qml
  components/workspace/qmldir

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  I'm not 100% sold on drawing the highlight on top and tinting everything, and 
can revert that part if everyone else hates it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26739: [applets/Task Manager] Refine tooltip highlight effect

2020-01-17 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch implements the following visual tweaks:
  
  - Draws the highlight effect on top so that it tints the content
  - Indents the media controls by `units.smallSpacing` to match the window 
thumbnail
  
  Now the boundaries of the highlight effect don't get overlapped by the 
content inside,
  and the highlight effect is more visible for tooltips where the thumbnail or 
album art
  takes up most of the space.
  
  BUG: 416390
  FIXED-IN: 5.18.0

TEST PLAN
  F7888903: After, with album art.png 
  F7888902: After, thumbnail with no media controls.png 

  F7888901: After, no album art and unminimized.png 

  F7888900: After, no album art and minimized.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  refine-tooltip-highlight-effects (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26739

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ToolTipInstance.qml

To: ngraham, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26738: Fix typo, launch plugin with argument, change signals

2020-01-17 Thread Alexander Lohnau
alex created this revision.
alex added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The typo in the HACKING file has been fixed, the kcms/runners plugin is now 
able to launch a specific plugin using the --arg parameter of kcmshell5 and the 
deprecated signals have been changed.
  And the QLatin1String has been replaced by the QStringLiteral Macro, because 
the open config method does not have an overload with the QLatin1String class.

TEST PLAN
  You can just type "kcmshell5 plasmasearch --args Dictionary" and additionally 
to the KRunner configs it should open the plugin config

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26738

AFFECTED FILES
  HACKING
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: alex, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26733: sync tooltip delay with systemsettings

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  Yeah, it might be nice to extract this into a framework that can bee used by 
all three apps so it can't diverge this way again.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26733

To: sitter
Cc: ngraham, bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 245 - Still unstable!

2020-01-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/245/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Jan 2020 17:56:08 +
 Build duration:
5 min 4 sec and counting
   JUnit Tests
  Name: (root) Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.appstreamtestName: projectroot.containments.desktop.plugins.folder Failed: 0 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 4 test(s)Name: projectroot.kcms.keyboard Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)Name: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(13/79)18%
(64/350)18%
(64/350)14%
(4388/32374)11%
(2380/21028)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.kimpanel.backend.ibus0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/10)applets.kimpanel.backend.ibus.ibus150%
(0/10)0%
(0/10)0%
(0/1093)0%
(0/610)applets.kimpanel.backend.scim0%
(0/1)0%
(0/1)0%
(0/663)0%
(0/395)applets.kimpanel.plugin0%
(0/2)0%
(0/2)0%
(0/43)0%
(0/26)applets.pager.plugin0%
(0/3)0%
(0/3)0%
(0/356)0%
(0/234)applets.showdesktop.plugin0%
(0/3)0%
(0/3)0%
(0/14)0%
(0/4)applets.taskmanager.plugin0%
(0/3)0%
(0/3)0%
(0/313)0%
(0/242)applets.taskmanager.plugin.smartlaunchers0%
(0/4)0%
(0/4)0%
(0/235)0%
(0/208)applets.trash.plugin0%
(0/5)0%
(0/5)0%
(0/116)0%
(0/52)attica-kde.kdeplugin0%
(0/1)0%
(0/1)0%
(0/125)0%
(0/118)containments.desktop.plugins.desktop0%
(0/2)0%
(0/2)0%
(0/48)0%
(0/18)containments.desktop.plugins.folder30%
(6/20)30%
(6/20)39%
(914/2350)28%
(419/1501)containments.desktop.plugins.folder.autotests100%
(4/4)100%
(4/4)100%
(558/558)60%
(221/368)dataengines.kimpanel0%
(0/7)0%
(0/7)0%
(0/343)0%
(0/131)imports.activitymanager0%
(0/3)0%
(0/3)0%
(0/386)0%
(0/224)kaccess0%
(0/3)0%
   

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 93 - Still unstable!

2020-01-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/93/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 17 Jan 2020 17:56:08 +
 Build duration:
3 min 54 sec and counting
   JUnit Tests
  Name: projectroot.containments.desktop.plugins.folder Failed: 2 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.containments.desktop.plugins.folder.autotests.foldermodeltestFailed: projectroot.containments.desktop.plugins.folder.autotests.positionertestName: projectroot.kcms.keyboard Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.kcms.keyboard.tests.kcm_keyboard_iso_codesName: projectroot.kcms.kfontinst.kio Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kcms.lookandfeel Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D26733: sync tooltip delay with systemsettings

2020-01-17 Thread Harald Sitter
sitter added a comment.


  ugh :(
  
  Thanks for context though.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26733

To: sitter
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26733: sync tooltip delay with systemsettings

2020-01-17 Thread Ben Cooksley
bcooksley added a comment.


  The code if memory serves originates from Dolphin, it was copied from there 
into System Settings (which was done by me - we weren't sure about API 
stability at the time for upstreaming to kdelibs as it was at the time), and 
then must have been copied again from there into KInfoCenter.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26733

To: sitter
Cc: bcooksley, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26733: sync tooltip delay with systemsettings

2020-01-17 Thread Harald Sitter
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  50 is fairly short, 300 as used in systemsettings is much nicer
  and also makes the two uis behave the same
  
  BUG: 393722
  FIXED-IN: 5.18.0
  
  why ever do we have a code copy of the same tooltip manager in
  both uis...

TEST PLAN
  tooltips are firing a bit slower

REPOSITORY
  R102 KInfoCenter

BRANCH
  delay

REVISION DETAIL
  https://phabricator.kde.org/D26733

AFFECTED FILES
  ToolTips/tooltipmanager.cpp

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

2020-01-17 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of those patches. Thanks @meven!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: meven, GB_2, dfaure, abetts, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart


D17372: [componentchooser KCM] Make KIO browser option the fallback only and remove from the UI

2020-01-17 Thread Méven Car
meven added a comment.


  In D17372#472624 , @dfaure wrote:
  
  > Writing into the user's home dir is a "hack".
  >
  > There are better ways for distros to set defaults (such as the global 
mimeapps.list) but it seems KIO ignores that... (to be checked...)
  
  
  It did (did not read `[Default Applications] x-scheme-handle/http` basicaly.
  I have a fix for that : D26690 
  
  And I have another go at this UI : D26731 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17372

To: ngraham, #plasma, #vdg, #frameworks, dfaure
Cc: meven, GB_2, dfaure, abetts, davidedmundson, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
ahiemstra, mart


D26731: KCM/Component Revamp Browser config

2020-01-17 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a reviewer: dfaure.
ngraham added a comment.
This revision is now accepted and ready to land.


  Works for me FWIW.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  browser-settings

REVISION DETAIL
  https://phabricator.kde.org/D26731

To: meven, ngraham, #plasma, ervin, dfaure
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26731: KCM/Component Revamp Browser config

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  The "Dans une application fondée sue le contenu d l'URL" setting is actually 
something I proposed removing in D17372 , 
and it got approval in theory, but it seems like this is quite a far-reaching 
change that requires many considerations.
  
  A lot of the discussion in D17372  kind 
of went over my head, so feel free to take over on that if you'd like.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26731

To: meven, ngraham, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26731: KCM/Component Revamp Browser config

2020-01-17 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> componentchooserbrowser.cpp:79
>  {
> -return radioKIO->isChecked();
> +// no real default
> +return true;

Do we want to set falkon or konqueror as default ?

> componentchooserbrowser.cpp:86
> -if (exec.isEmpty()) {
> -radioKIO->setChecked(true);
> -m_browserExec = exec;

With the remove as this possible setting, we don't have a way to set things as 
they were.
But I don't this is an issue, the behavior encompassed here, is I believe 
already gone in KRun (where KRun would determine the http resource mimetype and 
launch the appropriate application accordingly).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26731

To: meven, ngraham, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26731: KCM/Component Revamp Browser config

2020-01-17 Thread Méven Car
meven created this revision.
meven added reviewers: ngraham, Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Simplify UI:
  
  - Select option in the available browser
  - use mimeapps.list preferred service as source of truth regarding default 
browser
  - Can select any program as browser

REPOSITORY
  R119 Plasma Desktop

BRANCH
  browser-settings

REVISION DETAIL
  https://phabricator.kde.org/D26731

AFFECTED FILES
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h

To: meven, ngraham, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26640: [applets/weather] Port weather station picker to QQC2+ListView

2020-01-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 73780.
ngraham marked 3 inline comments as done.
ngraham added a comment.


  Address review comments

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26640?vs=73464=73780

BRANCH
  port-to-listview-in-scrollview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26640

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26640: [applets/weather] Port weather station picker to QQC2+ListView

2020-01-17 Thread Nathaniel Graham
ngraham added inline comments.

INLINE COMMENTS

> broulik wrote in WeatherStationPicker.qml:144
> This is unlike any other list we have in settings?

I copied it from the notifications KCM :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26640

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26730: pare xorg version for nicer display

2020-01-17 Thread Harald Sitter
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  instead of just printing a random integer lets try to print a
  nice looking version string. since I couldn't find
  cross-implementation documentation on what the format of the
  int is, I am going to assume it is vendor specific and guard
  the xorg specific parsing behind a guard based on the vendor
  string containig x.org
  
  BUG: 344038
  FIXED-IN: 5.18.0

TEST PLAN
  version looks nice in xorg module

REPOSITORY
  R102 KInfoCenter

BRANCH
  xorgversion

REVISION DETAIL
  https://phabricator.kde.org/D26730

AFFECTED FILES
  Modules/base/os_base.h

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26640: [applets/weather] Port weather station picker to QQC2+ListView

2020-01-17 Thread Kai Uwe Broulik
broulik added inline comments.

INLINE COMMENTS

> WeatherStationPicker.qml:44
>  if (!success) {
>  noSearchResultReport.text = i18nc("@info", "No weather stations 
> found for '%1'", searchString);
>  noSearchResultReport.visible = true;

Given the item is hidden anyway, you can probably assign this as a binding 
right away

> WeatherStationPicker.qml:134
> +background.visible = true;
> +searchStringEdit.forceActiveFocus();
>  }

Does `focus: true` on the `TextField` instead of the `ListView` make this 
redundant?

> WeatherStationPicker.qml:144
> +keyNavigationEnabled: true
> +keyNavigationWraps: true
> +

This is unlike any other list we have in settings?

> WeatherStationPicker.qml:169
> +wrapMode: Text.WordWrap
> +visible: locationListView.count === 0 && 
> searchStringEdit.length > 0
> +enabled: false

You're constantly breaking this binding by assigning to it elsewhere 
programmatically.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26640

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26729: do not disable getifaddrs use because of sa_len availablility

2020-01-17 Thread Harald Sitter
sitter updated this revision to Diff 73777.
sitter added a comment.


  committing the latest working tree helps a lot -.-

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26729?vs=73776=73777

BRANCH
  ipv6

REVISION DETAIL
  https://phabricator.kde.org/D26729

AFFECTED FILES
  Modules/nics/nic.cpp

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26729: do not disable getifaddrs use because of sa_len availablility

2020-01-17 Thread Harald Sitter
sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  this fixes ipv6 support in nic listing. well, kinda.
  
  the getifaddrs branch is the only one supporting ipv6 properly
  so it seems silly to use the ioctl branch just because sa_len
  is not available.
  simply wrap around getnameinfo and either use sa_len or
  determine the length based on the socket family (as seen on the
  getifaddrs manpage). this way the branch compiles fine without
  sa_len and is fine to use by just about all glibc systems thus
  giving us ipv6 support on just about every glib system.
  
  BUG: 313892
  FIXED-IN: 5.18.0

TEST PLAN
  built on neon. shows ipv6 addresses

REPOSITORY
  R102 KInfoCenter

BRANCH
  ipv6

REVISION DETAIL
  https://phabricator.kde.org/D26729

AFFECTED FILES
  Modules/nics/nic.cpp

To: sitter
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2020-01-17 Thread Nathaniel Graham
ngraham marked an inline comment as done.
ngraham added a comment.


  Re-added the namespace but the state checking still doesn't seem to work 
properly.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, 
ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart


D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2020-01-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 73775.
ngraham added a comment.


  Re-add namespace

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25447?vs=73771=73775

BRANCH
  suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25447

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, 
ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart


D24706: [RFC] Change button style

2020-01-17 Thread Noah Davis
ndavis added a comment.


  In D24706#595796 , @cfeck wrote:
  
  > If application developers need a rotated button, they need to rotate only 
the contents, not the frame.
  
  
  Good to know. I remembered seeing an earlier version of the KScreen redesign 
patch that had rotated shadows. The buttons were made flat, which fixed that 
problem, so I assumed it was stuck like that because of the QStyle.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, 
manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart


KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 320 - Still unstable!

2020-01-17 Thread CI System
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/320/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Jan 2020 15:13:27 +
 Build duration:
2 min 24 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.discover Failed: 1 test(s), Passed: 11 test(s), Skipped: 0 test(s), Total: 12 test(s)Failed: projectroot.discover.autotests.toplevelsName: projectroot.libdiscover Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libdiscover.backends.DummyBackend Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libdiscover.backends.KNSBackend Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report72%
(13/18)70%
(74/105)70%
(74/105)62%
(3550/5731)48%
(1691/3542)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdiscover100%
(12/12)100%
(12/12)75%
(589/783)55%
(255/466)discover.autotests100%
(1/1)100%
(1/1)100%
(100/100)55%
(35/64)exporter0%
(0/3)0%
(0/3)0%
(0/65)0%
(0/40)libdiscover71%
(5/7)71%
(5/7)76%
(207/274)63%
(116/183)libdiscover.Category100%
(5/5)100%
(5/5)67%
(164/244)48%
(111/230)libdiscover.ReviewsBackend100%
(7/7)100%
(7/7)86%
(197/228)77%
(56/73)libdiscover.Transaction88%
(7/8)88%
(7/8)79%
(235/298)68%
(98/144)libdiscover.UpdateModel100%
(3/3)100%
(3/3)91%
(224/247)74%
(92/125)libdiscover.appstream0%
(0/5)0%
(0/5)0%
(0/241)0%
(0/128)libdiscover.backends.DummyBackend73%
(8/11)73%
(8/11)83%
(261/315)75%
(124/166)libdiscover.backends.DummyBackend.tests100%
(2/2)100%
(2/2)97%
(250/259)53%
(143/268)libdiscover.backends.FwupdBackend0%
(0/8)0%
(0/8)0%
(0/553)0%
(0/267)libdiscover.backends.KNSBackend100%
(5/5)100%
(5/5)59%
(348/588)43%
(139/327)libdiscover.backends.KNSBackend.tests100%
(1/1)100%
(1/1)98%
(90/92)55%
(63/114)libdiscover.notifiers0%
(0/2)0%
(0/2)0%
(0/7)0%
(0/2)libdiscover.resources94%

KDE CI: Plasma » discover » kf5-qt5 SUSEQt5.12 - Build # 319 - Failure!

2020-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20SUSEQt5.12/319/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Jan 2020 15:08:17 +
 Build duration:
1 min 34 sec and counting
   CONSOLE OUTPUT
  [...truncated 429 lines...][2020-01-17T15:09:43.515Z] Scanning dependencies of target DiscoverNotifiers_autogen[2020-01-17T15:09:43.515Z] Scanning dependencies of target DiscoverCommon_autogen[2020-01-17T15:09:43.515Z] Scanning dependencies of target PaginateModelTest_autogen[2020-01-17T15:09:43.515Z] [  3%] Automatic MOC for target DiscoverCommon[2020-01-17T15:09:43.515Z] [  3%] Automatic MOC for target PaginateModelTest[2020-01-17T15:09:43.515Z] [  3%] Automatic MOC for target DiscoverNotifiers[2020-01-17T15:09:43.771Z] [  3%] Built target DiscoverNotifiers_autogen[2020-01-17T15:09:43.771Z] Scanning dependencies of target DiscoverNotifiers[2020-01-17T15:09:43.771Z] [  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/BackendNotifierModule.cpp.o[2020-01-17T15:09:43.771Z] [  4%] Building CXX object libdiscover/notifiers/CMakeFiles/DiscoverNotifiers.dir/DiscoverNotifiers_autogen/mocs_compilation.cpp.o[2020-01-17T15:09:43.771Z] [  4%] Built target PaginateModelTest_autogen[2020-01-17T15:09:43.771Z] Scanning dependencies of target PaginateModelTest[2020-01-17T15:09:43.771Z] [  5%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest_autogen/mocs_compilation.cpp.o[2020-01-17T15:09:43.771Z] [  6%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/PaginateModelTest.cpp.o[2020-01-17T15:09:43.771Z] [  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/__/PaginateModel.cpp.o[2020-01-17T15:09:43.771Z] [  7%] Building CXX object discover/autotests/CMakeFiles/PaginateModelTest.dir/discover_debug.cpp.o[2020-01-17T15:09:44.331Z] [  7%] Built target DiscoverCommon_autogen[2020-01-17T15:09:44.331Z] Scanning dependencies of target DiscoverCommon[2020-01-17T15:09:44.331Z] [  8%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/DiscoverCommon_autogen/mocs_compilation.cpp.o[2020-01-17T15:09:44.331Z] [ 10%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/Category.cpp.o[2020-01-17T15:09:44.331Z] [ 10%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoriesReader.cpp.o[2020-01-17T15:09:44.331Z] [ 10%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Category/CategoryModel.cpp.o[2020-01-17T15:09:44.331Z] [ 11%] Linking CXX shared library ../../bin/libDiscoverNotifiers.so[2020-01-17T15:09:44.587Z] [ 11%] Built target DiscoverNotifiers[2020-01-17T15:09:44.587Z] [ 12%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/AbstractReviewsBackend.cpp.o[2020-01-17T15:09:44.587Z] [ 13%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Rating.cpp.o[2020-01-17T15:09:44.842Z] [ 13%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/Review.cpp.o[2020-01-17T15:09:45.097Z] [ 14%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/ReviewsBackend/ReviewsModel.cpp.o[2020-01-17T15:09:45.352Z] [ 15%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/AddonList.cpp.o[2020-01-17T15:09:45.353Z] [ 16%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/Transaction.cpp.o[2020-01-17T15:09:45.608Z] [ 17%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionListener.cpp.o[2020-01-17T15:09:45.608Z] [ 18%] Linking CXX executable ../../bin/PaginateModelTest[2020-01-17T15:09:45.608Z] [ 19%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/Transaction/TransactionModel.cpp.o[2020-01-17T15:09:46.155Z] [ 19%] Built target PaginateModelTest[2020-01-17T15:09:46.155Z] [ 19%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateItem.cpp.o[2020-01-17T15:09:46.155Z] Scanning dependencies of target DummyNotifier_autogen[2020-01-17T15:09:46.155Z] [ 20%] Automatic MOC for target DummyNotifier[2020-01-17T15:09:46.155Z] [ 20%] Built target DummyNotifier_autogen[2020-01-17T15:09:46.155Z] Scanning dependencies of target DiscoverNotifier_autogen[2020-01-17T15:09:46.155Z] [ 21%] Automatic MOC for target DiscoverNotifier[2020-01-17T15:09:46.155Z] [ 22%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/UpdateModel/UpdateModel.cpp.o[2020-01-17T15:09:46.155Z] [ 22%] Built target DiscoverNotifier_autogen[2020-01-17T15:09:46.155Z] [ 23%] Building CXX object libdiscover/CMakeFiles/DiscoverCommon.dir/resources/ResourcesModel.cpp.o[2020-01-17T15:09:46.155Z] Scanning dependencies of target DummyNotifier[2020-01-17T15:09:46.155Z] [ 24%] Building CXX object libdiscover/backends/DummyBackend/CMakeFiles/DummyNotifier.dir/DummyNotifier_autogen/mocs_compilation.cpp.o[2020-01-17T15:09:46.409Z] [ 25%] Building CXX 

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  The goal is to have a sane default size.
  
  This patch in its current state seems to do that, since setting a minimum 
width and height on `m_editor` doesn't actually prevent it from being resized 
to be smaller due to its sizePolicy.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2020-01-17 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:81
> Edit, no it wasn't wrong
> 
> But I have found what is.
> 
> I export this as the class Baloo, but the import is also under Baloo
> 
> So for this to work against my patch it would be Baloo.Baloo.Suspended

> So for this to work against my patch it would be Baloo.Baloo.Suspended

This isn't in this diff

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25447

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, 
ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart


D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

2020-01-17 Thread David Edmundson
davidedmundson added a comment.


  > Is there a better way?
  
  Depends what the goal is. To set a minimum size or to change the default size.
  
  Commit title says one thing, comment says another.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26695

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2020-01-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 73771.
ngraham added a comment.


  Adjust to changes in D25743 

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25447?vs=73768=73771

BRANCH
  suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25447

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, 
ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart


D25634: Add kconf update script for ksmserver

2020-01-17 Thread David Edmundson
davidedmundson added a comment.


  > -1 I'd prefer if the config value was kept
  
  Beta is shipped and the value is not kept, so I'd still like this.
  
  Ping.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25634

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26699: [widgetexplorer] Animate column moves

2020-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:3a6795548fd7: [widgetexplorer] Animate column moves 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26699?vs=73662=73770

REVISION DETAIL
  https://phabricator.kde.org/D26699

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26698: [widgetexplorer] Fix animate in animation

2020-01-17 Thread David Edmundson
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:977665254990: [widgetexplorer] Fix animate in animation 
(authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26698?vs=73661=73769

REVISION DETAIL
  https://phabricator.kde.org/D26698

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

2020-01-17 Thread Nathaniel Graham
ngraham updated this revision to Diff 73768.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25447?vs=71013=73768

BRANCH
  suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25447

AFFECTED FILES
  kcms/baloo/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, #baloo, bruns, davidedmundson
Cc: davidedmundson, astippich, plasma-devel, hurikhan77, lots0logs, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, 
ashaposhnikov, spoorun, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, abrahams, sebas, apol, ahiemstra, mart


D26719: [Battery Monitor] Glow icon on hover

2020-01-17 Thread Konrad Materka
kmaterka updated this revision to Diff 73767.
kmaterka added a comment.


  Apply to notification icon

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26719?vs=73766=73767

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26719

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/notifications/package/contents/ui/CompactRepresentation.qml
  components/workspace/IconEffects.qml
  components/workspace/qmldir

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26640: [applets/weather] Port weather station picker to QQC2+ListView

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  Ping

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26640

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26726: [Breeze Cursors] Add some more cursor names

2020-01-17 Thread David Edmundson
davidedmundson added a comment.


  Semi relevant: https://bugs.kde.org/show_bug.cgi?id=395247

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26719: [Battery Monitor] Glow icon on hover

2020-01-17 Thread Konrad Materka
kmaterka updated this revision to Diff 73766.
kmaterka added a comment.


  Separate component

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26719?vs=73739=73766

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26719

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/CompactRepresentation.qml
  components/workspace/IconEffects.qml
  components/workspace/qmldir

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26726: [Breeze Cursors] Add some more cursor names

2020-01-17 Thread Kai Uwe Broulik
broulik added a comment.


  > even though they're still "up for discussion."
  
  Yeah, and then I looked at the date ;)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26725: make sure Solid::Battery is not deleted from QML

2020-01-17 Thread Harald Sitter
This revision was automatically updated to reflect the committed changes.
Closed by commit R102:764fce4aefbe: make sure Solid::Battery is not deleted 
from QML (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26725?vs=73758=73764

REVISION DETAIL
  https://phabricator.kde.org/D26725

AFFECTED FILES
  Modules/energy/batterymodel.cpp

To: sitter, broulik, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26717: [App Style KCM] Use QtQuick NewStuff dialogs

2020-01-17 Thread Yuri Chornoivan
yurchor added a comment.


  No objections to breaking string freeze from the Ukrainian team.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  change-exec (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26717

To: gikari, broulik, ngraham
Cc: yurchor, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26717: [App Style KCM] Use QtQuick NewStuff dialogs

2020-01-17 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Looks good, and this should go on the `plasma/5.18` branch to make sure it 
gets into Plasma 5.18 so this KCM isn't the odd one out.
  
  However it contains new and changed strings so I have requested a string 
freeze exception to make this possible. I'll let you know if and when it's 
accepted so this patch can land. Until then, please do not land it.
  
  Thanks again!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  change-exec (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26717

To: gikari, broulik, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D19409: [sddm-theme/lock screen] Adjust login and lock screen blur effect

2020-01-17 Thread Walter Johnson
wjohnson added a comment.


  If you wish to play with login and lock screen stuff, go to
  
  Main Login
  
  /usr/share/sddm/themes/your-login-theme/main.qml
  
  Lock Screen Login
  
  Helps to know that breeze is the default Plasma lock screen theme. If a lock 
screen is not part of whatever theme you are using, then Plasma will use the 
breeze one.
  
  
/usr/share/plasma/look-and-feel/org.kde.breeze.desktop/contents/lockscreen/LockScreenUi.qml
  
  In both of those files you will find something like this (I have added the 
corrections):
  
WallpaperFader {

// visible: false keeps from fading the wallpaper
visible: false

// Commenting out "anchors.fill: parent" will also do it.
//anchors.fill: parent

state: lockScreenRoot.uiVisible ? "on" : "off"
source: wallpaper
mainStack: mainStack
footer: footer
clock: clock
}
  
  Either one of those corrections will do the trick. I don't like blurred 
backgrounds on my login screens. They particularly look bad if they are already 
dark pictures.
  
  Anyway, good luck.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19409

To: rooty, #vdg, ngraham, #plasma, davidedmundson, filipf
Cc: wjohnson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26720: Cache single image wallpapers locally

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  Good point, I totally forgot to consider that. I have no idea how it works 
and will need to look into it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26720

To: ngraham, #plasma
Cc: broulik, filipf, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26726: [Breeze Cursors] Add some more cursor names

2020-01-17 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I suppose it doesn't hurt anything to add these even though they're still "up 
for discussion."

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

To: broulik, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26715: [Widget Explorer] Show placeholder message when there are no widgets or search results

2020-01-17 Thread Nathaniel Graham
ngraham added a comment.


  When set to false, it makes the label look less lighter without manually 
setting the opacity to some value that we'll often forget to be consistent on 
which would (and does) result in labels of opacity values varying between 0.3 
and 0.6.
  
  I'm working on making a high-level re-usable component for this fairly common 
Search Field + Scroll View + List View + placeholder text paradigm

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26715

To: ngraham, #vdg, #plasma, apol
Cc: davidedmundson, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D18006: Include only the largest size for the "Next" wallpaper

2020-01-17 Thread Nathaniel Graham
ngraham abandoned this revision.
ngraham added a comment.


  All right, no problem!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze, mart
Cc: apol, davidedmundson, mart, filipf, kvermette, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra


D26726: [Breeze Cursors] Add some more cursor names

2020-01-17 Thread Kai Uwe Broulik
broulik created this revision.
broulik added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  They are "up for discussion" [1] but seem to be used by e.g. Chrome.
  
  [1] https://www.freedesktop.org/wiki/Specifications/cursor-spec/

TEST PLAN
  Juts a bunch of symlinks, so 5.18
  Not sure where that `cursorList` file is being used (I also added some others 
that weren't added to this file in eb3498d9a797e3e21f0e722ecc0c9507c6f1b8ea 

  
  Now works
  F7888108: Screenshot_20200117_134406.PNG 


REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26726

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/ew-resize
  cursors/Breeze/Breeze/cursors/nesw-resize
  cursors/Breeze/Breeze/cursors/ns-resize
  cursors/Breeze/Breeze/cursors/nwse-resize
  cursors/Breeze/src/cursorList
  cursors/Breeze_Snow/Breeze_Snow/cursors/ew-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/nesw-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/ns-resize
  cursors/Breeze_Snow/Breeze_Snow/cursors/nwse-resize
  cursors/Breeze_Snow/src/cursorList

To: broulik, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper

2020-01-17 Thread Christophe Giboudeaux
This revision was automatically updated to reflect the committed changes.
Closed by commit R871:807d9dccab08: installdbgsymbols_suse: Pass --plus-content 
debug to zypper (authored by fvogt, committed by cgiboudeaux).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24751?vs=68220=73759

REVISION DETAIL
  https://phabricator.kde.org/D24751

AFFECTED FILES
  src/doc/examples/installdbgsymbols_suse.sh

To: fvogt, lbeltrame, cgiboudeaux
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26725: make sure Solid::Battery is not deleted from QML

2020-01-17 Thread Harald Sitter
sitter created this revision.
sitter added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  Battery objects are casted DeviceInterface objects and those are
  owned by Solid. deleting them outside solid means they will end
  up as dangling pointers inside Solid's global static objects.
  
  when switching away from the energy KCM the qml engine would
  get cleaned up as part of the KCM destruction, qml would then
  sweep up the Battery object and corrupt the solid internal
  pointers.
  
  to prevent this, explicitly mark Battery objects we give to QML
  as owned on the c++ side.
  
  BUG: 413003

TEST PLAN
  open kinfocenter
  switch to energy
  switch away
  switch to energy
  no crash

REPOSITORY
  R102 KInfoCenter

BRANCH
  413003

REVISION DETAIL
  https://phabricator.kde.org/D26725

AFFECTED FILES
  Modules/energy/batterymodel.cpp

To: sitter, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

2020-01-17 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 73756.
leinir added a comment.


  Rebase on master
  
  - Add the provider and service files (these use temp client data for now)
  - Actually install the service and provider files
  - Add functionality to open the accounts kcm on saveCredentials calls

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=71607=73756

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: zachus, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26330: [MPRIS Data Engine] Ignore players with CanControl false in multiplexer

2020-01-17 Thread Kai Uwe Broulik
broulik abandoned this revision.
broulik added a comment.


  Superseded by D26702 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26330

To: broulik, #plasma
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26689: [MPRIS Data Engine] Refactor to reduce code duplication

2020-01-17 Thread Kai Uwe Broulik
broulik abandoned this revision.
broulik added a comment.


  Incorporated in D26702 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26689

To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26717: [App Style KCM] Port GTK GHNS dialogs from exec()

2020-01-17 Thread Mikhail Zolotukhin
gikari updated this revision to Diff 73755.
gikari added a comment.


  Port dialogs to QtQuick

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26717?vs=73738=73755

BRANCH
  change-exec (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26717

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtk2_themes.knsrc
  kcms/style/gtk3_themes.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.h
  kcms/style/package/contents/ui/GtkStylePage.qml

To: gikari, broulik
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26185: Fix font rendering when compiled against Qt >= 5.14

2020-01-17 Thread David Edmundson
davidedmundson added a comment.


  Ack. Thanks for chasing up on indentifying causes.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26705: KCM/Component Revamp Terminal Emulator UI

2020-01-17 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> componentchooserterminal.cpp:47
> +void CfgTerminalEmulator::selectTerminalEmulator(int index) {
> +Q_UNUSED(index)
> +

remove

REPOSITORY
  R119 Plasma Desktop

BRANCH
  terminal-config

REVISION DETAIL
  https://phabricator.kde.org/D26705

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26714: KCM/Component Revamp FileManager UI

2020-01-17 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> componentchooserfilemanager.cpp:116
> +
> +// add a other option to add a new file manager with keditfiletype5
> +
> combofileManager->addItem(QIcon::fromTheme(QStringLiteral("application-x-shellscript")),
>  i18n("Other..."), QStringLiteral());

wrong comment

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26714

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D18006: Include only the largest size for the "Next" wallpaper

2020-01-17 Thread Filip Fila
filipf added a comment.


  In D18006#595782 , @ngraham wrote:
  
  > The whole point was to save some space on the user's machine. However 
trading space savings for load time maybe isn't the best trade-off? 18 MB isn't 
really all that much of a savings.
  >
  > Should we shelve this idea?
  
  
  I would go with yes. We also want the default wallpaper to be artistically 
perfectly cropped in addition to being efficient in all the non-artistic 
metrics. I think it's beneficial to make the trade off for the addon 
wallpapers, but this one should just be perfect.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D18006

To: ngraham, #vdg, #breeze, mart
Cc: apol, davidedmundson, mart, filipf, kvermette, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra


D26722: Load user information once on startup

2020-01-17 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:08178c059fd3: Load user information once on startup 
(authored by fvogt).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26722?vs=73749=73751

REVISION DETAIL
  https://phabricator.kde.org/D26722

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: fvogt, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26705: KCM/Component Revamp Terminal Emulator UI

2020-01-17 Thread Méven Car
meven updated this revision to Diff 73750.
meven added a comment.


  Clean two bad lines

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26705?vs=73718=73750

BRANCH
  terminal-config

REVISION DETAIL
  https://phabricator.kde.org/D26705

AFFECTED FILES
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/terminalemulatorconfig_ui.ui

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26722: Load user information once on startup

2020-01-17 Thread Fabian Vogt
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Apparently the seccomp filter can break KUser in certain setups, so load the
  info before the sandbox is active.

TEST PLAN
  Provided a test package to the reporter on the downstream bug
  (https://bugzilla.opensuse.org/show_bug.cgi?id=1160995), who reported
  success.

REPOSITORY
  R133 KScreenLocker

BRANCH
  boo1160995

REVISION DETAIL
  https://phabricator.kde.org/D26722

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h

To: fvogt, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

2020-01-17 Thread Konrad Materka
https://bugs.kde.org/show_bug.cgi?id=350365

Konrad Materka  changed:

   What|Removed |Added

  Component|general |Battery Monitor
 CC||plasma-b...@kde.org
   Target Milestone|--- |1.0
Product|Powerdevil  |plasmashell

-- 
You are receiving this mail because:
You are the assignee for the bug.

D26719: [Battery Monitor] Glow icon on hover

2020-01-17 Thread Konrad Materka
kmaterka added a comment.


  As proposed by @broulik in Bug 416310 
 it might be a good idea to create 
IconEffects.qml (or IconEffect.qml?). Ideally, it should have a feature parity 
with KIconEffect.
  Any recommendations?
  Where to put this component (org.kde.plasma.core, org.kde.plasma.components 
3.0, org.kde.plasma.extras, org.kde.plasma.workspace.components)?
  How to correctly document it?
  How to read KSharedConfig from QML?
  
  BTW. Will it help with T11637 ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26719

To: kmaterka, #plasma_workspaces, #plasma, broulik, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 92 - Still Failing!

2020-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/92/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 17 Jan 2020 08:47:50 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 88 lines...][Pipeline] sh[2020-01-17T08:48:36.336Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-desktop --branchGroup stable-kf5-qt5 --environment production --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/[2020-01-17T07:49:12.235Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-01-17T07:49:12.248Z]  > git config core.sparsecheckout # timeout=10[2020-01-17T07:49:12.256Z]  > git checkout -f 89d0452ba28ad311242c3a886a89c9fb84d339f8 # timeout=10[2020-01-17T08:48:39.598Z] Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5[2020-01-17T08:48:39.598Z] Retrieving: Plasma-kcodecs-stable-kf5-qt5[2020-01-17T08:48:39.598Z] Retrieving: Plasma-karchive-stable-kf5-qt5[2020-01-17T08:48:39.598Z] Retrieving: Plasma-ki18n-stable-kf5-qt5[2020-01-17T08:48:39.598Z] Retrieving: Plasma-kcoreaddons-stable-kf5-qt5[2020-01-17T08:48:39.598Z] Retrieving: Plasma-kauth-stable-kf5-qt5[2020-01-17T08:48:39.598Z] Retrieving: Plasma-kconfig-stable-kf5-qt5[2020-01-17T08:48:39.598Z] Retrieving: Plasma-kdoctools-stable-kf5-qt5[2020-01-17T08:48:39.854Z] Retrieving: Plasma-kguiaddons-stable-kf5-qt5[2020-01-17T08:48:39.854Z] Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5[2020-01-17T08:48:39.854Z] Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5[2020-01-17T08:48:39.854Z] Retrieving: Plasma-kitemviews-stable-kf5-qt5[2020-01-17T08:48:39.854Z] Retrieving: Plasma-kirigami-stable-kf5-qt5[2020-01-17T08:48:39.854Z] Retrieving: Plasma-kiconthemes-stable-kf5-qt5[2020-01-17T08:48:39.854Z] Retrieving: Plasma-kwindowsystem-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-kcrash-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-kdbusaddons-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-phonon-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-knotifications-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-kservice-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-kcompletion-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-sonnet-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-attica-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-kglobalaccel-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-ktextwidgets-stable-kf5-qt5[2020-01-17T08:48:40.109Z] Retrieving: Plasma-breeze-icons-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-kxmlgui-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-solid-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-kjobwidgets-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-kbookmarks-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-kwallet-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-kio-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-kparts-stable-kf5-qt5[2020-01-17T08:48:43.370Z] Retrieving: Plasma-syntax-highlighting-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kpackage-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kactivities-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kdnssd-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kdeclarative-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kidletime-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kitemmodels-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kross-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-threadweaver-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kunitconversion-stable-kf5-qt5[2020-01-17T08:48:43.626Z] Retrieving: Plasma-kwayland-stable-kf5-qt5[2020-01-17T08:48:43.884Z] Retrieving: Plasma-ktexteditor-stable-kf5-qt5[2020-01-17T08:48:43.884Z] Retrieving: Plasma-oxygen-icons5-stable-kf5-qt5[2020-01-17T08:48:45.778Z] Retrieving: Plasma-plasma-framework-stable-kf5-qt5[2020-01-17T08:48:45.778Z] Retrieving: Plasma-kpty-stable-kf5-qt5[2020-01-17T08:48:45.778Z] Retrieving: Plasma-kinit-stable-kf5-qt5[2020-01-17T08:48:45.778Z] Retrieving: Plasma-kded-stable-kf5-qt5[2020-01-17T08:48:45.778Z] Retrieving: Plasma-kemoticons-stable-kf5-qt5[2020-01-17T08:48:46.345Z] Retrieving: Plasma-kdesignerplugin-stable-kf5-qt5[2020-01-17T08:48:46.345Z] Retrieving: Plasma-knewstuff-stable-kf5-qt5[2020-01-17T08:48:46.345Z] Retrieving: Plasma-kfilemetadata-stable-kf5-qt5[2020-01-17T08:48:46.603Z] Retrieving: Plasma-baloo-stable-kf5-qt5[2020-01-17T08:48:46.603Z] Retrieving: Plasma-bluez-qt-stable-kf5-qt5[2020-01-17T08:48:46.603Z] Retrieving: Plasma-frameworkintegration-stable-kf5-qt5[2020-01-17T08:48:46.603Z] Retrieving: Plasma-kactivities-stats-stable-kf5-qt5[2020-01-17T08:48:46.603Z] Retrieving: 

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 244 - Still Failing!

2020-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/244/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Jan 2020 08:46:37 +
 Build duration:
1 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 128 lines...][Pipeline] sh[2020-01-17T08:47:17.424Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-desktop --branchGroup stable-kf5-qt5 --environment production --platform SUSEQt5.12 --installTo /home/jenkins//install-prefix/[2020-01-17T08:47:20.714Z] Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kcodecs-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-karchive-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-ki18n-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kcoreaddons-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-polkit-qt-1-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kauth-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kconfig-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kdoctools-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kguiaddons-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kitemviews-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kirigami-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kiconthemes-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kwindowsystem-stable-kf5-qt5[2020-01-17T08:47:20.714Z] Retrieving: Plasma-kcrash-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-kdbusaddons-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-phonon-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-knotifications-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-kservice-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-kcompletion-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-sonnet-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-attica-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-kglobalaccel-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-ktextwidgets-stable-kf5-qt5[2020-01-17T08:47:20.969Z] Retrieving: Plasma-breeze-icons-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kxmlgui-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-solid-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kjobwidgets-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kbookmarks-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kwallet-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kio-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kparts-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-syntax-highlighting-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kpackage-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kactivities-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kdnssd-stable-kf5-qt5[2020-01-17T08:47:22.851Z] Retrieving: Plasma-kdeclarative-stable-kf5-qt5[2020-01-17T08:47:23.110Z] Retrieving: Plasma-kidletime-stable-kf5-qt5[2020-01-17T08:47:23.110Z] Retrieving: Plasma-kitemmodels-stable-kf5-qt5[2020-01-17T08:47:23.110Z] Retrieving: Plasma-kross-stable-kf5-qt5[2020-01-17T08:47:23.110Z] Retrieving: Plasma-threadweaver-stable-kf5-qt5[2020-01-17T08:47:23.110Z] Retrieving: Plasma-kunitconversion-stable-kf5-qt5[2020-01-17T08:47:23.110Z] Retrieving: Plasma-kwayland-stable-kf5-qt5[2020-01-17T08:47:23.110Z] Retrieving: Plasma-ktexteditor-stable-kf5-qt5[2020-01-17T08:47:23.370Z] Retrieving: Plasma-oxygen-icons5-stable-kf5-qt5[2020-01-17T08:47:24.306Z] Retrieving: Plasma-plasma-framework-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kpty-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kinit-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kded-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kemoticons-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kdesignerplugin-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-knewstuff-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kfilemetadata-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-baloo-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-bluez-qt-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-frameworkintegration-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kactivities-stats-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kcmutils-stable-kf5-qt5[2020-01-17T08:47:27.607Z] Retrieving: Plasma-kdelibs4support-stable-kf5-qt5[2020-01-17T08:47:27.862Z] Retrieving: 

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 91 - Still Failing!

2020-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/91/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 17 Jan 2020 08:46:22 +
 Build duration:
29 sec and counting
   CONSOLE OUTPUT
  [...truncated 88 lines...][Pipeline] // stage[Pipeline] stage[Pipeline] { (Setup Dependencies)[Pipeline] sh[2020-01-17T08:46:38.759Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-desktop --branchGroup stable-kf5-qt5 --environment production --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/[2020-01-17T08:46:42.921Z] Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kcodecs-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-karchive-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-ki18n-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kcoreaddons-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kauth-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kconfig-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kdoctools-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kguiaddons-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kitemviews-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kirigami-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kiconthemes-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kwindowsystem-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kcrash-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kdbusaddons-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-phonon-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-knotifications-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kservice-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kcompletion-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-sonnet-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-attica-stable-kf5-qt5[2020-01-17T08:46:42.921Z] Retrieving: Plasma-kglobalaccel-stable-kf5-qt5[2020-01-17T08:46:43.177Z] Retrieving: Plasma-ktextwidgets-stable-kf5-qt5[2020-01-17T08:46:43.177Z] Retrieving: Plasma-breeze-icons-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kxmlgui-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-solid-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kjobwidgets-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kbookmarks-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kwallet-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kio-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kparts-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-syntax-highlighting-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kpackage-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kactivities-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kdnssd-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kdeclarative-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kidletime-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kitemmodels-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kross-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-threadweaver-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kunitconversion-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-kwayland-stable-kf5-qt5[2020-01-17T08:46:46.437Z] Retrieving: Plasma-ktexteditor-stable-kf5-qt5[2020-01-17T08:46:46.692Z] Retrieving: Plasma-oxygen-icons5-stable-kf5-qt5[2020-01-17T08:46:48.577Z] Retrieving: Plasma-plasma-framework-stable-kf5-qt5[2020-01-17T08:46:48.577Z] Retrieving: Plasma-kpty-stable-kf5-qt5[2020-01-17T08:46:48.577Z] Retrieving: Plasma-kinit-stable-kf5-qt5[2020-01-17T08:46:48.577Z] Retrieving: Plasma-kded-stable-kf5-qt5[2020-01-17T08:46:48.577Z] Retrieving: Plasma-kemoticons-stable-kf5-qt5[2020-01-17T08:46:48.833Z] Retrieving: Plasma-kdesignerplugin-stable-kf5-qt5[2020-01-17T08:46:48.833Z] Retrieving: Plasma-knewstuff-stable-kf5-qt5[2020-01-17T08:46:49.100Z] Retrieving: Plasma-kfilemetadata-stable-kf5-qt5[2020-01-17T08:46:49.100Z] Retrieving: Plasma-baloo-stable-kf5-qt5[2020-01-17T08:46:49.100Z] Retrieving: Plasma-bluez-qt-stable-kf5-qt5[2020-01-17T08:46:49.100Z] Retrieving: Plasma-frameworkintegration-stable-kf5-qt5[2020-01-17T08:46:49.100Z] Retrieving: Plasma-kactivities-stats-stable-kf5-qt5[2020-01-17T08:46:49.100Z] Retrieving: Plasma-kcmutils-stable-kf5-qt5[2020-01-17T08:46:49.100Z] Retrieving: Plasma-kdelibs4support-stable-kf5-qt5[2020-01-17T08:46:49.661Z] Retrieving: Plasma-kdesu-stable-kf5-qt5[2020-01-17T08:46:49.661Z] 

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 243 - Failure!

2020-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/243/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Fri, 17 Jan 2020 08:45:33 +
 Build duration:
1 min 2 sec and counting
   CONSOLE OUTPUT
  [...truncated 128 lines...][2020-01-17T08:46:20.328Z]  > git config core.sparsecheckout # timeout=10[2020-01-17T08:46:20.329Z]  > git checkout -f 0a7ee32c976f70638418cf72b196c39bd714529b # timeout=10[2020-01-17T08:46:25.243Z] Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kcodecs-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-karchive-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-ki18n-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kcoreaddons-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-polkit-qt-1-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kauth-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kconfig-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kdoctools-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kguiaddons-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kitemviews-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kirigami-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kiconthemes-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kwindowsystem-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kcrash-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kdbusaddons-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-phonon-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-knotifications-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kservice-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kcompletion-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-sonnet-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-attica-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-kglobalaccel-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-ktextwidgets-stable-kf5-qt5[2020-01-17T08:46:25.243Z] Retrieving: Plasma-breeze-icons-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-kxmlgui-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-solid-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-kjobwidgets-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-kbookmarks-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-kwallet-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-kio-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-kparts-stable-kf5-qt5[2020-01-17T08:46:27.146Z] Retrieving: Plasma-syntax-highlighting-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kpackage-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kactivities-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kdnssd-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kdeclarative-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kidletime-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kitemmodels-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kross-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-threadweaver-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kunitconversion-stable-kf5-qt5[2020-01-17T08:46:27.409Z] Retrieving: Plasma-kwayland-stable-kf5-qt5[2020-01-17T08:46:27.666Z] Retrieving: Plasma-ktexteditor-stable-kf5-qt5[2020-01-17T08:46:27.666Z] Retrieving: Plasma-oxygen-icons5-stable-kf5-qt5[2020-01-17T08:46:28.674Z] Retrieving: Plasma-plasma-framework-stable-kf5-qt5[2020-01-17T08:46:31.226Z] Retrieving: Plasma-kpty-stable-kf5-qt5[2020-01-17T08:46:31.493Z] Retrieving: Plasma-kinit-stable-kf5-qt5[2020-01-17T08:46:31.493Z] Retrieving: Plasma-kded-stable-kf5-qt5[2020-01-17T08:46:31.493Z] Retrieving: Plasma-kemoticons-stable-kf5-qt5[2020-01-17T08:46:31.748Z] Retrieving: Plasma-kdesignerplugin-stable-kf5-qt5[2020-01-17T08:46:31.748Z] Retrieving: Plasma-knewstuff-stable-kf5-qt5[2020-01-17T08:46:31.748Z] Retrieving: Plasma-kfilemetadata-stable-kf5-qt5[2020-01-17T08:46:32.007Z] Retrieving: Plasma-baloo-stable-kf5-qt5[2020-01-17T08:46:32.265Z] Retrieving: Plasma-bluez-qt-stable-kf5-qt5[2020-01-17T08:46:32.520Z] Retrieving: Plasma-frameworkintegration-stable-kf5-qt5[2020-01-17T08:46:32.520Z] Retrieving: Plasma-kactivities-stats-stable-kf5-qt5[2020-01-17T08:46:32.520Z] Retrieving: Plasma-kcmutils-stable-kf5-qt5[2020-01-17T08:46:32.520Z] Retrieving: Plasma-kdelibs4support-stable-kf5-qt5[2020-01-17T08:46:33.084Z] Retrieving: Plasma-kdesu-stable-kf5-qt5[2020-01-17T08:46:33.084Z] Retrieving: Plasma-kholidays-stable-kf5-qt5[2020-01-17T08:46:33.084Z] Retrieving: 

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 90 - Failure!

2020-01-17 Thread CI System
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/90/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 17 Jan 2020 08:45:33 +
 Build duration:
37 sec and counting
   CONSOLE OUTPUT
  [...truncated 88 lines...][2020-01-17T07:46:34.906Z]  > git rev-parse origin/master^{commit} # timeout=10[2020-01-17T07:46:34.915Z]  > git config core.sparsecheckout # timeout=10[2020-01-17T07:46:34.924Z]  > git checkout -f 89d0452ba28ad311242c3a886a89c9fb84d339f8 # timeout=10[Pipeline] sh[2020-01-17T08:45:54.114Z] + python3 -u ci-tooling/helpers/prepare-dependencies.py --product Plasma --project plasma-desktop --branchGroup stable-kf5-qt5 --environment production --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/[2020-01-17T08:45:57.377Z] Retrieving: Plasma-extra-cmake-modules-stable-kf5-qt5[2020-01-17T08:45:57.377Z] Retrieving: Plasma-kcodecs-stable-kf5-qt5[2020-01-17T08:45:57.377Z] Retrieving: Plasma-karchive-stable-kf5-qt5[2020-01-17T08:45:57.377Z] Retrieving: Plasma-ki18n-stable-kf5-qt5[2020-01-17T08:45:57.377Z] Retrieving: Plasma-kcoreaddons-stable-kf5-qt5[2020-01-17T08:45:57.377Z] Retrieving: Plasma-kauth-stable-kf5-qt5[2020-01-17T08:45:57.377Z] Retrieving: Plasma-kconfig-stable-kf5-qt5[2020-01-17T08:45:57.377Z] Retrieving: Plasma-kdoctools-stable-kf5-qt5[2020-01-17T08:45:57.632Z] Retrieving: Plasma-kguiaddons-stable-kf5-qt5[2020-01-17T08:45:57.632Z] Retrieving: Plasma-kwidgetsaddons-stable-kf5-qt5[2020-01-17T08:45:57.632Z] Retrieving: Plasma-kconfigwidgets-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-kitemviews-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-kirigami-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-kiconthemes-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-kwindowsystem-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-kcrash-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-kdbusaddons-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-phonon-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-knotifications-stable-kf5-qt5[2020-01-17T08:45:57.889Z] Retrieving: Plasma-kservice-stable-kf5-qt5[2020-01-17T08:45:58.144Z] Retrieving: Plasma-kcompletion-stable-kf5-qt5[2020-01-17T08:45:58.144Z] Retrieving: Plasma-sonnet-stable-kf5-qt5[2020-01-17T08:45:58.144Z] Retrieving: Plasma-attica-stable-kf5-qt5[2020-01-17T08:45:58.144Z] Retrieving: Plasma-kglobalaccel-stable-kf5-qt5[2020-01-17T08:45:58.144Z] Retrieving: Plasma-ktextwidgets-stable-kf5-qt5[2020-01-17T08:45:58.144Z] Retrieving: Plasma-breeze-icons-stable-kf5-qt5[2020-01-17T08:46:00.656Z] Retrieving: Plasma-kxmlgui-stable-kf5-qt5[2020-01-17T08:46:00.913Z] Retrieving: Plasma-solid-stable-kf5-qt5[2020-01-17T08:46:00.913Z] Retrieving: Plasma-kjobwidgets-stable-kf5-qt5[2020-01-17T08:46:00.913Z] Retrieving: Plasma-kbookmarks-stable-kf5-qt5[2020-01-17T08:46:00.913Z] Retrieving: Plasma-kwallet-stable-kf5-qt5[2020-01-17T08:46:00.913Z] Retrieving: Plasma-kio-stable-kf5-qt5[2020-01-17T08:46:01.168Z] Retrieving: Plasma-kparts-stable-kf5-qt5[2020-01-17T08:46:01.168Z] Retrieving: Plasma-syntax-highlighting-stable-kf5-qt5[2020-01-17T08:46:01.168Z] Retrieving: Plasma-kpackage-stable-kf5-qt5[2020-01-17T08:46:01.168Z] Retrieving: Plasma-kactivities-stable-kf5-qt5[2020-01-17T08:46:01.168Z] Retrieving: Plasma-kdnssd-stable-kf5-qt5[2020-01-17T08:46:01.168Z] Retrieving: Plasma-kdeclarative-stable-kf5-qt5[2020-01-17T08:46:01.425Z] Retrieving: Plasma-kidletime-stable-kf5-qt5[2020-01-17T08:46:01.425Z] Retrieving: Plasma-kitemmodels-stable-kf5-qt5[2020-01-17T08:46:01.425Z] Retrieving: Plasma-kross-stable-kf5-qt5[2020-01-17T08:46:01.425Z] Retrieving: Plasma-threadweaver-stable-kf5-qt5[2020-01-17T08:46:01.425Z] Retrieving: Plasma-kunitconversion-stable-kf5-qt5[2020-01-17T08:46:01.425Z] Retrieving: Plasma-kwayland-stable-kf5-qt5[2020-01-17T08:46:01.425Z] Retrieving: Plasma-ktexteditor-stable-kf5-qt5[2020-01-17T08:46:01.681Z] Retrieving: Plasma-oxygen-icons5-stable-kf5-qt5[2020-01-17T08:46:03.579Z] Retrieving: Plasma-plasma-framework-stable-kf5-qt5[2020-01-17T08:46:04.525Z] Retrieving: Plasma-kpty-stable-kf5-qt5[2020-01-17T08:46:04.525Z] Retrieving: Plasma-kinit-stable-kf5-qt5[2020-01-17T08:46:04.525Z] Retrieving: Plasma-kded-stable-kf5-qt5[2020-01-17T08:46:04.525Z] Retrieving: Plasma-kemoticons-stable-kf5-qt5[2020-01-17T08:46:05.085Z] Retrieving: Plasma-kdesignerplugin-stable-kf5-qt5[2020-01-17T08:46:05.085Z] Retrieving: Plasma-knewstuff-stable-kf5-qt5[2020-01-17T08:46:05.085Z] Retrieving: Plasma-kfilemetadata-stable-kf5-qt5[2020-01-17T08:46:05.085Z] Retrieving: Plasma-baloo-stable-kf5-qt5[2020-01-17T08:46:05.350Z] Retrieving: Plasma-bluez-qt-stable-kf5-qt5[2020-01-17T08:46:05.350Z] Retrieving: Plasma-frameworkintegration-stable-kf5-qt5[2020-01-17T08:46:05.350Z] Retrieving: Plasma-kactivities-stats-stable-kf5-qt5[2020-01-17T08:46:05.350Z] Retrieving: 

D26705: KCM/Component Revamp Terminal Emulator UI

2020-01-17 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> componentchooserterminal.cpp:138
> +changed(index != m_currentIndex);
> +m_currentIndex = terminalCombo->currentIndex();
> +} else {

Remove

> componentchooserterminal.cpp:143
> +terminalCombo->setCurrentIndex(terminalCombo->count() - 2);
> +m_currentIndex = terminalCombo->currentIndex();
> +

Remove

REPOSITORY
  R119 Plasma Desktop

BRANCH
  terminal-config

REVISION DETAIL
  https://phabricator.kde.org/D26705

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26565: KCM/Component Revamp email config

2020-01-17 Thread Méven Car
meven updated this revision to Diff 73747.
meven marked an inline comment as done.
meven added a comment.


  Remove a bad line

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26565?vs=73695=73747

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

AFFECTED FILES
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/emailclientconfig_ui.ui

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26565: KCM/Component Revamp email config

2020-01-17 Thread Méven Car
meven added inline comments.

INLINE COMMENTS

> componentchooseremail.cpp:144
> +// select newly inserted email client
> +m_currentIndex = emailClientsCombo->count() - 2;
> +emailClientsCombo->setCurrentIndex(m_currentIndex);

remove

REPOSITORY
  R119 Plasma Desktop

BRANCH
  email-config

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi, dvratil
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26714: KCM/Component Revamp FileManager UI

2020-01-17 Thread Méven Car
meven updated this revision to Diff 73746.
meven added a comment.


  Use KOpenWithDialog instead of keditfiletype5 to select the filemanager + 
small fix

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26714?vs=73731=73746

BRANCH
  filemanager-settings

REVISION DETAIL
  https://phabricator.kde.org/D26714

AFFECTED FILES
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/filemanagerconfig_ui.ui

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26185: Fix font rendering when compiled against Qt >= 5.14

2020-01-17 Thread Fabian Vogt
fvogt added a comment.


  The change itself is correct, but not in relation to the title and summary 
which are about https://bugreports.qt.io/browse/QTBUG-80967, which was a 
genuine bug in Qt, fixed in 5.14.1.
  What this change fixes is double scaling in applications which enable 
`Qt::AA_EnableHighDpiScaling`.
  
  So please change those accordingly, add `BUG: 415421` and it can go in.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26185

To: ahartmetz, #plasma, apol, davidedmundson
Cc: acooligan, fvogt, asturmlechner, dfaure, davidedmundson, anthonyfieroni, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D24706: [RFC] Change button style

2020-01-17 Thread Christoph Feck
cfeck added a comment.


  If application developers need a rotated button, they need to rotate only the 
contents, not the frame.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D24706

To: ndavis, #vdg, #breeze
Cc: cfeck, The-Feren-OS-Dev, cblack, bodoeggert, ngraham, plasma-devel, 
manueljlin, Orage, LeGast00n, konkinartem, ian, jguidon, hannahk, Ghost6, 
jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, 
alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart


D26714: KCM/Component Revamp FileManager UI

2020-01-17 Thread Méven Car
meven planned changes to this revision.
meven added a comment.


  In D26714#595786 , @ngraham wrote:
  
  > Selecting the "Other..." option for this one takes me to the filetype 
editor for `inode/directory` instead of the app chooser as in the other 
patches. Is that intentional?
  
  
  It is.
  But I was thinking about using the app chooser directly for consistency.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26714

To: meven, #plasma, ervin, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart