D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 74347.
gvgeo added a comment.


  Need specific width for columns in FLow. Changed maximumWidth to 
preferredWidth.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=74322=74347

BRANCH
  b3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26911: Align SpinBox text with LineEdit text

[Noah Davis]

ndavis abandoned this revision.
ndavis added a comment.


  Whoops, this problem doesn't actually exist in git master, I must have caused 
it while trying to fix another problem. I was so sure of myself...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26911

To: ndavis, #vdg, #breeze, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26911: Align SpinBox text with LineEdit text

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The SpinBox edit field didn't have the right horizontal alignment and the 
math using the spinbox frame width was off by about 2x.

REPOSITORY
  R31 Breeze

BRANCH
  spinbox-lineedit-alignment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26911

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Bad combobox width strikes again 
(https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon:
  
  F7939162: Screenshot_20200124_204922.PNG 

  
  Also, gross, there are duplicates

INLINE COMMENTS

> main.cpp:139
>  qmlRegisterAnonymousType("org.kde.plasma.sdk", 1);
> +qmlRegisterAonymousType("org.kde.plasma.sdk", 
> 1);
>  #endif

typo causes a build failure

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Albert Astals Cid]

aacid added a comment.


  stable branch please :)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  restore-old-style-kns-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: aacid, yurchor, davidedmundson, kde-i18n-doc, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D25584: [TabBar] Remove frame

[Filip Fila]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:2ecfa27b0af0: [TabBar] Remove frame (authored by filipf).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25584?vs=72051=74336

REVISION DETAIL
  https://phabricator.kde.org/D25584

AFFECTED FILES
  org.kde.desktop/TabBar.qml

To: filipf, #plasma, #vdg, ngraham, broulik, mart
Cc: mart, ahiemstra, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol

D26799: Apply KDE coding style, minor optimizations

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  emit and Q_EMIT are the same thing, I wouldn't change any future instances
  
  Q_EMIT has the advantage of not conflicting with some other libraries like 
emit sometimes can

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26799

To: alex, ngraham, meven, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Thanks :)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26582

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

[Méven Car]

meven added a comment.


  In D26582#600469 , @hein wrote:
  
  > So does this fall through to the dialog when the type hasn't been determined
  
  
  Any file has always one mime type : "application/octet-stream", but KRun 
generally resolves mimetype throug extension then through kio.
  And then will use KOpenWithDialog when there is no app associated to this 
mimetype.
  
  And this code basically reverts :
  https://phabricator.kde.org/D10835
  Just adding `run->setRunExecutables` instead.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26038: feat(kcm): add option for auto rotation

[seb sasch]

sasch added a comment.


  Don't want to spam here, pretty cool. However, I don't see the orientation 
part within settings on the latest daily opensuse Kryption (Plasma 5.18.80) in 
a wayland session ( 
https://phabricator.kde.org/file/data/3sk75xlk4g762d3dvdep/PHID-FILE-uuwpwd636vbjefesyjb7/preview-Screenshot_20191216_025659.png
 ). Is there any tablet mode I need to enable first, or any advice how I could 
test it on my convertible?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D26038

To: romangg, #plasma
Cc: plasma-devel, apol, aaronhoneycutt, sasch, ngraham, davidedmundson, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

[Eike Hein]

hein added a comment.


  So does this fall through to the dialog when the type hasn't been determined?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26904: Use Qt5 syntax for signal, rename files

[Alexander Lohnau]

alex created this revision.
alex added reviewers: mlaurent, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The signal in the SonnetSpellCheckingModule constructor now uses the Qt5 
syntax and the method has been correctly indented.
  Additionally the desktop file and library have been renamed to fit the 
conventions.

TEST PLAN
  You can launch the plugin using "kcmshell5 kcm_spellchecking"

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26904

AFFECTED FILES
  kcms/spellchecking/CMakeLists.txt
  kcms/spellchecking/kcm_spellchecking.desktop
  kcms/spellchecking/spellchecking.cpp
  kcms/spellchecking/spellchecking.desktop

To: alex, mlaurent, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

[David Redondo]

davidre added a comment.


  Ping since system theme support is now in frameworks and  plasma master can 
depend on frameworks master

REPOSITORY
  R118 Plasma SDK

REVISION DETAIL
  https://phabricator.kde.org/D25273

To: davidre, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25273: Enable selecting all installed color schemes in Cuttlefish

[David Redondo]

davidre updated this revision to Diff 74332.
davidre added a comment.


  - remove default color scheme, system theme support in kcolorschememanager, 
also display icons

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25273?vs=69667=74332

BRANCH
  colorschemes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25273

AFFECTED FILES
  CMakeLists.txt
  cuttlefish/autotests/CMakeLists.txt
  cuttlefish/package/contents/ui/Comparison.qml
  cuttlefish/package/contents/ui/IconGridDelegate.qml
  cuttlefish/package/contents/ui/Preview.qml
  cuttlefish/package/contents/ui/ResponsivePreview.qml
  cuttlefish/package/contents/ui/SvgGrid.qml
  cuttlefish/package/contents/ui/Tools.qml
  cuttlefish/package/contents/ui/ToolsResponsive.qml
  cuttlefish/package/contents/ui/cuttlefish.qml
  cuttlefish/src/CMakeLists.txt
  cuttlefish/src/colorschemes.cpp
  cuttlefish/src/colorschemes.h
  cuttlefish/src/iconmodel.cpp
  cuttlefish/src/iconmodel.h
  cuttlefish/src/main.cpp

To: davidre, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Filip Fila]

filipf added a comment.


  Well I tested this with several themes and it looks just fine on all of them 
except Sweet. A #plasma  person should 
have a look at the code, but visually and usability-wise this is pretty good.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

[Ahmad Samir]

ahmadsamir abandoned this revision.
ahmadsamir added a comment.


  OK.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26902

To: ahmadsamir, #plasma, davidedmundson, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

[Nathaniel Graham]

ngraham added a comment.


  Wasn't this already fixed with D26772 ?

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26902

To: ahmadsamir, #plasma, davidedmundson, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

[Nathaniel Graham]

ngraham added a comment.


  Ah, looks like it landed on the stable branch but was never merged to master. 
Just did that.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26902

To: ahmadsamir, #plasma, davidedmundson, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

[Méven Car]

meven added a comment.


  ping :) @hein

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26111: Runner: make recentdocument use KActivityStats data

[Méven Car]

meven added a comment.


  Gentle ping dear reviewers.

INLINE COMMENTS

> recentdocuments.cpp:69
> +| Agent::any()
> +| Url("/*/" + term + "*")
> +| Limit(30);

Request for now is limited, it will need some work in KActivityStats to be more 
clever

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26111

To: meven, #plasma, ivan, ngraham, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26902: Fix systemsettings5 crash if kscreenlocker shortcut is empty

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: Plasma, davidedmundson, mart.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

TEST PLAN
  - Make the kscreenlocker shortcut empty
  - Try opening systemsettings -> workspace behaviour, it crashes
  - Apply diff and try again

REPOSITORY
  R133 KScreenLocker

BRANCH
  l-crash (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26902

AFFECTED FILES
  kscreensaversettings.cpp

To: ahmadsamir, #plasma, davidedmundson, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> gvgeo wrote in BatteryItem.qml:112
> This does not react to preferredWidth, minimumWidth or maximumWidth. Is it 
> really managed by Layout?

It's not Flow isn't a layout.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Re: Long press global shortcuts

[Aleix Pol]

On Sun, Jan 12, 2020 at 6:11 PM Aleix Pol  wrote:
>
> Hi,
> In a discussion some weeks ago, we came to the conclusion that it
> would make sense to support long press global shortcuts.
>
> The use-case we discussed back then was the power button on the Plasma
> phone. We need to have 2 actions upon press. Short press would lock
> and dim the screen, long press would show the shutdown button.
> Thinking about it further makes me think it's something we probably
> want for the desktop use-case as well.
>
> The problem is two-fold:
> - We need to support long-press on kglobal accel (or even QShortcut?)
> - When do we trigger the action? Because now it happens on pressed.
>
> The second part of this is why I'm sending this e-mail. We're
> responding to global shortcuts on press rather than on release, which
> makes it impossible to handle the long press. Would it make sense to
> change it to on release? Maybe only in the cases where there's a long
> press counterpart?
>
> Aleix

Hi,
So I've been looking into it further and it turns out that the power
button is special in libinput in that Press and Release are always
emitted together upon press on my laptops (kde slimbook 1, dell xps
13, ms surface go). Good news is that on my nexus 5x it does the right
thing. I wonder how reliable that is though.

I have no idea why that is, it could make sense to reach out to
libinput upstream and they know what's going on.
You can test it in your computer by using "sudo libinput debug-events".

https://phabricator.kde.org/D26899
Here's a patch that should work, consequently we should implement
Qt::Key_PowerDown on powerdevil and start removing the ad-hoc dpms
management we do at the moment on hwcomposer.

Alternatively, we could also consider implementing it for double-press.

Aleix

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo marked 5 inline comments as done.
gvgeo added a comment.


  After some effort, I reached in these conclusions:
  1.Is not that big of a problem to specify width in a layout. The big problem 
is specifying preferredWidth and height in the same item. Breaks the 
dimensions, this is what got me confused.
  2.Item set as property, does not get managed by layout.
  
  There are still some width set in places. That do not respond to 
preferredWidth, minimumWidth or maximumWidth.

INLINE COMMENTS

> BatteryItem.qml:112
> +height: implicitHeight
> +width: modelData.label ? detailsLayout.leftColumnWidth : 
> detailsLayout.rightColumnWidth
> +wrapMode: Text.NoWrap

This does not react to preferredWidth, minimumWidth or maximumWidth. Is it 
really managed by Layout?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 74322.
gvgeo added a comment.


  Remove as much as I could width and height settings.
  Removed loader. Moved instead flow in place.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=74314=74322

BRANCH
  b3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yeah, it won't be perfect for everything, but I think it's better than what 
we have right now and fixes the bug.
  
  Is everyone okay with this?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Manuel Jesús de la Fuente]

manueljlin accepted this revision.
manueljlin added a comment.


  Nice, looks great! About the stream name, it doesn't look like it's useful 
most of the time so it might be better to remove it

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  layout2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26895: Introduce an Info Center mode

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> MenuModel.cpp:26
>  #include "MenuItem.h"
> -
> +#include 
>  

not needed

> ModuleView.cpp:349
>  if (activeModule) {
> -
> KActivities::ResourceInstance::notifyAccessed(QUrl(QStringLiteral("kcm:") + 
> activeModule->moduleInfo().service()->storageId()),
> -QStringLiteral("org.kde.systemsettings"));
> +if (d->mSaveStatistics) {
> +
> KActivities::ResourceInstance::notifyAccessed(QUrl(QStringLiteral("kcm:") + 
> activeModule->moduleInfo().service()->storageId()),

We might want to have a different url scheme like "kinfo" insteat of "kcm" and 
"org.kde.kinfocenter" instead of "org.kde.systemsettings"

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma
Cc: meven, davidedmundson, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26881: [Applets/Folder View] Allow using a folder that ends with a space

[Anthony Fieroni]

anthonyfieroni added a comment.


  If url ends with more than one space?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26881

To: ngraham, hein, #plasma
Cc: anthonyfieroni, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> BatteryItem.qml:48
> +spacing: units.smallSpacing
> +width: leftColumnWidth + spacing + rightColumnWidth
>  

width used inside a layout

> BatteryItem.qml:57
>  height: implicitHeight
> +width: modelData.label ? detailsLayout.leftColumnWidth : 
> detailsLayout.rightColumnWidth
> +wrapMode: Text.NoWrap

width/height used inside a layout

> BatteryItem.qml:83
> +id: batteryIcon
> +width: units.iconSizes.smallMedium
> +height: width

here

> PopupDialog.qml:147
> +id: batteryList
> +height: childrenRect.height
> +implicitHeight: height

and here

> PowerManagementItem.qml:34
> +MouseArea {
> +width: childrenRect.width
> +height: childrenRect.height

and here

and you shouldn't need to be using chidrenRect.width 
when your child has

  anchors.fill: parent

that's a loop

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 74314.
gvgeo added a comment.


  Don't show suppression messages if PM is disabled.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=74262=74314

BRANCH
  b3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26891: Apply Breeze GTK theme on startup, if the config is empty

[Mikhail Zolotukhin]

gikari added a comment.


  In D26891#600210 , @fvogt wrote:
  
  > It should only do the migration once, like the kconf_update script.
  
  
  From where migration script is launched? Can the migration script itself be a 
standalone entity, that uses kded module for requesting the current theme ans 
setting whatever it wants in every config?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

[Nathaniel Graham]

ngraham added a comment.


  In D26896#600258 , @broulik wrote:
  
  > Would it make sense to keep a `kinfocenter` script that just launchers 
`systemsettings5 -i` for compat?
  >  Does it still show up if you type "kinfocenter" into KRunner, not sure if 
it uses the `Exec` for that if this name is in the desktop file somewhere other 
than that.
  
  
  +1, would be nice to keep the old name around somehow for compatibility. We 
are shooting for enterprise-grade after all, and those folks hate this kind of 
renaming that breaks their custom scripts.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma
Cc: ngraham, broulik, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26881: [Applets/Folder View] Allow using a folder that ends with a space

[Kai Uwe Broulik]

broulik added a comment.


  That's somewhat oddly spcific, isn't it? I'd be surprised that 
`fromLocalFile` strips trailing spaces? :0

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26881

To: ngraham, hein, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Apply Breeze GTK theme on startup, if the config is empty

[Fabian Vogt]

fvogt added a comment.


  In D26891#600264 , @gikari wrote:
  
  > In D26891#600210 , @fvogt wrote:
  >
  > > If this is adjusted to include the migration code for older breeze-like 
GTK themes from 
https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa,
 it should be possible to drop the kconf_update script there.
  > >  It might even cause conflicts otherwise.
  >
  >
  > If I understood correctly, this script replaces the theme setting from 
`orion`/`oxygen-gtk` to `Breeze`. But what if a user wants to actually use 
`Oxygen` for GTK theme?
  
  
  The kconf_update script only runs once, which means only for a) Fresh 
profiles b) Profiles older than the kconf_update script introduction (-> KDE4)
  For a), no manual configuration was done and for b) Migration from oxygen -> 
breeze is done already for the widget theme, so it's needed for consistency.
  
  > Kded Module here is started every time on login, therefore it should not 
replace the settings from correct ones to correct ones.
  
  It should only do the migration once, like the kconf_update script.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Apply Breeze GTK theme on startup, if the config is empty

[Mikhail Zolotukhin]

gikari marked 3 inline comments as done.
gikari added a comment.


  In D26891#600210 , @fvogt wrote:
  
  > If this is adjusted to include the migration code for older breeze-like GTK 
themes from 
https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa,
 it should be possible to drop the kconf_update script there.
  >  It might even cause conflicts otherwise.
  
  
  If I understood correctly, this script replaces the theme setting from 
`orion`/`oxygen-gtk` to `Breeze`. But what if a user wants to actually use 
`Oxygen` for GTK theme?
  
  Kded Module here is started every time on login, therefore it should not 
replace the settings from correct ones to correct ones.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

[Kai Uwe Broulik]

broulik added a comment.


  Would it make sense to keep a `kinfocenter` script that just launchers 
`systemsettings5 -i` for compat?
  Does it still show up if you type "kinfocenter" into KRunner, not sure if it 
uses the `Exec` for that if this name is in the desktop file somewhere other 
than that.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26895: Introduce an Info Center mode

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> SettingsBase.h:48
> +// This has effect only if set right after the ctor
> +void setInfoCenterMode(bool set);
>  bool queryClose() override;

why not an arg in the ctor then?

> SettingsBase.h:95
> +MenuItem * homeModule = nullptr;
>  MenuItem * lostFound = nullptr;
>  KService::List categories;

what happens to lost and found modules

> main.cpp:57
>  QCommandLineParser parser;
> +QCommandLineOption infoCenterOption(QStringList() << QStringLiteral("i") 
> << QStringLiteral("showInformation"),
> +i18n("Show System information 
> instead of System configuration."));

As an alternative, we could switch based on our binary name, from arg[0] and 
then install a symlink.
Then we have 100% compatibility

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma
Cc: davidedmundson, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26896: Kill the KinfoCenter binary

[David Edmundson]

davidedmundson added a comment.


  Assuming the other gets in, ship it!

INLINE COMMENTS

> CMakeLists.txt:25
>  Crash
>  DBusAddons
>  DocTools

We can probably get rid of at least this. Maybe quite a few others

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26896

To: mart, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26895: Introduce an Info Center mode

[Kai Uwe Broulik]

broulik added a comment.


  Great idea!

INLINE COMMENTS

> SettingsBase.h:100
>  KAboutApplicationDialog * aboutDialog = nullptr;
> +bool m_infoCenterMode = false;
>  };

I would prefer this to be an enum

> main.cpp:66
> +if (infoCenterMode) {
> +QCoreApplication::setApplicationName(QStringLiteral("kinfocenter"));
> +application.setApplicationName(QStringLiteral("kinfocenter"));

Can we not just create a different `KAboutData` instance?

> main.cpp:71
> +aboutData.setDesktopFileName(QStringLiteral("org.kde.kinfocenter"));
> +aboutData.setShortDescription(QStringLiteral("Centralized and 
> convenient overview of system information"));
> +
> application.setWindowIcon(QIcon::fromTheme(QStringLiteral("hwinfo")));

`i18n`

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D26895

To: mart, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26896: Kill the KinfoCenter binary

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  Remove the binary, only install the modules and categories.
  The categories have been reorganized a bit to be compatible with 
SystemSettigns

REPOSITORY
  R102 KInfoCenter

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26896

AFFECTED FILES
  CMakeLists.txt
  Categories/CMakeLists.txt
  Categories/basicinformation.desktop
  Categories/detailedinformation.desktop
  Categories/deviceinfocategory.desktop
  Categories/graphicalinfocategory.desktop
  Categories/kinfocentercategory.desktop
  Categories/networkinfocategory.desktop
  Modules/about-distro/src/about-distro.desktop
  Modules/energy/kcm_energyinfo.desktop
  Modules/fileindexermonitor/kcm_fileindexermonitor.desktop
  Modules/memory/kcm_memory.desktop
  ToolTips/tooltipmanager.cpp
  ToolTips/tooltipmanager.h
  config-X11.h.cmake
  config-project-version.h.cmake
  infocenter.cpp
  infocenter.h
  infokcmmodel.cpp
  infokcmmodel.h
  infokcmproxymodel.cpp
  infokcmproxymodel.h
  kcmcategoryitem.cpp
  kcmcategoryitem.h
  kcmcontainer.cpp
  kcmcontainer.h
  kcmtreeitem.cpp
  kcmtreeitem.h
  kinfocenterui.rc
  main.cpp
  main.h
  org.kde.kinfocenter.desktop
  sidepanel.cpp
  sidepanel.h

To: mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26895: Introduce an Info Center mode

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  withthe command line switch -i, start
  systemsettings loading the KInfoCenter modules and hyerarchy instead.
  
  - KAboutData and dbus service name will be the same of KInfoCenter
  - The startup page is not shown but the "System Information" kcm is loaded 
instead
  - KACtivityStats is disabled
  - The home button will load the "System Information" kcm as well
  - It will *always* be in sidebar mode regardless how systemsettings is 
configured
  - Config dialog can't be open.

TEST PLAN
  - SystemSettings mode functionality didn't change
  - infocenter mode is fully functional

REPOSITORY
  R124 System Settings

BRANCH
  mart/kinfoCenterMode

REVISION DETAIL
  https://phabricator.kde.org/D26895

AFFECTED FILES
  app/SettingsBase.cpp
  app/SettingsBase.h
  app/SystemSettingsApp.cpp
  app/SystemSettingsApp.h
  app/main.cpp
  core/BaseData.cpp
  core/BaseData.h
  core/BaseMode.cpp
  core/BaseMode.h
  core/MenuItem.cpp
  core/MenuModel.cpp
  core/MenuModel.h
  core/ModuleView.cpp
  core/ModuleView.h
  sidebar/SidebarMode.cpp

To: mart, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Vlad Zahorodnii]

zzag added inline comments.

INLINE COMMENTS

> zzag wrote in metainfo.yaml:1
> I think Martin didn't step down officially.

"officially"

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D26894

To: kossebau, #kwin
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Vlad Zahorodnii]

zzag added a comment.


  +1
  
  > So, is kdecoration still a non-deprecated lib?
  
  Yes, KDecoration2 is a non-deprecated lib.

INLINE COMMENTS

> metainfo.yaml:1
> -maintainer: graesslin
>  description: Plugin based library to create window decorations.

I think Martin didn't step down officially.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D26894

To: kossebau, #kwin
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Apply Breeze GTK theme on startup, if the config is empty

[Fabian Vogt]

fvogt added a comment.


  If this is adjusted to include the migration code for older breeze-like GTK 
themes from 
https://cgit.kde.org/breeze-gtk.git/tree/kconf_update/main.cpp?id=b00e12ff39264fd8c2fb8af4168e998726766dfa,
 it should be possible to drop the kconf_update script there.
  It might even cause conflicts otherwise.

INLINE COMMENTS

> gikari wrote in gtkconfig.h:76
> `GtkConfig::applyAllSettings()`?

Indeed - I didn't notice that hunk extended beyond adding two methods...

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Yuri Chornoivan]

yurchor added a comment.


  No objections for porting into the stable branch from the Ukrainian team.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  restore-old-style-kns-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: yurchor, davidedmundson, kde-i18n-doc, gikari, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Friedrich W. H. Kossebau]

kossebau added a comment.


  I stumbled over that metainfo.yaml file and was wondering whether this would 
not be a lib that wants to be covered an api.kde.org.
  So, is kdecoration still a non-deprecated lib? If so, this change should 
trigger addition of KDecoration on api.kde.org, similar like KAsync is 
currently at the toplevel.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D26894

To: kossebau, #kwin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> broulik wrote in componentchooseremail.cpp:149
> So here you do show an `entryPath` but not in the other components?

For email I have a slightly more advanced logic to read and display the "Added 
Associations" section of mimeapps.list and add it to the list of choices.

I did this because at least for thunderbird, when it set itself as default 
browser it creates a new entry to "Added Associations" and use this new entry 
as choice in "Default Applications".
But this new application service has no icon defined, so a user would be 
confused to see two entries for Thunderbird in the list, one with the icon 
which is not selected.
I meant here to display something to the user to help distinguish between the 
two.

I may want to reconsider and simply add whatever service is in Default 
Application and display it, ignoring entries in "Added Associations", as I do 
elsewhere.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-component-chooser

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26894: Enable publication of API dox on api.kde.org

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kossebau requested review of this revision.

REPOSITORY
  R129 Window Decoration Library

BRANCH
  addtoapikdeorg

REVISION DETAIL
  https://phabricator.kde.org/D26894

AFFECTED FILES
  README.md
  metainfo.yaml

To: kossebau, #kwin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Méven Car]

meven updated this revision to Diff 74304.
meven marked 11 inline comments as done.
meven added a comment.


  - Make CfgPlugin a QComboBox with default and currently saved index handling
  - General code improvements : in loops, naming...
  - set the minimal width of combobox 18 making them most of the time of same 
lenght
  - Correct typo in license declaration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26797?vs=74012=74304

BRANCH
  new-component-chooser

REVISION DETAIL
  https://phabricator.kde.org/D26797

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/browserconfig_ui.ui
  kcms/componentchooser/componentchooser.cpp
  kcms/componentchooser/componentchooser.h
  kcms/componentchooser/componentchooser_ui.ui
  kcms/componentchooser/componentchooserbrowser.cpp
  kcms/componentchooser/componentchooserbrowser.h
  kcms/componentchooser/componentchooseremail.cpp
  kcms/componentchooser/componentchooseremail.h
  kcms/componentchooser/componentchooserfilemanager.cpp
  kcms/componentchooser/componentchooserfilemanager.h
  kcms/componentchooser/componentchooserterminal.cpp
  kcms/componentchooser/componentchooserterminal.h
  kcms/componentchooser/componentconfig_ui.ui
  kcms/componentchooser/emailclientconfig_ui.ui
  kcms/componentchooser/filemanagerconfig_ui.ui
  kcms/componentchooser/kcm_componentchooser.cpp
  kcms/componentchooser/kcm_componentchooser.h
  kcms/componentchooser/terminalemulatorconfig_ui.ui

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26847: Hide irrevelevant default button, code clean and future proofing

[Méven Car]

meven added a comment.


  In D26847#600133 , @rikmills wrote:
  
  > Fails to build:
  >
  > 
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console
  >
  > 00:42:51 /workspace/build/src/usermanager.cpp: In constructor 
‘UserManager::UserManager(QWidget*, const QVariantList&)’:
  >  00:42:51 /workspace/build/src/usermanager.cpp:68:70: error: no matching 
function for call to ‘UserManager::connect(AccountInfo*&, void 
(AccountInfo::*)(bool), UserManager*, )’
  >  00:42:51  connect(m_widget, ::changed, this, 
::changed);
  >  00:42:51   
^
  
  
  Thanks @rikmills
  
  I don't get why it does not compile.
  I don't reproduce locally :/
  
  Tentative fix : https://phabricator.kde.org/D26893

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26847

To: meven, ngraham, #plasma
Cc: rikmills, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26893: Fix a building issue

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ngraham, rikmills.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Build regression introduced in D26847 
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console

TEST PLAN
  Builds

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26893

AFFECTED FILES
  src/usermanager.cpp

To: meven, #plasma, ngraham, rikmills
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26870: [ksgrd] Drop a QWidget dependency

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R111:d7a5f72c7a69: [ksgrd] Drop a QWidget dependency (authored 
by davidedmundson).

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26870?vs=74238=74302

REVISION DETAIL
  https://phabricator.kde.org/D26870

AFFECTED FILES
  CMakeLists.txt
  ksgrd/CMakeLists.txt
  ksgrd/SensorManager.cpp
  ksgrd/SensorManager.h

To: davidedmundson, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[David Edmundson]

davidedmundson added subscribers: kde-i18n-doc, davidedmundson.
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Which branch?
  
  I don't have a strong opinion, that's something that needs @kde-i18n-doc to 
decide

REPOSITORY
  R119 Plasma Desktop

BRANCH
  restore-old-style-kns-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma, davidedmundson
Cc: davidedmundson, kde-i18n-doc, gikari, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Mikhail Zolotukhin]

gikari added a comment.


  This also should be changed in GTK Subpage in Application Style KCM (D26717 
)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26892

To: leinir, #plasma
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Apply Breeze GTK theme on startup, if the config is empty

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> fvogt wrote in gtkconfig.h:76
> Where are those methods called from?

`GtkConfig::applyAllSettings()`?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26892: Switch to the old-style button text for the KNSQuick buttons

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  This fixes a series of localization issues as reported in
  https://bugs.kde.org/show_bug.cgi?id=415541 based on the
  minimum-impact method (hopefully these strings should even
  still be in the pot files...)
  
  BUG:415541

REPOSITORY
  R119 Plasma Desktop

BRANCH
  restore-old-style-kns-button-text (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26892

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: leinir
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Apply Breeze GTK theme on startup, if the config is empty

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> gtkconfig.h:76
>  
> +void setDefaultGtk2Theme() const;
> +void setDefaultGtk3Theme() const;

Where are those methods called from?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Apply Breeze GTK theme on startup, if the config is empty

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  BUG: 416635
  FIXED-IN: 5.18.0

TEST PLAN
  1. Remove `gtk-theme-name=` line in `~/.gtkrc-2.0` file
  2. Restart `kded5`, `gtk-theme-name="Breeze"` line should appear in 
`~/.gtkrc-2.0` file
  3. Remove `gtk-theme-name=` line in `~/.config/gtk-3.0/settings.ini` file
  4. Restart `kded5`, `gtk-theme-name=Breeze` line should appear in 
`~/.config/gtk-3.0/settings.ini` file, also it should be changed in dconf in 
`org.gnome.desktop.interface.gtk-theme` prefix and in 
`~/.config/xsettingsd/xsettingsd.conf` file (`Net/ThemeName "Breeze"` line)

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  apply-theme-on-startup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26891

AFFECTED FILES
  kded/configeditor.cpp
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo added a comment.


  Never going to be correct. Sometimes the highlight touches the edges, other 
times have big margins. The aim was to avoid getting out of the svg frame.
  
  These changes focus even more on the breeze theme. 
   Sweet theme has some issues.
   F7927628: Screenshot_20200124_112438.png 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo updated this revision to Diff 74298.
gvgeo added a comment.


  Change line order.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26861?vs=74297=74298

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo updated this revision to Diff 74297.
gvgeo added a comment.
This revision is now accepted and ready to land.


  Increase right margins by 1.2 when need, to avoid highlight area been drawn 
out of the frame.
  Various little changes.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26861?vs=74194=74297

BRANCH
  pos2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26847: Hide irrevelevant default button, code clean and future proofing

[Rik Mills]

rikmills added a comment.


  Fails to build:
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console
  
  00:42:51 /workspace/build/src/usermanager.cpp: In constructor 
‘UserManager::UserManager(QWidget*, const QVariantList&)’:
  00:42:51 /workspace/build/src/usermanager.cpp:68:70: error: no matching 
function for call to ‘UserManager::connect(AccountInfo*&, void 
(AccountInfo::*)(bool), UserManager*, )’
  00:42:51  connect(m_widget, ::changed, this, 
::changed);
  00:42:51  
 ^

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26847

To: meven, ngraham, #plasma
Cc: rikmills, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:77c170c8f7cb: Update from Plasma for ToolTipInstance.qml 
(authored by trmdi).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26760?vs=74260=74296

REVISION DETAIL
  https://phabricator.kde.org/D26760

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart