D29140: Fix POTD in lock screen (partly)

[Yunhe Guo]

guoyunhe updated this revision to Diff 81064.
guoyunhe added a comment.


  Fix APOD and Flicker provider cache

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29140?vs=81043&id=81064

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29140

AFFECTED FILES
  dataengines/potd/cachedprovider.cpp

To: guoyunhe, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Kai Uwe Broulik]

broulik added a comment.


  > what happens if we have more Weather Providers won't the dialog box be 
cluttered?
  
  I wonder how many we actually offer?
  Maybe the old way but with a more obvious label could work. Dunno...

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  I'm seeing a lot of this message in GDB when I switch from a different QStyle 
such as Fusion back to Breeze:
  
QBackingStore::endPaint() called with active painter; did you forget to 
destroy it or call QPainter::end() on it?
  
  I also see this sometimes:
  
QWidget::repaint: Recursive repaint detected

INLINE COMMENTS

> breezetoolsareamanager.cpp:127
> +auto geoUpdate = [=]() {
> +_helper->_invalidateCachedRects = true;
> +emit toolbarUpdated();

When I run GDB on `oxygen-demo5`, sometimes it tells me that `oxygen-demo5` 
crashes on this line. I'm not sure how to make it happen reliably, but it 
usually involves changing QStyles with the Style combobox or color schemes with 
the Color Scheme combobox.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D29144: [applets/weather] Improve UX for selecting a weather station

[Shawn Starr]

spstarr added a comment.


  What happens if we have more Weather Providers won't the dialog box be 
cluttered?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: spstarr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29110: [applet] Port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:fbd32235c6ac: [applet] Port to 
Kirigami.PlaceholderMessage (authored by ngraham).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29110?vs=80938&id=81059

REVISION DETAIL
  https://phabricator.kde.org/D29110

AFFECTED FILES
  CMakeLists.txt
  plasma/package/contents/ui/main.qml

To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29110: [applet] Port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R845 Plasma Vault

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29110

To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29110: [applet] Port to Kirigami.PlaceholderMessage

[Ivan Čukić]

ivan accepted this revision.
ivan added a comment.
This revision is now accepted and ready to land.


  Fair enough.

REPOSITORY
  R845 Plasma Vault

BRANCH
  port-to-PlaceholderMessage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29110

To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29139: Remove .clang-format

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:50bde7c5ba33: Remove .clang-format (authored by ndavis).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29139?vs=81042&id=81058

REVISION DETAIL
  https://phabricator.kde.org/D29139

AFFECTED FILES
  .clang-format

To: ndavis, ivan, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29110: [applet] Port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham added a comment.


  I know what you mean, but Kirigami is already a dependency of Plasma itself, 
which a user of Plasma Vaults presumably already has installed. :)
  
  When I created the ExpandableListItem, I put it in plasma-framework, but I 
almost put it in Kirigami, and for Plasma 6, there's talk of deprecating 
PlasmaComponents and porting everything to use Kirigami components.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29110

To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  No time left over for Plasma currently,  sorry,

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Ivan Čukić]

ivan added a comment.


  And I'l just be using my keyboard shortcut ;)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Niccolò Venerandi]

niccolove added a comment.


  Size should be an even number
  
  - For sizes from 36 to 40, I'm OK with it
  - At 42 and 44 the icons in the task manager become too big for the panel; 
their size should be reduced to same as the launcher button, then it's fine
  - At 46 and over it's fine

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29130: [Applet] Show in system tray iff at least one vault is open

[Nathaniel Graham]

ngraham added a comment.


  (If this patch lands, I'll set it to "Always visible" because I use my vault 
a lot)

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29143: [applets/mediacontroller] Make the right margin the same as the left margin

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:082aaaf7b56e: [applets/mediacontroller] Make the right 
margin the same as the left margin (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29143?vs=81047&id=81050

REVISION DETAIL
  https://phabricator.kde.org/D29143

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: ngraham, cblack, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Nathaniel Graham]

ngraham updated this revision to Diff 81049.
ngraham marked 2 inline comments as done.
ngraham added a comment.


  Address review comments

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29144?vs=81048&id=81049

BRANCH
  better-weather-station-selection-ux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29144

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik, kossebau
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Ivan Čukić]

ivan added a comment.


  I'm not fond of this change, but I agree with Nate's comment about the 
possibility of setting 'always visible' for users that wish to keep the current 
behaviour, so I'm not going to give this a -1.
  
  I'd still like the current behaviour kept, maybe with a different icon to 
show when there is a vault that is currently open to remedy one of the reasons 
behind this patch.
  
  But, again, this is a personal preference and I'm not going to block the 
patch if everybody else decides it is a good idea.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Kai Uwe Broulik]

broulik added a comment.


  +1 that hidden flag thing always bugged me

INLINE COMMENTS

> WeatherStationPicker.qml:66
> +ColumnLayout {
> +Kirigami.FormData.label: i18n("Select weather providers:")
> +Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater

Perhaps just "Weather Providers:"?

> WeatherStationPicker.qml:67
> +Kirigami.FormData.label: i18n("Select weather providers:")
> +Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater
> +

How about `calendarPluginsRepeater.itemAt(0)`

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29144: [applets/weather] Improve UX for selecting a weather station

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This patch improves the UX of selecting a weather station by re-implementing 
it a column
  o checkboxes that are visible by default at the top of the window, so that 
selecting a
  weather station is follows the local top-to-bottom flow of the page.
  
  When no weather stations are selected (as it is by default), everything else 
in the
  window is disabled so it's completely obvious what you need to do to proceed.

TEST PLAN
  F8256457: vokoscreenNG-2020-04-23_14-56-01.webm 


REPOSITORY
  R114 Plasma Addons

BRANCH
  better-weather-station-selection-ux (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29144

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29110: [applet] Port to Kirigami.PlaceholderMessage

[Ivan Čukić]

ivan added a comment.


  Not sure I like pulling in Kirigami just for this. Are there other places 
where Kirigami could improve the Vaults applet?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29110

To: ngraham, #vdg, #plasma, ivan, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29143: [applets/mediacontroller] Make the right margin the same as the left margin

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: cblack, VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Now the song text can't almost touch the right edge.

TEST PLAN
  F8256425: Screenshot_20200423_143811.png 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  consistent-right-margin-in-media-player-applet (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29143

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml

To: ngraham, cblack, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29142: Add footer support to systray

[Niccolò Venerandi]

niccolove created this revision.
niccolove added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29142

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml

To: niccolove, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0a7b99bb6ae1: Added plasmoidHeading to clipboard and 
ported to Page (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29137?vs=81038&id=81044

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yeah, my diff put everything in one new `FullRepresentation` file.
  
  This is fine though. Totally works. Shipit!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  clipboard_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Fix POTD in lock screen (partly)

[Yunhe Guo]

guoyunhe created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
guoyunhe requested review of this revision.

REVISION SUMMARY
  POTD was cached in `~/.cache/`. But lock screen seems not a process of 
current user, so it won't find the cache in user's home dir. So I changed cache 
location to `/tmp` and it starts to work. Note: it only works when your lock 
screen use the same POTD provider as your desktop wallpaper.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29140

AFFECTED FILES
  dataengines/potd/cachedprovider.cpp

To: guoyunhe
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham added a comment.


  Anyway color-wise, here's an example of using a darker tools area color to 
improve the at-a-glance detectability of the active window:
  
  F8256343: vokoscreenNG-2020-04-23_13-26-00.webm 

  
  Thoughts?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29139: Remove .clang-format

[Noah Davis]

ndavis created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  It was an ignored file that was committed to the repo at some point.
  Because it's automatically generated and replaces the version commited to the 
repo when the project is built, it keeps causing kdesrc-build to report build 
failures for this project.

REPOSITORY
  R161 KActivity Manager Service

BRANCH
  clangformat (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29139

AFFECTED FILES
  .clang-format

To: ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81039.
ngraham added a comment.


  Hopefully fix it

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=81027&id=81039

BRANCH
  tools-area-color-changes-v2

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Nathaniel Graham]

ngraham added a comment.


  Thanks! Implementation-wise, I would have re-arranged things a bit to have 
only one header for the `PC3.Page`, with the contents changing depending on the 
page in the stack, rather than your approach of giving each page in the stack 
its own header, but that works fine too and it's perfectly valid so I'll accept 
it.
  
  Everything works great. Just one thing: I feel like we need a 
`units.smallSpacing` bottom margin underneath the headers for both pages.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Niccolò Venerandi]

niccolove updated this revision to Diff 81038.
niccolove added a comment.


  Added margin

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29137?vs=81037&id=81038

BRANCH
  clipboard_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Niccolò Venerandi]

niccolove added a comment.


  In D29137#655936 , @ngraham wrote:
  
  > Thanks! Implementation-wise, I would have re-arranged things a bit to have 
only one header for the `PC3.Page`, with the contents changing depending on the 
page in the stack, rather than your approach of giving each page in the stack 
its own header, but that works fine too and it's perfectly valid so I'll accept 
it.
  
  
  That was my first though, but the headings often use variables defined in 
their files which means that I should have brought everything to be one file or 
deal with passing variables though files. This felt cleaner and I guess it 
could scale better to new types of pages.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  No wait, that would be half a gigabyte of stuff. Maybe not the best idea to 
zip it up.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  In D28317#655922 , @ngraham wrote:
  
  > I mean, how to fix it with `arc`. :)
  
  
  I don't know what the branch looks like on your end. Maybe just zip up the 
whole repo and send it to me?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konrad Materka]

kmaterka added a comment.


  IMO it is the best **not** to add new status in System Tray - it is already 
quite confusing with "Disabled" state, the 3 other (Always hidden, Shown when 
relevant and Always shown) are OK and self-explanatory.
  "Shown when relevant" might be tricky and we will never please everyone. As 
stated in previous comment, this is tricky.
  
  Currently the decision is in the developer's hand only. There can be a 
configuration option, but too many options is also confusing. For configuration 
option, there additional questions: how to describe it with simple label? will 
users understand the purpose? what if applet is standalone (not in systemtray)? 
will user ever use it? is it easily discoverable? etc. If someone doesn't like 
default behavior it is always possible to force Shown/Hidden state. After all, 
it is not that users delete all vaults and creates new one on everyday basis.
  
  Personally I like the idea to hide Vaults icon when no vault is opened. I 
have one configured, but I use it very rarely, so for **me** it is better :) 
From the other side, Bluetooth and Network icons are visible not only when 
something is connected but also when connection is possible 
(Bluetooth/networking  is enabled). So maybe it would be more consistent if we 
leave it as it is now, wouldn't it? For someone who is using vaults often 
hiding Vaults icon might be really annoying. I don't know what's the best...
  
  BTW. For reference, MS Windows tries to hide as much as possible. But they 
are trying to kill system tray, so sometimes it is taken to the extreme and 
annoying.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> vaultsmodel.h:36
>  Q_PROPERTY(bool hasError READ hasError NOTIFY hasErrorChanged)
> +Q_PROPERTY(bool hasOpen READ hasOpen NOTIFY hasOpenChanged)
>  Q_PROPERTY(int count READ rowCount NOTIFY rowCountChanged)

I think this should be `openCount` to match `count`.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Niccolò Venerandi]

niccolove updated this revision to Diff 81037.
niccolove added a comment.


  Rebase and enabled

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29137?vs=81036&id=81037

BRANCH
  clipboard_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham added a comment.


  I mean, how to fix it with `arc`. :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in ClipboardPage.qml:81
> Can this be `enabled:` rather than `visible:`? That's what I did in D29132 
>  and I think it's nicer and more 
> consistent with the mockups.

never mind, wrong patch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29109

To: ngraham, #vdg, #plasma, broulik, niccolove, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ClipboardPage.qml:91
> +anchors.fill: parent
> +visible: !emptyHint.visible
>  

Can this be `enabled:` rather than `visible:`? That's what I did in D29132 
 and I think it's nicer and more consistent 
with the mockups.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ClipboardPage.qml:81
>  Layout.fillWidth: true
> -visible: !emptyHint.visible
> +visible: clipboardMenu.model.count > 0
>  

Can this be `enabled:` rather than `visible:`? That's what I did in D29132 
 and I think it's nicer and more consistent 
with the mockups.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29109

To: ngraham, #vdg, #plasma, broulik, niccolove, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  The event filter in `breezetoolsareamanager.cpp` already exists in the tools 
area patch and the other changes are incompatible with the current version of 
the tools area patch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Niccolò Venerandi]

niccolove added a comment.


  Heh, I just noticed :P

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Nathaniel Graham]

ngraham added a comment.


  This needs a rebase to apply against the clipboard patch I just landed

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29137

To: niccolove, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29137: Added plasmoidHeading to clipboard and ported to Page

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  clipboard_page_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29137

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/clipboard.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham added a comment.


  Definitely not sure. If you have an idea of what went wrong or how to fix it, 
I'm all ears.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  Never mind, I was wrong, I see it in arcpatch-D27669. However, just to see 
what would happen, I made my arcpatch-D27669 branch the upstream of 
arcpatch-D28317 and it said that arcpatch-D28317 was behind a commit. Are you 
sure you've rebased against the tools area patch correctly?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D29109: Port Clipboard and Notifications applets to Kirigami.PlaceholderMessage

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:f7687b01cade: Port Clipboard and Notifications applets to 
Kirigami.PlaceholderMessage (authored by ngraham).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29109?vs=80937&id=81034#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29109?vs=80937&id=81034

REVISION DETAIL
  https://phabricator.kde.org/D29109

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/Menu.qml
  applets/notifications/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, broulik, niccolove, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis added a comment.


  I gave it some thought and I would be reluctant to introduce one more fuzzy 
(as in ambiguous) state.
  
  More specifically, right now, we have four states: "Shown when relevant", 
"Always shown", "Always hidden", and "Disabled". Without having gone through 
the source code, I can guess what the latter three mean, but "Shown when 
relevant" is context-specific (and the reason this patch came to be). If we 
introduce another state, let's call it "Show when configured", we will just 
exacerbate the problem, because it is not immediately clear what it means. For 
instance, for the Bluetooth applet, does "configured" mean that I powered my 
adapter or maybe that I configured at least one device? As a user, both of them 
make sense to me, but again they are context-specific. Therefore, if we want to 
move in this direction of pleasing everyone, I suggest we delegate this 
responsibility to the applet itself where the context is clear. In this way, 
the Bluetooth applet could define relevance (in "Shown when relevant") as: 
"Show when adapter is powered", "Show when devices are configured", or "Show 
when devices are connected". This could be done in the applet's config dialog 
without breaking the current "interface" (i.e., the four current states).
  
  If we want to keep things simple, I suggest we make the status quo consistent 
by defining relevance as a dynamic event that requires the user's attention. In 
the context of the Bluetooth applet, that would mean a device was connected. In 
the context of vaults, that would mean I opened one of them. Having configured 
a Bluetooth device or having created a vault is pretty much a steady state for 
most users (as in you only do it once); I don't think anyone goes around 
setting up things over and over again. In that case, we are pretty much in the 
"Always shown" domain.
  
  **tl;dr**:
  
  - Do you want to keep things simple? Maintain the status quo but iron out any 
inconsistencies.
  - Do you want to accommodate all needs? Delegate to the applets where the 
context is clear.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham added a comment.


  `kstyle/breezetoolsareamanager.cpp` is added in D27669 
.
  
  Maybe the problem is that D27669  has 
three commits in it, so arc gets confused?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  It's the change to `kstyle/breezetoolsareamanager.cpp` that causes this patch 
to fail to apply. That file doesn't exist anywhere.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham added a comment.


  How are you guys feeling about the colors here? The Tools Area color 
currently used in this patch and the mockups demos well, but I'm starting to 
wonder if we're regressing usability in the process. I'm starting to think that 
the color isn't dark enough to adequately signal that a window is active or 
inactive. Current Breeze is very obvious about this, but the new color is quite 
subtle, especially for windows with only a titlebar. It's more obvious in 
windows with a large Tools Area like Okular or Gwenview since there's a large 
area of color change and all the text and icons lighten too, but I feel like 
for windows with less stuff in the Tools Area (e.g. dialogs and 3rd-party apps) 
it takes me longer to figure out at a glance which window is active than it did 
before. Do other folks find the same thing? I wonder if we might want to 
experiment with making the Titlebar/Tools Area gray color a touch darker. 
Thoughts?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81027.
ngraham added a comment.


  Oh lord

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=81026&id=81027

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/breezetoolsareamanager.cpp

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81026.
ngraham added a comment.


  Arc, you are the worst

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=81025&id=81026

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81024.
ngraham added a comment.


  Remove merge conflict

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=81023&id=81024

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81025.
ngraham added a comment.


  Change the patch base, again

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=81024&id=81025

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/breezetoolsareamanager.cpp

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81023.
ngraham added a comment.


  Rebase against tools area patch

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=81022&id=81023

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/breezetoolsareamanager.cpp

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81022.
ngraham added a comment.


  Remove leftover CMake bit

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=81021&id=81022

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  colors/CMakeLists.txt
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h
  kstyle/breezestyle.cpp
  kstyle/breezestyle.h
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h
  kstyle/config/breezestyleconfig.cpp
  kstyle/config/ui/breezestyleconfig.ui

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham updated this revision to Diff 81021.
ngraham added a comment.


  Rebase on e9d658fcb1f9751a39180e79ccc66aff3a18599d

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28317?vs=80762&id=81021

BRANCH
  tools-area-color-changes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28317

AFFECTED FILES
  colors/Breeze.colors
  colors/BreezeLight.colors
  kdecoration/breezebutton.cpp
  kdecoration/breezesettingsdata.kcfg
  kstyle/breezehelper.cpp
  kstyle/breezestyle.cpp
  kstyle/breezetoolsareamanager.cpp
  kstyle/breezetoolsareamanager.h

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  the cmake file in `colors/` also needs to be updated for the patch to build.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Nathaniel Graham]

ngraham added a comment.


  Ugh

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28317: Adjust default color scheme and titlebar appearance for Tools Area

[Noah Davis]

ndavis added a comment.


  This time when I try to apply the patch, it fails. I have the most up to date 
version of D27669  too.
  
╭ …/src/kde/workspace/breeze   master  
╰ arc patch D28317
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D28317.
Branch name arcpatch-D27669 already exists; trying a new name.
Created and checked out branch arcpatch-D27669_1.
Checking patch kstyle/config/ui/breezestyleconfig.ui...
Checking patch kstyle/config/breezestyleconfig.cpp...
Checking patch kstyle/breezetoolsareamanager.h...
Checking patch kstyle/breezetoolsareamanager.cpp...
Checking patch kstyle/breezestyle.h...
Checking patch kstyle/breezestyle.cpp...
Checking patch kstyle/breezehelper.h...
Checking patch kstyle/breezehelper.cpp...
Checking patch kstyle/breeze.kcfg...
Checking patch kstyle/CMakeLists.txt...
Applied patch kstyle/config/ui/breezestyleconfig.ui cleanly.
Applied patch kstyle/config/breezestyleconfig.cpp cleanly.
Applied patch kstyle/breezetoolsareamanager.h cleanly.
Applied patch kstyle/breezetoolsareamanager.cpp cleanly.
Applied patch kstyle/breezestyle.h cleanly.
Applied patch kstyle/breezestyle.cpp cleanly.
Applied patch kstyle/breezehelper.h cleanly.
Applied patch kstyle/breezehelper.cpp cleanly.
Applied patch kstyle/breeze.kcfg cleanly.
Applied patch kstyle/CMakeLists.txt cleanly.
 COMMITTED  Successfully committed patch.


This diff is against commit 33be688c002cb4829fee475f0199cbffbb8dc265, 
but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (944d47cd098ff8abf85f08823cbe7d033eee082d)
[Y/n] y

Checking patch kstyle/breezetoolsareamanager.cpp...
error: while searching for:
this, [this]() {
emit toolbarUpdated();
});
<<< HEAD
toolbar->installEventFilter(this);
===
>>> c2487fc1... [kstyle] Tools area
}
connect(widget, &QObject::destroyed,
this, [this, widget]() {

error: patch failed: kstyle/breezetoolsareamanager.cpp:187
error: while searching for:

void ToolsAreaManager::unregisterWidget(QWidget *widget)
{
<<< HEAD
if (qobject_cast(widget)) {
widget->setContentsMargins(0,0,0,0);
widget->removeEventFilter(this);
}
===
if (qobject_cast(widget)) 
widget->setContentsMargins(0,0,0,0);
>>> c2487fc1... [kstyle] Tools area
_registeredWidgets.remove(widget);
QList toRemove;
for (auto window : animationMap.keys()) {

error: patch failed: kstyle/breezetoolsareamanager.cpp:213
Checking patch kdecoration/breezesettingsdata.kcfg...
Checking patch kdecoration/breezebutton.cpp...
Checking patch colors/BreezeLight.colors...
Checking patch colors/Breeze.colors...
Applying patch kstyle/breezetoolsareamanager.cpp with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
Applied patch kdecoration/breezesettingsdata.kcfg cleanly.
Applied patch kdecoration/breezebutton.cpp cleanly.
Applied patch colors/BreezeLight.colors cleanly.
Applied patch colors/Breeze.colors cleanly.

 Patch Failed!
Usage Exception: Unable to apply patch!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D28317

To: ngraham, #vdg, #breeze
Cc: ndavis, niccolove, The-Feren-OS-Dev, manueljlin, davidre, broulik, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Marco Martin]

mart updated this revision to Diff 81020.
mart added a comment.


  - use the new face library

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28487?vs=80403&id=81020

BRANCH
  mart/mewSystemMonitor

REVISION DETAIL
  https://phabricator.kde.org/D28487

AFFECTED FILES
  applets/systemmonitor/CMakeLists.txt
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/coreusage/metadata.desktop
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/cpu/contents/config/config.qml
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskactivity/contents/config/config.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/diskusage/contents/config/config.qml
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/memory/contents/config/config.qml
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/Messages.sh
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml
  applets/systemmonitor/net/contents/ui/netConfig.qml
  applets/systemmonitor/net/metadata.desktop
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  applets/systemmonitor/systemmonitor/Messages.sh
  applets/systemmonitor/systemmonitor/faces/CMakeLists.txt
  applets/systemmonitor/systemmonitor/faces/barchart/contents/config/main.xml
  applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/BarChart.qml
  
applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/barchart/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/barchart/metadata.desktop
  applets/systemmonitor/systemmonitor/faces/linechart/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/linechart/contents/ui/LineChart.qml
  applets/systemmonitor/systemmonitor/faces/linechart/metadata.desktop
  applets/systemmonitor/systemmonitor/faces/piechart/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/piechart/contents/ui/PieChart.qml
  applets/systemmonitor/systemmonitor/faces/piechart/metadata.desktop
  applets/systemmonitor/systemmonitor/faces/table/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/faces/table/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/table/contents/ui/Config.qml
  
applets/systemmonitor/systemmonitor/faces/table/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/table/metadata.desktop
  
applets/systemmonitor/systemmonitor/faces/textonly/contents/ui/CompactRepresentation.qml
  
applets/systemmonitor/systemmonitor/faces/textonly/contents/ui/FullRepresentation.qml
  applets/systemmonitor/systemmonitor/faces/textonly/metadata.desktop
  applets/systemmonitor/systemmonitor/package/contents/config/config.qml
  applets/systemmonitor/systemmonitor/package/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/main.qml
  applets/systemmon

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 81019.
mart added a comment.


  - move all face-related stuff in own library
  - use the new face library

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=80982&id=81019

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6d12d2d62607: KCM Notifications : Manage app-specific 
notifications with KCconfigXT's magic (authored by crossi).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=81014&id=81017

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29135: PageRouter: find parents of items better

[Carson Black]

cblack updated this revision to Diff 81018.
cblack added a comment.


  Remove stray qDebug

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29135?vs=81015&id=81018

BRANCH
  cblack/better-router-parent-finding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29135

AFFECTED FILES
  src/pagerouter.cpp

To: cblack, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 81016.
davidre added a comment.


  - Don't drop installing scheme files

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80767&id=81016

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma, ngraham
Cc: GB_2, broulik, davidedmundson, nicolasfella, ngraham, iasensio, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29135: PageRouter: find parents of items better

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  The PageRouterAttached is now able to locate a parent PageRouter by 
travelling up the visual parent hierarchy as well as the regular QObject parent 
hierarchy.

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/better-router-parent-finding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29135

AFFECTED FILES
  src/pagerouter.cpp

To: cblack, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 81014.
crossi added a comment.


  clear the nitpicks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=81009&id=81014

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml
  kcms/notifications/sourcesmodel.h

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29058: Set a component display name for the action collection of ksmserver

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9056449edc89: Set a component display name for the action 
collection of ksmserver (authored by davidre).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29058?vs=80778&id=81013

REVISION DETAIL
  https://phabricator.kde.org/D29058

AFFECTED FILES
  ksmserver/server.cpp

To: davidre, ngraham, #plasma, #vdg, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29052: Set component display name for touchboard and keyboard kcm action collections

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e64a3cb2af23: Set component display name for touchboard 
and keyboard kcm action collections (authored by davidre).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29052?vs=80770&id=81012

REVISION DETAIL
  https://phabricator.kde.org/D29052

AFFECTED FILES
  kcms/keyboard/bindings.cpp
  kcms/touchpad/kded/kdedactions.cpp

To: davidre, ngraham, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Clean up those minor comments and then ship it, thanks!

INLINE COMMENTS

> kcm.cpp:256
> +}
> +return m_behaviorSettingsList[index.row()];
> +}

`.value(index.row())`

> kcm.cpp:269
> +QString groupName;
> +QModelIndex index;
> +for (int i = 0; i < m_sourcesModel->rowCount(QModelIndex()); ++i) {

Why define outside?

> kcm.cpp:270
> +QModelIndex index;
> +for (int i = 0; i < m_sourcesModel->rowCount(QModelIndex()); ++i) {
> +index = m_sourcesModel->index(i, 0);

`QModelIndex()` should be the default argument for `rowCount()`

> ApplicationConfiguration.qml:46
>  
> -function behavior() {
> -if (configColumn.desktopEntry) {
> -return 
> kcm.settings.applicationBehavior(configColumn.desktopEntry);
> -} else if (configColumn.notifyRcName) {
> -return kcm.settings.serviceBehavior(configColumn.notifyRcName);
> -}
> -return -1;
> -}
> -
> -function setBehavior(flag, enable) {
> -var newBehavior = behavior();
> -if (enable) {
> -newBehavior |= flag;
> -} else {
> -newBehavior &= ~flag;
> -}
> -
> -if (configColumn.desktopEntry) {
> -return 
> kcm.settings.setApplicationBehavior(configColumn.desktopEntry, newBehavior);
> -} else if (configColumn.notifyRcName) {
> -return 
> kcm.settings.setServiceBehavior(configColumn.notifyRcName, newBehavior);
> -}
> -}
> +readonly property bool notAppOther: configColumn.desktopEntry !== 
> configColumn.otherAppsId
>  

Can we swap that around to be "isOtherApp"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27188

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi updated this revision to Diff 81009.
crossi added a comment.
This revision is now accepted and ready to land.


  Consider Kai's comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27188?vs=80894&id=81009

REVISION DETAIL
  https://phabricator.kde.org/D27188

AFFECTED FILES
  kcms/notifications/kcm.cpp
  kcms/notifications/kcm.h
  kcms/notifications/package/contents/ui/ApplicationConfiguration.qml
  kcms/notifications/package/contents/ui/SourcesPage.qml
  kcms/notifications/package/contents/ui/main.qml

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:5b0b2a74bc98: [applet] Show toolbar unless Bluetooth 
hardware is absent (authored by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29132?vs=80999&id=81008

REVISION DETAIL
  https://phabricator.kde.org/D29132

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, niccolove, manueljlin
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good and it works for me, tested with Chromium.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

To: apol, jgrulich
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Nathaniel Graham]

ngraham added a comment.


  Yeah. Thinking about it more, your proposal makes some sense because people 
like you can currently not get what you want at all, while if we integrate this 
change, people like me can just change the visibility setting to "Always 
visible". So I'm leaning in the direction of approving.
  
  However if we really want to overthink things, we could go deeper and add 
more visibility states to satisfy everyone. We could have the following five 
states for visibility:
  
  1. Disabled
  2. Always hidden in pop-up
  3. Shown when there are any devices/services (as appropriate for the applet) 
configured
  4. Shown when in use
  5. Always shown
  
  #3 would only be visible for applets which can have devices/services/etc 
added and configured: Bluetooth, KDE, Printers, Vaults Connect
  
  Thoughts?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

[Manuel Jesús de la Fuente]

manueljlin accepted this revision.
manueljlin added a comment.
This revision is now accepted and ready to land.


  Much better

REPOSITORY
  R97 Bluedevil

BRANCH
  almost-always-show-applet-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29132

To: ngraham, #vdg, niccolove, manueljlin
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27513: Kill Runner: Remove duplicate function calls and refactor

[Alexander Lohnau]

alex updated this revision to Diff 81006.
alex added a comment.


  Fix small issue from splitting up patch

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27513?vs=76149&id=81006

BRANCH
  arcpatch-D27513

REVISION DETAIL
  https://phabricator.kde.org/D27513

AFFECTED FILES
  runners/kill/CMakeLists.txt
  runners/kill/killrunner.cpp
  runners/kill/killrunner.h
  runners/kill/killrunner_config.cpp
  runners/kill/killrunner_config.h

To: alex, davidedmundson, ngraham, broulik, meven, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28988: Port hotplug from KRun::runCommand to CommandLauncherJob.

[David Faure]

dfaure closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28988

To: dfaure, davidedmundson, sitter, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29064: Support module commandline paramenter

[Kai Uwe Broulik]

broulik added a comment.


  Note you can pass multiple arguments to `kcmshell5` to open a dedicated save 
window with random KCMs inside, e.g. done by battery monitor:
  
kcmshell5 powerdevilprofilesconfig powerdevilactivitiesconfig 
powerdevilglobalconfig
  
  Not sure how this could be translated 1-on-1 :/
  Though power management is its own group, so maybe we could port that over to 
passing the parent category in or something. But reimplementing that in 
systemsettings looks like a rabbit hole we don't want to do down into.

REPOSITORY
  R124 System Settings

BRANCH
  phab/startupModule

REVISION DETAIL
  https://phabricator.kde.org/D29064

To: mart, #plasma, ngraham
Cc: broulik, bport, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis added a comment.


  Accurate analysis. If I might add, as an infrequent user of Plasma Vaults, I 
am stuck between an (almost) always visible applet (whether I select "Always 
shown" or "Shown when relevant") and an always hidden applet. A "currently 
active" relevance would cater for both frequent and infrequent users, with the 
drawback that frequent users would have to select "Always shown". I'm not 
particularly ecstatic about the Bluetooth applet taking up unnecessary space 
95% of the time, either.
  
  Imho, in KDE's configurable spirit, I would prefer it if systray relevance 
was configurable, but to my knowledge no plasmoid provides such an option; the 
creator is always in charge of making this decision with potential inconsistent 
results, as mentioned.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29064: Support module commandline paramenter

[Nathaniel Graham]

ngraham added a comment.


  In D29064#655349 , @mart wrote:
  
  > the *really* annoying thing is that every single kcm has a line like
  >
  >   Exec=kcmshell5 kcm_lookandfeel
  >   
  >
  > in its desktop file. Which would call something along the lines of what we 
did for kinfocenter, to still have kcmshell5 as a symlink, but in this case i 
don't think it would cover all cases?
  >
  > Without kcmshell, that won't work as currently implemented, and it would 
need to navigate you to the KScreen KCM in the same systemsettings instance.
  
  
  Yeah I guess a compatibility symlink that opens systemsettings5 will be 
necessary.
  
  >> Also a new way to get the information from `kcmshell5 --list` would be 
nice.
  > 
  > systemsettings5 --list works ;)
  
  Excellent!

REPOSITORY
  R124 System Settings

BRANCH
  phab/startupModule

REVISION DETAIL
  https://phabricator.kde.org/D29064

To: mart, #plasma, ngraham
Cc: bport, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

[Kai Uwe Broulik]

broulik added a comment.


  +1

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D29132

To: ngraham, #vdg, niccolove, manueljlin
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29116: [applets/batterymonitor] Put the toolbar in the header area

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:eca2ea2c859d: [applets/batterymonitor] Put the toolbar in 
the header area (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29116?vs=80951&id=81002

REVISION DETAIL
  https://phabricator.kde.org/D29116

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

To: ngraham, #vdg, #plasma, broulik, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29133: [Icon Applet] Port jump list actions to KServiceAction

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - Get browser actions on browser icon still
  - Launching them works and gives proper startup feedback

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29133

AFFECTED FILES
  applets/icon/iconapplet.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Nathaniel Graham]

ngraham added a reviewer: ivan.
ngraham added a comment.


  With this change, a person who creates a Vault they will be regularly using 
and wants the system tray icon to be always visible now has to go out of their 
way to use the "always visible" setting in the system tray settings; the "Shown 
when relevant" setting will make the tray icon hidden when they want to go and 
access the vault.
  
  I guess it depends on whether your definition of "relevant" means "the user 
has created at least one vault" or "the user is actively using a Vault right 
now".
  
  The latter definition is more consistent with the visibility status of the 
Printers applet, which shows itself only when a printer is in use, not when a 
printer is simply connected. However it would be inconsistent with the 
Bluetooth applet, which currently behaves in the same way as the Vaults applet 
does (the tray icon is visible when Bluetooth is on, not only when a device is 
connected). And I worry that it will be a bit annoying for people who regularly 
use Vaults, as it means they will have to access the item in the System Tray's 
expanded pop-up or change the default settings. I use Vaults quite frequently; 
if this change lands, I would change the default visibility setting to "Always 
visible"
  
  Thoughts from #VDG  and #consistency 
 people?

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D29130

To: ksmanis, #plasma, #vdg, ivan
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29132: [applet] Show toolbar unless Bluetooth hardware is absent

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, niccolove, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  While testing other bluedevil patches, I was finding that the toolbar showing 
and hiding
  itself when bluetooth is turned on and off was feeling a bit weird to me. 
This patch
  makes the toolbar always visible as long as a Bluetooth adapter is present; 
effectively
  this means that the toolbar no longer disappears when bluetooth is disabled. 
Instead,
  the toolbar remains visible but its controls are all disabled.
  
  If nobody likes this, I can drop it, but wanted to present the idea. If we 
like this,
  I would propose doing the same for other applets with toolbars so that they 
aren't
  appearing and disappearing so much.

TEST PLAN
  F8255623: vokoscreenNG-2020-04-23_07-41-35.webm 


REPOSITORY
  R97 Bluedevil

BRANCH
  almost-always-show-applet-toolbar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29132

AFFECTED FILES
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29111: [applet] Port to Kirigami.PlaceholderMessage

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:b75f36807ab4: [applet] Port to Kirigami.PlaceholderMessage 
(authored by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29111?vs=80939&id=80997

REVISION DETAIL
  https://phabricator.kde.org/D29111

AFFECTED FILES
  CMakeLists.txt
  src/applet/package/contents/ui/FullRepresentation.qml

To: ngraham, #vdg, #plasma, drosca, niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29117: [applet] Put the toolbar in the header area

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:0d732531346f: [applet] Put the toolbar in the header area 
(authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29117?vs=80952&id=80995

REVISION DETAIL
  https://phabricator.kde.org/D29117

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: ngraham, #vdg, #plasma, jgrulich, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29130: [Applet] Show in system tray iff at least one vault is open

[Konstantinos Smanis]

ksmanis created this revision.
ksmanis added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ksmanis requested review of this revision.

REVISION SUMMARY
  Currently, the "Shown when relevant" visibility option in the system
  tray shows an icon iff at least one vault exists, regardless of open
  status (i.e., if it is open or closed). Change this behavior to show an
  icon iff at least one *open* vault exists, allowing the user to be more
  mindful of potentially sensitive information being accessible.
  
  The previous behavior can be emulated by selecting the "Always shown"
  visibility option, assuming that the user does not create and delete
  Plasma Vaults for recreation.

TEST PLAN
  Compiles and runs as expected both on master (commit 4d11dcf 
) and
  Plasma/5.18 (commit 1f546c1 
).

REPOSITORY
  R845 Plasma Vault

BRANCH
  applet-systray-relevance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29130

AFFECTED FILES
  plasma/package/contents/ui/main.qml
  plasma/vaultsmodel.cpp
  plasma/vaultsmodel.h
  plasma/vaultsmodel_p.h

To: ksmanis, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c55ffdca923a: BoorkmarksRunner: Set QIcon instead of 
Favicon pointer in BookmarkMatch (authored by alex).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28439?vs=78906&id=80992

REVISION DETAIL
  https://phabricator.kde.org/D28439

AFFECTED FILES
  runners/bookmarks/bookmarkmatch.cpp
  runners/bookmarks/bookmarkmatch.h
  runners/bookmarks/browsers/chrome.cpp
  runners/bookmarks/browsers/firefox.cpp
  runners/bookmarks/browsers/kdebrowser.cpp
  runners/bookmarks/browsers/opera.cpp

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27188: KCM Notifications : Manage app-specific notifications with KCconfigXT's magic

[Cyril Rossi]

crossi planned changes to this revision.
crossi added inline comments.

INLINE COMMENTS

> broulik wrote in ApplicationConfiguration.qml:45
> I've seen duplicate apps in this list, e.g. snap vs properly installed, so I 
> don't think you can rely on this.

I guess I could use `rootIndex` instead, and it will solve the issue you 
mention below as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27188

To: crossi, #plasma, ervin, broulik, bport, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28664: [OverlaySheet] Add bottom margin when sheet height is less than 3/4 of screen

[Marco Martin]

mart added a comment.


  in the end, just centered vertically the sheet in 812238afdcb7 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28664

To: cblack, #kirigami
Cc: mart, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson

D29117: [applet] Put the toolbar in the header area

[Manuel Jesús de la Fuente]

manueljlin accepted this revision as: manueljlin.
manueljlin added a comment.


  Looks good 👍 Should I accept as VDG or wait for @niccolove 's review?

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  put-toolbar-in-header-area (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29117

To: ngraham, #vdg, #plasma, jgrulich, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28439: BoorkmarksRunner: Set QIcon instead of Favicon pointer in BookmarkMatch

[Alexander Lohnau]

alex added a comment.


  Friendly Ping :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28439

To: alex, apol, broulik, davidedmundson
Cc: bruns, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28509: [libnotificationmanager] introduce the WatchedNotificationsModel

[Bhushan Shah]

bshah updated this revision to Diff 80990.
bshah edited the test plan for this revision.
bshah added a comment.


  - watch for notification expiry and closing

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28509?vs=80847&id=80990

BRANCH
  bshah/notification-watcher

REVISION DETAIL
  https://phabricator.kde.org/D28509

AFFECTED FILES
  libnotificationmanager/CMakeLists.txt
  libnotificationmanager/abstractnotificationsmodel.cpp
  libnotificationmanager/abstractnotificationsmodel.h
  libnotificationmanager/abstractnotificationsmodel_p.h
  libnotificationmanager/dbus/org.kde.notificationmanager.xml
  libnotificationmanager/declarative/notificationmanagerplugin.cpp
  libnotificationmanager/notification.cpp
  libnotificationmanager/notification.h
  libnotificationmanager/notification_p.h
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/server_p.cpp
  libnotificationmanager/server_p.h
  libnotificationmanager/watchednotificationsmodel.cpp
  libnotificationmanager/watchednotificationsmodel.h

To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[David Edmundson]

davidedmundson added a comment.


  Generally +1

INLINE COMMENTS

> waylandintegration.cpp:452
> +connect(m_registry, &KWayland::Client::Registry::screencastingAnnounced, 
> this, [this] (quint32 name, quint32 version) {
> +qDebug() << "screen!";
> +m_screencasting = m_registry->createScreencasting(name, version, 
> this);

leftover

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28884

To: apol
Cc: davidedmundson, jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

[Aleix Pol Gonzalez]

apol updated this revision to Diff 80985.
apol added a comment.


  Adopt kwayland changes, provide the right buffer size.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28884?vs=80797&id=80985

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28884

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindEpoxy.cmake
  cmake/modules/FindGBM.cmake
  cmake/modules/FindPipeWire.cmake
  data/CMakeLists.txt
  data/kde-no-pipewire.portal
  src/CMakeLists.txt
  src/desktopportal.cpp
  src/desktopportal.h
  src/remotedesktop.cpp
  src/remotedesktopdialog.cpp
  src/remotedesktopdialog.h
  src/screencast.cpp
  src/screencast.h
  src/screencaststream.cpp
  src/screencaststream.h
  src/screencastwidget.cpp
  src/screencastwidget.h
  src/screenchooserdialog.cpp
  src/screenchooserdialog.h
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol
Cc: jgrulich, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 80982.
mart added a comment.


  - add missing file

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=80401&id=80982

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/ConfigAppearance.qml
  sensors/ConfigSensors.qml
  sensors/FaceDetailsConfig.qml
  sensors/SensorFace.cpp
  sensors/SensorFaceController.cpp
  sensors/SensorFaceController.h
  sensors/SensorFaceController_p.h
  sensors/SensorFace_p.h
  sensors/SensorInfo_p.h
  sensors/UsedSensorsView.qml
  sensors/declarative/CMakeLists.txt
  sensors/declarative/SensorFace.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/qmldir
  sensors/resources.qrc

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> SensorFaceController.cpp:21
> +#include "SensorFaceController.h"
> +#include "SensorFaceController_p.h"
> +#include "SensorFace_p.h"

This file is missing.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29127: Account for top and bottom margin in default card height

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:a9c8cb612992: Account for top and bottom margin in 
default card height (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29127?vs=80975&id=80979

REVISION DETAIL
  https://phabricator.kde.org/D29127

AFFECTED FILES
  src/controls/Card.qml
  src/controls/templates/AbstractCard.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D29129: Remove implicitHeight from cards in main page

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R1014:40f6034f35c1: Remove implicitHeight from cards in main 
page (authored by ahiemstra).

REPOSITORY
  R1014 Kirigami Gallery

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29129?vs=80978&id=80980

REVISION DETAIL
  https://phabricator.kde.org/D29129

AFFECTED FILES
  src/data/contents/ui/MainPage.qml

To: ahiemstra, #kirigami, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, 
davidedmundson, mart