Re: Merge Service still in use?

2023-12-18 Thread Vlad Zahorodnii

On 12/18/23 19:25, Ben Cooksley wrote:

Just out of curiosity - why?


It broke down a while ago and, unfortunately, it covers only some of 
ours needs, not all. So it was not a big loss for us and we simply moved 
on with merging patches manually.


Cheers,
Vlad




Re: more betas / shorter windows?

2023-12-18 Thread Nate Graham
Yeah, it's long been a problem that bugs reported towards the end of a 
beta release were often fixed weeks ago, which wastes everyone's time. 
Shorter betas would also help our most effective volunteer QA people who 
close their bug reports once they're fixed by us (like Patrick Silva and 
some others) do so at a more rapid pace.


I'd support one-week betas, or if we think that's too aggressive and too 
much work for everyone, then two weeks.


Nate



On 12/18/23 10:42, Harald Sitter wrote:

With the second p6 beta sneaking up on us I've been pondering the beta
experience...

I can't help but think that the windows we've chosen were too long. At
least from a crash tracking POV most of the crash reports we get from
!neon are either of unreasonably low quality (because of improvements
made to drkonqi in the meantime), or already fixed.

I'd like to propose that we push out more betas with shorter windows
in the future.

2 weeks maybe? 1 perhaps even if distros can cope? Or maybe something fibonacci?

Food for thought.

HS


Re: more betas / shorter windows?

2023-12-18 Thread Harald Sitter
6.x onwards

On Mon, Dec 18, 2023 at 6:59 PM Nicolas Fella  wrote:
>
> On 12/18/23 18:42, Harald Sitter wrote:
> > With the second p6 beta sneaking up on us I've been pondering the beta
> > experience...
> >
> > I can't help but think that the windows we've chosen were too long. At
> > least from a crash tracking POV most of the crash reports we get from
> > !neon are either of unreasonably low quality (because of improvements
> > made to drkonqi in the meantime), or already fixed.
> >
> > I'd like to propose that we push out more betas with shorter windows
> > in the future.
> >
> > 2 weeks maybe? 1 perhaps even if distros can cope? Or maybe something 
> > fibonacci?
> >
> > Food for thought.
> >
> > HS
> By "in the future" you mean for the 6.0 release or the 6.x releases? In
> the past we only had one beta release for the 5.x releases, but I guess
> having more than one again could be up for debate


Re: more betas / shorter windows?

2023-12-18 Thread Nicolas Fella

On 12/18/23 18:42, Harald Sitter wrote:

With the second p6 beta sneaking up on us I've been pondering the beta
experience...

I can't help but think that the windows we've chosen were too long. At
least from a crash tracking POV most of the crash reports we get from
!neon are either of unreasonably low quality (because of improvements
made to drkonqi in the meantime), or already fixed.

I'd like to propose that we push out more betas with shorter windows
in the future.

2 weeks maybe? 1 perhaps even if distros can cope? Or maybe something fibonacci?

Food for thought.

HS

By "in the future" you mean for the 6.0 release or the 6.x releases? In
the past we only had one beta release for the 5.x releases, but I guess
having more than one again could be up for debate


more betas / shorter windows?

2023-12-18 Thread Harald Sitter
With the second p6 beta sneaking up on us I've been pondering the beta
experience...

I can't help but think that the windows we've chosen were too long. At
least from a crash tracking POV most of the crash reports we get from
!neon are either of unreasonably low quality (because of improvements
made to drkonqi in the meantime), or already fixed.

I'd like to propose that we push out more betas with shorter windows
in the future.

2 weeks maybe? 1 perhaps even if distros can cope? Or maybe something fibonacci?

Food for thought.

HS


Re: Merge Service still in use?

2023-12-18 Thread Ben Cooksley
On Tue, Dec 19, 2023 at 2:36 AM Vlad Zahorodnii 
wrote:

> On 12/16/23 03:41, Ben Cooksley wrote:
> > Hi all,
> >
> > I've just been reviewing services we're looking after and while doing
> > so have noticed that Marge Bot (invent.kde.org/merge-service
> > ) doesn't seem to have done
> > anything for 4 months.
> >
> > As the two projects with it enabled, is this something you're still
> > using as it doesn't look like it.
>
> Hi,
>
> We stopped using it in kwin.
>

Thanks for that update.

Just out of curiosity - why?


>
> Regards,
> Vlad
>
>
Cheers,
Ben


Monday meeting notes for 18/12/2023

2023-12-18 Thread Marco Martin
Joshua
Stuff that's already approved but still noteworthy:
Been talking about it last week, but finally did it! Kirigami now
says which style you're using which may help you with "platform plugin
not found" warnings.
https://invent.kde.org/frameworks/kirigami/-/merge_requests/1411
Handle the lockscreen fallback greeter failing, which should never
happen but now it works a little bit better.
https://invent.kde.org/plasma/kscreenlocker/-/merge_requests/193
This MR needs another look, because I modified it quite a bit:
Check if the QQC2 style exists before setting it in (Qt6) Plasma
Intregration: 
https://invent.kde.org/plasma/plasma-integration/-/merge_requests/126
Fallback styles work differently in Qt6, as in if it doesn't exist
then the engine will hard exit (that pesky "org.kde.breeze module not
found" error.) I filed https://bugreports.qt.io/browse/QTBUG-120194
for this. I suggest it should still be merged for 6.0, I don't know
when it'll get fixed upstream (or when I'll find time to fix it.)
There's also the question of it affecting everything before 6.6.2 or
something like that, so the code needs to stay until we bump the
required min Qt. I tried to section it off as much as possible, so it
can be easily removed later.

Also KWaylandIntegration was stripped of something it should've had, if
nicofee or

David Redondo (@davidre:kde.org) could take a look at
https://invent.kde.org/plasma/kwayland-integration/-/merge_requests/63
that would be nice :)


Niccolò
I spent some time refactoring the code that sizes the applets in the
panel after the change from @notmart to make all them fillWidth by
default; there were some edge cases which I think I fixed now.
I was also looking into panels having the keyboard focus line on
startup whenever they were empty, but I couldn't find the issue.
I added a button to make the dialogs floating (detached from the
panel); we had that already out of the box for floating panels, but
there was no way to trigger it for non-floating ones. However it's
technically a feature and it will require an exeption.
Plus some other uninteresting bugfixes :P
https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1901


Xaver
I'm spending most of my KDE time bugfixing, but I got a few nice
things still done and queuing up:
   * an implementation for tearing with atomic modesetting, so that
the "allow tearing" checkbox finally actually does something by
default: https://invent.kde.org/plasma/kwin/-/merge_requests/4800
   * an implementation for explicit sync. It's still very WIP but
it'll fix lots of issues with NVidia on Wayland:
https://invent.kde.org/plasma/kwin/-/merge_requests/4693
   * I wrote a blog post about the HDR stuff
   * I have some more color management and VRR improvements I plan to
work on, but a bunch of them probably have to wait for Plasma 6.1

Nico
I upgraded my Qt to the new 6.7 branch
Which was fun, because I ran into a handful of bugs, so I spent some
time reporting them
Other than that I did a push on
https://invent.kde.org/plasma/kscreen/-/merge_requests/126  Which has
a few dependent changes
And multiple ways how things could be done


Akseli
   * I worked on this MR over the weekend because it was bothering me,
I wanted to refactor that old code I had there.
https://invent.kde.org/plasma/breeze/-/merge_requests/386
   * Instead doing our own weird math, just use KColorUtil::mix to
make the colors fit.
   * This should make the colors more consistent across desktop,
since it follows the values other elements have.
   * It's a small step towards my goal of making outline and
separator colors consistent.
   * This consistency will also help in future if/when I start
working on customizable separator colors.
   * Which then in turn allows us make accessible high contrast themes. :)
   * Also looking into issues with kickoff crashing when resuming to
use PC after screen has been turned off for a while. This is my prio.
https://bugs.kde.org/show_bug.cgi?id=478679
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3695


Arjen
* been chasing plasma bugs
* currently investigating a crash in plasmashell I get with mirrored screen


Carl
Worked mostly on porting apps to Qt6
Plasma relevant, i created
https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/344
and a related thread on the kde-devel mailing list about
spacing/margins. It might be a good idea to get some other thoughts on
the topic of Kirigami.Units vs QStyle::pixelMetric(PM_LayoutMargin).


Kai Uwe
KWin:
Allow show desktop screen edge during drag and drop, please
review: https://invent.kde.org/plasma/kwin/-/merge_requests/4792
Lets you start dragging a file, nudge the screen edge to show
the desktop, drop on desktop
Plasma:
Folder View creates drag pixmap with dpr now
Will add “Channel” to WLAN frequency details
Frameworks:
Support XDG foreign, I’d really get this in soon...
https://invent.kde.org/framewo

Re: Merge Service still in use?

2023-12-18 Thread Vlad Zahorodnii

On 12/16/23 03:41, Ben Cooksley wrote:

Hi all,

I've just been reviewing services we're looking after and while doing 
so have noticed that Marge Bot (invent.kde.org/merge-service 
) doesn't seem to have done 
anything for 4 months.


As the two projects with it enabled, is this something you're still 
using as it doesn't look like it.


Hi,

We stopped using it in kwin.

Regards,
Vlad