Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated Feb. 8, 2017, 1:46 p.m.) Status -- This change has been discarded. Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich
Re: Review Request 124397: Add today button to calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Feb. 4, 2016, 8:30 nachm.) Status -- This change has been discarded. Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description --- Add button "Select Today" to calendar title bar BUG: 348362 Diffs - src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e202ced1c050479ed04d71d8976a4e03a12c Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar "Select Today" button is shown select different day clicked button -> selection changes to today moved to another month/month selection/year/year selection -> clicked button --> jumps to today File Attachments Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124397: Add today button to calendar
On Juli 28, 2015, 8:37 nachm., Martin Klapetek wrote: src/declarativeimports/calendar/qml/DaysCalendar.qml, lines 147-149 https://git.reviewboard.kde.org/r/124397/diff/3/?file=388457#file388457line147 Given this is only used here, would it make more sense to actually move the function here? Having it on the main item does not seem to bring any advantages... resetToday in MonthView.qml is used for example by org.kde.plasma.digitalclock/contents/ui/CalendarView.qml I don't know where else it is also used.. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review83118 --- On Juli 28, 2015, 8:32 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 28, 2015, 8:32 nachm.) Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description --- Add button Select Today to calendar title bar BUG: 348362 Diffs - src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e202ced1c050479ed04d71d8976a4e03a12c Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown select different day clicked button - selection changes to today moved to another month/month selection/year/year selection - clicked button -- jumps to today File Attachments Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124397: Add today button to calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 28, 2015, 8:21 nachm.) Review request for KDE Frameworks and Plasma. Changes --- Updated patch for latest calendar changes Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description (updated) --- Add button Select Today to calendar title bar Button only changes current view (day, month, year), not the selection BUG: 348362 Diffs (updated) - src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e202ced1c050479ed04d71d8976a4e03a12c Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing (updated) --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown select different day clicked button - selection changes to today moved to another month/month selection/year/year selection - clicked button -- jumps to today File Attachments Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124397: Add today button to calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 28, 2015, 8:32 nachm.) Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description (updated) --- Add button Select Today to calendar title bar BUG: 348362 Diffs - src/declarativeimports/calendar/qml/DaysCalendar.qml 35a1e202ced1c050479ed04d71d8976a4e03a12c Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown select different day clicked button - selection changes to today moved to another month/month selection/year/year selection - clicked button -- jumps to today File Attachments Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
On Juli 19, 2015, 4:51 nachm., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? Bernhard Friedreich wrote: that should be possible yes.. but shouldn't it also work like this? Martin Klapetek wrote: I think you are supposed to just add TranslationSystem=kde and TranslationDomain=your-translation-domain into the kcfgc file and the rest is automagic. Emphasizes on the think. Martin Klapetek wrote: ...and then you should use label.../label or text.../text. hm.. I couldn't find any examples on how to integrate a kcfgc file with a plasmoid - is this supposed to be done? Or shall I just fallback to the solution proposed by Kai? If you think this is the way to go I'll try of course :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review82655 --- On Juli 19, 2015, 2:25 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated Juli 19, 2015, 2:25 nachm.) Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 122488: Improved calendar navigation
On Mai 21, 2015, 5:24 nachm., Martin Klapetek wrote: Bump. Can we get this in for 5.4? Marco Martin wrote: ugh, i almost forgot about this... yes please Just tested the patch. Working beautifully for me from a user perspective :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/#review80706 --- On Juli 18, 2015, 8:28 nachm., Kai Uwe Broulik wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122488/ --- (Updated Juli 18, 2015, 8:28 nachm.) Review request for Plasma and KDE Usability. Repository: plasma-framework Description --- This improves the calendar navigation by providing a Year overview showing all 12 months in a grid, and a Decade overview showing the current decade in a grid. A lot of code has just been moved around. The overviews use a QML ListModel owing to laziness. See https://www.youtube.com/watch?v=7SaBhRa32ds for a screencast (I love that mouse click effect!) Diffs - src/declarativeimports/calendar/calendar.h 5dc3081 src/declarativeimports/calendar/calendar.cpp c462dbd src/declarativeimports/calendar/daydata.h 39ac086 src/declarativeimports/calendar/daysmodel.h e1285f6 src/declarativeimports/calendar/daysmodel.cpp 1a6f454 src/declarativeimports/calendar/qml/DayDelegate.qml 6a3747e src/declarativeimports/calendar/qml/DaysCalendar.qml ab3e750 src/declarativeimports/calendar/qml/MonthView.qml 601755f Diff: https://git.reviewboard.kde.org/r/122488/diff/ Testing --- I changed the selection to be persistent during navigation; other than that, should work as before, with the new overviews. Thanks, Kai Uwe Broulik ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124397: Add today button to calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description --- Add button Select Today to calendar title bar, aligned to the right Removed commented out code to jump to a specific date, this will likely be replaced by RR 122488 BUG: 348362 Diffs - src/declarativeimports/calendar/qml/MonthView.qml 601755f4e9f99618914099e35616e71c332ec7c4 Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown clicked different day clicked button - jumps to today moved to another month - clicked button -- jumps to today Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124394: Timer: trying to fix missing translation in config file (not working)
On Juli 19, 2015, 4:51 nachm., Kai Uwe Broulik wrote: What about just leaving the default an empty string and then do a fallback on the QML side? that should be possible yes.. but shouldn't it also work like this? - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/#review82655 --- On Juli 19, 2015, 2:25 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- (Updated Juli 19, 2015, 2:25 nachm.) Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 124394: Timer: trying to fix missing translation in config file (not working)
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124394/ --- Review request for Plasma. Bugs: 347492 http://bugs.kde.org/show_bug.cgi?id=347492 Repository: kdeplasma-addons Description --- I'm trying to fix a missing translation in the timer applets config file (config.xml using kcfg) but I can't get it to work :( David Edmundson commented in the bug if this fixed it - I don't think so - or at least I don't understand what to do with it.. https://git.reviewboard.kde.org/r/123872/ Any suggestions? Diffs - applets/timer/package/contents/config/main.xml 833bf8f45df4f0e468301a426852bf01c94e1221 Diff: https://git.reviewboard.kde.org/r/124394/diff/ Testing --- Tried adding the applet - the full i18n String is used instead of a translation/the original string Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124397: Add today button to calendar
On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote: Please include a screenshot for UI changes. Also please wait until Review 122488 is merged to save me another rebase headache. Of course :) I'll wait till your Review is merged. Just wanted to get some comments if I'm on the right track :) Thanks for the review :) Screenshot attached. On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote: src/declarativeimports/calendar/qml/MonthView.qml, lines 161-164 https://git.reviewboard.kde.org/r/124397/diff/1/?file=386074#file386074line161 ToolButton has a tooltip property, no need for a custom tooltip thanks didn't know that :) in the original code it was done like this. On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote: src/declarativeimports/calendar/qml/MonthView.qml, line 156 https://git.reviewboard.kde.org/r/124397/diff/1/?file=386074#file386074line156 ToolButton is square by default makes sense.. On Juli 19, 2015, 4:50 nachm., Kai Uwe Broulik wrote: src/declarativeimports/calendar/qml/MonthView.qml, line 155 https://git.reviewboard.kde.org/r/124397/diff/1/?file=386074#file386074line155 Should be go-jump-today I suppose fixed thanks :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review82653 --- On Juli 19, 2015, 5:04 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:04 nachm.) Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description --- Add button Select Today to calendar title bar, aligned to the right Removed commented out code to jump to a specific date, this will likely be replaced by RR 122488 BUG: 348362 Diffs - src/declarativeimports/calendar/qml/MonthView.qml 601755f4e9f99618914099e35616e71c332ec7c4 Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown clicked different day clicked button - jumps to today moved to another month - clicked button -- jumps to today File Attachments Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124397: Add today button to calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:04 nachm.) Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description --- Add button Select Today to calendar title bar, aligned to the right Removed commented out code to jump to a specific date, this will likely be replaced by RR 122488 BUG: 348362 Diffs - src/declarativeimports/calendar/qml/MonthView.qml 601755f4e9f99618914099e35616e71c332ec7c4 Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown clicked different day clicked button - jumps to today moved to another month - clicked button -- jumps to today File Attachments (updated) Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124397: Add today button to calendar
On Juli 19, 2015, 7:59 nachm., Kai Uwe Broulik wrote: +1 from my side Looking really nice, I wonder why I didn't think of this earlier :) thanks :) I'll wait for your patches to land and then rebase/push :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/#review82663 --- On Juli 19, 2015, 5:06 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:06 nachm.) Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description --- Add button Select Today to calendar title bar, aligned to the right Removed commented out code to jump to a specific date, this will likely be replaced by RR 122488 BUG: 348362 Diffs - src/declarativeimports/calendar/qml/MonthView.qml 601755f4e9f99618914099e35616e71c332ec7c4 Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown clicked different day clicked button - jumps to today moved to another month - clicked button -- jumps to today File Attachments Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 124397: Add today button to calendar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124397/ --- (Updated Juli 19, 2015, 5:06 nachm.) Review request for KDE Frameworks and Plasma. Bugs: 348362 http://bugs.kde.org/show_bug.cgi?id=348362 Repository: plasma-framework Description --- Add button Select Today to calendar title bar, aligned to the right Removed commented out code to jump to a specific date, this will likely be replaced by RR 122488 BUG: 348362 Diffs (updated) - src/declarativeimports/calendar/qml/MonthView.qml 601755f4e9f99618914099e35616e71c332ec7c4 Diff: https://git.reviewboard.kde.org/r/124397/diff/ Testing --- plasmoidviewer with digitalclock plasmoid added digitalclock plasmoid to desktop clicked digital clock plasmoid to view calendar Select Today button is shown clicked different day clicked button - jumps to today moved to another month - clicked button -- jumps to today File Attachments Plasmoidviewer Digital Clock showing Calendar with Today ToolButton https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 21, 2015, 7:37 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 8f09567eae260a1241e65e2ec2a9e9ba28bbf0ad by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
On April 20, 2015, 7:59 a.m., Marco Martin wrote: hmm, the timer is actually quite small and not bigger than the digital clock, It would be probably better if it stays always extended the whole resizing mechanism of the plasmoid will need to be rewritten I fear.. while doing this I also plan to make the timer automatically show in it's full form also in panel. For now (with this addition) I would leave it like it is.. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/#review79243 --- On April 18, 2015, 6:14 p.m., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 18, 2015, 6:14 p.m.) Review request for Plasma. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
On April 20, 2015, 7:59 vorm., Marco Martin wrote: hmm, the timer is actually quite small and not bigger than the digital clock, It would be probably better if it stays always extended Bernhard Friedreich wrote: the whole resizing mechanism of the plasmoid will need to be rewritten I fear.. while doing this I also plan to make the timer automatically show in it's full form also in panel. For now (with this addition) I would leave it like it is.. Marco Martin wrote: what it needs is to export a sane Layout.minimumWidth / minimumHeight Like the digital clock, should export a fixed size that would make fit all numbers in the timer without continuous panel relayout. a collapsed mode may still be useful in the case of vertical, very narrow panels hmm.. still: may I submit this? As you said the layouting will need to be updated, but I feel like this will be a whole different task - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/#review79243 --- On April 18, 2015, 6:14 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 18, 2015, 6:14 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- Review request for Plasma. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 18, 2015, 5:26 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments (updated) Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
On April 18, 2015, 5:33 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/timer.qml, lines 221-225 https://git.reviewboard.kde.org/r/123420/diff/1/?file=362055#file362055line221 Can be simplified to operation.summary = notificationText || i18n(Timer finished) Ah nice :) also using this for the appName now :) On April 18, 2015, 5:33 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/timer.qml, line 56 https://git.reviewboard.kde.org/r/123420/diff/1/?file=362055#file362055line56 Make that proper if statements, complex ternary operators are hard to follow yeah this one grew too big.. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/#review79175 --- On April 18, 2015, 6:14 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 18, 2015, 6:14 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123420: Timer: added tooltip for compact mode (e.g. in panel) and full mode
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123420/ --- (Updated April 18, 2015, 6:14 nachm.) Review request for Plasma. Changes --- Fixed issues pointed out by Kai Uwe Broulik. Thanks for the review :) Repository: kdeplasma-addons Description --- Compact Mode: shows the name of the timer and the remaining seconds Using the tooltip it is possible to glance at the timer without opening the full representation by clicking Full Mode: shows information that you can use the scroll wheel to change the digits and choose from predefined timers using the context menu BUG: 259630 Added missing i18n for notifaction finished text Diffs (updated) - applets/timer/package/contents/ui/timer.qml 2f7af4f3815b3c8a43e4a7b32d6a020cf3dc0848 Diff: https://git.reviewboard.kde.org/r/123420/diff/ Testing --- File Attachments Compact mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/9b90a460-8808-49bd-969f-cedcc9251f32__tooltip_compact_mode_running.png Compact mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/f548efea-0635-4647-b9a3-6d2d4c497bfa__tooltip_compact_mode.png Full mode running https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/c7370926-e497-43f1-a254-8448e4ffbdf0__tooltip_full_mode_running.png Full mode https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/e4068531-ced8-4487-8b2e-d95b339d7e53__tooltip_full_mode.png Compact mode with title and time already set https://git.reviewboard.kde.org/media/uploaded/files/2015/04/18/4d574a75-d469-4f65-acb7-6961fe567782__tooltip_compact_mode_title_set.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
On April 15, 2015, 7:49 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 44 https://git.reviewboard.kde.org/r/123332/diff/2/?file=361044#file361044line44 This is the line that doesn't work. Layout.property is a hint for the parent item, if and only if the parent item item is a layout. GroupBox is not a layout, it's an item. So this does nothing. This means we have nothing telling this layout that it should be as big as the parent. It might be on first open, but it's not bound to anything. The layout in the groupbox needs to anchors.fill: parent to tell it to fill the groupbox. Same for the other groupbox below. Hope that makes sense? Ping me on IRC if it doesn't. thank you very much for taking a look :) using anchors.fill: parent in the GroupBox-ColumnLayout I was finally able to get it to work :) Updated diff :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78989 --- On April 17, 2015, 8:02 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 17, 2015, 8:02 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Tab showing defaults https://git.reviewboard.kde.org/media/uploaded/files/2015/04/17/f133b83a-c8bd-4cbb-b1d1-2757b3016fd1__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 17, 2015, 8:02 nachm.) Review request for Plasma. Changes --- Updated to use anchors.fill: parent Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs (updated) - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments (updated) Appearance Tab showing defaults https://git.reviewboard.kde.org/media/uploaded/files/2015/04/17/f133b83a-c8bd-4cbb-b1d1-2757b3016fd1__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 17, 2015, 8:16 nachm.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Tab showing defaults https://git.reviewboard.kde.org/media/uploaded/files/2015/04/17/f133b83a-c8bd-4cbb-b1d1-2757b3016fd1__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 13, 2015, 7:33 nachm.) Review request for Plasma. Changes --- Updated the diff with the latest fillWidth changes - still doesn't resize the TextEdits properly to the full width.. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs (updated) - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using QtLayouts.Layout.fillWidth: true doesn't work for me :( I've set it in all layers I think: the GroupBox, the ColumnLayout, the RowLayout and finally the TextField but it stays small... Bernhard Friedreich wrote: any ideas on this? can't get it to work.. Martin Klapetek wrote: You should use only Layout.fillWidth, not QtLayouts.Layout I think? It's just an attached property, that's never with the import name mhm.. according to this page [1] it must be imported using e.g. import QtQuick.Layouts 1.1 as QtLayouts therefore my code looks like QtLayouts.Layout.fillWidth: true but doesn't work :( [1]: http://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#fillWidth-attached-prop - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 --- On April 11, 2015, 2:16 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 11, 2015, 2:16 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using QtLayouts.Layout.fillWidth: true doesn't work for me :( I've set it in all layers I think: the GroupBox, the ColumnLayout, the RowLayout and finally the TextField but it stays small... Bernhard Friedreich wrote: any ideas on this? can't get it to work.. Martin Klapetek wrote: You should use only Layout.fillWidth, not QtLayouts.Layout I think? It's just an attached property, that's never with the import name Bernhard Friedreich wrote: mhm.. according to this page [1] it must be imported using e.g. import QtQuick.Layouts 1.1 as QtLayouts therefore my code looks like QtLayouts.Layout.fillWidth: true but doesn't work :( [1]: http://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#fillWidth-attached-prop Bernhard Friedreich wrote: removing the alias and just using Layout.fillWidth: true doesn't work either.. Kai Uwe Broulik wrote: Well, the parent Layout doesn't have a width either, so it cannot span. Add a Layout.fillWidth to the parent one as well, looks like you forgot one. I have added those locally already but it doesn't change anything. just updated the reviewrequest with the latest diff containig the fillWidth for every layer.. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 --- On April 13, 2015, 7:33 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 13, 2015, 7:33 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
On April 13, 2015, 7:40 nachm., David Edmundson wrote: Ship It! sorry for the misunderstanding but the TextEdits still don't resize to the windowsize.. (see the open issue) I've just updated the review request with my latest tries about the fillWidth everywhere.. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78905 --- On April 13, 2015, 7:33 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 13, 2015, 7:33 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAdvanced.qml c315c89249ae5f926c46a901e0358162a067cea4 applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using QtLayouts.Layout.fillWidth: true doesn't work for me :( I've set it in all layers I think: the GroupBox, the ColumnLayout, the RowLayout and finally the TextField but it stays small... Bernhard Friedreich wrote: any ideas on this? can't get it to work.. Martin Klapetek wrote: You should use only Layout.fillWidth, not QtLayouts.Layout I think? It's just an attached property, that's never with the import name Bernhard Friedreich wrote: mhm.. according to this page [1] it must be imported using e.g. import QtQuick.Layouts 1.1 as QtLayouts therefore my code looks like QtLayouts.Layout.fillWidth: true but doesn't work :( [1]: http://doc.qt.io/qt-5/qml-qtquick-layouts-layout.html#fillWidth-attached-prop removing the alias and just using Layout.fillWidth: true doesn't work either.. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 --- On April 11, 2015, 2:16 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 11, 2015, 2:16 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? Bernhard Friedreich wrote: using QtLayouts.Layout.fillWidth: true doesn't work for me :( I've set it in all layers I think: the GroupBox, the ColumnLayout, the RowLayout and finally the TextField but it stays small... any ideas on this? can't get it to work.. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 --- On April 11, 2015, 2:16 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 11, 2015, 2:16 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123332: Timer: Added config ui for notification and title text
On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/ui/configAppearance.qml, line 91 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360828#file360828line91 use Layout.fillWith: true ? using QtLayouts.Layout.fillWidth: true doesn't work for me :( I've set it in all layers I think: the GroupBox, the ColumnLayout, the RowLayout and finally the TextField but it stays small... On April 11, 2015, 3 nachm., David Edmundson wrote: applets/timer/package/contents/config/main.xml, line 33 https://git.reviewboard.kde.org/r/123332/diff/1/?file=360827#file360827line33 Currently there's no way to set these in the UI? If there is, we'll have to migrate configs, but if can rely on them always being the current default, then there's no point. In the current kf5 based qml version of the plasmoid there is no way of setting it in the ui. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/#review78812 --- On April 11, 2015, 2:16 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- (Updated April 11, 2015, 2:16 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123332: Timer: Added config ui for notification and title text
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123332/ --- Review request for Plasma. Repository: kdeplasma-addons Description --- Added config ui for specifying a title text Added config ui for disabling the notification (default: enabled) Added config ui for configuring the notification text Diffs - applets/timer/package/contents/config/main.xml 886bcd413ff68b4b5b092409dbc5f0e4aff273dc applets/timer/package/contents/ui/configAppearance.qml ceb97326b8192a9dfe80b6753c0fd0a7e3010095 applets/timer/package/contents/ui/timer.qml 82fee524f51f06f522fc8c556a7454ab6840d1a3 Diff: https://git.reviewboard.kde.org/r/123332/diff/ Testing --- File Attachments Appearance Config Ui (showing the defaults) https://git.reviewboard.kde.org/media/uploaded/files/2015/04/11/7628230f-9be6-4c13-b57d-584cb56043bc__tab_appearance_default.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 29 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line29 What is that invisible (flat and no title) GroupBox for? copycat is to be blamed (took it like that from another plasmoid iirc) :) On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 3:19 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? David Edmundson wrote: set the default to true in the xml file? I ment if some users had already used the property hideSeconds and we are changing the config-key to showSeconds then they will have to configure it again. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 3:19 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:19 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:16 nachm.) Review request for Plasma. Changes --- Implemented suggestions from David Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs (updated) - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments (updated) Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78631 --- applets/timer/package/contents/ui/configAppearance.qml (line 25) https://git.reviewboard.kde.org/r/123274/#comment53803 removed already locally - Bernhard Friedreich On April 7, 2015, 3:16 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 3:16 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 7, 2015, 3:28 nachm., Kai Uwe Broulik wrote: applets/timer/package/contents/ui/configAppearance.qml, line 43 https://git.reviewboard.kde.org/r/123274/diff/4/?file=360398#file360398line43 HIG says Checkboxes should always be positive, ie. Show seconds and then enable it by default instead; also makes it consistent with the other one Bernhard Friedreich wrote: current config (main.xml) uses hideSeconds as property - how can this be migrated properly for our users if we are changing this? Or don't we have to care about this because the ui wasn't there in plasma 5.x yet? David Edmundson wrote: set the default to true in the xml file? Bernhard Friedreich wrote: I ment if some users had already used the property hideSeconds and we are changing the config-key to showSeconds then they will have to configure it again. David Edmundson wrote: ah, if it's not been released then we don't care. In a hypothetical example where it was released, you would use kconf_update: https://techbase.kde.org/Development/Tools/Using_kconf_update afaik it hasn't been released yet. I've already updated the last diff to reflect this change. - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78632 --- On April 7, 2015, 5:20 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 5:20 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 5:20 nachm.) Review request for Plasma. Changes --- Implemented suggestions by Kai Uwe Broulik. Thanks for the review :) Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs (updated) - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 7, 2015, 9:08 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 57aeac6278d8085b481850d62eb2f2ad8109a316 by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening [Edit 3]: updated layers in the config ui and make the command textfield depend upon the checkbox [Edit 4]: fixed many things mentioned by Kai Uwe Broulik Diffs - applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/config/main.xml 6d4cdd38965e57d351df999b76d759af6bbe724c applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/76e6ad91-78e2-4a91-8d2d-99a7ccce41c4__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/e5c1c56e-1109-4d24-9c41-d5f4ffd99d44__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments (updated) General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 6, 2015, 2:29 nachm., David Edmundson wrote: File Attachment: General Tab - tab_general.png https://git.reviewboard.kde.org/r/123274/#fcomment391 Given this looks like advanced feature, I'd rather we hid it away so it wasn't the first thing that comes up in the config. So I'm clear, what do you see the use case of this being? Well primarily I readded those configuration options because they were there originally, and looking at the bugreports also used. I guess they got lost in the port to kf5/qml. In the config xml they where still there and I guess some people want them back. Personally I could imagine usecases like custom notifications - e.g. I'll take a short nap of about half an hour - after the timer is done please start playing some music - this could be set as a command I guess. Other ideas instead of command execution? Could we hook something else into this? Your argument about the advanced feature is of course correct - any suggestions? Rename the tab from General to Advanced (?) and move it down below the Appearance so the appearance tab is shown when opening the config dialog? On April 6, 2015, 2:29 nachm., David Edmundson wrote: applets/timer/plugin/timer.cpp, line 28 https://git.reviewboard.kde.org/r/123274/diff/1/?file=360283#file360283line28 QProcess::stateDetached(touch /tmp/asdf); doesn't behave quite as you think it should, the args need to be in a second argument as a stringlist of one per argument. You'll need to do some splitting and such in here. Oh I thought KProcess was the preferred way.. Meh.. yeah this will need fixing of course.. Thanks for the review :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 1:11 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 3:55 nachm.) Review request for Plasma. Changes --- Updated to use QProcess Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: Updated to use QProcess Diffs (updated) - applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 6, 2015, 2:29 nachm., David Edmundson wrote: applets/timer/plugin/timer.cpp, line 28 https://git.reviewboard.kde.org/r/123274/diff/1/?file=360283#file360283line28 QProcess::stateDetached(touch /tmp/asdf); doesn't behave quite as you think it should, the args need to be in a second argument as a stringlist of one per argument. You'll need to do some splitting and such in here. Bernhard Friedreich wrote: Oh I thought KProcess was the preferred way.. Meh.. yeah this will need fixing of course.. Thanks for the review :) QProcess::startDetached(touch /home/friedreb/blah); works for me as expected (file is created/touched) - imho using this method I won't have to parse the arguments manually.. do I miss something here what you've ment? - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 1:11 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 1:11 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) Diffs - applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configGeneral.qml PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments General Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/d21e3a9e-fef5-4d08-b5b4-1654a4b198b5__tab_general.png Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/bca4649f-4d12-40d5-b801-7a4fc73943ba__tab_appearance.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 4:05 nachm.) Review request for Plasma. Changes --- Rename General to Advanced and make Appearance the first tab shown when opening the config dialog Repository: kdeplasma-addons Description (updated) --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs (updated) - applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments (updated) Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123274: Timer Plasmoid: Added config ui for hiding/showing seconds and title, and cmd execution
On April 6, 2015, 2:29 nachm., David Edmundson wrote: File Attachment: General Tab - tab_general.png https://git.reviewboard.kde.org/r/123274/#fcomment392 Given this looks like advanced feature, I'd rather we hid it away so it wasn't the first thing that comes up in the config. So I'm clear, what do you see the use case of this being? Bernhard Friedreich wrote: Well primarily I readded those configuration options because they were there originally, and looking at the bugreports also used. I guess they got lost in the port to kf5/qml. In the config xml they where still there and I guess some people want them back. Personally I could imagine usecases like custom notifications - e.g. I'll take a short nap of about half an hour - after the timer is done please start playing some music - this could be set as a command I guess. Other ideas instead of command execution? Could we hook something else into this? Your argument about the advanced feature is of course correct - any suggestions? Rename the tab from General to Advanced (?) and move it down below the Appearance so the appearance tab is shown when opening the config dialog? Regarding the run command usecase: https://bugs.kde.org/show_bug.cgi?id=264934#c1 - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/#review78560 --- On April 6, 2015, 4:05 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123274/ --- (Updated April 6, 2015, 4:05 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Added tab General and Appearance in the config ui General contains the bits about command execution after the timer has completed Appearance contains the ability to hide seconds and showing the title The configuration option for showing the title is a bit buggy (again) This bugreport explains the wrong scaling of the title: 304923 I've converted this plasmoid from being qml only to c++ and qml because it looks like KProcess has no qml interface yet (and I didn't find any place where to start) [Edit 1]: updated to use QProcess [Edit 2]: renamed General to Advanced and moved it down to make Appearance the default tab on opening Diffs - applets/timer/plugin/timerplugin.cpp PRE-CREATION applets/timer/plugin/timer.cpp PRE-CREATION applets/timer/plugin/timerplugin.h PRE-CREATION applets/timer/plugin/timer.h PRE-CREATION applets/timer/plugin/qmldir PRE-CREATION applets/timer/package/contents/ui/timer.qml f675b93bda59eb161fe10b5f575eaa2082b822e0 applets/timer/package/contents/ui/configAppearance.qml PRE-CREATION applets/timer/package/contents/ui/configAdvanced.qml PRE-CREATION applets/timer/package/contents/config/config.qml PRE-CREATION applets/timer/CMakeLists.txt c7cba10a96e6d3f1ba98a3aa755d6d3d8aad0c9f Diff: https://git.reviewboard.kde.org/r/123274/diff/ Testing --- Tested using plasmashell directly and using plasmoidviewer File Attachments Appearance Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/b9a4c7dd-c272-4b4c-807b-145102e17d13__tab_appearance.png Advanced Tab https://git.reviewboard.kde.org/media/uploaded/files/2015/04/06/ca6d1f98-70fe-4d13-a170-ec44cb82bce4__tab_advanced.png Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 is awesome...and some help required with build instructions
To me the XDG_DATA_DIRS path looks right..
[friedreb@pollux kde]$ awk -v 'RS=\0' -F= '$1==XDG_DATA_DIRS {print $2}'
/proc/3183/environ
/products/kde/install/share:/usr/share
[friedreb@pollux kde]$ ls -la /products/kde/install/share/ | wc -l
73
[friedreb@pollux kde]$ ls -la /products/kde/install/share/ | head -n 5
insgesamt 0
drwxrwxr-x. 1 friedreb friedreb 1282 30. Mär 20:51 .
drwxrwxr-x. 1 friedreb friedreb66 30. Mär 17:20 ..
drwxrwxr-x. 1 friedreb friedreb 1208 30. Mär 20:51 applications
drwxrwxr-x. 1 friedreb friedreb24 29. Mär 22:43 apps
Any other ideas?
Thanks
Bernhard
2015-03-30 22:22 GMT+02:00 David Edmundson da...@davidedmundson.co.uk:
Any ideas? (attached the output/bt I got from gdb)
it's an assert in could not find any theme
At a guess you XDG_DATA_DIRS are wrong.
cat /proc/PIDOFPLASMASHELL/env will tell you the most
Thanks :)
Bye,
Bernhard Friedreich
2015-03-28 19:23 GMT+01:00 Siddhartha sh.siddhar...@gmail.com:
Hi David,
Thanks a lot for your comments!
On 28 March 2015 at 20:23, David Edmundson da...@davidedmundson.co.uk
wrote:
I don't think we should tell people to download's David Faure's
kdesrc-buildrc file. It has /d hardcoded a lot.
If we make our own we don't need people to change it and can have the
same
directories you use for the rest of this.
Good point. I took this section from Frameworks/Building, didn't think
too much :P
Maybe we should update that page too?
That's installing to /opt/kde5 but we need to create those directories
first
(as root and change permissions)
Instructions already present :)
If this is about plasma change:
include extragear/utils/kdesrc-build/kf5-qt5-build-include
to
include extragear/utils/kdesrc-build/kf5-frameworks-build-include
include extragear/utils/kdesrc-build/kf5-workspace-build-include
this way you won't build apps and pim
Cool. Changed the whole section.
export XDG_CACHE_HOME=/home/user/.kde5/cache
only works if you happen to be called user.
I'm pretty sure you can do export XDG_CACHE_HOME=$HOME/.whatever
Ah right, fixed.
Personally I wouldn't change the paths, you lose your firefox
settings, and
with the .xinitrc hack later you're only going to be loading this
session
from now on anyway.
Hmm. I preferred having clean Plasma 5 config paths. These lines are
now commented out by default.
The setup is a bit broken, if you do the login manager way.
yet if you log into your distro session and then start anything dbus
activated it will load from /opt/kde/install which is at best a bit
weird.
Ah right. But logging in to a Plasma 4 seemed to work fine. Ideally
one should remove the dbus config before starting the distro session,
yes.
you need to say login manager way and the .xinit way are mutually
exclusive
(well you can do both, but it'd be weird)
Done.
add a line saying to log out and back in.
Done
Cheers!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 is awesome...and some help required with build instructions
I finally found the problem - the instructions on the wiki were updated
since my setup and I was lacking some lib64 directories in the
runPlasma5.sh script..
Thanks for the documentation and your help! :)
2015-03-31 20:44 GMT+02:00 Bernhard Friedreich fries...@gmail.com:
To me the XDG_DATA_DIRS path looks right..
[friedreb@pollux kde]$ awk -v 'RS=\0' -F= '$1==XDG_DATA_DIRS {print
$2}' /proc/3183/environ
/products/kde/install/share:/usr/share
[friedreb@pollux kde]$ ls -la /products/kde/install/share/ | wc -l
73
[friedreb@pollux kde]$ ls -la /products/kde/install/share/ | head -n 5
insgesamt 0
drwxrwxr-x. 1 friedreb friedreb 1282 30. Mär 20:51 .
drwxrwxr-x. 1 friedreb friedreb66 30. Mär 17:20 ..
drwxrwxr-x. 1 friedreb friedreb 1208 30. Mär 20:51 applications
drwxrwxr-x. 1 friedreb friedreb24 29. Mär 22:43 apps
Any other ideas?
Thanks
Bernhard
2015-03-30 22:22 GMT+02:00 David Edmundson da...@davidedmundson.co.uk:
Any ideas? (attached the output/bt I got from gdb)
it's an assert in could not find any theme
At a guess you XDG_DATA_DIRS are wrong.
cat /proc/PIDOFPLASMASHELL/env will tell you the most
Thanks :)
Bye,
Bernhard Friedreich
2015-03-28 19:23 GMT+01:00 Siddhartha sh.siddhar...@gmail.com:
Hi David,
Thanks a lot for your comments!
On 28 March 2015 at 20:23, David Edmundson da...@davidedmundson.co.uk
wrote:
I don't think we should tell people to download's David Faure's
kdesrc-buildrc file. It has /d hardcoded a lot.
If we make our own we don't need people to change it and can have the
same
directories you use for the rest of this.
Good point. I took this section from Frameworks/Building, didn't think
too much :P
Maybe we should update that page too?
That's installing to /opt/kde5 but we need to create those
directories first
(as root and change permissions)
Instructions already present :)
If this is about plasma change:
include extragear/utils/kdesrc-build/kf5-qt5-build-include
to
include extragear/utils/kdesrc-build/kf5-frameworks-build-include
include extragear/utils/kdesrc-build/kf5-workspace-build-include
this way you won't build apps and pim
Cool. Changed the whole section.
export XDG_CACHE_HOME=/home/user/.kde5/cache
only works if you happen to be called user.
I'm pretty sure you can do export XDG_CACHE_HOME=$HOME/.whatever
Ah right, fixed.
Personally I wouldn't change the paths, you lose your firefox
settings, and
with the .xinitrc hack later you're only going to be loading this
session
from now on anyway.
Hmm. I preferred having clean Plasma 5 config paths. These lines are
now commented out by default.
The setup is a bit broken, if you do the login manager way.
yet if you log into your distro session and then start anything dbus
activated it will load from /opt/kde/install which is at best a bit
weird.
Ah right. But logging in to a Plasma 4 seemed to work fine. Ideally
one should remove the dbus config before starting the distro session,
yes.
you need to say login manager way and the .xinit way are mutually
exclusive
(well you can do both, but it'd be weird)
Done.
add a line saying to log out and back in.
Done
Cheers!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma 5 is awesome...and some help required with build instructions
Hi, At first: thanks for the guide :) It's a nice addition to https://community.kde.org/Frameworks/Building I've got the following problems: 1.) on my fedora 23 (rawhide) I had to set selinux to permissive mode for the custom dbus files to be read (otherwise it wouldn't let dbus access them, maybe it is because I changed paths from /opt to /products?) (yeah I know decreasing selinux security isn't a solution) 2.) I can start the session from sddm but plasmashell and krunner crash instantly.. Any ideas? (attached the output/bt I got from gdb) Thanks :) Bye, Bernhard Friedreich 2015-03-28 19:23 GMT+01:00 Siddhartha sh.siddhar...@gmail.com: Hi David, Thanks a lot for your comments! On 28 March 2015 at 20:23, David Edmundson da...@davidedmundson.co.uk wrote: I don't think we should tell people to download's David Faure's kdesrc-buildrc file. It has /d hardcoded a lot. If we make our own we don't need people to change it and can have the same directories you use for the rest of this. Good point. I took this section from Frameworks/Building, didn't think too much :P Maybe we should update that page too? That's installing to /opt/kde5 but we need to create those directories first (as root and change permissions) Instructions already present :) If this is about plasma change: include extragear/utils/kdesrc-build/kf5-qt5-build-include to include extragear/utils/kdesrc-build/kf5-frameworks-build-include include extragear/utils/kdesrc-build/kf5-workspace-build-include this way you won't build apps and pim Cool. Changed the whole section. export XDG_CACHE_HOME=/home/user/.kde5/cache only works if you happen to be called user. I'm pretty sure you can do export XDG_CACHE_HOME=$HOME/.whatever Ah right, fixed. Personally I wouldn't change the paths, you lose your firefox settings, and with the .xinitrc hack later you're only going to be loading this session from now on anyway. Hmm. I preferred having clean Plasma 5 config paths. These lines are now commented out by default. The setup is a bit broken, if you do the login manager way. yet if you log into your distro session and then start anything dbus activated it will load from /opt/kde/install which is at best a bit weird. Ah right. But logging in to a Plasma 4 seemed to work fine. Ideally one should remove the dbus config before starting the distro session, yes. you need to say login manager way and the .xinit way are mutually exclusive (well you can do both, but it'd be weird) Done. add a line saying to log out and back in. Done Cheers! ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel (gdb) bt #0 0x76674520 in QQmlComponent::status() const () at /lib64/libQt5Qml.so.5 #1 0x7723f832 in KDeclarative::QmlObject::completeInitialization(QHashQString, QVariant const) (this=0xba4640, initialProperties=...) at /products/kde/sources/frameworks/kdeclarative/src/kdeclarative/qmlobject.cpp:264 #2 0x0040cfc5 in View::View(QWindow*) (this=0x7fffde50) at /products/kde/sources/kde/workspace/plasma-workspace/krunner/view.cpp:93 #3 0x0040bb58 in main(int, char**) (argc=1, argv=0x7fffe0c8) at /products/kde/sources/kde/workspace/plasma-workspace/krunner/main.cpp:66 Starting program: /products/kde/install/bin/plasmashell [Thread debugging using libthread_db enabled] Using host libthread_db library /lib64/libthread_db.so.1. kf5.kiconthemes: Theme tree: (Breeze) kf5.kservice.sycoca: Trying to open ksycoca from /home/friedreb/.cache/ksycoca5 populateAddPanelsMenu 1 Failed to load the OSD script file from [New Thread 0x7fffd26bf700 (LWP 2216)] has no desktop group, cannot construct a KPluginInfo object from it. Detaching after fork from child process 2218. kscreen: launcherDataAvailable: org.kde.KScreen.Backend.XRandR kscreen: Launcher finished with exit code 1 , status 0 kscreen: Service for requested backend already running kscreen: Primary output changed from KScreen::Output(Id: 118 , Name: LVDS1 ) ( LVDS1 ) to KScreen::Output(Id: 118 , Name: LVDS1 ) ( LVDS1 ) Error loading plugin plasma_applet_timer Die dynamische Bibliothek konnte nicht gefunden werden. Plugin search paths are (/usr/lib64/qt5/plugins, /products/kde/install/bin) The environment variable QT_PLUGIN_PATH might be not correctly set unversioned plugin detected, may result in instability Error loading plugin plasma_applet_timer Die dynamische Bibliothek konnte nicht gefunden werden. Plugin search paths are (/usr/lib64/qt5/plugins, /products/kde/install/bin) The environment variable QT_PLUGIN_PATH might be not correctly set Could not load applet org.kde.plasma.timer ! reason given: Die dynamische Bibliothek konnte nicht gefunden werden. Falling back to an empty one Constructing a KPluginInfo object from old style JSON. Please use
Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion
On März 29, 2015, 3:03 nachm., David Edmundson wrote: If it works in plasmashell, ship it. yeah works in plasmashell :) I don't have commit access yet - shall I request it? Is this the recommended way? https://identity.kde.org/index.php?r=developerApplication - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/#review78176 --- On März 29, 2015, 2:20 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/ --- (Updated März 29, 2015, 2:20 nachm.) Review request for Plasma. Repository: kdeplasma-addons Description --- Commit 1: Fixed codingstyle Commit 2: Fixed warning Unable to assign int to QEasingCurve Commit 3: Added notification on timer completion (not working yet) Diffs - applets/timer/package/contents/ui/TimerDigit.qml 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405 applets/timer/package/contents/ui/timer.qml 09df67004f07352436a30195fb13c2550f8ebce7 Diff: https://git.reviewboard.kde.org/r/123173/diff/ Testing --- Event is fired when the timer is finished (console.log output works) but the notification won't show up. I get this message on console: Are we the only client? (Both have to be true) false true How can I send a notification from qml (without c++)? Am I on the right track? [Edit] Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas? Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123173: Timer Plasmoid: Add notification on timer completion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/ --- Review request for Plasma. Repository: kdeplasma-addons Description --- Commit 1: Fixed codingstyle Commit 2: Fixed warning Unable to assign int to QEasingCurve Commit 3: Added notification on timer completion (not working yet) Diffs - applets/timer/package/contents/ui/TimerDigit.qml 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405 applets/timer/package/contents/ui/timer.qml 09df67004f07352436a30195fb13c2550f8ebce7 Diff: https://git.reviewboard.kde.org/r/123173/diff/ Testing --- Event is fired when the timer is finished (console.log output works) but the notification won't show up. I get this message on console: Are we the only client? (Both have to be true) false true How can I send a notification from qml (without c++)? Am I on the right track? Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123173: Timer Plasmoid: Add notification on timer completion
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123173/ --- (Updated March 29, 2015, 7:53 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 99c42f6c8f67984abcc270425a1ab2469d199386 by Bernhard Friedreich to branch master. Repository: kdeplasma-addons Description --- Commit 1: Fixed codingstyle Commit 2: Fixed warning Unable to assign int to QEasingCurve Commit 3: Added notification on timer completion (not working yet) Diffs - applets/timer/package/contents/ui/TimerDigit.qml 94ec17d2c1e6fb02f6d8d3b1c0ea75f16b0fa405 applets/timer/package/contents/ui/timer.qml 09df67004f07352436a30195fb13c2550f8ebce7 Diff: https://git.reviewboard.kde.org/r/123173/diff/ Testing --- Event is fired when the timer is finished (console.log output works) but the notification won't show up. I get this message on console: Are we the only client? (Both have to be true) false true How can I send a notification from qml (without c++)? Am I on the right track? [Edit] Looks like the notification is working if the plasmoid is added somewhere but not from within plasmawindowed.. any ideas? Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123161: Add copy and paste support for calculator widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/ --- (Updated März 28, 2015, 2:45 nachm.) Review request for Plasma. Changes --- Fixed pasting and implemented suggestions. Bugs: 318221 http://bugs.kde.org/show_bug.cgi?id=318221 Repository: kdeplasma-addons Description --- The current displayed value from the textfield can be copied. Content from the clipboard can be pasted but only if the content is a valid number BUG: 318221 Diffs (updated) - applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff: https://git.reviewboard.kde.org/r/123161/diff/ Testing (updated) --- Copying: *) Tried copying entered numbers and results - works for me :) Pasting: *) Pasting asdf leads to nothing being pasted - correct *) Pasting 5 appends the number to the currently entered input or replaces the current number in case an operator has been pressed before Only pasting doubles is possible - no signs or full math expressions are supported. It looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 doesnt result in 10) Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123161: Add copy and paste support for calculator widget
On März 27, 2015, 11:46 nachm., David Edmundson wrote: applets/calculator/package/contents/ui/calculator.qml, line 220 https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line220 I'm not convinced this is going to work. You'll update the display, but all the handling of storing what number is entered handles in the key press events. Can you try pasting 5 then typing '+' and '1' and see what happens. I think it will then show 1, not 6. you are right - this doesn't work.. slipped my testing somehow.. should I iterate over every character of the clipboard and call displayNumber for each? Would reuse the existing codepath.. On März 27, 2015, 11:46 nachm., David Edmundson wrote: applets/calculator/package/contents/ui/calculator.qml, line 95 https://git.reviewboard.kde.org/r/123161/diff/1/?file=356978#file356978line95 avoid guessing what the shortcut is. Otherwise if someone maps it to alt in their settings it won't work. Or if someone has a dvorak layout it won't be c and v. Use if event.matches(StandardKey.Copy) http://doc.qt.io/qt-5/qml-qtquick-keyevent.html#matches-method internally this will ask our QPT plugin which loads things from a KDE config file. I had already found this before but the clipboard plasmoid was doing it like this so I thought this was the prefered way - makes sense and is more readable. Thanks :) - Bernhard --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/#review78129 --- On März 27, 2015, 11:21 nachm., Bernhard Friedreich wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/ --- (Updated März 27, 2015, 11:21 nachm.) Review request for Plasma. Bugs: 318221 http://bugs.kde.org/show_bug.cgi?id=318221 Repository: kdeplasma-addons Description --- The current displayed value from the textfield can be copied. Content from the clipboard can be pasted but only if the content is a valid number BUG: 318221 Diffs - applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff: https://git.reviewboard.kde.org/r/123161/diff/ Testing --- Copying: *) Tried copying entered numbers and results - works for me :) Pasting: *) Pasting asdf leads to nothing being pasted - correct *) Pasting 5 pasts 5 - replaces the currently entered text with the pasted content (this could be worked around - should it append?) *) Pasting = 5 + 3 passes through validation - no idea why yet - this should be possible I guess? Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 123161: Add copy and paste support for calculator widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/ --- (Updated March 28, 2015, 3:18 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 16cad20c28e09109844f1e34ae87c71ae8259350 by David Edmundson on behalf of Bernhard Friedreich to branch master. Bugs: 318221 http://bugs.kde.org/show_bug.cgi?id=318221 Repository: kdeplasma-addons Description --- The current displayed value from the textfield can be copied. Content from the clipboard can be pasted but only if the content is a valid number BUG: 318221 Diffs - applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff: https://git.reviewboard.kde.org/r/123161/diff/ Testing --- Copying: *) Tried copying entered numbers and results - works for me :) Pasting: *) Pasting asdf leads to nothing being pasted - correct *) Pasting 5 appends the number to the currently entered input or replaces the current number in case an operator has been pressed before Only pasting doubles is possible - no signs or full math expressions are supported. It looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 doesnt result in 10) Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 123161: Add copy and paste support for calculator widget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/ --- Review request for Plasma. Bugs: 318221 http://bugs.kde.org/show_bug.cgi?id=318221 Repository: kdeplasma-addons Description --- The current displayed value from the textfield can be copied. Content from the clipboard can be pasted but only if the content is a valid number BUG: 318221 Diffs - applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff: https://git.reviewboard.kde.org/r/123161/diff/ Testing --- Copying: *) Tried copying entered numbers and results - works for me :) Pasting: *) Pasting asdf leads to nothing being pasted - correct *) Pasting 5 pasts 5 - replaces the currently entered text with the pasted content (this could be worked around - should it append?) *) Pasting = 5 + 3 passes through validation - no idea why yet - this should be possible I guess? Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P Thanks, Bernhard Friedreich ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
