D18892: Move Look and Feel KCM to top level

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0af980f5cab8: Move Look and Feel KCM to top level 
(authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18892?vs=51301&id=51642

REVISION DETAIL
  https://phabricator.kde.org/D18892

AFFECTED FILES
  kcms/lookandfeel/kcm_lookandfeel.desktop

To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson
Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18892: Move Look and Feel KCM to top level

[Björn Feber]

GB_2 added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18892

To: GB_2, #plasma, #vdg, rooty, ngraham, davidedmundson, abetts
Cc: ngraham, davidedmundson, abetts, rooty, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Björn Feber]

GB_2 added a comment.


  Oops

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.


  In D18903#411538 , @ngraham wrote:
  
  > In D18903#411529 , @filipf wrote:
  >
  > > For this patch (and moving forward) we still have 2 dilemmas left then:
  > >
  > > - remove the article -> "Configure system fonts" instead of "Configure 
the system fonts"?
  >
  >
  > My recommendation:
  >
  > - For the UI-related font KCM: "Choose user interface fonts" or something 
like that
  > - For the font installer KCM, we could expose some more of its power via 
the tooltip and make the comment something more like "Install, manage, and 
organize system fonts"
  >
  > > - capitalize Look and Feel? Or just do "Choose (the) look and feel theme"?
  >
  > For the title, "Look And Feel" is good. For the tooltip, my recommendation 
is "Choose the Look and Feel theme".
  
  
  In the tooltip Look and Feel should be lowercase, then it's correct.
  Other theme types are lowercase too and it's not a brand.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Björn Feber]

GB_2 added a comment.


  We currently use the KAboutData name in headers, we can easily change them to 
real titles and leave the desktop files how they are currently (explanation 
sentences). Should we just use the KCM name in the header or something more 
explaining like "Look and Feel Theme Selection"?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18903: Make Appearance KCMs' labels consistent

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Perfect!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  516-appearance-header-labels (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18903

To: filipf, GB_2, #vdg, ngraham, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18892: Move Look and Feel KCM to top level

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Moves the LnF KCM from the Workspace Theme category to the top level (to the 
Appearance section), because:
  
  - the KCM affects everything, not just workspace themes
  - then it's faster to discover the KCM and go to it
  
  It won't affect any other KCMs, so this change should be fine.
  Also see T8871 .
  F6604946: Look and Feel KCM in Top Level.png 


TEST PLAN
  Open the system settings.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  move-look-and-feel-kcm-to-top-level (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18892

AFFECTED FILES
  kcms/lookandfeel/kcm_lookandfeel.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the look of the Fonts KCM UI

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9dac09af4a02: Improve the look of the Fonts KCM UI 
(authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18861?vs=51274&id=51300

REVISION DETAIL
  https://phabricator.kde.org/D18861

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/kxftconfig.cpp
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham, rooty, davidedmundson
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the look of the Fonts KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 51274.
GB_2 added a comment.


  Show pt after font size and remove seperator in the font preview. Also apply 
the KDE HIG even more.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18861?vs=51213&id=51274

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/kxftconfig.cpp
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham, rooty, davidedmundson
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 added a comment.


  In D18861#408459 , @davidedmundson 
wrote:
  
  > Please use more descriptive messages than "Improve the blahblah". 
  >  Practically every single commit aims to improve the product.
  
  
  I added the word UI, what do you suggest as a title?
  I can't think of anything better, because this changes many different things.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 added a comment.


  What about `Noto Sans 10pt`?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18861

To: GB_2, #plasma, #vdg, ngraham, rooty
Cc: ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 51213.
GB_2 added a comment.


  Change "Force fonts DPI" checkbox text to "Force font DPI"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18861?vs=51211&id=51213

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: rooty, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18861: Improve the Fonts KCM UI

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Makes some improvements to the Fonts KCM UI, like applying the KDE HIG, 
adding icons and tooltips to buttons and improrving the buttons, updating 
strings and more.
  F6602139: Improved Fonts KCM UI.png 

TEST PLAN
  Open the Fonts KCM.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18861

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/kcm_fonts.desktop
  kcms/fonts/package/contents/ui/FontWidget.qml
  kcms/fonts/package/contents/ui/main.qml
  kcms/fonts/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18785: Use different Font Management KCM "All Fonts" icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e5ef9c97e75e: Use different Font Management KCM "All 
Fonts" icon (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18785?vs=51115&id=51162

REVISION DETAIL
  https://phabricator.kde.org/D18785

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/GroupList.cpp

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18785: Use different Font Management KCM "All Fonts" icon

[Björn Feber]

GB_2 updated this revision to Diff 51115.
GB_2 added a comment.


  Use new icon "font"

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18785?vs=51032&id=51115

BRANCH
  use-different-font-management-all-fonts-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18785

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/GroupList.cpp

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

[Björn Feber]

GB_2 added a comment.


  In D18797#407129 , @ngraham wrote:
  
  > So if this isn't an acceptable solution, then what we need to do is remove 
all the 22px monochrome versions of icons that have colorful 32px-and-larger 
versions.
  
  
  What I proposed in T10413  :-)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D18797

To: ngraham, #vdg
Cc: GB_2, broulik, rooty, ndavis, davidedmundson, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18785: Use different Font Management KCM "All Fonts" icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Needed for D18702 .
  F6591513: New Font Management All Fonts Icon.png 


TEST PLAN
  Open the Font Management KCM.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  use-different-font-management-all-fonts-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18785

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/GroupList.cpp

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18682: Update Breeze Dark Look and Feel theme previews

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:2750e07e4e00: Update Breeze Dark Look and Feel theme 
previews (authored by GB_2).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18682?vs=50762&id=50766

REVISION DETAIL
  https://phabricator.kde.org/D18682

AFFECTED FILES
  lookandfeel.dark/contents/previews/fullscreenpreview.jpg
  lookandfeel.dark/contents/previews/preview.png

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18681: Update Breeze Look and Feel theme previews

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ba642873f40f: Update Breeze Look and Feel theme previews 
(authored by GB_2).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18681?vs=50761&id=50765

REVISION DETAIL
  https://phabricator.kde.org/D18681

AFFECTED FILES
  lookandfeel/contents/previews/fullscreenpreview.jpg
  lookandfeel/contents/previews/lockscreen.png
  lookandfeel/contents/previews/preview.png
  lookandfeel/contents/previews/splash.png

To: GB_2, #plasma, #vdg, ngraham
Cc: abetts, ngraham, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18682: Update Breeze Dark Look and Feel theme previews

[Björn Feber]

GB_2 updated this revision to Diff 50762.
GB_2 added a comment.


  Improve Look and Feel theme previews

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18682?vs=50738&id=50762

BRANCH
  update-breezedark-lookandfeel-theme-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18682

AFFECTED FILES
  lookandfeel.dark/contents/previews/fullscreenpreview.jpg
  lookandfeel.dark/contents/previews/preview.png

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18681: Update Breeze Look and Feel theme previews

[Björn Feber]

GB_2 updated this revision to Diff 50761.
GB_2 added a comment.


  Improve Look and Feel theme previews

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18681?vs=50737&id=50761

BRANCH
  update-breeze-lookandfeel-theme-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18681

AFFECTED FILES
  lookandfeel/contents/previews/fullscreenpreview.jpg
  lookandfeel/contents/previews/lockscreen.png
  lookandfeel/contents/previews/preview.png
  lookandfeel/contents/previews/splash.png

To: GB_2, #plasma, #vdg, ngraham
Cc: abetts, ngraham, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18419: Adjust some KCMs to implement new Appearance section layout

[Björn Feber]

GB_2 added a comment.


  I think we should really move the LnF KCM to the top level now since it 
affects everything. Doing that is safe IMO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18681: Update Breeze Look and Feel theme previews

[Björn Feber]

GB_2 added a comment.


  In D18681#404092 , @abetts wrote:
  
  > Maybe I am asking for a lot... but could these be animated and show what 
the splash screen does? Maybe a gif animation on hover?
  
  
  There's already the preview button that shows the splash when you click on it.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  update-breeze-lookandfeel-theme-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18681

To: GB_2, #plasma, #vdg, ngraham
Cc: abetts, ngraham, rooty, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18682: Update Breeze Dark Look and Feel theme previews

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Update and improve some old Breeze Dark Look and Feel theme previews (similar 
to D18681 ).
  F6583315: Updated Breeze Look and Feel Theme Previews.png 


TEST PLAN
  Open the Look and Feel KCM.

REPOSITORY
  R31 Breeze

BRANCH
  update-breezedark-lookandfeel-theme-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18682

AFFECTED FILES
  lookandfeel.dark/contents/previews/fullscreenpreview.jpg
  lookandfeel.dark/contents/previews/preview.png

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18681: Update Breeze Look and Feel theme previews

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Update and improve some old Breeze Look and Feel theme previews (the Breeze 
Dark previews will be updated in a different revision, because it is in a 
different repo).
  F6583315: Updated Breeze Look and Feel Theme Previews.png 


TEST PLAN
  Open the Look and Feel KCM and the Splash Screen KCM.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  update-breeze-lookandfeel-theme-previews (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18681

AFFECTED FILES
  lookandfeel/contents/previews/fullscreenpreview.jpg
  lookandfeel/contents/previews/lockscreen.png
  lookandfeel/contents/previews/preview.png
  lookandfeel/contents/previews/splash.png

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18677: Change workspace theme category icon

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:4ef5a0b01421: Change workspace theme category icon 
(authored by GB_2).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18677?vs=50726&id=50728

REVISION DETAIL
  https://phabricator.kde.org/D18677

AFFECTED FILES
  categories/settings-appearance-workspacetheme.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18677: Change workspace theme category icon

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use a proper workspace theme icon for the workspace theme category.
  F6583141: Workspace Theme Category Icon.png 


TEST PLAN
  Open the system settings.

REPOSITORY
  R124 System Settings

BRANCH
  change-workspacetheme-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18677

AFFECTED FILES
  categories/settings-appearance-workspacetheme.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18559: Use correct sidebar back button press color

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:cad722aa0fa0: Use correct sidebar back button press color 
(authored by GB_2).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18559?vs=50363&id=50651

REVISION DETAIL
  https://phabricator.kde.org/D18559

AFFECTED FILES
  sidebar/package/contents/ui/SubCategoryPage.qml

To: GB_2, #plasma, #vdg, davidedmundson, ngraham
Cc: ngraham, plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18561: Use same intro page system settings icon as in the desktop file

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:d5740e73d070: Use same intro page system settings icon as 
in the desktop file (authored by GB_2).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18561?vs=50365&id=50652

REVISION DETAIL
  https://phabricator.kde.org/D18561

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18561: Use same intro page system settings icon as in the desktop file

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Use the same system settings icon in the intro page that is used in the 
desktop file for consistency and compatibilty with other icon themes.

TEST PLAN
  Open the system settings (maybe also with a different icon theme).

REPOSITORY
  R124 System Settings

BRANCH
  use-same-intropage-systemsettings-icon-as-in-desktop-file (branched from 
master)

REVISION DETAIL
  https://phabricator.kde.org/D18561

AFFECTED FILES
  sidebar/package/contents/ui/introPage.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18559: Use correct sidebar back button press color

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The system settings currently use a wrong sidebar back button press color, 
which can look very bad on some color schemes (for example Breeze Light), this 
fixes it.
  Before:
  F6569998: Wrong Back Button Press Color.png 

  
  After:
  F656: Correct Back Button Press Color.png 


TEST PLAN
  Open the system settings, click on any category and then press the back 
button.

REPOSITORY
  R124 System Settings

BRANCH
  use-correct-sidebar-back-button-press-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18559

AFFECTED FILES
  sidebar/package/contents/ui/SubCategoryPage.qml

To: GB_2, #plasma, #vdg
Cc: plasma-devel, #vdg, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18546: [Desktop Toolbox] Use "tools" icon

[Björn Feber]

GB_2 added a comment.


  In D18546#400253 , @hein wrote:
  
  > How about we actually rename it "Desktop Menu".
  
  
  +1, good idea!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18546

To: ngraham, #vdg, #plasma
Cc: GB_2, hein, ndavis, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18528: [Desktop Toolbox] Use a clearer name when the label is shown

[Björn Feber]

GB_2 added a comment.


  Looks good!

INLINE COMMENTS

> ToolBoxButton.qml:30
>  
> -property string text: main.Plasmoid.activityName
> +property string text: main.Plasmoid.activityName == i18n("Default") ? 
> i18n("Desktop Toolbox") : i18n("Desktop Toolbox - %1 Activity", 
> main.Plasmoid.activityName)
>  property bool isCorner: !buttonMouse.dragging &&

I think we should use this dash "—" instead of "-" for consistency.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  desktop-toolbox-clearer-naming (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18528

To: ngraham, #vdg, #plasma, hein
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18419: Adjust some KCMs to implement new Appearance section layout

[Björn Feber]

GB_2 added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18419

To: ngraham, #vdg, #plasma, davidedmundson
Cc: GB_2, abetts, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Björn Feber]

GB_2 added a comment.


  Thanks!
  Looks good!

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18504: [plasma-nm/applet] Add right-click context menu to directly customize a connection

[Björn Feber]

GB_2 added a comment.


  Next time please upload images directly to Phabricator.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18504

To: vpilo, #vdg
Cc: GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12278: [Colors KCM] Port to new design

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> colors.cpp:58
> +
> +KAboutData *about = new KAboutData(QStringLiteral("kcm_colors"), 
> i18n("Configure color schemes"),
> +   QStringLiteral("2.0"), QString(), 
> KAboutLicense::GPL);

Better: "Choose the color scheme"

> kcm_colors.desktop:106
>  
>  Comment=Application Color Scheme
>  Comment[ca]=Esquema de color de les aplicacions

Better: "Choose the color scheme"

> main.qml:30
> +KCM.GridViewKCM {
> +KCM.ConfigModule.quickHelp: i18n("This module lets you configure the 
> color scheme of applications.")
> +

Better: "This module lets you choose the color scheme."

> metadata.desktop:3
> +Name=Colors
> +Comment=Application Color Scheme
> +

Better: "Choose the color scheme"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: GB_2, nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-devel, 
jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol

D18381: Add tooltip to configure panel button

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7a08f3d135c5: Add tooltip to configure panel button 
(authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18381?vs=49870&id=49918

REVISION DETAIL
  https://phabricator.kde.org/D18381

AFFECTED FILES
  toolboxes/paneltoolbox/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ndavis, ngraham
Cc: Codezela, ngraham, ndavis, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18381: Add tooltip to configure panel button

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Adds a tooltip to the configure panel button.
  F6556503: Configure Panel Tooltip.png 

TEST PLAN
  Hover over the configure panel button

REPOSITORY
  R119 Plasma Desktop

BRANCH
  add-configure-panel-tooltip (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18381

AFFECTED FILES
  toolboxes/paneltoolbox/contents/ui/main.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18269: Improve the Splash Screen KCM

[Björn Feber]

GB_2 added a comment.


  In D18269#393711 , @ngraham wrote:
  
  > In general, you should wait until all reviewers with an open "Changes 
Requested" status have changed it to "Accepted" before landing a patch.
  
  
  Ok, sorry.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18269

To: GB_2, #plasma, #vdg, davidedmundson, ngraham
Cc: davidedmundson, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18269: Improve the Splash Screen KCM

[Björn Feber]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:fd94db08a555: Improve the Splash Screen KCM (authored by 
GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18269?vs=49544&id=49545

REVISION DETAIL
  https://phabricator.kde.org/D18269

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm_splashscreen.desktop
  kcms/ksplash/package/contents/ui/main.qml
  kcms/ksplash/package/metadata.desktop

To: GB_2, #plasma, #vdg, davidedmundson, ngraham
Cc: davidedmundson, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18269: Improve the Splash Screen KCM

[Björn Feber]

GB_2 updated this revision to Diff 49544.
GB_2 added a comment.


  Use old icon `preferences-system-splash`

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18269?vs=49541&id=49544

BRANCH
  improve-splashscreen-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18269

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm_splashscreen.desktop
  kcms/ksplash/package/contents/ui/main.qml
  kcms/ksplash/package/metadata.desktop

To: GB_2, #plasma, #vdg, davidedmundson
Cc: davidedmundson, ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18269: Improve the Splash Screen KCM

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> GB_2 wrote in kcm_splashscreen.desktop:2
> Yes, I just used it because I think it should be included in Plasma 5.15 and 
> it is the closest to a login splash icon I could find.

BTW, the Plymouth Splash KCM just uses an empty screen icon.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18269

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18269: Improve the Splash Screen KCM

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> ngraham wrote in kcm_splashscreen.desktop:2
> I know you're making this change because we don't actually have a 
> `preferences-system-splash` icon, but is this really semantically correct? It 
> seems like we should actually create that icon, or maybe make 
> `preferences-system-login` a symlink to it for now.
> 
> Of course that's a frameworks change, so it wouldn't get done in time for the 
> Plasma 5.15 release...

Yes, I just used it because I think it should be included in Plasma 5.15 and it 
is the closest to a login splash icon I could find.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18269

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18269: Improve the Splash Screen KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Similar to D18206 .
  The Splash Screen KCM has some inconsistencies and doesn't always apply the 
KDE HIG, so this fixes it and makes some other improvements.

TEST PLAN
  Open the Splash Screen KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-splashscreen-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18269

AFFECTED FILES
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm_splashscreen.desktop
  kcms/ksplash/package/contents/ui/main.qml
  kcms/ksplash/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e0a4d3fa415d: Improve the Cursor Theme KCM (authored by 
GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18267?vs=49536&id=49540

REVISION DETAIL
  https://phabricator.kde.org/D18267

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Björn Feber]

GB_2 added a comment.


  In D18267#393635 , @ngraham wrote:
  
  > In D18267#393620 , 
@davidedmundson wrote:
  >
  > > > In the tooltip and header on the page
  > >
  > >
  > >
  > > > In the description of the KCM when you hover over it.
  > >
  > > Both those are taken from kcm_cursortheme.desktop surely.
  >
  >
  > Yeah, but if we change it there, we should make sure that 
`metadata.desktop` is updated too, right?
  
  
  Yes, this also wasn't a problem with the other patches.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Björn Feber]

GB_2 added a comment.


  In D18267#393604 , @davidedmundson 
wrote:
  
  > Try to stick to titles that aren't "improve" as that literally covers every 
patch (or at least, you'd hope so)
  
  
  Ok, there is one more patch that I will make with this name though, since I 
already used this name and description for the other ones too.

INLINE COMMENTS

> davidedmundson wrote in metadata.desktop:63
> Where is this string visible?

In the description of the KCM when you hover over it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18267: Improve the Cursor Theme KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The Cursor Theme KCM has some inconsistencies and doesn't always apply the 
KDE HIG, so this fixes it and makes some other improvements.

TEST PLAN
  Open the Cursor Theme KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-cursortheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18267

AFFECTED FILES
  kcms/cursortheme/kcm_cursortheme.desktop
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/cursortheme/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2015bad98e64: Improve Desktop/Plasma Theme KCM (authored 
by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18247?vs=49453&id=49461

REVISION DETAIL
  https://phabricator.kde.org/D18247

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

GB_2 added a comment.


  In D18247#393021 , @davidedmundson 
wrote:
  
  > > The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and
  >
  > Where?
  >
  > > renames the KCM to "Plasma Theme".
  >
  > I can only see this.
  
  
  Wrong description, icon and text capitalization.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18247

To: GB_2, #plasma, #vdg
Cc: davidedmundson, #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D18247: Improve Desktop/Plasma Theme KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Similar to D18206 .
  The Desktop/Plasma Theme KCM has some inconsistencies and doesn't always 
apply the KDE HIG, so this fixes it, makes some other improvements and renames 
the KCM to "Plasma Theme".

TEST PLAN
  Open the Desktop/Plasma Theme KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-desktoptheme-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18247

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm_desktoptheme.desktop
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/desktoptheme/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, sukalyanbanga, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:beca304a1f44: Improve the Look and Feel KCM (authored by 
GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18206?vs=49321&id=49374

REVISION DETAIL
  https://phabricator.kde.org/D18206

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, rooty, rizzitello, abetts, filipf, #vdg, plasma-devel, #plasma, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D18206: Improve the Look and Feel KCM

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  The LnF KCM has some inconsistencies and doesn't always apply the KDE HIG, so 
this fixes that and makes some other improvements.
  F6546516: LnF KCM.png 

TEST PLAN
  Open the LnF KCM

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-lookandfeel-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18206

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp
  kcms/lookandfeel/kcm_lookandfeel.desktop
  kcms/lookandfeel/package/contents/ui/main.qml
  kcms/lookandfeel/package/metadata.desktop

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18048: [Connections] Add search ellipsis to network connection search

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:9c7de905eab3: [Connections] Add search ellipsis to 
network connection search (authored by Krešimir Čohar , 
committed by GB_2).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18048?vs=48879&id=49263

REVISION DETAIL
  https://phabricator.kde.org/D18048

AFFECTED FILES
  kcm/qml/main.qml

To: rooty, #vdg, #plasma, ngraham
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18047: [plasma-desktop] Add search ellipsis to Font Management and Date and Time

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c52d93976e60: [plasma-desktop] Add search ellipsis to 
Font Management and Date and Time (authored by Krešimir Čohar 
, committed by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18047?vs=48878&id=49261

REVISION DETAIL
  https://phabricator.kde.org/D18047

AFFECTED FILES
  kcms/dateandtime/dateandtime.ui
  kcms/kfontinst/kcmfontinst/FontFilter.cpp

To: rooty, #vdg, #plasma, ngraham
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18044: [kde-cli-tools] Add search ellipsis to label, make label more consistent with HIG

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:d8069f6fcbde: [kde-cli-tools] Add search ellipsis to 
label, make label more consistent with… (authored by Krešimir Čohar 
, committed by GB_2).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18044?vs=48873&id=49257

REVISION DETAIL
  https://phabricator.kde.org/D18044

AFFECTED FILES
  keditfiletype/filetypesview.cpp

To: rooty, #vdg, #plasma, plasma-devel, ngraham
Cc: ngraham, apol, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18005: Include only the largest size for each wallpaper

[Björn Feber]

GB_2 added a comment.


  @cfeck had a good idea:
  
  In D18005#387519 , @cfeck wrote:
  
  > Maybe symlinking all to the largest version?

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: GB_2, mart, rooty, sitter, rikmills, filipf, davidedmundson, cfeck, ndavis, 
plasma-devel, kvanton, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D18016: Don't use hardcoded background color

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Fixes the hardcoded SDDM theme preview background color
  F6530004: SDDM KCM Breeze.png 
  F6530005: SDDM KCM Breeze Dark.png 

TEST PLAN
  Open the SDDM KCM

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18016

AFFECTED FILES
  src/qml/main.qml

To: GB_2, #vdg, #breeze
Cc: #breeze, plasma-devel, #vdg, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18012: [SDDM theme] Update the theme preview

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a3bbdef02ad8: [SDDM theme] Update the theme preview 
(authored by filipf, committed by GB_2).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18012?vs=48796&id=48802

REVISION DETAIL
  https://phabricator.kde.org/D18012

AFFECTED FILES
  sddm-theme/preview.png

To: filipf, #plasma, #vdg, #breeze, GB_2, ngraham
Cc: ngraham, GB_2, oussemabouaneni, plasma-devel, kvanton, jraleigh, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18012: [SDDM theme] Update the theme preview

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  +1, updated and looks much better

REPOSITORY
  R120 Plasma Workspace

BRANCH
  new-sddm-preview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18012

To: filipf, #plasma, #vdg, #breeze, GB_2
Cc: GB_2, oussemabouaneni, plasma-devel, kvanton, jraleigh, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

[Björn Feber]

GB_2 added a comment.


  In D17963#386701 , @ngraham wrote:
  
  > Hmm, this results in the menu having one colored icon and two monochrome 
icons.
  >
  > My gut feeling is that if we're going to use KMenuEdit's icon, perhaps we 
should mention it by name, e.g. "Edit Applications with KMenuEdit".
  >
  > If we don't want to do that, or we can't because invoking the menu item 
might actually open some other app instead of KMenuEdit, then the `edit-entry` 
icon might be more appropriate.
  >
  > Thoughts?
  
  
  I just used the same icon that is used here and in some other places for 
consistency: F6526257: Kickoff Application Right Click Context Menu.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17963

To: GB_2, #plasma, #vdg, davidedmundson
Cc: ngraham, #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:f29c04572c06: [Kicker and Kickoff] Use an icon for the 
"Edit Applications..." menu entry (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17963?vs=48673&id=48674

REVISION DETAIL
  https://phabricator.kde.org/D17963

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/Kickoff.qml

To: GB_2, #plasma, #vdg, davidedmundson
Cc: #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17963: [Kicker and Kickoff] Use an icon for the "Edit Applications..." menu entry

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  This adds an icon to the "Edit Applications..." menu entry to make it look 
better.
  F6525011: Edit Applications Menu Entry Icon.png 


TEST PLAN
  Open the right click context menu for Kicker or Kickoff

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17963

AFFECTED FILES
  applets/kicker/package/contents/ui/main.qml
  applets/kickoff/package/contents/ui/Kickoff.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, kvanton, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:510c88f65b76: [Kickoff] Increase Kickoff information 
label readability (authored by Krešimir Čohar , 
committed by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17934?vs=48644&id=48659

REVISION DETAIL
  https://phabricator.kde.org/D17934

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, ngraham, #vdg, #plasma, GB_2
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Looks better now!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  centered-infolabel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma, GB_2
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Björn Feber]

GB_2 added a comment.


  In D17934#386050 , @ngraham wrote:
  
  > The opacity change makes sense to me: since this text isn't visible by 
default, there's no reason to make it difficult to read with a low opacity. If 
you go hunting for it and want to see it, you want it to be readable!
  >
  > The alignment change I'm not as sure about. Because the username and 
information label are different sizes, I deliberately used bottom alignment to 
avoid having the system information label appear to jump up when hovering on 
it. With your change, the jumpiness is re-introduced:
  >
  > F6523443: Peek 2019-01-03 14-15.gif 
  >
  > Thoughts/ideas?
  
  
  I agree, it's better if it is left how it was before.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: GB_2, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17935: [Clipboard] Use ellipsis in the search field label ('Search...' instead of 'Search')

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d066eb8cbd85: [Clipboard] Use ellipsis in the search 
field label ('Search...' instead of… (authored by Krešimir Čohar 
, committed by GB_2).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17935?vs=48581&id=48619

REVISION DETAIL
  https://phabricator.kde.org/D17935

AFFECTED FILES
  applets/clipboard/contents/ui/ClipboardPage.qml

To: rooty, ngraham, #plasma, #vdg
Cc: abetts, filipf, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12278: WIP: [Colors KCM] Port to new design

[Björn Feber]

GB_2 added a comment.


  > This removes the "Apply to non-Qt applications checkbox" which isn't 
something one should uncheck.
  
  I disagree. I even think it should be disabled by default, because it causes 
issues in GTK 2 apps such as this: https://i.stack.imgur.com/jpeYm.jpg
  I think it is not needed, because the GTK 2 theme already defines which 
colors are used and that should not be overwritten because of the issues.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: GB_2, nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D17622: [Panel Edit Mode] Show screen edge button and panel size button tooltips immediately after click

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
GB_2 added projects: Plasma, VDG.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  This sets the delay of the tooltips added in D17323 
 to 0, so they are immediately shown when 
you click on the buttons.

TEST PLAN
  Click on the two buttons in the Panel Edit Mode.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17622

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

[Björn Feber]

GB_2 updated this revision to Diff 47615.
GB_2 added a comment.


  Remove unneeded line.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17321?vs=46739&id=47615

REVISION DETAIL
  https://phabricator.kde.org/D17321

AFFECTED FILES
  toolboxes/paneltoolbox/contents/ui/main.qml

To: GB_2, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#374062 , @davidedmundson 
wrote:
  
  > > I'm trying to emit the signal contextualActionsAboutToShow in the (QML) 
onVisualParentChanged function, but it doesn't work...
  >
  > Use console.log to check your code is being called at the right time.
  >  Also search for contextualActionsAboutToShow in other code and then you'll 
have a reference you can copy.
  
  
  It is being called at the right time (I can see the output):
  
onVisualParentChanged: {
if (visualParent) {
...
console.log("Call contextualActionsAboutToShow");
currentApplet.applet.contextualActionsAboutToShow();
}
}
  
  And it should only show the button if there are specific alternatives:
  
PlasmaComponents.ToolButton {
id: alternativesButton
...
visible: currentApplet.applet.action("alternatives").visible
...
}
  
  But it doesn't work, it prints out `Cannot read property 'applet' of null` 
and `currentApplet.applet.action("alternatives").visible` is always `false`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17321: Change panel edit mode icon from from a hamburger icon to a configure icon

[Björn Feber]

GB_2 requested review of this revision.
GB_2 added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.qml:58
> This doesn't make sense..
> 
> We're re-evaulating because hasElement might have changed when switching 
> themes.

So just remove the line?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17321

To: GB_2, #plasma, #vdg, ngraham, davidedmundson
Cc: davidedmundson, abetts, ngraham, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, sebas, apol, mbohlender, mart

D17574: Remove period ( . ) character from the end

[Björn Feber]

GB_2 added a comment.


  The two images need to be swapped.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17574

To: shubham, #plasma, #vdg, mart
Cc: GB_2, plasma-devel, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  I'm trying to emit the signal contextualActionsAboutToShow in the (QML) 
onVisualParentChanged function, but it doesn't work...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, 
skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, mbohlender, mart

D17440: Rotate busy indicator clockwise

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Breeze, VDG.
GB_2 added projects: Breeze, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  Most loading/refresh icons have a circular arrow pointing clockwise, but the 
busy indicator is currently rotated counterclockwise. This changes it to rotate 
clockwise.
  How most loading/refresh icons look like:
  F6464496: Loading Icon Example.png 

TEST PLAN
  Use an icon theme with this kind of loading/refresh icon (such as "Papirus", 
"Adwaita" or "Antü") , open Discover and click on for example "Plasma Addons". 
At the bottom you can then see the busy indicator.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D17440

AFFECTED FILES
  org.kde.desktop/BusyIndicator.qml

To: GB_2, #breeze, #vdg
Cc: #vdg, plasma-devel, #breeze, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#373036 , @ngraham wrote:
  
  > Neat, it seems to generally work well. I notice that when I click the new 
menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we 
could make it not do that, so it would stay in panel edit mode if invoked while 
in panel edit mode.
  
  
  I can't find where that is implemented and I think it shouldn't be included 
here, because it exits the panel edit mode when it looses it's focus.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, 
trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

[Björn Feber]

GB_2 updated this revision to Diff 47058.
GB_2 added a comment.


  Hide the tooltip if you click on it.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47045&id=47058

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, 
plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

[Björn Feber]

GB_2 added a comment.


  It's okay :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, 
plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

[Björn Feber]

GB_2 added a comment.


  In D17323#372752 , @Codezela wrote:
  
  > when resizing the panel can we show the width of it
  >  48px ,36px etc
  >  because now when I resize the panel I guess what better visually
  >  but if I know the size exactly It will much better
  >  like all other panels latte dock for example
  
  
  It does that already:
  F6461758: Panel Edit Mode Buttons (5).png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg, ngraham
Cc: Codezela, davidedmundson, matheusm, ngraham, trickyricky26, #vdg, 
plasma-devel, #plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, 
ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 updated this revision to Diff 47054.
GB_2 added a comment.


  Update TODO text.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=47051&id=47054

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
GB_2 added projects: Plasma, VDG.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  There is a configure button and an alternatives button in the context menu of 
an applet, but there is no alternatives button in the popup/overlay of an 
applet in the panel edit mode, so this adds that button, to make it more 
consistent and easier to find.
  F6461739: Alternatives Button in Applet Configuration in Panel Edit Mode.png 


TEST PLAN
  Hover over an applet in the panel edit mode.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

[Björn Feber]

GB_2 updated this revision to Diff 47045.
GB_2 added a comment.


  Fix tooltip text color (for real this time).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47041&id=47045

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

[Björn Feber]

GB_2 updated this revision to Diff 47041.
GB_2 added a comment.


  Fix text color.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47038&id=47041

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: [Panel Edit Mode] Change screen edge button hover cursor, add icons to screen edge button and panel size button, add tooltips

[Björn Feber]

GB_2 updated this revision to Diff 47038.
GB_2 added a comment.


  Improve wording.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47033&id=47038

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg, ngraham
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 47033.
GB_2 added a comment.


  Add tooltip for the resize button, change tooltip text and increase tooltip 
timeout.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47011&id=47033

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 47011.
GB_2 added a comment.


  Increase tooltip timeout.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=47010&id=47011

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 47010.
GB_2 added a comment.


  Improve code and add tooltip timeout.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46973&id=47010

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 46973.
GB_2 added a comment.


  Add import.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46972&id=46973

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Oops, forgot the import...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 46972.
GB_2 added a comment.


  Use QQC2 tooltip.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46971&id=46972

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 46971.
GB_2 added a comment.


  Added the tooltip.
  F6459564: Panel Edit Mode Buttons (3).png 

  It is ready now!

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46749&id=46971

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: davidedmundson, matheusm, ngraham, trickyricky26, #vdg, plasma-devel, 
#plasma, alexde, IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Ok, number two then.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Because https://phabricator.kde.org/D17355 is currently not working properly, 
we have two options:
  
  1. Small "Height/Width" button
  
  F6458263: Panel Edit Mode Buttons (1).png 

  
  2. Align "Height/Width" button contents on the left side
  
  F6458265: Panel Edit Mode Buttons (2).png 

  
  And yes, I will still add the tooltip.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Waiting for https://phabricator.kde.org/D17355

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  I managed to fix it, but it the Plasma QML Button code needs to be changed. 
Should I create a new Phabricator revision or add it here?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Hmm... when a button has an icon the content gets aligned on the left and I 
can't find a way to change it...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  Oh, you mean the button content...
  I will try to fix that!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 updated this revision to Diff 46749.
GB_2 edited the summary of this revision.
GB_2 added a comment.


  Update panel size button icons.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17323?vs=46741&id=46749

REVISION DETAIL
  https://phabricator.kde.org/D17323

AFFECTED FILES
  desktoppackage/contents/configuration/panelconfiguration/EdgeHandle.qml
  desktoppackage/contents/configuration/panelconfiguration/SizeHandle.qml

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17323: Panel edit mode: change screen edge button hover cursor, add icons to screen edge button and panel size button

[Björn Feber]

GB_2 added a comment.


  In D17323#370411 , @matheusm wrote:
  
  > +1, but why aren't the buttons content centered?
  
  
  They are, do you think that because of the screenshot?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17323

To: GB_2, #plasma, #vdg
Cc: matheusm, ngraham, trickyricky26, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart