Re: Review Request 119116: KRunner: Show a "Configure" button on the side
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119116/#review61628 --- This review has been submitted with commit 947867cdb77c99cdccff38c37a254e28a9308d36 by Vishesh Handa to branch master. - Commit Hook On July 4, 2014, 4:11 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119116/ > --- > > (Updated July 4, 2014, 4:11 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Just like what krunner4 had > > > Diffs > - > > krunner/view.h 86788f8 > krunner/view.cpp 488b342 > lookandfeel/contents/runcommand/RunCommand.qml 870ba86 > > Diff: https://git.reviewboard.kde.org/r/119116/diff/ > > > Testing > --- > > > File Attachments > > > krunner_withconfig.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/07/04/32a97211-153a-4f42-b5bf-9ed4560acb34__krunner_withconfig.png > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119103: Startkde: Remove KLOCALE_LANGUAGES
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119103/#review61594 --- This review has been submitted with commit 7a6ef7aaf9cc32173ea61b4f71c802da5c6ac3d2 by Vishesh Handa to branch master. - Commit Hook On July 3, 2014, 11:25 a.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119103/ > --- > > (Updated July 3, 2014, 11:25 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Startkde: Remove KLOCALE_LANGUAGES > > KLOCALE_LANGUAGES was used by the kde4 ksplash in order to to know which > language to show. This environment variable is no longer used by the qml > based ksplash. It makes no sense to have it. > > Additionally, this means we can stop linking against kdelibs4support. > This is important cause kdostartupconfig blocks the rest of the boot > sequence. On my system it causes a good 0.3 - 0.4 seconds delay. By no > longer linking to kdelibs4support it takes less than 0.1 seconds and no > longer shows up in the bootchat logs. > > > Diffs > - > > startkde/kstartupconfig/CMakeLists.txt 6920fe5 > startkde/kstartupconfig/kdostartupconfig.cpp d545f4f > startkde/startkde.cmake 40e3377 > > Diff: https://git.reviewboard.kde.org/r/119103/diff/ > > > Testing > --- > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119105: PlasmaShell: Disable Session Management
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119105/#review61593 --- This review has been submitted with commit 7652d581921c355135be41ec205d85b1d21c1590 by Vishesh Handa to branch master. - Commit Hook On July 3, 2014, 3:42 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119105/ > --- > > (Updated July 3, 2014, 3:42 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > PlasmaShell: Disable Session Management > > PlasmaShell should not be restored by the session manager. It will be > started by klauncher because we install an autostart file. > > This also clears up the booting process to a certain extent, as > plasmashell will now not be started twice (once via session restore, and > once via autostart) > > > Diffs > - > > shell/main.cpp 0b96674 > > Diff: https://git.reviewboard.kde.org/r/119105/diff/ > > > Testing > --- > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118977: KSMServer: Do not autostart files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118977/#review61592 --- This review has been submitted with commit f913e251fe66e22606c380a8cc0ddc8c69e3c07d by Vishesh Handa to branch master. - Commit Hook On July 3, 2014, 12:14 a.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118977/ > --- > > (Updated July 3, 2014, 12:14 a.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Bugs: 335878 > https://bugs.kde.org/show_bug.cgi?id=335878 > > > Repository: plasma-workspace > > > Description > --- > > KSMServer: Do not autostart files > > Currently KLauncher is responsible for starting all of the autostart > files. It intelligently starts only the files which should be started in > the KDE environment. > > Once this is done, KLauncher then decides to also start all the files > in the autostart folder, but does that without checking which should be > started. I'm not sure why both KSMServer and KLauncher are overlaping > and doing the same thing. But it seems that KLauncher is the correct > place to do this. Specially since ksmserver uses kioclient5 in order to > start the applications. > > BUG: 335878 > > > Diffs > - > > ksmserver/server.h 3d19118 > ksmserver/startup.cpp 11cc968 > > Diff: https://git.reviewboard.kde.org/r/118977/diff/ > > > Testing > --- > > Applications are now only started once. > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119062: Add a script to enforce window decorations for GTK windows
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119062/#review61562 --- This review has been submitted with commit f0e1e3187e4be7c09cbbbce1bb481fea3ffe7ce3 by Martin Gräßlin to branch master. - Commit Hook On July 1, 2014, 2:53 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119062/ > --- > > (Updated July 1, 2014, 2:53 p.m.) > > > Review request for kwin, Plasma and Hugo Pereira Da Costa. > > > Repository: kwin > > > Description > --- > > Add a script to enforce window decorations for GTK windows > > This is going to be a controversal change. It enforces KWin decorations > on all client side decorated windows from GTK+. Unfortunately we are > caught between a rock and a hard place. Keeping the status quo means > having broken windows and a more or less broken window manager due to > GTK+ including the shadow in the windows. This is no solution. > Enforcing server side decorations visually breaks the windows. This is > also no solution. So why do it? > > It's our task to provide the best possible user experience and KWin is > a window manager which has always done great efforts to fix misbehaving > windows. One can think of the focus stealing prevention, the window rules > and lately the scripts. The best possible window management experience is > our aim. This means we cannot leave the users with the broken windows > from GTK. > > The issues we noticed were reported to GTK+ about 2 months ago and we are > working on improving the situation. Unfortunately several issues are not > yet addressed and others will only be addressed in the next GTK+ release. > We are working on improving the NETWM spec (see [1]) to ensure that the > client side decorated windows are not in a broken state. This means the > enforcment is a temporary solution and will be re-evaluated with the next > GTK release. I would prefer to not have to do such a change, if some of > the bugs were fixed or GTK+ would not use client-side-decos on wms not > yet supporting those all of this would be a no issue. > > For a complete list of the problems caused by GTK's decos see bug [2] and > the linked bug reports from there. > > The change is done in a least inversive way in KWin. We just check for > the property _GTK_FRAME_EXTENTS and create a Q_PROPERTY in Client for it. > If we add support for the frame extents in future we would also need > this. So it's not a change just for enforcing the decoration. > > The actual enforcing is done through a KWin script so users can still > disable it. > > [1] https://mail.gnome.org/archives/wm-spec-list/2014-June/msg2.html > [2] https://bugzilla.gnome.org/show_bug.cgi?id=729721 > > > Diffs > - > > atoms.h d52223504a78909efa7c18d7e96feebec8f3cb21 > atoms.cpp 576e85f0c0e865721a1b513af9d1ad1bfdb580ea > client.h 8e41e203d01b41fdd918c35fb3dc9353d7e41774 > client.cpp 608e6a8435ad9bc7d86ff813038023648e6b7b1e > events.cpp 514eecc69d81136d8975155e0fbb3fef39d3a346 > manage.cpp fbdf19570418e412cdadb54f36cf94e5da24db4f > scripts/CMakeLists.txt feeb288250407f5f2bd4b3ea878f21640ebb7d20 > scripts/enforcedeco/contents/code/main.js PRE-CREATION > scripts/enforcedeco/metadata.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119062/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119015/#review61518 --- This review has been submitted with commit a615f2abaef7769f9d287022462e84930821b8f0 by Sujith Haridasan to branch master. - Commit Hook On June 29, 2014, 3:53 p.m., Sujith Haridasan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119015/ > --- > > (Updated June 29, 2014, 3:53 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > This patch fixes the full screen settings of plasma-mediacenter during exit. > Though its bit hackish which I had done. > I would like to make this done better. With this change the pmc will save the > fullscreen settings before exit. > > > Diffs > - > > browsingbackends/utility/exit/CMakeLists.txt 48d12a7 > browsingbackends/utility/exit/exitbackend.cpp 9fe6cad > shells/newshell/mainwindow.cpp 97655d8 > > Diff: https://git.reviewboard.kde.org/r/119015/diff/ > > > Testing > --- > > Done testing with fullscreen enabled and exit && fullscreen disabled and > exit. Both results were as expected. > > > Thanks, > > Sujith Haridasan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118977: KSMServer: Do not autostart files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118977/#review61516 --- This review has been submitted with commit 68b27ba6abbce9c8f03a94a065c32d54b13a8c8c by Aleix Pol on behalf of Vishesh Handa to branch master. - Commit Hook On July 1, 2014, 3:24 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118977/ > --- > > (Updated July 1, 2014, 3:24 p.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Bugs: 335878 > https://bugs.kde.org/show_bug.cgi?id=335878 > > > Repository: plasma-workspace > > > Description > --- > > KSMServer: Do not autostart files > > Currently KLauncher is responsible for starting all of the autostart > files. It intelligently starts only the files which should be started in > the KDE environment. > > Once this is done, KLauncher then decides to also start all the files > in the autostart folder, but does that without checking which should be > started. I'm not sure why both KSMServer and KLauncher are overlaping > and doing the same thing. But it seems that KLauncher is the correct > place to do this. Specially since ksmserver uses kioclient5 in order to > start the applications. > > BUG: 335878 > > > Diffs > - > > ksmserver/server.h 3d19118 > ksmserver/startup.cpp 11cc968 > > Diff: https://git.reviewboard.kde.org/r/118977/diff/ > > > Testing > --- > > Applications are now only started once. > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118978: [screenlocker/greeter] Disable session management in the greeter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118978/#review61404 --- This review has been submitted with commit c9b0480069e650626a7daf597a7e9879f60397b7 by Martin Gräßlin to branch master. - Commit Hook On June 27, 2014, 3:26 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118978/ > --- > > (Updated June 27, 2014, 3:26 p.m.) > > > Review request for Plasma and Harald Sitter. > > > Bugs: 336793 > https://bugs.kde.org/show_bug.cgi?id=336793 > > > Repository: plasma-workspace > > > Description > --- > > [screenlocker/greeter] Disable session management in the greeter > > We don't want to have the greeter being restored on session startup if > one shut down the system from the lock screen. > > BUG: 336793 > > > Diffs > - > > ksmserver/screenlocker/greeter/main.cpp > c708a2f9be0ac8a214045d775cc3489d3dfdb5ab > > Diff: https://git.reviewboard.kde.org/r/118978/diff/ > > > Testing > --- > > shut down system from lock screen before and after change. > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118974: UserAccount KCM: Change the name using the AccountManager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118974/#review61357 --- This review has been submitted with commit 77275f50241eb2f4e38051152074c379fa96fe84 by Vishesh Handa to branch frameworks. - Commit Hook On June 30, 2014, 1:16 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118974/ > --- > > (Updated June 30, 2014, 1:16 p.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Repository: kde-baseapps > > > Description > --- > > UserAccount KCM: Change the name using the AccountManager > > Instead of calling chfn, parsing its output (which depends on the > version of chfn which is present) and also additionally requires the > password. > > This is also much more secure since we aren't storing the password in > memory. > > > Diffs > - > > kdepasswd/kcm/CMakeLists.txt ddb2ed6 > kdepasswd/kcm/chfnprocess.h 9f962e2 > kdepasswd/kcm/chfnprocess.cpp fca8e25 > kdepasswd/kcm/main.cpp 25f9001 > > Diff: https://git.reviewboard.kde.org/r/118974/diff/ > > > Testing > --- > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119053: KGlobalAccel fixes for loading shortcuts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119053/#review61346 --- This review has been submitted with commit 4caa63d655d603268d46c98d38a39337dfed04c9 by Martin Gräßlin to branch master. - Commit Hook On July 1, 2014, 7:59 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119053/ > --- > > (Updated July 1, 2014, 7:59 a.m.) > > > Review request for KDE Frameworks, Plasma and David Faure. > > > Repository: kglobalaccel > > > Description > --- > > Sorry for the last minute changes. I expected the bugs to be in the KCM and > not in kglobalaccel and unfortunately the autotests cannot be executed on > build.kde.org thus I never noticed that they don't pass :-( > > > Update actionShortcuts on auto loading shortcuts > > When using auto-loading the shortcut needs to be updated from what the > daemon returns. This had not been done yet and KGlobalAccel still kept > the shortcut passed in. > > With this change the autotests pass and the global shortcut KCM shows > the used shortcuts properly. > > Update actionShortcuts when daemon emits yourShortcutGotChanged > > Without updating the shortcut kept in actionShortcuts KGlobalAccel > still returns the old shortcut when invoking the shortcut() method. > > The unit test for this was unfortunately broken as it checked the > wrong QAction. This is also fixed with this change. > > Set componentName and DisplayName on QActions in KGlobalShortcutTest > > This fixes the testFindActionByKey. > > > Diffs > - > > autotests/kglobalshortcuttest.cpp 3f76760cb9e06a19d636a81546706cee548e1869 > src/kglobalaccel.cpp a98891c806764132b4f02b828d59584a85745fb3 > > Diff: https://git.reviewboard.kde.org/r/119053/diff/ > > > Testing > --- > > unit tests pass now. > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119027: Add basic application to load mediacenter shell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119027/#review61267 --- This review has been submitted with commit b5be331bd2fc95aac54b7abcfba0c8de0c1ed1df by Bhushan Shah to branch frameworks. - Commit Hook On June 30, 2014, 9:52 a.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119027/ > --- > > (Updated June 30, 2014, 9:52 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > --- > > Add a basic application to load mediacenter shell, > > Which loads shell package > Creates PlasmaQuick view to load Desktop.qml > And adds one containment in corona > > > Diffs > - > > CMakeLists.txt f79e878 > shells/CMakeLists.txt 9877ee3 > shells/application/CMakeLists.txt PRE-CREATION > shells/application/main.cpp PRE-CREATION > shells/application/plasmaquick/view.h PRE-CREATION > shells/application/pmccorona.h PRE-CREATION > shells/application/pmccorona.cpp PRE-CREATION > shells/application/pmcview.h PRE-CREATION > shells/application/pmcview.cpp PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/119027/diff/ > > > Testing > --- > > correctly works, containment is added to config file and restored on startup > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118973: Ensure we mark batteries as connected when the charge is full too
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118973/#review61168 --- This review has been submitted with commit 3e58744036a5a78d55c42349e64550acba44d955 by Aleix Pol to branch master. - Commit Hook On June 27, 2014, 11:24 a.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118973/ > --- > > (Updated June 27, 2014, 11:24 a.m.) > > > Review request for Plasma, Solid and Kai Uwe Broulik. > > > Repository: plasma-workspace > > > Description > --- > > I always found weird that the blue lightning is disabled when my laptop is > charged and connected, so came up with this little patch. > > > Diffs > - > > applets/batterymonitor/contents/ui/BatteryItem.qml 7c93f49 > lookandfeel/contents/components/InfoPane.qml 5a1bae0 > > Diff: https://git.reviewboard.kde.org/r/118973/diff/ > > > Testing > --- > > Seems to work. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118975: Shell: Show an OSD for the keyboard brightness
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118975/#review61098 --- This review has been submitted with commit a03b006c8af098d04603ac135d3d1047843e3b28 by Vishesh Handa to branch master. - Commit Hook On June 27, 2014, 1:58 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118975/ > --- > > (Updated June 27, 2014, 1:58 p.m.) > > > Review request for Plasma and Martin Klapetek. > > > Repository: plasma-workspace > > > Description > --- > > I have corresponding patches in powerdevil to hook it up and show it. > > > Diffs > - > > shell/osd.h 134d9f5 > shell/osd.cpp a3fbedc > > Diff: https://git.reviewboard.kde.org/r/118975/diff/ > > > Testing > --- > > Yup. Works! > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118972: Don't have all the Thmeme color properties in the public api
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61086 --- This review has been submitted with commit 18b6d854a01c010fd51db4977157802b0be0ea48 by Marco Martin to branch master. - Commit Hook On June 27, 2014, 1:09 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118972/ > --- > > (Updated June 27, 2014, 1:09 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > the color properties are remotely useful only when used from QML and risk to > explode in number in the future, it's not a good thing for a public c++ api. > > Also, they will become kinda deprecated as in largely replaced by the > ColorRole api. Too late to remove those properties completely, but still last > days to move them at least out of c++ api. (and in qml they could be removed > in the future in a 2.1 version of the import while still being present in 2.0 > if needed) > > This moves the color properties is a theme subclass available only from QML > (yes, it basically reintroduces the old themeproxy concept, but i don't think > it was completely a good move to move everything in theme) > > > Diffs > - > > src/declarativeimports/core/CMakeLists.txt e3d2f4e > src/declarativeimports/core/corebindingsplugin.cpp ebd9fd7 > src/declarativeimports/core/quicktheme.h PRE-CREATION > src/declarativeimports/core/quicktheme.cpp PRE-CREATION > src/plasma/theme.h 0211f73 > src/plasma/theme.cpp c193807 > > Diff: https://git.reviewboard.kde.org/r/118972/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118972: Don't have all the Thmeme color properties in the public api
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61085 --- This review has been submitted with commit 6c54fb596d96e697b6ce0e6c27e11ab3b990c551 by Marco Martin to branch master. - Commit Hook On June 27, 2014, 1:07 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118972/ > --- > > (Updated June 27, 2014, 1:07 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > the color properties are remotely useful only when used from QML and risk to > explode in number in the future, it's not a good thing for a public c++ api. > > Also, they will become kinda deprecated as in largely replaced by the > ColorRole api. Too late to remove those properties completely, but still last > days to move them at least out of c++ api. (and in qml they could be removed > in the future in a 2.1 version of the import while still being present in 2.0 > if needed) > > This moves the color properties is a theme subclass available only from QML > (yes, it basically reintroduces the old themeproxy concept, but i don't think > it was completely a good move to move everything in theme) > > > Diffs > - > > src/declarativeimports/core/CMakeLists.txt e3d2f4e > src/declarativeimports/core/corebindingsplugin.cpp ebd9fd7 > src/declarativeimports/core/quicktheme.h PRE-CREATION > src/declarativeimports/core/quicktheme.cpp PRE-CREATION > src/plasma/theme.h 0211f73 > src/plasma/theme.cpp c193807 > > Diff: https://git.reviewboard.kde.org/r/118972/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118940: Change SDDM theme installation path
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118940/#review61007 --- This review has been submitted with commit 26d57768bc80f7ed75d632829a8af13f151cd27e by David Edmundson on behalf of Bernd Steinhauser to branch master. - Commit Hook On June 26, 2014, 5:47 a.m., Pier Luigi Fiorini wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118940/ > --- > > (Updated June 26, 2014, 5:47 a.m.) > > > Review request for Plasma, David Edmundson, Marco Martin, and Sebastian > Kügler. > > > Repository: plasma-workspace > > > Description > --- > > Change SDDM theme installation path > > Upstream now has themes installed under INSTALL_PREFIX/share/sddm. > > > Diffs > - > > CMakeLists.txt 611e69e1f1b471e490126a94f9c34456510eab8f > lookandfeel/contents/loginmanager/README > 970d219c542bea077a000417dc35837d33ca4171 > > Diff: https://git.reviewboard.kde.org/r/118940/diff/ > > > Testing > --- > > > Thanks, > > Pier Luigi Fiorini > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118733: Change installation path of sddm theme
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118733/#review61008 --- This review has been submitted with commit 26d57768bc80f7ed75d632829a8af13f151cd27e by David Edmundson on behalf of Bernd Steinhauser to branch master. - Commit Hook On June 13, 2014, 4:09 p.m., Bernd Steinhauser wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118733/ > --- > > (Updated June 13, 2014, 4:09 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-workspace > > > Description > --- > > Simple thing. The default installation path changed upstream at id > d102be248237d3e4da0e1d0e8cdfe862851375f7 from > /usr/share/apps/sddm > to > /usr/share/sddm > > Hence the patch updates the path, so sddm can actually find the theme. > > > Diffs > - > > CMakeLists.txt 08c9084 > > Diff: https://git.reviewboard.kde.org/r/118733/diff/ > > > Testing > --- > > > Thanks, > > Bernd Steinhauser > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118937: DesktopView: Launch krunner on typing
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118937/#review61003 --- This review has been submitted with commit 9fd2842d78137a3c7357da5c1acdc163c4889d04 by Vishesh Handa to branch master. - Commit Hook On June 25, 2014, 2:38 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118937/ > --- > > (Updated June 25, 2014, 2:38 p.m.) > > > Review request for Plasma. > > > Bugs: 336692 > https://bugs.kde.org/show_bug.cgi?id=336692 > > > Repository: plasma-workspace > > > Description > --- > > This is consistent with the behaviour in Plasma 4. > > > Diffs > - > > shell/CMakeLists.txt ed1348f > shell/desktopview.h 1cc5881 > shell/desktopview.cpp a0e08ad > > Diff: https://git.reviewboard.kde.org/r/118937/diff/ > > > Testing > --- > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118933: PlasmaShell: Do not start krunner
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118933/#review61002
---
This review has been submitted with commit
fa096ebb7b2ab2740ba16a681d6dd1b28e03ba98 by Vishesh Handa to branch master.
- Commit Hook
On June 25, 2014, 10:58 a.m., Vishesh Handa wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118933/
> ---
>
> (Updated June 25, 2014, 10:58 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> ---
>
> PlasmaShell: Do not start krunner
>
> Krunner is automatically started via an autostart file. We do not need
> plasma to
> start it as well. Without this patch, krunner comes into focus each time
> plasma is restarted since krunner is already running and executing it
> then gives it focus.
>
> BUG: 336002
>
> This patch depends on another patch in plasma-workspace/krunner which adds
> the krunner.desktop file -
>
> commit 1b570623b1e8df93f20940654e160b35570172ac
> Author: Vishesh Handa
> Date: Wed Jun 25 11:38:49 2014 +0200
>
> Add a KRunner autostart file
>
> diff --git a/krunner/CMakeLists.txt b/krunner/CMakeLists.txt
> index 8e625b9..4197827 100644
> --- a/krunner/CMakeLists.txt
> +++ b/krunner/CMakeLists.txt
> @@ -35,6 +35,7 @@ target_link_libraries(krunner
>
> install(TARGETS krunner ${INSTALL_TARGETS_DEFAULT_ARGS})
> install(FILES ${krunner_dbusAppXML} DESTINATION
> ${DBUS_INTERFACES_INSTALL_DIR} )
> +install(FILES krunner.desktop DESTINATION ${AUTOSTART_INSTALL_DIR})
>
> set(CMAKECONFIG_INSTALL_DIR
> "${CMAKECONFIG_INSTALL_PREFIX}/KRunnerAppDBusInterface")
> ecm_configure_package_config_file(KRunnerAppDBusInterfaceConfig.cmake.in
> diff --git a/krunner/krunner.desktop b/krunner/krunner.desktop
> new file mode 100644
> index 000..2f1f6dc
> --- /dev/null
> +++ b/krunner/krunner.desktop
> @@ -0,0 +1,9 @@
> +[Desktop Entry]
> +Exec=krunner
> +Name=KRunner
> +OnlyShowIn=KDE;
> +Type=Application
> +X-DBUS-StartupType=Unique
> +X-DBUS-ServiceName=org.kde.krunner
> +X-KDE-StartupNotify=false
> +X-KDE-autostart-phase=0
>
>
> Diffs
> -
>
> desktoppackage/contents/loader.qml c1ac4a4
>
> Diff: https://git.reviewboard.kde.org/r/118933/diff/
>
>
> Testing
> ---
>
>
> Thanks,
>
> Vishesh Handa
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118896: Fix 2 data races in runnercontext, mention another one.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118896/#review60987 --- This review has been submitted with commit 09dd2a2a20b7fcd5382e8b139e1843da4437cba9 by David Faure to branch master. - Commit Hook On June 25, 2014, 10:51 p.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118896/ > --- > > (Updated June 25, 2014, 10:51 p.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Repository: kdelibs > > > Description > --- > > Fix 2 data races in runnercontext, mention another one. > > Found by helgrinding krunner. Turns out helgrind lacks support for > QReadWriteLock, but reading the code still made me found these. > > > Diffs > - > > plasma/private/runnerjobs.cpp 6a8a7710f95adba38cc56c2d59393bfa3b123185 > plasma/runnercontext.cpp abd6a4bc7fca2a0d05f27c6601b658ff552307b3 > > Diff: https://git.reviewboard.kde.org/r/118896/diff/ > > > Testing > --- > > Typing various things into krunner. > > The main crash is still there though: baloo or xapian isn't reentrant; but > that's separate. > > > Thanks, > > David Faure > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118896: Fix 2 data races in runnercontext, mention another one.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118896/#review60986 --- This review has been submitted with commit 8facec405ff4c5bc3666246183575f5d3dc8a896 by David Faure to branch KDE/4.13. - Commit Hook On June 23, 2014, 7:45 a.m., David Faure wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118896/ > --- > > (Updated June 23, 2014, 7:45 a.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Repository: kdelibs > > > Description > --- > > Fix 2 data races in runnercontext, mention another one. > > Found by helgrinding krunner. Turns out helgrind lacks support for > QReadWriteLock, but reading the code still made me found these. > > > Diffs > - > > plasma/private/runnerjobs.cpp 6a8a7710f95adba38cc56c2d59393bfa3b123185 > plasma/runnercontext.cpp abd6a4bc7fca2a0d05f27c6601b658ff552307b3 > > Diff: https://git.reviewboard.kde.org/r/118896/diff/ > > > Testing > --- > > Typing various things into krunner. > > The main crash is still there though: baloo or xapian isn't reentrant; but > that's separate. > > > Thanks, > > David Faure > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118936: Correct typo in LockScreen.qml (forceAcitveFocus -> forceActiveFocus).
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118936/#review60961 --- This review has been submitted with commit 1d826eaabe57af8b2a194dd3a208bded56100f44 by Elias Probst to branch master. - Commit Hook On June 25, 2014, 2:36 p.m., Elias Probst wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118936/ > --- > > (Updated June 25, 2014, 2:36 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Correct typo in LockScreen.qml (forceAcitveFocus -> forceActiveFocus). > > > Diffs > - > > lookandfeel/contents/lockscreen/LockScreen.qml > adbca6d178e1a0bd21c6d9222d3c438b18a83541 > > Diff: https://git.reviewboard.kde.org/r/118936/diff/ > > > Testing > --- > > The message "LockScreen.qml:152: TypeError: Property 'forceAcitveFocus' of > object TextField_QMLTYPE_10(0x14516a0) is not a function" in the lockscreen > output is gone. > > > Thanks, > > Elias Probst > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118906: Fix dialog's check for isTooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/#review60912 --- This review has been submitted with commit dc79190b8d1aa52830764950ee43f947bd089bde by David Edmundson to branch master. - Commit Hook On June 23, 2014, 5:26 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118906/ > --- > > (Updated June 23, 2014, 5:26 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Fix dialog's check for isTooltip > > Qt::Tooltip is a mix of other flags (0x0001101) > > using a simple & is not correct as any Window will have (0x001) set > and the bitwise & operation will return a non-zero value > > > Diffs > - > > src/plasmaquick/dialog.cpp ab56ccc > > Diff: https://git.reviewboard.kde.org/r/118906/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118899: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118899/#review60905 --- This review has been submitted with commit 79d59289fc68204a94eb44fa281a22c34307896b by Michael Palimaka to branch master. - Commit Hook On June 23, 2014, 2:44 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118899/ > --- > > (Updated June 23, 2014, 2:44 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Threadweaver is unused. Akonadi, Boost, KdepimLibs, and QImageBlitz are used > only by commented-out stuff so there's no point trying to find and report > about it. > > > Diffs > - > > CMakeLists.txt 4bfa2e93abfc6f8087693c363e5982fa862cf0fa > wallpapers/image/CMakeLists.txt 32dbf310ce7c243a62e042c71f8b9de420048cd8 > > Diff: https://git.reviewboard.kde.org/r/118899/diff/ > > > Testing > --- > > Inspected source. Builds. > > > Thanks, > > Michael Palimaka > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118898: KGamma: Apply user setting at login/startup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60890 --- This review has been submitted with commit 82a264a08c2356f68c76ca6dafebe139639caf56 by Wolfgang Bauer to branch master. - Commit Hook On June 24, 2014, 10:58 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118898/ > --- > > (Updated June 24, 2014, 10:58 a.m.) > > > Review request for kde-workspace, KDE Graphics, Plasma, and Marcel Wiesweg. > > > Bugs: 218668 > http://bugs.kde.org/show_bug.cgi?id=218668 > > > Repository: kgamma > > > Description > --- > > KGamma's saved user settings are not applied on startup/login. The user has > to enter the KCM to apply them. > This makes it rather useless, as not even saving the settings system-wide > really works any more. (this requires an xorg.conf which normally doesn't > exist nowadays) > > This patch uses kcminit to apply these settings again on login. Apparently > this has been forgotten when moving/porting kgamma to KDE4. > > PS: As there seems to be no kgamma group and this is desktop-related, I > decided to add the kde-workspace and plasma groups for review. I hope that's > ok... ;) > > > Diffs > - > > kcmkgamma/kgamma.cpp 890ba99 > kcmkgamma/kgamma.desktop 3d87513 > > Diff: https://git.reviewboard.kde.org/r/118898/diff/ > > > Testing > --- > > Set a gamma value in the KGamma KCM, logout/login (or reboot), Gamma value > gets set correctly. > > If there's no kgammarc file (or it contains no actual gamma settings), the > Gamma value is not changed. It stays at what is configured for X (or its > default). > > > Thanks, > > Wolfgang Bauer > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118898: KGamma: Apply user setting at login/startup
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118898/#review60889 --- This review has been submitted with commit abb774fa60709102cc86daeef035cc8d59a9ef09 by Wolfgang Bauer to branch KDE/4.13. - Commit Hook On June 24, 2014, 8:04 a.m., Wolfgang Bauer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118898/ > --- > > (Updated June 24, 2014, 8:04 a.m.) > > > Review request for kde-workspace, KDE Graphics, Plasma, and Marcel Wiesweg. > > > Bugs: 218668 > http://bugs.kde.org/show_bug.cgi?id=218668 > > > Repository: kgamma > > > Description > --- > > KGamma's saved user settings are not applied on startup/login. The user has > to enter the KCM to apply them. > This makes it rather useless, as not even saving the settings system-wide > really works any more. (this requires an xorg.conf which normally doesn't > exist nowadays) > > This patch uses kcminit to apply these settings again on login. Apparently > this has been forgotten when moving/porting kgamma to KDE4. > > PS: As there seems to be no kgamma group and this is desktop-related, I > decided to add the kde-workspace and plasma groups for review. I hope that's > ok... ;) > > > Diffs > - > > kcmkgamma/kgamma.cpp 890ba99 > kcmkgamma/kgamma.desktop 3d87513 > > Diff: https://git.reviewboard.kde.org/r/118898/diff/ > > > Testing > --- > > Set a gamma value in the KGamma KCM, logout/login (or reboot), Gamma value > gets set correctly. > > If there's no kgammarc file (or it contains no actual gamma settings), the > Gamma value is not changed. It stays at what is configured for X (or its > default). > > > Thanks, > > Wolfgang Bauer > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118891: Folder view icon text background
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118891/#review60873 --- This review has been submitted with commit 5819be48aafef3465451a61f87ca01dc6dd93bd3 by Andrew Lake to branch master. - Commit Hook On June 23, 2014, 2:19 p.m., Andrew Lake wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118891/ > --- > > (Updated June 23, 2014, 2:19 p.m.) > > > Review request for Plasma. > > > Bugs: 335070 > https://bugs.kde.org/show_bug.cgi?id=335070 > > > Repository: plasma-desktop > > > Description > --- > > Addresses lack of contrast of folderview containment icon text on certain > backgrounds: Bug 335070 > > The color of the text background is just the complement of the icon label > text with a 0.6 opacity applied. > > > Diffs > - > > containments/folder/package/contents/ui/ConfigIcons.qml 9f57900 > containments/folder/package/contents/ui/ItemDelegate.qml 4f95f04 > > Diff: https://git.reviewboard.kde.org/r/118891/diff/ > > > Testing > --- > > > File Attachments > > > with latest changes showing it with selection background > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/23/58f07e42-08b4-480a-9c05-40195514edbf__icontextbackground2.png > > > Thanks, > > Andrew Lake > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118886: Add paintedWidth and paintedHeight properties to WindowThumbnail
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118886/#review60829 --- This review has been submitted with commit 347e073df39429bf1be804a2c3d32aad09b7f0ab by Kai Uwe Broulik to branch master. - Commit Hook On June 23, 2014, 5:39 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118886/ > --- > > (Updated June 23, 2014, 5:39 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-framework > > > Description > --- > > This adds paintedWidth and paintedHeight properties to > PlasmaCore.WindowThumbnail which tells as how large the thumbnail, which is > scaled keeping aspect ratio, actually is, similar to what QML Image does. > This is will eventually allow the taskmanager to size its tooltips more > appropriately. > > (Is it better to store m_paintedWidth and m_paintedHeight separately, or is > the QSize thing I used ok?) > > > Diffs > - > > src/declarativeimports/core/windowthumbnail.h 14fc44a > src/declarativeimports/core/windowthumbnail.cpp b10f030 > > Diff: https://git.reviewboard.kde.org/r/118886/diff/ > > > Testing > --- > > Works, reports the actual size > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118889: Use new Konqui in the about Dialog
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60786 --- This review has been submitted with commit 09fc14eda3fa7f378fe2252d6556786183f7472e by Marco Martin to branch master. - Commit Hook On June 22, 2014, 8:13 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118889/ > --- > > (Updated June 22, 2014, 8:13 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kxmlgui > > > Description > --- > > This (actually no code, just a new png) replaces the current image in About > KDE from the old 3d rendered Konqui to an image using the New official one, > done by the author for the purpose > > > Diffs > - > > > Diff: https://git.reviewboard.kde.org/r/118889/diff/ > > > Testing > --- > > > File Attachments > > > aboutkde.png > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/22/cf0875f5-52c0-429f-b852-54ea2b6f87fd__aboutkde.png > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118869: Use QElapsedTimer for data engines
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60781 --- This review has been submitted with commit fec57bdaa2622efbab88061e3d84fda03a806376 by Christoph Feck to branch master. - Commit Hook On June 23, 2014, 11:03 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118869/ > --- > > (Updated June 23, 2014, 11:03 a.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Bugs: 336551 > http://bugs.kde.org/show_bug.cgi?id=336551 > > > Repository: kdelibs > > > Description > --- > > As described in bug 336551, plasma data engines use QTime to find out about > elapsed time. The problem is that QTime handles time zones, and therefore > reads /etc/localtime on each call. > > Instead, it should use QElapsedTimer. This fixes both the performance issue, > as well as the FIXME from the comment about not handled 24-h wraps and > timezone changes. > > There are probably more places where this can be changed. > > > Diffs > - > > plasma/datacontainer.cpp d19b1a5 > plasma/dataengine.cpp 9612574 > plasma/private/datacontainer_p.h a3e1f00 > plasma/private/dataengine_p.h 74a61e2 > > Diff: https://git.reviewboard.kde.org/r/118869/diff/ > > > Testing > --- > > > Thanks, > > Christoph Feck > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118869: Use QElapsedTimer for data engines
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118869/#review60780 --- This review has been submitted with commit ac5d3d2f916c0a461121d4d033642227bd743edb by Christoph Feck to branch master. - Commit Hook On June 23, 2014, 10:47 a.m., Christoph Feck wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118869/ > --- > > (Updated June 23, 2014, 10:47 a.m.) > > > Review request for Plasma and Aaron J. Seigo. > > > Bugs: 336551 > http://bugs.kde.org/show_bug.cgi?id=336551 > > > Repository: kdelibs > > > Description > --- > > As described in bug 336551, plasma data engines use QTime to find out about > elapsed time. The problem is that QTime handles time zones, and therefore > reads /etc/localtime on each call. > > Instead, it should use QElapsedTimer. This fixes both the performance issue, > as well as the FIXME from the comment about not handled 24-h wraps and > timezone changes. > > There are probably more places where this can be changed. > > > Diffs > - > > plasma/datacontainer.cpp d19b1a5 > plasma/dataengine.cpp 9612574 > plasma/private/datacontainer_p.h a3e1f00 > plasma/private/dataengine_p.h 74a61e2 > > Diff: https://git.reviewboard.kde.org/r/118869/diff/ > > > Testing > --- > > > Thanks, > > Christoph Feck > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118637: [klipper] Port from XLib to XCB
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118637/#review60751 --- This review has been submitted with commit 951af7b491d3ad02d64031870b7bb8da1d69a18d by Martin Gräßlin to branch master. - Commit Hook On June 10, 2014, 1:40 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118637/ > --- > > (Updated June 10, 2014, 1:40 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > [klipper] Port from XLib to XCB > > This ports the workarounds using query pointer from XLib to XCB. At the > same time the build system is adjusted to only link against XCB and > Qt5::X11Extras if we are building for X11 and the define is taken from > config-X11.h instead of setting a define through CMakeLists.txt. > > [klipper] Update apptime only on platform X11 > > > [klipper] Use KWindowSystem for URLGrabber::isAvoidedWindow() > > It had custom (and incorrect) code for reading the window class of the > active window. That's provided by KWindowSystem in a better way without > the need of having windowing system dependent code. > > > Diffs > - > > klipper/CMakeLists.txt 999be53c5332048c90b98cbbd9b23fad72be2a4b > klipper/klipper.cpp 5e60a5ab0a31567545876888309b287ac9b4be35 > klipper/urlgrabber.cpp 61425e0f88731575699429a5263b1306269d5ae1 > > Diff: https://git.reviewboard.kde.org/r/118637/diff/ > > > Testing > --- > > * URL copied with actions enabled for normal window and browser > * selected word without lmb > > * not tested: the OOo test case. > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118695: Don't set -DHAVE_X11 through target properties
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118695/#review60750 --- This review has been submitted with commit ca9be41cb8d4f459f9a31c92c1cc200b34e94f8e by Martin Gräßlin to branch master. - Commit Hook On June 12, 2014, 11:46 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118695/ > --- > > (Updated June 12, 2014, 11:46 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Don't set -DHAVE_X11 through target properties > > Include instead. > > > Diffs > - > > kcms/colors/CMakeLists.txt 8f75d1dcee6f23c5c8378884a20befdc1139ea97 > kcms/fonts/CMakeLists.txt b4c237c8fd9a2acd89b1755b62dbadfafa239302 > kcms/fonts/fonts.cpp e57d745996925790123e716e47674c34801e02e0 > kcms/input/CMakeLists.txt 0baed093d2996a61ab8b02570ae072753368a697 > kcms/krdb/krdb.cpp cddfe24d0eed9d5e031b36b68a949601fc564131 > kcms/style/CMakeLists.txt 423241b8127491853d8afa75bb8b5d78c9009dca > > Diff: https://git.reviewboard.kde.org/r/118695/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118812: [plasmashell] Show a warning if there are no Shaders and exit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118812/#review60745 --- This review has been submitted with commit 0a040bc49837e49f9cd4a1780ac926156f1430d6 by Martin Gräßlin to branch master. - Commit Hook On June 18, 2014, 1:27 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118812/ > --- > > (Updated June 18, 2014, 1:27 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > [plasmashell] Show a warning if there are no Shaders and exit > > If there are no Shaders Plasma doesn't work. If we detect this we show > a warning (without GL) and exit. > > This doesn't really work as Qt has a bug which doesn't allow to detect > whether Shaders are supported and the exit just doesn't work. > > > Diffs > - > > shell/shellcorona.h f500e837b5957e14e70ac4b24da0cdf7970a7171 > shell/shellcorona.cpp 4abe3432f30a8c4eb90806893f15c7c50f0e1ac2 > > Diff: https://git.reviewboard.kde.org/r/118812/diff/ > > > Testing > --- > > With Mesa drivers: > LIBGL_ALWAYS_INDIRECT=1 plasmashell > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60674 --- This review has been submitted with commit 97e717aae08e03fa4fa7ada024b0f6dfa019c6d4 by Shantanu Tushar on behalf of R. Harish Navnit to branch vsrao-seriesbackend. - Commit Hook On June 21, 2014, 3:58 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116874/ > --- > > (Updated June 21, 2014, 3:58 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 330990 and Bug > http://bugs.kde.org/show_bug.cgi?id=330990 > http://bugs.kde.org/show_bug.cgi?id=Bug > > > Repository: plasma-mediacenter > > > Description > --- > > Now the next and previous buttons do not work unless a media is playing. > > > Diffs > - > > mediaelements/mediacontroller/MediaController.qml 2fce0a0 > > Diff: https://git.reviewboard.kde.org/r/116874/diff/ > > > Testing > --- > > I've done the testing for this patch. > > These are the steps that I followed. > 1. Added a new playlist and added a few songs to the playlist. > 2. Re-opened Plasma Media Center > 3. Clicked the Next and Previous buttons. > 4. Nothing was played. > 5. Selected a song from the list and then tested the next and previous > buttons. > 6. The buttons worked seamlessly. > > > Thanks, > > R.Harish Navnit > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116874: Patch for the next and previous button functionality in an inactive playlist.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116874/#review60670 --- This review has been submitted with commit fec9938bcef6dd884720008d9577aea18c82cf99 by Shantanu Tushar on behalf of R. Harish Navnit to branch master. - Commit Hook On June 21, 2014, 3:55 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116874/ > --- > > (Updated June 21, 2014, 3:55 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 330990 and Bug > http://bugs.kde.org/show_bug.cgi?id=330990 > http://bugs.kde.org/show_bug.cgi?id=Bug > > > Repository: plasma-mediacenter > > > Description > --- > > Now the next and previous buttons do not work unless a media is playing. > > > Diffs > - > > mediaelements/mediacontroller/MediaController.qml 2fce0a0 > > Diff: https://git.reviewboard.kde.org/r/116874/diff/ > > > Testing > --- > > I've done the testing for this patch. > > These are the steps that I followed. > 1. Added a new playlist and added a few songs to the playlist. > 2. Re-opened Plasma Media Center > 3. Clicked the Next and Previous buttons. > 4. Nothing was played. > 5. Selected a song from the list and then tested the next and previous > buttons. > 6. The buttons worked seamlessly. > > > Thanks, > > R.Harish Navnit > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118824: Fix for "Bug 336414 - Playlist switching doesnt move highlight"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/#review60644 --- This review has been submitted with commit f5118554d78a471c28afc1f6624909ba65ac6b31 by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 19, 2014, 2:10 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118824/ > --- > > (Updated June 19, 2014, 2:10 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 336414 > http://bugs.kde.org/show_bug.cgi?id=336414 > > > Repository: plasma-mediacenter > > > Description > --- > > Whenever we added / removed any playlist, the highlight was stuck at one > point i.e changing the playlist after that was not changing the highlight. > > This was happening because we were directly assigning value to > "multiplePlaylistList.currentIndex" in qml code, which removed its previous > binding. Instead we should emit the currentIndexChanged() signal and let the > ListView do the rest. > > > Diffs > - > > libs/mediacenter/multipleplaylistmodel.cpp 87601f5 > mediaelements/playlist/MultiplePlaylists.qml 4b085fe > > Diff: https://git.reviewboard.kde.org/r/118824/diff/ > > > Testing > --- > > Changed playlist after adding / removing a playlist. Now highlight is working > fine > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118759: Add a separator to the path where PMC stores playlist file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/#review60643 --- This review has been submitted with commit a9a575cdb76887751b60b4b76460e8406c5f by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 15, 2014, 4:21 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118759/ > --- > > (Updated June 15, 2014, 4:21 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Due to a lack of separator, PMC was storing the file in a different directory > and reading playlists from a different directory. > > > Diffs > - > > libs/mediacenter/playlistmodel.cpp 4c52f00 > > Diff: https://git.reviewboard.kde.org/r/118759/diff/ > > > Testing > --- > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review60642 --- This review has been submitted with commit 1e05c24eadd0668345990713e8e9916339bfc30c by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 12, 2014, 5:51 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118691/ > --- > > (Updated June 12, 2014, 5:51 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Change the currentIndex of playlistModel to -1 when a media is played from > somewhere other than playlist. > > > Diffs > - > > libs/mediacenter/playlistmodel.h 0de7c56 > libs/mediacenter/playlistmodel.cpp c5ab1ab > shells/newshell/package/contents/ui/mediacenter.qml a859225 > > Diff: https://git.reviewboard.kde.org/r/118691/diff/ > > > Testing > --- > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118688: Avoid crash when artist is invalid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/#review60641 --- This review has been submitted with commit d9bc355a07eb898b8b951efec27ccc8759d1a511 by Shantanu Tushar on behalf of Bhushan Shah to branch vsrao-seriesbackend. - Commit Hook On June 12, 2014, 1:07 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118688/ > --- > > (Updated June 12, 2014, 1:07 p.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > --- > > Artist can be invalid, dont fetch artist name if it is invalid. > > > Diffs > - > > libs/mediacenter/medialibrary.cpp c8b7ab1 > > Diff: https://git.reviewboard.kde.org/r/118688/diff/ > > > Testing > --- > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/#review60645 --- This review has been submitted with commit 312950ac1408cf421a48565126df07bf4f4e44fe by Shantanu Tushar on behalf of Ashish Madeti to branch vsrao-seriesbackend. - Commit Hook On June 19, 2014, 5:14 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118767/ > --- > > (Updated June 19, 2014, 5:14 p.m.) > > > Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu > Tushar, Sinny Kumari, and Sujith Haridasan. > > > Bugs: 328532 > http://bugs.kde.org/show_bug.cgi?id=328532 > > > Repository: plasma-mediacenter > > > Description > --- > > PMC didn't used to remember the playlist I was on the last time, when > restarting it. > Now it saves the "lastPlaylist" while closing in the settings, and when > starting it loads the value of "lastPlaylist" in settings > > > Diffs > - > > libs/mediacenter/playlistmodel.cpp dccaf52 > > Diff: https://git.reviewboard.kde.org/r/118767/diff/ > > > Testing > --- > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/#review60640 --- This review has been submitted with commit 64e556652117408dcfe35cb03dc7e77d43a2eac2 by Shantanu Tushar on behalf of Sinny Kumari to branch vsrao-seriesbackend. - Commit Hook On June 11, 2014, 2:27 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118468/ > --- > > (Updated June 11, 2014, 2:27 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > As of now, PMC only uses the MediaPlay button to give the user an option to > play/pause media from the home screen. However, not all keyboards have the > MediaPlay button AFAIK. > This patch gives the user the option to play/pause the media from the home > screen using the spacebar key as another alternative. > > > Diffs > - > > shells/newshell/package/contents/ui/mediacenter.qml e1bc0e6 > > Diff: https://git.reviewboard.kde.org/r/118468/diff/ > > > Testing > --- > > Play any media, navigate to homescreen. Press the spacebar to check if the > media plays/pauses. > > Seems to work fine to me. > > > Thanks, > > R.Harish Navnit > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118845: Apply some settings to KDE4 if possible
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118845/#review60613 --- This review has been submitted with commit ccb12703c93972c8ce7462453e3bb64af14d07a9 by Marco Martin to branch master. - Commit Hook On June 20, 2014, 3:26 p.m., Marco Martin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118845/ > --- > > (Updated June 20, 2014, 3:26 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Some settings in kf5 applications are relatively safe to apply to kde4 as > well, in order to keep applications feel "integrated" > > this patch uses kde4migration to apply > * colors > * icons > * fonts > > when any of those is changed in systemsettings > > > Diffs > - > > kcms/krdb/krdb.cpp cddfe24 > > Diff: https://git.reviewboard.kde.org/r/118845/diff/ > > > Testing > --- > > > Thanks, > > Marco Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118849: AppletQuickItem: Do not remember the popup dialog size
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118849/#review60608 --- This review has been submitted with commit d3de99eb1e59c30a7e0fa53c81dcf0af5cb35d67 by Vishesh Handa to branch master. - Commit Hook On June 20, 2014, 2:35 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118849/ > --- > > (Updated June 20, 2014, 2:35 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > The popup dialog can currently never be resized, so it doesn't make > sense to record its height in a config file. Additionally, this also > causes problems when applet writers change the size of their plasmoid. > Since the old size is saved in the config file, it is shown with the old > dimensions instead of the new ones. > > When we implement dialog resizing at that time we can propogate a signal > which says that the applet has been manually resized and save it in a config > file. Though even that could be buggy since the plasmoid could later be much > smaller. > > > Diffs > - > > src/plasmaquick/appletquickitem.cpp a6e91f7 > src/plasmaquick/private/appletquickitem_p.h 8b8010a > > Diff: https://git.reviewboard.kde.org/r/118849/diff/ > > > Testing > --- > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118796: [notifications] Introduce a list of apps that are limited to single notification only
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118796/#review60600 --- This review has been submitted with commit 299ba613208897be49383f41a2c30016f56fe31a by Martin Klapetek to branch master. - Commit Hook On June 20, 2014, 12:21 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118796/ > --- > > (Updated June 20, 2014, 12:21 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This prevents some apps to spam lots of notifications when all it needs is > actually just one single notification. > > Imagine you're switching songs in your playlist quickly and each song change > sends new notification, but when > you get to the tenth song, you still see the notification from the 3rd song > (because timeouts) and you don't > really care about all those songs changes still in the queue as you see it in > the playlist anyway. > > So this patch limits certain apps to have only one single notification which > is always updated. So far > Clementine and Spotify is there. Switching songs or changing playback status > creates only one single popup. > > > Diffs > - > > applets/notifications/package/contents/ui/NotificationPopup.qml d07ee32 > applets/notifications/plugin/notificationshelper.cpp c5a1082 > dataengines/notifications/notificationsengine.h df0d3ca > dataengines/notifications/notificationsengine.cpp aaf6079 > > Diff: https://git.reviewboard.kde.org/r/118796/diff/ > > > Testing > --- > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118847: Fix disappearing icons when adding panel in "Folder" layout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118847/#review60599 --- This review has been submitted with commit e11e9c7c6c1836c28b455014ae93e10bb61af540 by Bhushan Shah to branch master. - Commit Hook On June 20, 2014, 1:05 p.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118847/ > --- > > (Updated June 20, 2014, 1:05 p.m.) > > > Review request for Plasma and Eike Hein. > > > Bugs: 336376 > https://bugs.kde.org/show_bug.cgi?id=336376 > > > Repository: plasma-workspace > > > Description > --- > > setting thickness requires the panel alignment set beforehand. so if we will > not set panel alignment panel geometry is calculated wrong and hence > availableScreenRect in shellcorona. > > > Diffs > - > > shell/panelview.cpp 24edfcb > > Diff: https://git.reviewboard.kde.org/r/118847/diff/ > > > Testing > --- > > icons are still there after adding 4 panels. > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118842: Add reset function to QImageItem image property
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118842/#review60584
---
This review has been submitted with commit
542d1b8534d56b7278ec239236feecd942ec4dfe by David Edmundson to branch master.
- Commit Hook
On June 20, 2014, 12:26 a.m., David Edmundson wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118842/
> ---
>
> (Updated June 20, 2014, 12:26 a.m.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Repository: kdeclarative
>
>
> Description
> ---
>
> Add reset function to QImageItem
>
> This allows
>
> QImageItem {
> image: undefined
> }
>
> without warnings.
>
> This is useful as otherwise it's impossible to unset a set QImageItem as
> QImage is uncreatable from within QML.
>
> The immediate usage is to fix a bug in notifications where sometimes an image
> from a previous notification "leaks" into our current notification.
>
>
> Diffs
> -
>
> src/qmlcontrols/kquickcontrolsaddons/qimageitem.h eef59bc
> src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed20605
> src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.h eee8189
> src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp fcc66b5
>
> Diff: https://git.reviewboard.kde.org/r/118842/diff/
>
>
> Testing
> ---
>
> Wrote small qml file, code had warning before, now it doesn't.
> Images are still displayed if set.
>
>
> Thanks,
>
> David Edmundson
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118724: rename .directory files to kf5 prefix to prevent clashes with kde-runtime files
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118724/#review60582 --- This review has been submitted with commit 53eccfad474f399ff5e71453a53312fa8bde7c63 by Jonathan Riddell to branch master. - Commit Hook On June 17, 2014, 4:16 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118724/ > --- > > (Updated June 17, 2014, 4:16 p.m.) > > > Review request for Plasma and David Faure. > > > Repository: plasma-workspace > > > Description > --- > > rename .directory files to kf5 prefix to prevent clashes with kde-runtime > files > goes with https://git.reviewboard.kde.org/r/118725/ > > > Diffs > - > > menu/desktop/CMakeLists.txt fa6af4d214a10ee3db661a752776c1c3c31c34a8 > menu/desktop/kde-development-translation.directory > menu/desktop/kde-development-webdevelopment.directory > menu/desktop/kde-development.directory > menu/desktop/kde-editors.directory > menu/desktop/kde-edu-languages.directory > menu/desktop/kde-edu-mathematics.directory > menu/desktop/kde-edu-miscellaneous.directory > menu/desktop/kde-edu-science.directory > menu/desktop/kde-edu-tools.directory > menu/desktop/kde-education.directory > menu/desktop/kde-games-arcade.directory > menu/desktop/kde-games-board.directory > menu/desktop/kde-games-card.directory > menu/desktop/kde-games-kids.directory > menu/desktop/kde-games-logic.directory > menu/desktop/kde-games-roguelikes.directory > menu/desktop/kde-games-strategy.directory > menu/desktop/kde-games.directory > menu/desktop/kde-graphics.directory > menu/desktop/kde-internet-terminal.directory > menu/desktop/kde-internet.directory > menu/desktop/kde-main.directory > menu/desktop/kde-more.directory > menu/desktop/kde-multimedia.directory > menu/desktop/kde-office.directory > menu/desktop/kde-science.directory > menu/desktop/kde-settingsmenu.directory > menu/desktop/kde-system-terminal.directory > menu/desktop/kde-system.directory > menu/desktop/kde-toys.directory > menu/desktop/kde-unknown.directory > menu/desktop/kde-utilities-accessibility.directory > menu/desktop/kde-utilities-desktop.directory > menu/desktop/kde-utilities-file.directory > menu/desktop/kde-utilities-peripherals.directory > menu/desktop/kde-utilities-pim.directory > menu/desktop/kde-utilities-xutils.directory > menu/desktop/kde-utilities.directory > > Diff: https://git.reviewboard.kde.org/r/118724/diff/ > > > Testing > --- > > > Thanks, > > Jonathan Riddell > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118732: Add xsession file for Plasma
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118732/#review60581 --- This review has been submitted with commit cd4dbbca57e1483954ff53eec3e8d3983d95aedd by Jonathan Riddell to branch master. - Commit Hook On June 13, 2014, 2:22 p.m., Jonathan Riddell wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118732/ > --- > > (Updated June 13, 2014, 2:22 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > Add xsession file for Plasma > replaces https://git.reviewboard.kde.org/r/118729/ > > > Diffs > - > > CMakeLists.txt 08c9084 > plasma.desktop.cmake PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118732/diff/ > > > Testing > --- > > > Thanks, > > Jonathan Riddell > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118734: Added MPRIS specifications Tracklist Interface
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118734/#review60575 --- This review has been submitted with commit 1edd44ee0b9a476b10e2c679a09c132c6d6c2889 by Ashish Madeti to branch master. - Commit Hook On June 14, 2014, 8:15 a.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118734/ > --- > > (Updated June 14, 2014, 8:15 a.m.) > > > Review request for Plasma, Emmanuel Pescosta, Shantanu Tushar, and Sinny > Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Added a MPRIS specifications Tracklist Interface, which will expose and give > control over the current playlist on dbus. > http://specifications.freedesktop.org/mpris-spec/latest/Track_List_Interface.html > > > Diffs > - > > libs/mediacenter/CMakeLists.txt 8d95cfc > libs/mediacenter/mpris2/mediaplayer2player.h 7a2f583 > libs/mediacenter/mpris2/mediaplayer2player.cpp 2de56c2 > libs/mediacenter/mpris2/mediaplayer2tracklist.h PRE-CREATION > libs/mediacenter/mpris2/mediaplayer2tracklist.cpp PRE-CREATION > libs/mediacenter/mpris2/mpris2.h 1dd78ca > libs/mediacenter/mpris2/mpris2.cpp b64ba04 > shells/newshell/mainwindow.cpp 3c888f8 > > Diff: https://git.reviewboard.kde.org/r/118734/diff/ > > > Testing > --- > > Tested the properties using qdbusviewer. > I created a qt console application for testing whether the signals are being > emitted correctly and the methods are working. > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118841: Add notify to colorGroup property
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841/#review60567 --- This review has been submitted with commit c317939aba7177077c9f7f8885e9dd52e77f0cf1 by David Edmundson to branch master. - Commit Hook On June 19, 2014, 9:34 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118841/ > --- > > (Updated June 19, 2014, 9:34 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Add notify to colorGroup property > > > Diffs > - > > src/declarativeimports/core/colorscope.h b90bb61 > > Diff: https://git.reviewboard.kde.org/r/118841/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60554 --- This review has been submitted with commit 66e2b915f6c8bc82b0fc08819a1e1c1601721cdf by David Edmundson to branch master. - Commit Hook On June 19, 2014, 6 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/114283/ > --- > > (Updated June 19, 2014, 6 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Use QtQuickControls ScrollView internally > > Flickable has a very odd API in which contentHeight can't be trusted. we need > to update our ScrollBars/ScrollArea to make use of the new > originX and originY in order to fix a lot of bugs that we currently see with > scrollbars. > > Instead of doing that, by porting to use QtQuick Controls we get all > these bug fixes as well as _significantly_ reducing our code. > > Having a separate logic vs UI, makes things (IMHO) easier to read. > > I don't expect to merge this as-is; I haven't included the plasma > feature that creates a SectionScroller if the content is a listview, but > that should be viable. As far as I know all other features (keyboard > controls / hiding buttons on touch screens) are still kept. > > Files removed are as indication as to long term changes from making this > change, in order to do that we need to port all users from ScrollBars -> > ScrollArea. (which is worth doing anyway IMHO) > > > Diffs > - > > src/declarativeimports/plasmaextracomponents/qml/ScrollArea.qml 860c0e7 > src/declarativeimports/plasmaextracomponents/qml/styles/ScrollViewStyle.qml > PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/114283/diff/ > > > Testing > --- > > Widget Explorer in plasma-shell looks exactly as before. > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118767: Fix for "Bug 328532 - Remember the playlist I was using when I closed PMC last time"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118767/#review60548 --- This review has been submitted with commit ea5ef1bb1b021dfcf0894eeb66bc8ba1416f520c by Shantanu Tushar on behalf of Ashish Madeti to branch master. - Commit Hook On June 19, 2014, 4:30 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118767/ > --- > > (Updated June 19, 2014, 4:30 p.m.) > > > Review request for Plasma, Bhushan Shah, Nikolaos Chatzidakis, Shantanu > Tushar, Sinny Kumari, and Sujith Haridasan. > > > Bugs: 328532 > http://bugs.kde.org/show_bug.cgi?id=328532 > > > Repository: plasma-mediacenter > > > Description > --- > > PMC didn't used to remember the playlist I was on the last time, when > restarting it. > Now it saves the "lastPlaylist" while closing in the settings, and when > starting it loads the value of "lastPlaylist" in settings > > > Diffs > - > > libs/mediacenter/playlistmodel.cpp dccaf52 > > Diff: https://git.reviewboard.kde.org/r/118767/diff/ > > > Testing > --- > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118665: Avoid invalid read in ShadowHelper destructor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118665/#review60524 --- This review has been submitted with commit befeecf182d610797402c2bae5e7ddfe1438f6ba by Aurélien Gâteau to branch master. - Commit Hook On June 13, 2014, 8:40 a.m., Aurélien Gâteau wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118665/ > --- > > (Updated June 13, 2014, 8:40 a.m.) > > > Review request for Plasma and Hugo Pereira Da Costa. > > > Repository: oxygen > > > Description > --- > > Valgrind pointed out ~ShadowHelper uses _helper, but at the time > ~ShadowHelper is called, _helper has already been deleted. Deleting > ShadowHelper manually works around this problem. I also have an alternative > patch which turns _helper into a QSharedPointer, which I can submit instead, > but the changes are much more invasive. > > > Diffs > - > > kstyle/oxygenstyle.cpp 972e4c8 > > Diff: https://git.reviewboard.kde.org/r/118665/diff/ > > > Testing > --- > > Running "valgrind kcmshell5 desktop" does not print any error about invalid > reads in ~ShadowHelper anymore. > > > Thanks, > > Aurélien Gâteau > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118824: Fix for "Bug 336414 - Playlist switching doesnt move highlight"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118824/#review60520 --- This review has been submitted with commit 553bbf16a8c0f8c46b08657b773bcd91a495f68f by Ashish Madeti to branch master. - Commit Hook On June 19, 2014, 6:51 a.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118824/ > --- > > (Updated June 19, 2014, 6:51 a.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Bugs: 336414 > http://bugs.kde.org/show_bug.cgi?id=336414 > > > Repository: plasma-mediacenter > > > Description > --- > > Whenever we added / removed any playlist, the highlight was stuck at one > point i.e changing the playlist after that was not changing the highlight. > > This was happening because we were directly assigning value to > "multiplePlaylistList.currentIndex" in qml code, which removed its previous > binding. Instead we should emit the currentIndexChanged() signal and let the > ListView do the rest. > > > Diffs > - > > libs/mediacenter/multipleplaylistmodel.cpp 87601f5 > mediaelements/playlist/MultiplePlaylists.qml 4b085fe > > Diff: https://git.reviewboard.kde.org/r/118824/diff/ > > > Testing > --- > > Changed playlist after adding / removing a playlist. Now highlight is working > fine > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118838: Don't require mandatory subText in tooltip
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/#review60514 --- This review has been submitted with commit 21af3f8c817cfd1fb9b53150c1193ca73e2018d2 by David Edmundson to branch master. - Commit Hook On June 19, 2014, 1:07 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118838/ > --- > > (Updated June 19, 2014, 1:07 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Don't require mandatory subText in tooltip > > I wasted ages yesterday trying to work out why my tooltip wasn't showing in > my code; turns out it's because I didn't have a subtext. > Besides the current implementation is broken; if the tooltip is already > showing somewhere else then this check is skipped entirely. > > > Diffs > - > > src/declarativeimports/core/tooltip.cpp 11aaaff > > Diff: https://git.reviewboard.kde.org/r/118838/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118636: Reinstate login & logout sounds
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118636/#review60509 --- This review has been submitted with commit 019f3bf5262bb1a168c2e874b1ca45d1dea9a6f2 by Martin Klapetek to branch master. - Commit Hook On June 13, 2014, 3:42 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118636/ > --- > > (Updated June 13, 2014, 3:42 p.m.) > > > Review request for Plasma and Àlex Fiestas. > > > Bugs: 335948 > https://bugs.kde.org/show_bug.cgi?id=335948 > > > Repository: plasma-workspace > > > Description > --- > > This returns the feature of having and configuring login/logout sounds for > workspace; default remains off for both. > > Additionally to this, I've made KNotification close immediately if there are > no actions defined for the given event, so it won't even try (and wait for) > all the notify plugins. > > > Diffs > - > > ksmserver/CMakeLists.txt 71ad4fc > ksmserver/plasma_workspace.notifyrc PRE-CREATION > ksmserver/server.h f813394 > ksmserver/shutdown.cpp 6a6dca9 > ksmserver/startup.cpp 6f5d502 > > Diff: https://git.reviewboard.kde.org/r/118636/diff/ > > > Testing > --- > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118791: (Need opinions) KRunner: Avoid having a scroll area
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118791/#review60507 --- This review has been submitted with commit 0c834be25392b1fc41c515a02cd357e2f6a9b36f by Vishesh Handa to branch master. - Commit Hook On June 17, 2014, 4:46 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118791/ > --- > > (Updated June 17, 2014, 4:46 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This is an experiment. > > I've removed the scroll area in the KRunner, and now all of the results are > shown. I'm not totally convinced if this is a good idea, hence the review > request. > > Advantages - > * You can see all of the results > > Disadvantages - > * Consumes more space > * Less consistent with the old runner as now it no longer has a scroll area > > Currently the way the code is structured, the model only shows 20 results. We > need to tell the model a maximum number as it decides how many results should > be shown per category based on that number. > > > Diffs > - > > lookandfeel/contents/runcommand/RunCommand.qml 7a0503d > > Diff: https://git.reviewboard.kde.org/r/118791/diff/ > > > Testing > --- > > > File Attachments > > > Krunner in its full view > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/17/a5743542-405a-4346-aa26-ac915821__krunner.png > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118716: New Translations KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118716/#review60419 --- This review has been submitted with commit bd9b9ce0ebc99161ee15d485331098d69fd42213 by Sebastian Kügler to branch master. - Commit Hook On June 18, 2014, 2:12 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118716/ > --- > > (Updated June 18, 2014, 2:12 p.m.) > > > Review request for Plasma, Chusslove Illich and John Layt. > > > Repository: plasma-desktop > > > Description > --- > > This is the second part of the replacement of the Locale KCM: Translations. > > This KCM complements the formats KCM, which sets the locale. With this KCM, > the user can configure GUI translations. > > The mechanism to set up the langhere, KF5-uage is the same as in the formats > KCM, while formats set LC_* and LANG, this KCM will set LANGUAGE. The UI is > roughly the same as in the previous "Locale", though here, KF5-compatible > mechanism (QLocale, ki18n, are used. > > This code has been written by John Layt, I've merely cleaned it up a bit, > added some missing features, tested it and am submitting it now for review. > > > Diffs > - > > kcms/CMakeLists.txt 76887e2 > kcms/formats/kcmformats.h 345fbb1 > kcms/formats/kcmformats.cpp 78cfb98 > kcms/formats/writeexports.h PRE-CREATION > kcms/translations/CMakeLists.txt PRE-CREATION > kcms/translations/Messages.sh PRE-CREATION > kcms/translations/kcmtranslations.h PRE-CREATION > kcms/translations/kcmtranslations.cpp PRE-CREATION > kcms/translations/kcmtranslationswidget.ui PRE-CREATION > kcms/translations/translations.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118716/diff/ > > > Testing > --- > > Set up languages (x-test, others), re-logged in, languages correctly set up > for KF5 and console applications. > > > File Attachments > > > KCM in systemsettings > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png > > > Thanks, > > Sebastian Kügler > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118662: fix plugin install target for phonon platform plugin
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118662/#review60418
---
This review has been submitted with commit
6099e02691c19f9deb47f307ec4f629848dbf2a3 by Harald Sitter to branch master.
- Commit Hook
On June 11, 2014, 8:51 a.m., Harald Sitter wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118662/
> ---
>
> (Updated June 11, 2014, 8:51 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> ---
>
> ${PLUGIN_INSTALL_DIR} already contains /plugins so appending it manually
> leads to /plugins/plugins/ as dir
>
> dpkg -L project-neon5-plasma-workspace |grep phonon
> /opt/project-neon5/lib/x86_64-linux-gnu/plugins/plugins/phonon_platform
> /opt/project-neon5/lib/x86_64-linux-gnu/plugins/plugins/phonon_platform/kde.so
> /opt/project-neon5/share/knotifications5/phonon.notifyrc
> /opt/project-neon5/share/kservicetypes5/phononbackend.desktop
>
>
> Diffs
> -
>
> phonon/platform_kde/CMakeLists.txt a42c213ad212631079cf0d03a7f8cb9f4b1278d1
>
> Diff: https://git.reviewboard.kde.org/r/118662/diff/
>
>
> Testing
> ---
>
> builds and installs without having /plugins/ twice in the target path
>
>
> Thanks,
>
> Harald Sitter
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118813: [declarativeimports/core] Do not crash if FadingMaterialShader failed to complie
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118813/#review60402 --- This review has been submitted with commit d7d71e8a6660331494cca42b0b1eb002c00338e9 by Martin Gräßlin to branch master. - Commit Hook On June 18, 2014, 12:19 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118813/ > --- > > (Updated June 18, 2014, 12:19 p.m.) > > > Review request for Plasma. > > > Bugs: 336272 > http://bugs.kde.org/show_bug.cgi?id=336272 > > > Repository: plasma-framework > > > Description > --- > > [declarativeimports/core] Do not crash if FadingMaterialShader failed to > complie > > Without GLSL our shader doesn't compile and Qt aborts when accessing the > uniforms. We don't want that, abort is never nice. > > BUG: 336272 > > > Diffs > - > > src/declarativeimports/core/fadingnode.cpp > 0c41ec1f4cc2fe78af59dfb1c705bbc65697380b > > Diff: https://git.reviewboard.kde.org/r/118813/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118797: Port webshortcuts runner
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118797/#review60299 --- This review has been submitted with commit abc0214dd1561256cbf03e15bfe80da818fe6006 by Rohan Garg to branch master. - Commit Hook On June 17, 2014, 2:53 p.m., Rohan Garg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118797/ > --- > > (Updated June 17, 2014, 2:53 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > See title > > > Diffs > - > > runners/CMakeLists.txt ded1fcb > runners/webshortcuts/CMakeLists.txt b97a7c5 > runners/webshortcuts/webshortcutrunner.h 73339c4 > runners/webshortcuts/webshortcutrunner.cpp cae2dec > > Diff: https://git.reviewboard.kde.org/r/118797/diff/ > > > Testing > --- > > Seems to work with the kde: , qt: and youtube: keywords > > > Thanks, > > Rohan Garg > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118798: Add icon size "tiny"
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118798/#review60269 --- This review has been submitted with commit b44e0205bc720481793671eb921675936840e85e by David Edmundson to branch master. - Commit Hook On June 17, 2014, 3:09 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118798/ > --- > > (Updated June 17, 2014, 3:09 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > Add icon size "tiny" > > See https://bugs.kde.org/show_bug.cgi?id=336326 > > > Diffs > - > > src/declarativeimports/core/units.cpp 558cafc > > Diff: https://git.reviewboard.kde.org/r/118798/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118792: PowerDevil: Show the brightness OSD on pressing the brightness key
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118792/#review60246 --- This review has been submitted with commit 8b607a73e23c5ccd9c8a54ddd4e9c0c1f47aa1e5 by Vishesh Handa to branch master. - Commit Hook On June 17, 2014, 11:20 a.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118792/ > --- > > (Updated June 17, 2014, 11:20 a.m.) > > > Review request for Plasma, Solid and Àlex Fiestas. > > > Repository: powerdevil > > > Description > --- > > See title > > > Diffs > - > > daemon/actions/bundled/brightnesscontrol.cpp 59bbbcc > > Diff: https://git.reviewboard.kde.org/r/118792/diff/ > > > Testing > --- > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118793: Remove old display KCM
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118793/#review60244 --- This review has been submitted with commit 7edf073609bf420c250348e63cdb2584136c2e14 by Elias Probst to branch master. - Commit Hook On June 17, 2014, 12:55 p.m., Elias Probst wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118793/ > --- > > (Updated June 17, 2014, 12:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Drop old display KCM in favor of kscreen's KCM. > > The old display KCM > - doesn't seem to work anymore (shows only a gray empty window) > - is not included in 'System Settings' anymore > - still shows up in search results (krunner, milou, ...) > - is superseded by kscreen > > > Diffs > - > > kcms/hardware/CMakeLists.txt ab222935903f2c10562e4a74f7933bf694d6e818 > kcms/hardware/display/CMakeLists.txt > ab8225f13ecf1623a6de28d20b467ecd306a368b > kcms/hardware/display/Messages.sh 561ccd0d8b2167dda6c354cff924166806c176ce > kcms/hardware/display/display.cpp a0392821f80081bb1c6dc2e38af0a7acd41dcfd8 > kcms/hardware/display/display.desktop > e8eff615aee5a27651ae56da909f3ecc2db09781 > kcms/hardware/display/display.h 7e0c342240eb3559c555c2ea6635987fa18f7ba6 > > Diff: https://git.reviewboard.kde.org/r/118793/diff/ > > > Testing > --- > > Building plasma-desktop with this patch doesn't install these files anymore: > /usr/share/kservices5/display.desktop > /usr/lib64/plugins/kcm_display.so > > > Thanks, > > Elias Probst > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118668: Split the startDate property into today and displayedDate in calendar component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118668/#review60224 --- This review has been submitted with commit 3188b417f4b898d416646e3c46999d710650bf3d by Martin Klapetek to branch master. - Commit Hook On June 11, 2014, 2:55 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118668/ > --- > > (Updated June 11, 2014, 2:55 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > Basically splits the Calendar::m_startDate into 'today' and 'displayedDate', > where displayedDate is the date that is displayed (it controls the days model > etc) and can be manipulated by the user by eg. changing months in the > plasmoid, and today is the current day, populated by our dataengine (which > means it auto-updates with no need for a timer). This allows for greater > flexibility and things like "Go back to today" when eg. the plasmoid is > hidden or when the user have browsed too far in the calendar and just wants > to get back to today (the button to do that pending). Also this fixes a > problem where the time dataengine is being polled every 30secs for the clock > and would reset the calendar view as the startDate is currently bound to the > dataengine and the view resets on that change. > > > Diffs > - > > src/declarativeimports/calendar/calendar.h fd2c534 > src/declarativeimports/calendar/calendar.cpp 4225579 > src/declarativeimports/calendar/qml/MonthMenu.qml 89e9dc2 > src/declarativeimports/calendar/qml/MonthView.qml eee850d > > Diff: https://git.reviewboard.kde.org/r/118668/diff/ > > > Testing > --- > > All works properly > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60213 --- This review has been submitted with commit d09bfbd3949688c3eaf422cd785f77c96ff6e399 by Sebastian Kügler to branch master. - Commit Hook On June 16, 2014, 2:43 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118678/ > --- > > (Updated June 16, 2014, 2:43 p.m.) > > > Review request for Plasma, Chusslove Illich and John Layt. > > > Repository: ki18n > > > Description > --- > > Allow querying for translations of a specific domain > > In the new translations KCM, we want to list available languages for the > workspace. This might, or might not be the same application domain as > the one set (current translation is different from installed > translations). In order to list the installed translations, we need to > specify that domain, independently from the one set in > KLocalizedString's global static. > > With this patch, I can successfully list installed languages in the new KCM. > > > I'm not super-familiar with how this stuff works, there might be a better > way, > in which case I'm sure you guys will enlighten me. :) > > > Diffs > - > > src/klocalizedstring.h 1a9fce8 > src/klocalizedstring.cpp e12d6df > > Diff: https://git.reviewboard.kde.org/r/118678/diff/ > > > Testing > --- > > Tested new translations KCM, languages show up. > > > Thanks, > > Sebastian Kügler > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118753/#review60207 --- This review has been submitted with commit 76175fafa6d3a38d739c0ab016528010040068fc by Kai Uwe Broulik to branch master. - Commit Hook On June 15, 2014, 12:01 a.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118753/ > --- > > (Updated June 15, 2014, 12:01 a.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > Now that we can handle mouse wheel events with QtQuick 2, we should. > > It mimics QSlider's behavior meaning scrolling vertically up (angleDelta.y > > 0) and scrolling horizontally right (angleDelta.x < 0 - though WheelEvent > documentation suggests otherwise) is treated the same. Anyone with a > mousewheel that can actually scroll sideways is invited to test. Also > WheelEvent behaves erratic when scrolling horizontally on my touchpad > (reporting 1 digit y values instead of proper x values) > > > Diffs > - > > src/declarativeimports/plasmacomponents/qml/Slider.qml 142040a > > Diff: https://git.reviewboard.kde.org/r/118753/diff/ > > > Testing > --- > > Tested in a horizontal slider with both mouse and touchpad scrolling with > either vertical or (by holding Alt) horizontal scrolling > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118574: Adjust componentchooser for renamed KWin binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/#review60198 --- This review has been submitted with commit ba346b6c2d17dff7f613aef84fef2cc73c34bc43 by Martin Gräßlin on behalf of Hrvoje Senjan to branch master. - Commit Hook On June 5, 2014, 7:17 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118574/ > --- > > (Updated June 5, 2014, 7:17 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-desktop > > > Description > --- > > complementary to r118266 & r118482 > > > Diffs > - > > ConfigureChecks.cmake f0a23bf > config-workspace.h.cmake 66c1d63 > kcms/componentchooser/componentchooserwm.cpp 22dfa31 > > Diff: https://git.reviewboard.kde.org/r/118574/diff/ > > > Testing > --- > > builds, reseting to default one writes in kwin_x11 in ksmserverrc, upon > restarting kwin_x11 is invoked. > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118482: Adjust ksmserver for renamed KWin binary
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/#review60197 --- This review has been submitted with commit 6cbbe0a2faddf75fdf577f1e90ad3ec3e432fb23 by Martin Gräßlin on behalf of Hrvoje Senjan to branch master. - Commit Hook On June 3, 2014, 1:22 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118482/ > --- > > (Updated June 3, 2014, 1:22 p.m.) > > > Review request for Plasma and Martin Gräßlin. > > > Repository: plasma-workspace > > > Description > --- > > as per dependant review, adjust ksmserver usage of KWin name. (IOW make sure > kwin_x11 is started) > > > Diffs > - > > ConfigureChecks.cmake 8e6a87a > ksmserver/config-ksmserver.h.cmake 939632c > ksmserver/server.cpp 644013b > ksmserver/startup.cpp 6f5d502 > > Diff: https://git.reviewboard.kde.org/r/118482/diff/ > > > Testing > --- > > using it for some ~10 days, noticed no regression. > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/#review60191 --- This review has been submitted with commit a68bb91fef6190fca8b0d40d15c20991e8a5bd2d by Martin Gräßlin to branch master. - Commit Hook On June 16, 2014, 11:45 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118779/ > --- > > (Updated June 16, 2014, 11:45 a.m.) > > > Review request for Plasma and Vishesh Handa. > > > Repository: plasma-workspace > > > Description > --- > > [krunner] Add Qt::Key_Search as a global shortcut > > > Diffs > - > > krunner/view.cpp f5b1884e60df76527747cf256d02f3ebb93825ca > > Diff: https://git.reviewboard.kde.org/r/118779/diff/ > > > Testing > --- > > * Alt+F2: works > * Alt+Space: works > * Search: works > > might require deleting the config of kglobalshortcutsrc and restarting > kglobalacceld5 > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118696: Remove unused dependencies.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/#review60181 --- This review has been submitted with commit fab88696dde52f1e0d234f510339fd3b3b155ed6 by Michael Palimaka to branch frameworks. - Commit Hook On June 12, 2014, 2:45 p.m., Michael Palimaka wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118696/ > --- > > (Updated June 12, 2014, 2:45 p.m.) > > > Review request for Plasma. > > > Repository: plasmate > > > Description > --- > > Also disable tests if QtTest is not found. > > > Diffs > - > > CMakeLists.txt 63884d6063e5cee8dafa68ce7ccc37a445a8013b > plasmate/CMakeLists.txt 17975dd6e8656f01b02926bca111cbbfa88b79f2 > > Diff: https://git.reviewboard.kde.org/r/118696/diff/ > > > Testing > --- > > Inspected sources, builds. > > > Thanks, > > Michael Palimaka > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118693: [ksmserver/screenlocker] Use ScreenSaver key as shortcut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/#review60166 --- This review has been submitted with commit 82f15720a8523031fa11de235d33e199b01a2bd1 by Martin Gräßlin to branch master. - Commit Hook On June 12, 2014, 11:11 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118693/ > --- > > (Updated June 12, 2014, 11:11 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > [ksmserver/screenlocker] Use ScreenSaver key as shortcut > > As we support multiple global shortcuts nowadays we can use both: > * ScreenSaver > * Ctrl+Alt+L > > So if the user has a lock screen key it works as expected. If not > the screen can still be locked using the well known shortcut. > > > Diffs > - > > ksmserver/screenlocker/ksldapp.cpp efc9bce5840fe0ac3bdb795954974f5c05596171 > > Diff: https://git.reviewboard.kde.org/r/118693/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118769: Use RotationAnimator in BusyIndicator
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118769/#review60136 --- This review has been submitted with commit 60ddc9f25d75686b56145120096fa741b2b2216f by Kai Uwe Broulik to branch master. - Commit Hook On June 15, 2014, 7:19 p.m., Kai Uwe Broulik wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118769/ > --- > > (Updated June 15, 2014, 7:19 p.m.) > > > Review request for Plasma, David Edmundson, Elias Probst, and Jan Grulich. > > > Bugs: 311799 and 336274 > http://bugs.kde.org/show_bug.cgi?id=311799 > http://bugs.kde.org/show_bug.cgi?id=336274 > > > Repository: plasma-framework > > > Description > --- > > Use RotationAnimator [1] for the BusyIndicator animation which operates > directly on the scenegraph. > > This helped reducing the massive plasmashell CPU usage during file copying > (ie. notifications spinning). The results varied greatly but it can't hurt to > use the Animator nonetheless since it doesn't propagate the new rotation > angle constantly. > > [1] http://qt-project.org/doc/qt-5/qml-qtquick-rotationanimator.html > > > Diffs > - > > src/declarativeimports/plasmacomponents/qml/BusyIndicator.qml fafd031 > > Diff: https://git.reviewboard.kde.org/r/118769/diff/ > > > Testing > --- > > Put notification in panel and systray, requested a view from JobViewServer, > ran top. Tried with different configurations, such as LIBGL_ALWAYS_SOFTWARE=1 > or QML_FORCE_THREADED_RENDERER=1. Results varied but generally indicated a > CPU relief. > > > Thanks, > > Kai Uwe Broulik > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118759: Add a separator to the path where PMC stores playlist file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118759/#review60129 --- This review has been submitted with commit de7de9be9bf3984b968622d5530c2c5c57c6334a by Ashish Madeti to branch master. - Commit Hook On June 15, 2014, 12:30 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118759/ > --- > > (Updated June 15, 2014, 12:30 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Due to a lack of separator, PMC was storing the file in a different directory > and reading playlists from a different directory. > > > Diffs > - > > libs/mediacenter/playlistmodel.cpp 4c52f00 > > Diff: https://git.reviewboard.kde.org/r/118759/diff/ > > > Testing > --- > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118730/#review60066 --- This review has been submitted with commit b551c6dbd4490b04a0548f40e4fbd5e1feeb0e0e by Martin Gräßlin to branch master. - Commit Hook On June 13, 2014, 7:36 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118730/ > --- > > (Updated June 13, 2014, 7:36 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-workspace > > > Description > --- > > [startkde] Introduce a ksyncdbusenv helper application > > This application is invoked by startkde once all environment variables > are set and syncs them to DBus for the activation environment. > > > Diffs > - > > startkde/startkde.cmake 0c1f5841eeefc1012dbdc71e1d1fde11e7511dd6 > startkde/ksyncdbusenv/ksyncdbusenv.cpp PRE-CREATION > startkde/ksyncdbusenv/CMakeLists.txt PRE-CREATION > startkde/CMakeLists.txt 3360a1c59409588ecec49e63276914b69568164e > > Diff: https://git.reviewboard.kde.org/r/118730/diff/ > > > Testing > --- > > on log in kglobalacceld5 doesn't pick up the right environment yet, but on > manual invocation of the tool + trigger restart of kglobalacceld5 it works. > So the approach seems to work, just not yet from startkde (maybe it's too > late?) > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118694: X11/XCB becomes a required component
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118694/#review59930 --- This review has been submitted with commit 4889a12629520f542ec01785f75ad190846a7d4f by Martin Gräßlin to branch master. - Commit Hook On June 12, 2014, 11:32 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118694/ > --- > > (Updated June 12, 2014, 11:32 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > X11/XCB becomes a required component > > So far plasma-desktop supported to be built without X11 support (Win32), > but that was completely broken (X11Extras was required). Based on > discussion in [1] X11/XCB becomes a required component. > > This means that we should not have any components in the build system > which are built optionaly depending on whether X11 is available. Ifdefs > in the code should stay, though. > > For the future we will turn X11 in a optional dependency again. But it > will never be that a component won't be built if we are building without > X11. Instead there will be a required Wayland backend and this means all > X11 specific code needs to become platform aware. > > So the way forward is: > 1. X11 required > 2. X11 required, Wayland optional > 3. X11 required, Wayland required > 4. Wayland required, X11 optional > > [1] https://mail.kde.org/pipermail/plasma-devel/2014-June/032259.html > > > Diffs > - > > CMakeLists.txt 399de771e17b265c1e5a223ad128ae2d17c00d22 > applets/CMakeLists.txt a5f35f77aead140054696ca4b3122fb177c70f1d > kcms/CMakeLists.txt 8024367f52b4fd3f757d4e5c5c851a204f4fd74b > kcms/componentchooser/CMakeLists.txt > 66f0fece8b786cf277cf41e6bef0cf03b3f619d1 > kcms/componentchooser/componentservices/CMakeLists.txt > 15cca45a12e2e61c721f092b26fa5953701ee958 > kcms/style/CMakeLists.txt 423241b8127491853d8afa75bb8b5d78c9009dca > > Diff: https://git.reviewboard.kde.org/r/118694/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118691: Change currentIndex of playlistModel to -1 when a media is not from playlist
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118691/#review59893 --- This review has been submitted with commit 1f6b40ed24fc3ce4a844364207e5c987ac105630 by Ashish Madeti to branch master. - Commit Hook On June 12, 2014, 5:22 p.m., Ashish Madeti wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118691/ > --- > > (Updated June 12, 2014, 5:22 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > Change the currentIndex of playlistModel to -1 when a media is played from > somewhere other than playlist. > > > Diffs > - > > libs/mediacenter/playlistmodel.h 0de7c56 > libs/mediacenter/playlistmodel.cpp c5ab1ab > shells/newshell/package/contents/ui/mediacenter.qml a859225 > > Diff: https://git.reviewboard.kde.org/r/118691/diff/ > > > Testing > --- > > > Thanks, > > Ashish Madeti > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118688: Avoid crash when artist is invalid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118688/#review59883 --- This review has been submitted with commit 198cbb351814dc23f0c73bc64cf8010c292a42cd by Bhushan Shah to branch master. - Commit Hook On June 12, 2014, 6:51 a.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118688/ > --- > > (Updated June 12, 2014, 6:51 a.m.) > > > Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith > Haridasan. > > > Repository: plasma-mediacenter > > > Description > --- > > Artist can be invalid, dont fetch artist name if it is invalid. > > > Diffs > - > > libs/mediacenter/medialibrary.cpp c8b7ab1 > > Diff: https://git.reviewboard.kde.org/r/118688/diff/ > > > Testing > --- > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118148: KRunner: Add the concept of disabled categories
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118148/#review59814 --- This review has been submitted with commit 50f7522c5162632a907f298160ac1efc1af08f93 by Vishesh Handa to branch master. - Commit Hook On May 22, 2014, 2:59 p.m., Vishesh Handa wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118148/ > --- > > (Updated May 22, 2014, 2:59 p.m.) > > > Review request for Plasma. > > > Repository: krunner > > > Description > --- > > Add the concept of disabled categories > > Each runner can provide a list of categories which can be used to > provide the runner extra information about which categories should be > given. This is quite useful when a single runner provides many different > categories and not all are required. > > Additionally, the RunnerManager also disables runners whose categories > are disabled. > > > Diffs > - > > src/abstractrunner.h d7d13ce > src/abstractrunner.cpp c64c510 > src/runnercontext.h 0fe0038 > src/runnercontext.cpp f58bab6 > src/runnermanager.h 94d0454 > src/runnermanager.cpp 75fb9ef > > Diff: https://git.reviewboard.kde.org/r/118148/diff/ > > > Testing > --- > > > Thanks, > > Vishesh Handa > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118669: Update DataEngine sources only if they are used
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118669/#review59812 --- This review has been submitted with commit a177696c6cd491a8363602498e7ea61befa5ffa4 by Martin Klapetek to branch master. - Commit Hook On June 11, 2014, 2:56 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118669/ > --- > > (Updated June 11, 2014, 2:56 p.m.) > > > Review request for Plasma. > > > Repository: plasma-framework > > > Description > --- > > Should save some cycles > > > Diffs > - > > src/plasma/dataengine.cpp d0befc2 > > Diff: https://git.reviewboard.kde.org/r/118669/diff/ > > > Testing > --- > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118468: Use the spacebar key to play/pause a media from the homescreen.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118468/#review59801 --- This review has been submitted with commit 6b7a1eb31cebef89e44979fc3d00118eddad2f38 by Sinny Kumari to branch master. - Commit Hook On June 2, 2014, 12:24 p.m., R.Harish Navnit wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118468/ > --- > > (Updated June 2, 2014, 12:24 p.m.) > > > Review request for Plasma, Shantanu Tushar and Sinny Kumari. > > > Repository: plasma-mediacenter > > > Description > --- > > As of now, PMC only uses the MediaPlay button to give the user an option to > play/pause media from the home screen. However, not all keyboards have the > MediaPlay button AFAIK. > This patch gives the user the option to play/pause the media from the home > screen using the spacebar key as another alternative. > > > Diffs > - > > shells/newshell/package/contents/ui/mediacenter.qml e1bc0e6 > > Diff: https://git.reviewboard.kde.org/r/118468/diff/ > > > Testing > --- > > Play any media, navigate to homescreen. Press the spacebar to check if the > media plays/pauses. > > Seems to work fine to me. > > > Thanks, > > R.Harish Navnit > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118659: Improve finding of all X11 dependencies
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118659/#review59772
---
This review has been submitted with commit
5ea23e38146a8f29f340bfb904926f01ef23521e by Martin Gräßlin to branch master.
- Commit Hook
On June 11, 2014, 7:26 a.m., Martin Gräßlin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118659/
> ---
>
> (Updated June 11, 2014, 7:26 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-workspace
>
>
> Description
> ---
>
> Improve finding of all X11 dependencies
>
> * Don't find what is not used
> * Don't find things multiple times
> * Use XCB::XCB and similar instead of ${XCB_XCB_LIBRARY}
>
>
> Diffs
> -
>
> CMakeLists.txt b7883dfaf644abfd57f7eac0d4e469c181c030f9
> kglobalaccel/CMakeLists.txt ee886e95ca2a86e9fea02c9e79055e3a4aac0f3e
> krunner/CMakeLists.txt 865a07f744c846a7cf5a682a07ad357ad885ab06
> ksmserver/screenlocker/CMakeLists.txt
> 8bd7fd39c354d83c69528bd5d2a72af079ad3964
> shell/CMakeLists.txt 2fd6264f4cae489cfe327386a27cb1266262bbda
>
> Diff: https://git.reviewboard.kde.org/r/118659/diff/
>
>
> Testing
> ---
>
> clean compile
>
>
> Thanks,
>
> Martin Gräßlin
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118251: Small improvments to FadingNode and IconItem
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118251/#review59743 --- This review has been submitted with commit 0d61746784629cb9f6b8c67e06a7ff49b5dc8732 by Martin Gräßlin to branch master. - Commit Hook On June 10, 2014, 1:56 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118251/ > --- > > (Updated June 10, 2014, 1:56 p.m.) > > > Review request for Plasma and David Edmundson. > > > Repository: plasma-framework > > > Description > --- > > Small improvments to FadingNode and IconItem > > * trigger an update after the animation finished as the IconItem needs to > switch to SVGTextureNode again > * Don't connect needlessly to a lambda slot > * FadingMaterialShader had the texture bind swapped > * Fix virtual method hidden warning in FadingMaterialShader > * Use dynamic_cast instead of static_cast to convert to SVGTextureNode > or FadingNode. > > > Diffs > - > > src/declarativeimports/core/fadingnode.cpp > 207eff3902848a3c76bf1ec62d73877d6d9d0df7 > src/declarativeimports/core/iconitem.cpp > 384017d4a9c9a96e1d465298260dffe0285712e3 > > Diff: https://git.reviewboard.kde.org/r/118251/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118644: Update battery monitor popup to use new icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118644/#review59719 --- This review has been submitted with commit 2d97851b8ad9991bffb05419fbde3d9888484ce1 by Andrew Lake to branch master. - Commit Hook On June 10, 2014, 5:09 p.m., Andrew Lake wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118644/ > --- > > (Updated June 10, 2014, 5:09 p.m.) > > > Review request for Plasma and Kai Uwe Broulik. > > > Repository: plasma-workspace > > > Description > --- > > Update battery monitor to use new icons from new battery.svgz theme file in > popup. > > Also includes minor updates to vertical alignments of icon with text and > slight increase in battery status text opacity. > > (Requires replacing the battery.svgz theme file in the theme icons/ directory > with the new one attached - I wasn't sure how to do a review request across > two different repos) > > > Diffs > - > > applets/batterymonitor/contents/ui/BatteryIcon.qml > 308eaf85c8d41574f210086b6ce17a47e261a773 > applets/batterymonitor/contents/ui/BatteryItem.qml > 655026b8e5a429f70e55aa8b9d01218139ac > applets/batterymonitor/contents/ui/BrightnessItem.qml > 0d7e8e2b4a2acae4e5a2ab43a9edefc812216ee6 > applets/batterymonitor/contents/ui/PopupDialog.qml > 44f6f9dd55d6356c446f4c7352bc5bc03338d870 > > Diff: https://git.reviewboard.kde.org/r/118644/diff/ > > > Testing > --- > > > File Attachments > > > New battery.svgz theme file > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/1b839cb5-f507-42c0-9314-cd9e0a17ee1f__battery.svgz > SS from my laptop > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/6bb20e04-22fd-4ad6-bff6-9afee5cfd4de__iconsreviewrequestss.png > icon assets shown in mockup > > https://git.reviewboard.kde.org/media/uploaded/files/2014/06/10/102356b1-0d85-45fa-96de-93384e33__mockup_battery_monitor_2.png > > > Thanks, > > Andrew Lake > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59697 --- This review has been submitted with commit 7eaa20924b99e3fa92ec3aaddef3631e7400f3e8 by Sebastian Kügler to branch master. - Commit Hook On June 9, 2014, 10:04 p.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118630/ > --- > > (Updated June 9, 2014, 10:04 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > --- > > Consider Super_L and Super_R as modifiers > > Without this patch, I can't use the meta key to assign shortcuts, as > Super_L and Super_R are not considered as modifiers, so when I press > meta (Super_L on my system), the shortcut is immediately accepted, > before I get the chance to press another key. > > This patch requires the fix in > https://bugreports.qt-project.org/browse/QTBUG-38428 > to be applied. With both patches, the QtQuick widgets to assign > shortcuts works for me also with the Meta key. > > Suggested by David Edmundson in review request at > https://git.reviewboard.kde.org/r/118581/ > > CCBUG:335316 > > > Diffs > - > > src/qmlcontrols/kquickcontrols/private/keysequencehelper.cpp > 7bf67ecb68c97086c0d858ef7c7f774ae0560983 > > Diff: https://git.reviewboard.kde.org/r/118630/diff/ > > > Testing > --- > > Tested assigning Meta + L to digital clock plasmoid, works with the patch, > doesn't work without (displays garbage like in the linked bugreport). > > > Thanks, > > Sebastian Kügler > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/#review59693 --- This review has been submitted with commit e958dea8964b16457e9d15e2eacd76b38bc69ec2 by David Edmundson to branch master. - Commit Hook On May 30, 2014, 3:42 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118428/ > --- > > (Updated May 30, 2014, 3:42 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > --- > > Drop configuration options for taskbar and desktop fonts > > These weren't being used by plasma so it ended up as a config > option to do nothing. > > > Diffs > - > > kcms/fonts/fonts.cpp 9747761 > > Diff: https://git.reviewboard.kde.org/r/118428/diff/ > > > Testing > --- > > Opened KCM. > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118386: Give milou proper version
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118386/#review59690 --- This review has been submitted with commit df86d9da03f47b928fe6bb5a93a546346aba26ab by Hrvoje Senjan to branch frameworks. - Commit Hook On May 28, 2014, 7:07 p.m., Hrvoje Senjan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118386/ > --- > > (Updated May 28, 2014, 7:07 p.m.) > > > Review request for Plasma and Vishesh Handa. > > > Repository: milou > > > Description > --- > > sideeffect - coexists with 4.x version. as there's no development files, > added LIBRARY NAMELINK_SKIP directive. > > > Diffs > - > > CMakeLists.txt 4bf25ae > lib/CMakeLists.txt 657e9dc > > Diff: https://git.reviewboard.kde.org/r/118386/diff/ > > > Testing > --- > > builds > > > Thanks, > > Hrvoje Senjan > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118635: [klipper] Drop kdelibs4support dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118635/#review59688 --- This review has been submitted with commit 41d3e1fc54a4aaa036152f8b4f288cf14294edbc by Martin Gräßlin to branch master. - Commit Hook On June 10, 2014, 12:36 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118635/ > --- > > (Updated June 10, 2014, 12:36 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > [klipper] Drop kdelibs4support dependency > > \o/ - it's ported away > > > Diffs > - > > klipper/CMakeLists.txt 40aa4d92ab61cff749b6ff5e1de93bb6befa0a35 > klipper/clipcommandprocess.cpp 7a6fe03d32ddc7590de0835bf146548c4fe98268 > klipper/urlgrabber.cpp 9a3d6acd4c2afd8b38a6123237756cb123a9f90e > > Diff: https://git.reviewboard.kde.org/r/118635/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118461: [klipper] Rename desktop file to org.kde.klipper.desktop and set DBUS-ServiceName
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118461/#review59680 --- This review has been submitted with commit 9cced65bcf6e427b03271b50b6ad54a665b294a5 by Martin Gräßlin to branch master. - Commit Hook On June 10, 2014, 12:14 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118461/ > --- > > (Updated June 10, 2014, 12:14 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > [klipper] Rename desktop file to org.kde.klipper.desktop > > > [klipper] Add X-DBUS-ServiceName to desktop file > > > Diffs > - > > klipper/CMakeLists.txt 107d8135adce3374d4fae3190e0fefb51140a42e > klipper/klipper.desktop e8085c91f6bcb55c63c65ee110abb918306b3d02 > klipper/org.kde.klipper.desktop PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/118461/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118423: [klipper] Port KMimeType to QMimeType
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118423/#review59671 --- This review has been submitted with commit 027c1723c0bd34dc6ca7e6c43bfc944570f4d6a3 by Martin Gräßlin to branch master. - Commit Hook On May 30, 2014, 1:38 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118423/ > --- > > (Updated May 30, 2014, 1:38 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > [klipper] Port KMimeType to QMimeType > > > Diffs > - > > klipper/urlgrabber.cpp 4eccb7065ae2932cc548c902ab3a8c50e4972444 > > Diff: https://git.reviewboard.kde.org/r/118423/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118347: [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118347/#review59643 --- This review has been submitted with commit 51d3cf399949ee2596f6900825d5b86940e92ad7 by Martin Gräßlin to branch master. - Commit Hook On June 3, 2014, 5:48 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118347/ > --- > > (Updated June 3, 2014, 5:48 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > [klipper] Port from KIntSpinBox to KPluralHandlingSpinBox > > This introduces new dependency to KF5TextWidgets. > > REVIEW: 118347 > > > Diffs > - > > klipper/generalconfig.ui f0145752eb2dbd927392b682b6472695c793a588 > klipper/CMakeLists.txt 87e24724c99adde236c3479c13faca1c8f6c8b51 > CMakeLists.txt 1f507a88f60188d34761a7a1eab95b33abd1f783 > > Diff: https://git.reviewboard.kde.org/r/118347/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118581: Consider Super_L and Super_R as modifiers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118581/#review59637 --- This review has been submitted with commit d8e40e8579f559819a703c37cdca7849b618dc55 by Sebastian Kügler to branch master. - Commit Hook On June 6, 2014, 12:39 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118581/ > --- > > (Updated June 6, 2014, 12:39 a.m.) > > > Review request for KDE Frameworks, Plasma and Vishesh Handa. > > > Bugs: 335316 > https://bugs.kde.org/show_bug.cgi?id=335316 > > > Repository: kxmlgui > > > Description > --- > > Consider Super_L and Super_R as modifiers > > Without this patch, I can't use the meta key to assign shortcuts, as > Super_L and Super_R are not considered as modifiers, so when I press > meta (Super_L on my system), the shortcut is immediately accepted, > before I get the chance to press another key. > > This patch requires the fix in > https://bugreports.qt-project.org/browse/QTBUG-38428 > to be applied. With both patches, KKeySequenceWidget works for me. > > BUG:335316 > > > Diffs > - > > src/kkeysequencewidget.cpp b6fcd207a1d18466f4a747e1a0b4b58107c82871 > > Diff: https://git.reviewboard.kde.org/r/118581/diff/ > > > Testing > --- > > Tried to assign meta + something in global shortcuts KCM, fails without patch > (see screenshot in the linked bugreport), works correctly with patch. > > > Thanks, > > Sebastian Kügler > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118613: Prevent crash when requesting icon with negative size
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118613/#review59553 --- This review has been submitted with commit 86c1f46eaa2ffe3849e6e76c1ff2c8a27ed92a75 by Bhushan Shah to branch master. - Commit Hook On June 8, 2014, 4:45 a.m., Bhushan Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118613/ > --- > > (Updated June 8, 2014, 4:45 a.m.) > > > Review request for Plasma. > > > Bugs: 335939 > http://bugs.kde.org/show_bug.cgi?id=335939 > > > Repository: plasma-framework > > > Description > --- > > Prevent crash when requesting icon with negative size. > > > Diffs > - > > src/declarativeimports/core/iconitem.cpp 9e0cb36 > > Diff: https://git.reviewboard.kde.org/r/118613/diff/ > > > Testing > --- > > tried to resize some icons.. no longer crashes > > > Thanks, > > Bhushan Shah > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59478 --- This review has been submitted with commit d6173c1e01152019005a5e03a0c3267a88d226b1 by Luca Beltrame to branch master. - Commit Hook On June 6, 2014, 6:45 a.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118584/ > --- > > (Updated June 6, 2014, 6:45 a.m.) > > > Review request for Plasma, John Layt and Sebastian Kügler. > > > Repository: plasma-desktop > > > Description > --- > > Currently the Formats KCM writes its configuration file using the selected > locale's bcp47Name(). This, at least on my distro, breaks locale loading as > locales are in the form "foo_FOO" (e.g., "it_IT" for my own locale) and > instead the Formats KCM exports LANG as "foo" (e.g. "it"). > > This causes a bunch of runtime warnings and locales don't get actually > loaded. This patch's approach is naive and likely needs more pairs of eyes on > it, as I can't test with other distros. > > Also we might need "UTF-8" suffix for distros that use UTF-8 locales: or so I > think, but I'm not knowledgeable enough to tell if this is needed or not. > > > Diffs > - > > kcms/formats/kcmformats.cpp 4169244 > > Diff: https://git.reviewboard.kde.org/r/118584/diff/ > > > Testing > --- > > Compiled, ran the Formats KCM, selected my country, inspected the generated > files. > > > Thanks, > > Luca Beltrame > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118592: Fix Plasma's SNI icons + port away from kdelibs4support
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118592/#review59462 --- This review has been submitted with commit b0c2fda3abf978561613a9a2f8a56ccff6bdeeb2 by Martin Klapetek to branch master. - Commit Hook On June 6, 2014, 1:28 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118592/ > --- > > (Updated June 6, 2014, 1:28 p.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > --- > > This is the final patch required for Qt4 SNI icons with custom themes to work > properly. Also ports away from kdelibs4support bits. > > > Diffs > - > > applets/systemtray/plugin/protocols/dbussystemtray/dbussystemtraytask.cpp > 570f54e > dataengines/statusnotifieritem/CMakeLists.txt d5f0a34 > dataengines/statusnotifieritem/statusnotifieritem_engine.cpp 70d203e > dataengines/statusnotifieritem/statusnotifieritemsource.cpp 2157def > > Diff: https://git.reviewboard.kde.org/r/118592/diff/ > > > Testing > --- > > Qt4 apps with the QSystrayIcon-to-SNI patch now have proper icons in our > systray --> http://i.imgur.com/V5ixOyf.png > > > Thanks, > > Martin Klapetek > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118583: Fix Comic Strip Installation
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118583/#review59419 --- This review has been submitted with commit 250ad26b897ad15259dc9dc96481c5396b501c86 by David E. Narvaez to branch KDE/4.13. - Commit Hook On June 6, 2014, 6:26 a.m., David Narváez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118583/ > --- > > (Updated June 6, 2014, 6:26 a.m.) > > > Review request for Plasma. > > > Bugs: 325028 > http://bugs.kde.org/show_bug.cgi?id=325028 > > > Repository: kdeplasma-addons > > > Description > --- > > Use the plasmapkg option to install instead of the one to upgrade. What > branch should this change go to? > > > Diffs > - > > applets/comic/comic.knsrc e7a78b9 > > Diff: https://git.reviewboard.kde.org/r/118583/diff/ > > > Testing > --- > > Repeated the steps in bug 325028 > > > Thanks, > > David Narváez > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118548: Port libtaskmanager away from QDesktopWidget
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118548/#review59351 --- This review has been submitted with commit 1f5225d4405df26732fbc22ae1491614bc3a7420 by Aleix Pol to branch master. - Commit Hook On June 5, 2014, 4:57 p.m., Aleix Pol Gonzalez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118548/ > --- > > (Updated June 5, 2014, 4:57 p.m.) > > > Review request for Plasma, Martin Gräßlin, Eike Hein, and Luca Beltrame. > > > Repository: plasma-workspace > > > Description > --- > > plasmoid.screen doesn't map to QDesktopWidget indexes anymore, therefore we > need to port it. > > This patch uses the screen geometry to figure out what's the screen and then > passes around the screen rect so that we can filter out the screens that > aren't inside if the user asks for it. > > > Diffs > - > > libtaskmanager/taskmanager.cpp 27eeed7 > libtaskmanager/taskmanager.h e6ca735 > libtaskmanager/task.h 13a5a9c > libtaskmanager/task.cpp 50ea1a6 > libtaskmanager/launcheritem.cpp 649caca > libtaskmanager/groupmanager.h aa71bac > libtaskmanager/groupmanager.cpp 83b39ef > > Diff: https://git.reviewboard.kde.org/r/118548/diff/ > > > Testing > --- > > I have played with it and seems to work. > > > Thanks, > > Aleix Pol Gonzalez > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118557: Port PlasmaFramework to i18nd + Add test checking for i18n use
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118557/#review59317 --- This review has been submitted with commit 73bb587ee95a3117416ca41619b847ee2979f530 by David Edmundson to branch master. - Commit Hook On June 5, 2014, 10:12 a.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118557/ > --- > > (Updated June 5, 2014, 10:12 a.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: plasma-framework > > > Description > --- > > Set catalog name in QueryDailog > > Add a test that i18nd is used throughout > > I know I'm definitely going to forget to use i18nd in the near future, I'm > sure others will too. > The test is somewhat naive, (it would fail if you write i18n() in a comment > for example), but I think it's going to catch a lot more problems than it > causes. > > > Diffs > - > > autotests/CMakeLists.txt cda9f03 > autotests/i18ndcheck.sh PRE-CREATION > src/declarativeimports/plasmacomponents/qml/QueryDialog.qml a057e72 > > Diff: https://git.reviewboard.kde.org/r/118557/diff/ > > > Testing > --- > > Tests pass. > > > Thanks, > > David Edmundson > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118526: Provide i18nd wrappers in kdeclarative
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118526/#review59313 --- This review has been submitted with commit 90c9c6563dbc7e6ad57ab374d2f9cab78ccd367b by Martin Gräßlin to branch master. - Commit Hook On June 5, 2014, 10:03 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118526/ > --- > > (Updated June 5, 2014, 10:03 a.m.) > > > Review request for KDE Frameworks, Plasma and Marco Martin. > > > Repository: kdeclarative > > > Description > --- > > Provide i18nd wrappers in kdeclarative > > As QML might combine multiple modules with different cataloges we need > to be able to specify the translation domain explicitly. If there is a > need to use a specific domain for all i18n calls (e.g. in a library > using QML) there is the possibility to set a global translation domain > through KDeclarative. If such a domain is set all i18n calls delegate > to the i18nd variant. > > Due to the nature of KDeclarative we cannot mix i18n calls with > different domains. If two modules would require to set the translation > domain it's bound to fail. Thus the recommendation is to use the i18nd > variants in any QML code which is intended to be used as an import. > > > Diffs > - > > src/kdeclarative/kdeclarative.h b4a274b710f4de7ffbfc275d1e9a0a93be283053 > src/kdeclarative/kdeclarative.cpp a35dac5cfbd42e75e892d4ad88c491345be4a1b0 > src/kdeclarative/private/kdeclarative_p.h > 6b61d123bf74671b413e4e68bf911bb969fdaf53 > src/kdeclarative/private/rootcontext.cpp > 12309b096495910b83ed1e388989042b45a1 > src/kdeclarative/private/rootcontext_p.h > 16694b155c668e11cf7a16549a18cdc89b81b3e2 > > Diff: https://git.reviewboard.kde.org/r/118526/diff/ > > > Testing > --- > > adjusted kwineffects KCM and run it with the x-test language: the strings > with i18n from QML side are now picking up the translated strings. > > > Thanks, > > Martin Gräßlin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
