Re: Baloo and remote file systems

2018-07-19 Thread David Kahles
Hi Rainer,

> I assume it relies on inotify or something similar to
> avoid periodic full scans.
I don't know enough about Baloo to answer your questions, but Baloo relies not 
only on inotify, but additionally on LMDB (lightning memory-mapped database).

> Can anybody tell if it is possible to run baloo on a remote file system,
> also running a baloo client on the file server would be possible.
I think both, inoitfy and LMDB, don't work on NFS, so i think this is 
impossible.

David

signature.asc
Description: This is a digitally signed message part.


D9225: Fix building autotest on platforms where syscalls are not available

2018-01-04 Thread David Kahles
davidk added a comment.


  Just adding my 2 cent: I think the filter should work fine, as SCMP_SYS is 
explicit available to support different platforms. If the syscall isn't 
available, it uses negative pseudo syscall numbers to ignore those syscalls.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9225

To: bshah, #plasma, fvogt, graesslin
Cc: davidk, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart


D9673: Guard against syscalls not available on some platforms

2018-01-04 Thread David Kahles
davidk abandoned this revision.
davidk added a comment.


  In https://phabricator.kde.org/D9673#186294, @bshah wrote:
  
  > Uh, sorry I forgot to mention in orignial PR: but 
https://phabricator.kde.org/D9225
  
  
  Ok, no problem. I'll close this one.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9673

To: davidk, bshah, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D9673: Guard against syscalls not available on some platforms

2018-01-04 Thread David Kahles
davidk added reviewers: bshah, graesslin.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D9673

To: davidk, bshah, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8756: Forbid more syscalls which could modify the filesystem

2018-01-04 Thread David Kahles
davidk added a comment.


  In https://phabricator.kde.org/D8756#186280, @davidk wrote:
  
  > I'm not sure what happens here as well. I guess that arm64 doesn't 
implement many syscalls. I will prepare a patch to exclude those syscalls if 
they're not available.
  
  
  Here it is: https://phabricator.kde.org/D9673

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D8756

To: davidk, graesslin
Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8756: Forbid more syscalls which could modify the filesystem

2018-01-04 Thread David Kahles
davidk added a comment.


  In https://phabricator.kde.org/D8756#176550, @bshah wrote:
  
  > Hello,
  >
  > It seems this commit doesn't seem to build on arm64 properly: 
https://build.neon.kde.org/job/xenial_unstable_plasma_kscreenlocker_bin_arm64/1/console
  >
  > I don't exactly understand what's going on.
  
  
  Sorry for beein inactive for some time, real life was busy...
  I'm not sure what happens here as well. I guess that arm64 doesn't implement 
many syscalls. I will prepare a patch to exclude those syscalls if they're not 
available.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D8756

To: davidk, graesslin
Cc: bshah, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart


D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:7720e8486337: Forbid more syscalls which could modify the 
filesystem (authored by davidk).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D8756?vs=22174=22176

REVISION DETAIL
  https://phabricator.kde.org/D8756

AFFECTED FILES
  greeter/autotests/seccomp_test.cpp
  greeter/seccomp_filter.cpp

To: davidk, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
davidk added a reviewer: graesslin.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D8756

To: davidk, graesslin
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


D8756: Forbid more syscalls which could modify the filesystem

2017-11-10 Thread David Kahles
davidk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Forbid more syscalls. An malicious theme could create directories with the
  password as name, or encode the password in chmod bits. Also, prevent
  deleting anything, so a theme can't delete the users files.

TEST PLAN
  - Autotests run fine
  - Started sceenlocker, unlocked, created a new session. Got no seccomp 
violations in dmesg and everything worked fine.
  - Didn't test it with the nvidia driver

REPOSITORY
  R133 KScreenLocker

BRANCH
  seccomp

REVISION DETAIL
  https://phabricator.kde.org/D8756

AFFECTED FILES
  greeter/autotests/seccomp_test.cpp
  greeter/seccomp_filter.cpp

To: davidk
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart


T5412: Improve Plasma PA usability

2017-03-07 Thread David Kahles
davidk added a comment.


  >> When having many devices, the list quickly becomes longer than the 
available space and you need to scroll. Which is difficult, because you can't 
use the scrollwheel for that on most of the applet because of the sliders.
  > 
  > That's an issue in systray and not in plasma-pa, you can always use it 
outside of systray to have bigger popup.
  > 
  > I've tried disabling the wheel scrolling on sliders (because you can't 
disable it with QtQuickControls) with various hacks, but I failed. There was a 
patch to Qt to make it configurable, but it was rejected.
  
  The Qt patch has been merged and will be available in Qt 5.10: 
https://codereview.qt-project.org/#/c/187392/

TASK DETAIL
  https://phabricator.kde.org/T5412

To: davidk
Cc: davidk, vpilo, Zren, broulik, #vdg, plasma-devel, #plasma, subdiff, drosca, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mbohlender


[Differential] [Commented On] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk added a comment.


  
  
  In https://phabricator.kde.org/D4324#80955, @broulik wrote:
  
  > I think this is just working around the fact that a KCM has no way of 
postponing the closing/deletion of the dialog when OK is clicked. We have the 
issue of OK not saving settings properly in various other places that use jobs, 
too.
  
  
  Yes this is just a workaround, as there is currently no such way.
  It would be nice if KCModule::save() would return a list of KJob's to wait 
for, but this is not possible without API breakage. Maybe something like 
"KCModule::registerSavingJob(KJob *job)" and "QList 
KCModule::getSaveingJobs()" ? Then KCMultiDialog could postpone closing the 
dialog until all jobs are finished, and maybe show a progressdialog if it lasts 
too long?

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D4324

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Abandoned] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk abandoned this revision.
davidk added a comment.


  This needs more changes, will upload again if everything works.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D4324

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Updated, 7 lines] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk updated this revision to Diff 10658.
davidk added a comment.


  Fix method name

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4324?vs=10657=10658

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4324

AFFECTED FILES
  src/accountinfo.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas


[Differential] [Updated, 7 lines] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk updated this revision to Diff 10657.
davidk added a comment.


  Move the file instead of copying it

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D4324?vs=10656=10657

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4324

AFFECTED FILES
  src/accountinfo.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk updated the summary for this revision.
davidk updated the test plan for this revision.
davidk added a reviewer: Plasma.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D4324

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 7 lines] D4324: Copy user face icon synchronously

2017-01-28 Thread David Kahles
davidk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Otherwise the CopyJopb thead will be killed if the user klicks the "OK"
  button, because kcmshell5 quits. Thus the icon won't get saved.
  As the face file is limited to a width of 600px it shouldn't block too
  long.

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D4324

AFFECTED FILES
  src/accountinfo.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Breeze] [Bug 358224] breeze dark plasma look and feel: KDE4 applications are using mixed (light and dark) colors, rendering text unreadable

2016-11-18 Thread David Kahles
https://bugs.kde.org/show_bug.cgi?id=358224

David Kahles <david.kahle...@gmail.com> changed:

   What|Removed |Added

 CC||david.kahle...@gmail.com

--- Comment #4 from David Kahles <david.kahle...@gmail.com> ---
(In reply to kde from comment #2)
> Can this be switched from resolved? I'm having the same issue with Anki
> which is still using QT4. The problem also effects input fields.

Do you have this problem only with Anki, or with some KDE applications too?
Because I remember that Anki hardcodes some colors, and uses some other colors
from the theme, so it's hard to read with some themes. (On your screenshot it
looks like Anki hardcodes the font color to black, but uses the background
color of the theme)
If that's the case, you should report this bug to Anki.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Updated] D3071: Port away from KDELibs4Support

2016-10-25 Thread davidk (David Kahles)
davidk marked an inline comment as done.
davidk added a comment.


  Thanks for pointing this out, pushed in a separate commit.

REPOSITORY
  rUSERMANAGER User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3071

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma, mart
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D3134: Bring back usericon region selection

2016-10-25 Thread davidk (David Kahles)
This revision was automatically updated to reflect the committed changes.
Closed by commit rUSERMANAGER35715e6a5e22: Bring back usericon region selection 
(authored by davidk).

REPOSITORY
  rUSERMANAGER User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3134?vs=7605=7646

REVISION DETAIL
  https://phabricator.kde.org/D3134

AFFECTED FILES
  src/accountinfo.cpp
  src/createavatarjob.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma, davidedmundson
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Updated] D3134: Bring back usericon region selection

2016-10-22 Thread davidk (David Kahles)
davidk updated the test plan for this revision.

REPOSITORY
  rUSERMANAGER User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3134

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 35 lines] D3134: Bring back usericon region selection

2016-10-22 Thread davidk (David Kahles)
davidk created this revision.
davidk added a reviewer: Plasma.
davidk added a subscriber: plasma-devel.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Also, improve error checking.

TEST PLAN
  - selected an new icon, got the region selector
- without the resize, saving will fail for high resolution images
- When resizing to a bigger size (e.g. 800x800 pixel), icons will be too big
- Canceling the region selection will not change the icon

REPOSITORY
  rUSERMANAGER User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3134

AFFECTED FILES
  src/accountinfo.cpp
  src/createavatarjob.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Closed] D3071: Port away from KDELibs4Support

2016-10-22 Thread davidk (David Kahles)
This revision was automatically updated to reflect the committed changes.
Closed by commit rUSERMANAGER4aafaf4e5fea: Port away from KDELibs4Support 
(authored by davidk).

REPOSITORY
  rUSERMANAGER User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3071?vs=7421=7603

REVISION DETAIL
  https://phabricator.kde.org/D3071

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/accountinfo.cpp
  src/accountinfo.h
  src/createavatarjob.cpp
  src/lib/modeltest.cpp
  src/passworddialog.cpp
  src/passworddialog.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Commented On] D3064: Port away from KDELibs4Support

2016-10-17 Thread davidk (David Kahles)
davidk added a comment.


  Abandoned, because it includes stuff which should be in it's own RR.

REPOSITORY
  rUSERMANAGER User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3064

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Changed Policy] D3064: Port away from KDELibs4Support

2016-10-17 Thread davidk (David Kahles)
davidk changed the visibility from "No One" to "All Users".

REPOSITORY
  rUSERMANAGER User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3064

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Re: [Differential] [Request, 161 lines] D3064: Port away from KDELibs4Support

2016-10-16 Thread David Kahles

Hey,

Sorry, thats my fault.
I didn't get the differences between Reviewboard and Phabricator,
and included things into the review, which shouldn't be there.
When I tried to abandon the revision, I restricted the access to myself.

I just uploaded a new RR which should work fine.

Am Sonntag, 16. Oktober 2016 14:15:50 CEST schrieb David Edmundson:


I get an error trying to view this.

"You Shall Not Pass: Restricted Differential Revision"

I can view others fine. Does anyone else have this problem?

Bshah, can you see if user-manager is set up differently? 







[Differential] [Request, 125 lines] D3071: Port away from KDELibs4Support

2016-10-16 Thread davidk (David Kahles)
davidk created this revision.
davidk added a reviewer: Plasma.
davidk added a subscriber: plasma-devel.
davidk added a project: Plasma.

TEST PLAN
  Builds and works fine, including the password dialog.

REPOSITORY
  rUSERMANAGER User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3071

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/accountinfo.cpp
  src/accountinfo.h
  src/createavatarjob.cpp
  src/lib/modeltest.cpp
  src/passworddialog.cpp
  src/passworddialog.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Abandoned] D3065: Port away from KDELibs4Support

2016-10-15 Thread davidk (David Kahles)
davidk abandoned this revision.
davidk added a comment.


  Sorry for the noise, I have some problems with phabricator.

REPOSITORY
  rUSERMANAGER User Manager

REVISION DETAIL
  https://phabricator.kde.org/D3065

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 125 lines] D3065: Port away from KDELibs4Support

2016-10-15 Thread davidk (David Kahles)
davidk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rUSERMANAGER User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3065

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/accountinfo.cpp
  src/accountinfo.h
  src/createavatarjob.cpp
  src/lib/modeltest.cpp
  src/passworddialog.cpp
  src/passworddialog.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


[Differential] [Request, 161 lines] D3064: Port away from KDELibs4Support

2016-10-15 Thread davidk (David Kahles)
davidk created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Bring back the usericon region selection
  
  Also improve error checking.

REPOSITORY
  rUSERMANAGER User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D3064

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/accountinfo.cpp
  src/accountinfo.h
  src/createavatarjob.cpp
  src/lib/modeltest.cpp
  src/passworddialog.cpp
  src/passworddialog.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidk
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas


Re: multiscreen logging

2016-07-28 Thread David Kahles

Hi,
Am Donnerstag, 28. Juli 2016 12:23:56 CEST schrieb Sebastian Kügler:

On donderdag 28 juli 2016 01:18:00 CEST David Kahles wrote:

I think the problem with this approach is, that most (or even all?) of
these processes aren't units but simple processes.
A better approach using the power of journald would be something like:

journalctl -b --user _COMM=plasmashell + _COMM=kded5 
QT_CATEGORY=kscreen + 
  _COMM=systemsettings5 + 
_COMM=kscreen_backend


I may add that this makes it a lot more complex for the user 
than just sending 
me a single, combined log file.


Also, what about users without journalctl?


I don't think that executing a one-liner is a lot more complex.
But this won't work for users without journalctl, I didn't think about 
that.

Therefore I think we should go with your solution.

Cheers,
David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: multiscreen logging

2016-07-27 Thread David Kahles

Hi,

Am Mittwoch, 27. Juli 2016 22:44:38 CEST schrieb Mark Gaiser:

On Tue, Jul 26, 2016 at 3:09 PM, Mark Gaiser  wrote:


On Tue, Jul 26, 2016 at 2:03 PM, Sebastian Kügler  wrote:


Hey,

[Please keep both lists addressed.]

Debugging multiscreen issues is a nightmare:

- there are at least 4 different processes involved (kded, kcmshell /
  systemsettings, kscreen_backend_launcher and plasmashell)
- some are critical during log in
- they IPC with each other
- especially the backend launcher's debug is really hard to get at

This means that:
- it's hard (almost impossible) for users to get us good and useful logs
- it's hard for ourselves to debug and find out what's exactly going on,
especially when multiple components need to play in tune

Yesternight, after debugging the so-many-th issue, it occurred to me that
we
need to make this way easier to debug. Q(C)Debug falls short in that we
get
logs of individual components, if we're lucky. If we're really lucky, we
get
timestamps, so we can get a rough idea of what is going down when.

All of these problems can be solved with a relatively simple, shared log
file.

So I'd like to switch most of (lib)kscreen's debug output to logging to a
file. The files has then logs from multiple processes and will be much
easier
to go through.

API-wise, my main thing is having log messages and a bit of context, so
it'd
look like this:

Log::instance()->setContext("handling resume event");
// ...
Log::log("Enabled output" + output->name());

In the log, we'd then get

[TIMESTAMP] (kded: handling resume event) Enabled output eDP-1


The key here is that we get a mostly correct sequence of things, that all
the
info is there right away, and that it's easier for the user to annotate
the
log ("Now plugging in my external display as HDMI-2").

The file is simple enough that even plasmashell could log to the file (at
least until we've fixed the interaction between screen handling and
plasmashell), so we get the full picture.

libkscreen[sebas/log] has a basic implementation. It's incomplete in the
sense
that it needs a bit of autotesting (just haven't gotten to it yet),
review and
then switching over the code-base. (For now it's on by 
default, but can be

disabled using a env var.)

I hope that this makes it much more straight-forward for us (and even
users)
to figure out where their multiscreen headaches are coming from, and that
it
gives us a one-stop shop (pretty much) to tell users what info we need to
fix
their bugs. ("Just send me the logfile in ~/.local/share/kscreen.log").

What do you think? If you like the idea, I'll polish up my 
branch and will

post it for review, so we can discuss the actual implementation.

Cheers,
--
sebas

http://www.kde.org | http://vizZzion.org
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel



Hi,

Just a quick idea that might help you.

I'm not sure if the logging of those applications is already visible in
journalctl, but if it is then you can do something like this:
journalctl -u  -u  -u  -u  -f

-u would be the "units". Like plasmashell i guess.
-f means following the log (new entries appear on your screen).

Lastly, i would suggest to use a second pc independent of the one that
you're debugging. On that second machine just ssh into the one you're
debugging and execute the logging command from above.

This all obviously only works if you everything is already visible in
journalctl.

Good luck!
I hope this makes logging and debugging easier for you.

Cheers,
Mark



This idea was not an option?

It seems - to me, but i'm biased since i proposed it.. - like an idea with
minimal effort and probably gets the job done, no?




I think the problem with this approach is, that most (or even all?) of
these processes aren't units but simple processes.
A better approach using the power of journald would be something like:

journalctl -b --user _COMM=plasmashell + _COMM=kded5 QT_CATEGORY=kscreen + 
 _COMM=systemsettings5 + _COMM=kscreen_backend


which filters all logs based on the executable names, the current user
and the current boot. We can also search for specific qt logging categories
(e.g. we're searching for all kded5 logs in category "kscreen").

See "man 1 journalctl" and "man 7 systemd.journal-fields" for more 
information.
I think this is a simple and powerful solution, which doesn't require more 
code,
and doesn't have the race condition problems mentioned in the review 
request

for the new code.

Cheers,
David
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125755: Fix build with QT5.6

2016-03-18 Thread David Kahles

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125755/
---

(Updated March 17, 2016, 11:18 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: sddm-kcm


Description
---

Since QT5.6, qpixmap.h pulls in qtextstream.h. Xlib.h has a
but qtextstream.h uses Status as an enum name. fixx11h.h resolves this
name clash.


Diffs
-

  src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c 
  src/cursortheme/xcursortheme.cpp 4fc70a605d5fc3165de78916db92c13bb67c0429 

Diff: https://git.reviewboard.kde.org/r/125755/diff/


Testing
---

Compiles now.


Thanks,

David Kahles

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 125755: Fix build with QT5.6

2016-03-10 Thread David Kahles


> On Oct. 22, 2015, 1:38 p.m., Martin Gräßlin wrote:
> > src/CMakeLists.txt, line 7
> > <https://git.reviewboard.kde.org/r/125755/diff/1/?file=412366#file412366line7>
> >
> > is KWindowSystem being found at all in sddm-kcm?

Sorry for the late reply, I was very busy over the last moths.
I just noticed that the build works fine again with an up-to-date qt build. I 
don't remember the exact problem, but if it works fine now, i think this isn't 
needed anymore.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125755/#review87258
---


On Oct. 22, 2015, 1:20 p.m., David Kahles wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125755/
> ---
> 
> (Updated Oct. 22, 2015, 1:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: sddm-kcm
> 
> 
> Description
> ---
> 
> Since QT5.6, qpixmap.h pulls in qtextstream.h. Xlib.h has a
> but qtextstream.h uses Status as an enum name. fixx11h.h resolves this
> name clash.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 65be8bf3290f054c3d6d9ebc1d33c0a993c3f52c 
>   src/cursortheme/xcursortheme.cpp 4fc70a605d5fc3165de78916db92c13bb67c0429 
> 
> Diff: https://git.reviewboard.kde.org/r/125755/diff/
> 
> 
> Testing
> ---
> 
> Compiles now.
> 
> 
> Thanks,
> 
> David Kahles
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


Re: Review Request 126691: Add DBusMenuShortcut type overload for QDBusArgument

2016-02-07 Thread David Kahles


> On Jan. 10, 2016, 2:06 p.m., David Edmundson wrote:
> > That sounds like you're saying Qt has broken API. 
> > If that's true, they'll want to know about it.

I talked to them (see https://codereview.qt-project.org/#/c/144823/) and it 
seems like we shouldn't have done it like it was before, it worked by pure luck.
According to them, this change will do the right thing, but additional, we 
shouldn't inherit containers at all.
(I think the problem is, that QT containers don't have a virtual destructor)

Btw., libdbusmenu-qt suffers from the same problem, but I'm  not sure whether 
this is our responsibility (I'm confused because there's kind of a fork in 
plasma).


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126691/#review90839
---


On Jan. 10, 2016, 2:59 a.m., Dāvis Mosāns wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126691/
> ---
> 
> (Updated Jan. 10, 2016, 2:59 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Add DBusMenuShortcut type overload for QDBusArgument.
> I don't know if there's a better way to fix this than this kinda code 
> duplication.
> 
> 
> This is needed because otherwise it wouldn't compile with latest Qt dev 
> branch. It's probably because QList overload was removed in 
> http://code.qt.io/cgit/qt/qtbase.git/commit/src/dbus/qdbusargument.h?h=dev=5f542f3cca13f2da58b82aee2efbaffefeee00a7
> 
> and Container doesn't work...
> 
> /usr/include/QtDBus/qdbusargument.h:244:29: note: candidate: 
> template