Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated Feb. 8, 2017, 3:49 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs - CMakeLists.txt edf3938 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 186880f plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png kconfig_xt_editor_document.png https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/fb1f6bb9-7af5-4ec5-980a-b6ee75588fc7__kconfig_xt_editor_document.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 121207: Port the notes editor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121207/ --- (Updated Feb. 8, 2017, 3:49 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- This is a simple port of the noteseditor to KDevPlatform. The internals have remained the same. Also I have attached an image showing the noteseditor inside KDevelop Diffs - plasmate/noteseditor/noteseditor.h 2176456 plasmate/noteseditor/noteseditor.cpp 6118d4e plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/noteseditor/CMakeLists.txt PRE-CREATION plasmate/plugins/noteseditor/kdevnoteseditor.desktop.cmake PRE-CREATION plasmate/plugins/noteseditor/kdevnoteseditor.rc PRE-CREATION plasmate/plugins/noteseditor/noteseditorplugin.h PRE-CREATION plasmate/plugins/noteseditor/noteseditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121207/diff/ Testing --- File Attachments noteseditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/6bdfb03a-444f-4368-b789-e7aeb9db6148__notes.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 117750: populate the konsole and enable it by default in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117750/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- populate the konsole and enable it by default in plasmoidviewer we add a custom message handler which will print all the output to stdout and also it will check from debug messages which come from the category "qml" and those which are coming from QML Diffs - plasmoidviewer/main.cpp 009acbbe7591b03487913cb1316d5f61e6a2b500 plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml d99c8cd8ebfbbe27ca04ba30c7a2bbe396d1a064 plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml 34db7f6fc6a04ce96cd307455ff15abe6697f194 plasmoidviewer/view.h d997f15d093584f4446bbdb3475c30c98441e728 plasmoidviewer/view.cpp aa8914539358b216b9641da679050f95ba5af512 Diff: https://git.reviewboard.kde.org/r/117750/diff/ Testing --- File Attachments plasmoidviewer_message https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/8ad4291f-c8b8-4378-8ab0-0330bb01d454__plasmoidviewer_msghandler_reviewboard_ok.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/ --- (Updated Sept. 22, 2016, 8:40 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- The appletPath contains the path of the applet, if the user doesn't give a path then the refresh button of the plasmoidviewer will be hidden because we need the plasmoid path in order to execute `plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically so the user can refresh the plasmoid without having to install the plasmoid manually. Diffs - plasmoidviewer/main.cpp 009acbb plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 8a125ea plasmoidviewer/view.h d997f15 plasmoidviewer/view.cpp aa89145 Diff: https://git.reviewboard.kde.org/r/116800/diff/ Testing --- 1. paths like ~/kf5/foo/plasmoid work 2. the plasmoid is being loaded even without the --appletPath Thanks, Giorgos Tsiapaliokas
Re: Review Request 116983: Fix the height of the buttonsbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116983/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasma-sdk Description --- If I am not mistaken a regression has been introduced in plasmoidviewer. This patch solves the issue. Diffs - plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 Diff: https://git.reviewboard.kde.org/r/116983/diff/ Testing --- I have attached two images 1 without my patch and one with my patch File Attachments after.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png before.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png plasmoidviewer without margins https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated April 7, 2015, 7:08 p.m.) Review request for Plasma. Repository: plasmate Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs - CMakeLists.txt edf3938 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 186880f plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments (updated) kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png kconfig_xt_editor_document.png https://git.reviewboard.kde.org/media/uploaded/files/2015/04/07/fb1f6bb9-7af5-4ec5-980a-b6ee75588fc7__kconfig_xt_editor_document.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
On March 25, 2015, 1:59 a.m., Aleix Pol Gonzalez wrote: Is it all in now? Maybe an updated screenshot would help? Anyway, I trust your judgement if you want to ship this. The KConfigXt doesn't exist anymore in the toolviews. I have added an image in which I do 1. Click in the Configuration XML file 2. the KconfigXt document opens. - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/#review78034 --- On March 24, 2015, 9:38 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated March 24, 2015, 9:38 p.m.) Review request for Plasma. Repository: plasmate Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs - CMakeLists.txt edf3938 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 186880f plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121208: Port the KConfigXtEditor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- (Updated March 24, 2015, 9:38 p.m.) Review request for Plasma. Changes --- port KConfigXtEditor from a toolview to a document view Repository: plasmate Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs (updated) - CMakeLists.txt edf3938 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 186880f plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.h PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditordocument.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.h PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121206: Port savesystem to KDevPlatform and qml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/ --- (Updated March 14, 2015, 1 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Changes --- Submitted with commit 7b24cb2599e2bea0612cb492d2395bb6c44722ed by Giorgos Tsiapaliokas to branch frameworks. Repository: plasmate Description --- This patch is a port of the savesystem to KDevPlatform and qml. Savesystem is using KDevPlatform's code for handling the git and the ui is rewritten in qml. I have attached an image of the new savesystem Diffs - plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION plasmate/plugins/savesystemview/Messages.sh PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION plasmate/plugins/savesystemview/git.h PRE-CREATION plasmate/plugins/savesystemview/git.cpp PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121206/diff/ Testing --- File Attachments savesystem in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121206: Port savesystem to KDevPlatform and qml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/ --- (Updated March 7, 2015, 8:47 p.m.) Review request for Plasma. Changes --- Now savesystem is using the VcsEventModel and the CommitsModel is now a QIdentityProxyModel. Repository: plasmate Description --- This patch is a port of the savesystem to KDevPlatform and qml. Savesystem is using KDevPlatform's code for handling the git and the ui is rewritten in qml. I have attached an image of the new savesystem Diffs (updated) - plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION plasmate/plugins/savesystemview/Messages.sh PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION plasmate/plugins/savesystemview/git.h PRE-CREATION plasmate/plugins/savesystemview/git.cpp PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121206/diff/ Testing --- File Attachments savesystem in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121206: Port savesystem to KDevPlatform and qml
On March 2, 2015, 5:20 p.m., Aleix Pol Gonzalez wrote: plasmate/plugins/savesystemview/git.cpp, line 156 https://git.reviewboard.kde.org/r/121206/diff/2/?file=352727#file352727line156 This won't scale very much, I'd suggest using a VcsEventModel, but I guess this can be done further in the future. VcsEventModel is a QAbstractTableModel, if I am not mistaken it won't work in a ListView. Am I missing something? Also I think that the desired ui can be implemented only with a ListView. - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/#review76899 --- On March 2, 2015, 4:30 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/ --- (Updated March 2, 2015, 4:30 p.m.) Review request for Plasma. Repository: plasmate Description --- This patch is a port of the savesystem to KDevPlatform and qml. Savesystem is using KDevPlatform's code for handling the git and the ui is rewritten in qml. I have attached an image of the new savesystem Diffs - plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION plasmate/plugins/savesystemview/Messages.sh PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION plasmate/plugins/savesystemview/git.h PRE-CREATION plasmate/plugins/savesystemview/git.cpp PRE-CREATION plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121206/diff/ Testing --- File Attachments savesystem in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121206: Port savesystem to KDevPlatform and qml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/ --- (Updated March 2, 2015, 4:30 p.m.) Review request for Plasma. Changes --- I have fixed the issues except from the QQuickWidget. When I try to add a QQuickWidget into a QDocWidget the QQuickWidget becomes black. Repository: plasmate Description --- This patch is a port of the savesystem to KDevPlatform and qml. Savesystem is using KDevPlatform's code for handling the git and the ui is rewritten in qml. I have attached an image of the new savesystem Diffs (updated) - plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION plasmate/plugins/savesystemview/Messages.sh PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION plasmate/plugins/savesystemview/git.h PRE-CREATION plasmate/plugins/savesystemview/git.cpp PRE-CREATION plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121206/diff/ Testing --- File Attachments savesystem in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On 2/3/15 1:59 PM, Sebastian Kügler wrote: The repo name is I think a bit confusing. I think plasma-sdk would fit it better. +1 On 1/30/15 11:57 AM, Marco Martin wrote: maybe a quiet last kde4 release? so would be called the version, then 4 and 5 released more or less at the same time I guess we all agree that new features won't be added to kde4 version of plasmate. If we make another release of plasmate, will we take the responsibility of fixing bugs into the KDE4 release? Or we will just offer updated tarball? On 2/1/15 11:12 AM, Aleix Pol wrote: So the plan is to be able to release Plasmate without Plasmate? the plan is to release the entire repo, but to disable the plasmate application by default. The plasmate application will still be there with the dependency of KDevPlatform but it will have to be enabled. Also for later when the plasmate application is ready, we could add a check, and if KDevPlatform is found then the plasmate application will be enabled automatically otherwise it won't. -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Proposal regarding plasmate's release
Hello, I believe that before we release plasmate we should reconsider the release strategy. The current situation is that 1. the plasmate repo is in extragear 2. plasmate's repo version doesn't match the one of plasma. 3. the master branch contains the KDE4 code and the frameworks branch contains the KF5 code. I propose to 1. move the plasmate repo away from extragear 2. release the plasmate repo together with plasma and all the applications in it will follow plasma's version number. So there won't be plasmoidviewer 2.0 but plasmoidviewer 5.x 3. merge the frameworks branch into master and delete the frameworks branch 4. make the PLASMATE_BUILD_WITH_KDEVPLATFORM off(false) by default and add a message that will inform the user that the plasmate application isn't ready yet for production. -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal regarding plasmate's release
On 01/29/2015 02:52 PM, Sebastian Kügler wrote: when plasmate's new version is usable and useful, I'd like to turn this into an optional dependency, so if kdevplatform is there, we'll automatically build the plasmate IDE. +1 On 01/29/2015 02:42 PM, Marco Martin wrote: yeah, master should be in releasable state before moving. yes sorry, I meant to make the master releasable first and then to make the move. last thing, are there changes in master for kde4 not released? it may be good at least tagging it if so. yes there are. Should I just add a tag named kde4 or something like that? On 01/29/2015 02:40 PM, David Edmundson wrote: For policy reasons this requires an email to kde-core-devel Ok I can do that, thank you for letting me know. :) Which should be the new location of the plasmate repo? kde/workspace ? -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Moving plasmaengineexplorer to plasma-framework?
Hello, On 1/23/15 7:18 AM, Bhushan Shah wrote: So at moment plasmaengineexplorer is provided by plasmate which is not released at moment. yes unfortunately I haven't done a good job in that. I haven't abandoned plasmate, its just that I don't have the free time that I used to have. AFAIK nobody picked the task of releasing the plasmate repo, so I would like to help on this one. I believe that this thread is quite big enough, so I will make a new one in which we can discuss about the release. -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121206: Port savesystem to KDevPlatform and qml
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121206/ --- Review request for Plasma. Repository: plasmate Description --- This patch is a port of the savesystem to KDevPlatform and qml. Savesystem is using KDevPlatform's code for handling the git and the ui is rewritten in qml. I have attached an image of the new savesystem Diffs - plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SwitchBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Commit.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/CommitsView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePoint.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/NewSavePointView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/SaveSystemItem.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/View.qml PRE-CREATION plasmate/plugins/savesystemview/qml/Home.qml PRE-CREATION plasmate/plugins/savesystemview/qml/main.qml PRE-CREATION plasmate/plugins/savesystemview/savesystemview.h PRE-CREATION plasmate/plugins/savesystemview/savesystemview.cpp PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.h PRE-CREATION plasmate/plugins/savesystemview/savesystemviewplugin.cpp PRE-CREATION plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/savesystemview/CMakeLists.txt PRE-CREATION plasmate/plugins/savesystemview/Messages.sh PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.h PRE-CREATION plasmate/plugins/savesystemview/commitsmodel.cpp PRE-CREATION plasmate/plugins/savesystemview/git.h PRE-CREATION plasmate/plugins/savesystemview/git.cpp PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.desktop.cmake PRE-CREATION plasmate/plugins/savesystemview/kdevsavesystemview.rc PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/Branch.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/DeleteBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/InputBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/NewBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/RenameBranchView.qml PRE-CREATION plasmate/plugins/savesystemview/qml/CommitsView/BranchView/SelectionBranchView.qml PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121206/diff/ Testing --- File Attachments savesystem in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/fe1432e8-ded2-43ac-8fed-3203ab8dc6e0__savesystem_image.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121207: Port the notes editor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121207/ --- Review request for Plasma. Repository: plasmate Description --- This is a simple port of the noteseditor to KDevPlatform. The internals have remained the same. Also I have attached an image showing the noteseditor inside KDevelop Diffs - plasmate/noteseditor/noteseditor.h 2176456 plasmate/noteseditor/noteseditor.cpp 6118d4e plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/noteseditor/CMakeLists.txt PRE-CREATION plasmate/plugins/noteseditor/kdevnoteseditor.desktop.cmake PRE-CREATION plasmate/plugins/noteseditor/kdevnoteseditor.rc PRE-CREATION plasmate/plugins/noteseditor/noteseditorplugin.h PRE-CREATION plasmate/plugins/noteseditor/noteseditorplugin.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121207/diff/ Testing --- File Attachments noteseditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/6bdfb03a-444f-4368-b789-e7aeb9db6148__notes.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121208: Port the KConfigXtEditor to KDevPlatform
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121208/ --- Review request for Plasma. Repository: plasmate Description --- This is a port of the KConfigXtEditor to KDevPlatform. The internals of the kconfigxteditor haven't changed. Diffs - plasmate/plugins/kconfigxteditor/kconfigxteditorplugin.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorview.cpp PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.desktop.cmake PRE-CREATION plasmate/plugins/kconfigxteditor/kdevkconfigxteditor.rc PRE-CREATION plasmate/plugins/utils.h PRE-CREATION plasmate/plugins/utils.cpp PRE-CREATION plasmate/editors/kconfigxt/kconfigxteditor.cpp plasmate/editors/kconfigxt/kconfigxteditor.ui plasmate/editors/kconfigxt/kconfigxteditorpart.h 60a72af plasmate/editors/kconfigxt/kconfigxteditorpart.cpp 4bf252c plasmate/editors/kconfigxt/kconfigxtreader.h plasmate/editors/kconfigxt/kconfigxtreader.cpp plasmate/editors/kconfigxt/kconfigxtwriter.h plasmate/editors/kconfigxt/kconfigxtwriter.cpp plasmate/editors/kconfigxt/standalone/main.cpp plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.h 0287e04 plasmate/editors/kconfigxt/standalone/plasmakconfigxteditor.cpp plasmate/plugins/CMakeLists.txt 410080b plasmate/plugins/kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/plugins/kconfigxteditor/kconfigxteditorplugin.h PRE-CREATION CMakeLists.txt 72f5eb2 Plasmate.cmake PRE-CREATION kconfigxteditor/CMakeLists.txt PRE-CREATION plasmate/CMakeLists.txt 6e07b30 plasmate/editors/kconfigxt/kconfigxteditor.h Diff: https://git.reviewboard.kde.org/r/121208/diff/ Testing --- File Attachments kconfigxteditor in kdevelop https://git.reviewboard.kde.org/media/uploaded/files/2014/11/22/1e568048-4526-44cd-bc4c-04ded3236af0__kconfigxteditor.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 121013: Plasmate-Kdev: Add plasma project manager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121013/ --- (Updated Nov. 18, 2014, 4:14 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasmate Description --- Plasma Project Manager offers a custom view for plasma packages. If a file or a directory matches the entries from the plasma package then instead of using the real name of the file or directory it will use the semantic one. Diffs - plasmate/plugins/CMakeLists.txt PRE-CREATION plasmate/plugins/plasmaprojectmanager/CMakeLists.txt PRE-CREATION plasmate/plugins/plasmaprojectmanager/kdevplasmamanager.desktop.cmake PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaitem.h PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaitem.cpp PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaprojectmanager.h PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaprojectmanager.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121013/diff/ Testing --- Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 121013: Plasmate-Kdev: Add plasma project manager
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121013/ --- Review request for Plasma. Repository: plasmate Description --- Plasma Project Manager offers a custom view for plasma packages. If a file or a directory matches the entries from the plasma package then instead of using the real name of the file or directory it will use the semantic one. Diffs - plasmate/plugins/CMakeLists.txt PRE-CREATION plasmate/plugins/plasmaprojectmanager/CMakeLists.txt PRE-CREATION plasmate/plugins/plasmaprojectmanager/kdevplasmamanager.desktop.cmake PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaitem.h PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaitem.cpp PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaprojectmanager.h PRE-CREATION plasmate/plugins/plasmaprojectmanager/plasmaprojectmanager.cpp PRE-CREATION Diff: https://git.reviewboard.kde.org/r/121013/diff/ Testing --- Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120542: Plasmate-Kdev: Add packagemanagerview
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120542/ --- (Updated Nov. 6, 2014, 6:04 p.m.) Status -- This change has been discarded. Review request for Plasma. Repository: plasmate Description --- This is the new version of our package viewer. The technical differences between the new and the old one are: * the old one was a QDockWidget which was hardcoded inside plasmate the new one is a KDevPlatform plugin * the new one requires less code because we reuse KDevelop::ProjectModel Visually I tried to avoid any changes. The only visual difference is that we are missing the New.. entries. The screenshots show the new package viewer. Commits Cleanup the packagehandler, plasmoidhandler and themehandler We will use KDevelop::PackageModel which is a QAIM with its own info so we don't need our nodes. What we need is a a way (PackageModel::description) which will associate for example the filename main.qml to Mainscript. Add the packagemanagerview plugin This is a plugin which shows the files of the package according to the package structure. We reuse the KDevelop::ProjectModel as our model and we just proxy it by using QIDentityProxyModel. Diffs - plasmate/tests/themehandlertest.h a080d14 plasmate/tests/themehandlertest.cpp 42dab7b plasmate/plugins/packagemanagerview/packagemanagerview.cpp PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerviewplugin.h PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerviewplugin.cpp PRE-CREATION plasmate/plugins/packagemanagerview/proxymodel.h PRE-CREATION plasmate/plugins/packagemanagerview/proxymodel.cpp PRE-CREATION plasmate/tests/plasmoidhandlertest.h e888c53 plasmate/tests/plasmoidhandlertest.cpp a6abc98 plasmate/CMakeLists.txt 3380f82 plasmate/packagehandler/packagehandler.h 7dbc3bb plasmate/packagehandler/packagehandler.cpp ead1f37 plasmate/packagehandler/plasmoidhandler.h 11ca4ae plasmate/packagehandler/plasmoidhandler.cpp 60009c9 plasmate/packagehandler/themehandler.h 6c95d83 plasmate/packagehandler/themehandler.cpp 4d88361 plasmate/plugins/CMakeLists.txt PRE-CREATION plasmate/plugins/packagemanagerview/CMakeLists.txt PRE-CREATION plasmate/plugins/packagemanagerview/Messages.sh PRE-CREATION plasmate/plugins/packagemanagerview/kdevpackagemanagerview.desktop.cmake PRE-CREATION plasmate/plugins/packagemanagerview/kdevpackagemanagerview.rc PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerview.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120542/diff/ Testing --- File Attachments theme package https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/a4995d07-5564-41c5-a1f7-2cf39e5cd13f__packagemanagerview_theme.png plasmoid package https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/0bc938b4-495e-4df9-bdf9-4780f12619e9__packagemanagerview_plasmoid2.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 120542: Plasmate-Kdev: Add packagemanagerview
On Oct. 10, 2014, 2:55 a.m., Aleix Pol Gonzalez wrote: I know I've said that before, but I'm a stubborn person. It would be really cool if you considered these packages kdevplatform projects. This way these plasmoid projects would be a bit less of a special case and we could start to integrate them. Doesn't it make sense? I know I've said that before, but I'm a stubborn person. We just had postponed the conversation, in order to discuss it when the time comes. Didn't we? :) For me this review is the perfect place to discuss it. It would be really cool if you considered these packages kdevplatform projects. So, if I get this right, you suggest to 1. remove the package concept and don't add the packagemanagerview 2. use the projectmanagerview and to *not* change the names of the dirs and files, so main.qml is main.qml and not Main Script File Right? This way these plasmoid projects would be a bit less of a special case and we could start to integrate them. When you say integrate them, do you mean something like 1. adding new actions to projectmanagerview if there is a plasmoid package? 2. disabling actions from projectmanagerview that doesn't make sense for a plasmoid package? - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120542/#review68192 --- On Oct. 9, 2014, 7:21 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120542/ --- (Updated Oct. 9, 2014, 7:21 p.m.) Review request for Plasma. Repository: plasmate Description --- This is the new version of our package viewer. The technical differences between the new and the old one are: * the old one was a QDockWidget which was hardcoded inside plasmate the new one is a KDevPlatform plugin * the new one requires less code because we reuse KDevelop::ProjectModel Visually I tried to avoid any changes. The only visual difference is that we are missing the New.. entries. The screenshots show the new package viewer. Commits Cleanup the packagehandler, plasmoidhandler and themehandler We will use KDevelop::PackageModel which is a QAIM with its own info so we don't need our nodes. What we need is a a way (PackageModel::description) which will associate for example the filename main.qml to Mainscript. Add the packagemanagerview plugin This is a plugin which shows the files of the package according to the package structure. We reuse the KDevelop::ProjectModel as our model and we just proxy it by using QIDentityProxyModel. Diffs - plasmate/tests/themehandlertest.h a080d14 plasmate/tests/themehandlertest.cpp 42dab7b plasmate/plugins/packagemanagerview/packagemanagerview.cpp PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerviewplugin.h PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerviewplugin.cpp PRE-CREATION plasmate/plugins/packagemanagerview/proxymodel.h PRE-CREATION plasmate/plugins/packagemanagerview/proxymodel.cpp PRE-CREATION plasmate/tests/plasmoidhandlertest.h e888c53 plasmate/tests/plasmoidhandlertest.cpp a6abc98 plasmate/CMakeLists.txt 3380f82 plasmate/packagehandler/packagehandler.h 7dbc3bb plasmate/packagehandler/packagehandler.cpp ead1f37 plasmate/packagehandler/plasmoidhandler.h 11ca4ae plasmate/packagehandler/plasmoidhandler.cpp 60009c9 plasmate/packagehandler/themehandler.h 6c95d83 plasmate/packagehandler/themehandler.cpp 4d88361 plasmate/plugins/CMakeLists.txt PRE-CREATION plasmate/plugins/packagemanagerview/CMakeLists.txt PRE-CREATION plasmate/plugins/packagemanagerview/Messages.sh PRE-CREATION plasmate/plugins/packagemanagerview/kdevpackagemanagerview.desktop.cmake PRE-CREATION plasmate/plugins/packagemanagerview/kdevpackagemanagerview.rc PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerview.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120542/diff/ Testing --- File Attachments theme package https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/a4995d07-5564-41c5-a1f7-2cf39e5cd13f__packagemanagerview_theme.png plasmoid package https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/0bc938b4-495e-4df9-bdf9-4780f12619e9__packagemanagerview_plasmoid2.png Thanks, Giorgos Tsiapaliokas
Re: Review Request 120038: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 2
/themehandlertest.h a080d14 plasmate/tests/themehandlertest.cpp 42dab7b Diff: https://git.reviewboard.kde.org/r/120038/diff/ Testing --- Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120542: Plasmate-Kdev: Add packagemanagerview
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120542/ --- Review request for Plasma. Repository: plasmate Description --- This is the new version of our package viewer. The technical differences between the new and the old one are: * the old one was a QDockWidget which was hardcoded inside plasmate the new one is a KDevPlatform plugin * the new one requires less code because we reuse KDevelop::ProjectModel Visually I tried to avoid any changes. The only visual difference is that we are missing the New.. entries. The screenshots show the new package viewer. Commits Cleanup the packagehandler, plasmoidhandler and themehandler We will use KDevelop::PackageModel which is a QAIM with its own info so we don't need our nodes. What we need is a a way (PackageModel::description) which will associate for example the filename main.qml to Mainscript. Add the packagemanagerview plugin This is a plugin which shows the files of the package according to the package structure. We reuse the KDevelop::ProjectModel as our model and we just proxy it by using QIDentityProxyModel. Diffs - plasmate/tests/themehandlertest.h a080d14 plasmate/tests/themehandlertest.cpp 42dab7b plasmate/plugins/packagemanagerview/packagemanagerview.cpp PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerviewplugin.h PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerviewplugin.cpp PRE-CREATION plasmate/plugins/packagemanagerview/proxymodel.h PRE-CREATION plasmate/plugins/packagemanagerview/proxymodel.cpp PRE-CREATION plasmate/tests/plasmoidhandlertest.h e888c53 plasmate/tests/plasmoidhandlertest.cpp a6abc98 plasmate/CMakeLists.txt 3380f82 plasmate/packagehandler/packagehandler.h 7dbc3bb plasmate/packagehandler/packagehandler.cpp ead1f37 plasmate/packagehandler/plasmoidhandler.h 11ca4ae plasmate/packagehandler/plasmoidhandler.cpp 60009c9 plasmate/packagehandler/themehandler.h 6c95d83 plasmate/packagehandler/themehandler.cpp 4d88361 plasmate/plugins/CMakeLists.txt PRE-CREATION plasmate/plugins/packagemanagerview/CMakeLists.txt PRE-CREATION plasmate/plugins/packagemanagerview/Messages.sh PRE-CREATION plasmate/plugins/packagemanagerview/kdevpackagemanagerview.desktop.cmake PRE-CREATION plasmate/plugins/packagemanagerview/kdevpackagemanagerview.rc PRE-CREATION plasmate/plugins/packagemanagerview/packagemanagerview.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/120542/diff/ Testing --- File Attachments theme package https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/a4995d07-5564-41c5-a1f7-2cf39e5cd13f__packagemanagerview_theme.png plasmoid package https://git.reviewboard.kde.org/media/uploaded/files/2014/10/09/0bc938b4-495e-4df9-bdf9-4780f12619e9__packagemanagerview_plasmoid2.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Sept. 2, 2014, 4:52 p.m.) Status -- This change has been marked as submitted. Review request for Plasma. Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs - CMakeLists.txt 3fc11fb plasmate/CMakeLists.txt 1a6ce87 plasmate/app/katepartui.rc PRE-CREATION plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 120038: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 2
://git.reviewboard.kde.org/r/120038/diff/ Testing --- Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
On Aug. 9, 2014, 5:35 p.m., Aleix Pol Gonzalez wrote: Why would people disable plasmate when building plasmate? Giorgos Tsiapaliokas wrote: The plasmate repository contains the plasmate application and other applications like the plasmoidviewer, etc The reasoning behind this proposal is that people may doesn't want to build the plasmate application but they want to build the rest of them (plasmoidviewer, engine explorer, etc). I just thought that it may be good for now to offer this alternative since we will add a new dependency. Sebastian Kügler wrote: Agree, it should not be necessary to have kdevplatform installed just to build plasmoidviewer, for example. Making it conditional makes sense here. So can I push this one? Do I have a ship-it again? - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review64110 --- On Aug. 8, 2014, 8:18 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Aug. 8, 2014, 8:18 p.m.) Review request for Plasma. Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs - CMakeLists.txt 3fc11fb plasmate/CMakeLists.txt 1a6ce87 plasmate/app/katepartui.rc PRE-CREATION plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
On Aug. 9, 2014, 5:35 p.m., Aleix Pol Gonzalez wrote: Why would people disable plasmate when building plasmate? The plasmate repository contains the plasmate application and other applications like the plasmoidviewer, etc The reasoning behind this proposal is that people may doesn't want to build the plasmate application but they want to build the rest of them (plasmoidviewer, engine explorer, etc). I just thought that it may be good for now to offer this alternative since we will add a new dependency. - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review64110 --- On Aug. 8, 2014, 8:18 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Aug. 8, 2014, 8:18 p.m.) Review request for Plasma. Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs - CMakeLists.txt 3fc11fb plasmate/CMakeLists.txt 1a6ce87 plasmate/app/katepartui.rc PRE-CREATION plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: Because I wasn't very clear. I will also open reviews for every plugin that I have created. I just started with the plasmate's shell. We could discuss about the plugins in their individual reviews or of course we could discuss it here. As you want. :) On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: File Attachment: How plasmate should look like in the end - plasmate_ui.png https://git.reviewboard.kde.org/r/119411/#fcomment242 Didn't you have an editor for metadata files? Yes its called Metadata Editor, its in the right. On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: File Attachment: How plasmate should look like in the end - plasmate_ui.png https://git.reviewboard.kde.org/r/119411/#fcomment243 Maybe you don't want the console? Yes, we don't want some of the plugins, but I havedn't removed any of them yet. On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: File Attachment: How plasmate should look like in the end - plasmate_ui.png https://git.reviewboard.kde.org/r/119411/#fcomment244 Have you integrated plasma documentation there? No I haven't. In the past we used to offer a webview which was loading techbase.kde.org. Which with the port to KDevPlatform we will use it as a plugin. On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: File Attachment: How plasmate should look like in the end - plasmate_ui.png https://git.reviewboard.kde.org/r/119411/#fcomment245 Wouldn't it make sense to integrate Package into Project? What are the differences? Ok, Project is showing to the user the actual name of the dir/file. So for the file main.qml Project will show main.qml, but Package is showing the semantic name of the files/dirs which is taken from the plasma package. So Package for the file main.qml will show Main Script File. We wanted to present the files/dirs to the user with their semantic names. This is the reason why I created Package, I couldn't find a way to do that with Project On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: File Attachment: How plasmate should look like in the end - plasmate_ui.png https://git.reviewboard.kde.org/r/119411/#fcomment246 2 Run menus? In fact, plasmate probably wants to define its own menus, right? I have fixed the 2 Run Menus. Yes plasmate would like to have its menus.The menus should probably make it easier for the user to find the plasma specifc toolviews like the plasmoidviewer toolview. I haven't done any big changes to the menus(comparing it with the KDevPlatform shell) because the actions from the menus would come out from the plugins which I don't have included in this review request. On Aug. 7, 2014, 7:37 p.m., Aleix Pol Gonzalez wrote: plasmate/app/main.cpp, line 74 https://git.reviewboard.kde.org/r/119411/diff/2/?file=294902#file294902line74 Patches are welcome. Of course :) This was a personal note in order to fix it later. - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review64004 --- On Aug. 2, 2014, 1:20 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Aug. 2, 2014, 1:20 p.m.) Review request for Plasma. Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs - plasmate/CMakeLists.txt 1a6ce87 plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Aug. 8, 2014, 8:18 p.m.) Review request for Plasma. Changes --- I have just came up with the idea of adding the option PLASMATE_BUILD_WITH_KDEVPLATFORM. This will allow people to disable the build of plasmate in case they don't want it. This change is located in plasmate/CMakeLists.txt. By default plasmate will be included in the build. Any objections to this one? Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs (updated) - CMakeLists.txt 3fc11fb plasmate/CMakeLists.txt 1a6ce87 plasmate/app/katepartui.rc PRE-CREATION plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
On July 23, 2014, 2:58 a.m., Giorgos Tsiapaliokas wrote: This looks far simpler than I'd have anticipated. Maybe you'd like to put some screenshots? What's the completion of the branch? I have added a screenshot with how plasmate looks like in the end. The screenshot contains the plasmate's shell and the various plugins that I have created which used to be qdockwidgets. Please note that plasmoidviewer and the remoteinstaller are missing from the screenshot since they are not ready yet. I am working on those now. What do you think? P.S.: I have added in a red circle the changes of the UI. P.S.2: The UI has some issues. - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review62912 --- On Aug. 2, 2014, 1:20 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Aug. 2, 2014, 1:20 p.m.) Review request for Plasma. Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs - plasmate/CMakeLists.txt 1a6ce87 plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
On July 22, 2014, 10:18 p.m., David Edmundson wrote: I have separated this task to two reviews, because there are also some git mv in order to have a decent directory structure which I don't have FYI: If you create the diff with --find-renames it /should/ track the file movements. You've split things now, so it's possibly not worth updating, but might make your life a bit easier next time. thank you for the tip - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/#review62906 --- On Aug. 2, 2014, 1:20 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Aug. 2, 2014, 1:20 p.m.) Review request for Plasma. Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs - plasmate/CMakeLists.txt 1a6ce87 plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- (Updated Aug. 2, 2014, 1:20 p.m.) Review request for Plasma. Changes --- * fix the i18n issue * add a screenshot of how plasmate should look like in the end Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs (updated) - plasmate/CMakeLists.txt 1a6ce87 plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc plasmate/plasmateui.rc 41f6025 plasmate/startpage.h 4c77e29 plasmate/startpage.cpp a65a2cc Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 File Attachments (updated) How plasmate should look like in the end https://git.reviewboard.kde.org/media/uploaded/files/2014/08/02/f0937ff2-53b9-4adc-9b5c-5a758a32ccd5__plasmate_ui.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 119411: Plasmate-Kdev: Port plasmate to KDevPlatform's shell part 1
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119411/ --- Review request for Plasma. Repository: plasmate Description --- I have separated this task to two reviews, because there are also some `git mv` in order to have a decent directory structure which I don't have included in this review for readability. Below is the list of commits from which this review has been made. * use some private members and improve readability * Every project must have a .plasmate file in order to pick the Manager. * Initial commit for porting plasmate to kdevplatform We introduce a new class named PlasmateApp which will show the Startpage and hide it, when it must do it. Diffs - plasmate/CMakeLists.txt 1a6ce8799741b70abf4d19c7df9ea1d11d4779f8 plasmate/app/main.cpp PRE-CREATION plasmate/app/plasmateapp.h PRE-CREATION plasmate/app/plasmateapp.cpp PRE-CREATION plasmate/app/plasmateextention.h PRE-CREATION plasmate/app/plasmateextention.cpp PRE-CREATION plasmate/app/plasmateui.rc PRE-CREATION plasmate/main.cpp 633c4cc86b4795418d1ed90028165615a2e6f2ec plasmate/plasmateui.rc 41f602591cf9596c0dae13f111845630e96f19f6 plasmate/startpage.h 4c77e29bc2dd93977e06bdeec45c753a568e374a plasmate/startpage.cpp a65a2cc48afa4eef0db6d6248e31ac2111b42d8d Diff: https://git.reviewboard.kde.org/r/119411/diff/ Testing --- You can also test this review from url: http://quickgit.kde.org/?p=clones%2Fplasmate%2Ftsiapaliwkas%2Fplasmate-kdevplatform.git git: git://anongit.kde.org/clones/plasmate/tsiapaliwkas/plasmate-kdevplatform.git branch: r/119411 Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate Debian packaging issues
Hello, sorry for my late response but I am still in an exam period On Wednesday 02 of July 2014 20:26:25 David Suárez wrote: Created at https://git.reviewboard.kde.org/r/119089/ I have already replied to it. It looks ok to me but I would like someone else more exprerienced with licensing to ship it. I asigned it to the plasma group, I could found a plasmate dedicated one. yes we use the plasma group for the review requests Thanks for acepting the changes :) David thank you for volunteering to fix the issue :) Giorgos, -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 119089: Use appropiate licensed files for modeltest
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119089/#review61508 --- +1 from me but I would like someone else to have a look at it since I am not an expert on licensing. Comparing it with the original the only difference is that copyrights doesn't match and I don't know if they should match or not. - Giorgos Tsiapaliokas On July 2, 2014, 9:28 p.m., David Suárez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119089/ --- (Updated July 2, 2014, 9:28 p.m.) Review request for Plasma. Repository: plasmate Description --- Use appropiate licensed files for modeltest to comply with dfsg. Diffs - plasmate/modeltest/dynamictreemodel.h 9633755 plasmate/modeltest/dynamictreemodel.cpp fa634b6 plasmate/modeltest/modeltest.h 52b45d9 plasmate/modeltest/modeltest.cpp 98d707c Diff: https://git.reviewboard.kde.org/r/119089/diff/ Testing --- Not needed, it didn't touch any code. Thanks, David Suárez ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Request to MacBook users
Hello, On Friday 13 of June 2014 09:02:55 Martin Gräßlin wrote: What I see on my old MacBook is: * Expose: XF86LaunchA * Dashboard: XF86LaunchB It's the same here in MacoBook Pro 11.1(2013) -- Giorgos Tsiapaliokas terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/ --- (Updated April 24, 2014, 4:38 p.m.) Review request for Plasma. Changes --- I have updated the diff into the latest frameworks branch and I have fixed the issues. Repository: plasmate Description --- The appletPath contains the path of the applet, if the user doesn't give a path then the refresh button of the plasmoidviewer will be hidden because we need the plasmoid path in order to execute `plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically so the user can refresh the plasmoid without having to install the plasmoid manually. Diffs (updated) - plasmoidviewer/main.cpp 009acbb plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 8a125ea plasmoidviewer/view.h d997f15 plasmoidviewer/view.cpp aa89145 Diff: https://git.reviewboard.kde.org/r/116800/diff/ Testing --- 1. paths like ~/kf5/foo/plasmoid work 2. the plasmoid is being loaded even without the --appletPath Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 117750: populate the konsole and enable it by default in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117750/ --- Review request for Plasma. Repository: plasmate Description --- populate the konsole and enable it by default in plasmoidviewer we add a custom message handler which will print all the output to stdout and also it will check from debug messages which come from the category qml and those which are coming from QML Diffs - plasmoidviewer/main.cpp 009acbbe7591b03487913cb1316d5f61e6a2b500 plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml d99c8cd8ebfbbe27ca04ba30c7a2bbe396d1a064 plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml 34db7f6fc6a04ce96cd307455ff15abe6697f194 plasmoidviewer/view.h d997f15d093584f4446bbdb3475c30c98441e728 plasmoidviewer/view.cpp aa8914539358b216b9641da679050f95ba5af512 Diff: https://git.reviewboard.kde.org/r/117750/diff/ Testing --- File Attachments plasmoidviewer_message https://git.reviewboard.kde.org/media/uploaded/files/2014/04/24/8ad4291f-c8b8-4378-8ab0-0330bb01d454__plasmoidviewer_msghandler_reviewboard_ok.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/#review56285 --- Ship it! Ship It! - Giorgos Tsiapaliokas On April 23, 2014, 5:38 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/ --- (Updated April 23, 2014, 5:38 p.m.) Review request for Plasma. Repository: plasmate Description --- The konsole button should be shown only if the konsole is enabled. There is no need to show a button which actually does nothing. Diffs - plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml afe6c1e Diff: https://git.reviewboard.kde.org/r/117631/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117632: Plasmoidviewer-Frameworks: Enable the konsole and fix the spacing.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117632/#review56055 --- Personally I would prefer if there was some spacing between the buttons and the konsole. plasmoidviewer/main.cpp https://git.reviewboard.kde.org/r/117632/#comment39123 Don't enable the konsole yet. Plasmoidviewer doesn't provide any output to the konsole. - Giorgos Tsiapaliokas On April 18, 2014, 6:28 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117632/ --- (Updated April 18, 2014, 6:28 p.m.) Review request for Plasma. Repository: plasmate Description --- This patch enables the konsole and it fixes the spacing. More info on the screenshots. Diffs - plasmoidviewer/main.cpp 009acbb plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 Diff: https://git.reviewboard.kde.org/r/117632/diff/ Testing --- File Attachments before https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/8e659a10-f238-440f-b10a-90533880dc99__konsole_spacing-wrong.png after https://git.reviewboard.kde.org/media/uploaded/files/2014/04/18/c9bb85d3-4f8e-4b9c-bbbf-bc80f7ccf71b__konsole_spacing-ok.png Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117631: Plasmoidviewer-Frameworks: The konsole button should be visible only if the konsole is enabled.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/#review56056 --- plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml https://git.reviewboard.kde.org/r/117631/#comment39124 you don't need it (check below) plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml https://git.reviewboard.kde.org/r/117631/#comment39126 The konsoleButton doesn't change the visibility of the konsole. The onClicked signal doesn't exist. plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml https://git.reviewboard.kde.org/r/117631/#comment39125 replace konsoleVisible with desktop.konsoleVisible We already know that there is a property called desktop from view.cpp so we are already familiar with desktop.*. Introducing a new property makes it harder to understand the code. desktop.* - its coming from view.cpp konsoleVisible - desktop.konsoleVisible - its coming from view.cpp - Giorgos Tsiapaliokas On April 18, 2014, 6:15 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117631/ --- (Updated April 18, 2014, 6:15 p.m.) Review request for Plasma. Repository: plasmate Description --- The konsole button should be shown only if the konsole is enabled. There is no need to show a button which actually does nothing. Diffs - plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml afe6c1e Diff: https://git.reviewboard.kde.org/r/117631/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal to hide raw QML errors in Plasma Next
On Friday 18 of April 2014 10:04:02 Bhushan Shah wrote: This is case, but still you are missing two stuffs.. 1) We still have some qDebug and kDebug kDebug doesn't count because it is deprecated code which should be replaced. qDebug is using default as its category. default = false will remove it from the output. The problem exists if the developer is writing something and he is still using qDebug and friends. Then yes the developer can't filter the output, but he shouldn't use qDebug anyway. Also even if the qDebug doesn't get ported because it exists in some framework or something in which the developer doesn't want to spend time fixing it, he can just turn off everything and enable only his category. 2) Debug messages from qml files Debug messages from qml belong to the qml category. Also the debug messages from qml aren't special. They also have a type console.log - QtDebugMsg, console.warn - QtWarningMsg etc -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal to hide raw QML errors in Plasma Next
Hello, I also like the more user friendly ui errors. On Thursday 17 of April 2014 17:49:35 Aleix Pol wrote: +1, I would like to add though that we should probably adopt a 0 qDebug policy as well. It's useful to have them when working on a feature, but having things like: plasma_shell(27403)/(systemtray) SystemTray::Task::setStatus: ST2 status changed 2 plasma_shell(27403)/(qml) onCompleted: WindowModel(0x4cd9a50) Is random and makes it harder to debug the actual problems. Aleix If we have 0 debug output how does this makes it easier? The existing debug output, if you filter it gives some hints about what is going on, IMO this is very useful. No? In Qt 5.3 there is an way to filter the output *without* changing the source code of the application. Here is an example, if you are using qC* for logging and your category is named foo then you can filter the output by doing $ export QT_LOGGING_CONF=/home/bob/rulesWhatEverName $ plasma-shell the rulesWhatEverName file must contain something like [Rules] * = false #hide all the output foo = true #show only the output for my project Am I missing something? thanks, Giorgos -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117450: Add Milou to the default panel layout
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117450/#review55488 --- I would prefer if we didn't add milou to the panel by default, because a. IMO the panel will become over populated. b. IMO the first thing the user will notice after an update in KDE is the panel. The user will see that there is a new plasmoid which didn't exist back in KDE4 by default. IIRC we had said that plasma next won't have any new big ui changes and this one seems to me a big one. Considering that users will update from KDE4 to the new major version, a changed panel may make plasma look evil again. - Giorgos Tsiapaliokas On April 9, 2014, 6:22 p.m., Vishesh Handa wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117450/ --- (Updated April 9, 2014, 6:22 p.m.) Review request for Plasma. Repository: plasma-desktop Description --- KRunner is hidden away as it is only accessible via a shortcut. It will be nice to have the plasmoid visible by default. It will not be an extra dependency as plasma-workspace already depends on Milou because of KRunner. Diffs - desktoppackage/contents/layout.js 303e7af Diff: https://git.reviewboard.kde.org/r/117450/diff/ Testing --- Thanks, Vishesh Handa ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116983: Fix the height of the buttonsbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116983/ --- (Updated March 24, 2014, 12:26 p.m.) Review request for Plasma. Changes --- I have removed the margins because they were pushing the buttons away from the background and also I don't think that they should exist. I have attached another screenshot in which the buttons and the background align correctly. Here the refreshButton has implicitHeight 26 and the background 52(tested with console.log) but the background doesn't seem to have 52, its more like 26(see the image without_margins.png). Repository: plasmate Description --- If I am not mistaken a regression has been introduced in plasmoidviewer. This patch solves the issue. Diffs (updated) - plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml c3624a5 Diff: https://git.reviewboard.kde.org/r/116983/diff/ Testing --- I have attached two images 1 without my patch and one with my patch File Attachments (updated) after.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png before.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png plasmoidviewer without margins https://git.reviewboard.kde.org/media/uploaded/files/2014/03/24/19f7cde7-7736-4199-b4f6-938b5fd75772__without_margins.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: fix for installed libksysguard-headers
Hello, On Saturday 22 of March 2014 11:19:45 Treeve Jelbert wrote: the following patches fix the installed headers so that they are usable by other programs. I do not have access to reviewboad, so I am submitting them here. reviewboard needs the credentials from https://identity.kde.org/ you have to create an account and then you will be able to login in the reviewboard and create reviews. Also reviewboard makes it easier for the rest of the team to review the patches. -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116983: Fix the height of the buttonsbar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116983/ --- Review request for Plasma. Repository: plasmate Description --- If I am not mistaken a regression has been introduced in plasmoidviewer. This patch solves the issue. Diffs - plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml afe6c1e35115805d3db5a8eaf24207dc386ed09c Diff: https://git.reviewboard.kde.org/r/116983/diff/ Testing --- I have attached two images 1 without my patch and one with my patch File Attachments after.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/145ef74a-1936-4237-b09d-022fe128baa2__after.png before.png https://git.reviewboard.kde.org/media/uploaded/files/2014/03/22/ebdf5aee-69e2-4c79-a5e4-7501059ceab2__before.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 116800: introduce the command line argument --appletPath in plasmoidviewer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116800/ --- Review request for Plasma. Repository: plasmate Description --- The appletPath contains the path of the applet, if the user doesn't give a path then the refresh button of the plasmoidviewer will be hidden because we need the plasmoid path in order to execute `plasmapkg2 -u $myapplet`. Also this patch installs the plasmoid automatically so the user can refresh the plasmoid without having to install the plasmoid manually. Diffs - plasmoidviewer/main.cpp e8e9b98 plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml 742f1d1 plasmoidviewer/view.h d997f15 plasmoidviewer/view.cpp 76fd542 Diff: https://git.reviewboard.kde.org/r/116800/diff/ Testing --- 1. paths like ~/kf5/foo/plasmoid work 2. the plasmoid is being loaded even without the --appletPath Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Move plasmate to git-next?
Since nobody disagrees I will make the request to the sysadmins. I will inform you again when the move is completed. -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Move plasmate to git-next?
Hello, if nobody hasn't any objections I would like to move plasmate to git-next.kde.org. Any objections? thanks, -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposal: make libplasmaquick semi-privare
On 02/14/2014 06:49 PM, Sebastian Kügler wrote: On Friday, February 14, 2014 16:38:29 Marco Martin wrote: I would like for now to *not* install headers for libplasmaquick for now, So that would mean the systray has a copy of a header? Maybe in order to avoid making copies of the headers we could * add a cmake, build and runtime warning * set soversion to * add to every header a comment which will say that this lib is private and if we want to make it even more clear we could *also* * rename the library to libplasmaquickprivate * add the namespace PlasmaQuickPrivate also since I was one of the people who wanted this lib I volunteer for the task :) -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate dragdrop breaks
Hello, On Tuesday, January 28, 2014 03:36:14 PM Aleix Pol wrote: Hi, I've been encountering lately that when I drag and drop something to plasmate it crashes badly (it enters an endless loop where the only output I guess that you mean plasmoidviewer. Plasmate isn't ported yet. Is the backtrace useful or do you get the classic v4 backtrace? Also I see that I don't have such problem when dropping things to Plasma Shell. Now, should we really debug this? considering that plasmoidviewer combined with qmlprofiler doesn't give the right information we will have to do the plasmoidviewer differently which means that the code will change a lot. So no:) Unfortunatelly before 14th February I won't be able to work on anything because I have the exams for my college. Fixing plasmoidviewer is on my TODO list after 14th February. Sorry for not being able to help sooner. -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113236: make the warnings accessible from QML
On Jan. 30, 2014, 2:59 p.m., David Edmundson wrote: This patch doesn't match the review description at all. It just prints the error messages. the idea of the patch was to pass the errors with m_qmlObject-rootObject()-setProperty(warnings, warn); because we needed it for plasmoidviewer. But with the qC* methods there is a better way of doing it. qInstallMessageHandler and the qC* methods will do the job. So I will discard this review - Giorgos --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113236/#review48630 --- On Oct. 14, 2013, 7:51 a.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113236/ --- Review request for Plasma. Repository: plasma-framework Description --- This patch takes the QQmlErrors of QQmlEngine::errors signal and passes them to a property of QmlObject, so the errors become accessible from QML. Diffs - src/scriptengines/qml/plasmoid/appletinterface.cpp 214a4b1 Diff: https://git.reviewboard.kde.org/r/113236/diff/ Testing --- I have create a `property string warnings` inside in a containment and I was able to print the warnings with `onWarningsChanged: console.log(warnings)` Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 113236: make the warnings accessible from QML
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/113236/ --- Status -- This change has been discarded. Review request for Plasma. Repository: plasma-framework Description --- This patch takes the QQmlErrors of QQmlEngine::errors signal and passes them to a property of QmlObject, so the errors become accessible from QML. Diffs - src/scriptengines/qml/plasmoid/appletinterface.cpp 214a4b1 Diff: https://git.reviewboard.kde.org/r/113236/diff/ Testing --- I have create a `property string warnings` inside in a containment and I was able to print the warnings with `onWarningsChanged: console.log(warnings)` Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: System Tray
Hello, On 13 January 2014 14:01, DmitriyBoyko . dimitriy.bo...@gmail.com wrote: I am using vertial task bar and I think that it would look better if icons were not so big (please see attahed file). if you have a patch please submit it to git.reviewboard.kde.org I can't install systemtray2 (the one generated by Plasmate) widget on my system, it simply says that it failed (where to look for log?). there is no plasmate for Qt5/KF5. There is no binary. So you are using plasmate1 which doesn't support yet KF5/Qt5 because its not ported yet :) So in order to test systemtray which is based on KF5/Qt5 just do * install the frameworks branch of the repository plasmate * execute on the terminal the command `plasmoidviewer -a org.kde.plasma.systemtray` make sure that the output of the command `which plasmoidviewer` is something like /opt/kf5/bin/plasmoidviewer cheers -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114493: Plasmate: Merge plasmoidviewer2 branch into frameworks
On Dec. 16, 2013, 1:46 p.m., Sebastian Kügler wrote: plasmoidviewer/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/114493/diff/2/?file=225327#file225327line22 Please make this org.kde.plasma.plasmoidviewershell, we're moving everything from org.kde.* to org.kde.plasma.* Bhushan Shah wrote: @sebas If you don't mind can we install it to org.kde.plasmate.plasmoidviewershell? (Given this is not plasma stuff actually) Sebastian Kügler wrote: That's fine with me. IMO we should avoid the name plasmate into the QML import name. The name plasmate refers to the ide and the repository. I *really* want to make clear even from the QML imports that plasmate doesn't try to take any distance from plasma. So how would we name it, if it was kickoff or rssnow or slc? - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114493/#review45779 --- On Dec. 16, 2013, 12:36 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114493/ --- (Updated Dec. 16, 2013, 12:36 p.m.) Review request for Plasma. Repository: plasmate Description --- This is a merge request for plasmoidviewer2 branch into the frameworks branch. Plasmoidviewer2 branch contains some missing features and bug fixes. Diffs - plasmoidviewer/CMakeLists.txt 30de8e2 plasmoidviewer/fullview.h 7d4c70d plasmoidviewer/fullview.cpp 898931a plasmoidviewer/main.cpp f3cdb22 plasmoidviewer/qmlpackages/containment/Messages.sh c8a9b60 plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js 62e149a plasmoidviewer/qmlpackages/containment/contents/config/main.xml d88 plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml b23e098 plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml 33d72c0 plasmoidviewer/qmlpackages/containment/contents/ui/main.qml 6558710 plasmoidviewer/qmlpackages/containment/metadata.desktop 9ddd217 plasmoidviewer/qmlpackages/shell/contents/views/Background.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml e5bedf3 plasmoidviewer/qmlpackages/shell/contents/views/Konsole.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/views/SdkButtons.qml PRE-CREATION plasmoidviewer/view.h 0e2e48c plasmoidviewer/view.cpp fc008b0 Diff: http://git.reviewboard.kde.org/r/114493/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Crash: [Plasmate] [2013-12-06] Automatic crash report generated by DrKonqi
in x11EventSourceDispatch (s=0x2368e00, callback=0x0, user_data=0x0) at kernel/qguieventdispatcher_glib.cpp:146 #31 0x7fc0d87502d6 in g_main_context_dispatch () from /usr/lib64/libglib-2.0.so.0 #32 0x7fc0d8750628 in ?? () from /usr/lib64/libglib-2.0.so.0 #33 0x7fc0d87506cc in g_main_context_iteration () from /usr/lib64/libglib-2.0.so.0 #34 0x7fc0df7ded55 in QEventDispatcherGlib::processEvents (this=0x22d6b30, flags=...) at kernel/qeventdispatcher_glib.cpp:425 #35 0x7fc0e025f936 in QGuiEventDispatcherGlib::processEvents (this=optimized out, flags=...) at kernel/qguieventdispatcher_glib.cpp:204 #36 0x7fc0df7b0d0f in QEventLoop::processEvents (this=this@entry=0x7fff4bfa7c80, flags=...) at kernel/qeventloop.cpp:149 #37 0x7fc0df7b1005 in QEventLoop::exec (this=this@entry=0x7fff4bfa7c80, flags=...) at kernel/qeventloop.cpp:204 #38 0x7fc0df7b613b in QCoreApplication::exec () at kernel/qcoreapplication.cpp:1221 #39 0x7fc0e01c106c in QApplication::exec () at kernel/qapplication.cpp:3823 #40 0x00427d10 in main (argc=1, argv=0x7fff4bfa7eb8) at /usr/src/debug/plasmate-1.0/plasmate/main.cpp:56 ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Plasmate next
Hello, I would like to share some of my thoughts about plasmate, Until now we have released 1.0 and we have only one blocker which prevents the 1.1 release(see bug 317826). After this patch gets solved I would like to do the following a. release 1.1 having at least one release candidate and this will be the last minor release of plasmate for KDE4. After 1.1 only bug fixes will be added to plasmate. b. make the master branch depend on kf5 and qt5 Why I don't want another plasmate release after 1.1 for KDE4? The answer is simple because we don't have the man power to maintain and develop features in two different codebases and second we have already decided what we want from plasmate. We want to do one thing and do it well and I believe that we are already there. So what do you think? thanks, -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: How to change the plasma theme?
On 29 November 2013 16:17, Marco Martin notm...@gmail.com wrote: theme.setUseGlobalSettings(false); theme.setThemeName(themeName); and this was definately one of my shiniest moments. :) thanks -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
plasma-framework cmake issue?
Hello, I am having a KDE4Support cmake issue in plasma-framework. I have attached the output of cmake. Do you know what is going wrong? thanks in advance -- Giorgos Tsiapaliokas (terietor) terietor.org cmake -DCMAKE_INSTALL_PREFIX=$KF5 .. -- The C compiler identification is GNU 4.8.1 -- The CXX compiler identification is GNU 4.8.1 -- Check for working C compiler: /usr/lib/ccache/bin/cc -- Check for working C compiler: /usr/lib/ccache/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Check for working CXX compiler: /usr/lib/ccache/bin/c++ -- Check for working CXX compiler: /usr/lib/ccache/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- KF5[InstallDirs]: Loaded settings from /opt/kf5/share/ECM/kde-modules/KDEInstallDirs.cmake -- KF5[CMake]: Loaded settings from /opt/kf5/share/ECM/kde-modules/KDECMakeSettings.cmake -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL -- Performing Test __KDE_HAVE_W_OVERLOADED_VIRTUAL - Success -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_HAS_DEPRECATED_ATTR -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success -- KF5[Compiler]: Loaded settings from /opt/kf5/share/ECM/kde-modules/KDECompilerSettings.cmake -- KF5[KIdleTime]: Loaded /opt/kf5/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake -- KF5[ItemModels]: Loaded /opt/kf5/lib64/cmake/ItemModels/ItemModelsConfig.cmake -- KF5[KWidgetsAddons]: Loaded /opt/kf5/lib64/cmake/KWidgetsAddons/KWidgetsAddonsConfig.cmake -- KF5[KWindowSystem]: Loaded /opt/kf5/lib64/cmake/KWindowSystem/KWindowSystemConfig.cmake -- KF5[KCodecs]: Loaded /opt/kf5/lib64/cmake/KCodecs/KCodecsConfig.cmake -- KF5[KArchive]: Loaded /opt/kf5/lib64/cmake/KArchive/KArchiveConfig.cmake -- KF5[KCoreAddons]: Loaded /opt/kf5/lib64/cmake/KCoreAddons/KCoreAddonsConfig.cmake -- KF5[Solid]: Loaded /opt/kf5/lib64/cmake/Solid/SolidConfig.cmake -- KF5[ThreadWeaver]: Loaded /opt/kf5/lib64/cmake/ThreadWeaver/ThreadWeaverConfig.cmake -- KF5[KConfig]: Loaded /opt/kf5/lib64/cmake/KConfig/KConfigConfig.cmake -- KF5[KAuth]: Loaded /opt/kf5/lib64/cmake/KAuth/KAuthConfig.cmake -- KF5[KJS]: Loaded /opt/kf5/lib64/cmake/KJS/KJSConfig.cmake -- KF5[KWallet]: Loaded /opt/kf5/lib64/cmake/KWallet/KWalletConfig.cmake -- KF5[KDBusAddons]: Loaded /opt/kf5/lib64/cmake/KDBusAddons/KDBusAddonsConfig.cmake -- KF5[KI18n]: Loaded /opt/kf5/lib64/cmake/KI18n/KI18nConfig.cmake -- KF5[KGuiAddons]: Loaded /opt/kf5/lib64/cmake/KGuiAddons/KGuiAddonsConfig.cmake -- KF5[KConfigWidgets]: Loaded /opt/kf5/lib64/cmake/KConfigWidgets/KConfigWidgetsConfig.cmake -- KF5[KService]: Loaded /opt/kf5/lib64/cmake/KService/KServiceConfig.cmake -- KF5[ItemViews]: Loaded /opt/kf5/lib64/cmake/ItemViews/ItemViewsConfig.cmake -- KF5[KNotifications]: Loaded /opt/kf5/lib64/cmake/KNotifications/KNotificationsConfig.cmake -- KF5[KIconThemes]: Loaded /opt/kf5/lib64/cmake/KIconThemes/KIconThemesConfig.cmake -- KF5[KCompletion]: Loaded /opt/kf5/lib64/cmake/KCompletion/KCompletionConfig.cmake -- KF5[KJobWidgets]: Loaded /opt/kf5/lib64/cmake/KJobWidgets/KJobWidgetsConfig.cmake -- KF5[KConfigWidgets]: Loaded /opt/kf5/lib64/cmake/KConfigWidgets/KConfigWidgetsConfig.cmake -- KF5[Sonnet]: Loaded /opt/kf5/lib64/cmake/Sonnet/SonnetConfig.cmake -- KF5[KTextWidgets]: Loaded /opt/kf5/lib64/cmake/KTextWidgets/KTextWidgetsConfig.cmake -- KF5[XmlGui]: Loaded /opt/kf5/lib64/cmake/XmlGui/XmlGuiConfig.cmake -- KF5[KCrash]: Loaded /opt/kf5/lib64/cmake/KCrash/KCrashConfig.cmake CMake Warning at /opt/kf5/lib64/cmake/KDeclarative/KDeclarativeConfig.cmake:31 (find_package): Found package configuration file: /opt/kf5/lib64/cmake/KIO/KIOConfig.cmake but it set KIO_FOUND to FALSE so package KIO is considered to be NOT FOUND. Reason given by package: The following imported targets are referenced, but are missing: KF5::KBookmarks Call Stack (most recent call first): /opt/kf5/lib64/cmake/KDeclarative/KDeclarativeConfig.cmake:58 (find_dependency) /opt/kf5/share/ECM/find-modules/FindKF5.cmake:208 (find_package) CMakeLists.txt:42 (find_package) -- KF5[KDeclarative]: Loaded /opt/kf5/lib64/cmake/KDeclarative/KDeclarativeConfig.cmake -- KF5[KBookmarks]: Loaded /opt/kf5/lib64/cmake/KBookmarks/KBookmarksConfig.cmake -- KF5[KUnitConversion]: Loaded /opt/kf5/lib64/cmake/KUnitConversion/KUnitConversionConfig.cmake -- KF5[Kross]: Loaded /opt/kf5/lib64/cmake/Kross/KrossConfig.cmake -- Found KF5: /opt/kf5/lib64/cmake/KIdleTime/KIdleTimeConfig.cmake} (found version 5.0.0) found components: CMake Compiler InstallDirs KIdleTime ItemModels KWidgetsAddons KWindowSystem KCodecs KArchive KCoreAddons Solid ThreadWeaver KConfig KAuth KJS KWallet KDBusAddons KI18n KGuiAddons KConfigWidgets KService ItemViews KNotifications
Re: kde-workspace fails to build
Hello, thank you for your answers. With today's clean install it builds. :) Regards, Giorgos -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
kde-workspace fails to build
Hello, kde-workspace fails to build. I have attached the build error. Any ideas why this is happening? :) Regards, Giorgos P.S.: my install dir and build dir are clean. -- Giorgos Tsiapaliokas (terietor) terietor.org build.log Description: Binary data ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 113207: Plasmate: Request for merge, branch plasmoidviewer2 to frameworks-scratch
On Oct. 12, 2013, 7:20 p.m., Sebastian Kügler wrote: Code looks pretty good, there's a bunch of nitpicks, but mostly minor stuff. What I'm not happy about is the amount of -- apparently -- copied code, the shell package and the containment. If we need those things, plasmate should probably just depend on the respective repos. Copying code is just a huge maintainance burden. Nevertheless, I think we can merge this already. What I'm not happy about is the amount of -- apparently -- copied code, the shell package and the containment. If we need those things, plasmate should probably just depend on the respective repos. Copying code is just a huge maintainance burden. I am not happy either with the duplication of code, but for the time being we don't have a complete plasmoidviewer so we aren't sure 100% about the final implementation. So I guess its ok for the moment to keep those copies(which are slightly different from the originals). My original idea was 1. lets make something which is working 2. lets see if we can reduce/remove the duplicated code 3. open another review and lets see together if its ok IMO having duplicated code is one of the worst things that we could ever had and I really want to avoid it but I believe that this is not the moment that we sit down and see how can we remove this code. - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113207/#review41613 --- On Oct. 11, 2013, 6:40 p.m., Antonis Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113207/ --- (Updated Oct. 11, 2013, 6:40 p.m.) Review request for Plasma. Repository: plasmate Description --- The plasmoidviewer2 branch contains the initial support for plasmoidviewer2. Right now the plasmoidviewer is able to load the applet, setup the location and the formfactor. Diffs - CMakeLists.txt 2b50b09 plasmoidviewer/CMakeLists.txt d36fddb plasmoidviewer/main.cpp f8a6b32 plasmoidviewer/qmlpackages/containment/Messages.sh PRE-CREATION plasmoidviewer/qmlpackages/containment/contents/code/LayoutManager.js PRE-CREATION plasmoidviewer/qmlpackages/containment/contents/config/main.xml PRE-CREATION plasmoidviewer/qmlpackages/containment/contents/ui/AppletAppearance.qml PRE-CREATION plasmoidviewer/qmlpackages/containment/contents/ui/BusyOverlay.qml PRE-CREATION plasmoidviewer/qmlpackages/containment/contents/ui/main.qml PRE-CREATION plasmoidviewer/qmlpackages/containment/metadata.desktop PRE-CREATION plasmoidviewer/qmlpackages/shell/Messages.sh PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/applet/AppletError.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/applet/CompactApplet.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/applet/DefaultCompactRepresentation.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/configuration/AppletConfiguration.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/configuration/ConfigCategoryDelegate.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/configuration/ConfigurationShortcuts.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/configuration/MouseEventInputButton.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/defaults PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/layout.js PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/loader.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/contents/views/Desktop.qml PRE-CREATION plasmoidviewer/qmlpackages/shell/metadata.desktop PRE-CREATION plasmoidviewer/view.h PRE-CREATION plasmoidviewer/view.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/113207/diff/ Testing --- Thanks, Antonis Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: plasmoidviewer 2 merge blockers?
Hello, On 10 October 2013 15:48, Sebastian Kügler se...@kde.org wrote: What is holding back the merge from your point of view? it depends from the containment. Right now `plasmoidviewer -a foo` will use the plasmoidviewer's containment which is missing * more testing and someone to review the code * no way to access the plasmoid's settings * formfactor/location can't be changed from the view, only from the command line, like `plasmoidviewer -a foo1 -l foo2 -f foo3` * no konsolepreviewer, ok we can live without this one :) * the ui isn't perfect(check the attached image) *but* if we use an existing containment like `plasmoidviewer -a org.kde.example.widgetgallery -c org.kde.desktopcontainment` then its mostly ok, but we are still missing * more testing and someone to review the code also some other features are missing like to change the width and height using args, but those aren't blockers. So, a. we can merge the plasmoidviewer now into frameworks-scratch and change the default containment in order to provide most of the plasmoidviewer's 1 functionality and continue working on plasmoidviewer2 branch the rest of the features. b. we can wait until its ready(including all the features and the plasmoidviewer's containment). I believe that option a is good enough for the time being because it does most of the job and also plasmoidviewer 1 didn't have a custom containment in KDE4. a or b? :) Regards, Giorgos -- Giorgos Tsiapaliokas (terietor) terietor.org attachment: plasmoidviewer2.png___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
kde-workspace fails to configure???
Hello, I have tried to install kde-workspace[master] but it fails due to some cmake issue. I have attached the output from cmake. The build is with a clean install and build directory, Any ideas why this error occurs? Regards, Giorgos -- Giorgos Tsiapaliokas (terietor) terietor.org cmake.log Description: Binary data ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112723: add a visible property in the toolBox
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112723/
---
(Updated Sept. 23, 2013, 3:32 p.m.)
Status
--
This change has been discarded.
Review request for Plasma.
Description
---
The toolBox should have a visible property in order to be
possible to do
property Item toolBox
onToolBoxChanged: {
visible: false
}
Diffs
-
src/scriptengines/qml/plasmoid/appletinterface.cpp 4e100d9
Diff: http://git.reviewboard.kde.org/r/112723/diff/
Testing
---
the default value of the visible property is true,
so the existing behavior doesn't change.
Thanks,
Giorgos Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 112723: add a visible property in the toolBox
On Sept. 14, 2013, 6:22 p.m., Sebastian Kügler wrote:
Why should the (abstract) toolbox care? What do you want to achieve?
If I understood the code of AppletInterface correctly, If we use a shell
package like org.kde.desktop which specifies a toolbox in its defaults
file AppletInterface will create a toolbox and it will add it in the view using
QmlObject::createObjectFromSource. So the view will end up with a toolbox by
default. But for the plasmoidviewer
we don't want a toolbox and with this patch I was able to hide the toolbox.
- Giorgos
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112723/#review40026
---
On Sept. 14, 2013, 11:38 a.m., Giorgos Tsiapaliokas wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112723/
---
(Updated Sept. 14, 2013, 11:38 a.m.)
Review request for Plasma.
Description
---
The toolBox should have a visible property in order to be
possible to do
property Item toolBox
onToolBoxChanged: {
visible: false
}
Diffs
-
src/scriptengines/qml/plasmoid/appletinterface.cpp 4e100d9
Diff: http://git.reviewboard.kde.org/r/112723/diff/
Testing
---
the default value of the visible property is true,
so the existing behavior doesn't change.
Thanks,
Giorgos Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 112723: add a visible property in the toolBox
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112723/
---
Review request for Plasma.
Description
---
The toolBox should have a visible property in order to be
possible to do
property Item toolBox
onToolBoxChanged: {
visible: false
}
Diffs
-
src/scriptengines/qml/plasmoid/appletinterface.cpp 4e100d9
Diff: http://git.reviewboard.kde.org/r/112723/diff/
Testing
---
the default value of the visible property is true,
so the existing behavior doesn't change.
Thanks,
Giorgos Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 112447: implement the PlasmaView library
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112447/ --- Review request for Plasma. Description --- This patch creates a new library out of the shell dir. We need this library in order to implement plasmoidviewer 2.0 Diffs - src/CMakeLists.txt 281d146 src/plasmaview/CMakeLists.txt PRE-CREATION src/plasmaview/PlasmaViewConfig.cmake.in PRE-CREATION src/plasmaview/configview.h PRE-CREATION src/plasmaview/configview.cpp PRE-CREATION src/plasmaview/containmentconfigview_p.h PRE-CREATION src/plasmaview/containmentconfigview_p.cpp PRE-CREATION src/plasmaview/currentcontainmentactionsmodel_p.h PRE-CREATION src/plasmaview/currentcontainmentactionsmodel_p.cpp PRE-CREATION src/plasmaview/includes/PlasmaView/ConfigView PRE-CREATION src/plasmaview/includes/PlasmaView/ContainmentConfigView PRE-CREATION src/plasmaview/includes/PlasmaView/ShellPluginLoader PRE-CREATION src/plasmaview/includes/PlasmaView/View PRE-CREATION src/plasmaview/shellpackage_p.h PRE-CREATION src/plasmaview/shellpackage_p.cpp PRE-CREATION src/plasmaview/shellpluginloader.h PRE-CREATION src/plasmaview/shellpluginloader.cpp PRE-CREATION src/plasmaview/view.h PRE-CREATION src/plasmaview/view.cpp PRE-CREATION src/shell/CMakeLists.txt 3da019f src/shell/configview.h 2e8f68f src/shell/configview.cpp fea5a73 src/shell/containmentconfigview.h 619fa14 src/shell/containmentconfigview.cpp 235a33f src/shell/currentcontainmentactionsmodel.h db94da1 src/shell/currentcontainmentactionsmodel.cpp c955bef src/shell/shellcorona.cpp ffdbfe8 src/shell/shellpackage.h 99dc460 src/shell/shellpackage.cpp 74aea5c src/shell/shellpluginloader.h 1d3dade src/shell/shellpluginloader.cpp 8b2e1dd src/shell/view.h 7e6b2d9 src/shell/view.cpp a0c6168 Diff: http://git.reviewboard.kde.org/r/112447/diff/ Testing --- The code is locate at g...@git.kde.org:clones/plasma-framework/tsiapaliwkas/pf5.git . how to test it * git clone g...@git.kde.org:clones/plasma-framework/tsiapaliwkas/pf5.git * cd pf5 * git checkout split7 * build it and install it * use plasma-shell I haven't noticed any issues. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Implement plasmoid configuration dialog in QtQuick 1.1
Hello, On 31 August 2013 20:33, crist...@gmail.com wrote: Hi What is the easiest way of implementing a plasmoid configuration dialog in a mixed C++ and QML application ? here is an example http://quickgit.kde.org/?p=declarative-plasmoids.gita=treeh=788eea04850367f217c2b2d991c254552925025chb=9c4fe72e75cf5faf201acd0f6a4485e4135b5d8ff=rssnow Some hints for using only QML are provided in http://aseigo.blogspot.fr/2013/02/elegant-plasmoid-configuration.html , but this seems to be available only for Qt Quick 2.0 yes they are available only in plasma2 -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: naming the next major release
Hello, On 21 August 2013 12:49, Marco Martin notm...@gmail.com wrote: My vote would go for Plasma. +1, just Plasma without KDE. On 21 August 2013 21:38, Martin Graesslin mgraess...@kde.org wrote: another idea: let's drop the version number completely and only use it internally (bugtracker, libs, etc.) I was thinking this too. But when a new version comes out how could we promote it? Also if a product doesn't have a version then this could mean that it is rolling. Yes not always but this is the first thought that goes through the mind. No? -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: naming the next major release
On 22 August 2013 21:26, David Edmundson da...@davidedmundson.co.uk wrote: One thing that wasn't clear to me on the original proposals and has just been mentioned by Giorgos is the prefix KDE. KDE is not just the community but also an umbrella brand for the technology created by the KDE community [0]. I have heard other people make comments about how Plasma is trying to distance itself from the KDE community. I don't agree with those people, but we shouldn't fuel that fire. Displaying that it is part of the KDE umbrella is IMHO important. When I said lets remove the KDE from KDE Plasma was in order to emphasize that KDE is the community. TBH I don't believe that by removing the KDE, plasma is taking some distance from KDE. Also there are a lot of projects inside KDE which aren't using the KDE word and they don't take any distance from KDE, for instance the most references in plasma active are Plasma Active and not KDE Plasma Active, but PA doesn't have any distance from KDE. I believe that projects take some distance from KDE when they stop referring to it and not when they remove the KDE word, but that is just me of course :) -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 112157: replace deprecated widgets
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112157/ --- Review request for Plasma. Description --- Hello, * this replaces the deprecated widgets from the plasmaengineexplorer * makes the serviceviewer.ui nicer( I have attached a screenshot) Diffs - engineexplorer/CMakeLists.txt 1466542 engineexplorer/engineexplorer.h 5c19fa6 engineexplorer/engineexplorer.cpp a3f2e1f engineexplorer/engineexplorer.ui 65e70b4 engineexplorer/ktreeviewsearchline.cpp 734ef94 engineexplorer/main.cpp 8eae7a3 engineexplorer/serviceviewer.h dc0b36b engineexplorer/serviceviewer.cpp d7e8e5a engineexplorer/serviceviewer.ui b91b784 Diff: http://git.reviewboard.kde.org/r/112157/diff/ Testing --- it is building/installing/working correctly. I have noticed any issue File Attachments http://git.reviewboard.kde.org/media/uploaded/files/2013/08/19/layout.png Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Need help to setup build environment of KF5
show us the cmake errors :) -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110288: Checks if an optional field was instantiated before accessing it
On May 4, 2013, 9:14 a.m., Giorgos Tsiapaliokas wrote: The patch is ok, it can go in. Are you familiar with out git workflow policy? http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy If you have any questions don't hesitate to ask :) Albert Astals Cid wrote: Janitorial dude question: Has this been commited and you forgot to mark it as submitted or it does still need submitting? No this hasn't been submitted yet. I am waiting for the contributor. I am aware of the existence of this review. If the contributor doesn't show up I will submit it. - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110288/#review31994 --- On May 3, 2013, 8:38 p.m., Denis Falqueto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110288/ --- (Updated May 3, 2013, 8:38 p.m.) Review request for Plasma. Description --- The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not. This addresses bug 319291. http://bugs.kde.org/show_bug.cgi?id=319291 Diffs - plasmate/mainwindow.cpp 1ef5a81 Diff: http://git.reviewboard.kde.org/r/110288/diff/ Testing --- I've created a data engine in python successfully. Thanks, Denis Falqueto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: How to build KDE Workspace on top of KF5?
On 16 August 2013 14:28, Bhushan Shah bhus...@gmail.com wrote: In this source-dir, build-dir and kdedir is easy to understand but what to enter instead of qtdir? I have installed project-neon5-session. It installed inside /opt/project-neon5. qtdir is path in which your qt5 are libraries are. You can find this path from the command `qmake -v`. In my machine it gives $ qmake -v QMake version 3.0 Using Qt version 5.2.0 in /home/tsiapaliokas/src/kf5/qt5/qtbase/lib so in my kdesrc-buildrc I have this qtdir /home/tsiapaliokas/src/kf5/qt5/build/qtbase/ -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Compiling QT5 for KF5
On 14 August 2013 11:53, Bhushan Shah bhus...@gmail.com wrote: Wish I could get PKGBUILDs, Its available for 64 bit only. I asked Andrea Scarpino but no reply yet, May be different time zone! :-) Thanks! https://aur.archlinux.org/packages/?O=0K=kf5 -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: framework5/plasma2
Hello, On 26 July 2013 22:26, Heena Mahour heena...@gmail.com wrote: Yeah , so how to proceed with porting plasma2 plasmoids. I want to ask how plasma2 plasmoid would be tested as just start plasma-shell and load your plasmoid, then in order to reload it remove your plasmoid and load it again. -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KLocale imports
On 3 July 2013 22:24, Marco Martin notm...@gmail.com wrote: there is already one http://techbase.kde.org/Development/Tutorials/Plasma/QML/API Yes I wasn't very clear sorry. I was wondering if we kept the documentation in the c++ files if the situation could be improved. Because right now we don't have a way to review the changes except from 'I have changed this in the wiki, can someone have a look at this one?'. Also when the documentation is more tied to the source isn't it easier to maintain it? -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: KLocale imports
On 1 July 2013 22:59, Kai Uwe Broulik k...@privat.broulik.de wrote: I think this should be stated in the Plasma QML API techbase page with link to the KLocale API docs and/or notable properties (such as prettyFormatDuration)? Is it a good approach to keep the how to use this component in QML in a wiki page? We could just keep it in the c++ files. -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: wierd problems about systemmonitor's acpi temperature
Hello, On 22 May 2013 07:16, bruce bruce...@gmail.com wrote: 2, when wierd problem #2 happened, i checked directory '/proc/acpi/thermal_zone',and found its gone, but i am sure it really did exists for a long time. same machine, same operating system, why does this happens? does this one /sys/class/thermal/ exists on your machine? -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: if i define a function testfunc() in plasmoid /contents/main.js, when user add two instances of my plasmoid to taskbar, in these two instances, is function testfunc() a same object?
Hello, your function will be a function in all the instances of your plasmoid, but it won't live in the same memory. What exactly do you want to do? On 13 May 2013 14:22, bruce bruce...@gmail.com wrote: if i define testfunc.PROPERTY1=1, is it a same property? ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109965: Refactor assetimporters
On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: assetimporters/projectgutenberg/src/gutenbergdatabase.cpp, lines 328-338 http://git.reviewboard.kde.org/r/109965/diff/1/?file=138225#file138225line328 this can be done once and then the value cached now m_partnerId takes the value of the partnerId(). So do we still need to cache the value? - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/#review30976 --- On April 20, 2013, 10:52 a.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- (Updated April 20, 2013, 10:52 a.m.) Review request for Plasma. Description --- This patch * removes the duplicated code in assetimporters * adds asset's size into the db * and fixes a few small issues Diffs - assetimporters/CMakeLists.txt 24e76a0 assetimporters/database-common/channelscatalog.h 5d39c02 assetimporters/database-common/channelscatalog.cpp 6ca0aef assetimporters/database-common/database.h 9883216 assetimporters/database-common/database.cpp e860bdd assetimporters/kdeartwork-wallpapers/CMakeLists.txt 56d19b9 assetimporters/kdeartwork-wallpapers/database.h 6991758 assetimporters/kdeartwork-wallpapers/database.cpp d75cdda assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h PRE-CREATION assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp PRE-CREATION assetimporters/kdeartwork-wallpapers/main.cpp 708a949 assetimporters/obs/CMakeLists.txt 2dbcd42 assetimporters/obs/channelscatalog.h PRE-CREATION assetimporters/obs/channelscatalog.cpp PRE-CREATION assetimporters/obs/packagedatabase.h 99f4e17 assetimporters/obs/packagedatabase.cpp ae43b8e assetimporters/projectgutenberg/CMakeLists.txt b86cc49 assetimporters/projectgutenberg/src/CMakeLists.txt 2d48e9c assetimporters/projectgutenberg/src/database.h 8dba0ba assetimporters/projectgutenberg/src/database.cpp 75cba69 assetimporters/projectgutenberg/src/gutenbergdatabase.h PRE-CREATION assetimporters/projectgutenberg/src/gutenbergdatabase.cpp PRE-CREATION assetimporters/projectgutenberg/src/main.cpp 46f2340 sql/bodega.sql 44f8641 Diff: http://git.reviewboard.kde.org/r/109965/diff/ Testing --- I haven't noticed regression. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109965: Refactor assetimporters
On May 11, 2013, 9:51 a.m., Aaron J. Seigo wrote: licenseQuery, partnerQuery, languageQuery need to be changed to licenseId, partnerId and languageId. they return the ID of the license, partner and language. what they do internally is irrelevant. API must reflect what the API does to the user of the API, not how the API is implemented internally. it makes for more readable code and more maintainable code (as the implementation tends to stay in line with the naming) yes I forgot to make those change in my patch. I will upload the new one which contains them. - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/#review32350 --- On April 20, 2013, 10:52 a.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- (Updated April 20, 2013, 10:52 a.m.) Review request for Plasma. Description --- This patch * removes the duplicated code in assetimporters * adds asset's size into the db * and fixes a few small issues Diffs - assetimporters/CMakeLists.txt 24e76a0 assetimporters/database-common/channelscatalog.h 5d39c02 assetimporters/database-common/channelscatalog.cpp 6ca0aef assetimporters/database-common/database.h 9883216 assetimporters/database-common/database.cpp e860bdd assetimporters/kdeartwork-wallpapers/CMakeLists.txt 56d19b9 assetimporters/kdeartwork-wallpapers/database.h 6991758 assetimporters/kdeartwork-wallpapers/database.cpp d75cdda assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h PRE-CREATION assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp PRE-CREATION assetimporters/kdeartwork-wallpapers/main.cpp 708a949 assetimporters/obs/CMakeLists.txt 2dbcd42 assetimporters/obs/channelscatalog.h PRE-CREATION assetimporters/obs/channelscatalog.cpp PRE-CREATION assetimporters/obs/packagedatabase.h 99f4e17 assetimporters/obs/packagedatabase.cpp ae43b8e assetimporters/projectgutenberg/CMakeLists.txt b86cc49 assetimporters/projectgutenberg/src/CMakeLists.txt 2d48e9c assetimporters/projectgutenberg/src/database.h 8dba0ba assetimporters/projectgutenberg/src/database.cpp 75cba69 assetimporters/projectgutenberg/src/gutenbergdatabase.h PRE-CREATION assetimporters/projectgutenberg/src/gutenbergdatabase.cpp PRE-CREATION assetimporters/projectgutenberg/src/main.cpp 46f2340 sql/bodega.sql 44f8641 Diff: http://git.reviewboard.kde.org/r/109965/diff/ Testing --- I haven't noticed regression. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109965: Refactor assetimporters
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109965/
---
(Updated May 12, 2013, 8:59 p.m.)
Review request for Plasma.
Changes
---
In short, this update does
* s/partnerQuery/partnerID
s/licenseQuery/licenseID
s/languageQuery/languageID
* removes some unneeded comments
* fixes the queries [1]
* the assignment of the m_partner happens in the writeInit method and not in
the ctor of the Database [2]
the long summary of this patch,
[1] the queries of the languageID and partnerId were something like
select name from licenses where id = 'LGPL';
select name from partners where id = 'KDE';
but they should be
select id from licenses where name = 'LGPL';
select id from partners where name = 'KDE';
sorry I missed that.
[2] It used to be
Database::Database(..)
{
m_partnerId = partnerId();
}
and it became like
Database::Database(..)
{
}
void Database::writeInit(...)
{
m_partnerId = partnerId();
}
Q: why this change?
A: Otherwise the m_partnerId won't take the right value because the assignment
of the m_partnerID
happens before the instantiation of the derived class.
Description
---
This patch
* removes the duplicated code in assetimporters
* adds asset's size into the db
* and fixes a few small issues
Diffs (updated)
-
assetimporters/CMakeLists.txt 24e76a0
assetimporters/database-common/channelscatalog.h 5d39c02
assetimporters/database-common/channelscatalog.cpp 6ca0aef
assetimporters/database-common/database.h 9883216
assetimporters/database-common/database.cpp e860bdd
assetimporters/kdeartwork-wallpapers/CMakeLists.txt 56d19b9
assetimporters/kdeartwork-wallpapers/database.h 6991758
assetimporters/kdeartwork-wallpapers/database.cpp d75cdda
assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h PRE-CREATION
assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp PRE-CREATION
assetimporters/kdeartwork-wallpapers/main.cpp 708a949
assetimporters/obs/CMakeLists.txt 2dbcd42
assetimporters/obs/channelscatalog.h PRE-CREATION
assetimporters/obs/channelscatalog.cpp PRE-CREATION
assetimporters/obs/packagedatabase.h 99f4e17
assetimporters/obs/packagedatabase.cpp ae43b8e
assetimporters/projectgutenberg/CMakeLists.txt b86cc49
assetimporters/projectgutenberg/src/CMakeLists.txt 2d48e9c
assetimporters/projectgutenberg/src/database.h 8dba0ba
assetimporters/projectgutenberg/src/database.cpp 75cba69
assetimporters/projectgutenberg/src/gutenbergdatabase.h PRE-CREATION
assetimporters/projectgutenberg/src/gutenbergdatabase.cpp PRE-CREATION
assetimporters/projectgutenberg/src/main.cpp 46f2340
sql/bodega.sql 44f8641
Diff: http://git.reviewboard.kde.org/r/109965/diff/
Testing
---
I haven't noticed regression.
Thanks,
Giorgos Tsiapaliokas
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: QML applet - write config
Hello, do you have a main.xml file in your plasmoid? In order to be able to write something into the plasma config file you need a xml like this one, ?xml version=1.0 encoding=UTF-8? kcfg xmlns=http://www.kde.org/standards/kcfg/1.0; xmlns:xsi=http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation=http://www.kde.org/standards/kcfg/1.0 http://www.kde.org/standards/kcfg/1.0/kcfg.xsd; kcfgfile name=/ group name=General entry name=testfoo type=string labelbla bla/label defaultsomevalue/default /entry /group /kcfg If you don't have a xml like this one, when you do plasmoid.writeConfig nothing will happen. Regards, Giorgos -- Giorgos Tsiapaliokas (terietor) terietor.org ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 110288: Checks if an optional field was instantiated before accessing it
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110288/#review31994 --- Ship it! The patch is ok, it can go in. Are you familiar with out git workflow policy? http://community.kde.org/Plasma/IntegrationBranches/GeneralPolicy If you have any questions don't hesitate to ask :) - Giorgos Tsiapaliokas On May 3, 2013, 8:38 p.m., Denis Falqueto wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/110288/ --- (Updated May 3, 2013, 8:38 p.m.) Review request for Plasma. Description --- The private field m_konsolewidget is initialized only on some specific cases, so it should be accessed with caution. But there are some places in witch it's being used without checking if it was instantiated or not. This patch fixes those accesses, by checking if it is instantiated or not. This addresses bug 319291. http://bugs.kde.org/show_bug.cgi?id=319291 Diffs - plasmate/mainwindow.cpp 1ef5a81 Diff: http://git.reviewboard.kde.org/r/110288/diff/ Testing --- I've created a data engine in python successfully. Thanks, Denis Falqueto ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109965: Refactor assetimporters
On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: looking very good. a few comments below, but this should be ready soon, i imagine. Regarding the cache of the partnerId and licenseId, I cache those values in the *init method. I don't follow you in this one. What is the difference between caching the value inside the method and caching the value in the *init method? On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: assetimporters/projectgutenberg/src/gutenbergdatabase.cpp, line 326 http://git.reviewboard.kde.org/r/109965/diff/1/?file=138225#file138225line326 this is more partnerId than partnerQuery? yes you can call it a partnerId, but I didn't. Because partnerQuery is a virtual method of databasecommon and I wanted to emphasize the fact that *this* partner has changed. So I believe we should leave the method as partnerQuery or to rename all of them into partnerId. We have to emphasize the change in the value(if it changes at all), no? On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: assetimporters/projectgutenberg/src/gutenbergdatabase.cpp, line 341 http://git.reviewboard.kde.org/r/109965/diff/1/?file=138225#file138225line341 as with partnerQuery above, this is probably more accurately named languageId same answer as the partnerQuery. :) On April 13, 2013, 2:12 a.m., Aaron J. Seigo wrote: assetimporters/projectgutenberg/src/gutenbergdatabase.cpp, line 357 http://git.reviewboard.kde.org/r/109965/diff/1/?file=138225#file138225line357 same as methods above same answer as above :) - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/#review30976 --- On April 12, 2013, 6:45 p.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- (Updated April 12, 2013, 6:45 p.m.) Review request for Plasma. Description --- This patch * removes the duplicated code in assetimporters * adds asset's size into the db * and fixes a few small issues Diffs - assetimporters/CMakeLists.txt 24e76a0 assetimporters/database-common/channelscatalog.h 5d39c02 assetimporters/database-common/channelscatalog.cpp 6ca0aef assetimporters/database-common/database.h 9883216 assetimporters/database-common/database.cpp e860bdd assetimporters/kdeartwork-wallpapers/CMakeLists.txt 56d19b9 assetimporters/kdeartwork-wallpapers/database.h 6991758 assetimporters/kdeartwork-wallpapers/database.cpp d75cdda assetimporters/kdeartwork-wallpapers/kdewallpapers-channels.ini b22f395 assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h PRE-CREATION assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp PRE-CREATION assetimporters/kdeartwork-wallpapers/main.cpp 708a949 assetimporters/obs/CMakeLists.txt 2dbcd42 assetimporters/obs/channelscatalog.h PRE-CREATION assetimporters/obs/channelscatalog.cpp PRE-CREATION assetimporters/obs/packagedatabase.h 99f4e17 assetimporters/obs/packagedatabase.cpp ae43b8e assetimporters/projectgutenberg/CMakeLists.txt b86cc49 assetimporters/projectgutenberg/src/CMakeLists.txt 2d48e9c assetimporters/projectgutenberg/src/database.h 8dba0ba assetimporters/projectgutenberg/src/database.cpp 75cba69 assetimporters/projectgutenberg/src/gutenbergdatabase.h PRE-CREATION assetimporters/projectgutenberg/src/gutenbergdatabase.cpp PRE-CREATION assetimporters/projectgutenberg/src/main.cpp 46f2340 sql/bodega.sql 44f8641 Diff: http://git.reviewboard.kde.org/r/109965/diff/ Testing --- I haven't noticed regression. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109965: Refactor assetimporters
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- (Updated April 20, 2013, 10:52 a.m.) Review request for Plasma. Changes --- update the diff according to the review Description --- This patch * removes the duplicated code in assetimporters * adds asset's size into the db * and fixes a few small issues Diffs (updated) - assetimporters/CMakeLists.txt 24e76a0 assetimporters/database-common/channelscatalog.h 5d39c02 assetimporters/database-common/channelscatalog.cpp 6ca0aef assetimporters/database-common/database.h 9883216 assetimporters/database-common/database.cpp e860bdd assetimporters/kdeartwork-wallpapers/CMakeLists.txt 56d19b9 assetimporters/kdeartwork-wallpapers/database.h 6991758 assetimporters/kdeartwork-wallpapers/database.cpp d75cdda assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h PRE-CREATION assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp PRE-CREATION assetimporters/kdeartwork-wallpapers/main.cpp 708a949 assetimporters/obs/CMakeLists.txt 2dbcd42 assetimporters/obs/channelscatalog.h PRE-CREATION assetimporters/obs/channelscatalog.cpp PRE-CREATION assetimporters/obs/packagedatabase.h 99f4e17 assetimporters/obs/packagedatabase.cpp ae43b8e assetimporters/projectgutenberg/CMakeLists.txt b86cc49 assetimporters/projectgutenberg/src/CMakeLists.txt 2d48e9c assetimporters/projectgutenberg/src/database.h 8dba0ba assetimporters/projectgutenberg/src/database.cpp 75cba69 assetimporters/projectgutenberg/src/gutenbergdatabase.h PRE-CREATION assetimporters/projectgutenberg/src/gutenbergdatabase.cpp PRE-CREATION assetimporters/projectgutenberg/src/main.cpp 46f2340 sql/bodega.sql 44f8641 Diff: http://git.reviewboard.kde.org/r/109965/diff/ Testing --- I haven't noticed regression. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 109965: Refactor assetimporters
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109965/ --- Review request for Plasma. Description --- This patch * removes the duplicated code in assetimporters * adds asset's size into the db * and fixes a few small issues Diffs - assetimporters/CMakeLists.txt 24e76a0 assetimporters/database-common/channelscatalog.h 5d39c02 assetimporters/database-common/channelscatalog.cpp 6ca0aef assetimporters/database-common/database.h 9883216 assetimporters/database-common/database.cpp e860bdd assetimporters/kdeartwork-wallpapers/CMakeLists.txt 56d19b9 assetimporters/kdeartwork-wallpapers/database.h 6991758 assetimporters/kdeartwork-wallpapers/database.cpp d75cdda assetimporters/kdeartwork-wallpapers/kdewallpapers-channels.ini b22f395 assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.h PRE-CREATION assetimporters/kdeartwork-wallpapers/kdewallpapersdatabase.cpp PRE-CREATION assetimporters/kdeartwork-wallpapers/main.cpp 708a949 assetimporters/obs/CMakeLists.txt 2dbcd42 assetimporters/obs/channelscatalog.h PRE-CREATION assetimporters/obs/channelscatalog.cpp PRE-CREATION assetimporters/obs/packagedatabase.h 99f4e17 assetimporters/obs/packagedatabase.cpp ae43b8e assetimporters/projectgutenberg/CMakeLists.txt b86cc49 assetimporters/projectgutenberg/src/CMakeLists.txt 2d48e9c assetimporters/projectgutenberg/src/database.h 8dba0ba assetimporters/projectgutenberg/src/database.cpp 75cba69 assetimporters/projectgutenberg/src/gutenbergdatabase.h PRE-CREATION assetimporters/projectgutenberg/src/gutenbergdatabase.cpp PRE-CREATION assetimporters/projectgutenberg/src/main.cpp 46f2340 sql/bodega.sql 44f8641 Diff: http://git.reviewboard.kde.org/r/109965/diff/ Testing --- I haven't noticed regression. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109821: make the DvcsJob async
On April 8, 2013, 3:46 p.m., Aaron J. Seigo wrote: the only possible downside i can see at the moment is that it is not possible anymore to say which branch rename failed, etc. that does not really matter since the old code wasn't doing that either .. but it was possible with the individual jobs being returned. in future, if this becomes needed/desired, i suppose the signals in GitRunner could be augmented with additional information. in any case, this looks like an incremental improvement over the existing code as is. if the signals become something foo(bool ok), then we are ok. No? - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109821/#review30695 --- On April 2, 2013, 6:24 a.m., Giorgos Tsiapaliokas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109821/ --- (Updated April 2, 2013, 6:24 a.m.) Review request for Plasma. Description --- This patch implements a proper KJob and uses the job as an async when and where it makes sense. My opinion about the patch(feel free to ignore it:) I tried to make all the jobs async but in some cases it was an overhead and the code was looking bad, so I implemented the execSynchrousnly in order to emphasize that the job is sync and to have a better result. Diffs - plasmate/savesystem/timeline.cpp 4293dae plasmate/savesystem/timeline.h 95e7e97 plasmate/savesystem/gitrunner.cpp 7520239 plasmate/savesystem/gitrunner.h dfacc5b plasmate/savesystem/dvcsjob.cpp 6f83307 plasmate/savesystem/dvcsjob.h 38df371 Diff: http://git.reviewboard.kde.org/r/109821/diff/ Testing --- I haven't found any regressions. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109339: Delete the old konsoleWidget when loading a new project.
On March 15, 2013, 8:13 p.m., Giorgos Tsiapaliokas wrote: any updates on this one? Tianyu Zhu wrote: It seems I forgot push the Publish button, my bad! any updates? - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109339/#review29293 --- On March 7, 2013, 2:10 p.m., Tianyu Zhu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109339/ --- (Updated March 7, 2013, 2:10 p.m.) Review request for Plasma. Description --- If the old konsoleWidget is not deleted when loading a new project, it shows up along with a new one in the project view. This also fixes a memory leak. This addresses bug https://bugs.kde.org/show_bug.cgi?id=316276. http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316276 Diffs - plasmate/mainwindow.cpp 13234ec Diff: http://git.reviewboard.kde.org/r/109339/diff/ Testing --- It works on my machine: Thinkpad T520, Kubuntu 12.10, KDE 4.10.1 Thanks, Tianyu Zhu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 109340: Use default background colours for the konsolepreviewer
On March 15, 2013, 8:13 p.m., Giorgos Tsiapaliokas wrote: any updates on this one? Tianyu Zhu wrote: Sorry, I've had a hectic couple of weeks (school, you know). I haven't contributed to KDE before so I'll see what I can figure out from the wiki. Giorgos Tsiapaliokas wrote: I haven't contributed to KDE before so I'll see what I can figure out from the wiki. If you have any questions, you can always ask on the irc, probably I will also be there. any updates? - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109340/#review29294 --- On March 11, 2013, 1:31 p.m., Tianyu Zhu wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109340/ --- (Updated March 11, 2013, 1:31 p.m.) Review request for Plasma. Description --- - Deleted lines hard-coding the background of the konsolepreviwer to white. This addresses bug https://bugs.kde.org/show_bug.cgi?id=316274. http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=316274 Diffs - plasmate/konsole/konsolepreviewer.h 543ff77 plasmate/konsole/konsolepreviewer.cpp 05d426e Diff: http://git.reviewboard.kde.org/r/109340/diff/ Testing --- Tested on Kubuntu 12.10 with KDE 4.10.1 Tested with both the default and Krita-Dark colour scheme. In both cases, the text in the konsolepreviewer shows up well against its background. Thanks, Tianyu Zhu ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 109821: make the DvcsJob async
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109821/ --- Review request for Plasma. Description --- This patch implements a proper KJob and uses the job as an async when and where it makes sense. My opinion about the patch(feel free to ignore it:) I tried to make all the jobs async but in some cases it was an overhead and the code was looking bad, so I implemented the execSynchrousnly in order to emphasize that the job is sync and to have a better result. Diffs - plasmate/savesystem/timeline.cpp 4293dae plasmate/savesystem/timeline.h 95e7e97 plasmate/savesystem/gitrunner.cpp 7520239 plasmate/savesystem/gitrunner.h dfacc5b plasmate/savesystem/dvcsjob.cpp 6f83307 plasmate/savesystem/dvcsjob.h 38df371 Diff: http://git.reviewboard.kde.org/r/109821/diff/ Testing --- I haven't found any regressions. Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 109823: fix stripe again
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109823/ --- Review request for Plasma. Description --- This patch fixes another stripe API property error. I missed this error in my previous patch Diffs - server/lib/payments.js ad096fa Diff: http://git.reviewboard.kde.org/r/109823/diff/ Testing --- it works, no undefined properties Thanks, Giorgos Tsiapaliokas ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: New git workflow for plasmate repository
Hello, the branches - window_swithcer_fix_icons_bug_316772 - terietor/BUG/316281 - terietor/BUG/316408 - terietor/BUG/316290 - yuenhoe/loadlocalfix have been merged in the master branch and they have been deleted from the wiki Regards, Giorgos On 25 March 2013 12:41, Giorgos Tsiapaliokas terie...@gmail.com wrote: Hello, the integration branch has been created. All the requested branches have been merged into it. Regards, Giorgos -- Giorgos Tsiapaliokas (terietor) KDE Developer terietor.gr -- Giorgos Tsiapaliokas (terietor) KDE Developer terietor.gr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Automatic crash report generated by DrKonqi for Plasmate.
Hello, this a duplicate of the bug #316408, the fix of the bug is in the branch terietor/BUG/316408. If everything goes well and nobody finds something wrong with this fix by Monday morning the branch will be merged in master. Regards, Giorgos -- Giorgos Tsiapaliokas (terietor) KDE Developer terietor.gr ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 108778: Fix bodega server database setup script
On Feb. 5, 2013, 8:10 a.m., Aaron J. Seigo wrote: Ship It! hello, this patch isn't shipped. Can you push it? - Giorgos --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108778/#review26660 --- On Feb. 4, 2013, 5:19 p.m., Lluis Esquerda wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108778/ --- (Updated Feb. 4, 2013, 5:19 p.m.) Review request for Plasma and Aaron J. Seigo. Description --- Some systems do not recognize 'PLPGSQL' as a language, hence the need to only sue 'plpgsql'. Also, if I am correct, there was a small typo in a constraint (==), which should be a =. Diffs - sql/actionconf.plsql 141f63b sql/bodega.sql b9d1d59 sql/core.plsql e99de53 sql/purchasing.plsql fa4d266 Diff: http://git.reviewboard.kde.org/r/108778/diff/ Testing --- I found it while running the database initialization scripts. Before it was throwing 'ERROR' and some tables where not being created. With this patch the scripts run with no problem. Thanks, Lluis Esquerda ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
