D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

2020-06-08 Thread Henri Chain
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6cd25ded9934: Add a new standalone executable to replace 
X-KDE-Autostart-Condition (authored by hchain).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28424?vs=78865&id=83248

REVISION DETAIL
  https://phabricator.kde.org/D28424

AFFECTED FILES
  startkde/CMakeLists.txt
  startkde/kde-systemd-start-condition.cpp

To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28305: WIP: Systemd Startup

2020-04-17 Thread Henri Chain
hchain added inline comments.

INLINE COMMENTS

> plasma-core@.target:3
> +Description=KDE Plasma Workspace Core
> +Wants=plasma-plasmashell.service plasma-kwin_%i.service 
> plasma-kcminit.service plasma-kded.service plasma-kcminit-phase1.service
> +Requires=plasma-ksmserver.service

can we make this `plasma-kwin@%i.service` ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart


D28424: Add a new standalone executable to replace X-KDE-Autostart-Condition

2020-03-30 Thread Henri Chain
hchain created this revision.
hchain added reviewers: davidedmundson, broulik, dfaure, ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
hchain requested review of this revision.

REVISION SUMMARY
  For systemd autostart generator will add a 
ExecCondition=kde-systemd-start-condition rcfile:section:entry:default
  As described in T12627 . Needs D28421 


TEST PLAN
  Run kde-systemd-start-condition; should return 0 with a missing or incomplete 
argument, 255 with a false or non-existent and non-default con
  fig value.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28424

AFFECTED FILES
  startkde/CMakeLists.txt
  startkde/kde-systemd-start-condition.cpp

To: hchain, davidedmundson, broulik, dfaure, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D28305: WIP: Systemd Startup

2020-03-26 Thread Henri Chain
hchain added inline comments.

INLINE COMMENTS

> startplasma.cpp:404
> +startPlasmaSession.start(QStringLiteral(CMAKE_INSTALL_FULL_BINDIR 
> "/plasma_session"), plasmaSessionOptions);
> +rc = startPlasmaSession.waitForStarted();
> +#else

unrelated change ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart


D28305: WIP: Systemd Startup

2020-03-26 Thread Henri Chain
hchain added inline comments.

INLINE COMMENTS

> hchain wrote in plasmawayland-dev.desktop.cmake:2
> does that still work in legacy (non-systemd) mode ?

original patch https://phabricator.kde.org/D19004

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart


D28305: WIP: Systemd Startup

2020-03-26 Thread Henri Chain
hchain added inline comments.

INLINE COMMENTS

> apol wrote in plasmawayland-dev.desktop.cmake:2
> Is this change related?

does that still work in legacy (non-systemd) mode ?

> apol wrote in org.kde.plasmashell.desktop.cmake:55
> We probably want it always hidden?

maybe add a comment that this file is superseded in systemd-mode by a custom 
service and we don't want the systemd generator to make another one for us

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28305

To: davidedmundson
Cc: hchain, apol, ahiemstra, benjaminberg, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart