Re: Shipping Plasma 6.1 wallpaper in Plasma 6.1.1

[Kai Uwe Broulik]

fwiw Plasma 5.1 also had the same wallpaper as 5.0 ;)

Re: Shipping Plasma 6.1 wallpaper in Plasma 6.1.1

[Kai Uwe Broulik]

Indeed SUSE will probably not be very amused when their openQA tests 
start failing in a patch release because the default wallpaper changed.


Am 18.06.24 um 08:43 schrieb David Edmundson:


What is the problem of delivering the wallpaper with 6.1.1?


It's a behavioural change in a patch release. Patch releases should be
bugfixes only.

David

Re: CI moved to Qt 6.7 for Linux builds

[Kai Uwe Broulik]

Hi,

This doesn't look terribly active to me / something receiving much in 
the way of release activity?


Plasma 5.27.11 was released two months ago, so that’s not that far ago. 
And I think I haven’t merged most of my cherry-picks because of failing 
pipelines because of appstream.


Cheers
Kai Uwe

Re: CI moved to Qt 6.7 for Linux builds

[Kai Uwe Broulik]

Hi,

(only posting to plasma-devel only below is about Plasma)

> i'd also like to schedule removing CI support for [...] Plasma/5.27

Plasma 5.27 is our LTS release and we’ve just had Kubuntu 24.04 ship 
with it. I’m also aware of at least one other major deployment that’s 
also on 5.27 for the forseeable time.


I think we need to keep this around for at least another year, maybe 
longer, so we can still backport important fixes and do a few more 5.27 
releases. One year of support isn’t exactly “LTS” imho particularly with 
a major version jump. Think of how long Qt 5.15 has been around and 
still will be in the industry.


Cheers
Kai Uwe

PS: Though we should probably disable this stupid appstream test on 5.27

Re: More 5.27 Releases

[Kai Uwe Broulik]

Agreed.

I also think it’s a bad mindset to have “there won’t be any 5.27 
release”. We should for now treat backporting as if there will be 
another one, given 6.0 isn’t even out yet.


Cheers
Kai Uwe

Am 12.02.24 um 11:53 schrieb David Edmundson:

Plasma 5.27 is not getting any more regular timed releases. However in
the past for LTS releases we have said that we would just make them
on-demand if there's enough stuff.

I've seen enough patches over the last month that warrant putting into
5.27 with people not cherry-picking some major fixes because "there's
not going to be another release". I want to request that we do at
least one more spin some time in the next few months.

David

Re: Wayland Nvidia situation for initial Plasma 6 release

[Kai Uwe Broulik]

Hi,

plasma-integration already (which I am NOT happy about!) creates a GL 
context to check whether to use software rendering, there we could also 
check the GL_VENDOR and set basic render loop.


But backporting won’t hurt either way I’d say.

Cheers
Kai Uwe

Am 07.02.24 um 10:13 schrieb David Redondo:

Hi,

when using Wayland on Nvidia there is a significant problem that QtQuick
windows freeze when resized, this can also manifest in plasma popups sometimes
not showing up.
ref. https://bugreports.qt.io/browse/QTBUG-95817
This can be worked around with using the basic render loop instead of the
threaded one.
With https://codereview.qt-project.org/c/qt/qtwayland/+/536040 Qt will now
disable threaded rendering on NVidia. However this patch missed 6.6.2 and will
be released with 6.6.3. Given that 6.6.2 is the latest patch version released
for Plasma 6.0 and the Wayland session is the new default we need to do
something. Options that I can think of are

- tell distros to include this patch in their QtWayland builds
- disable threaded rendering in plasma-integration on Nvidia and running
anything less than Qt 6.6.3

Thoughts?

David

Re: QML: a packagers nightmare. Assistance please.

[Kai Uwe Broulik]

Hi,

that ShadowedLabel is literally one QML file with a Label and a 
DropShadow. KWin could just not use that (and build its own) and we’d 
resolve the issue.


Cheers
Kai Uwe

 From what I am seeing this patch causes KWin to import a qml module that lives
in plasma-workspace

import org.kde.plasma.workspace.components 2.0 as WorkspaceComponents

At the same time plasma-workspace build depends on KWin due to the need of the
DBus xml files.

So the situation right now is that plasma-workspace build depends on KWin and
KWin has a runtime dependency on plasma-workspace.
I think it's not a full cycle since installing plasma-workspace does not need
anything from KWin but maybe it can cause problems for distributions?

David

Maintainer Wanted: PowerDevil

[Kai Uwe Broulik]

Hi everyone,

unfortunately my KDE time has been limited for a while now.

I’ve seen a bunch of hot new stuff™ being worked on (notably the logical 
screen brightness and automatic brightness stuff) and it’s just unfair 
to be the bottleneck here by not reviewing them.


Therefore I’d like to pass on the PowerDevil torch to some fresh new 
minds that can lift it up to the standard in power management that 
people expect in the 2020s.


Cheers
Kai Uwe

Re: Moving print-manager and wacomtablet to Plasma

[Kai Uwe Broulik]

Hi,

I can’t speak for wacomtablet but I support the idea of moving 
print-manager to Plasma. It always struck me as odd that it’s not part 
of Plasma.


Realistically there’s plenty of CUPS-based printer UIs, so I don’t see 
why anyone would ours, which is pretty tightly integrated, outside of 
Plasma.


Cheers
Kai Uwe

Re: Cherry-picking policy

[Kai Uwe Broulik]

Hi,

> I propose to make creating MRs for bugfix backports mandatory:

Agreed. I have also been guilty of cherry-picking changes on a whim from 
my phone before going to bed, which is not something we want for the 
stable branch.


Back when we were still forward-merging I was at least compiling them 
locally and giving them a quick test run.


Cheers
Kai Uwe

Re: change size of kickoff

[Kai Uwe Broulik]

Hi Daniel,

this was very recently added and should be possible from Plasma 5.25 
onwards [1], [2].


Cheers
Kai Uwe

[1] https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/924
[2] https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/500

Am 12.07.22 um 09:43 schrieb Daniel Rieß:

Dear Kde-devs,

first of all, many thanks for the great job writing all that good free 
software.


However, one thing I miss is to change the size easily of Kickoff 
Application Launcher. Theres is no draggable area, or a setting (And 
changing FullRepresenation.qml doesn't feel proper).


Maybe I don't find it - or you might even plan it as a upcoming feature..

Regards, Daniel

[Powerdevil] [Bug 377357] configurable timer setting to turn off the keyboard's backlight

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=377357

--- Comment #9 from Kai Uwe Broulik  ---
Splitting out the keyboard backlight into a separate action would also enable
us to dim the keyboard while keeping the screen on, like when a video player
forces the screen on, you probably still want the keyboard backlight to turn
off as to not be distracting.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Can we move the Monday Plasma meeting to a later time?

[Kai Uwe Broulik]

Hi,

CET is UTC+1, CE*S*T is UTC+2 :)

Cheers
Kai Uwe


Am 17.01.22 um 20:34 schrieb Nate Graham:

Cool.

Europe time means CET i.e. UTC+2?

Nate

Re: Akademy Plasma Bof

[Kai Uwe Broulik]

Hi,

Was already asking :) I'd prefer Mon or Tue. 

Cheers
Kai Uwe 

Re: Has there ever been ...

[Kai Uwe Broulik]

Hi,

I don't think we consider running KWin instead of Quartz Compositor a 
supported usecase, maybe that's where your glitches are coming from. /scnr


> because kwin has been becoming more and more bloated over the 
versions leading up to 5.15, and filled with functionality I don't need.


Can you give some examples? We've been working on splitting many things 
out into separate plugins and making KWin core slimmer again.


> I'm a firm believer in not fixing things that ain't broke

Plot twist: KDecoration1 was inefficient and old and had to be replaced. 
Unfortunately that also meant that virtually all alternative decorations 
were lost. (rip trusty Keramik)


To come back to the original question:

> Has there ever been a KWin version that was just (or predominatly) a 
straight port of the latest KWin4 to Qt5 and KF5?


Maybe check out KWin from Plasma 5.0 then. It still had the old 
decoration lib. Depends on your definition of "straight port", do you 
include the necessary Xlib-to-XCB transition form Qt 4 to 5 part of a 
straight Qt 5 port?


Cheers

Relicensing Plasma Browser Integration Host to GPLv3+

[Kai Uwe Broulik]

Hi all,

I've noticed that the licensing of Plasma Browser Integration is all 
over the place, some parts seem to be resembling an MIT-style license, 
probably carried over all the way from when it was just a proof of 
concept we didn't care much about.


To clean up that mess, I'd like to relicense the host (all code in 
plasma-browser-integration/host) to GPLv3+ to match the newer host code 
and extension code.


According to git log the following people (and myself) touched that folder:

David Edmundson
Fabian Vogt
Laurent Montel
Friedrich W. H. Kossebau
Matthijs Tijink

Are you fine with this, or have any other comments?

Cheers
Kai Uwe

(Should probably do some REUSE porting as part of this, too ;)

Re: Clang Format Update

[Kai Uwe Broulik]

Setting it the column width too narrow makes it have the habit of 
pointlessly breaking statements apart a lot.


Am 01.01.21 um 17:59 schrieb Roman Gilg:
> 160 chars column limit contradicts Frameworks recommendation of 100 
chars.

Monday Meeting notes for 2020-12-28

[Kai Uwe Broulik]

Hi all,

find below today's meeting notes. Small round because of the holidays, 
see you next year!


fvogt:
* I've only got 
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/532 to 
raise [login-sessions: (Correctly) set the correct filename depending on 
default session type]


alex:
* When we discussed clang-format last time we agreed that a pre-commit 
hook would be very good, I made a proposal here 
https://invent.kde.org/frameworks/extra-cmake-modules/-/merge_requests/65
* In that MR I am not entirely sure how we should handle the case when 
clang-format is not installed. I am not sure if we should force it^^
* And maybe rename this little function to sth. more generic? In case we 
add a QML formatter or sth. else in the future?


kbroulik:
KRunner:
* Add support for custom pixmap in DBusRunner, can we get this in now? 
https://invent.kde.org/frameworks/krunner/-/merge_requests/48
* Size category sidebar dynamically for more room, 
https://invent.kde.org/plasma/milou/-/merge_requests/19 not too happy 
with the result though

xdg-desktop-portal:
* No feedback on ScreenCast inhibition whatsoever.. 
https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/33

plasma-browser-integration:
* Haven't heard back from Microsoft yet about some Edge questions
* Browser history runner, no feedback whatsoever, will just merge it 
once the custom pixmap stuff is in. 
https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/20

PowerDevil:
* Wrote a plugin for acpi platform_profiles 
https://invent.kde.org/plasma/powerdevil/-/merge_requests/34
* Compiled kernel with the relevant patches but didn't show up for 
me. PowerDevil patch seems straightforward enough though

Plasma:
* Found regression breaking ProgressBar width, can we get this in now? 
https://invent.kde.org/frameworks/plasma-framework/-/merge_requests/172
* Found a questionable behavior change in KWin breaking Spectacle, KFind 
and possibly many others. Please review a remedy 
https://invent.kde.org/plasma/plasma-integration/-/merge_requests/15

Other:
* Wrote thumbnailer for Animated Windows Cursors (ANI) :D 
https://invent.kde.org/frameworks/kimageformats/-/merge_requests/10


! The Plasma and KRunner ones are actually important since Frameworks 
tagging for the version Plasma 5.21 will depend on is coming up !

[Powerdevil] [Bug 364067] Automatic suspend when inhibitor is set

[Kai Uwe Broulik]

https://bugs.kde.org/show_bug.cgi?id=364067

Kai Uwe Broulik  changed:

   What|Removed |Added

 Resolution|--- |FIXED
  Latest Commit||https://invent.kde.org/plas
   ||ma/powerdevil/commit/b5dfb2
   ||86a4d9b43ac74862218beb5dd7f
   ||58ea7a8
   Version Fixed In||5.21.0
 Status|ASSIGNED|RESOLVED

--- Comment #4 from Kai Uwe Broulik  ---
Git commit b5dfb286a4d9b43ac74862218beb5dd7f58ea7a8 by Kai Uwe Broulik.
Committed on 18/12/2020 at 14:40.
Pushed by broulik into branch 'master'.

Take into account logind sleep and idle inhibitions

System services cannot access the user's session bus and that freedesktop
inhibition interface appears deprecated. This patch makes PowerDevil watch
logind's BlockInhibited property and internally posts an appropriate
inhibition.
FIXED-IN: 5.21.0

M  +106  -0daemon/powerdevilpolicyagent.cpp
M  +22   -0daemon/powerdevilpolicyagent.h

https://invent.kde.org/plasma/powerdevil/commit/b5dfb286a4d9b43ac74862218beb5dd7f58ea7a8

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: How to enable notification history for an application

[Kai Uwe Broulik]

Hi,



Is it possible for the application to change its own "show in history"
setting, instead of the user going to System Settings to do this?


It is not.

Cheers
Kai Uwe

Re: How to enable notification history for an application

[Kai Uwe Broulik]

Hi,

by default all well-known applications show in history.

Having DesktopEntry= in the notifyrc should make it show up in System 
Settings. Make sure the notifyrc file is intsalled in the correct 
location and the DesktopEntry matches the desktop file name and that the 
desktop file isn't marked as Hidden etc.


Also, applications that aren't properly registered like above but have 
sent a notification once will be registered and show up in the list.


Make sure the desktopFileName in the QApplication/KAboutData is set 
correctly. Check the "desktop-entry" hint of the notification emitted by 
KAlarm using dbus-monitor if necessary to find out if it sends the 
correct hint.


Cheers
Kai Uwe

Re: dipping a toe in waywater? :)

[Kai Uwe Broulik]

> this is not a standard set-up, so just selecting wayland as a login option on 
> the login manager screen isn't an option.


Is it Mac OS?

Re: Icon-Only Task Manager Colored Backgrounds

[Kai Uwe Broulik]

Hi,

I also thought it was pretty cool but I tried that the other day with 
Task Manager by using the k-cluster sampling code from Big Screen to get 
the dominant icon color.


It didn't work very well. Our current design the line doesn't give much 
area for colorization (the background is pretty faint then) and I always 
kept thinking my VLC player was demanding attention as the button turned 
orange.


I sometimes wish I could colorize specific apps so I don't lose them in 
task bar (e.g. my email client or music player) but I am not sure the 
colorization stuff really works well in practice. I think Unity (or 
what's left of it) also moved away from permanently colored sidebar tiles.


Cheers
Kai Uwe

Sprint notes - PowerDevil

[Kai Uwe Broulik]

Find below the sprint notes for the "PowerDevil" session. We decided to 
broaden the scope a little from PowerDevil KCM to overall PowerDevil 
discussion:


Cheers
Kai Uwe

* KCM is all about plugins but I'd suggest making a static "coherent" UI
* figure out disabling vs "don't touch" (e.g. screen brightness 
shouldn't be messed with all the time when plugging AC)

* dim brightness dims in multiple steps, why?
* Add turn screen off AND lock option - ask VDG how to do that with good UX
* figure out "restoring state" rather than overwriting when you switch 
between profiles, e.g. don't always mess with screen brightness if user 
manually changed it...
* the "run script" stuff is pretty much a workaround for us not having a 
proper "do stuff on certain events" KCM. Should remove the UI in the kcm 
and just document how to set these scripts in some wiki.


* move bluetooth/wifi etc to bluedevil/plasma-nm
* make it smarter, dont disable if something is paired or I dont know

* UPower backend which is not exactly backend, and also does not use 
anything upower specific much

* kill XRandrBrightness control
* multi screen brightness support - FN keys prefer laptop screen and 
then you have multiple sliders for each screen or something


* can we show something like "app xyz is using a lot of power" right 
now? do we also get hardware info? does cgroups help? The wakeups stuff 
we had in Energy Info seems to be disabled on most kernels these days


* login1 inhibition support:
	* listen to inhibitors change and translate them to internal powerdevil 
state, just track them like xdg inhibition


* Wake lock support for mobile:
	* when user activity is happening, register a wakelock, drop when it 
hits idle timeout and let the kernel handle sleep/wakeup

D27129: [Notifications] Allow expiring an entire group

[Kai Uwe Broulik]

broulik added a comment.


  Should we go with this now? I haven't seen it crash on me since I fixed the 
`checkIndex` thing

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27129

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28881: [Applet] Fix connecting with a password

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ConnectionItem.qml:234
> +} else if (connectionItem.customExpandedViewContent == 
> passwordDialogComponent) {
> +if (passwordDialogComponent.password != "") {
> +handler.addAndActivateConnection(DevicePath, 
> SpecificPath, passwordDialogComponent.password)

You can't access a `Component`. You'd need to access the instance created by 
the `Loader` in `ExpandableListItem` which isn't exposed to the user.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D28881

To: ngraham, jgrulich, nicolasfella, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D21987: Extend KDE Connect to images, video, audio, selection

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  We have image/video/audio now, text selection I might add later but maybe not 
soo useful after alll

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D21987

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  I'd prefer some dimmed label next to the app name but with the radio button 
and manual size calculations all over the place now, this is difficult

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D29478: [Clipboard Plasmoid] Port to Prison QML import

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7bd9bea0723c: [Clipboard Plasmoid] Port to Prison QML 
import (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29478?vs=82076&id=83171

REVISION DETAIL
  https://phabricator.kde.org/D29478

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/DelegateToolButtons.qml
  applets/clipboard/contents/ui/Menu.qml

To: broulik, #plasma, vkrause
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28904: Cleanup dependencies

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  I've noticed I accidentally removed compiling a few things, that also depend 
on KIO, so maybe not as lean as I hoped

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28904

To: broulik, #plasma
Cc: asturmlechner, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: Gitlab and plasma dev

[Kai Uwe Broulik]

The thing that I found annoying is that only one person can be assigned to
review. One thing that I was on the verge of doing is to @people that I'd like
to notice the review in the comment to the MR.


Yeah, I'm annoyed by that, too. The problem with a pure mention is that 
there's no overview to see all of those. I typically don't go by my 
email inbox but by a list of merge requests and there isn't a 
"mentioned" search, just author or assignee.


I also have to work around the fact that there's no list of all merge 
requests on all projects by doing a "Target-Branch is master" query, 
which shows me most but also misses stable branches.

Re: Gitlab and plasma dev

[Kai Uwe Broulik]

Hi,

> I think this could be achieved with a label, that reviewers can set 
and authors can clear when they're ready.
> Somehow it's possible to create a label that covers all of Plasma as 
the VDG have one already.


Good idea! I think having a "Needs changes" label would be very useful, 
even on a global scale, not just for Plasma. Then you could also filter 
those ones out from your search queries.


However, given GitLab has this concept of resolved threads where it 
wouldn't let you merge until everything's remedied - maybe there already 
exists infrastructure we could leverage for this purpose? (probably only 
in EE, scnr)


What I would like to see is a "VDG approved" or "Design approved" label 
to explicitly express for designers "we like the looks of it" or "the 
interaction pattern is sound" but that someone still needs to review the 
actual code.


Nate's been doing this on Phabricator by doing this "Accepted by VDG" 
which I recall was an awkward dance of clicking accept and then 
unchecking oneself. Making this more explicit and user-friendly would be 
appreciated.


Cheers
Kai Uwe

D29831: Update availableScreenRect when a panel moves to another screen

[Kai Uwe Broulik]

broulik added a comment.


  Could that also mitigate task manager showing windows of the wrong screen in 
certain scenarios?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29831

To: akandaurov
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Plasma Firewall

[Kai Uwe Broulik]

Hi all,

Tomaz, Lucas, and me have been working on a simple Firewall KCM for 
Plasma based on nx-firewall. It supports both ufw and firewalld. I'd 
like to eventually include that in Plasma 5.20 so please give it some 
code review and testing so we can iron out any issues for that, 
especially with the KAuth side of things.


It is currently in Tomaz' private GitLab: 
https://invent.kde.org/tcanabrava/plasma-firewall


Cheers
Kai Uwe

D28904: Cleanup dependencies

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in CMakeLists.txt:20
> That's not right at least. It should be optional when KF5NetworkManagerQt is 
> found. It looks weird to present at all.

Yes, this looks wrong but I don't understand why I even have to add this 
manually... NetworkManager-Qt CMake looks for Qt5 Network and it also has it in 
its PUBLIC link interface.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D28904

To: broulik, #plasma
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27130: [Notifications] For group parents combine the child bodies

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ebf61e5ecf9e: [Notifications] For group parents combine 
the child bodies (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27130?vs=74931&id=83102

REVISION DETAIL
  https://phabricator.kde.org/D27130

AFFECTED FILES
  libnotificationmanager/notificationgroupingproxymodel.cpp

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D23021: [Image Wallpaper] Use layer.enabled during transition to avoid background glimpsing through

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Yeah, would love some @ahiemstra shader magic there :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23021

To: broulik, #plasma, ngraham
Cc: ahiemstra, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c743d36b0372: [Colors / Desktop Theme KCM] Use 
Kirigami.SearchField (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25462?vs=83044&id=83100

REVISION DETAIL
  https://phabricator.kde.org/D25462

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, aspotashev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26296: Add Opera Extension ID

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Gave up on Opera review. If someone wants to maintain our Opera store 
presence there, feel free to get in touch.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D26296

To: broulik, #plasma, leinir, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27130: [Notifications] For group parents combine the child bodies

[Kai Uwe Broulik]

broulik added a comment.


  Ping

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27130

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Sunsetting PowerDevil's XRandrBrightness

[Kai Uwe Broulik]

> One thing which this will trip over is, if device supports both XRandr
> and normal backlight control, then code will prefer to still use the
> XRandr, so not sure if we can "trust" data.

That's on purpose, since XRandR has the smooth brightness animation, I 
always prefer that one, if possible. :)


> Can we figure out some stats from e.g. bug reports and logs we have
> available?

Not sure, maybe. or KUserFeedback :D

Sunsetting PowerDevil's XRandrBrightness

[Kai Uwe Broulik]

Hi all,

PowerDevil has two (three, if you count DDC) means of controlling screen 
brightness:


* Writing to sysfs (/sys/class/backlight and /sys/class/leds)
* Using XRandr output property

XRandR is doing X calls and we have some lovely animated screen 
brightness change. However, the UPower "backend" in PowerDevil is quite 
a spaghetti class and having multiple ways to control LEDs doesn't help.


Can we get rid of the XRandrBrightness class and just use sysfs in every 
case? XRandR Brightness doesn't work on Wayland, obviously, and the 
Intel driver which supported it is dead. Are there any other GPU drivers 
or models that use XRandR over sysfs? AMD, nvidia? I vaguely recall 
something but I don't know for sure.


(We're super early in the 5.20 cycle, so if we rip it out now, we still 
have four months to ignore any requests to put it back in ;)


Cheers
Kai Uwe

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik added a comment.


  https://invent.kde.org/plasma/plasma-pa/-/merge_requests/1

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Will revisit on GitLab. Code has changed too much

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29464: [applets/appmenu] Hide old menu before showing new menu

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  Oops, I didnt't properly apply the patch. So yeah, the flickering for which I 
added this code is still there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29464

To: cblack, #plasma, #kwin, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29464: [applets/appmenu] Hide old menu before showing new menu

[Kai Uwe Broulik]

broulik added a comment.


  That focus loss flickering was fixed at some point iirc. I'll try the patch 
tomororw but lgtm

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29464

To: cblack, #plasma, #kwin
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29465: [applets/appmenu] Improve menu feel

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Clever with the `hoverEnabled`, I had to think twice to understand it, though 
:p

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-better-menu-behaviour (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29465

To: cblack, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25984: Load translations

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Looks like D27595  fixes the issue

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D25984

To: broulik, #kirigami, #frameworks, kossebau, aacid
Cc: vkrause, mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ngraham, apol, ahiemstra

D25462: [Colors / Desktop Theme KCM] Use Kirigami.SearchField

[Kai Uwe Broulik]

broulik updated this revision to Diff 83044.
broulik edited the summary of this revision.
broulik added a comment.


  - Drop `placeholderText` since the Kirigami issue has been resolved

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25462?vs=78891&id=83044

REVISION DETAIL
  https://phabricator.kde.org/D25462

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, aspotashev, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29771: [Notifications] Don't take updated time into account for sorting

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:d71181245f13: [Notifications] Don't take updated 
time into account for sorting (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29771?vs=82909&id=83042#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29771?vs=82909&id=83042

REVISION DETAIL
  https://phabricator.kde.org/D29771

AFFECTED FILES
  libnotificationmanager/notificationsortproxymodel.cpp

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:97e843d3ead3: [Free Space Notifer] Use critical 
notification instead of tray icon and monitor… (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29770?vs=82905&id=83036

REVISION DETAIL
  https://phabricator.kde.org/D29770

AFFECTED FILES
  freespacenotifier/CMakeLists.txt
  freespacenotifier/freespacenotifier.cpp
  freespacenotifier/freespacenotifier.h
  freespacenotifier/freespacenotifier.notifyrc
  freespacenotifier/module.cpp
  freespacenotifier/module.h

To: broulik, #plasma, #vdg, ngraham, ndavis, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29691: Restore ability to send tel: URLs to the phone

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  
https://invent.kde.org/plasma/plasma-browser-integration/commit/8c4c240c0c1064893aaba0cd94fadf73f0e908ce

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D29691

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:424217083a8c: [kstart] Port to ApplicationLauncherJob and 
CommandLauncherJob (authored by broulik).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29621?vs=82950&id=82952

REVISION DETAIL
  https://phabricator.kde.org/D29621

AFFECTED FILES
  kstart/CMakeLists.txt
  kstart/kstart.cpp

To: broulik, #plasma, dfaure, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

[Kai Uwe Broulik]

broulik updated this revision to Diff 82950.
broulik added a comment.


  - Drop manual startup stuff
  - Drop C stuff

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29621?vs=82500&id=82950

REVISION DETAIL
  https://phabricator.kde.org/D29621

AFFECTED FILES
  kstart/CMakeLists.txt
  kstart/kstart.cpp

To: broulik, #plasma, dfaure
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in iconapplet.cpp:435
> According to the kservice docs KService::serviceByStorageId() param is
> "the storage id or desktop-file path of the service", so I guess that's why 
> it works.

but "desktop file path" is what we're doing. what I believe is happening that 
you're actually launching the original file, not the one the icon uses.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ahmadsamir wrote in iconapplet.cpp:435
> I tried that first, and it doesn't work; those .desktop files are in a 
> ~/.local/share/plasma_icons, ksycoca doesn't know about that location.

But why would `serviceByStorageId` work then?
Looks like this needs to be `KService::Ptr(new KService(m_localPath))` then?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Kai Uwe Broulik]

broulik added a comment.


  Is there no better way to do this? e.g. the KWin Rules KCM spends 20% of its 
startup time in "retranslate" :/

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause, mart
Cc: davidedmundson, broulik, rikmills, ngraham, apol, plasma-devel, 
fbampaloukas, GB_2, domson, dkardarakos, ahiemstra, mart

D29760: Replace MapProxySource with some javascript code

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> SensorFace.qml:49
> +result = []
> +for (var sensor of root.controller.highPrioritySensorIds) {
> +result.push(root.controller.sensorColors[sensor])

To match "Map"proxy source could have done ;)

  const controller = root.controller;
  return controller.highPrioritySensorIds.map((sensor) => {
  return controller.sensorColors[sensor];
  });

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D29760

To: ahiemstra, #plasma, ngraham, mart
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29771: [Notifications] Don't take updated time into account for sorting

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Notification spec says, when replacing a notification:
  
  > The server must atomically (ie with no flicker or other visual cues) 
replace the given notification with this one.
  
  Notifications shifting about is a "visual cue".

TEST PLAN
  I've noticed that with D29770  where I 
always update notification text, notification can randomly swap places 
depending on which free space job happened to be finished first.
  
  Since this is a "fix to make it more spec compliant", could go into 5.18? 
Definitely should go into 5.19

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29771

AFFECTED FILES
  libnotificationmanager/notificationsortproxymodel.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29770: [Free Space Notifer] Use critical notification instead of tray icon and monitor Root, too

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This refactors the free space notifier module to use a critical (i.e. 
persistent and always on top) notification for warning of low disk space. The, 
albeit blinking, tray icon is easy to miss, especially when you're running a 
full screen terminal, which I typically do while compiling stuff.
  It now also monitors the Root folder, if it's on a separate partition from 
the user's home. Furthermore, Filelight is offered to explore the drive (if 
installed).
  
  The overall warning logic remains pretty much the same:
  
  - Once the drive goes below the configured threshold a warning notification 
is shown, it stays on screen until dismissed by the user or when free space is 
above warning threshold again.
  - The notification is emitted again when free space drops below half the 
previous threshold, for added sense of urgency should the drive be rapidly 
filled up
  - The notification is also emitted again if free space remains below the 
threshold for more than one hour
  
  (It will only emit again when it was closed, obviously, so you won't end up 
with a tonne of popups after a few hours ;)
  
  I don't think this needs to be separately configurable for Home and Root, 
since the default threshold is like 200 MiB (it's not a configured percentage), 
so the absolute free space it warns about will be the same, even if your Home 
is giant compared to Root.
  
  BUG: 340582
  FIXED-IN: 5.20.0

TEST PLAN
  For testing set my threshold to a million MiB:
  F8322073: Screenshot_20200515_093208.png 

  (when Filelight is installed, it will instead say "Open in Filelight")
  
  - Verified that it checks every minute like before
  - Verified that it re-emits when free space drops below half of previous check
  - Verified that notification text is always updated to reflect the free space 
ever time we check for it if the notification is still open
  - Verified that it only monitors root if it's on a separate partition from 
Home
  - Verified that it re-emits the notification after an hour when disk space is 
still low
  - Verified that opening filelight and dolphin work
  - Verified that opening config dialog works and unchecking "warn on..." will 
unload the kded module
  - Verified that manually reloading the kded module enables the setting again

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29770

AFFECTED FILES
  freespacenotifier/CMakeLists.txt
  freespacenotifier/freespacenotifier.cpp
  freespacenotifier/freespacenotifier.h
  freespacenotifier/freespacenotifier.notifyrc
  freespacenotifier/module.cpp
  freespacenotifier/module.h

To: broulik, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29744: [Kicker] Fix jump list actions in RunnerMatchesModel

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:9e545131faa9: [Kicker] Fix jump list actions in 
RunnerMatchesModel (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29744?vs=82836&id=82900

REVISION DETAIL
  https://phabricator.kde.org/D29744

AFFECTED FILES
  applets/kicker/plugin/runnermatchesmodel.cpp

To: broulik, #plasma, hein, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29765: Add a blurless SDDM theme

[Kai Uwe Broulik]

broulik added a comment.


  Can we perhaps add infrastructure so that a theme can provide options?
  For instance, the look and feel package can add options to the lock screen 
KCM which we use for e.g. "always show clock" and "show media controls".
  I'm not keen on duplicating the entire theme for a single option.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29765

To: filipf, #vdg, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29744: [Kicker] Fix jump list actions in RunnerMatchesModel

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Fixes regression caused by me meddling with data in 
6e660cf92d7c3fb0e20527866691eaff9f8bc207 

  Unfortunately KRunner has no notion of "this is application xyz" so Kicker 
has to make assumptions, which broke here.

TEST PLAN
  5.19 please
  
  - Searched for firefox, right clicked the result, got "new incognito tab" 
again
  - Searched for "incognito", got "new incognito tab" result, right clicked, 
didn't get any jump list actions there purposefully

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29744

AFFECTED FILES
  applets/kicker/plugin/runnermatchesmodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:7e2e0bc0: [Reminder] Also advert Chromie store for 
Vivaldi and Brave (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29533?vs=82814&id=82818

REVISION DETAIL
  https://phabricator.kde.org/D29533

AFFECTED FILES
  reminder/browserintegrationreminder.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave

[Kai Uwe Broulik]

broulik updated this revision to Diff 82814.
broulik retitled this revision from "[Reminder] Also advert Chromie store for 
Vivaldi" to "[Reminder] Also advert Chromie store for Vivaldi and Brave".
broulik edited the test plan for this revision.
broulik added a comment.


  - Also for brave

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29533?vs=82271&id=82814

REVISION DETAIL
  https://phabricator.kde.org/D29533

AFFECTED FILES
  reminder/browserintegrationreminder.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> ngraham wrote in UserDetailsPage.qml:217
> FWIW KCMs opened through KRunner are now opened in System Settings so 
> KCMShell is something we're going to have to deal with much less. :)

Yes, but it's still something to consider. Right now Esc does nothing at all, 
and neither do arrow keys. This thing needs some `FocusScope` treatment

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D28154: Add users KCM

[Kai Uwe Broulik]

broulik added a comment.


  Pretty cool

INLINE COMMENTS

> UserDetailsPage.qml:36
> +
> +property variant user
> +property bool overrideImage: false

Use `property var`, or even `property QtObject` since `User` is a `QObject`

> UserDetailsPage.qml:82
> +id: fileDialog
> +title: "Choose a picture"
> +folder: shortcuts.pictures

`i18n`

> UserDetailsPage.qml:96
> +Layout.alignment: Qt.AlignHCenter
> +QQC2.RoundButton {
> +id: userPfp

Is this a `RoundButton` bug that it doesn't indicate keyboard focus when I tab 
to it?

> UserDetailsPage.qml:97
> +QQC2.RoundButton {
> +id: userPfp
> +

Pfp?

> UserDetailsPage.qml:99
> +
> +property int size: 6 * Kirigami.Units.gridUnit
> +

`readonly property`

> UserDetailsPage.qml:111
> +visible: usersDetailPage.user.faceValid || 
> usersDetailPage.overrideImage
> +sourceSize: Qt.size(parent.size, parent.size)
> +cache: false

I *think* one needs to multiple that with `Screen.devicePixelRatio`

> UserDetailsPage.qml:217
> +
> +Kirigami.OverlaySheet {
> +id: picturesSheet

Can you add some way to make Escape close the sheet but not the entire KCM, 
when run standalone through kcmshell? Hopefully the following is sufficient, 
otherwise you'd have to mess with `FocusScope` and the like:

  Keys.onEscapePressed: {
  close();
  event.accepted = true;
  }

> UserDetailsPage.qml:219
> +id: picturesSheet
> +header: RowLayout {
> +Kirigami.Heading {

Is this `RowLayout` needed?

> UserDetailsPage.qml:287
> +model: [
> +"Artist Konqi.png",
> +"Bookworm Konqi.png",

Can we not hardcode the list of avatars, please.
Also, you probably want to use a proper `GridView` for all of this, otherwise 
you end up creating every single delegate immediately on opening.

> UserDetailsPage.qml:342
> +
> +QQC2.Button {
> +Layout.preferredHeight: Kirigami.Units.gridUnit * 6

A tooltip and `Accessible.name` with the name of the avatar would be nice

> UserDetailsPage.qml:346
> +
> +ColumnLayout {
> +anchors.centerIn: parent

Is this `ColumnLayout` needed?

> UserDetailsPage.qml:361
> +
> +Repeater {
> +model: [

What's all of this? I don't see anything in the UI.
Anyway, we probably want to make all of this into a proper `QAbstractListModel`

> UserDetailsPage.qml:399
> +onClicked: {
> +colourRectangle.grabToImage(function(result) 
> {
> +picturesSheet.close()

Not sure if clever or mad :) Can we not just generate a colored rectangle on 
C++ side?

> usermodel.cpp:112
> +{
> +if (!checkIndex(index))
> +{

I just learned that you need to pass 
`QAbstractItemModel::CheckIndesOptions::IndexIsValid` otherwise it only checks 
for blatant out of bounds indices but not invalid "Null" ones :/

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: ltoscano, mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, 
davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, 
Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29687: [IconApplet] Port KRun to ApplicationLauncherJob

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> iconapplet.cpp:435
>  
> -new KRun(QUrl::fromLocalFile(m_localPath), QApplication::desktop());
> +KIO::ApplicationLauncherJob *job = new 
> KIO::ApplicationLauncherJob(KService::serviceByStorageId(m_localPath));
> +job->setUiDelegate(new 
> KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, 
> QApplication::desktop()));

`m_localPath` is a *path* so you want `serviceByDesktopPath`

> iconapplet.cpp:436
> +KIO::ApplicationLauncherJob *job = new 
> KIO::ApplicationLauncherJob(KService::serviceByStorageId(m_localPath));
> +job->setUiDelegate(new 
> KIO::JobUiDelegate(KJobUiDelegate::AutoHandlingEnabled, 
> QApplication::desktop()));
> +job->start();

Use `KNotificationJobUiDelegate`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29687

To: ahmadsamir, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29691: Restore ability to send tel: URLs to the phone

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  They're not `http` or `https` URLs. Add a dedicated handler with appropriate 
"Call on device" label and icon.
  The URL pattern doesn't look like any of the listed examples, but `tel://*/*` 
would refuse on grounds that "tel" isn't a recognized schema but just doing 
"tel:*" works on both Firefox and Chrome.

TEST PLAN
  - Right clicked a link with tel: URL, got a "Call on my phone" entry

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D29691

AFFECTED FILES
  extension/_locales/en/messages.json
  extension/extension-kdeconnect.js
  extension/icons/call-start-symbolic.svg

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29633: [Battery Monitor] Fix toolTipMainText when plugged in

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ddefcfb7c901: [Battery Monitor] Fix toolTipMainText when 
plugged in (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29633?vs=82530&id=82658

REVISION DETAIL
  https://phabricator.kde.org/D29633

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: broulik, #plasma, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidre wrote in shortcutsmodel.cpp:89
> We typically don't have apps with numbers but I can also add it?

Ah, this is for apps, but yeah, why not...

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29644: Select application after it is added

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> main.qml:97
> +id: transition
> +PropertyAnimation {
> +target: components

Sounds like you want `PropertyAction`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  addIndex (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29644

To: davidre, broulik, ngraham, #plasma, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Thanks
  please phrase the commit message the opposite way. State what the commit 
changes, not what the state was before the commit.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29651

To: epopov, ngraham, plasma-devel, broulik
Cc: broulik, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> batterymonitor.qml:61
> +} else {
> +return i18n("Battery charging, currently at %1%", 
> pmSource.data.Battery.Percent)
>  }

Also, just because it's plugged in, doesn't mean it's charging.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29636

To: ngraham, broulik, #plasma, #localization, yurchor
Cc: yurchor, ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29636: [applets/batterymonitor] Fix tooltip main text not updating while plugged in and charging

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  The tooltip logic was completely rewritten in 5.19. This patch does not apply 
to 5.18.
  Also, D29633 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29636

To: ngraham, broulik, #plasma, #localization, yurchor
Cc: yurchor, ltoscano, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29632: [kcms/keys] Use better collator settings

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> shortcutsmodel.cpp:89
>  QCollator collator;
> +collator.setCaseSensitivity(Qt::CaseInsensitive);
>  std::sort(m_components.begin(), m_components.end(), 
> [&](const Component &c1, const Component &c2){

Why no numeric mode here?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  collator (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29632

To: davidre, ognarb, broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29633: [Battery Monitor] Fix toolTipMainText when plugged in

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It only had a return value for "NoCharge" since the else case was only for 
not plugged in, resulting in it effectively returning `undefined`, throwing 
during assignment "cannot assign [undefined] to string" and leaving whatever 
text happened to be shown last.

TEST PLAN
  Literally none

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29633

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/batterymonitor.qml

To: broulik, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29621: [kstart] Port to ApplicationLauncherJob and CommandLauncherJob

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, dfaure.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The existing `--service` is kept for compatibility as it prints out the 
actually registered DBus name.
  A new argument `--application` is added which also takes a desktop //name//. 
It prints the launched PID.

TEST PLAN
  - `kstart5 kwrite` launches kwrite
  - `kstart5 --application org.kde.kwrite` launches kwrites and has it properly 
scoped
  - `kstart5 --application org.kde.kwrite --maximize` launches kwrite and has 
it properly scoped and its window maximized
  - `kstart5 --application org.kde.kwrite --url file:///home/foo/bar` launches 
kwrite with that file open

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D29621

AFFECTED FILES
  kstart/CMakeLists.txt
  kstart/kstart.cpp

To: broulik, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29475: [Global Shortcuts KCM] Also check PortableText

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c6a8b2f5e940: [Global Shortcuts KCM] Also check 
PortableText (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29475?vs=82073&id=82494

REVISION DETAIL
  https://phabricator.kde.org/D29475

AFFECTED FILES
  kcms/keys/filteredmodel.cpp

To: broulik, #plasma, #vdg, davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29594: Close low battery notificaton when showing critical

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R122:afff6ae64f42: Close low battery notificaton when showing 
critical (authored by broulik).

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29594?vs=82422&id=82493

REVISION DETAIL
  https://phabricator.kde.org/D29594

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma, nicolasfella
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29594: Close low battery notificaton when showing critical

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When not acknowledging the low battery notification, close it when showing 
the critical one, to avoid showing contradicting notificatoins.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D29594

AFFECTED FILES
  daemon/powerdevilcore.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29533: [Reminder] Also advert Chromie store for Vivaldi

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  They advertise supporting Chrome extensions

TEST PLAN
  Untested
  
  To test:
  
  - Run kded with `PLASMA_BROWSE_REMIND_FORCE=1`, load the reminder module in 
background services kcm (it disables autoloading if it has reminded once), then 
launch vivaldi through its desktop file (i.e. not the shell runner)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D29533

AFFECTED FILES
  reminder/browserintegrationreminder.cpp

To: broulik, #plasma, fvogt
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29393: Use player "poster" as album cover if available

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:811ae0dd5a54: Use player "poster" as album 
cover if available (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29393?vs=81828&id=82240

REVISION DETAIL
  https://phabricator.kde.org/D29393

AFFECTED FILES
  extension/content-script.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

[Kai Uwe Broulik]

broulik added a comment.


  Ah, right, we just use the sort filter model, no model from C++. Meh, so I 
can't think of a better way right now either..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28180

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28180: [applets/systemtray] Hide/show expander arrow - regression fix

[Kai Uwe Broulik]

broulik added a comment.


  I would suggest we add a `count` property with a `NOTIFY` signal on the model 
which is then updated on C++ side? I find that cleaner than doing that from QML 
like this

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28180

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Kai Uwe Broulik]

broulik added a comment.


  > Switching to it would also require user data. How many users use a vertical 
panel?
  
  Yes, please!
  It also imho depends on the usecase. On a laptop you're more likely to use a 
left vertical panel than on a giant desktop setup with multiple monitors.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma, filipf
Cc: broulik, filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29474: Add inHistory bool and hide heading on inHistory

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  I kinda think this should be named more generically, e.g. 
`headerBackgroundVisible`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29478: [Clipboard Plasmoid] Port to Prison QML import

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, vkrause.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Which does the rendering and proper sizing for us, e.g. ensure integer 
scaling so the barcode remains scannable.
  While at it, fix `supportsBarcode` (wasn't routed through to the delegate 
component when it was split out) and add Code 128 which is in Prison now.
  Also, show a label when the barcode would become too large to display (mostly 
for the 1D barcodes).

TEST PLAN
  F8288986: Screenshot_20200506_125330.png 

  F8288990: Screenshot_20200506_125433.png 

  F8288987: Screenshot_20200506_125354.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29478

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/DelegateToolButtons.qml
  applets/clipboard/contents/ui/Menu.qml

To: broulik, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29475: [Global Shortcuts KCM] Also check PortableText

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to find keyboard shortcuts without knowing the localized key 
designation.

TEST PLAN
  F8288879: Screenshot_20200506_114738.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29475

AFFECTED FILES
  kcms/keys/filteredmodel.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

[Kai Uwe Broulik]

broulik added a comment.


  > I added one last thing
  
  Can we please not mix behavior changes into a patch that fixes bugs and 
regressions.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:a5c9e000b9c9: [Notifications] Don't show do not 
disturb end date beyond 100 days (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28740?vs=79818&id=81973

REVISION DETAIL
  https://phabricator.kde.org/D28740

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/main.qml

To: broulik, #plasma, ngraham
Cc: ngraham, bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Kai Uwe Broulik]

broulik added a comment.


  Generally +1
  Nice idea with this `Media` singleton

INLINE COMMENTS

> ExpandedRepresentation.qml:65
> +}
> +Media.lockPositionUpdate= false
> +}

Coding style, space

> ExpandedRepresentation.qml:99
>  seekSlider.value = Math.max(0, seekSlider.value - 500) 
> // microseconds
> -seekSlider.moved();
> +seekSlider.moved()
>  } else if (event.key === Qt.Key_Right || event.key === Qt.Key_L) 
> {

Unrelated cleanup

> Media.qml:6
> +
> +Item {
> +id: media

Make this a `QtObject`

> Media.qml:87
> +
> +readonly property int play: 0
> +readonly property int pause: 1

Just pass the action string through, since all we do below is map the number 
back to a string

> Media.qml:141
> +sources.filter(source => source !== mpris2Source.multiplexSource)
> +   .forEach(source => {
> +   model.push({

or `map()` and then `unshift` the multiplexer :p

> Media.qml:187
> +function togglePlaying() {
> +print(Media.state)
> +if (Media.state === "playing" && Media.canPause) {

Remove debug prints

> Media.qml:197
> +
> +states: [
> +State {

Turn this into a property with an `if` when this is no longer an `Item`

> main.qml:155
>  name: "playing"
> -when: !root.noPlayer && mpris2Source.currentData.PlaybackStatus 
> === "Playing"
> +when: Media.state == "playing"
>  

You can just set `state: Media.state` rather than `when` on every state

> main.qml:159
>  target: plasmoid
> -icon: albumArt ? albumArt : "media-playback-playing"
> -toolTipMainText: track
> -toolTipSubText: artist ? i18nc("by Artist (player name)", 
> "by %1 (%2)", artist, identity) : identity
> +icon: Media.albumArt ? Media.albumArt : 
> "media-playback-playing"
> +toolTipMainText: Media.currentTrack

We don't set album art on the icon anymore, cf D28917 


> main.qml:243
> -
> -function action_open() {
> -serviceOp(mpris2Source.current, "Raise");

You can't remove these, they are wired up to the `plasmoid.setAction` calls 
above. (Yes, I'd like to have an API to pass a JS callback :p but this is how 
it works right now)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: broulik, trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29315: [applets/batterymonitor] Port inhibition message to Layouts and match notifications applet

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> PowerManagementItem.qml:62
> +Layout.fillWidth: true
> +Layout.leftMargin: units.gridUnit + units.smallSpacing // width of 
> checkbox and spacer
>  spacing: units.smallSpacing

Try if this works with right-to-left layout, or should we ignore this and hope 
david's patch goes in?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29315

To: ngraham, #vdg, #plasma, broulik, manueljlin, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29411: [KRunner] Watch config with KConfigWatcher

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:6db69ae09524: [KRunner] Watch config with KConfigWatcher 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29411?vs=81896&id=81904#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29411?vs=81896&id=81904

REVISION DETAIL
  https://phabricator.kde.org/D29411

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h

To: broulik, #plasma, ngraham, ksmanis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29410: [Runners KCM] Notify history deletion

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8fe03502660c: [Runners KCM] Notify history deletion 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29410?vs=81895&id=81901

REVISION DETAIL
  https://phabricator.kde.org/D29410

AFFECTED FILES
  kcms/runners/kcm.cpp

To: broulik, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29411: [KRunner] Watch config with KConfigWatcher

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham, ksmanis.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Rather than using a `KDirWatch` that points to the wrong place.

TEST PLAN
  5.18 please
  
  - Cleared history in KCM with D29410 , 
confi was reloaded and history gone right away

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29411

AFFECTED FILES
  krunner/view.cpp
  krunner/view.h

To: broulik, #plasma, ngraham, ksmanis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29410: [Runners KCM] Notify history deletion

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  So KRunner can catch that in a `KConfigWatcher`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29410

AFFECTED FILES
  kcms/runners/kcm.cpp

To: broulik, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Kai Uwe Broulik]

broulik added a comment.


  Ideally, we'd change the KCM to write the key with `KConfig::Notify` and then 
use `KConfigWatcher` here

REPOSITORY
  R120 Plasma Workspace

BRANCH
  krunner-fix-watched-config-path (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29401: [KRunner] Fix watched config file path

[Kai Uwe Broulik]

broulik added a comment.


  That's not the bug I tried to solve in D26444 
, was it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29401

To: ksmanis, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28740: [Notifications] Don't show do not disturb end date beyond 100 days

[Kai Uwe Broulik]

broulik added a comment.


  I find "for a year" odd. Also, this is a bug fix, so can we get this in or 
not. Changing strings can then be done in master, if we want to.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28740

To: broulik, #plasma
Cc: ngraham, bport, pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart