Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/ --- Review request for Plasma. Summary --- This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3. Diffs - /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 949231 /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 949231 Diff: http://reviewboard.kde.org/r/521/diff Testing --- Unfortunately I don't have possibility to test if this works property after porting from custom clock. I've tested only if it compiles. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/ --- (Updated 2009-04-20 03:16:22.257265) Review request for Plasma. Summary --- This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3. Diffs - /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 956306 /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 956306 Diff: http://reviewboard.kde.org/r/521/diff Testing (updated) --- Tested using digital-clock and analog-clock applets from trunk and it works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/ --- (Updated 2009-04-20 03:09:12.855492) Review request for Plasma. Changes --- Remove & from copied text. Summary --- This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3. Diffs (updated) - /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 956306 /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 956306 Diff: http://reviewboard.kde.org/r/521/diff Testing --- Unfortunately I don't have possibility to test if this works property after porting from custom clock. I've tested only if it compiles. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Context menu for fast copying date and time strings to clipboard (libplasmaclock)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/521/ --- (Updated 2009-04-20 09:51:21.099386) Review request for Plasma. Changes --- This solution for clipboard menu should be better (update also when opening menu using keyboard and delete object in destructor). Summary --- This patch tries to add context menu with formatted date and time strings to clocks (by adding it to plasmaclock library) like in KDE3. Diffs (updated) - /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.h 956306 /trunk/KDE/kdebase/workspace/libs/plasmaclock/clockapplet.cpp 956306 Diff: http://reviewboard.kde.org/r/521/diff Testing --- Tested using digital-clock and analog-clock applets from trunk and it works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Activate present windows from task group context menu
> On 2009-06-27 04:53:14, Marco Martin wrote: > > i like it! > > i was also experimenting in the taskbar applet, (like with clicking on the > > group while pressing control) and mostly ended up with duplicate code, now, > > i am wondering: > > what about providing a TaskGroupItem::presentWindows()? (that would > > basically be a carbon copy of PresentWindowsActionImpl) in this way it > > could be used by the context menu -and- by the applet.. Good idea. :-) - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/897/#review1397 --- On 2009-06-27 04:30:57, Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/897/ > --- > > (Updated 2009-06-27 04:30:57) > > > Review request for Plasma. > > > Summary > --- > > Patch adds a new menu entry to task group context menu to show the group of > windows in kwin's present windows effect. When this entry is selected the > window ids of the tasks listed in the group are passed to an XAtom which > activates present windows effect for the passed windows (other windows will > be hidden). The atom will be removed by present windows effect when it get's > disabled. > > This patch requires current kwin from trunk. What's missing is the detection > if present windows effect is available or not (e.g. compositing not active, > Compiz used instead of KWin). KWin announces support via setting atom on root > window. > > > Diffs > - > > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions.cpp 972097 > trunk/KDE/kdebase/workspace/libs/taskmanager/taskactions_p.h 972097 > > Diff: http://reviewboard.kde.org/r/897/diff > > > Testing > --- > > Tested with both manual and automatic grouping. > > > Thanks, > > Martin > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Custom combo boxes for Plasma::ComboBox
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- Review request for Plasma and Marco Martin. Summary --- This patch adds possibility to use custom combo box widgets (subclassed from KComboBox) instead of plain KComboBox. It's intended for 4.3 (better later than never..., didn't know that there is still no possibility to do something like this and no possibility to create custom Plasma themed widget). It adds new constructor to set widget without creating new like in first. It will be used by Run Command applet (KHistoryComboBox, waiting for theming possibility for very long time) and probably by others in the future. If it will be accepted I'll probably prepare similar patches to some other widgets (most common) for consistency and bigger flexibility that comes without costs (as far as I know). Diffs - /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1000582 /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1000582 Diff: http://reviewboard.kde.org/r/1094/diff Testing --- Tested by my friend, compiles and works. Screenshots --- Plasma themed KHistoryComboBox in Run Command applet http://reviewboard.kde.org/r/1094/s/151/ Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom combo boxes for Plasma::ComboBox
> On 2009-07-21 18:37:25, Marco Martin wrote: > > I like the idea,since doesn't make sense a new plasma widget for every > > conceivale thing, i think adding the possibility (just for c++ ones?) of > > putting a subclass in does make the thing more flexible while not putting > > too many exported symbols > > of course if it's ok for the combobox it should be done for all > > proxywidgets, either all of them or nothing :) As discussed on IRC, for now we don't need that (could be done with ugly way be setting new widget for proxy that has style taken from widget created in Plasma widget) and there is possible problem with widgets created using: Plasma::ComboBox(NULL)... But we could try to find better solution for 4.4 probably, by adding method that sets own widget instead current, connects signals and slots and sets style. Maybe someone has better idea? - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review1705 ------- On 2009-07-21 15:55:33, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1094/ > --- > > (Updated 2009-07-21 15:55:33) > > > Review request for Plasma and Marco Martin. > > > Summary > --- > > This patch adds possibility to use custom combo box widgets (subclassed from > KComboBox) instead of plain KComboBox. > It's intended for 4.3 (better later than never..., didn't know that there is > still no possibility to do something like this and no possibility to create > custom Plasma themed widget). > It adds new constructor to set widget without creating new like in first. > It will be used by Run Command applet (KHistoryComboBox, waiting for theming > possibility for very long time) and probably by others in the future. > If it will be accepted I'll probably prepare similar patches to some other > widgets (most common) for consistency and bigger flexibility that comes > without costs (as far as I know). > > > Diffs > - > > /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1000582 > /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1000582 > > Diff: http://reviewboard.kde.org/r/1094/diff > > > Testing > --- > > Tested by my friend, compiles and works. > > > Screenshots > --- > > Plasma themed KHistoryComboBox in Run Command applet > http://reviewboard.kde.org/r/1094/s/151/ > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom combo boxes for Plasma::ComboBox
> On 2009-07-23 04:12:32, Aaron Seigo wrote: > > if this is needed (which it may be in this case) then it should not be done > > using a constructor imo but rather a setNativeWidget method. that a > > combobox is created and then discarded in the process is a non-issue (it's > > not a hot path and the execution time of that code is quite negligable). Right, I was thinking also about this solution. Maybe we should move all code that sets style and connects signals and slots to that method and call it with new widget from constructor (to avoid code duplication)? I'll prepare new patch later. - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review1722 ------- On 2009-07-21 15:55:33, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1094/ > --- > > (Updated 2009-07-21 15:55:33) > > > Review request for Plasma and Marco Martin. > > > Summary > --- > > This patch adds possibility to use custom combo box widgets (subclassed from > KComboBox) instead of plain KComboBox. > It's intended for 4.3 (better later than never..., didn't know that there is > still no possibility to do something like this and no possibility to create > custom Plasma themed widget). > It adds new constructor to set widget without creating new like in first. > It will be used by Run Command applet (KHistoryComboBox, waiting for theming > possibility for very long time) and probably by others in the future. > If it will be accepted I'll probably prepare similar patches to some other > widgets (most common) for consistency and bigger flexibility that comes > without costs (as far as I know). > > > Diffs > - > > /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1000582 > /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1000582 > > Diff: http://reviewboard.kde.org/r/1094/diff > > > Testing > --- > > Tested by my friend, compiles and works. > > > Screenshots > --- > > Plasma themed KHistoryComboBox in Run Command applet > http://reviewboard.kde.org/r/1094/s/151/ > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- Review request for Plasma. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
> On 2009-08-10 06:41:57, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, > > line 43 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line43> > > > > 42 + 13? This is taken from Imageshack backend, strange notation indeed. ;-) > On 2009-08-10 06:41:57, Chani wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp, line 101 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9804#file9804line101> > > > > why are all these image server classes being cast to themselves? This is also question to applet developer, I can later create patch that fixes thinks like that and also adds possibility to show error message (at least this backend can show different error messages, API returns codes). - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1948 ------- On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1251/ > --- > > (Updated 2009-08-09 21:08:23) > > > Review request for Plasma. > > > Summary > --- > > This patch adds support for Simplest Image Hosting > (http://simplest-image-hosting.net/) to pastebin applet. > > > Diffs > - > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h > PRE-CREATION > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui > 1008396 > > Diff: http://reviewboard.kde.org/r/1251/diff > > > Testing > --- > > Works fine except showing error icon even if upload is successful (there is > success notification and link is added to history). > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
> On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp, > > line 54 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line54> > > > > maybe you get the error post icon even after a successful post because > > it tries to retrieve more data and then you fall in this place. not sure > > though and right now I don't have the time to test. Check form where > > postError() is being emited on your backend code. (probably from here) Thanks for the hint, I'll test it with qDebug(). ;-) > On 2009-08-10 12:00:23, Artur de Souza (MoRpHeUz) wrote: > > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui, line > > 57 > > <http://reviewboard.kde.org/r/1251/diff/1/?file=9806#file9806line57> > > > > With more plugins being added we need to properly fix this config tab > > now. We postponed this as much as we could but now we should do it > > properly. I'll come with something later (plane to tokamak? hehe). Yes, this should be done cleaner, maybe it is possible to create kind of service for backends and use them through data engine, as mentioned earlier? - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review1950 --- On 2009-08-09 21:08:23, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1251/ > --- > > (Updated 2009-08-09 21:08:23) > > > Review request for Plasma. > > > Summary > --- > > This patch adds support for Simplest Image Hosting > (http://simplest-image-hosting.net/) to pastebin applet. > > > Diffs > - > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h > PRE-CREATION > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui > 1008396 > > Diff: http://reviewboard.kde.org/r/1251/diff > > > Testing > --- > > Works fine except showing error icon even if upload is successful (there is > success notification and link is added to history). > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:41:16.451067) Review request for Plasma. Changes --- Fixed showing error notification on success. This was indeed second call of that method with empty data (strange, there should be no redirection, there was comment about that in imageshack backend). Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-10 16:56:55.220998) Review request for Plasma. Changes --- Fixed coding style. Summary --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine except showing error icon even if upload is successful (there is success notification and link is added to history). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
> On 2009-08-10 16:51:06, Artur de Souza (MoRpHeUz) wrote:
> > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp,
> > line 57
> > <http://reviewboard.kde.org/r/1251/diff/1/?file=9802#file9802line57>
> >
> > Minor but important: not sure if kdeplasma-addons have coding style
> > guidelines but following kdelibs, "if" statements should have the "{" on
> > the same line :)
> >
Fixed in new diff.
Personally I don't use in my work that coding style (I was using it for some
years, but new line is more readable for me and not only me ;-)).
By the way, I could try to rewrite this applet from scratch and add for example
support for error messages (SIH returns different error messages for example),
that could be passed as signal parameter.
- Michal
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1251/#review1964
-------
On 2009-08-10 16:56:55, Michal Dutkiewicz wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1251/
> ---
>
> (Updated 2009-08-10 16:56:55)
>
>
> Review request for Plasma.
>
>
> Summary
> ---
>
> This patch adds support for Simplest Image Hosting
> (http://simplest-image-hosting.net/) to pastebin applet.
>
>
> Diffs
> -
>
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui
> 1008396
>
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp
> PRE-CREATION
> /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396
>
> /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h
> PRE-CREATION
>
> Diff: http://reviewboard.kde.org/r/1251/diff
>
>
> Testing
> ---
>
> Works fine except showing error icon even if upload is successful (there is
> success notification and link is added to history).
>
>
> Thanks,
>
> Michal
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Center tool tips in Plasma
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch aims to provide centered tool tips for Plasma (aligned to edge in some cases looks bad). Diffs - /trunk/KDE/kdelibs/plasma/corona.h 1016281 /trunk/KDE/kdelibs/plasma/corona.cpp 1016281 /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1016281 Diff: http://reviewboard.kde.org/r/1428/diff Testing --- Tested only if compile, not tested if works (can't compile full trunk now... problems with Akonadi), relies on commented out code to center popups. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Center tool tips in Plasma
> On 2009-08-28 21:42:20, Aaron Seigo wrote: > > /trunk/KDE/kdelibs/plasma/corona.cpp, line 511 > > <http://reviewboard.kde.org/r/1428/diff/1/?file=10799#file10799line511> > > > > i thought we were going to avoid the bool and instead use Qt::Alignment? So only one public method with optional Alignment flag (by default alignment would be as now, usually to left edge etc.) and for now accepting only Qt::AlignCenter? - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/#review2173 --- On 2009-08-28 20:26:02, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1428/ > --- > > (Updated 2009-08-28 20:26:02) > > > Review request for Plasma and Aaron Seigo. > > > Summary > --- > > This patch aims to provide centered tool tips for Plasma (aligned to edge in > some cases looks bad). > > > Diffs > - > > /trunk/KDE/kdelibs/plasma/corona.h 1016281 > /trunk/KDE/kdelibs/plasma/corona.cpp 1016281 > /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1016281 > > Diff: http://reviewboard.kde.org/r/1428/diff > > > Testing > --- > > Tested only if compile, not tested if works (can't compile full trunk now... > problems with Akonadi), relies on commented out code to center popups. > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 11:53:32.697101) Review request for Plasma. Changes --- Updated to last changes and added buddies for all labels in configuration dialog. Warning! Diff is available at http://pastebin.ca/1548163 (couldn't update here, upload fails...). Summary (updated) --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet and additionally adds buddies for labels in configuration dialog. New diff is available here (can't upload new for unknown reason :-/): http://pastebin.ca/1548163 Diffs - /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1008396 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION Diff: http://reviewboard.kde.org/r/1251/diff Testing (updated) --- Works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/ --- (Updated 2009-08-30 12:13:25.327179) Review request for Plasma. Changes --- Finally uploaded new diff... Summary (updated) --- This patch adds support for Simplest Image Hosting (http://simplest-image-hosting.net/) to pastebin applet and additionally adds buddies for labels in configuration dialog. Diffs (updated) - /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp PRE-CREATION /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1017356 /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui 1017356 Diff: http://reviewboard.kde.org/r/1251/diff Testing --- Works fine. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom combo boxes for Plasma::ComboBox
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-08-30 16:39:32.923467) Review request for Plasma, Aaron Seigo and Marco Martin. Changes --- New approach, constructor replaced by setNativeWidget() method. It's time to decide which widgets should also have this method, personally I think that at least LineEdit, SpinBox, TextEdit should have it (others usually are not sub classed, at least as far as I know). Summary (updated) --- This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox. Diffs (updated) - /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1016281 /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1016281 Diff: http://reviewboard.kde.org/r/1094/diff Testing (updated) --- Compiles and should work, but not tested. Screenshots --- Plasma themed KHistoryComboBox in Run Command applet http://reviewboard.kde.org/r/1094/s/151/ Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Simplest Image Hosting support for pastebin applet
> On 2009-08-30 16:51:34, Artur de Souza (MoRpHeUz) wrote: > > Do you have an svn account to ship it ? Otherwise just poke me on IRC. I have one, I'll commit it now. :-) - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1251/#review2189 --- On 2009-08-30 12:13:25, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1251/ > --- > > (Updated 2009-08-30 12:13:25) > > > Review request for Plasma. > > > Summary > --- > > This patch adds support for Simplest Image Hosting > (http://simplest-image-hosting.net/) to pastebin applet and additionally adds > buddies for labels in configuration dialog. > > > Diffs > - > > /trunk/KDE/kdeplasma-addons/applets/pastebin/CMakeLists.txt 1017356 > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/backends.h 1017356 > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.h > PRE-CREATION > > /trunk/KDE/kdeplasma-addons/applets/pastebin/backends/simplestimagehosting.cpp > PRE-CREATION > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.h 1017356 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebin.cpp 1017356 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinConfig.ui 1017356 > /trunk/KDE/kdeplasma-addons/applets/pastebin/pastebinServersConfig.ui > 1017356 > > Diff: http://reviewboard.kde.org/r/1251/diff > > > Testing > --- > > Works fine. > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom combo boxes for Plasma::ComboBox
> On 2009-08-30 19:40:51, Aaron Seigo wrote: > > i'm fine with this going in; line edit and text edits too, i think. but > > spinbox? i don't think it's that common to subclass it ...? OK, so maybe I'll add these widgets and then upload one bigger patch, tomorrow I'll have someone to test code. In case if it will be needed also for others widgets then it could be added later, there is plenty of time before 4.4. ;-) - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/#review2193 ------- On 2009-08-30 16:39:32, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1094/ > --- > > (Updated 2009-08-30 16:39:32) > > > Review request for Plasma, Aaron Seigo and Marco Martin. > > > Summary > --- > > This patch adds possibility to use custom combo box widgets (sub classed from > KComboBox) instead of plain KComboBox. > > > Diffs > - > > /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1016281 > /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1016281 > > Diff: http://reviewboard.kde.org/r/1094/diff > > > Testing > --- > > Compiles and should work, but not tested. > > > Screenshots > --- > > Plasma themed KHistoryComboBox in Run Command applet > http://reviewboard.kde.org/r/1094/s/151/ > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Keyboard navigation support for Tasks applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1482/ --- Review request for Plasma, Aaron Seigo and Marco Martin. Summary --- This patch adds support for [Shift + ] Tab navigation (and Enter / Return to activate item) in Tasks plasmoid. In order to work it needs fixing of panel focusing issue (as discussed on mailing list), I could apply mine method for temporary use if needed. Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017471 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017471 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1017471 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1017471 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017471 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp 1017471 Diff: http://reviewboard.kde.org/r/1482/diff Testing --- Tested in plasmoidviwer and works (groups may need additional testing). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Keyboard navigation support for Tasks applet
> On 2009-08-31 08:58:13, Marco Martin wrote: > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp, line > > 696 > > <http://reviewboard.kde.org/r/1482/diff/1/?file=10850#file10850line696> > > > > should be circular and logic for this is already in the wheel event, > > you should use that ()then wheelevent calling focusPrevNex (don't really > > like the name btw) This is Qt built in method, I'll port wheel event to use it (using built in handling of Tab is best way I think ;-)). But there is one problem, in case of wheel event we can simply activate window but in case of [Shift + ] Tab it is not so easy, especially before fixing focus for panels, so I'll stick with Enter / Return to activate when using keyboard. - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1482/#review2208 ------- On 2009-08-30 20:46:50, Michal Dutkiewicz wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1482/ > --- > > (Updated 2009-08-30 20:46:50) > > > Review request for Plasma, Aaron Seigo and Marco Martin. > > > Summary > --- > > This patch adds support for [Shift + ] Tab navigation (and Enter / Return to > activate item) in Tasks plasmoid. > In order to work it needs fixing of panel focusing issue (as discussed on > mailing list), I could apply mine method for temporary use if needed. > > > Diffs > - > > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017471 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017471 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h > 1017471 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp > 1017471 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017471 > /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp > 1017471 > > Diff: http://reviewboard.kde.org/r/1482/diff > > > Testing > --- > > Tested in plasmoidviwer and works (groups may need additional testing). > > > Thanks, > > Michal > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Keyboard navigation support for Tasks applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1482/ --- (Updated 2009-08-31 14:04:45.714405) Review request for Plasma, Aaron Seigo and Marco Martin. Changes --- Ported wheelEvent() to use the same logic for changing active task (hope that it is right approach). By the way, why wheelEvent() is protected slot here? Summary --- This patch adds support for [Shift + ] Tab navigation (and Enter / Return to activate item) in Tasks plasmoid. In order to work it needs fixing of panel focusing issue (as discussed on mailing list), I could apply mine method for temporary use if needed. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp 1017535 Diff: http://reviewboard.kde.org/r/1482/diff Testing --- Tested in plasmoidviwer and works (groups may need additional testing). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Keyboard navigation support for Tasks applet
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1482/ --- (Updated 2009-08-31 16:03:46.974286) Review request for Plasma, Aaron Seigo and Marco Martin. Changes --- Use available methods instead querying layout directly and possible optimization when there is only one task. Summary --- This patch adds support for [Shift + ] Tab navigation (and Enter / Return to activate item) in Tasks plasmoid. In order to work it needs fixing of panel focusing issue (as discussed on mailing list), I could apply mine method for temporary use if needed. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.h 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/abstracttaskitem.cpp 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.h 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/taskgroupitem.cpp 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.h 1017535 /trunk/KDE/kdebase/workspace/plasma/applets/tasks/windowtaskitem.cpp 1017535 Diff: http://reviewboard.kde.org/r/1482/diff Testing --- Tested in plasmoidviwer and works (groups may need additional testing). Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-08-31 16:26:07.434735) Review request for Plasma, Aaron Seigo and Marco Martin. Changes --- Include LineEdit and TextEdit too. Summary (updated) --- This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox and similar possibilities for text and line edits. Diffs (updated) - /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1016281 /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1016281 /trunk/KDE/kdelibs/plasma/widgets/lineedit.h 1016281 /trunk/KDE/kdelibs/plasma/widgets/lineedit.cpp 1016281 /trunk/KDE/kdelibs/plasma/widgets/textedit.h 1016281 /trunk/KDE/kdelibs/plasma/widgets/textedit.cpp 1016281 Diff: http://reviewboard.kde.org/r/1094/diff Testing --- Compiles and should work, but not tested. Screenshots --- Plasma themed KHistoryComboBox in Run Command applet http://reviewboard.kde.org/r/1094/s/151/ Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: big revamp of Device Notifier
On 2009-09-10 18:18:27, Giulio Camuffo wrote: > > I still don't like the fact that you have to click twice to select the > > action if there is only one available action.. we should find a solution > > for this.. > > Giulio Camuffo wrote: > I agree. > Maybe we could show the actions on hover. This would require then a > single click, but on the other hand it could be a bit annoying if you have > many devices and you have to get to the one on the other side of the applet. > Maybe we could show the actions on hover. What about showing them with delay (so fast mouse move won't trigger showing)? - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2266 --- On 2009-09-01 16:55:56, Giulio Camuffo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1370/ > --- > > (Updated 2009-09-01 16:55:56) > > > Review request for Plasma. > > > Summary > --- > > This is a patch that modifies quite heavily the behaviour of the Device > Notifier. > It comes from here: > http://kde-look.org/content/show.php/Device+Manager?content=106051 > It can show the not removable devices too, it can mount them automatically or > with a click, since the "eject" button is a "mount" button when the volume is > umounted. So that guy on the dot will be ok. > It can hide some items in the same way as Dolphin's places (hide item/ show > all). > Finally, it shows the various opening actions under the device instead of > calling that xp-ish window. > > > Diffs > - > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui > PRE-CREATION > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp > 1013960 > > Diff: http://reviewboard.kde.org/r/1370/diff > > > Testing > --- > > I'm using it every day since I released 0.1 on Kde-look. I tried all the > options on my pc and they work. Some people on kde-look posted some comments > about some problems, but it seems to me they are very particular cases, so in > my opinion it is quite stable to go in trunk, but anyway review it! :) > > > Screenshots > --- > > screen > http://reviewboard.kde.org/r/1370/s/183/ > > > Thanks, > > Giulio > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: big revamp of Device Notifier
On 2009-09-10 18:18:27, Giulio Camuffo wrote: > > I still don't like the fact that you have to click twice to select the > > action if there is only one available action.. we should find a solution > > for this.. > > Giulio Camuffo wrote: > I agree. > Maybe we could show the actions on hover. This would require then a > single click, but on the other hand it could be a bit annoying if you have > many devices and you have to get to the one on the other side of the applet. > > Michal Dutkiewicz wrote: > > Maybe we could show the actions on hover. > > What about showing them with delay (so fast mouse move won't trigger > showing)? > > Giulio Camuffo wrote: > This could be a solution, but could make this feature less discoverable > This could be a solution, but could make this feature less discoverable Depends how long is that delay. ;-) I think that it could be something like 200 milliseconds, but could be adjusted after some testing. - Michal --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1370/#review2266 --- On 2009-09-01 16:55:56, Giulio Camuffo wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/1370/ > --- > > (Updated 2009-09-01 16:55:56) > > > Review request for Plasma. > > > Summary > --- > > This is a patch that modifies quite heavily the behaviour of the Device > Notifier. > It comes from here: > http://kde-look.org/content/show.php/Device+Manager?content=106051 > It can show the not removable devices too, it can mount them automatically or > with a click, since the "eject" button is a "mount" button when the volume is > umounted. So that guy on the dot will be ok. > It can hide some items in the same way as Dolphin's places (hide item/ show > all). > Finally, it shows the various opening actions under the device instead of > calling that xp-ish window. > > > Diffs > - > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/CMakeLists.txt > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/configurationpage.ui > PRE-CREATION > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicespaceinfodelegate.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.h > 1013960 > > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierdialog.cpp > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.h > 1013960 > /trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/notifierview.cpp > 1013960 > > Diff: http://reviewboard.kde.org/r/1370/diff > > > Testing > --- > > I'm using it every day since I released 0.1 on Kde-look. I tried all the > options on my pc and they work. Some people on kde-look posted some comments > about some problems, but it seems to me they are very particular cases, so in > my opinion it is quite stable to go in trunk, but anyway review it! :) > > > Screenshots > --- > > screen > http://reviewboard.kde.org/r/1370/s/183/ > > > Thanks, > > Giulio > > ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Custom native widgets for Plasma::ComboBox, Plasma::LineEdit and Plasma::TextEdit
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1094/ --- (Updated 2009-09-22 10:30:38.640491) Review request for Plasma, Aaron Seigo and Marco Martin. Changes --- Updated to last changes. Tested with KHistoryComboBox, KRestrictedLine and KTextEdit. Summary --- This patch adds possibility to use custom combo box widgets (sub classed from KComboBox) instead of plain KComboBox and similar possibilities for text and line edits. Diffs (updated) - /trunk/KDE/kdelibs/plasma/widgets/combobox.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/combobox.cpp 1025780 /trunk/KDE/kdelibs/plasma/widgets/lineedit.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/lineedit.cpp 1025780 /trunk/KDE/kdelibs/plasma/widgets/textedit.h 1025780 /trunk/KDE/kdelibs/plasma/widgets/textedit.cpp 1025780 Diff: http://reviewboard.kde.org/r/1094/diff Testing --- Compiles and should work, but not tested. Screenshots --- Plasma themed KHistoryComboBox in Run Command applet http://reviewboard.kde.org/r/1094/s/151/ Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Center tool tips in Plasma
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1428/ --- (Updated 2009-09-27 13:18:54.556459) Review request for Plasma and Aaron Seigo. Changes --- Replaced bool parameter by alignment flag, added new public methods, for Corona and Applet. Accepted alignment flags are Qt::AlignLeft (default, for compatibility), Qt::AlignCenter and Qt::AlignRight. Additionally it tries to reverse alignment (if different than center) for RTL languages. Summary (updated) --- This patch aims to provide centered tool tips for Plasma (aligned to edge in some cases looks bad) and ability to set pop ups alignment (by default it uses left alignment for compatibility). Diffs (updated) - /trunk/KDE/kdelibs/plasma/applet.h 1028190 /trunk/KDE/kdelibs/plasma/applet.cpp 1028190 /trunk/KDE/kdelibs/plasma/corona.h 1028190 /trunk/KDE/kdelibs/plasma/corona.cpp 1028190 /trunk/KDE/kdelibs/plasma/tooltipmanager.cpp 1028190 Diff: http://reviewboard.kde.org/r/1428/diff Testing (updated) --- Tested for vertical and horizontal form factors and for floating applets. Thanks, Michal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
