D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  Things look bad when a bitmap icon appears in the tray... (e.g. Remmina) It 
seems `roundToIconSize` is necessary for bitmap icons.
  
  I think I am going to abandon this patch, as the necessary changes are simply 
too big:
  
  - all references to `marginHints` in the systemtray should be removed, and 
`spacing` used instead
  - `Units::roundToIconSize` has to be changed so it works on real pixels and 
not on density-independent pixels - now it breaks down on HiDPI screens
  
  I think no of these two changes are going to be accepted, unless someone 
knows why exactly these two things are implemented the current way.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  With this new version the tray icons scale exactly like the application icons 
on the left (the "jumps" between icon sizes happen at exactly the same time).

INLINE COMMENTS

> anthonyfieroni wrote in main.qml:42
> I see it has configuration for icon size ? What about to use it?

The goal of this patch is to make the size of the application icons on the left 
side of the panel match the size of the tray icons.
Additionally, the System Settings -> Icons -> Panel icon size adjustment will 
affect the tray icons too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27248.
pgkos added a comment.


  Cancel out the enlargement of AbstractItem by the tasksRow's marginHints.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27139&id=27248

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  It seems the problem is not with SVG icons, but with the systemtray code. If 
I make the systemtray's Flow's marginHints zero, the padding is preserved 
correctly! No magic constant is needed anymore:
  
//Do spacing with margins, to correctly compute the number of lines
property QtObject marginHints: QtObject {
property int left: Math.round(0)
property int top: Math.round(0)
property int right: Math.round(0)
property int bottom: Math.round(0)
}
  
  But I have no idea what this code was supposed to be doing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: anthonyfieroni, ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  There is something wrong and inconstent about SVG icon scaling. For example, 
if I put this line in systemtray ui main QML code instead:
  
  `property int itemSize: Math.min(width, height)`
  
  then the KDE Connect icon completely fills the height of the panel.
  
  Which is obviously wrong, because if we open 
/usr/share/plasma/desktoptheme/default/icons/kdeconnect.svgz in an SVG editor 
we see that the icon is drawn on a 32x32px canvas ("page") and it has 2px top 
and bottom padding inside the canvas.
  
  That padding disappears when the icon is drawn on the panel. That is wrong 
because if it was a 32x32px bitmap icon, the padding (transparent pixels) would 
be preserved.
  
  That is the reason why we need to force padding (0.85*height) in the tray, 
but not in the application shortcut icons - the tray icons are SVG icons, but 
the application shorcut icons are bitmaps.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  I have returned to the previous version, as the version which used 
units.smallSpacing looked awful.
  
  Yes, it uses magic constant 0.85, but it really looks much better. I have 
patched the digital clock height too, so it perfectly matches the height of the 
tray icons.
  
  I think that this constant should be placed inside the Units class. More, I 
also think this constant should be configurable by the user (for example, in 
the panel settings -> more settings...).
  
  This code has the benefit that it **does not change the appearance at the 
default panel height at all** compared to the version without this patch. I 
have tested this on both small HD screens and 4K HiDPI screens (with screen 
scaling factor == 2.0), using KDE Neon git unstable live USB stick.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27139.
pgkos added a comment.


  Fix the previous commit

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27138&id=27139

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27138.
pgkos added a comment.


  Return to previous version, which was better.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27114&id=27138

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27114.
pgkos added a comment.


  Use units.smallSpacing for padding instead of magic numbers.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27105&id=27114

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/icon/package/contents/ui/main.qml
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  I have tried and tested this diff without any padding, and trust me, it looks 
very bad - **I would rather have this patch not accepted** - than not to add 
any padding.
  
  Particularly, the tray icons look extremely bad when there is no padding - I 
suppose this is because the SVG icons are sized a little differently than 
pixmap icons.
  
  For example, the KDE Connect icon almost doesn't fit in the panel when it has 
no padding.
  
  I will try with units.smallSpacing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  I could argue that the numbers come from Material Design guidelines 
 - it 
recommends between 10% to 20% of padding around icons.
  
  But with your attitude it will be difficult to justify anything.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  So maybe you tell me where this comes from? 
https://cgit.kde.org/plasma-workspace.git/commit/applets/digital-clock/package/contents/ui/DigitalClock.qml?id=90ea27f49c84f0dffbbf79b29eaa14c57f31a24d

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  I have tested it with the panel in both horizontal and vertical orientations, 
and 0.85 looks optimal for me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27105.
pgkos added a comment.


  Squashed the commits

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27103&id=27105

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/icon/package/contents/ui/main.qml
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27103.
pgkos added a comment.


  Make the padding of all the panel icons the same

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27095&id=27103

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/icon/package/contents/ui/main.qml
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  This patch also enables the user to configure the tray icon's size limit 
using System Settings -> Icons -> Advanced -> Panel

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos added a comment.


  The 0.8 is used to create a small padding, so the icons never touch the 
panel's borders.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos updated this revision to Diff 27095.
pgkos added a comment.


  Fix tray icon scaling

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10487?vs=27089&id=27095

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos edited the test plan for this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

To: pgkos, #plasma_workspaces
Cc: ngraham, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10489: Fix the tray icon scaling

[Piotr Kosinski]

pgkos created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
pgkos requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  tray-icon-size-fix

REVISION DETAIL
  https://phabricator.kde.org/D10489

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: pgkos
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10487: Fix tray icon size scaling when changing the panel size (fix bug 360333)

[Piotr Kosinski]

pgkos created this revision.
pgkos added a reviewer: Plasma: Workspaces.
pgkos added a project: Plasma: Workspaces.
Restricted Application edited projects, added Plasma; removed Plasma: 
Workspaces.
Restricted Application added a subscriber: plasma-devel.
pgkos requested review of this revision.

REVISION SUMMARY
  This fixes the bug 360333  by 
making the tray icons scale exactly like the application icons on the left.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D10487

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: pgkos, #plasma_workspaces
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos added a comment.


  In my opinion, roundToIconSize should operate on scaled units - it is used 
multiple times in a few plasmoids - all calls from them to roundToIconSize 
assume it will operate on scaled units.
  
  The method, as it is now, is useless, because QML code has no access to 
KIconLoader sizes and devicePixelIconSize() method, so it cannot operate on 
unscaled units or convert them on the fly.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, 
plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos updated this revision to Diff 26878.
pgkos added a comment.


  This is a simpler implementation - the diff changes roundToIconSize so it 
uses scaled units.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7849?vs=19612&id=26878

REVISION DETAIL
  https://phabricator.kde.org/D7849

AFFECTED FILES
  src/declarativeimports/core/units.cpp

To: pgkos, #plasma
Cc: ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, 
plasma-devel, michaelh, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos added a comment.


  @anthonyfieroni my first version of the diff changed only the tray icon QML 
file, but I think that it is better to fix it in the plasma framework, as that 
function is used in multiple other places and there is the same problem with 
wrongly sized icons on hidpi screens.

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: anthonyfieroni, broulik, #frameworks, davidedmundson, plasma-devel, 
ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos added a comment.


  @broulik consider this case:
  
  The tray icons' size is defined by default in 
`org.kde.plasma.private.systemtray/contents/config/main.xml` to `smallMedium`, 
which means 22 pixels on a 96-dpi screen. On a 192-dpi screen, the icons' real 
size is 44 pixels.
  Now, in `org.kde.plasma.private.systemtray/contents/ui/main.qml` there is 
this line:
  
units.roundToIconSize(Math.min(Math.min(width, height), 
units.iconSizes[iconSizes[plasmoid.configuration.iconSize]]))
  
  The `height` property is the height of the panel (assuming the panel is 
horizontal). On my hidpi screen the default panel height is around 72 pixels 
(`32 px * 2`).
  
  So the above line evaluates to:
  `units.roundToIconSize(Math.min(72, units.iconSizes.smallMedium))`
  `units.roundToIconSize(Math.min(72, 44))`
  `units.roundToIconSize(44)`
  
  and that gets rounded to `medium` size, which is incorrect, because we want a 
`smallMedium` size multiplied by two (`32 px != 22 px * 2`).
  
  So, on a hidpi screen the `roundToIconSize` function returns a wrong size, 
and additionally it (wrongly) does not multiply the size by the icon dpi 
scaling factor (e.g. `2.0`).

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: broulik, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos updated this revision to Diff 19612.
pgkos added a comment.


  Fixed the previous diff.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7849?vs=19592&id=19612

REVISION DETAIL
  https://phabricator.kde.org/D7849

AFFECTED FILES
  src/declarativeimports/core/units.cpp
  src/declarativeimports/core/units.h

To: pgkos, #plasma
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos updated this revision to Diff 19592.
pgkos changed the repository for this revision from R120 Plasma Workspace to 
R242 Plasma Framework (Library).
pgkos added a comment.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.


  Edited the function `Units::roundToIconSize` so it both accepts and outputs a 
dpi-scaled pixel value.
  
  This might break some things, but on the other hand there are places (other 
than the system tray) which also have exactly the same problem with icon 
scaling on hidpi screens (see e.g. 
https://cgit.kde.org/plasma-desktop.git/tree/applets/taskmanager/package/contents/ui/Task.qml),
 this patch will also fix all these other cases.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7849?vs=19585&id=19592

REVISION DETAIL
  https://phabricator.kde.org/D7849

AFFECTED FILES
  src/declarativeimports/core/units.cpp

To: pgkos, #plasma
Cc: #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos added a reviewer: Plasma.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7849

To: pgkos, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

[Piotr Kosinski]

pgkos created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This patch fixes the problem with tray icon scaling on HiDPI screens - the 
icons are too small.
  
  The function `Units::roundToIconSize` returns an unscaled icon size, but we 
need a size scaled by the HiDPI factor (e.g. 2.0). Also, the arguments passed 
to this function must be in pixels (density-independent, for 96 dpi), but now 
they are multiplied by the HiDPI factor, so the function returns a wrong size.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7849

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: pgkos
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart