Re: Plasma 5.26.3: Breeze is broken

[Rik Mills]

On 08/11/2022 17:57, Fabian Vogt wrote:> Hi,
>
> Am Dienstag, 8. November 2022, 15:28:54 CET schrieb Jonathan Riddell:
>> Plasma 5.26.3 is now released 
https://kde.org/announcements/plasma/5/5.26.3

>
> At least breeze has the wrong version in its CMakeLists.txt:
>
> set(PROJECT_VERSION "5.26.2")
>
> This means that plasma-workspace will silently ignore Breeze and 
instead use

> Plastik as default window decoration.
>
> I did not check whether other repos/tarballs are affected.
>
> Thanks,
> Fabian
>
>
I see grep'ing through:

bluedevil/CMakeLists.txt:set(PROJECT_VERSION "5.26.2")
breeze/CMakeLists.txt:set(PROJECT_VERSION "5.26.2")
oxygen-sounds/CMakeLists.txt:set(PROJECT_VERSION "5.26.80")

the rest are 5.26.3

Re: Plasma 5.24.2

[Rik Mills]

On 22/02/2022 13:56, Jonathan Riddell wrote:
> Plasma 5.24.2 is now released
> https://kde.org/announcements/plasma/5/5.24.2
> 

Discover fails to build

/<>/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp:
In member function ‘void FlatpakBackend::addAppFromFlatpakRef(const
QUrl&, ResultsStream*)’:
/<>/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp:728:35:
error: cannot convert ‘const QString’ to ‘const QUrl&’
  728 | resource->setResourceLocation(refurl);
  |   ^~
  |   |
  |   const QString
In file included from
/<>/libdiscover/backends/FlatpakBackend/FlatpakBackend.h:11,
 from
/<>/libdiscover/backends/FlatpakBackend/FlatpakBackend.cpp:8:
/<>/libdiscover/backends/FlatpakBackend/FlatpakResource.h:154:42:
note:   initializing argument 1 of ‘void
FlatpakResource::setResourceLocation(const QUrl&)’
  154 | void setResourceLocation(const QUrl )
  |  ^~~~
[ 68%] Linking CXX executable ../../../../bin/flatpaktest
cd
/<>/obj-arm-linux-gnueabihf/libdiscover/backends/FlatpakBackend/tests
&& /usr/bin/cmake -E cmake_link_script
CMakeFiles/flatpaktest.dir/link.txt --verbose=1
/usr/bin/c++ -g -O2 -ffile-prefix-map=/<>=.
-fstack-protector-strong -Wformat -Werror=format-security -Wdate-time
-D_FORTIFY_SOURCE=2 -fno-operator-names -fno-exceptions -Wall -Wextra
-Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long
-Wpointer-arith -Wundef -Wnon-virtual-dtor -Woverloaded-virtual
-Werror=return-type -Werror=init-self -Wvla -Wdate-time
-Wsuggest-override -Wlogical-op -Wl,--enable-new-dtags
-Wl,-Bsymbolic-functions -Wl,-z,relro -Wl,-z,now
CMakeFiles/flatpaktest.dir/flatpaktest_autogen/mocs_compilation.cpp.o
CMakeFiles/flatpaktest.dir/FlatpakTest.cpp.o -o
../../../../bin/flatpaktest
-Wl,-rpath,/<>/obj-arm-linux-gnueabihf/bin
../../../../bin/libDiscoverCommon.so
/usr/lib/arm-linux-gnueabihf/libQt5Qml.so.5.15.2
/usr/lib/arm-linux-gnueabihf/libKF5ItemModels.so.5.91.0
/usr/lib/arm-linux-gnueabihf/libQt5Network.so.5.15.2
/usr/lib/arm-linux-gnueabihf/libKF5I18n.so.5.91.0
/usr/lib/arm-linux-gnueabihf/libQt5Gui.so.5.15.2
/usr/lib/arm-linux-gnueabihf/libQt5Test.so.5.15.2
/usr/lib/arm-linux-gnueabihf/libQt5Core.so.5.15.2
make[3]: ***
[libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/build.make:114:
libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/FlatpakBackend.cpp.o]
Error 1
make[3]: Leaving directory '/<>/obj-arm-linux-gnueabihf'
make[2]: *** [CMakeFiles/Makefile2:1718:
libdiscover/backends/FlatpakBackend/CMakeFiles/flatpak-backend.dir/all]
Error 2
make[2]: *** Waiting for unfinished jobs

Re: Next Plasma LTS?

[Rik Mills]

On 10/01/2022 11:28, Marco Martin wrote:
> as said in the meeting notes, there is a request from Opensuse and Kubuntu to 
> do a new Plasma LTS release.
> Optimal for them would be 5.24, but a potential problem is that is a quite 
> feature heavy release, so it may be too buggy for an lts.
> 
> Opinions? ideas? do we go with 5.24? 5.25? or not lts anymore until the last 
> kf5 based relase? (which may be too far ahead in the future)

I should also note that UbuntuStudio 22.04 LTS will be shipping Plasma
5.24 as their DE, so if that is not a LTS they will be in the same
dilemma as Kubuntu

Thanks

Re: Next Plasma LTS?

[Rik Mills]

On 10/01/2022 11:28, Marco Martin wrote:
> Optimal for them would be 5.24, but a potential problem is that is a quite 
> feature heavy release, so it may be too buggy for an lts.

Not so much optimal, but the only possible option that would work for
22.04 LTS

Re: 5.24 as LTS

[Rik Mills]

On 22/12/2021 19:28, Jonathan Riddell wrote:
> We've had a late request for 5.24 to be an LTS.
> 
> We had previously said the final Plasma 5 release would be the one
> before Plasma 6, but there's no immediate sign of a Plasma 6. 
> 
> What do devs think of making 5.24 an LTS?
> 
> Jonathan


FYI, It was already stated in IRC and the 5.24 kickoff meeting, that
Kubuntu would very much like this to be a LTS release. I am not sure who
the 'late' request was from, but our preference is not newly expressed
and still stands.

Thanks.

Rik

Re: Using C++20 in Plasma

[Rik Mills]

On 06/08/2021 12:06, Nicolas Fella wrote:
> Hi,
> 
> I would like to explore whether it would be feasible from a distribution
> POV to use C++20 in Plasma (and other non-Frameworks projects).
> 
> In practical terms this would mean something like requiring gcc 10 or
> clang 10 (the exact version that supports a given standard is hard to
> define precisely, but these versions seem to have a reasonable coverage).
> 
> Is there any distro planning to ship future Plasma releases that does
> not have gcc 10 or clang 10?
> 
> Cheers
> 
> Nico
> 

No problem with this from K/Ubuntu

Re: Plasma discover updates page blank (5.20.3, with frameworks 5.74 and Qt 5.15.1`)

[Rik Mills]

Thanks for that.

On 13/11/2020 14:11, Nate Graham wrote:
> As far as I can tell, what happened here is that Kirigami.Icon changed
> in 5.75: https://invent.kde.org/frameworks/kirigami/-/merge_requests/111
> 
> implicitWidth/height used to be read-only properties, but that MR
> changed them to read-write. Technically this is an API break, but now
> that it's been released, if we revert it we'll break all the places
> where we ported uses of Kirigami.Icon to set implicitWidth/height. :(
> 
> Now that it's done, I'm not sure what we can do about it. :(
> 
> The fact that I haven't seen any bug reports about this tells me that
> distros shipping 5.20 are generally exceeding the minimum Frameworks
> version already, which is masking the issue.

Yes, I only have 5.74 now because 5.75 was blocked by 1st the K/Ubuntu
release freezes for 20.10, and then Qt 5.15 landing once 21.04
development opened. Resulting in skipping 5.75 and going straight to
5.76 when it comes out tomorrow.

Fortunately, this is only in the Kubuntu dev release, so not as bad as
could have been.

> On 11/13/20 6:48 AM, Rik Mills wrote:
>> Plasma discover updates page is blank when updates exist:
>>
>> Version 5.20.3, with frameworks 5.74 and Qt 5.15.1
>>
>> Discover updates page: https://i.imgur.com/8LpPCEW.png
>> Error on clicking to navigate to that page:
>> https://i.imgur.com/jVTCCdy.png
>>
>> It has been suggested that official required kirigami 5.74 is not
>> actually new enough?
>>
>> Regards,
>>
>> Rik
>>

Re: Plasma discover updates page blank (5.20.3, with frameworks 5.74 and Qt 5.15.1`)

[Rik Mills]

Thanks for that.

On 13/11/2020 14:11, Nate Graham wrote:
> As far as I can tell, what happened here is that Kirigami.Icon changed
> in 5.75: https://invent.kde.org/frameworks/kirigami/-/merge_requests/111
> 
> implicitWidth/height used to be read-only properties, but that MR
> changed them to read-write. Technically this is an API break, but now
> that it's been released, if we revert it we'll break all the places
> where we ported uses of Kirigami.Icon to set implicitWidth/height. :(
> 
> Now that it's done, I'm not sure what we can do about it. :(
> 
> The fact that I haven't seen any bug reports about this tells me that
> distros shipping 5.20 are generally exceeding the minimum Frameworks
> version already, which is masking the issue.

Yes, I only have 5.74 now because 5.75 was blocked by 1st the K/Ubuntu
release freezes for 20.10, and then Qt 5.15 landing once 21.04
development opened. Resulting in skipping 5.75 and going straight to
5.76 when it comes out tomorrow.

Fortunately, this is only in the Kubuntu dev release, so not as bad as
could have been.

> On 11/13/20 6:48 AM, Rik Mills wrote:
>> Plasma discover updates page is blank when updates exist:
>>
>> Version 5.20.3, with frameworks 5.74 and Qt 5.15.1
>>
>> Discover updates page: https://i.imgur.com/8LpPCEW.png
>> Error on clicking to navigate to that page:
>> https://i.imgur.com/jVTCCdy.png
>>
>> It has been suggested that official required kirigami 5.74 is not
>> actually new enough?
>>
>> Regards,
>>
>> Rik
>>

Plasma discover updates page blank (5.20.3, with frameworks 5.74 and Qt 5.15.1`)

[Rik Mills]

Plasma discover updates page is blank when updates exist:

Version 5.20.3, with frameworks 5.74 and Qt 5.15.1

Discover updates page: https://i.imgur.com/8LpPCEW.png
Error on clicking to navigate to that page: https://i.imgur.com/jVTCCdy.png

It has been suggested that official required kirigami 5.74 is not
actually new enough?

Regards,

Rik

Re: Unannounced new dependency in plasma-desktop

[Rik Mills]

On 08/08/2020 12:22, Dan Leinir Turthra Jensen wrote:
> On Friday, 7 August 2020 22:55:20 BST Ben Cooksley wrote:
>> Hi Plasma Developers,
>>
>> It appears that in the past 24 hours you have introduced new
>> dependencies in the plasma-desktop repository without announcing them
>> 2 weeks in advance beforehand.
>>
>> This can be seen in the CI system failures at
>> https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/
>>
>> Could we please get an explanation as to why this was not requested in
>> advance as is supposed to happen?
>>
>> Thanks,
>> Ben
> 
>   This one is on me, i guess? The reason for this is that this new dependency 
> was on a framework rather than an external dependency, and i was led to 
> believe that adding such a dependency to the repo metadata would be 
> sufficient.
> 

kaccounts (build dep) is part of the release service (formally KDE
Applications), not a framework.

libaccounts-qt (build dep) and signon-plugin-oauth2 (runtime) are not
frameworks, or a KDE project.

There is also no information in cmake as to minimum required versions of
these.

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Rik Mills]

rikmills added a comment.


  Is this to land in 5.19?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: rikmills, mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

Re: repo freeze tomorrow

[Rik Mills]

On 30/04/2020 18:33, Aleix Pol wrote:
> Yes, in practice.

In practice? What other way is there? Now I check some more they seem
very non-optional.

Re: repo freeze tomorrow

[Rik Mills]

On 29/04/2020 22:04, David Edmundson wrote:
> We have something announced that I'm not sure is on the list.
> 
> Plasma will gain a new repo called kwayland-server.
> This is a split of half the code currently in framework.
> 
> Aleix has things prepared, but we haven't done all the steps to making
> it part of Plasma.
> 
> David
> 

So this is 2 new repos for 5.19? plasma-wayland-protocols and
kwayland-server

Re: Plasma 5.18 LTS

[Rik Mills]

On 29/04/2020 17:22, Jonathan Riddell wrote:
> Plasma 5.18 is due to have its .5 release shortly and then we'll move
> onto Plasma 5.19 releases.  Plasma 5.18 is an LTS so its translations
> will get put into the LTS branch and it'll move to 6 monthly releases
> until we decide on another LTS.
> 
> I've added releases for next year to
> https://community.kde.org/Schedules/Plasma_5#Future_releases
> 5.18.6LTS Bugfix  Tue 2020-09-29
> 
> 5.18.7LTS Bugfix  Tue 2021-03-30

So abandoning the Fibonacci release sequence at a much earlier point
compared to 5.12?

In that case it would be handy if the Plasma team could keep LTS distros
up to date with important fixes that will not end up in a new tar for
many months, and may be wanted to be cherry-picked? Perhaps record them
in some wiki/task/doc somewhere.

Rik

D28710: Make accidental panel and panel widget deletion more difficult

[Rik Mills]

rikmills added a comment.


  In D28710#647340 , @davidedmundson 
wrote:
  
  > We shouldn't be making UX changes on the stable branch
  
  
  I agree. This could make getting the 5.18.5 release accepted as a K/Ubuntu 
stable release update (SRU) in a few weeks time.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28710

To: ngraham, #vdg, #plasma, ndavis
Cc: davidedmundson, rikmills, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Rik Mills]

rikmills added a comment.


  In D27595#636640 , @vkrause wrote:
  
  > I haven't seen a backtrace for this, but from what I understood from the 
chat backlog this is triggering a QML bug (?) due to the re-evaluation of 
qsTr() with 5.12, rather than actually crashing in the code of this patch?
  
  
  Did not have time to last night, but I will file a bug with both backtraces 
shortly. For now I have reverted the commit in Kubuntu, as a crashing KCM is 
the greater evil, but a better solution would be great. :)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause, mart
Cc: davidedmundson, broulik, rikmills, ngraham, apol, plasma-devel, 
fbampaloukas, GB_2, domson, dkardarakos, ahiemstra, mart

D28360: cmake: make xsettingsd check an option

[Rik Mills]

rikmills added a comment.


  In D28360#636615 , @eszlari wrote:
  
  > https://packages.ubuntu.com/focal/kde-config-gtk-style
  >  
https://src.fedoraproject.org/rpms/kde-gtk-config/blob/master/f/kde-gtk-config.spec
  >  
https://gitweb.gentoo.org/repo/gentoo.git/tree/kde-plasma/kde-gtk-config/kde-gtk-config-5.18.3.ebuild
  
  
  
  
  In D28360#636617 , @kossebau wrote:
  
  > Okay, that is quite a few. Though, I wonder why they missed it. The current 
addition to RUNTIME dependency was only added post 5.18, right? And no-one told 
the  packagers explicitly otherwise by the usual ways (like in release 
announcement). They do read the cmake log though, and usually ask for that 
listing as RUNTIME dependency.
  
  
  To be specific, this has been added as a runtime check in the 5.18 branch 
AFTER release of the 5.18.3 tars, so it would only be someone who is doing 
stable git builds (CI or otherwise) who would have had build logs flag this up.
  
  As far as K/Ubuntu is concerned, this has also been added at a point what we 
are well past feature freeze for 20.04. Adding a runtime depends/recommends 
that draws a new package into the default install AND on the ISO needs a 
feature freeze exception application to be made, and since this is not just 
that but a persistent runtime daemon, that is doubly so.
  
  Given that this is ENTIRELY optional, and designed to fix a 'problem' that I 
honestly cannot recall any users raising (at all, or) as a significant problem, 
then I certainly won't be looking at it until after the 20.04 beta next week, 
as there are many more important things to deal with for now.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28360

To: eszlari, gikari
Cc: rikmills, kossebau, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27595: Watch for language change events, and forward those to the QML engine

[Rik Mills]

rikmills added a comment.


  git bisect also shows that this crashes the virtual desktop and regional 
settings KCM in Kubuntu 20.04

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27595

To: vkrause, mart
Cc: rikmills, ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, ahiemstra, davidedmundson, mart

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

[Rik Mills]

rikmills added a comment.


  In D27077#604505 , @broulik wrote:
  
  > Having Kickoff confirm shutdown could be superfluous as you already had to 
go through the trouble of opening it, going to "Leave", but for e.g. the lock 
logout entry or generic " Leave" in the desktop context menu I'd still want a 
confirmation.
  
  
  Also the lock/logout applet if someone has added it to a panel. One 
accidental click can invoke the leave/timeout screen.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: rikmills, broulik, cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D27045: [wallpapers] Use more high-quality JPEGs for Next

[Rik Mills]

rikmills added a comment.


  I don't object to bumping the size for this release.
  
  However, I do wonder if it might be worth thinking about future 
guidelines/rules regarding wallpaper maximum sizes after optimisation.

REPOSITORY
  R31 Breeze

BRANCH
  more-hq-next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27045

To: filipf, #plasma, #vdg, ngraham
Cc: The-Feren-OS-Dev, rikmills, raveomelette, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D21226: search for a default wallpaper in lookandfeel

[Rik Mills]

rikmills added a comment.


  Would this handle the case where an existing look-and-feel package that did 
NOT specify a wallpaper, then in a new version adds one? And that occurs on a 
users system the l-n-f package was already active and plasma is long past 1st 
plasma start.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D21226

To: mart, #plasma, davidedmundson
Cc: rikmills, kossebau, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26847: Hide irrevelevant default button, code clean and future proofing

[Rik Mills]

rikmills added a comment.


  Fails to build:
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_user-manager_bin_amd64/99/console
  
  00:42:51 /workspace/build/src/usermanager.cpp: In constructor 
‘UserManager::UserManager(QWidget*, const QVariantList&)’:
  00:42:51 /workspace/build/src/usermanager.cpp:68:70: error: no matching 
function for call to ‘UserManager::connect(AccountInfo*&, void 
(AccountInfo::*)(bool), UserManager*, )’
  00:42:51  connect(m_widget, ::changed, this, 
::changed);
  00:42:51  
 ^

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D26847

To: meven, ngraham, #plasma
Cc: rikmills, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26275: SourcesPage: Override contentItem of ListSectionHeader instead of relying on data property

[Rik Mills]

rikmills added a comment.


  This does NOT fix BUG: 415666. The distro native sources button is still 
missing.
  
  Git master with this change:
  
  F7850103: 230501812c.png 
  
  Correctly showing sources button before commit 
https://cgit.kde.org/discover.git/commit/?id=89088f7639a63c0c099ccb9c95393f12d83c17b5
  
  F7850101: 5e38cc3bf6.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  sources_actiontoolbar

REVISION DETAIL
  https://phabricator.kde.org/D26275

To: ahiemstra, #plasma, #discover_software_store, apol, ngraham
Cc: rikmills, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors

[Rik Mills]

rikmills added a comment.


  add_compile_definitions requires cmake 3.13, so breaks build in Neon where 
cmake from Bionic is 3.10

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D8626

To: dvogel, broulik, davidedmundson
Cc: rikmills, ngraham, asturmlechner, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 5.12.9 LTS

[Rik Mills]

On 10/09/2019 17:21, Jonathan Riddell wrote:
> Plasma 5.12.9 LTS
> is now released https://www.kde.org/announcements/plasma-5.12.9.php

Kwin to fails to build with Qt 5.9.

Plasma 5.12 should build with 5.9.

 /effects/screenshot/screenshot.cpp:110:15: error: ‘const class QImage’
has no member named ‘sizeInBytes’

but from qt.io

qsizetype QImage::sizeInBytes() const
Returns the image data size in bytes.
This function was introduced in Qt 5.10.

Commit introducing that is 67444e36592e78d46b757a6c72be1d50bdae19e6
[effects/screenshot] Upload data to xpixmap in chunks

Re: Plasma 2020 release schedules

[Rik Mills]

On 23/07/2019 16:53, Jonathan Riddell wrote:

> https://community.kde.org/Schedules/Plasma_5

Has someone made changes to how table formatting is done there, or on
the wiki as a whole? That lack of table lines and borked alignment looks
dreadful.

> Distros, please say if you would like any of these to be considered
for LTS.

5.18 as an LTS would be ideal for Kubuntu, and really would be the only
thing that would work for 20.04 LTS.

D22238: Fix creation of kdeglobals if /etc/xdg/kdeglobals present

[Rik Mills]

rikmills added a comment.


  So if XDG_CONFIG_DIRS contains additional locations, this will not work?
  
  e.g. in Kubuntu we set up: 
XDG_CONFIG_DIRS="$XDG_CONFIG_DIRS:/usr/share/kubuntu-default-settings/kf5-settings"

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D22238

To: fvogt, #plasma
Cc: rikmills, kwin, plasma-devel, LeGast00n, sbergeron, jraleigh, fbampaloukas, 
GB_2, mkulinski, ragreen, jackyalcine, Pitel, iodelay, crozbo, bwowk, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart

D21593: [showdesktop] Reduce the maximum panel icon size

[Rik Mills]

rikmills added a comment.


  This also needs to be applied to the minimizeall widget, as this is the 
directly (right click) selectable alternative to showdesktop widget, so the 
icon size change would revert if a user switched the panel widget to this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21593

To: ndavis, #vdg, #plasma
Cc: rikmills, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Rik Mills]

rikmills added a comment.


  > ! In D19631#467167 , @filipf 
wrote:
  > 
  > Why does it look different than Neon?
  
  Seems neon have a settings tweak to force more font Noto (especially for 
sddm).
  
  Cherry picking that...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19631: [sddm-theme/lock screen] Overhaul font sizes

[Rik Mills]

rikmills added a comment.


  Not looking good.
  
  F6835091: c0924558f6.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19631

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: rikmills, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19821: Fix breeze dialog background with Qt 5.12.2

[Rik Mills]

rikmills added a comment.


  I guess it is very likely, but all the same for the record I will request 
that this results in a 5.56.2 release of plasma-framework.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19821

To: fvogt, #plasma, rooty
Cc: acooligan, filipf, heikobecker, falqueto, rooty, Zren, arojas, rikmills, 
asturmlechner, kde-frameworks-devel, plasma-devel, michaelh, ngraham, bruns

D19465: Port to ECM's component/imported target based FindXCB

[Rik Mills]

rikmills added a comment.


  Results in cmake configure build failure on Neon
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_plasma-desktop_bin_amd64/292/consoleFull

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19465

To: vkrause, apol
Cc: rikmills, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18287: Remove hardcoded /usr/share paths in install

[Rik Mills]

rikmills added a comment.


  Build fails now on Kubuntu Cosim and Disco builds.
  
  
https://launchpadlibrarian.net/406558385/buildlog_ubuntu-disco-amd64.breeze-gtk_5.14.80+p19.04+git20190117.0641-0_BUILDING.txt.gz
  
  > make[3]: Leaving directory 
'/<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/obj-x86_64-linux-gnu'
  >  make -f kconf_update/CMakeFiles/gtkbreeze5.5.dir/build.make 
kconf_update/CMakeFiles/gtkbreeze5.5.dir/build
  >  [ 25%] Generating ../Breeze-Dark/gtk-2.0/gtkrc, 
../Breeze-Dark/gtk-3.18/gtk.css, ../Breeze-Dark/gtk-3.20/gtk.css
  >  make[3]: Entering directory 
'/<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/obj-x86_64-linux-gnu'
  >  cd /<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/src && 
./build_theme.sh -c BreezeDark -t 
/<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/obj-x86_64-linux-gnu/Breeze-Dark
 -r 
  >  [ 50%] Generating ../Breeze/gtk-2.0/gtkrc, ../Breeze/gtk-3.18/gtk.css, 
../Breeze/gtk-3.20/gtk.css, ../Breeze/gtk-3.18/gtk-dark.css, 
../Breeze/gtk-3.20/gtk-dark.css
  >  cd /<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/src && 
./build_theme.sh -c Breeze -t 
/<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/obj-x86_64-linux-gnu/Breeze
 -r 
  >  ./build_theme.sh: 88: shift: can't shift that many
  >  make[3]: *** [src/CMakeFiles/Breeze.dir/build.make:140: 
Breeze/gtk-2.0/gtkrc] Error 2
  >  make[3]: Leaving directory 
'/<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/obj-x86_64-linux-gnu'
  >  make[2]: *** [CMakeFiles/Makefile2:151: src/CMakeFiles/Breeze.dir/all] 
Error 2
  >  make[2]: *** Waiting for unfinished jobs
  >  ./build_theme.sh: 88: shift: can't shift that many
  >  make[3]: *** [src/CMakeFiles/Breeze-Dark.dir/build.make:138: 
Breeze-Dark/gtk-2.0/gtkrc] Error 2
  >  make[3]: Leaving directory 
'/<>/breeze-gtk-5.14.80+p19.04+git20190117.0641/obj-x86_64-linux-gnu'
  >  make[2]: *** [CMakeFiles/Makefile2:188: 
src/CMakeFiles/Breeze-Dark.dir/all] Error 2

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18287

To: davidedmundson, #plasma, zzag
Cc: rikmills, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18244: Check for python-cairo

[Rik Mills]

rikmills added a comment.


  This breaks Neon builds, whereas previously the builds were working as I 
explicitly had added python3-cairo to the build depends. It is there still, but 
cmake thinks not.
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull
  
  > 02:43:04 -- The following REQUIRED packages have not been found:
  >  02:43:04 
  >  02:43:04  * PythonCairo
  >  02:43:04Required to render assets

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D18244

To: davidedmundson, #plasma, ngraham, cgiboudeaux, zzag
Cc: rikmills, ngraham, zzag, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18005: Include only the largest size for each wallpaper

[Rik Mills]

rikmills added a comment.


  In D18005#387324 , @ngraham wrote:
  
  > However, just removing files from the repo doesn't actually remove them 
from users' machines; their packaging system does that. Perhaps we should alert 
packagers that for the 5.15 release, they shouldn't remove these files from 
users' machines when they disappear from the repo.
  
  
  Leaving orphaned files on disk isn't really acceptable.
  
  Instead Plasma should perhaps recognise that the image has gone, and seek and 
apply whatever singe larger size now exists.

REPOSITORY
  R131 Plasma Wallpapers

BRANCH
  keep-only-largest-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18005

To: ngraham, #vdg, #plasma, ndavis
Cc: rikmills, filipf, davidedmundson, cfeck, ndavis, plasma-devel, kvanton, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17359: Fix use of QRegularExpressionMatch

[Rik Mills]

rikmills added a comment.


  I have someone on IRC asking
  
  > [12:46]  Now got an issue.. Using the Plasma Vault the GUI complains 
about wrong versions of CryFS and alternatively wrong version of EncFS. I 
checked with 'apt show cryfs' and 'apt show encfs' and the installed versions 
are _newer_ than the one that Plasma Vaults is expecting. What to do / Can I 
proceed?
  
  Is this the issue this fix is intended for>

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D17359

To: fvogt, #plasma, ivan
Cc: rikmills, plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17375: Don't automatically refresh if the user already asked apt to do so

[Rik Mills]

rikmills added a comment.


  In D17375#373278 , @ngraham wrote:
  
  > That's what I thought. Then it doesn't fully fix 401810, since people not 
using Kubuntu or Neon will still not have a way to change the update frequency.
  
  
  I don't think this was intended to be a full fix for that in a distro 
agnostic sense, though it is relevant so posted on that bug. This is specific 
to apt updates where currently if a x0periodic config files exists the (a) 
notifier and apt config prompted refreshes will at a minimum double the 
frequency, and (b) even worse the apt-config setting in days was being 
misconstrued by the notifier as **hours**, resulting in even more frequent 
refreshes. That is what I pointed out and discussed with Aleix a few days ago, 
which prompted this revision.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17375: Don't automatically refresh if the user already asked apt to do so

[Rik Mills]

rikmills added a comment.


  In D17375#373049 , @ngraham wrote:
  
  > This helps for Kubuntu (and Neon ?) users, but what about everyone else?
  
  
  As the original code and this change is apt specific, for non apt distro the 
updater will continue as before to refresh via packagekit 5 mins after system 
startup, and then afterwards once every 24 hrs.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17375: Don't automatically refresh if the user already asked apt to do so

[Rik Mills]

rikmills added a comment.


  Seems good to me, and a quick test on a stock Kubuntu install gets the 
updater registering new updates when the system does its own refresh.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D17375

To: apol, #kubuntu, sitter, rikmills
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

5.15 New Features notepad

[Rik Mills]

On 19/10/2018 13:37, Rik Mills wrote:
> notes.kde.org refuses to allow log in

Seems to have rectified itself. :)

Re: 5.15 New Features notepad

[Rik Mills]

On 19/10/2018 11:18, Jonathan Riddell wrote:
> As discussed at the meeting starting the 5.15 new features notepad
> early, please add things as you merge them in
> https://notes.kde.org/p/plasma_5_15
> 
> Jonathan
> 

notes.kde.org refuses to allow log in

[ksysguard] [Bug 399637] libksysguard fails to build without QtWebEngine

[Rik Mills]

https://bugs.kde.org/show_bug.cgi?id=399637

--- Comment #1 from Rik Mills  ---
For the record, seeing the same failure on Neon and Kubuntu CI builds of master
branch.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[ksysguard] [Bug 399637] libksysguard fails to build without QtWebEngine

[Rik Mills]

https://bugs.kde.org/show_bug.cgi?id=399637

Rik Mills  changed:

   What|Removed |Added

 Status|REPORTED|CONFIRMED
 Ever confirmed|0   |1

-- 
You are receiving this mail because:
You are the assignee for the bug.

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Rik Mills]

rikmills added a comment.


  In D16031#339149 , @ngraham wrote:
  
  > It's a bit frustrating to spend a lot of time in the phab task (T9658 
) getting consensus on a design, implement 
it, and then hear, "no, no, major elements of this design needs to be 
rethought." I understand that sometimes implementation reveals issues that were 
unforeseen during the original discussion, but let's keep the discussion in 
T9658  or else it will be very hard to 
follow scattered in two places.
  
  
  To be fair, the new screenshots showing how this adversely affects appearance 
with a range of backgrounds which are not darkish default Plasma wallpapers are 
only shown in this review, so naturally I think people would comment here. Not 
saying that is right, but it would help if the new examples are mirrored there 
for comment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma
Cc: rikmills, filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15942: Don't drag windows in empty areas from touch/pen events

[Rik Mills]

rikmills added a comment.


  Fails to build on Neon and Kubuntu CI
  
  https://build.neon.kde.org/job/bionic_unstable_kde_breeze/71/
  
  01:20:12 [ 94%] Building CXX object 
kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o
  01:20:12 kstyle/CMakeFiles/breeze.dir/build.make:982: recipe for target 
'kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o' failed
  01:20:12 make[5]: Leaving directory '/workspace/build/build-qt4'
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp: In member function 
‘bool Breeze::WindowManager::mousePressEvent(QObject*, QEvent*)’:
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:448:25: error: 
‘class QMouseEvent’ has no member named ‘source’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:448:41: error: 
‘MouseEventNotSynthesized’ is not a member of ‘Qt’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~~~
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp: In member function 
‘bool Breeze::WindowManager::mouseMoveEvent(QObject*, QEvent*)’:
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:514:25: error: 
‘class QMouseEvent’ has no member named ‘source’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~
  01:20:12 /workspace/build/kstyle/breezewindowmanager.cpp:514:41: error: 
‘MouseEventNotSynthesized’ is not a member of ‘Qt’
  01:20:12  if (mouseEvent->source() != Qt::MouseEventNotSynthesized)
  01:20:12  ^~~~
  01:20:12 make[5]: *** 
[kstyle/CMakeFiles/breeze.dir/breezewindowmanager.cpp.o] Error 1
  01:20:12 make[5]: *** Waiting for unfinished jobs

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D15942

To: davidedmundson, #plasma, broulik, ngraham
Cc: rikmills, ngraham, abalaji, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15717: Fix spelling errors

[Rik Mills]

rikmills added a comment.


  In D15717#330808 , @ngraham wrote:
  
  > Landed on master, so the change will show up in KDE Plasma 5.15. See 
https://community.kde.org/Schedules/Plasma_5 for more information.
  
  
  Why not in 5.14 which also has these errors?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D15717

To: borispek, ngraham
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14869: [RFC] Increase default font sizes by 1 pt

[Rik Mills]

rikmills added a comment.


  In D14869#311997 , @rooty wrote:
  
  > P.S. wasn't this problem settled already in T7864 
?
  
  
  No, that's a task on Kubuntu workboard about changing our distro specific 
defaults.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: mart, oysteins, rooty, filipf, safaalfulaij, rikmills, harmathy, rkflx, 
abetts, davidedmundson, rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D14869: [RFC] Increase default font sizes by 1 pt

[Rik Mills]

rikmills added a comment.


  In D14869#309949 , @rkflx wrote:
  
  > I fear this will make it better for some people and worse for others, 
creating nothing but churn. Did you test this with several of said displays?
  
  
  I would agree with that to a large extent. The current defaults while not 
being ideal for everyone, are in my opinion at a reasonable middle ground 
already. Increasing even by this 1pt starts to skew this too far one way.
  
  In D14869#309949 , @rkflx wrote:
  
  > 5. Are there many bug reports of users complaining about too small fonts in 
Plasma? If so, could you add links?
  
  
  I can't comment on bug reports, but as far as I can think with user feedback 
on Kubuntu, the default fon't size has not been an issue of concern on any 
serious level.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: safaalfulaij, rikmills, harmathy, rkflx, abetts, davidedmundson, 
rizzitello, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D14869: [RFC] Increase default font sizes by 1 pt

[Rik Mills]

rikmills added a comment.


  Increasing the default font size was suggested for Kubuntu in T7864 

  
  I have the same concerns/objections as I did then.
  
  As has been mentioned  this scales other UI elements like kicker. Having also 
tested at the time with a fairly typical 1600x900 laptop display, it looked 
quite awful. A bit like it was designed for use by a short sighted toddler. Not 
every KDE user has a nice large res or hidpi display. In fact usage of FOSS OS 
often seems to be wider for lower end spec machines and displays.
  
  If this change goes ahead, I may have to give serious though to overriding 
new default in our Kubuntu settings package, but that brings issues of 
diverging from what will then be tried and tested defaults (I hope) which is 
additional testing burden on a small team.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14869

To: ngraham, #plasma, #kde_applications, valorie, #vdg
Cc: rikmills, harmathy, rkflx, abetts, davidedmundson, rizzitello, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D11198: [libbreezecommon] Add box shadow helper

[Rik Mills]

rikmills added a comment.


  In D11198#292783 , @zzag wrote:
  
  > @rikmills Should build now.
  
  
  @zzag It does. Thank you

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: rikmills, ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13734: Make GConf optional dependency

[Rik Mills]

rikmills added a comment.


  Somehow, in some way, the changes to **src/CMakeLists.txt** are in 5.13 
branch, but are missing in master branch.
  
  So 5.13 builds ok without gconf, but current master fails to build.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D13734

To: drosca, #plasma, davidedmundson
Cc: rikmills, plasma-devel, asturmlechner, apol, matthiasdahl, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D11198: [libbreezecommon] Add box shadow helper

[Rik Mills]

rikmills added a comment.


  Fails to build from source:
  
  
https://build.neon.kde.org/job/bionic_unstable_kde_breeze_bin_armhf/44/consoleFull
  
  06:47:17 CMakeFiles/Makefile2:118: recipe for target 
'libbreezecommon/CMakeFiles/breezecommon4.dir/all' failed
  06:47:17 /workspace/build/libbreezecommon/breezeboxshadowhelper.cpp: In 
function ‘void Breeze::BoxShadowHelper::blurAlphaNaive(QImage&, int)’:
  06:47:17 /workspace/build/libbreezecommon/breezeboxshadowhelper.cpp:138:56: 
error: conversion from ‘QVector’ to non-scalar type ‘const 
QVector’ requested
  06:47:17  const QVector kernel = computeGaussianKernel(radius);
  06:47:17~^~~~
  06:47:17 In file included from /usr/include/qt4/QtGui/qpolygon.h:45:0,
  06:47:17  from /usr/include/qt4/QtGui/qmatrix.h:45,
  06:47:17  from /usr/include/qt4/QtGui/qtransform.h:44,
  06:47:17  from /usr/include/qt4/QtGui/qimage.h:45,
  06:47:17  from /usr/include/qt4/QtGui/qpixmap.h:50,
  06:47:17  from /usr/include/qt4/QtGui/qpainter.h:49,
  06:47:17  from /usr/include/qt4/QtGui/QPainter:1,
  06:47:17  from 
/workspace/build/libbreezecommon/breezeboxshadowhelper.h:27,
  06:47:17  from 
/workspace/build/libbreezecommon/breezeboxshadowhelper.cpp:21:
  06:47:17 /usr/include/qt4/QtCore/qvector.h: In instantiation of ‘int 
QVector::sizeOfTypedData() [with T = double]’:
  06:47:17 /usr/include/qt4/QtCore/qvector.h:503:49:   required from ‘void 
QVector::realloc(int, int) [with T = double]’
  06:47:17 /usr/include/qt4/QtCore/qvector.h:340:32:   required from ‘void 
QVector::reserve(int) [with T = double]’
  06:47:17 /workspace/build/libbreezecommon/breezeboxshadowhelper.cpp:62:30:   
required from here
  06:47:17 /usr/include/qt4/QtCore/qvector.h:323:49: warning: cast from 
‘QVector*’ to ‘const Data* {aka const QVectorTypedData*}’ 
increases required alignment of target type [-Wcast-align]
  06:47:17  return reinterpret_cast(&(reinterpret_cast(this))->array[1]) - reinterpret_cast(this);
  06:47:17 
~^
  06:47:17 make[5]: 
[libbreezecommon/CMakeFiles/breezecommon4.dir/breezeboxshadowhelper.cpp.o] 
Error 1
  06:47:17 make[4]:  [libbreezecommon/CMakeFiles/breezecommon4.dir/all] Error 2

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11198

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: rikmills, ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D13602: Fix tooltip woes

[Rik Mills]

rikmills added a comment.


  I have tested the modified patch on the same environment with Qt 5.10.1 where 
I found the crash with the previous version in 5.13.0 tars.
  
  plasmashell now seems to start without issue on login

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D13602

To: hein, broulik, davidedmundson, romangg
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13357: Use logging categories in a few dataengines

[Rik Mills]

rikmills added a comment.


  @davidedmundson Seems so. Thank you.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13357

To: davidedmundson, #plasma, mart
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13357: Use logging categories in a few dataengines

[Rik Mills]

rikmills added a comment.


  Build errors with this:
  
  
https://build.kde.org/job/Plasma%20plasma-workspace%20kf5-qt5%20SUSEQt5.10/44/console
  
  https://build.neon.kde.org/job/bionic_unstable_kde_plasma-workspace/102/
  
  https://kci.pangea.pub/job/cosmic_unstable_plasma-workspace/
  
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:76: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:76: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 
CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o:
 In function `StatusNotifierItemEngine::registerWatcher(QString const&)':
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:118: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:118: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 
CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o:
 In function `StatusNotifierItemEngine::unregisterWatcher(QString const&)':
  13:46:35 /home/jenkins/workspace/Plasma plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:126: 
undefined reference to `DATAENGINE_SNI()'
  13:46:35 
CMakeFiles/plasma_engine_statusnotifieritem.dir/statusnotifieritem_engine.cpp.o:/home/jenkins/workspace/Plasma
 plasma-workspace kf5-qt5 
SUSEQt5.10/dataengines/statusnotifieritem/statusnotifieritem_engine.cpp:126: 
more undefined references to `DATAENGINE_SNI()' follow
  13:46:35 collect2: error: ld returned 1 exit status

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D13357

To: davidedmundson, #plasma, mart
Cc: rikmills, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: bugfix in frameworks vital for 5.13

[Rik Mills]

On 14/05/18 19:16, Marco Martin wrote:
> Hi all,
> about https://bugs.kde.org/show_bug.cgi?id=394134 which makes many new kcms 
> look borked, the problem actually wasn't the upstream qt bug (which is an 
> issue as well)
> but another one which was actually in qqc2-desktop-style
> now, since released frameworks is the one that 5.13 has to depend, how to 
> proceed, respin the tarball?
> 
> the commit that's needed is 
> https://commits.kde.org/qqc2-desktop-style/
> 8790d850c4343b9f615457f0926cc3cdcef8d0c7
> 

5.46.1 tar for that source sounds sensible to me.

D10563: Place toolbox in the top right corner of the screen

[Rik Mills]

rikmills added a comment.


  In D10563#209359 , @davidedmundson 
wrote:
  
  > > what "the toolbox' own xml file is ignored
  >
  > What xml file? If it's not used, delete it.
  
  
  containments/desktop/package/contents/config/main.xml
  
  It certainly was NOT ignored for me and Kubuntu users since Plasma 5.9, in a 
default setup at least.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D10563

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, cfeck, rikmills, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10429: Disable the title bar separator by default

[Rik Mills]

rikmills added a comment.


  +1 for turning off by default or removing altogether.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D10429

To: fvogt, #vdg, #plasma, ngraham
Cc: rikmills, anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9792: even slimmer scrollbars

[Rik Mills]

rikmills added a comment.


  In https://phabricator.kde.org/D9792#193697, @hpereiradacosta wrote:
  
  > In https://phabricator.kde.org/D9792#193473, @rikmills wrote:
  >
  > > In Neon and Kubuntu CI with Qt 5.9.3
  > >
  > > 
https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console
  > >
  > > 17:55:15 /workspace/build/kstyle/breezestyle.cpp: In member function 
‘virtual bool Breeze::Style::drawScrollBarSliderControl(const QStyleOption*, 
QPainter*, const QWidget*) const’:
  > >  17:55:15 /workspace/build/kstyle/breezestyle.cpp:5013:136: error: ‘const 
class QStyleOption’ has no member named ‘styleObject’
  > >  17:55:15  const bool widgetMouseOver( widget ? 
_animations->scrollBarEngine().isHovered( widget, QStyle::SC_ScrollBarGroove )  
: option->styleObject->property("hover").toBool());
  > >  17:55:15 
^
  > >  17:55:15 kstyle/CMakeFiles/breeze.dir/build.make:910: recipe for target 
'kstyle/CMakeFiles/breeze.dir/breezestyle.cpp.o' failed
  >
  >
  > Thanks for reporting.
  >  Looking at the log in more detail, this is in fact the qt4/kde4 built of 
breeze that fails.
  >  And indeed styleObject is not defined for qt4.
  
  
  Ah, I forgot that our builds were still making the Qt4 style. Also explains 
why the main KDE CI build did not fail!
  
  Thanks

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: rikmills, davidedmundson, ngraham, colomar, abetts, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein

D9792: even slimmer scrollbars

[Rik Mills]

rikmills added a comment.


  In Neon and Kubuntu CI with Qt 5.9.3
  
  
https://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/186/console
  
  17:55:15 /workspace/build/kstyle/breezestyle.cpp: In member function ‘virtual 
bool Breeze::Style::drawScrollBarSliderControl(const QStyleOption*, QPainter*, 
const QWidget*) const’:
  17:55:15 /workspace/build/kstyle/breezestyle.cpp:5013:136: error: ‘const 
class QStyleOption’ has no member named ‘styleObject’
  17:55:15  const bool widgetMouseOver( widget ? 
_animations->scrollBarEngine().isHovered( widget, QStyle::SC_ScrollBarGroove )  
: option->styleObject->property("hover").toBool());
  17:55:15  
   ^
  17:55:15 kstyle/CMakeFiles/breeze.dir/build.make:910: recipe for target 
'kstyle/CMakeFiles/breeze.dir/breezestyle.cpp.o' failed

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D9792

To: mart, #plasma, #kirigami, #vdg, hpereiradacosta, abetts
Cc: rikmills, davidedmundson, ngraham, colomar, abetts, plasma-devel, ZrenBot, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart, hein

Kwin build failure

[Rik Mills]

This morning on stable 5.11 branch in both Neon and Kubuntu CI

Thank you

https://build.neon.kde.org/job/xenial_stable_plasma_kwin_bin_amd64/241/console

08:06:59
/workspace/build/autotests/integration/decoration_input_test.cpp: In
member function ‘void
KWin::DecorationInputTest::testModifierClickUnrestrictedMove_data()’:
08:06:59
/workspace/build/autotests/integration/decoration_input_test.cpp:584:10:
error: ‘XdgShellV6’ is not a member of ‘KWin::Test::ShellSurfaceType’
08:06:59  {Test::ShellSurfaceType::XdgShellV6,
QByteArrayLiteral("XdgShellV6")},
08:06:59   ^
08:06:59
/workspace/build/autotests/integration/decoration_input_test.cpp:585:5:
error: no matching function for call to
‘QVector
>::QVector()’

D8443: Revert "Make the kde-gtk-config kcm better at checking global gtk settings"

[Rik Mills]

rikmills added a comment.


  I made the same revert to test earlier this morning, and on **brief** testing 
it seems to have solved the issue, and tests still pass.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D8443

To: fvogt, #plasma, apol
Cc: rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D8178: Fix editing items in SimpleFavoritesModel

[Rik Mills]

rikmills added a comment.


  Built with the above patch, and on quick testing it seems to resolve the 
issue for me. I am not a user of activities, so my testing there to make sure 
existing behaviour on the standard favourites was still the same, may not be as 
thorough as desirable.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D8178

To: fvogt, #plasma
Cc: rikmills, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7891: expose the colorset for the stylesheet

[Rik Mills]

rikmills added a comment.


  Since this change, polkit-kde-agent-1 fails to build from source with the 
error:
  
  >   In file included from /usr/include/KF5/KIconThemes/KIconLoader:1:0,
  >   from 
/<>/polkit-kde-agent-1-5.10.95+p17.10+git20170929.1419/AuthDialog.cpp:37:
  >   /usr/include/KF5/KIconThemes/kiconloader.h:31:10: fatal error: 
kcolorscheme.h: No such file or directory
  >   #include 
  >   ^~~~
  >   compilation terminated.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D7891

To: mart, #frameworks, #plasma, hein, dfaure
Cc: rikmills, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7257: Set the QtQuick Controls 1 style name explicitly

[Rik Mills]

rikmills added a comment.


  I don't think it has an effect here, but for completeness just in case, I 
should mention that both Neon and KDE have a patch to #startkde/startkde.cmake
  
  
https://packaging.neon.kde.org/plasma/plasma-workspace.git/tree/debian/patches/kubuntu_startkde-qtpath.diff?h=Neon/unstable
  
  though I could be mistaken, so would not like to leave that fact out of the 
discussion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7257

To: fvogt, #plasma, mart
Cc: rikmills, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7257: Set the QtQuick Controls 1 style name explicitly

[Rik Mills]

rikmills added a comment.


  In https://phabricator.kde.org/D7257#136069, @fvogt wrote:
  
  > Does it work with `export QT_QUICK_CONTROLS_1_STYLE=Breeze`?
  >
  > I don't know how the style selection of Quick Controls work, maybe someone 
more knowledgeable in that area could chime in here.
  
  
  Yes, that seems to work ok.
  
  Again, reverting to '=Desktop' results in the issue reoccurring.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7257

To: fvogt, #plasma, mart
Cc: rikmills, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7257: Set the QtQuick Controls 1 style name explicitly

[Rik Mills]

rikmills added a comment.


  I am seeing this in both Neon dev-unstable edition (Xenial base), and 
Kubuntu's CI packages (Artful base). Another user is also seeing it in the 
Kubuntu CI builds.
  
  In both I have created a new user and tested under that, which should 
eliminate any caching issues. The result is the same and the issue persists.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7257

To: fvogt, #plasma, mart
Cc: rikmills, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7257: Set the QtQuick Controls 1 style name explicitly

[Rik Mills]

rikmills added a comment.


  Is this a result of this change?
  
  F3863427: d0cb251738.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7257

To: fvogt, #plasma, mart
Cc: rikmills, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

Re: Notice of significant adjustment to KWin

[Rik Mills]

Fair enough. I will not poke at that further then.

On 09/06/17 21:20, Ben Cooksley wrote:
>From my understanding invasive changes were committed without review,
> which were similar to changes which had been previously been rejected
> in review.
>
> Regards,
> Ben

I look forward to good progress being restored. :)

Re: Notice of significant adjustment to KWin

[Rik Mills]

Cannot view T6301 (I have a -dev account now), so I am in the dark on
the reasons/reasoning for this?

Can you elaborate please?

On 09/06/17 21:10, Ben Cooksley wrote:
> Hi all,
> 
> At the request of the KWin maintainer the KWin repository master
> branch has been forcibly rewound to c5861b99 (per T6301)
> 
> A log of the changes which have been thrown away is attached.
> 
> Developers may need to reinstate these changes (assuming they have
> been properly reviewed) to ensure no fixes are lost.
> 
> Apologies for the inconvenience.
> 
> Regards,
> Ben Cooksley
> KDE Sysadmin
> 

D5910: make shadows work on wayland

[Rik Mills]

rikmills added a comment.


  > ! In https://phabricator.kde.org/D5910#114781, @hpereiradacosta wrote:
  >  Working on fixing it. 
  >  Just a couple of ifdef missing.
  
  The fix you just pushed seems to have done the trick. Thank you.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: rikmills, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5910: make shadows work on wayland

[Rik Mills]

rikmills added a comment.


  This breaks builds on Neon and Kubuntu CI (Qt 5.7.1)
  
  
http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console
  
  05:10:59 In file included from 
/workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0,
  05:10:59  from 
/workspace/build/build-qt4/kstyle/breeze_automoc.cpp:33:
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:24: 
error: ‘KWayland’ was not declared in this scope
  05:10:59  QMap _widgetSurfaces;
  05:10:59 ^
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:51: 
error: template argument 2 is invalid
  05:10:59  QMap _widgetSurfaces;

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: rikmills, anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5889: Keep QIcon::fromTheme in main thread

[Rik Mills]

rikmills added a comment.


  This breaks build on Neon and Kubuntu CI with Qt 5.7.1
  
  
http://build.neon.kde.org/job/xenial_unstable_plasma_breeze_bin_amd64/120/console
  
  05:10:59 In file included from 
/workspace/build/build-qt4/kstyle/moc_breezeshadowhelper.cpp:9:0,
  05:10:59  from 
/workspace/build/build-qt4/kstyle/breeze_automoc.cpp:33:
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:24: 
error: ‘KWayland’ was not declared in this scope
  05:10:59  QMap _widgetSurfaces;
  05:10:59 ^
  05:10:59 
/workspace/build/build-qt4/kstyle/../../kstyle/breezeshadowhelper.h:162:51: 
error: template argument 2 is invalid
  05:10:59  QMap _widgetSurfaces;

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D5889

To: davidedmundson, #plasma, graesslin
Cc: rikmills, graesslin, plasma-devel, #frameworks, ZrenBot, spstarr, 
progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5114: support for high dpi in aurorae

[Rik Mills]

rikmills added a comment.


  In https://phabricator.kde.org/D5114#113943, @luebking wrote:
  
  > Just saw this because of a bug report.
  
  
  This one I presume: https://bugs.kde.org/show_bug.cgi?id=380524
  
  The bug affects me on 5.10 (I am comment #1)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5114

To: mart, #plasma, graesslin
Cc: rikmills, luebking, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, 
lukas

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

This revision was automatically updated to reflect the committed changes.
Closed by commit R98:6ac39e82ff06: Set no stepper button for GTK3 scrollbars on 
gtk >=3.20 (authored by rikmills).

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D5128?vs=12678=14441

REVISION DETAIL
  https://phabricator.kde.org/D5128

AFFECTED FILES
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/gtk-3.20/gtk.css

To: rikmills, #plasma, davidedmundson
Cc: davidedmundson, elvisangelaccio, plasma-devel, ZrenBot, spstarr, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

rikmills added a comment.


  Checked appearance on 'fixed' Firefox 55 nightly. No apparent regressions 
with those upstream changes and this change as far as I can see.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

To: rikmills, #plasma
Cc: elvisangelaccio, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

rikmills added a comment.


  In https://phabricator.kde.org/D5128#98591, @elvisangelaccio wrote:
  
  > It seems the upstream firefox bug has been fixed, can you update to commit 
message?
  >  Anyway +1 for removing the stepper buttons, currently there is an annoying 
difference between breeze and breeze-gtk3 scrollbars.
  
  
  Done, I think.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

To: rikmills, #plasma
Cc: elvisangelaccio, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

rikmills edited the summary of this revision.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

To: rikmills, #plasma
Cc: elvisangelaccio, plasma-devel, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

rikmills added a comment.


  I note that in recent Breeze, the native scrollbar are a fair amount thinner, 
so maybe a reduction in width here by 2 px may look/match better?
  
  e.g.
  
  F3154031: a87f589636.png 

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

To: rikmills, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

Re: Plasma 5.9.4

[Rik Mills]

Re-spun *before* the announcement email @ 14:53 UTC if I recall from IRC.

If you grabbed the tarballs beforehand, then yes you may the have ones
prior to the respin?

On 23/03/17 07:16, Tobias C. Berner wrote:
> Hi
> 
> it seems the tarballs were respun after the announcement. Could you in
> the future, please give a little notice of that?
> 
> 
> mfg Tobias
> 
> On 21 March 2017 at 15:53, Jonathan Riddell  > wrote:
> 
> Out now
> https://www.kde.org/announcements/plasma-5.9.4.php
> 
> 
> 

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

rikmills added a reviewer: Plasma.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

To: rikmills, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D5128: Set no stepper button for GTK3 scrollbars on gtk >=3.20

[Rik Mills]

rikmills created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  This is a workaround to mitigate broken (huge wide) scrollbars in 
mozilla/Gecko  based applications for GTK3 >= 3.20 in versions 52 onwards.
  
  Saying that, I think it now brings those GTK3 scrollbars closer to the Breeze 
Qt scrollbars in latest releases.
  
  Ref:  https://bugs.kde.org/show_bug.cgi?id=377008 and 
https://bugzilla.mozilla.org/show_bug.cgi?id=1343802
  
  I noticed this as I run ubuntu zesty and use Firefox beta/dev editions, but 
it does now affect the released v52 onwards.
  
  before:
  
  F3093537: 96cd277e4f.png 
  
  after
  
  F3093579: 29bd31aa11.png 

TEST PLAN
  I have tested this locally for myself, and staged a patched build for kubuntu 
here:
  
  
https://launchpad.net/~kubuntu-ppa/+archive/ubuntu/staging-plasma/+packages?field.name_filter=breeze-gtk_filter=published_filter=zesty
  
  Tested in a few non-gecko GTK3 based apps to see the result:
  
  e.g. in Nautilus
  
  F3093664: 35645d067d.png 
  
  Maybe the bordering around the scrollbar trough could be better? Not sure, 
and my GTK/CSS fu is probably not up to much more than trial and error from 
here onwards.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D5128

AFFECTED FILES
  Breeze-dark-gtk/gtk-3.20/gtk.css
  Breeze-gtk/gtk-3.20/gtk.css

To: rikmills
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol

D4956: [Folder View] Lower toolbox when an item is hovered

[Rik Mills]

rikmills added a comment.


  > In https://phabricator.kde.org/D4956#93270, @broulik wrote:
  >  In any way it is an improvement over the status quo.
  
  No doubt. Just annoying I can't replicate your result.
  
  > It might indeed be beneficial if we place the tool box at the top right 
corner by default.
  
  Well.. I personally am in favour of that change, unless there is 
particular/reason or objection.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4956

To: broulik, #plasma, #vdg, hein, mart
Cc: rikmills, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4956: [Folder View] Lower toolbox when an item is hovered

[Rik Mills]

rikmills added a comment.


  In https://phabricator.kde.org/D4956#93275, @broulik wrote:
  
  > Are you running plasma-desktop master? There have been many improvements in 
highlight handling as well as the icon grid layout itself.
  
  
  Just updated and re-applied the patch to make sure.
  
  i.e. http://build.neon.kde.org/job/xenial_unstable_plasma_plasma-desktop/280/
  
  (which was tip of master until you pushed some changes 30 mins ago)
  
  with the patch applied on top.
  
  Tested with a new user once the patch was applied to FolderView.qml
  
  F2753814: 34dbd70c5a.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4956

To: broulik, #plasma, #vdg, hein, mart
Cc: rikmills, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4956: [Folder View] Lower toolbox when an item is hovered

[Rik Mills]

rikmills added a comment.


  No, not throwing my mouse cursor at it at all.
  
  Starting at:
  
  F2753737: c691ba2eef.png 
  
  then very very very slowly edging towards the toolbox, it triggers about here:
  
  F2753741: 80fd4c7b7a.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4956

To: broulik, #plasma, #vdg, hein, mart
Cc: rikmills, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D4956: [Folder View] Lower toolbox when an item is hovered

[Rik Mills]

rikmills added a comment.


  Applying this:
  
  This seems to work ok when as shown in the video,  you have a panel moved to 
the top of the screen and the pager not moved, so it is partially underneath 
that panel, shifting the relative location of the icon.
  
  However, it does not seem to work at all with the default plasma setup for a 
new user of the panel at the bottom, toolbox square in shape and top left, and 
the Home and Wastebin icons in their default place.
  
  You are still unable to hover the mouse and move it to click the selection 
and folder preview markers. The toolbox raises or activates and blocks you.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4956

To: broulik, #plasma, #vdg, hein, mart
Cc: rikmills, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

Re: plasma-integration/5.9 fails on build.kde.org

[Rik Mills]

Reported that issue as:

https://bugs.kde.org/show_bug.cgi?id=375290

On 19/01/17 10:00, Rik Mills wrote:
> On 18/01/17 17:05, David Edmundson wrote:
>> I'm on it.
>>
>> David
> 
> 
> Master branch in kubuntu CI now fails with
> 
> /<>/plasma-integration-5.8.5+p17.04+git20170119.0940/src/platformtheme/kdeplatformsystemtrayicon.cpp
> CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o:
> In function `KdePlatformTheme::createPlatformMenuBar() const':
> ./obj-x86_64-linux-gnu/autotests/./src/platformtheme/kdeplatformtheme.cpp:333:
> undefined reference to `QDBusMenuBar::windowChanged(QWindow*, QWindow*)'
> collect2: error: ld returned 1 exit status
> autotests/CMakeFiles/kdeplatformtheme_unittest.dir/build.make:385:
> recipe for target 'autotests/kdeplatformtheme_unittest' failed
> make[4]: *** [autotests/kdeplatformtheme_unittest] Error 1
> make[4]: Leaving directory
> '/<>/plasma-integration-5.8.5+p17.04+git20170119.0940/obj-x86_64-linux-gnu'
> CMakeFiles/Makefile2:427: recipe for target
> 'autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all' failed
> make[3]: *** [autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all]
> Error 2
> make[3]: *** Waiting for unfinished jobs
> 

Re: plasma-integration/5.9 fails on build.kde.org

[Rik Mills]

On 18/01/17 17:05, David Edmundson wrote:
> I'm on it.
> 
> David


Master branch in kubuntu CI now fails with

/<>/plasma-integration-5.8.5+p17.04+git20170119.0940/src/platformtheme/kdeplatformsystemtrayicon.cpp
CMakeFiles/kdeplatformtheme_unittest.dir/__/src/platformtheme/kdeplatformtheme.cpp.o:
In function `KdePlatformTheme::createPlatformMenuBar() const':
./obj-x86_64-linux-gnu/autotests/./src/platformtheme/kdeplatformtheme.cpp:333:
undefined reference to `QDBusMenuBar::windowChanged(QWindow*, QWindow*)'
collect2: error: ld returned 1 exit status
autotests/CMakeFiles/kdeplatformtheme_unittest.dir/build.make:385:
recipe for target 'autotests/kdeplatformtheme_unittest' failed
make[4]: *** [autotests/kdeplatformtheme_unittest] Error 1
make[4]: Leaving directory
'/<>/plasma-integration-5.8.5+p17.04+git20170119.0940/obj-x86_64-linux-gnu'
CMakeFiles/Makefile2:427: recipe for target
'autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all' failed
make[3]: *** [autotests/CMakeFiles/kdeplatformtheme_unittest.dir/all]
Error 2
make[3]: *** Waiting for unfinished jobs

Re: Review Request 129707: Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg

[Rik Mills]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129707/
---

(Updated Dec. 26, 2016, 11:09 p.m.)


Status
--

This change has been discarded.


Review request for Plasma and Andreas Kainz.


Repository: breeze-icons


Description
---

Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg, where 
symlinking was removed by commit 
https://cgit.kde.org/breeze-icons.git/commit/?id=36e2af0fc5d9e617c0a691e55f679e14dd22d08a

Currently the duplicates cause the dupetest to fail


Diffs
-

  icons-dark/applets/48/weather-fog.svg 470e866 
  icons-dark/applets/48/weather-fog.svg PRE-CREATION 
  icons-dark/applets/48/weather-overcast.svg 0126794 
  icons-dark/applets/48/weather-overcast.svg PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129707/diff/


Testing
---

Modified source built locally in pbuilder chroot with kubuntu CI package 
sources.

Re-symlinked icons result in dupetest passing and successful build.


Thanks,

Rik Mills

Review Request 129707: Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg

[Rik Mills]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129707/
---

Review request for Plasma and Andreas Kainz.


Repository: breeze-icons


Description
---

Re-symlink duplicate icons weather-fog.svg and weather-overcast.svg, where 
symlinking was removed by commit 
https://cgit.kde.org/breeze-icons.git/commit/?id=36e2af0fc5d9e617c0a691e55f679e14dd22d08a

Currently the duplicates cause the dupetest to fail


Diffs
-

  icons-dark/applets/48/weather-fog.svg 470e866 
  icons-dark/applets/48/weather-fog.svg PRE-CREATION 
  icons-dark/applets/48/weather-overcast.svg 0126794 
  icons-dark/applets/48/weather-overcast.svg PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129707/diff/


Testing
---

Modified source built locally in pbuilder chroot with kubuntu CI package 
sources.

Re-symlinked icons result in dupetest passing and successful build.


Thanks,

Rik Mills

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

[Rik Mills via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=341762

Rik Mills <rik.mill...@gmail.com> changed:

   What|Removed |Added

 CC||rik.mill...@gmail.com

--- Comment #12 from Rik Mills <rik.mill...@gmail.com> ---
I also cannot replicate this at all:

Plasma 5.7.2, and later 5.7.5
Qt 5.6.1
Ubuntu 16.10 (Yakkety)

-- 
You are receiving this mail because:
You are the assignee for the bug.