Re: Proposed fix for issue 330115
On Tue, Feb 4, 2014 at 5:26 PM, R.Harish Navnit harishnav...@gmail.comwrote: On Mon, Feb 3, 2014 at 11:34 PM, sujith h sujit...@gmail.com wrote: Do you have problem launching plasma-mediacenter? No problems launching plasma-mediacenter on my laptop . However , I don't have internet access in my laptop at all times . Yesterday I had it for about 20mins or so and I was able to build and run it within that time ;) . I'll try working whenever I get time , but I might not be able to do any work for the next week or so :( No problem. Happy hacking :) Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposed fix for issue 330115
On Mon, Feb 3, 2014 at 10:34 PM, R.Harish Navnit harishnav...@gmail.comwrote: Hello everyone , I've successfully built plasma-mediacenter in my newly installed kubuntu 13.10 on my laptop . However , the problems with the virtualbox still persist (The virtualbox also has kubuntu 13.10) . Do you have problem launching plasma-mediacenter? Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com On Mon, Feb 3, 2014 at 8:48 PM, R.Harish Navnit harishnav...@gmail.comwrote: On Thu, Jan 30, 2014 at 11:44 AM, sujith h sujit...@gmail.com wrote: Hi Harish, Try this only if you are *not* having trouble with downloading the gz files mentioned by Shantanu. I was able to download the packages manually but I don't know how to handle them . Where do I extract it to ? Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposed fix for issue 330115
Hi Harish, One more hack you can do is by following the thread : http://askubuntu.com/questions/37753/how-can-i-get-apt-to-use-a-mirror-close-to-me-or-choose-a-faster-mirror. So what I want to convey you is try changing the mirror. And lets see how that will help you. Note: Please take a backup of your orignal sources.list file. Try this only if you are *not* having trouble with downloading the gz files mentioned by Shantanu. On Wed, Jan 29, 2014 at 9:39 PM, Shantanu Tushar Jha shaan...@gmail.comwrote: did you try apt-get update few more times? If yes, It could be that files above a size are blocked? Try downloading them manually and see if you get an error or something, the URLs which failed for you are- http://in.archive.ubuntu.com/ubuntu/dists/saucy/universe/binary-amd64/Packages.gz http://in.archive.ubuntu.com/ubuntu/dists/saucy/main/binary-i386/Packages.gz On Wed, Jan 29, 2014 at 9:27 PM, R.Harish Navnit harishnav...@gmail.comwrote: On Wed, Jan 29, 2014 at 8:34 PM, Shantanu Tushar Jha shaan...@gmail.comwrote: The problem is here- W: Failed to fetch gzip:/var/lib/apt/lists/partial/in.archive.ubuntu.com_ubuntu_dists_saucy_universe_binary-amd64_Packages Hash Sum mismatch W: Failed to fetch gzip:/var/lib/apt/lists/partial/in.archive.ubuntu.com_ubuntu_dists_saucy_main_binary-i386_Packages Hash Sum mismatch Which basically means something went wrong when downloading these files. Try sudo apt-get update few more times till this is fixed. If it still doesnt go away, try a different network connection. Failure to download these is causing the problems installing the packages. It could be because our college's internet service has a lot of restrictions . It does have a lot of sites blocked. But I don't know if packages would have been blocked . I always get such errors and we usually neglect them . Looks like I'll have to look for another network connection . This is getting really tedious now :P Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposed fix for issue 330115
On Tue, Jan 28, 2014 at 5:54 PM, R.Harish Navnit harishnav...@gmail.comwrote: On Tue, Jan 28, 2014 at 5:45 PM, Sinny Kumari ksi...@gmail.com wrote: Your local git is messed up. So, I will suggest simple things to you for retrieving changes related to fixing issue. 1. Rename your local branch with some other name(e.g plasma-mediacenter.old). 2. Do a fresh git clone of PMC repo by running git clone git:// anongit.kde.org/plasma-mediacenter 3. Since, all changes relevant to work is in plasma-mediacenter.old/mediaelements/mediawelcome/HomeScreenFooter.qml, replace plasma-medicenter/mediaelements/mediawelcome/HomeScreenFooter.qml with plasma-medicenter.old/mediaelements/mediawelcome/HomeScreenFooter.qml. 4. After testing it, do git diff in your plasma-mediacenter and upload diff on http://reviewboard.kde.org/ I hope this will solve all your issues :) For the moment , I've left that clone(on Ubuntu 12.04 LTS) as it is and ran a fresh clone on kubuntu 13.10 and now facing troubles installing the qt-mobility. Can you help me with this ? Wouldn't installing packages mentioned in http://www.sinny.in/node/25 help you? Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposed fix for issue 330115
On Tue, Jan 28, 2014 at 6:45 PM, R.Harish Navnit harishnav...@gmail.comwrote: R.Harish Navnit The Enigma http://harishnavnit.wordpress.com On Tue, Jan 28, 2014 at 6:23 PM, sujith h sujit...@gmail.com wrote: Wouldn't installing packages mentioned in http://www.sinny.in/node/25help you? That's what I'm trying to do . I was able to install the required packages in Ubuntu 12.04 LTS. But when I try the same in Kubuntu 13.10 I get the following error log : http://pastebin.kde.org/png3htvj9 Oh man that sounds bit strange to me :) Even I have 13.10 installed in my laptop and build PMC. It works perfectly fine with packages mentioned in Sinny's blog. Can you share the output of 'dpkg -L' and more over what does your sources.list file have. Kindly share it. Let's see how to help you. Thanks, Sujith H Regards. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposed fix for issue 330115
On Tue, Jan 28, 2014 at 7:08 PM, Shantanu Tushar Jha shant...@kde.orgwrote: I don't know why you are trying to install qt-mobility at all. It is not listed under Ubuntu (12.10 and higher versions) on http://www.sinny.in/node/25. By the way is your build failing because of unavailability of package qt-mobility*? On Tue, Jan 28, 2014 at 6:45 PM, R.Harish Navnit harishnav...@gmail.comwrote: R.Harish Navnit The Enigma http://harishnavnit.wordpress.com On Tue, Jan 28, 2014 at 6:23 PM, sujith h sujit...@gmail.com wrote: Wouldn't installing packages mentioned in http://www.sinny.in/node/25help you? That's what I'm trying to do . I was able to install the required packages in Ubuntu 12.04 LTS. But when I try the same in Kubuntu 13.10 I get the following error log : http://pastebin.kde.org/png3htvj9 Regards. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Proposed fix for issue 330115
On Tue, Jan 28, 2014 at 8:05 PM, R.Harish Navnit harishnav...@gmail.comwrote: On Tue, Jan 28, 2014 at 7:13 PM, sujith h sujit...@gmail.com wrote: On Tue, Jan 28, 2014 at 7:08 PM, Shantanu Tushar Jha shant...@kde.orgwrote: I don't know why you are trying to install qt-mobility at all. It is not listed under Ubuntu (12.10 and higher versions) on http://www.sinny.in/node/25. Well , I was following this link : http://community.kde.org/Plasma/Plasma_Media_Center/getting_started_with_PMC. Also since I had to install it during my previous build made me think that this package would also be required. By the way is your build failing because of unavailability of package qt-mobility*? Well , I didn't try building because I wasn't able to install the package qt-mobility , so I assumed that the build would fail anyway. I'll try building and let you know . I am using 13.10. And believe me you don't have to install qt-mobility*. Just follow what sinny had beautifully documented and then enjoy PMC :) Regards. R.Harish Navnit The Enigma http://harishnavnit.wordpress.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Regression from commit 5fdf522c
Hi All, Extremely sorry for the inconvenience caused by me. I didn't tested with Open with feautre with PMC. Thanks Shantanu that you pointed it out. This also gives us a lesson to test PMC with the test cases we haven't followed. Thanks, Sujith H On Wed, Dec 18, 2013 at 12:32 AM, Shantanu Tushar Jha shant...@kde.orgwrote: Hi folks, I just noticed that commit 5fdf522chttps://projects.kde.org/projects/extragear/multimedia/plasma-mediacenter/repository/revisions/5fdf522c413869d98135494cb2e379d4bf639dedbreaks Open With .. feature with PMC. The media get added to Default playlist while PMC switches to another playlist and plays that. I tried to fix this by creating a new playlist for command line media but our current design makes it very complicated to switch playlists from code on demand. Because the release is in 2 days, I will revert the commit, live without that extra convenience. We can properly implement playlist switching in 1.3 so that this can be re-added. Also, lets take this as a lesson to avoid the temptation of adding such small conveniences after a beta release. Thanks! -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Media Center release delayed
Hi, So the scrollbar will now move automatically and highlight song which is being played. So that work is done. Thanks, Sujith H On Wed, Feb 13, 2013 at 1:29 AM, Sinny Kumari ksi...@gmail.com wrote: Thanks Sujith for your great work :) Looking forward to see more people working on Plasma Media Center. Thanks On Wed, Feb 13, 2013 at 12:24 AM, sujith h sujit...@gmail.com wrote: Hi, I am working on the scroll bar part of Plasma Media Center. The intention is to highlight the playlist songs and move the scroll bar to the position where the song is played. Thanks, Sujith H On Wed, Feb 13, 2013 at 12:13 AM, Shantanu Tushar Jha shaan...@gmail.com wrote: [cross posting to plasma-devel and active] Hi all, Today was supposed to be the first release of Plasma Media Center after we went into a feature freeze during December last year. We made lot of bugfixes and usability improvements during most of the last few months and its really coming out well. However, there are still few critical usability issues that need to be addressed before we can go live. Apart from the ones reported on bugs.kde.org, we currently miss a 100% perfect keyboard navigation. We had plans of addressing these, but most of the PMC team has been and will be busy for next two weeks (on the Indian side, its two[1] successive[2] KDE events coming up which is keeping us busy). So two things here- ** I propose we delay the release to 12th March 2013 which should give us enough time to address these issues, ** It will be nice if more people can volunteer to polish and help fixing the bugs at [3]. WE WANT YOU! Also, Fabian can you help with this and squash some bugs? [1] http://www.gnunify.in/2013/schedule/15th [2] http://www.gdgdaiict.com/kdemeetup/ [3] https://bugs.kde.org/buglist.cgi?list_id=505105query_format=advancedbug_status=UNCONFIRMEDbug_status=CONFIRMEDbug_status=ASSIGNEDbug_status=REOPENEDshort_desc_type=allwordssubstrproduct=plasma-mediacenter Regrets and thanks for understanding, -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Active mailing list act...@kde.org https://mail.kde.org/mailman/listinfo/active -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Active mailing list act...@kde.org https://mail.kde.org/mailman/listinfo/active -- http://www.sinny.in -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasma Media Center release delayed
Hi, I am working on the scroll bar part of Plasma Media Center. The intention is to highlight the playlist songs and move the scroll bar to the position where the song is played. Thanks, Sujith H On Wed, Feb 13, 2013 at 12:13 AM, Shantanu Tushar Jha shaan...@gmail.comwrote: [cross posting to plasma-devel and active] Hi all, Today was supposed to be the first release of Plasma Media Center after we went into a feature freeze during December last year. We made lot of bugfixes and usability improvements during most of the last few months and its really coming out well. However, there are still few critical usability issues that need to be addressed before we can go live. Apart from the ones reported on bugs.kde.org, we currently miss a 100% perfect keyboard navigation. We had plans of addressing these, but most of the PMC team has been and will be busy for next two weeks (on the Indian side, its two[1] successive[2] KDE events coming up which is keeping us busy). So two things here- ** I propose we delay the release to 12th March 2013 which should give us enough time to address these issues, ** It will be nice if more people can volunteer to polish and help fixing the bugs at [3]. WE WANT YOU! Also, Fabian can you help with this and squash some bugs? [1] http://www.gnunify.in/2013/schedule/15th [2] http://www.gdgdaiict.com/kdemeetup/ [3] https://bugs.kde.org/buglist.cgi?list_id=505105query_format=advancedbug_status=UNCONFIRMEDbug_status=CONFIRMEDbug_status=ASSIGNEDbug_status=REOPENEDshort_desc_type=allwordssubstrproduct=plasma-mediacenter Regrets and thanks for understanding, -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com ___ Active mailing list act...@kde.org https://mail.kde.org/mailman/listinfo/active -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: folderview broken
On Wed, Dec 21, 2011 at 10:46 AM, Zé mmode...@gmail.com wrote: 2011/12/21 Shantanu Tushar jhahon...@gmail.com: On Tuesday 20 Dec 2011 9:06:59 PM Zé wrote: 2011/12/20 Shantanu Tushar Jha shaan...@gmail.com: Hi, For the debug messages Sujith is asking, can you try the following and pastebin/attach the output, 1. run kdebugdialog and check all the checkboxes and press ok 2. run plasmoidviewer folderview and wait for sometime after folderview is shown. 3. copy the output on the terminal and send it I can not do it anymore since i have reverted that commit, like i have already stated, but if you doubt of what i say, im sure you will have more news about this from kde users in a near time. I didn't say that I am doubting what you're saying, I just want to find the reason why its not working. Its usually very helpful if people running kde from sources help in debugging :) Currently im building qt-4.8.0 official release and i have my hands in several other projects, so i cant go back building with your commit to show you the output. Im sure will appear some one complaining soon. But i dont understand why you cant do it yourself. Sorry I had tried it and I was not able to reproduce this issue on my system. If I could have reproduced it I would have solved it :) Currently im not subscribed to plasma devel ML, so i cant have it in CC. I have also reported this problem to Aseigo, maybe he could also help on this matter. It would be more apropriated if you could answer following the thread and not answer in the top breaking the order. This can help you - http://matt.might.net/articles/how-to-email/ Thanks :) On Mon, Dec 19, 2011 at 9:25 AM, sujith h sujit...@gmail.com wrote: On Mon, Dec 19, 2011 at 3:04 AM, Zé mmode...@gmail.com wrote: 2011/12/18 Zé mmode...@gmail.com: 2011/12/18 sujith h sujit...@gmail.com: On Sun, Dec 18, 2011 at 3:44 PM, Zé mmode...@gmail.com wrote: 2011/12/18 sujith h sujit...@gmail.com: Hi, Can you please share the debug message? For me its working fine. Sujith H On Sun, Dec 18, 2011 at 7:02 AM, Zé mmode...@gmail.com wrote: The commit you did in kde-baseapps (SHA c4baf7897e541bc070d1425583370830d3ffa414) as completly broken icons in screen. Now doesnt appear any icons in screen using folderview... -- Salutem, Zé What debug message??? Create a new user and check it. Sorry I cannot reproduce this problem. I had tested it by creating a new user. For me it works fine. Can you please let me know what was the method followed, so that I can help you. Sujith H -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info -- Salutem, Zé I had to revert your commit and rebuild kde-baseapps to have back icons available on screen. So please do the necessary steps to put the code you submited built and running. Some times we think we have done the necessary but in the end theres some missing, this has happened with me, so please update your git master, build it and isntall it. We are only humans :) -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info -- Salutem, Zé Just to remind you that i have build with and without your comit and i have created a new user in both cases. Are you trying to access remote site or local host? I had not done anything for local host. If you are trying to access the remote host, can you please share the URL for that, so that I can also try. -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- Shantanu Tushar(UTC +0530) http://www.shantanutushar.com -- Salutem, Zé -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: folderview broken
On Mon, Dec 19, 2011 at 3:04 AM, Zé mmode...@gmail.com wrote: 2011/12/18 Zé mmode...@gmail.com: 2011/12/18 sujith h sujit...@gmail.com: On Sun, Dec 18, 2011 at 3:44 PM, Zé mmode...@gmail.com wrote: 2011/12/18 sujith h sujit...@gmail.com: Hi, Can you please share the debug message? For me its working fine. Sujith H On Sun, Dec 18, 2011 at 7:02 AM, Zé mmode...@gmail.com wrote: The commit you did in kde-baseapps (SHA c4baf7897e541bc070d1425583370830d3ffa414) as completly broken icons in screen. Now doesnt appear any icons in screen using folderview... -- Salutem, Zé What debug message??? Create a new user and check it. Sorry I cannot reproduce this problem. I had tested it by creating a new user. For me it works fine. Can you please let me know what was the method followed, so that I can help you. Sujith H -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info -- Salutem, Zé I had to revert your commit and rebuild kde-baseapps to have back icons available on screen. So please do the necessary steps to put the code you submited built and running. Some times we think we have done the necessary but in the end theres some missing, this has happened with me, so please update your git master, build it and isntall it. We are only humans :) -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info -- Salutem, Zé Just to remind you that i have build with and without your comit and i have created a new user in both cases. Are you trying to access remote site or local host? I had not done anything for local host. If you are trying to access the remote host, can you please share the URL for that, so that I can also try. -- സുജിത് ഹരിദാസന് Bangalore ProjectContributor to KDE project http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding filename as tooltip for frame applet
On 2010-10-28 13:25:15, Anne-Marie Mahfouf wrote: It's fine. Maybe there should be a setting showing the tooltip or not, for example when a user has several picture frames the tooltip is shown on another one which can be annoying. Any feedback from other people about having it as a setting? I agree with you. Thumbs up for the idea :) - Sujith --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8409 --- On 2010-10-20 17:44:12, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- (Updated 2010-10-20 17:44:12) Review request for Plasma and Anne-Marie Mahfouf. Summary --- Added the filename as tooltip for the frame applet. The filename will be displayed as the tooltip when the user moves the moves on the frame. Diffs - trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 Diff: http://svn.reviewboard.kde.org/r/5660/diff Testing --- Tested on the set of pictures I had in my laptop. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding filename as tooltip for frame applet
On 2010-10-20 09:57:56, Ingomar Wesp wrote: Since the ToolTipContent is copied in ToolTipManager::setContent anyway, I wouldn't declare it as a member variable, but just allocate a ToolTipContent on the stack as needed. This way, you wouldn't have to introduce a new member variable and could keep the header unchanged. Otherwise, it looks good to me. Sounds cool. I had modified the patch. Hope this is what meant by you. - Sujith --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8253 --- On 2010-10-20 15:47:47, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- (Updated 2010-10-20 15:47:47) Review request for Plasma and Anne-Marie Mahfouf. Summary --- Added the filename as tooltip for the frame applet. The filename will be displayed as the tooltip when the user moves the moves on the frame. Diffs - trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 Diff: http://svn.reviewboard.kde.org/r/5660/diff Testing --- Tested on the set of pictures I had in my laptop. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding filename as tooltip for frame applet
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- (Updated 2010-10-20 15:47:47.555193) Review request for Plasma and Anne-Marie Mahfouf. Changes --- Making modifications according to Ingomar Wesp. Summary --- Added the filename as tooltip for the frame applet. The filename will be displayed as the tooltip when the user moves the moves on the frame. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 Diff: http://svn.reviewboard.kde.org/r/5660/diff Testing --- Tested on the set of pictures I had in my laptop. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding filename as tooltip for frame applet
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- (Updated 2010-10-20 17:44:12.910669) Review request for Plasma and Anne-Marie Mahfouf. Changes --- Added changes pointed out for the previous diff. Summary --- Added the filename as tooltip for the frame applet. The filename will be displayed as the tooltip when the user moves the moves on the frame. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 Diff: http://svn.reviewboard.kde.org/r/5660/diff Testing --- Tested on the set of pictures I had in my laptop. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding filename as tooltip for frame applet
On 2010-10-20 17:24:50, Ingomar Wesp wrote: I'm not the maintainer of the applet, so I'm sorry that I can only comment on the code itself, not on whether it should go into the applet. I noticed a few issues: - The includes are still in the header. Since you've removed the member variable, you can remove them as well. - The user visible text File: you're setting as main text needs to go through i18n. - You're setting the tooltip content twice (the first call to ToolTipManager::setContent is unnecessary IMHO). Ok, I can understand that. -I had removed the changes in the header file. Now when I do 'svn status' in my working machine, I can find only frame.cpp file updated. -I had changed the File: to i18n. -My mistake removed the first call to ToolTipManager::setContent - Sujith --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/#review8275 --- On 2010-10-20 15:47:47, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- (Updated 2010-10-20 15:47:47) Review request for Plasma and Anne-Marie Mahfouf. Summary --- Added the filename as tooltip for the frame applet. The filename will be displayed as the tooltip when the user moves the moves on the frame. Diffs - trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 Diff: http://svn.reviewboard.kde.org/r/5660/diff Testing --- Tested on the set of pictures I had in my laptop. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Adding filename as tooltip for frame applet
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5660/ --- Review request for Plasma and Anne-Marie Mahfouf. Summary --- Added the filename as tooltip for the frame applet. The filename will be displayed as the tooltip when the user moves the moves on the frame. Diffs - trunk/KDE/kdeplasma-addons/applets/frame/frame.h 1187544 trunk/KDE/kdeplasma-addons/applets/frame/frame.cpp 1187544 Diff: http://svn.reviewboard.kde.org/r/5660/diff Testing --- Tested on the set of pictures I had in my laptop. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Error while building
Hi, I had found an error while building the kdebase. The error actually pointed for the requirement saying it needs 0.6.0 version of dbusmenu-qt. I had updated the dbusmenu-qt by pulling it from the gitorious. And its already updated. Again am facing the same issue with the kdebase build. A helping hand to resolve this issue would be very much appreciated. Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info [suj...@myhost kdebase]$ cmakekde -- Found Qt-Version 4.7.0 (using /home/sujith/kde-qt/bin/qmake) -- Found X11: /usr/lib/libX11.so -- Found KDE 4.6 include dir: /home/sujith/kde/include -- Found KDE 4.6 library dir: /home/sujith/kde/lib -- Found the KDE4 kconfig_compiler preprocessor: /home/sujith/kde/bin/kconfig_compiler -- Found automoc4: /home/sujith/kde/bin/automoc4 -- Strigi API needs 'signed char' -- Found SharedDesktopOntologies: /home/sujith/kde/share/ontology -- Could NOT find SLP (missing: SLP_LIBRARIES SLP_INCLUDE_DIR) KDE4_DBUS_INTERFACES_DIR = /home/sujith/kde/share/dbus-1/interfaces -- checking for one of the modules 'NetworkManager' -- checking for one of the modules 'libnm-util' -- QNtrack not found. Can be used as a data input to Solid network status. See https://launchpad.net/ntrack -- Found OPENEXR: /usr/lib/libImath.so;/usr/lib/libIlmImf.so;/usr/lib/libIex.so;/usr/lib/libHalf.so;/usr/lib/libIlmThread.so -- Found ALSA: /usr/lib/libasound.so -- Could NOT find PulseAudio (missing: PULSEAUDIO_LIBRARY PULSEAUDIO_INCLUDE_DIR) (Required is at least version 0.9.16) -- checking for module 'libcanberra' -- package 'libcanberra' not found -- Strigi API needs 'signed char' -- Found SharedDesktopOntologies: /home/sujith/kde/share/ontology -- Strigi API needs 'signed char' CMake Error at /home/sujith/kde/share/apps/cmake/modules/FindPackageHandleStandardArgs.cmake:194 (MESSAGE): Could NOT find DBusMenuQt: Found version .., but required is at least 0.6.0 (found /home/sujith/kde/lib/libdbusmenu-qt.so) Call Stack (most recent call first): /home/sujith/kde/share/apps/cmake/modules/FindDBusMenuQt.cmake:70 (find_package_handle_standard_args) workspace/CMakeLists.txt:26 (find_package) -- Configuring incomplete, errors occurred! make: *** No targets specified and no makefile found. Stop. [suj...@myhost kdebase]$ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Re: Error while building
On Sat, Oct 2, 2010 at 11:05 PM, Diego Casella ([Po]lentino) polentino...@gmail.com wrote: -- Messaggio inoltrato -- From: sujith h sujit...@gmail.com To: plasma-devel@kde.org Date: Sat, 2 Oct 2010 12:13:34 +0530 Subject: Error while building Hi, I had found an error while building the kdebase. The error actually pointed for the requirement saying it needs 0.6.0 version of dbusmenu-qt. I had updated the dbusmenu-qt by pulling it from the gitorious. And its already updated. Again am facing the same issue with the kdebase build. A helping hand to resolve this issue would be very much appreciated. Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info Try to move dbusmenu-qt into the last available tag (git checkout 0.6.4.kde IIRC), then rebuild dbusmenu-qt and kdebase; this did the trick for me. Once they will fix that issue (Found version .. sounds ), you can make your clone to point back to master :) Thats the trick :) It worked for me too. Thanks. Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images
On 2010-09-16 11:20:34, Sebastian Kügler wrote: One small issue with i18n context left, otherwise it's good to go in (from my point of view, better wait for annma to mark it as ship it as well). Thanks. I will do it right away :) On 2010-09-16 11:20:34, Sebastian Kügler wrote: trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 88 http://svn.reviewboard.kde.org/r/5362/diff/4/?file=36015#file36015line88 i18n context should be more useful. Anne-Marie Mahfouf wrote: I agree with Sebas, ship it and thanks for looking in this issue! As for the context help for translators, maybe we can put i18nc(Text written on default picture, Dropped folder is empty. Please drop a folder with image(s)); Thanks Anne-Marie :) - Sujith --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/#review7637 --- On 2010-09-16 03:54:44, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/ --- (Updated 2010-09-16 03:54:44) Review request for Plasma. Summary --- This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s). Diffs - trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 Diff: http://svn.reviewboard.kde.org/r/5362/diff Testing --- This has been tested. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Frame applet should give valid message when dropped folder doesn't have any images
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/ --- Review request for Plasma. Summary --- This diff will make the give meaningful message when a folder is dropped to the frame applet, doesn't contain image(s). Diffs - trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 Diff: http://svn.reviewboard.kde.org/r/5362/diff Testing --- This has been tested. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/ --- (Updated 2010-09-15 18:45:47.497148) Review request for Plasma. Changes --- Removing the TODO from the slideshow.cpp Summary (updated) --- This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s). Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 Diff: http://svn.reviewboard.kde.org/r/5362/diff Testing --- This has been tested. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images
On 2010-09-15 19:34:53, Anne-Marie Mahfouf wrote: - You forgot to remove the class SlideShow; and #include slideshow.h from the Picture class - The message is not so good Folder that is dropped is empty. Please drop a folder with image(s). Maybe Dropped folder is empty. Please drop a folder with image(s) An English speaker can improve this. - There should not be the 2 arrows on the picture (the next and previous ones that only make sense on a slideshow). If you then drop a picture in it the 2 arrows stay. This seems to be a bug that existed before the patch though (the arrows stay after a slideshow) Anne-Marie, thanks for pointing out my mistake. I will remove class SlideShow; and #include slideshow.h from Picture Class. The suggestion regarding message is noted down. You are correct may be an English speaker can improve this. Will it be ok if I spent some more time for the 2 arrows problem. May I take it as my next task? - Sujith --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/#review7623 --- On 2010-09-16 03:54:44, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/ --- (Updated 2010-09-16 03:54:44) Review request for Plasma. Summary --- This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s). Diffs - trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 Diff: http://svn.reviewboard.kde.org/r/5362/diff Testing --- This has been tested. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/ --- (Updated 2010-09-16 03:54:44.933376) Review request for Plasma. Changes --- Updated the patch with the comments from Anne-Marie and Sebastian. Only missing part in the patch is regarding the arrows that remain even after the slideshow and even if the dropped folder doesn't contain images. Summary --- This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s). Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 Diff: http://svn.reviewboard.kde.org/r/5362/diff Testing --- This has been tested. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Frame applet should give valid message when dropped folder doesn't have any images
On 2010-09-15 22:34:11, Sebastian Kügler wrote: trunk/KDE/kdeplasma-addons/applets/frame/picture.h, line 66 http://svn.reviewboard.kde.org/r/5362/diff/3/?file=35935#file35935line66 trailing whitespace, please remove Noted down and removed the trailing white space. On 2010-09-15 22:34:11, Sebastian Kügler wrote: trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 90 http://svn.reviewboard.kde.org/r/5362/diff/3/?file=35936#file35936line90 should probably be a bool Changed to bool. On 2010-09-15 22:34:11, Sebastian Kügler wrote: trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp, line 132 http://svn.reviewboard.kde.org/r/5362/diff/3/?file=35936#file35936line132 Don't use a magic string here, a bool looks more in place? Changed to bool. Hence m_checkDir = Empty changes to m_checkDir = false; - Sujith --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/#review7624 --- On 2010-09-16 03:54:44, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5362/ --- (Updated 2010-09-16 03:54:44) Review request for Plasma. Summary --- This diff will give the user meaningful message when a folder is dropped to the frame applet and if it doesn't contain image(s). Diffs - trunk/KDE/kdeplasma-addons/applets/frame/picture.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/picture.cpp 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.h 1174498 trunk/KDE/kdeplasma-addons/applets/frame/slideshow.cpp 1174498 Diff: http://svn.reviewboard.kde.org/r/5362/diff Testing --- This has been tested. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: configChanged coverage for 4.6
On Tue, Sep 14, 2010 at 10:22 PM, Anne-Marie Mahfouf ann...@gmail.comwrote: On Tuesday 14 September 2010 01:55:39 Aaron J. Seigo wrote: On Saturday, September 4, 2010, Aaron J. Seigo wrote: All applets we ship that have any configuration will implement configChanged() it looks like we've accomplished our goal! folderview still has some outstanding items in it, but they are being actively worked on. thank-you to everyone who helped out with this! feedback time: was this a useful / helpful way to go about getting such improvements done? for those who got involved: was it enjoyable for you, and would you do it again? if so, i have a few more similarly entry level, detail oriented items that we could set as a new focus item. Hi, For me it was a motivating task to get back into KDE after 2 months away (summer kids holiday). I also noticed in the process that the applets in kdeplasma-addons are working well! Maybe I could have mentored a newcomer through it though (by the way of blogging for example) which would be nice for a next task. Would you mentor me? I would like to learn c++ more. The WorldClock applet in kdeedu/marble is still to be done but it crashes on me in a weird way so I can't even look at it. Anne-Marie ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Help regarding the code
On Wed, Sep 15, 2010 at 4:01 AM, Aaron J. Seigo ase...@kde.org wrote:
On Tuesday, September 14, 2010, sujith h wrote:
Hi,
I were trying to modify the frame applet in kdeplasma-addons.
I am having a small issue with the diff attached with the
mail(frame.diff).
The backtrace is also attached with
the mail(backtrace.txt). My intention is to pass emit the a function in
slideshow.cppwhen the directory is empty
to load images and then use the connect in the picture.cpp to write some
message to the a QString variable.
In the mean while I am initializing an object of SlideShow class using:
m_slideshow = new SlideShow(this);
Should this cause a problem? Pardon me if am wrong.
you have an infinite loop, and youc an see this in the backtrace how it
alternates between two lines back and forth:
in your patch in Picture::Picture(), there is this:
m_slideshow = new SlideShow(this);
so Picture creates a SlideShow. but in SlideShow's constructor, there is
this:
m_picture = new Picture(this);
which means Picture creates a Slideshow, which creates a Picture, which
creates a SlideShow, which creates a
you should not create the SlideShow in Picture. instead, right after
m_picture = new Picture(this); in SlideShow, put this line:
connect(this, SIGNAL(emptyDirMessage()), m_picture,
SLOT(customizeEmptyMessage()));
that should work much better :)
on a side note, instead of this:
if( m_picturePaths.size() == 0) {
you can just do:
if (m_picturePaths.isEmtpy()) {
we find it more readable
also, please be careful to follow the coding style (whitespace, etc) in the
files you work on.. cheers :)
Thanks a lot Aaron. I would try my best to rectify my errors.
--
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43
KDE core developer sponsored by Qt Development Frameworks
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
--
സുജിത് ഹരിദാസന്
Bangalore
http://fci.wikia.com/wiki/Anti-DRM-Campaign
Blog http://sujithh.info
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Adding KMessageBox instead of KNotification
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/ --- Review request for Plasma and Anne-Marie Mahfouf. Summary --- Implementing a TODO in the timer.cpp. Removing the KNotification with KMessageBox. Diffs - trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1061089 Diff: http://reviewboard.kde.org/r/2361/diff Testing --- Testing is done. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding KMessageBox instead of KNotification
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/ --- (Updated 2009-12-12 12:04:32.331590) Review request for Plasma and Anne-Marie Mahfouf. Changes --- The timer applet will now always start with 00:00:00. And the i18n string is reverted back. Summary --- Implementing a TODO in the timer.cpp. Removing the KNotification with KMessageBox. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1061089 Diff: http://reviewboard.kde.org/r/2361/diff Testing --- Testing is done. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding KMessageBox instead of KNotification
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/ --- (Updated 2009-12-12 12:13:50.835279) Review request for Plasma and Anne-Marie Mahfouf. Changes --- Removed KNotification from the earlier patch. Summary --- Implementing a TODO in the timer.cpp. Removing the KNotification with KMessageBox. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1061089 Diff: http://reviewboard.kde.org/r/2361/diff Testing --- Testing is done. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding KMessageBox instead of KNotification
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/ --- (Updated 2009-12-12 13:11:26.536267) Review request for Plasma and Anne-Marie Mahfouf. Changes --- Removed the enableAllMessages. Now its users wish, whether he/she wants to see the message. Summary --- Implementing a TODO in the timer.cpp. Removing the KNotification with KMessageBox. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1061089 Diff: http://reviewboard.kde.org/r/2361/diff Testing --- Testing is done. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding KMessageBox instead of KNotification
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/ --- (Updated 2009-12-12 13:13:42.435258) Review request for Plasma and Anne-Marie Mahfouf. Summary --- Implementing a TODO in the timer.cpp. Removing the KNotification with KMessageBox. Diffs (updated) - trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1061089 Diff: http://reviewboard.kde.org/r/2361/diff Testing --- Testing is done. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding KMessageBox instead of KNotification
On 2009-12-12 14:02:03, Marco Martin wrote: replacing something that doesn't interrupt the workflow with something that does? it's just the opposite of what we're trying to do everywhere else You are absolutely right. Hence I am closing this request. - Sujith --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/#review3406 --- On 2009-12-12 13:13:42, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2361/ --- (Updated 2009-12-12 13:13:42) Review request for Plasma and Anne-Marie Mahfouf. Summary --- Implementing a TODO in the timer.cpp. Removing the KNotification with KMessageBox. Diffs - trunk/KDE/kdeplasma-addons/applets/timer/timer.cpp 1061089 Diff: http://reviewboard.kde.org/r/2361/diff Testing --- Testing is done. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Build is breaking
Hi, When I were trying to build kdebase, the build was breaking. This was the error I was getting. [ 2%] Built target oxygen_automoc Scanning dependencies of target kstyle_oxygen_config_automoc Generating oxygenconf.moc [ 2%] Built target kstyle_oxygen_config_automoc Scanning dependencies of target attica_kde_automoc Generating kdeplatformdependent.moc /media/disk/kde-dev/kde/src/KDE/kdebase/runtime/attica/kdeplugin/kdeplatformdependent.h:42: Error: Undefined interface automoc4: process for /media/disk/kde-dev/kde/build/KDE/kdebase/runtime/attica/kdeplugin/kdeplatformdependent.moc failed: Unknown error pid to wait for: 0 returning failed.. make[2]: *** [runtime/attica/kdeplugin/CMakeFiles/attica_kde_automoc] Error 1 make[1]: *** [runtime/attica/kdeplugin/CMakeFiles/attica_kde_automoc.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs [ 2%] Built target userguide-handbook make: *** [all] Error 2 kde-de...@kdedev:/media/disk/kde-dev/kde/src/KDE/kdebase$ Can anyone help me to find out what is Q_INTERFACES(Attica::PlatformDependent) and how to resolve this error? Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
On 8/31/09, Aaron J. Seigo ase...@kde.org wrote: On August 31, 2009, Beat Wolf wrote: On 2009-05-07 10:17:53, Aaron Seigo wrote: another nice bug fix for 4.3 :) this patch seems to be commited, how can one mark a reviewrequest as shipped? the reporter needs to do it (or someone with admin rights, which i have though i can't make other people admins; have to ask David S. for that) Its fault from my side. And the request is marked as submitted. Thanks. I am marking the features/bugs that I have committed to trunk as submitted. Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: 4.4 call for runners (ideas)
On Thu, Jul 23, 2009 at 7:16 PM, Artur Souza (MoRpHeUz) morph...@openbossa.org wrote: On Thursday 23 July 2009, 06:45 Jacopo De Simoi wrote: I've also the following (random) ideas: I would love to have an assistant runner where I just type the name of the Qt class and it gives me back assistant on the exact page I need :) (even for kde docs). I support you :) Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fixing Bball getting stuck at the corner
On 2009-07-18 18:23:09, Anne-Marie Mahfouf wrote: I tested and indeed it works fine and it fixes the corner problem. It's a ship it and backport it from me. Thanks for testing it :) - Sujith --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/#review1653 --- On 2009-07-17 23:37:46, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/ --- (Updated 2009-07-17 23:37:46) Review request for Plasma, Aaron Seigo, Artur de Souza (MoRpHeUz), and Sebastian Kügler. Summary --- The Bball gets stuck at the right-bottom/left-bottom. Now with this patch it doesn't stuck. I had added a feature that when dropped from right/left top will make the ball bounce. Diffs - /trunk/KDE/kdeplasma-addons/applets/bball/bball.h 998542 /trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 998542 Diff: http://reviewboard.kde.org/r/1054/diff Testing --- Tested in my laptop and works fine here. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fixing Bball getting stuck at the corner
On 2009-07-19 00:16:17, Omer F. USTA wrote:
Hi , just to learn why or instead of common || ? in
if (m_bottom_right == 1 or m_bottom_left == 1) {
I changed it to '||'.
- Sujith
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1054/#review1655
---
On 2009-07-17 23:37:46, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1054/
---
(Updated 2009-07-17 23:37:46)
Review request for Plasma, Aaron Seigo, Artur de Souza (MoRpHeUz), and
Sebastian Kügler.
Summary
---
The Bball gets stuck at the right-bottom/left-bottom. Now with this patch it
doesn't stuck. I had added a feature that when dropped from right/left top
will make the ball bounce.
Diffs
-
/trunk/KDE/kdeplasma-addons/applets/bball/bball.h 998542
/trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 998542
Diff: http://reviewboard.kde.org/r/1054/diff
Testing
---
Tested in my laptop and works fine here.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Fixing Bball getting stuck at the corner
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/ --- Review request for Plasma, Aaron Seigo and Sebastian Kügler. Summary --- The Bball gets stuck at the right-bottom/left-bottom. Now with this patch it doesn't stuck. I had added a feature that when dropped from right/left top will make the ball bounce. Diffs - /trunk/KDE/kdeplasma-addons/applets/bball/bball.h 998542 /trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 998542 Diff: http://reviewboard.kde.org/r/1054/diff Testing --- Tested in my laptop and works fine here. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Fixing Bball getting stuck at the corner
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/1054/ --- (Updated 2009-07-17 23:37:46.001490) Review request for Plasma, Aaron Seigo, Artur de Souza (MoRpHeUz), and Sebastian Kügler. Summary --- The Bball gets stuck at the right-bottom/left-bottom. Now with this patch it doesn't stuck. I had added a feature that when dropped from right/left top will make the ball bounce. Diffs - /trunk/KDE/kdeplasma-addons/applets/bball/bball.h 998542 /trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp 998542 Diff: http://reviewboard.kde.org/r/1054/diff Testing --- Tested in my laptop and works fine here. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Plasmate IRC Meeting
On Thursday 11 June 2009, 01:42 Aaron J. Seigo wrote: i'm in my car until ~14:50 dropping peyton off at school. if we could make it even 15 minutes later i can be there for even most of the beginning :) Ok ! 14:45 is the new time :) Sounds nice. Sujith H ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Help to compile plasma in playground
Hi, Today I did svn checkout of playground/base(with non-recursive, hence I got only the basic files like CMakeLists.txt ,INDEX,INSTALL,Mainpage.dox and README). Inside the base directory i checked out the plasma directory. I know that these applets are under development. But I am struggling to compile the plasma. I have already compiled the qt-copy,kdelibs,kdesupport and kdepimlibs. A helping hand is very much appreciated to compile plasma in playground. Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Help to compile plasma in playground
On Tue, Jun 9, 2009 at 8:46 PM, Sebastian Kügler se...@kde.org wrote: Hi Sujith, On Tuesday 09 June 2009 15:47:23 sujith h wrote: Today I did svn checkout of playground/base(with non-recursive, hence I got only the basic files like CMakeLists.txt ,INDEX,INSTALL,Mainpage.dox and README). Inside the base directory i checked out the plasma directory. I know that these applets are under development. But I am struggling to compile the plasma. I have already compiled the qt-copy,kdelibs,kdesupport and kdepimlibs. A helping hand is very much appreciated to compile plasma in playground. What's the error you get? Here is the error I get when I compile playground/plasma. http://pastebin.ca/1453810 Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Help to compile plasma in playground
Oops by mistake i send a personal mail to morpheuz. It's not a problem with playground: CMake Error at /usr/share/cmake-2.6/Modules/FindPackageHandleStandardArgs.cmake:57 (MESSAGE): Could NOT find Akonadi (missing: Akonadi_CONFIG) Call Stack (most recent call first): /home/kde-devel/kde/share/apps/cmake/modules/FindAkonadi.cmake:40 (find_package_handle_standard_args) plasma/applets/lionmail/CMakeLists.txt:4 (find_package) This means that it's not finding Akonadi and for some reason playground needs akonadi to be built. I had this yesterday because Akonadi was updated. Update your akonadi by updating kdesupport module. Cheers, Thank you let me try svn update for kdesupport and compile it once more :) Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-21 23:52:58.365003) Review request for Plasma, Aaron Seigo and Lukas. Changes --- Removed the int val, and used enum instead :) Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-22 03:50:17.663140) Review request for Plasma, Aaron Seigo and Lukas. Changes --- Code clean up. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-22 04:49:04.421210) Review request for Plasma, Aaron Seigo and Lukas. Changes --- Made proper indentation for the code. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-22 05:02:07.524673) Review request for Plasma, Aaron Seigo and Lukas. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-22 05:13:57.645943) Review request for Plasma, Aaron Seigo and Lukas. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- Review request for Plasma, Aaron Seigo and Lukas. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-21 10:51:20.617736) Review request for Plasma, Aaron Seigo and Lukas. Changes --- Updated the code by adding using QHash. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Added sort feature in quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/731/ --- (Updated 2009-05-21 11:57:12.905933) Review request for Plasma, Aaron Seigo and Lukas. Changes --- Removed the static sortedList and saveSortedUrlList. And made it as part of the method. Summary --- Added feature to sort applications in quicklaunch both in ascending and descending. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 969054 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.h 968476 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchIcon.cpp 968476 Diff: http://reviewboard.kde.org/r/731/diff Testing --- Done basic testing and it had worked well. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Number of visible icons set to 0 in quicklaunch doesnt work after quicklaunch restart.
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/710/ --- Review request for Plasma, Aaron Seigo and Lukas. Summary --- When the number of visible icons in the quicklaunch is set to 0, the setting remains only for that session. With this patch it works. This addresses bug 192633. https://bugs.kde.org/show_bug.cgi?id=192633 Diffs - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 968476 Diff: http://reviewboard.kde.org/r/710/diff Testing --- Tested by setting the visible icons to 0 and it is working. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Get url list
Aaron J. Seigo wrote:
On Tuesday 12 May 2009, SUJITH H wrote:
I am able to iterate the row's. But have no clue how to retrieve the url
of that sorted Favorite item :(
KUrl url = childData-data(Kickoff::UrlRole);
I am getting segmentation fault when I run 'plasmoidviewer launcher'.
I had modified the sortFavorites. So the method becomes:
void FavoritesModel::sortFavorites(Qt::SortOrder order)
{
foreach (FavoritesModel *model, Private::models) {
model-d-headerItem-sortChildren(0, order);
}
FavoritesModel *model;
QStandardItem *childData;
for (int i = 0; i numberOfFavorites(); i++) {
childData = model-d-headerItem-child(i, 0);
kDebug() Url = childData-data(Kickoff::UrlRole);
}
Private::saveFavorites();
}
Any clue why am getting segmentation fault here?
Sujith H
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Sorting of Favourites in launcher will be saved
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/690/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch is regarding the bug 189607. This patch will enable saving the sorted Favorites. This addresses bug 189607. https://bugs.kde.org/show_bug.cgi?id=189607 Diffs - trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp 967123 Diff: http://reviewboard.kde.org/r/690/diff Testing --- Done basic testing by adding new items to favourites and deleting. It worked. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Sorting of Favourites in launcher will be saved
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/690/ --- (Updated 2009-05-13 11:18:46.172782) Review request for Plasma and Aaron Seigo. Changes --- Updated according to the comments :) Summary --- This patch is regarding the bug 189607. This patch will enable saving the sorted Favorites. This addresses bug 189607. https://bugs.kde.org/show_bug.cgi?id=189607 Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/favoritesmodel.cpp 967638 Diff: http://reviewboard.kde.org/r/690/diff Testing --- Done basic testing by adding new items to favourites and deleting. It worked. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Get url list
Aaron J. Seigo wrote:
On Monday 11 May 2009, SUJITH H wrote:
Can anyone help me how to get the url list of the sorted item
in launcher applet?
KUrl::List urls;
foreach (QuicklaunchIcon *icon, m_icons) {
urls icon-url();
}
Ok I think my explanation wasn't sufficient. My intention is to get the
Url of the sorted item in the launcher applet(kickoff). That is if
sorted either A-Z or Z-A. And then update globalFavoruteList
accordingly. Here is the small snippet I had done to sortFavorite method
in kickoff/core/favoritesmodel.cpp:
void FavoritesModel::sortFavorites(Qt::SortOrder order)
{
foreach (FavoritesModel *model, Private::models) {
model-d-headerItem-sortChildren(0, order);
}
FavoritesModel *model;
QStandardItem *childData;
for (int i = 0; i numberOfFavorites(); i++) {
childData = d-headerItem-child(i, 0);
}
Private::saveFavorites();
}
I am able to iterate the row's. But have no clue how to retrieve the url
of that sorted Favorite item :(
This work is related to the bug https://bugs.kde.org/show_bug.cgi?id=189607
Sujith H
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Get url list
Hi, Can anyone help me how to get the url list of the sorted item in launcher applet? Sujith H ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-07 08:56:57.415417) Review request for Plasma and Aaron Seigo. Changes --- I did indentation for the code. And its working :) Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 964135 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 964135 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
On 2009-05-05 16:14:28, Aaron Seigo wrote:
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp,
lines 379-381
http://reviewboard.kde.org/r/649/diff/8/?file=6115#file6115line379
the easiest way i can think of doing this (even if its not super fast,
which doesn't matter because there are small #s of items here):
for (int i = 0; i m_dialogLayout-count(); ++i) {
QGraphicsLayoutItem *item = m_dialogLayout-itemAt(i);
if (item-geometry().contains(pos)) {
m_dialogLayout-insertItem(dropedItem, i + 1);
break;
}
}
dropItem is Plasma::IconWidget right? err thats again confusing :( And the
insertItem would call addItem method of QGraphicsGridLayout.
- Sujith
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
---
On 2009-05-05 12:28:07, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/
---
(Updated 2009-05-05 12:28:07)
Review request for Plasma and Aaron Seigo.
Summary
---
This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had
added one more method named dropApp. Added the processDrop as per Aaron
seigo.
Diffs
-
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h
963461
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp
963461
Diff: http://reviewboard.kde.org/r/649/diff
Testing
---
Done basic testing and it works.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
On 2009-05-05 16:14:28, Aaron Seigo wrote:
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp,
lines 379-381
http://reviewboard.kde.org/r/649/diff/8/?file=6115#file6115line379
the easiest way i can think of doing this (even if its not super fast,
which doesn't matter because there are small #s of items here):
for (int i = 0; i m_dialogLayout-count(); ++i) {
QGraphicsLayoutItem *item = m_dialogLayout-itemAt(i);
if (item-geometry().contains(pos)) {
m_dialogLayout-insertItem(dropedItem, i + 1);
break;
}
}
wrote:
dropItem is Plasma::IconWidget right? err thats again confusing :( And
the insertItem would call addItem method of QGraphicsGridLayout.
May I know how to get the droped item(or object)? Because dropApp method uses
QGraphicsSceneDragDropEvent *event.
- Sujith
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
---
On 2009-05-05 12:28:07, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/
---
(Updated 2009-05-05 12:28:07)
Review request for Plasma and Aaron Seigo.
Summary
---
This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had
added one more method named dropApp. Added the processDrop as per Aaron
seigo.
Diffs
-
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h
963461
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp
963461
Diff: http://reviewboard.kde.org/r/649/diff
Testing
---
Done basic testing and it works.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
On 2009-05-05 16:14:28, Aaron Seigo wrote:
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp,
lines 379-381
http://reviewboard.kde.org/r/649/diff/8/?file=6115#file6115line379
the easiest way i can think of doing this (even if its not super fast,
which doesn't matter because there are small #s of items here):
for (int i = 0; i m_dialogLayout-count(); ++i) {
QGraphicsLayoutItem *item = m_dialogLayout-itemAt(i);
if (item-geometry().contains(pos)) {
m_dialogLayout-insertItem(dropedItem, i + 1);
break;
}
}
wrote:
dropItem is Plasma::IconWidget right? err thats again confusing :( And
the insertItem would call addItem method of QGraphicsGridLayout.
wrote:
May I know how to get the droped item(or object)? Because dropApp method
uses QGraphicsSceneDragDropEvent *event.
wrote:
looking at the code, all you need to do is this:
dropHandler(i + 1, event-mimeData());
The position used i.e, i+1, I think should be (i + 1 + m_visibleIcons). Else
the issue is if I don't use m_visibleIcons, then :
If i is 0, then position becomes 1. And hence the dropedItem gets added in the
applet not in the dialog box.
- Sujith
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/#review1070
---
On 2009-05-05 12:28:07, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/649/
---
(Updated 2009-05-05 12:28:07)
Review request for Plasma and Aaron Seigo.
Summary
---
This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had
added one more method named dropApp. Added the processDrop as per Aaron
seigo.
Diffs
-
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h
963461
trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp
963461
Diff: http://reviewboard.kde.org/r/649/diff
Testing
---
Done basic testing and it works.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-05 12:28:07.433175) Review request for Plasma and Aaron Seigo. Changes --- A helping hand is required in calculating the position of the drop in the dialog box. Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs (updated) - trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 963461 trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 963461 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-04 11:55:21.794595) Review request for Plasma and Aaron Seigo. Changes --- I am stuck to find out the position of the application to be inserted. The problem is in the 'else' part of the dropApp method. Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs (updated) - /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 962341 /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 962341 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-04 12:00:56.303439) Review request for Plasma and Aaron Seigo. Changes --- I am stuck to find out the position of the application to be inserted. The problem is in the 'else' part of the dropApp method. Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs (updated) - kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 963449 kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 963449 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-04 12:02:49.230058) Review request for Plasma and Aaron Seigo. Changes --- I am stuck to find out the position of the application to be inserted. The problem is in the 'else' part of the dropApp method. Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs (updated) - KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 963449 KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 963449 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-02 11:19:15.254137) Review request for Plasma and Aaron Seigo. Changes --- Added the required changes for dialog part. Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs (updated) - /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 962341 /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 962341 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- Review request for Plasma and Aaron Seigo. Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs - /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 955826 /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 955826 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: FIXME part of quicklaunch
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/649/ --- (Updated 2009-05-01 13:15:49.798493) Review request for Plasma and Aaron Seigo. Changes --- Removed processDrop from the code. Summary --- This patch is regarding the FIXME part of the quicklaunchApplet.cpp. I had added one more method named dropApp. Added the processDrop as per Aaron seigo. Diffs (updated) - /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 955826 /kde/trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 955826 Diff: http://reviewboard.kde.org/r/649/diff Testing --- Done basic testing and it works. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Problem compiling kdebase
On Sun, Apr 12, 2009 at 6:11 PM, Shantanu Tushar Jha jhahon...@gmail.comwrote: Recently I updated kdesupport, kdelibs, kdepimlibs, kdebase and as usual tried to make. kdesupport, kdelibs, and kdepimlibs built successfuly. When I try to 'make' kdebase, I get the following errors- [ 33%] Built target kappfinder_install [ 33%] Built target plasma_applet_folderview_automoc Linking CXX shared module ../../../../lib/plasma_applet_folderview.so CMakeFiles/plasma_applet_folderview.dir/folderview.o: In function `RemoteWallpaperSetter': /home/kde-devel/kde/src/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp:247: undefined reference to `vtable for RemoteWallpaperSetter' /home/kde-devel/kde/src/KDE/kdebase/apps/plasma/applets/folderview/folderview.cpp:247: undefined reference to `vtable for RemoteWallpaperSetter' collect2: ld returned 1 exit status make[2]: *** [lib/plasma_applet_folderview.so] Error 1 make[1]: *** [apps/plasma/applets/folderview/CMakeFiles/plasma_applet_folderview.dir/all] Error 2 make: *** [all] Error 2 makeobj[0]: Leaving directory `/home/kde-devel/kde/build/KDE/kdebase' Any idea what I'm doing wrong ? Shantanu, for me kdelibs is broken and I couldn't compile kdebase. The reason is anonsvn is broken :( (I hope u are also using the same) We may have to wait for it to become working :) If you are not using anonsvn please ignore my reply. Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Snapshot of quicklaunch applet
Hi Aron, I am sending the snapshot of the quicklaunch applet. http://imagebin.org/45059 In the constructor I had called kDebug() Foo Start and just after the resize(sizeHint(Qt::PreferredSize)) i had called another kDebug() Bar see in the method refactorUi(). Even if I change m_timer-start(100) to m_timer-start(10) its not making much difference :( Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: QTimer and Event compression
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/538/ --- (Updated 2009-04-09 08:16:50.829876) Review request for Plasma and Aaron Seigo. Changes --- Added connect function to the constructor of the QuicklaunchApplet class. Summary --- Hi Aron, This review request is regarding the event compression and QTimer of quicklaunch, which you had discussed in the IRC. I had given m_timer-start(100). I hope I am correct. If I am wrong then please do correct me. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 950296 /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 950296 Diff: http://reviewboard.kde.org/r/538/diff Testing --- Just compiled the quicklaunch. It compiled without any issues. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: QTimer and Event compression
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/538/ --- Review request for Plasma and Aaron Seigo. Summary --- Hi Aron, This review request is regarding the event compression and QTimer of quicklaunch, which you had discussed in the IRC. I had given m_timer-start(100). I hope I am correct. If I am wrong then please do correct me. Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.h 950296 /trunk/KDE/kdebase/workspace/plasma/applets/quicklaunch/quicklaunchApplet.cpp 950296 Diff: http://reviewboard.kde.org/r/538/diff Testing --- Just compiled the quicklaunch. It compiled without any issues. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/#review806 --- /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp http://reviewboard.kde.org/r/441/#comment493 I believe this method fits here. Is this method wrong? - Sujith On 2009-04-02 12:34:04, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-04-02 12:34:04) Review request for Plasma. Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-04-02 09:33:32.533793) Review request for Plasma. Changes --- Have a look at this diff :) Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
On 2009-04-02 10:06:27, Aaron Seigo wrote:
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp, line
611
http://reviewboard.kde.org/r/441/diff/5/?file=4680#file4680line611
this should be:
return m_applicationModel-nameDisplayOrder() ==
ApplicationModel::NameBeforeDescription;
wrote:
nameDisplayOrder()? So that means I would have to write a function
nameDisplayOrder() function?
wrote:
yes: bool nameDisplayOrder() const;
so it should be :
bool nameDisplayOrder() const
{
return ApplicationModel::NameBeforeDescription;
}
right?
- Sujith
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review785
---
On 2009-04-02 09:33:32, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/
---
(Updated 2009-04-02 09:33:32)
Review request for Plasma.
Summary
---
As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia
section he/she can see Audio Player - Amarok. But he requested it to be in
other way Amarok - Audio Player. Hence as an initial step he asked me to
add a check box similar to Switch tabs on hover. I had added a check box
for this. I am a newbie in KDE. Hence would like to know what next should I
do to accomplish the task.
Diffs
-
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp
947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244
Diff: http://reviewboard.kde.org/r/441/diff
Testing
---
I had compiled the above patch in my build directory. It compiled without any
errors.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-04-02 12:34:04.446635) Review request for Plasma. Changes --- I hope this time its ok :) Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/core/applicationmodel.cpp 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.h 947244 /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/ui/launcher.cpp 947244 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
On 2009-03-27 17:28:45, Aaron Seigo wrote: great! a few small issues to take care of; the next step is now to read the value when the applet is created. that should go into void Launcher::setApplet(Plasma::Applet *applet) in ui/launcher.cpp. then modify ApplicationModel (in core/applicationmodel.cpp) to have the order set (e.g. setNameDisplayOrder(DisplayOrder) where DisplayOrder would be an enum (there's a FormatType enum in simpleapplet/simpleapplet.h that maybe could be moved somewhere in core/?), and then in ApplicationModel::data, return the name or generic name based on that setting. that should complete the feature :) I am stuck at ApplicationModel(in core/applicationmodel.cpp). - Sujith --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/#review654 --- On 2009-03-27 12:37:45, Sujith H wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-03-27 12:37:45) Review request for Plasma. Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 945188 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
On 2009-03-27 17:28:45, Aaron Seigo wrote:
great! a few small issues to take care of; the next step is now to read the
value when the applet is created. that should go into void
Launcher::setApplet(Plasma::Applet *applet) in ui/launcher.cpp.
then modify ApplicationModel (in core/applicationmodel.cpp) to have the
order set (e.g. setNameDisplayOrder(DisplayOrder) where DisplayOrder would
be an enum (there's a FormatType enum in simpleapplet/simpleapplet.h that
maybe could be moved somewhere in core/?), and then in
ApplicationModel::data, return the name or generic name based on that
setting.
that should complete the feature :)
Sujith H wrote:
I am stuck at ApplicationModel(in core/applicationmodel.cpp).
Aaron Seigo wrote:
create a method that is something like void
setNameDisplayOrder(DisplayOrder) in ApplicationModel. then modify
ApplicationModel::data to return either the name or the description depending
on what the value was set to in setNameDisplayOrder. if you can describe
where you are stuck a bit more, perhaps i can offer a clearer answer.
I wrote a method in core/applicationmodel.cpp
int ApplicationModel::setNameDisplayOrder(DisplayOrder displayorder)
{
displayorder = NameBeforeDescription;
return displayorder;
}
In the core/application.h I wrote:
class KICKOFF_EXPORT ApplicationModel : public KickoffAbstractModel
{
Q_OBJECT
Q_ENUMS(DisplayOrder)
public:
.
.
.
enum DisplayOrder {
NameAfterDescription,
NameBeforeDescription
};
.
.
.
.
virtual int setNameDisplayOrder(DisplayOrder);
}
But I am confused in the switch statement. What will be role(i.e, switch(role)
in core/applicationmodel.cpp)?
If I can know that I believe I can call setNameDisplayOrder(displayorder) there
and return the value there.
I hope you got my point. If you need patch of my existing work, I can post that
too.
- Sujith
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/#review654
---
On 2009-03-27 12:37:45, Sujith H wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/441/
---
(Updated 2009-03-27 12:37:45)
Review request for Plasma.
Summary
---
As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia
section he/she can see Audio Player - Amarok. But he requested it to be in
other way Amarok - Audio Player. Hence as an initial step he asked me to
add a check box similar to Switch tabs on hover. I had added a check box
for this. I am a newbie in KDE. Hence would like to know what next should I
do to accomplish the task.
Diffs
-
/trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp
945188
Diff: http://reviewboard.kde.org/r/441/diff
Testing
---
I had compiled the above patch in my build directory. It compiled without any
errors.
Thanks,
Sujith
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: As per discussion in IRC
Hi, always good seeing somebody hacking on plasma, welcome :) can you publish the patch to reviewboard.kde.org? makes very easy for everyone reviewing and commenting the patch I can do that. But am a newbie to KDE. Hence Aron suggested me to do a first task. If someone clicks on launcher, in the Amarok one sees Audio Player and in the next line Amarok. It would be nice if this gets changed to Amarok - Audio Player. Hence he asked me to add a check box similar to switch tabs on hover in the plasma/applets/kickoff/applet/applet.cpp. This patch is regarding that. Now I am waiting what to do next. Since am in the initail stage of learning C++ and Qt, I need a little help. Hence I posted the patch. Sujith H -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- Review request for Plasma. Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs - kdebase/workspace/plasma/applets/kickoff/applet/workspace/plasma/applets/kickoff/applet/applet.cpp 945188 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: As per discussion in IRC
On Sat, Mar 28, 2009 at 12:13 AM, Artur Souza(MoRpHeUz) morph...@openbossa.org wrote: Hey! First of all: welcome to plasma and kde! =) Thank You :) On Friday 27 March 2009 15:25:15 sujith h wrote: can you publish the patch to reviewboard.kde.org? makes very easy for everyone reviewing and commenting the patch Just go to http://reviewboard.kde.org and register yourself. This is a web tool to make it easier to review patches and so on. It would help with future patches and we can help you to use the tool if you have any questions ;) Here is the link of the patch in reviewboard: http://reviewboard.kde.org/r/441/ -- സുജിത് ഹരിദാസന് Bangalore http://fci.wikia.com/wiki/Anti-DRM-Campaign Blog http://sujithh.info ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-03-27 12:28:22.628368) Review request for Plasma. Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs (updated) - workspace/plasma/applets/kickoff/applet/workspace/plasma/applets/kickoff/applet/applet.cpp 945188 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Patch regarding IRC discussion with Aron Seigo(its related to the first step, for the task given to me)
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/441/ --- (Updated 2009-03-27 12:37:45.873892) Review request for Plasma. Summary --- As per Aron Seigo's suggestion in the launcher when one clicks the Multimedia section he/she can see Audio Player - Amarok. But he requested it to be in other way Amarok - Audio Player. Hence as an initial step he asked me to add a check box similar to Switch tabs on hover. I had added a check box for this. I am a newbie in KDE. Hence would like to know what next should I do to accomplish the task. Diffs (updated) - /trunk/KDE/kdebase/workspace/plasma/applets/kickoff/applet/applet.cpp 945188 Diff: http://reviewboard.kde.org/r/441/diff Testing --- I had compiled the above patch in my build directory. It compiled without any errors. Thanks, Sujith ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
