Re: Review Request 115162: Launch single instance of plasma-mediacenter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/ --- (Updated Sept. 22, 2016, 8:37 p.m.) Status -- This change has been discarded. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched. Diffs - shells/newshell/CMakeLists.txt 60949df shells/newshell/application.h PRE-CREATION shells/newshell/application.cpp PRE-CREATION shells/newshell/main.cpp 9fd5df3 shells/newshell/mainwindow.h 5e0753e shells/newshell/mainwindow.cpp 1bf56ac shells/newshell/plasma-mediacenter.desktop c3c5781 Diff: https://git.reviewboard.kde.org/r/115162/diff/ Testing --- Tests done using konsole: a) Open a tab and launch pmc. b) Open another tab and try to launch another instance of pmc. c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running. Tests done using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith Haridasan
Re: Review Request 119015: Fixing full screen settings on Plasma Mediacenter exit
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119015/ --- (Updated July 3, 2014, 2:02 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch fixes the full screen settings of plasma-mediacenter during exit. Though its bit hackish which I had done. I would like to make this done better. With this change the pmc will save the fullscreen settings before exit. Diffs - browsingbackends/utility/exit/CMakeLists.txt 48d12a7 browsingbackends/utility/exit/exitbackend.cpp 9fe6cad shells/newshell/mainwindow.cpp 97655d8 Diff: https://git.reviewboard.kde.org/r/119015/diff/ Testing --- Done testing with fullscreen enabled and exit fullscreen disabled and exit. Both results were as expected. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118092: Left and right movement in All music
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- (Updated May 17, 2014, 7:38 a.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 334148 http://bugs.kde.org/show_bug.cgi?id=334148 Repository: plasma-mediacenter Description --- Left and right movement in All Music - Songs section. Now user can navigate left and right when in the songs section. And this is applicable only to the songs section. Diffs - components/listbrowser/ListBrowser.qml 202d406 Diff: https://git.reviewboard.kde.org/r/118092/diff/ Testing --- 1) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118092: Left and right movement in All music
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- (Updated May 16, 2014, 6:36 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Added a check if listBrowserRoot.topSibling.buttons, is defined. If defined then switch the focus on to the tabbar. Bugs: 334148 http://bugs.kde.org/show_bug.cgi?id=334148 Repository: plasma-mediacenter Description --- Left and right movement in All Music - Songs section. Now user can navigate left and right when in the songs section. And this is applicable only to the songs section. Diffs (updated) - components/listbrowser/ListBrowser.qml 202d406 Diff: https://git.reviewboard.kde.org/r/118092/diff/ Testing --- 1) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118092: Left and right movement in All music
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- (Updated May 16, 2014, 3:14 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Fixed the issue of tabbar focus, which caused user to press right/left key twice. Now user can navigate safely with single left/right click. Bugs: 334148 http://bugs.kde.org/show_bug.cgi?id=334148 Repository: plasma-mediacenter Description --- Left and right movement in All Music - Songs section. Now user can navigate left and right when in the songs section. And this is applicable only to the songs section. Diffs (updated) - components/listbrowser/ListBrowser.qml 202d406 Diff: https://git.reviewboard.kde.org/r/118092/diff/ Testing --- 1) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 118092: Left and right movement in All music
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- (Updated May 16, 2014, 3:18 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Remove tabbutton.pressed. Its not required. Bugs: 334148 http://bugs.kde.org/show_bug.cgi?id=334148 Repository: plasma-mediacenter Description --- Left and right movement in All Music - Songs section. Now user can navigate left and right when in the songs section. And this is applicable only to the songs section. Diffs (updated) - components/listbrowser/ListBrowser.qml 202d406 Diff: https://git.reviewboard.kde.org/r/118092/diff/ Testing --- 1) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 118092: Left and right movement in All music
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118092/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Bugs: 334148 http://bugs.kde.org/show_bug.cgi?id=334148 Repository: plasma-mediacenter Description --- Left and right movement in All Music - Songs section. Now user can navigate left and right when in the songs section. And this is applicable only to the songs section. Diffs - components/listbrowser/ListBrowser.qml 202d406 Diff: https://git.reviewboard.kde.org/r/118092/diff/ Testing --- 1) Use down arrow key to reach songs. 2) Press left/right arrow key. 3) Press left/right arrow key(for some reason we have to press the same key twice). 4) User reaches Artists if pressed left or Albums if pressed right. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 117691: Unload libplasma after using it in Plasma Media Center
On April 23, 2014, 11:08 p.m., Albert Astals Cid wrote: Seems to be an ulra-hack, but if it works, i guess you should commit it if it really helps your users to be able to use your product. Maybe adding a big TODO somewhere to recheck if this is needed later on or something. Shantanu Tushar wrote: Our current release is 1.2 and 1.3 will be released in June, these two will need this hack. After that we will move to a Qt5/KF5 port where we will not need this. I was also wondering if instead of actually committing this to the repo, we just keep this as a patch for distros to apply. Thoughts? Bhushan Shah wrote: I was also wondering if instead of actually committing this to the repo, we just keep this as a patch for distros to apply. Thoughts? +1, Also if possible some CMake option which enable plasmaadapter, so that they don't have to patch but just add cmake flag during configure. I too agree with Shantanu Tushar. - Sujith --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/#review56339 --- On April 22, 2014, 7:53 p.m., Sinny Kumari wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117691/ --- (Updated April 22, 2014, 7:53 p.m.) Review request for Plasma and Albert Astals Cid. Repository: plasma-mediacenter Description --- In Kubuntu 14.04 release, we found that Plasma Media Center was unable to play video/audio files. Reason behind it was PMC was linking with libplasma and QtMultimediaKit. libplasma links with libgstreamer1.0 while QtMultimediaKit links with libgstreamer0.10. This patch loads libplasma and unloads it after we are done as suggested on http://lists.kde.org/?l=kde-develm=139811564632441w=2 . Diffs - libs/plasmaadapter/plasmaadapter.cpp PRE-CREATION libs/plasmaadapter/CMakeLists.txt PRE-CREATION libs/CMakeLists.txt 7e0a9aa shells/newshell/CMakeLists.txt 9d9ea29 shells/newshell/mainwindow.h eb2b276 shells/newshell/mainwindow.cpp 9735a0a Diff: https://git.reviewboard.kde.org/r/117691/diff/ Testing --- Able to play audio/video on Kubuntu 14.04 and Fedora 19. Thanks, Sinny Kumari ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116898: Get rid of unnecessary Q_INVOKABLE declarations
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/#review53430 --- Ship it! Looks good to me :) - Sujith Haridasan On March 19, 2014, 12:49 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116898/ --- (Updated March 19, 2014, 12:49 p.m.) Review request for Plasma and Sujith Haridasan. Repository: plasma-mediacenter Description --- Methods supposed to be used as READ of Q_PROPERTY properties need not be invokable. Same goes for slots. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mpris2.h 0df64f4 libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/main.cpp bab6915 shells/newshell/mainwindow.cpp d2d71d4 Diff: https://git.reviewboard.kde.org/r/116898/diff/ Testing --- Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116907: Implemented Player MPRIS spec adaptor
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/#review53474 --- Ashish can you explain why do we need session bus for every single adaptor? Just wanted to know what advantage would that make? - Sujith Haridasan On March 19, 2014, 5:22 p.m., Ashish Madeti wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116907/ --- (Updated March 19, 2014, 5:22 p.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Implemented Player DBus adaptor of MPRIS specifications for Plasma Mediacenter. Specification reference: http://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html Some more work needs to be done in the adaptor which I plan to do soon. Diffs - libs/mpris2/mediaplayer2.h e68bc5c libs/mpris2/mediaplayer2.cpp ff96618 libs/mpris2/mediaplayer2player.h 203d681 libs/mpris2/mediaplayer2player.cpp 7871efa libs/mpris2/mpris2.cpp a8ad3ef shells/newshell/mainwindow.cpp d2d71d4 shells/newshell/package/contents/ui/mediacenter.qml bac33c2 Diff: https://git.reviewboard.kde.org/r/116907/diff/ Testing --- Tested with qdbusviewer, the properties and methods are working fine. Thanks, Ashish Madeti ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
On March 3, 2014, 6:01 a.m., Sujith Haridasan wrote: Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the Play All starts working as per my observation. Let me know if I am wrong. Harshit Agarwal wrote: Test Cases: 1. With an pre-empty playlist, added videos from a folder on the local drive. Result: The videos get added on clicking the PlayAll Button, and the first video starts playing, window remains in the file browser only. 2. With a pre-filled playlist, and some video playing from the playlist, went to another folder and clicked PlayAll to a new set of videos. They get added to the existing playlist and the video continues without breaking. 3. With a single video playing from the local drive, and an empty playlist before, clicked PlayAll on a list of videos from a folder. They get added to the playlist, but do not disturb the current video playing. Launch pmc and then try to go to All Music. And then click on Play All. See if that solves the problem? - Sujith --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review51736 --- On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 2, 2014, 10:53 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 116554: Implementation of autoplay when the PlayAll button in pressed
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/#review51736 --- Harshit, thanks for picking up the bug and I appreciate your effort. I would like to know every single step you had done as test case. I am pretty sure this is not a one liner fix. Only when the playlist frame gets into the stack, the Play All starts working as per my observation. Let me know if I am wrong. - Sujith Haridasan On March 2, 2014, 10:53 p.m., Harshit Agarwal wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116554/ --- (Updated March 2, 2014, 10:53 p.m.) Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- Referring to Bug #331040 The functionality of the media starting to play on the press of the Play All button has been implemented. It has been noted and implemented that the media doesn't start over when new songs/videos are added to an existing playlist. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp faaafa7 Diff: https://git.reviewboard.kde.org/r/116554/diff/ Testing --- The testing has been done through various test scenarios. Thanks, Harshit Agarwal ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115764: Make playlist model aware of currently playing media
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/#review50008 --- Tested with my recent patches with this patch. It doesn't break. Hence I am ok with this change. - Sujith Haridasan On Feb. 15, 2014, 5:24 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115764/ --- (Updated Feb. 15, 2014, 5:24 p.m.) Review request for Plasma, Sinny Kumari and Sujith Haridasan. Repository: plasma-mediacenter Description --- We have lots of issues because of the fact that the playlist model is not aware of what is playing right now and what is current index for the ListView. Additionally logic was thrown here and there in C++ and QML. This patch makes the model aware of the conect of currently playing index and it also makes sure that the model is in control of what is playing and how to play next/previous. This patch should not break any existing functionality except that changing playlist will make the current media to stop. This is to have consistency in what is playing and what the model can deduce it is playing. This will be improved in an upcoming patch but other things should keep working. Diffs - libs/mediacenter/playlistmodel.cpp 9c1dea9 mediaelements/playlist/MultiplePlaylists.qml d94fe6e mediaelements/playlist/Playlist.qml fd83c21 mediaelements/playlist/PlaylistDelegate.qml e1bd31d shells/newshell/application.cpp adc95dc shells/newshell/mainwindow.h d918e3d shells/newshell/mainwindow.cpp 7f7f31d shells/newshell/package/contents/ui/mediacenter.qml b6cb87c libs/mediacenter/multipleplaylistmodel.h 06b64df libs/mediacenter/multipleplaylistmodel.cpp f2c9246 libs/mediacenter/playlistmodel.h f79f814 Diff: https://git.reviewboard.kde.org/r/115764/diff/ Testing --- Tested with usual playback and with passing multiple files as command line parameters. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.
On Feb. 5, 2014, 5 p.m., Shantanu Tushar wrote: Works fine as far as the behavior is concerned. However on a personal note, I am very scared of the complexity we are bringing with this as well as the complexity we have from review #114892. Hope we can get rid of all this and do these in a much cleaner way some day. Believe me, we will do it. Even I am not comfortable to touch these many files for implementing minor features. - Sujith --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/#review49053 --- On Feb. 3, 2014, 3:53 p.m., Sujith Haridasan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/ --- (Updated Feb. 3, 2014, 3:53 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch should be applied on branch remotes/origin/sujith-playlistrefactor-1instance of pmc. This patch will help to add songs or videos to an already running instance ( or the single instance ) of pmc. Diffs - shells/newshell/application.cpp 2d1901b libs/mediacenter/playlistmodel.cpp 4b3cbc4 shells/newshell/mainwindow.h 3810fa0 shells/newshell/mainwindow.cpp b9671c3 Diff: https://git.reviewboard.kde.org/r/115447/diff/ Testing --- 1) Launch dolphin. 2) Start playing a song or video by clicking open with option in dolphin. 3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter. 4) User can see them automatically added to Misc playlist. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/ --- (Updated Feb. 5, 2014, 5:36 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch should be applied on branch remotes/origin/sujith-playlistrefactor-1instance of pmc. This patch will help to add songs or videos to an already running instance ( or the single instance ) of pmc. Diffs - shells/newshell/application.cpp 2d1901b libs/mediacenter/playlistmodel.cpp 4b3cbc4 shells/newshell/mainwindow.h 3810fa0 shells/newshell/mainwindow.cpp b9671c3 Diff: https://git.reviewboard.kde.org/r/115447/diff/ Testing --- 1) Launch dolphin. 2) Start playing a song or video by clicking open with option in dolphin. 3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter. 4) User can see them automatically added to Misc playlist. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 115447: Add songs or videos to Misc playlist while pmc is running.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- This patch should be applied on branch remotes/origin/sujith-playlistrefactor-1instance of pmc. This patch will help to add songs or videos to an already running instance ( or the single instance ) of pmc. Diffs - libs/mediacenter/playlistmodel.cpp 4b3cbc4 shells/newshell/application.cpp 2d1901b shells/newshell/mainwindow.h 3810fa0 shells/newshell/mainwindow.cpp b9671c3 Diff: https://git.reviewboard.kde.org/r/115447/diff/ Testing --- 1) Launch dolphin. 2) Start playing a song or video by clicking open with option in dolphin. 3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter. 4) User can see them automatically added to Misc playlist. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115447: Add songs or videos to Misc playlist while pmc is running.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115447/ --- (Updated Feb. 3, 2014, 3:53 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Small code cleanup. Removing qDebug. Repository: plasma-mediacenter Description --- This patch should be applied on branch remotes/origin/sujith-playlistrefactor-1instance of pmc. This patch will help to add songs or videos to an already running instance ( or the single instance ) of pmc. Diffs (updated) - shells/newshell/application.cpp 2d1901b libs/mediacenter/playlistmodel.cpp 4b3cbc4 shells/newshell/mainwindow.h 3810fa0 shells/newshell/mainwindow.cpp b9671c3 Diff: https://git.reviewboard.kde.org/r/115447/diff/ Testing --- 1) Launch dolphin. 2) Start playing a song or video by clicking open with option in dolphin. 3) Select another songs or videos from dolphin and try to open them with plasma-mediacenter. 4) User can see them automatically added to Misc playlist. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115162: Launch single instance of plasma-mediacenter
On Jan. 21, 2014, 5:58 p.m., Shantanu Tushar wrote: I couldn't try it right now but I have this doubt. If there is already a PMC instance running and open a file from Dolphin, does the file indeed start playing? What I meant to say is if PMC is already running and if user tries to open a file from Dolphin then there will be only one instance running which will be the first running instance. And hence the file tried to open via Dolphin has no effect. So nothing happens to running instance. - Sujith --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/#review47915 --- On Jan. 21, 2014, 6:44 a.m., Sujith Haridasan wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/ --- (Updated Jan. 21, 2014, 6:44 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched. Diffs - shells/newshell/CMakeLists.txt 60949df shells/newshell/application.h PRE-CREATION shells/newshell/application.cpp PRE-CREATION shells/newshell/main.cpp 9fd5df3 shells/newshell/plasma-mediacenter.desktop c3c5781 Diff: https://git.reviewboard.kde.org/r/115162/diff/ Testing --- Tests done using konsole: a) Open a tab and launch pmc. b) Open another tab and try to launch another instance of pmc. c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running. Tests done using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115162: Launch single instance of plasma-mediacenter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/ --- (Updated Jan. 22, 2014, 6:38 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Modified the code to address the issues pointed out by Shantanu. Repository: plasma-mediacenter Description --- Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched. Diffs (updated) - shells/newshell/application.h PRE-CREATION shells/newshell/application.cpp PRE-CREATION shells/newshell/main.cpp 9fd5df3 shells/newshell/mainwindow.h 5e0753e shells/newshell/mainwindow.cpp 1bf56ac shells/newshell/plasma-mediacenter.desktop c3c5781 shells/newshell/CMakeLists.txt 60949df Diff: https://git.reviewboard.kde.org/r/115162/diff/ Testing --- Tests done using konsole: a) Open a tab and launch pmc. b) Open another tab and try to launch another instance of pmc. c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running. Tests done using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 115162: Launch single instance of plams-mediacenter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched. Diffs - shells/newshell/CMakeLists.txt 60949df shells/newshell/application.h PRE-CREATION shells/newshell/application.cpp PRE-CREATION shells/newshell/main.cpp 9fd5df3 shells/newshell/plasma-mediacenter.desktop c3c5781 Diff: https://git.reviewboard.kde.org/r/115162/diff/ Testing --- Tests done using konsole: a) Open a tab and launch pmc. b) Open another tab and try to launch another instance of pmc. c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running. Tests done using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 115162: Launch single instance of plasma-mediacenter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115162/ --- (Updated Jan. 21, 2014, 6:44 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Fixing typo in the summary. Summary (updated) - Launch single instance of plasma-mediacenter Repository: plasma-mediacenter Description --- Launching single instance of plasma-mediacenter. Using KUniqueApplication only single instance of plasma-mediacenter is launched. Diffs - shells/newshell/CMakeLists.txt 60949df shells/newshell/application.h PRE-CREATION shells/newshell/application.cpp PRE-CREATION shells/newshell/main.cpp 9fd5df3 shells/newshell/plasma-mediacenter.desktop c3c5781 Diff: https://git.reviewboard.kde.org/r/115162/diff/ Testing --- Tests done using konsole: a) Open a tab and launch pmc. b) Open another tab and try to launch another instance of pmc. c) After executing (b) pmc wont launch because already another instance of pmc from (a) is already running. Tests done using Dolphin: a) Go to the music folder and right click on the file to be played. Click open with and launch pmc. b) Try to open another file using same step as (a) c) After executing (b) wait for few seconds and you can see that only single instance of (a) will be running. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114892/ --- (Updated Jan. 9, 2014, 5:09 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- PMC can play songs from the command line or when selected from file browsers like Dolphin( using Open With ). PMC creates a separate playlist called Misc which will store the files which are tried to open from command line or so. Name given for the playlist is a temperory one (Misc). We can discuss here and rename it to something meaningful. I have tested this functionality and it works. Diffs - libs/mediacenter/multipleplaylistmodel.h 30b317b libs/mediacenter/multipleplaylistmodel.cpp d52fa66 libs/mediacenter/playlistmodel.h 3993ac3 libs/mediacenter/playlistmodel.cpp 00a0cee mediaelements/playlist/MultiplePlaylists.qml 42877f0 shells/newshell/mainwindow.cpp b2793df Diff: https://git.reviewboard.kde.org/r/114892/diff/ Testing --- Open pmc from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114892/ --- (Updated Jan. 8, 2014, 6:22 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Updated the patch by sharing the code for calculating the path. Repository: plasma-mediacenter Description --- PMC can play songs from the command line or when selected from file browsers like Dolphin( using Open With ). PMC creates a separate playlist called Misc which will store the files which are tried to open from command line or so. Name given for the playlist is a temperory one (Misc). We can discuss here and rename it to something meaningful. I have tested this functionality and it works. Diffs (updated) - libs/mediacenter/multipleplaylistmodel.h 30b317b libs/mediacenter/multipleplaylistmodel.cpp d52fa66 libs/mediacenter/playlistmodel.h 3993ac3 libs/mediacenter/playlistmodel.cpp 00a0cee mediaelements/playlist/MultiplePlaylists.qml 42877f0 shells/newshell/mainwindow.cpp b2793df Diff: https://git.reviewboard.kde.org/r/114892/diff/ Testing --- Open pmc from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114892/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- PMC can play songs from the command line or when selected from file browsers like Dolphin( using Open With ). PMC creates a separate playlist called Misc which will store the files which are tried to open from command line or so. Name given for the playlist is a temperory one (Misc). We can discuss here and rename it to something meaningful. I have tested this functionality and it works. Diffs - libs/mediacenter/playlistmodel.h 3993ac3 libs/mediacenter/playlistmodel.cpp 00a0cee mediaelements/playlist/MultiplePlaylists.qml 42877f0 shells/newshell/mainwindow.cpp b2793df Diff: https://git.reviewboard.kde.org/r/114892/diff/ Testing --- Open pmc from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114892: Plasma-mediacenter plays songs or videos: passed as arguments
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114892/ --- (Updated Jan. 8, 2014, 6:09 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- This patch fixes the following issues addressed in the previous review: a) When a file played through command line or Dolphin, the focus gets automatically to Misc playlist. b) Removed the config setting mentioned by shantanu and implemented it in other way. Let me know if this solution sounds ok. Repository: plasma-mediacenter Description --- PMC can play songs from the command line or when selected from file browsers like Dolphin( using Open With ). PMC creates a separate playlist called Misc which will store the files which are tried to open from command line or so. Name given for the playlist is a temperory one (Misc). We can discuss here and rename it to something meaningful. I have tested this functionality and it works. Diffs (updated) - shells/newshell/mainwindow.cpp b2793df mediaelements/playlist/MultiplePlaylists.qml 42877f0 libs/mediacenter/multipleplaylistmodel.h 30b317b libs/mediacenter/playlistmodel.cpp 00a0cee libs/mediacenter/playlistmodel.h 3993ac3 libs/mediacenter/multipleplaylistmodel.cpp d52fa66 Diff: https://git.reviewboard.kde.org/r/114892/diff/ Testing --- Open pmc from the command line (or from Dolphin) with multiple files to be opened: 1) PMC starts playing the songs/videos with the ones passed. With Dolphin I have tested with only one file and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114741: Add time duration to media item for youtube videos.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114741/#review46472 --- First of all a big thanks to Sudhendhu for the effort. Good job. I tested the basic functionality like viewing the thumbnail and playing the video in openSUSE 13.1. It works like charm. So according to me this should go in. I give final say to Sinny and Shantanu. - Sujith Haridasan On Dec. 31, 2013, 6:46 a.m., Sudhendu Kumar wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114741/ --- (Updated Dec. 31, 2013, 6:46 a.m.) Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith Haridasan. Repository: plasma-mediacenter Description --- While searching for youtube videos from PMC, it was difficult to differentiate among the videos of same kind but different duration. This feature adds the duration of video at top-right corner of thumbnail. Snapshot added along with this review. Diffs - libs/mediacenter/mediacenter.h 7cdf285 libs/mediacenter/mediacenter.cpp 009ce22 browsingbackends/onlineservices/youtube/youtubemodel.cpp abb4f89 components/common/LabelOverlay.qml fd722af components/common/MediaItem.qml ccdc8c2 Diff: https://git.reviewboard.kde.org/r/114741/diff/ Testing --- Works good. File Attachments snapshot3.png https://git.reviewboard.kde.org/media/uploaded/files/2013/12/30/a1194a19-4412-43cf-92ff-3bf150bbd38c__snapshot3.png Thanks, Sudhendu Kumar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114482: Plasma-mediacenter remember last played playlist
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114482/ --- (Updated Dec. 16, 2013, 11:49 a.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Forgot to rebase the development branch. Now had updated the diff. Repository: plasma-mediacenter Description --- With this change Plasma-mediacenter now remembers the last playlist used by user. Hence if there are playlists a, b, c and user selects playlist b and listens songs in it and closes Plasma-mediacenter. When Plasma-mediacenter relaunched, user can see the playlist b opened in the view. Diffs (updated) - mediaelements/playlist/MultiplePlaylists.qml 42877f0 Diff: http://git.reviewboard.kde.org/r/114482/diff/ Testing --- Tested with 3 playlists and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114482: Plasma-mediacenter remember last played playlist
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114482/ --- (Updated Dec. 16, 2013, 6:08 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- With this change Plasma-mediacenter now remembers the last playlist used by user. Hence if there are playlists a, b, c and user selects playlist b and listens songs in it and closes Plasma-mediacenter. When Plasma-mediacenter relaunched, user can see the playlist b opened in the view. Diffs - mediaelements/playlist/MultiplePlaylists.qml 42877f0 Diff: http://git.reviewboard.kde.org/r/114482/diff/ Testing --- Tested with 3 playlists and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 114482: Plasma-mediacenter remember last played playlist
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114482/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- With this change Plasma-mediacenter now remembers the last playlist used by user. Hence if there are playlists a, b, c and user selects playlist b and listens songs in it and closes Plasma-mediacenter. When Plasma-mediacenter relaunched, user can see the playlist b opened in the view. Diffs - mediaelements/playlist/MultiplePlaylists.qml 42877f0 Diff: http://git.reviewboard.kde.org/r/114482/diff/ Testing --- Tested with 3 playlists and it worked properly. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114428: Replaced Text {} by Label {} using PlasmaComponents in mediaelements
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/#review45627
---
mediaelements/mediawelcome/HomeScreenFooter.qml
http://git.reviewboard.kde.org/r/114428/#comment32577
The PMC time doesn't get synced with desktop time. Can you tune this
further to get it synced?
mediaelements/mediawelcome/HomeScreenFooter.qml
http://git.reviewboard.kde.org/r/114428/#comment32576
Remove the white space
- Sujith Haridasan
On Dec. 13, 2013, 7:24 a.m., Heena Mahour wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/114428/
---
(Updated Dec. 13, 2013, 7:24 a.m.)
Review request for Plasma, Shantanu Tushar, Sinny Kumari, and Sujith
Haridasan.
Repository: plasma-mediacenter
Description
---
Replaced Text {} by PlasmaComponents.Label {}
Diffs
-
mediaelements/mediawelcome/BackendsListDelegate.qml e76af63
mediaelements/mediawelcome/HomeScreenFooter.qml d2c0eb7
mediaelements/mediawelcome/HomeScreenText.qml 35cd20a
Diff: http://git.reviewboard.kde.org/r/114428/diff/
Testing
---
works fine .
Thanks,
Heena Mahour
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114318: Adding keyboard navigation support for popupmenu.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114318/ --- (Updated Dec. 5, 2013, 5:35 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Adding keyboard navigation support for popup menu. Like a) using up/down arrow keys to navigate the popup menu. b) Pressing the return to do same action which a mouse click does on popupmenu. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 78d24c6 mediaelements/popupmenu/PopupMenu.qml 3ef66bb Diff: http://git.reviewboard.kde.org/r/114318/diff/ Testing --- Done testing both with mouse and keyboard. It worked fine. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114318: Adding keyboard navigation support for popupmenu.
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114318/ --- (Updated Dec. 5, 2013, 6:02 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Adding keyboard navigation support for popup menu. Like a) using up/down arrow keys to navigate the popup menu. b) Pressing the return to do same action which a mouse click does on popupmenu. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 78d24c6 mediaelements/popupmenu/PopupMenu.qml 3ef66bb Diff: http://git.reviewboard.kde.org/r/114318/diff/ Testing --- Done testing both with mouse and keyboard. It worked fine. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request 114223: Moving popupmenu to mediacenter and making it more generic
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114223/ --- Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Moving popup menu to mediacenter.qml and hence making it more generic. popup menu is pushed to the pagestack and hence it helps the user in keyboard navigation using Esc key too. Diffs - mediaelements/mediabrowser/MediaBrowser.qml ec76b99 shells/newshell/package/contents/ui/mediacenter.qml 860b794 Diff: http://git.reviewboard.kde.org/r/114223/diff/ Testing --- Tested by moving the popup menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114223/ --- (Updated Nov. 30, 2013, 5:07 p.m.) Review request for Plasma, Shantanu Tushar and Sinny Kumari. Changes --- Updated the new diff with the changes requested by @shantanu. Repository: plasma-mediacenter Description --- Moving popup menu to mediacenter.qml and hence making it more generic. popup menu is pushed to the pagestack and hence it helps the user in keyboard navigation using Esc key too. Diffs (updated) - shells/newshell/package/contents/ui/mediacenter.qml 860b794 mediaelements/popupmenu/PopupMenu.qml 6a832f7 mediaelements/mediabrowser/MediaBrowser.qml ec76b99 Diff: http://git.reviewboard.kde.org/r/114223/diff/ Testing --- Tested by moving the popup menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 114223: Moving popupmenu to mediacenter and making it more generic
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114223/ --- (Updated Nov. 30, 2013, 5:52 p.m.) Status -- This change has been marked as submitted. Review request for Plasma, Shantanu Tushar and Sinny Kumari. Repository: plasma-mediacenter Description --- Moving popup menu to mediacenter.qml and hence making it more generic. popup menu is pushed to the pagestack and hence it helps the user in keyboard navigation using Esc key too. Diffs - shells/newshell/package/contents/ui/mediacenter.qml 860b794 mediaelements/popupmenu/PopupMenu.qml 6a832f7 mediaelements/mediabrowser/MediaBrowser.qml ec76b99 Diff: http://git.reviewboard.kde.org/r/114223/diff/ Testing --- Tested by moving the popup menu to mediacenter by launching pmc. And also when pressed the Esc key it takes user to the files section of the media browser. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111187: Implement UI navigation using PageStack
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34898 --- Ship it! I loved the pagestack navigation. Good job. Didn't found major issues. - Sujith Haridasan On June 23, 2013, 6:16 a.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/ --- (Updated June 23, 2013, 6:16 a.m.) Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, and Sujith Haridasan. Description --- Using a PageStack for navigation in PMC has lots of benefits, the most important one is that it makes navigation flows easier to handle. We can remove old hacks, cleanup code that used to manage navigation. On the user's end, this brings more intuitive navigation from homescreen to browser, to playlist etc. Plus, keyboard navigation is much easier to do. This patch improves the UI flows and keyboard navigation. There are still few things that don't have key bindings, so only report issues that are regressions. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp 4e2b336 browsingbackends/localfiles/localfilesabstractmodel.cpp 158725c browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 074d5a8 browsingbackends/onlineservices/youtube/youtubebackend.desktop 648ead0 mediaelements/CMakeLists.txt 4894d36 mediaelements/imageviewer/ImageViewer.qml 27b93f5 mediaelements/imageviewer/PictureStrip.qml 187d687 mediaelements/imageviewer/PictureStripDelegate.qml 0c995bf mediaelements/keyhandler/KeyHandler.qml 0821c2c mediaelements/keyhandler/Logic.js b574221 mediaelements/mediabrowser/MediaBrowser.qml 04261aa mediaelements/mediabrowser/MediaItem.qml 2d6fac5 mediaelements/mediacontroller/MediaController.qml 5d62a0f mediaelements/mediaplayer/MediaPlayer.qml e6df21d mediaelements/mediawelcome/BackendsListDelegate.qml 7b9713a mediaelements/mediawelcome/MediaWelcome.qml 6c4554e mediaelements/playlist/Playlist.qml dfa6c8d mediaelements/playlist/PlaylistDelegate.qml a2b4fae mediaelements/qmldir 2d543c5 mediaelements/runtimedata/RuntimeData.qml 8524b47 shells/newshell/mainwindow.h 544618f shells/newshell/mainwindow.cpp 113748e shells/newshell/package/contents/ui/mediacenter.qml d533b60 Diff: http://git.reviewboard.kde.org/r/87/diff/ Testing --- Tested in my branch pagestack-shantanu, works awesome. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111187: Implement UI navigation using PageStack
On June 23, 2013, 10:32 a.m., Sinny Kumari wrote: mediaelements/imageviewer/ImageViewer.qml, line 61 http://git.reviewboard.kde.org/r/87/diff/2/?file=165265#file165265line61 Instead of adding MouseArea to Image element, it should be given to outer element FocusScope. Useful in case of small image. Agree with Sinny. - Hiding playlist is working by clicking the back button. It doesn't work with playlist icon. - Playlist looping is broken. - Sujith --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34901 --- On June 23, 2013, 9:06 a.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/ --- (Updated June 23, 2013, 9:06 a.m.) Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, and Sujith Haridasan. Description --- Using a PageStack for navigation in PMC has lots of benefits, the most important one is that it makes navigation flows easier to handle. We can remove old hacks, cleanup code that used to manage navigation. On the user's end, this brings more intuitive navigation from homescreen to browser, to playlist etc. Plus, keyboard navigation is much easier to do. This patch improves the UI flows and keyboard navigation. There are still few things that don't have key bindings, so only report issues that are regressions. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp 4e2b336 browsingbackends/localfiles/localfilesabstractmodel.cpp 158725c browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 074d5a8 browsingbackends/onlineservices/youtube/youtubebackend.desktop 648ead0 mediaelements/CMakeLists.txt 4894d36 mediaelements/imageviewer/ImageViewer.qml 27b93f5 mediaelements/imageviewer/PictureStrip.qml 187d687 mediaelements/imageviewer/PictureStripDelegate.qml 0c995bf mediaelements/keyhandler/KeyHandler.qml 0821c2c mediaelements/keyhandler/Logic.js b574221 mediaelements/mediabrowser/MediaBrowser.qml 04261aa mediaelements/mediabrowser/MediaItem.qml 2d6fac5 mediaelements/mediacontroller/MediaController.qml 5d62a0f mediaelements/mediaplayer/MediaPlayer.qml e6df21d mediaelements/mediawelcome/BackendsListDelegate.qml 7b9713a mediaelements/mediawelcome/MediaWelcome.qml 6c4554e mediaelements/playlist/Playlist.qml dfa6c8d mediaelements/playlist/PlaylistDelegate.qml a2b4fae mediaelements/qmldir 2d543c5 mediaelements/runtimedata/RuntimeData.qml 8524b47 shells/newshell/mainwindow.h 544618f shells/newshell/mainwindow.cpp 113748e shells/newshell/package/contents/ui/mediacenter.qml d533b60 Diff: http://git.reviewboard.kde.org/r/87/diff/ Testing --- Tested in my branch pagestack-shantanu, works awesome. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request 111187: Implement UI navigation using PageStack
On June 23, 2013, 3:45 p.m., Sinny Kumari wrote: According to me, Playlist icon should toggle. If user have to click on playlist button to view playlist, user will expect that clicking once again will hide it especially in touch devices. One more issue, related to https://bugs.kde.org/show_bug.cgi?id=318816 . Opening associated audio/video file in PMC, first homescreen appear then playlist and then video is visible. It looks little awkward. Expected behaviour: Only video player should be visible Shantanu Tushar wrote: There might be users who expect that the playlist button will toggle. However, they'll realize its not once they click it as there is no visual feedback of it being toggle. The reason it makes sense to use the back button is because now the playlist is a fully-fledged page rather than a toolbar-ish thing. The homescreen and playlist are added to the stack so to achieve consistency when the user presses back (or escape) from the playing video. This is intended behavior. Well if toggle can be taken off from the playlist button icon, then I believe it becomes more standardized. Which would be helpful for user( from user perspective). Becuase then back button will help him/her to get back to previous state. I hope I am not wrong? - Sujith --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/#review34911 --- On June 23, 2013, 2:26 p.m., Shantanu Tushar wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/87/ --- (Updated June 23, 2013, 2:26 p.m.) Review request for Plasma, Akshay Ratan, Fabian Riethmayer, Sinny Kumari, and Sujith Haridasan. Description --- Using a PageStack for navigation in PMC has lots of benefits, the most important one is that it makes navigation flows easier to handle. We can remove old hacks, cleanup code that used to manage navigation. On the user's end, this brings more intuitive navigation from homescreen to browser, to playlist etc. Plus, keyboard navigation is much easier to do. This patch improves the UI flows and keyboard navigation. There are still few things that don't have key bindings, so only report issues that are regressions. Diffs - browsingbackends/localfiles/localfilesabstractbackend.cpp 4e2b336 browsingbackends/localfiles/localfilesabstractmodel.cpp 158725c browsingbackends/metadatabackends/metadatamusicbackend/metadatamusiccomponents/MediaBrowser.qml 074d5a8 browsingbackends/onlineservices/youtube/youtubebackend.desktop 648ead0 mediaelements/CMakeLists.txt 4894d36 mediaelements/imageviewer/ImageViewer.qml 27b93f5 mediaelements/imageviewer/PictureStrip.qml 187d687 mediaelements/imageviewer/PictureStripDelegate.qml 0c995bf mediaelements/keyhandler/KeyHandler.qml 0821c2c mediaelements/keyhandler/Logic.js b574221 mediaelements/mediabrowser/MediaBrowser.qml 04261aa mediaelements/mediabrowser/MediaItem.qml 2d6fac5 mediaelements/mediacontroller/MediaController.qml 5d62a0f mediaelements/mediaplayer/MediaPlayer.qml e6df21d mediaelements/mediawelcome/BackendsListDelegate.qml 7b9713a mediaelements/mediawelcome/MediaWelcome.qml 6c4554e mediaelements/playlist/Playlist.qml dfa6c8d mediaelements/playlist/PlaylistDelegate.qml a2b4fae mediaelements/qmldir 2d543c5 mediaelements/runtimedata/RuntimeData.qml 8524b47 shells/newshell/mainwindow.h 544618f shells/newshell/mainwindow.cpp 113748e shells/newshell/package/contents/ui/mediacenter.qml d533b60 Diff: http://git.reviewboard.kde.org/r/87/diff/ Testing --- Tested in my branch pagestack-shantanu, works awesome. Thanks, Shantanu Tushar ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 15, 2011, 3:16 p.m.) Review request for Plasma. Changes --- Removed the comment of the dirlister.h from the previous patch. Description --- Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns. Diffs (updated) - plasma/applets/folderview/folderview.h 4896f07 plasma/applets/folderview/folderview.cpp 43d0511 Diff: http://git.reviewboard.kde.org/r/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 16, 2011, 6:20 a.m.) Review request for Plasma. Changes --- Updated the patch with changes: 1) Solid::Networking::shouldConnect() to shouldConnect() 2) Moving the connect to before line 408 if condition. Description --- Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns. Diffs (updated) - plasma/applets/folderview/folderview.h 4896f07 plasma/applets/folderview/folderview.cpp 43d0511 Diff: http://git.reviewboard.kde.org/r/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 15, 2011, 7:33 a.m.) Review request for Plasma. Changes --- Updated the patch with suggestions from Aaron Seigo and Shantanu. Description --- Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns. Diffs (updated) - plasma/applets/folderview/folderview.h 4896f07 plasma/applets/folderview/folderview.cpp 43d0511 Diff: http://git.reviewboard.kde.org/r/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp
On Dec. 12, 2011, 3:45 p.m., Aaron J. Seigo wrote: plasma/applets/folderview/folderview.cpp, lines 409-413 http://git.reviewboard.kde.org/r/103393/diff/1/?file=43162#file43162line409 this needs to be indented properly. also, instead of a knotification, which will appear somewhere unrelated, try using the setMessage method that comes with Plasma::Applet I hope you are pointing towards, showMessage. I couldn't find the setMessage in Plasma::Applet. Is it ok to have: Plasma::Applet::showMessage(KIcon(dialog-error),networkStatus,Plasma::ButtonOk) if you meant towards showMessage? - Sujith --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/#review8892 --- On Dec. 12, 2011, 3:40 p.m., Sujith Haridasan wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 12, 2011, 3:40 p.m.) Review request for Plasma. Description --- Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns. Diffs - plasma/applets/folderview/folderview.cpp 43d0511 Diff: http://git.reviewboard.kde.org/r/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- (Updated Dec. 14, 2011, 3:21 a.m.) Review request for Plasma. Changes --- Updated the patch with: 1)Solid::Networking::shouldConnect() if host is connected to the network. 2)Replaced the KNotification with Plasma::Applet::showMessage. 3)Checked the indentation. Description --- Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns. Diffs (updated) - plasma/applets/folderview/folderview.cpp 43d0511 Diff: http://git.reviewboard.kde.org/r/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Review Request: Adding patch for checking url is remote or not and check the network status as per the TODO in folderview.cpp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103393/ --- Review request for Plasma. Description --- Adding patch for the TODO, mentioned in the folderview.cpp file. This patch looks whether the url is local or remote. If its remote then checks for the network status of the host machine. If the host machine is not connected to the network then returns. Diffs - plasma/applets/folderview/folderview.cpp 43d0511 Diff: http://git.reviewboard.kde.org/r/103393/diff/diff Testing --- Tested by removing the host from the network and by adding the host to the network. Thanks, Sujith Haridasan ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
KDE/kdeplasma-addons/applets/bball
SVN commit 999070 by sujithh:
Fixing the Bball getting stuck at the bottom right/left corner.
Added a feature for making the ball bounce even if the ball is
released from the top right/left corner.
CCMAIL: plasma-devel@kde.org
M +24 -4 bball.cpp
M +1 -1 bball.h
--- trunk/KDE/kdeplasma-addons/applets/bball/bball.cpp #999069:999070
@@ -55,7 +55,10 @@
m_x_vel(0.0),
m_y_vel(0.0),
m_circum_vel(0.0),
- m_mouse_pressed(false)
+ m_mouse_pressed(false),
+ m_bottom_left(0),
+ m_bottom_right(0),
+ m_bottom(0)
{
setHasConfigurationInterface (true);
//TODO figure out why it is not good enough to set it here
@@ -284,6 +287,7 @@
m_y_vel *= -m_resitution;
adjustAngularVelocity( m_x_vel, m_circum_vel );
m_circum_vel = m_x_vel;
+ m_bottom=1;
}
inline void bballApplet::topCollision()
@@ -296,18 +300,31 @@
inline void bballApplet::rightCollision()
{
- m_position.moveRight (m_screen.right ());
+ m_position.moveRight (m_screen.right () - 0.1);
m_x_vel *= -m_resitution;
adjustAngularVelocity( m_y_vel, -m_circum_vel );
m_circum_vel = -m_y_vel;
+ if (m_bottom == 1)
+ {
+//kDebug() HIT Bottom AND RIGHT;
+m_x_vel = 0.0;
+m_bottom=0;
+m_bottom_right=1;
+ }
}
inline void bballApplet::leftCollision()
{
- m_position.moveLeft (m_screen.left ());
+ m_position.moveLeft (m_screen.left () + 0.1);
m_x_vel *= -m_resitution;
adjustAngularVelocity( m_y_vel, m_circum_vel );
m_circum_vel = m_y_vel;
+ if (m_bottom == 1)
+ {
+//kDebug() HIT Bottom AND LEFT;
+m_bottom=0;
+m_bottom_left=1;
+ }
}
inline void bballApplet::checkCollisions()
@@ -319,6 +336,7 @@
{
bottomCollision();
collision = true;
+kDebug() Bottom collision;
}
//ceiling
@@ -353,6 +371,9 @@
m_y_vel += m_gravity;
m_y_vel *= m_friction;
m_x_vel *= m_friction;
+ if (m_bottom_right == 1 || m_bottom_left == 1) {
+m_x_vel=0.0;
+ }
}
inline void bballApplet::moveAndRotateBall()
@@ -364,7 +385,6 @@
void bballApplet::goPhysics ()
{
-// kDebug() called;
if ( m_mouse_pressed ) {
return;
}
--- trunk/KDE/kdeplasma-addons/applets/bball/bball.h #999069:999070
@@ -75,7 +75,7 @@
inline void applyPhysics();
inline void moveAndRotateBall();
- int m_radius, m_old_radius, m_sound_volume, m_overlay_opacity;
+ int m_radius, m_old_radius, m_sound_volume, m_overlay_opacity,
m_bottom_left, m_bottom_right, m_bottom;
QRectF m_position, m_screen, m_pie_size;
QPointF m_old_mouse, m_mouse;
qreal m_angle;
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
branches/KDE/4.3/kdeplasma-addons/applets/bball
SVN commit 999083 by sujithh:
Backporting r999070 from trunk.
CCMAIL: plasma-devel@kde.org
M +24 -4 bball.cpp
M +1 -1 bball.h
--- branches/KDE/4.3/kdeplasma-addons/applets/bball/bball.cpp #999082:999083
@@ -55,7 +55,10 @@
m_x_vel(0.0),
m_y_vel(0.0),
m_circum_vel(0.0),
- m_mouse_pressed(false)
+ m_mouse_pressed(false),
+ m_bottom_left(0),
+ m_bottom_right(0),
+ m_bottom(0)
{
setHasConfigurationInterface (true);
//TODO figure out why it is not good enough to set it here
@@ -284,6 +287,7 @@
m_y_vel *= -m_resitution;
adjustAngularVelocity( m_x_vel, m_circum_vel );
m_circum_vel = m_x_vel;
+ m_bottom=1;
}
inline void bballApplet::topCollision()
@@ -296,18 +300,31 @@
inline void bballApplet::rightCollision()
{
- m_position.moveRight (m_screen.right ());
+ m_position.moveRight (m_screen.right () - 0.1);
m_x_vel *= -m_resitution;
adjustAngularVelocity( m_y_vel, -m_circum_vel );
m_circum_vel = -m_y_vel;
+ if (m_bottom == 1)
+ {
+//kDebug() HIT Bottom AND RIGHT;
+m_x_vel = 0.0;
+m_bottom=0;
+m_bottom_right=1;
+ }
}
inline void bballApplet::leftCollision()
{
- m_position.moveLeft (m_screen.left ());
+ m_position.moveLeft (m_screen.left () + 0.1);
m_x_vel *= -m_resitution;
adjustAngularVelocity( m_y_vel, m_circum_vel );
m_circum_vel = m_y_vel;
+ if (m_bottom == 1)
+ {
+//kDebug() HIT Bottom AND LEFT;
+m_bottom=0;
+m_bottom_left=1;
+ }
}
inline void bballApplet::checkCollisions()
@@ -319,6 +336,7 @@
{
bottomCollision();
collision = true;
+kDebug() Bottom collision;
}
//ceiling
@@ -353,6 +371,9 @@
m_y_vel += m_gravity;
m_y_vel *= m_friction;
m_x_vel *= m_friction;
+ if (m_bottom_right == 1 || m_bottom_left == 1) {
+m_x_vel=0.0;
+ }
}
inline void bballApplet::moveAndRotateBall()
@@ -364,7 +385,6 @@
void bballApplet::goPhysics ()
{
-// kDebug() called;
if ( m_mouse_pressed ) {
return;
}
--- branches/KDE/4.3/kdeplasma-addons/applets/bball/bball.h #999082:999083
@@ -75,7 +75,7 @@
inline void applyPhysics();
inline void moveAndRotateBall();
- int m_radius, m_old_radius, m_sound_volume, m_overlay_opacity;
+ int m_radius, m_old_radius, m_sound_volume, m_overlay_opacity,
m_bottom_left, m_bottom_right, m_bottom;
QRectF m_position, m_screen, m_pie_size;
QPointF m_old_mouse, m_mouse;
qreal m_angle;
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
