Re: Review Request 105319: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/105319/
---

(Updated Sept. 15, 2016, 11:33 a.m.)


Status
--

This change has been discarded.


Review request for Plasma.


Repository: kde-workspace


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: https://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

Re: Review Request 105319: DBus-interface for changing wallpapers

[Varun Herale]

> On Feb. 8, 2013, 9:48 p.m., Albert Astals Cid wrote:
> > Varun, it seems Aaron had some comments, can you have a look at them?

Yes, I am looking at it right now.


- Varun


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review27009
---


On July 1, 2012, 5:56 a.m., Varun Herale wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> ---
> 
> (Updated July 1, 2012, 5:56 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This patch is for hosting a dbus-interface that can be used to load any 
> installed wallpaper plugin onto current desktop containment. In case of 
> default "image" plugin, the path to the image can also be sent which will 
> change the wallpaper.  
> 
> 
> Diffs
> -
> 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
>   plasma/desktop/shell/plasmaapp.h 6ae0c89 
>   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
> 
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
> 
> 
> Testing
> ---
> 
> Tested on different activities and made sure it works for per-virtual desktop 
> containment.
> 
> Haven't tested on a system with multiple screens though, as I don't have 
> access to one. Could someone please test for that ?
> 
> 
> Thanks,
> 
> Varun Herale
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review18436
---


Can this be submitted ?

- Varun Herale


On July 1, 2012, 5:56 a.m., Varun Herale wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> ---
> 
> (Updated July 1, 2012, 5:56 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This patch is for hosting a dbus-interface that can be used to load any 
> installed wallpaper plugin onto current desktop containment. In case of 
> default "image" plugin, the path to the image can also be sent which will 
> change the wallpaper.  
> 
> 
> Diffs
> -
> 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
>   plasma/desktop/shell/plasmaapp.h 6ae0c89 
>   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
> 
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
> 
> 
> Testing
> ---
> 
> Tested on different activities and made sure it works for per-virtual desktop 
> containment.
> 
> Haven't tested on a system with multiple screens though, as I don't have 
> access to one. Could someone please test for that ?
> 
> 
> Thanks,
> 
> Varun Herale
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Adding an image to slideshow.

[Varun Herale]

>
>
> i think that would be a highly unexpected for the user as image files
> would end
> up copied seemingly randomly all over the place. no .. what needs to
> happen is
> that the wallpaper plugin needs to be fixed so that it remembers the added
> path
> correctly.
> (classic example of "fix, don't work around, the bug")


True, but I was thinking copying them to the folder will mean all the
concerned images are in one place. But I understand how that can cause
other problems.

How about adding another key to the config file which comes under
"slidepaths" ? This key could hold a list of all user-added images to the
current slideshow and if the user changes the slideshow folder the paths
can be cleared.

I think this should be best option if the added images are to be remembered
even after restart while plasma-desktop is loading. Or is there another way
to remember between sessions ?

--
Varun Herale
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---

(Updated July 1, 2012, 5:56 a.m.)


Review request for Plasma.


Changes
---

Changed so as not to expose Name and Mode.


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs (updated)
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: http://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

> On June 28, 2012, 4:48 p.m., Aaron J. Seigo wrote:
> > plasma/desktop/shell/plasmaapp.cpp, line 397
> > <http://git.reviewboard.kde.org/r/105319/diff/5/?file=70293#file70293line397>
> >
> > i would prefer it if the plugin name and mode were not exposed. the use 
> > case is "setting a wallpaper image" so let's implement that. 
> > 
> > the main problem with being able to set the name and mode is that not 
> > only are most of the plugins optional (just asking for fun breakage) but 
> > also require configuration.
> > 
> > so i would recommend a rather simpler setWallpaperImage(const QString 
> > &url).
> > 
> > it should probably do similar to what the drag and drop support does 
> > and if the url is not local then try to fetch it using KIO.

Doesn't the Image plugin support fetching url if it is not local ? So it is not 
needed for this function right ?

Also what about exposing the mode also - to be able to change between 
"SingleImage" and "Slideshow" mode ? Or should we make this just "SingleImage" ?


- Varun


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15226
---


On June 24, 2012, 3:47 p.m., Varun Herale wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> ---
> 
> (Updated June 24, 2012, 3:47 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This patch is for hosting a dbus-interface that can be used to load any 
> installed wallpaper plugin onto current desktop containment. In case of 
> default "image" plugin, the path to the image can also be sent which will 
> change the wallpaper.  
> 
> 
> Diffs
> -
> 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
>   plasma/desktop/shell/plasmaapp.h 6ae0c89 
>   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
> 
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
> 
> 
> Testing
> ---
> 
> Tested on different activities and made sure it works for per-virtual desktop 
> containment.
> 
> Haven't tested on a system with multiple screens though, as I don't have 
> access to one. Could someone please test for that ?
> 
> 
> Thanks,
> 
> Varun Herale
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Adding an image to slideshow.

[Varun Herale]

Hello,

This is regarding bug#302612 <https://bugs.kde.org/show_bug.cgi?id=302612>.

When a URL is added using setUrls(url), the path is temporarily added to
the "m_slideshowBackgrounds" list. But when the next slide is rendered this
member doesn't remember the path added. It goes back to only containing the
paths of images in the slideshow folder. So it is a good thing to copy the
image into the slideshow folder in this case ?

--
Varun Herale
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---

(Updated June 24, 2012, 3:47 p.m.)


Review request for Plasma.


Changes
---

Changed the code accordingly :)

In case of "Slideshow", it doesn't append the image in any case. Will raise a 
bug and check that.


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs (updated)
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: http://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

> On June 24, 2012, 1:41 a.m., David Edmundson wrote:
> > I think you've overcomplicated this:
> > 
> > Everything after currentContainment could be replaced with simply:
> > 
> > ---
> > currentContainment->setWallpaper(name, mode);
> > if (!path.isEmpty()) {
> > currentContainment->wallpaper()->setUrls(KUrl(path));
> > }
> > ---
> > 
> > if the name and mode haven't changed setWallpaper will do nothing.
> > if the plugin doesn't support setUrls it will do nothing, if it does - your 
> > API will work with it \o/.
> > Containment::setWallpaper appears to save when changing, same for setUrls 
> > on the plugin.
> > 
> > I tested the above and it saves and restores fine :)

When the name is "image" and mode is "Slideshow", image with path doesn't seem 
to be added to the slideshow. So I wasn't sure if using setUrls for all cases 
was a good idea. Is it okay to do that ?

As for the rest - It just didn't strike me to use setUrls after setWallpaper 
and that lead to over complication :P Learnt something. And will update the 
diff soon.


- Varun


---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/#review15052
---


On June 22, 2012, 2:36 p.m., Varun Herale wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105319/
> ---
> 
> (Updated June 22, 2012, 2:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Description
> ---
> 
> This patch is for hosting a dbus-interface that can be used to load any 
> installed wallpaper plugin onto current desktop containment. In case of 
> default "image" plugin, the path to the image can also be sent which will 
> change the wallpaper.  
> 
> 
> Diffs
> -
> 
>   plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
>   plasma/desktop/shell/plasmaapp.h 6ae0c89 
>   plasma/desktop/shell/plasmaapp.cpp 7abd8fc 
> 
> Diff: http://git.reviewboard.kde.org/r/105319/diff/
> 
> 
> Testing
> ---
> 
> Tested on different activities and made sure it works for per-virtual desktop 
> containment.
> 
> Haven't tested on a system with multiple screens though, as I don't have 
> access to one. Could someone please test for that ?
> 
> 
> Thanks,
> 
> Varun Herale
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---

(Updated June 22, 2012, 2:36 p.m.)


Review request for Plasma.


Changes
---

Yes, that line lead to leak. Sorry about that, missed it.. corrected it using 
the containment object obtained.


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs (updated)
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: http://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---

(Updated June 22, 2012, 2:07 a.m.)


Review request for Plasma.


Changes
---

Opps, my bad! Fixed the identation errors and also a couple of unnecessary 
lines.


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs (updated)
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: http://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---

(Updated June 21, 2012, 7:15 p.m.)


Review request for Plasma.


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs (updated)
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: http://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

> the ui and services are in the share-like-connect repository.
> it's still in playground because still needs improvements in the ui and
> backend sides.
> the api to advertise content to it is in kactivities tough, so available in
> 4.9 already.


Okay, thank you!

>please post it on http://reviewboard.kde.org .. i can't review a pastebin,
>sorry.
>btw, you may want to look at Corona::containmentForScreen().

Done! And thanks about Corona::containmentForScreen().
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request: DBus-interface for changing wallpapers

[Varun Herale]

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105319/
---

Review request for Plasma.


Description
---

This patch is for hosting a dbus-interface that can be used to load any 
installed wallpaper plugin onto current desktop containment. In case of default 
"image" plugin, the path to the image can also be sent which will change the 
wallpaper.  


Diffs
-

  plasma/desktop/shell/dbus/org.kde.plasma.App.xml eefce32 
  plasma/desktop/shell/plasmaapp.h 6ae0c89 
  plasma/desktop/shell/plasmaapp.cpp 7abd8fc 

Diff: http://git.reviewboard.kde.org/r/105319/diff/


Testing
---

Tested on different activities and made sure it works for per-virtual desktop 
containment.

Haven't tested on a system with multiple screens though, as I don't have access 
to one. Could someone please test for that ?


Thanks,

Varun Herale

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

>
> * will the feature work consistently (multiple screens, per-virtual desktop
> containments, etc..) and not just work for some configurations
>
>
I have written some code  for this. It hosts
a dbus-interface from which wallpaper plugins can be loaded. From what I've
tested it works for per-virtual desktop containments and should also work
with multiple screens. Please do review, it'll help with my understanding
of Plasma atleast.

crazy idea: what about using SLC for this? Like -> Use as wallpaper
>
> I am new here and I haven't come across this before. So please bear with
me. Is the feature currently available or is it being worked on right now ?
I only find Plasma::Mobile links on searching for it!

>From what I understand this will also help applications communicate with
plasma, am I right ?


> Yes, but this discussion started exactly because there's a need (justified
> or not) for a different solution. That's what that "fallback" referred to
> (again, think the non-drag enabled envs and/or the convenience mention
> previously).
>
> Yes, but if SLC helps applications communicate with plasma then
applications can provide their own solution for this problem. Where can I
find out more about this ?


>
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

>
> and how are you attempting to do this right now?
>
> Right now I am using DBus to find out the current activity and then the
"plasma-desktop-appletrc" config file to find the current containment
information. What I am trying to do is load the containment object using
the Plasma::Containment::restore() function, but it fails at this point - Link
1.
I was intending to try and change wallpaper after loading the containment
this way. I am not sure if this will work, but I didn't understand why
isContainment() was returning false even when it is a Plasma::Containment
object.

(the best way is probably to offer a dbus interface in plasma-desktop that then
> connects to the active wallpaper plugin ... which has a call for setting
> wallpapers by url)
>
> How about adding a DBus function to "plasmaapp.cpp " which can set any
wallpaper plugin into the current desktop containment as long as it is
installed ? I am working on the code for that right now. Will post in
reviewboard once completed!
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

>
> so this is meant to be a way to select an image from within digikam to be used
> as the desktop wallpaper?
>
> iow, you want the ability to set the desktop wallpaper from an application
> running outside of plasma-desktop?
>
>
Yes, exactly
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

> cool; how it supposed to work? pulling images at a given interval from a
> digikam album? or..?
>
>
The plugin hasn't been working since KDE4, so currently the aim is to get
it to work for a single image chosen from digikam albums. Once that is
implemented maybe slideshow feature can also be implemented
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

New Link 

The old one got deleted..

I am trying to implement wallpaper plugin for digikam as SoK project. Using
> an applet I am able to change the wallpaper but not otherwise as I need the
> current desktop containment object.
>
> I am trying to obtain that by creating a containment object and restoring
> from the config file. But the isContainment() is set to false in this case.
>
> I also tried using the static load function from Plasma::Applet, but
> because the desktop plugin has both Plasma/Applet and Plasma/Containment,
> the isContainment() is set to false this way too.
>
> Currently I have a Wallpaper object loaded this way and changed the Url and
> saved it back to the file. But as update signals are protected I can't
> change the wallpaper in realtime. If I can get the current containment
> object, I can use the Plasma::Containment::setWallpaper() function after
> saving the new config and it will update.
>
> Pastebin 
>
> Is there another way to change the wallpaper from an application ?
>
>
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

>
> how exactly are you doing this? can you share some code with us?
> no. what are you trying to accomplish? (there may be a better way to do
> whatever it is you are trying to do..)


I am trying to implement wallpaper plugin for digikam as SoK project. Using
an applet I am able to change the wallpaper but not otherwise as I need the
current desktop containment object.

I am trying to obtain that by creating a containment object and restoring
from the config file. But the isContainment() is set to false in this case.

I also tried using the static load function from Plasma::Applet, but
because the desktop plugin has both Plasma/Applet and Plasma/Containment,
the isContainment() is set to false this way too.

Currently I have a Wallpaper object loaded this way and changed the Url and
saved it back to the file. But as update signals are protected I can't
change the wallpaper in realtime. If I can get the current containment
object, I can use the Plasma::Containment::setWallpaper() function after
saving the new config and it will update.

Pastebin 

Is there another way to change the wallpaper from an application ?
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Plasma Containment default setting

[Varun Herale]

Hello,

I am trying to load the current desktop containment info from a
KConfigGroup object. But because by default the isContainment member is set
as false I am not able to do this.

Why is the isContainment member inherited from AppletPrivate class set as
false for an object of Containment Class ?

Also, is there any other way to load current desktop containment
information into a Containment object ?

-- 
- Varun Herale.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel