[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-16 Thread Martin Gräßlin 
graesslin added inline comments.

INLINE COMMENTS

> usta wrote in kwaylandintegration.cpp:57
> #include  removed and #include  isn't this also should be change ?

no? We try to not change unrelated code. The include of QGuiApplication is due 
to the usage of QGuiApplication::topLevelWindows. For this code it doesn't make 
any difference whether it's QCoreApplication or QGuiApplication. So there is no 
need to change it. The code is correct and a change would clutter up the commit.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  color-scheme-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3046

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: usta, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-16 Thread Ömer Fadıl Usta 
usta added inline comments.

INLINE COMMENTS

> graesslin wrote in kwaylandintegration.cpp:57
> this is completely unrelated code not touched in this change.

#include  removed and #include https://phabricator.kde.org/D3046

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: usta, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-16 Thread Martin Gräßlin 
graesslin added inline comments.

INLINE COMMENTS

> usta wrote in kwaylandintegration.cpp:57
> QCoreApplication ->  QGuiApplication

this is completely unrelated code not touched in this change.

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  color-scheme-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3046

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: usta, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D3046: Pass color scheme hint to Wayland compositor using window property

2016-10-16 Thread Ömer Fadıl Usta 
usta added a comment.


  In line 57  QCoreApplication -> QGuiApplication

INLINE COMMENTS

> kwaylandintegration.cpp:57
>  qputenv("QT_WAYLAND_DISABLE_WINDOWDECORATION", "1");
>  QCoreApplication::instance()->installEventFilter(this);
>  }

QCoreApplication ->  QGuiApplication

REPOSITORY
  rPLASMAINTEGRATION Integration for Qt applications in Plasma

BRANCH
  color-scheme-wayland

REVISION DETAIL
  https://phabricator.kde.org/D3046

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: graesslin, #plasma, sebas
Cc: usta, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas