Re: Breeze dark theme white edge outlines
On Thursday 02 October 2014 12:45:10 Andrew Lake wrote: Cool Marco! I'm totally fine with that as a solution instead of separate svgs. :-) Of course, you'll still have to decide if you like the white outlines on the dark theme or more subtle edge outlines. deep echo-y voiceThe decision is in your hands. muwahahaha! /deep echo-y voice Seriously though, while I wouldn't have proposed the more subtle outlines if I didn't think they look better, I'm totally cool with whatever the decision on this is from a visual standpoint. I think everyone knows the timelines we're working with, so I say just make and decision and go for it. :-) oki, so in the end i removed a bit of contrast, but the broder is still well visible -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze dark theme white edge outlines
No objections just a massive thumbs up! On Wednesday 01 October 2014 16.21.03 Andrew Lake wrote: For anyone using the breeze dark theme, I've been meaning for a while to make some adjustments so that the edges aren't quite so pronounced and high contrast. It looks this way because it's currently using the same svgs (and edge highlights) from the normal breeze theme svgs. I have changes ready to push to reduce that high contrast edge outline, but I wanted to check to see if there was anyone that was particularly wedded to the those white outlines before I do. I'd do up a screen shot but just imagine those bright white outlines turned all the way down. Holler if anyone has any objections. :-) Thanks, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze dark theme white edge outlines
On 02.10.2014 01:21, Andrew Lake wrote: Holler if anyone has any objections. :-) Personally I kind of like the white outlines. Not sure how to put it, they give kind of a cool retro-y vibe perhaps ;). I think they might actually fall into happy-accident territory, but I'm not married to them ... Thanks, Andrew Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze dark theme white edge outlines
On Thu, Oct 2, 2014 at 11:10 AM, Eike Hein h...@kde.org wrote: On 02.10.2014 01:21, Andrew Lake wrote: Holler if anyone has any objections. :-) Personally I kind of like the white outlines. Not sure how to put it, they give kind of a cool retro-y vibe perhaps ;). I think they might actually fall into happy-accident territory, but I'm not married to them ... Same here. I personally do like them, imo it gives some kind of visual connection to the white icons used in breeze-dark, but if you think the disadvantages are bigger, go ahead :) Cheers -- Martin Klapetek | KDE Developer ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze dark theme white edge outlines
On Wednesday 01 October 2014 16:21:03 Andrew Lake wrote: For anyone using the breeze dark theme, I've been meaning for a while to make some adjustments so that the edges aren't quite so pronounced and high contrast. It looks this way because it's currently using the same svgs (and edge highlights) from the normal breeze theme svgs. I have changes ready to push to reduce that high contrast edge outline, but I wanted to check to see if there was anyone that was particularly wedded to the those white outlines before I do. I'd do up a screen shot but just imagine those bright white outlines turned all the way down. Holler if anyone has any objections. :-) does the change involve duplicating the svgs? I quite like them as well, also i prefer duplication of images to be as little as possible (just yesterday i fixed some graphics glitches exactly in that, means next time work gets to be done double of the times) I am not that opposed to it, but if it has to be done i would prefer a way that doesn't duplicate svgs (that should be possible) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze dark theme white edge outlines
Thanks for the feedback. Given the collection of responses so far, I'll go ahead and leave the white outlines as they are. Regarding duplication of svgs. Yes, the changes I prepared had separate panel-background, dialog and tooltip svgs specifically for the dark theme. The main reason is that reflective properties of the edge of the material changes with color - brighter colors reflect more light, darker colors reflect less. So where as the Cardboard Grey of the normal Breeze theme needed a much brighter outline to better represent the quality of the edge, the dark grey of the breeze dark theme would need a much less bright outline. The current white outlines that we've grown to like are a happy accident of the much brighter outline needed for the normal theme. Now, we'll just say that those outlines are intentional. ;-) In any event, I think there may be only so much complexity that's worth it to avoid duplication of svgs. Beyond a certain point a theme of a different color is, in the end, just a different theme. And these themes are a couple of drunken grizzly bears to put together as is. :-) Thanks much for the feedback! Andrew [back to visual bug hunting] On Thu, Oct 2, 2014 at 2:25 AM, Marco Martin notm...@gmail.com wrote: On Wednesday 01 October 2014 16:21:03 Andrew Lake wrote: For anyone using the breeze dark theme, I've been meaning for a while to make some adjustments so that the edges aren't quite so pronounced and high contrast. It looks this way because it's currently using the same svgs (and edge highlights) from the normal breeze theme svgs. I have changes ready to push to reduce that high contrast edge outline, but I wanted to check to see if there was anyone that was particularly wedded to the those white outlines before I do. I'd do up a screen shot but just imagine those bright white outlines turned all the way down. Holler if anyone has any objections. :-) does the change involve duplicating the svgs? I quite like them as well, also i prefer duplication of images to be as little as possible (just yesterday i fixed some graphics glitches exactly in that, means next time work gets to be done double of the times) I am not that opposed to it, but if it has to be done i would prefer a way that doesn't duplicate svgs (that should be possible) -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze dark theme white edge outlines
On Thursday 02 October 2014 10:19:52 Andrew Lake wrote: Thanks for the feedback. Given the collection of responses so far, I'll go ahead and leave the white outlines as they are. Regarding duplication of svgs. Yes, the changes I prepared had separate panel-background, dialog and tooltip svgs specifically for the dark theme. I have an idea for a svg that should have automagically a pretty much solid white outline on breeze normal and a just a little bit brighter onbreeze-dark (attached) here only the top, topright and left elements are adjusted because lazyness, but if is a good concept i can finish it: there are two clones of the border pixel: one has the background color, solid (so gray/white on breeze and blackish on breeze-dark) then a second copy is on top of it, white/translucent, so will result in a dull white in the normal case, and a light gray in breeze-dark. -- Marco Martin___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Breeze dark theme white edge outlines
Cool Marco! I'm totally fine with that as a solution instead of separate svgs. :-) Of course, you'll still have to decide if you like the white outlines on the dark theme or more subtle edge outlines. deep echo-y voiceThe decision is in your hands. muwahahaha! /deep echo-y voice Seriously though, while I wouldn't have proposed the more subtle outlines if I didn't think they look better, I'm totally cool with whatever the decision on this is from a visual standpoint. I think everyone knows the timelines we're working with, so I say just make and decision and go for it. :-) Hope this helps! Andrew On Thu, Oct 2, 2014 at 11:13 AM, Marco Martin notm...@gmail.com wrote: On Thursday 02 October 2014 10:19:52 Andrew Lake wrote: Thanks for the feedback. Given the collection of responses so far, I'll go ahead and leave the white outlines as they are. Regarding duplication of svgs. Yes, the changes I prepared had separate panel-background, dialog and tooltip svgs specifically for the dark theme. I have an idea for a svg that should have automagically a pretty much solid white outline on breeze normal and a just a little bit brighter onbreeze-dark (attached) here only the top, topright and left elements are adjusted because lazyness, but if is a good concept i can finish it: there are two clones of the border pixel: one has the background color, solid (so gray/white on breeze and blackish on breeze-dark) then a second copy is on top of it, white/translucent, so will result in a dull white in the normal case, and a light gray in breeze-dark. -- Marco Martin ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Breeze dark theme white edge outlines
For anyone using the breeze dark theme, I've been meaning for a while to make some adjustments so that the edges aren't quite so pronounced and high contrast. It looks this way because it's currently using the same svgs (and edge highlights) from the normal breeze theme svgs. I have changes ready to push to reduce that high contrast edge outline, but I wanted to check to see if there was anyone that was particularly wedded to the those white outlines before I do. I'd do up a screen shot but just imagine those bright white outlines turned all the way down. Holler if anyone has any objections. :-) Thanks, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
