Bug 322820 - Playlist is not reachable from home screen

2014-03-03 Thread Ashish Madeti 
In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820

I have two solutions to the problem.

1. We can show the mediaController even on home screen (welcome screen).
It will have an added advantage (can be implemented in near future) of
directly playing the last selected playlist by clicking the play button on
welcome screen.

2. We can add a menu item for "Browse Playlists" on welcome screen for
music and videos.

I will try to implement whichever is better.

-- 
*Ashish Madeti*
2nd Year
Computer Science & Engineering
The LNM Institute of Information Technology
Jaipur, Rajasthan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Bug 322820 - Playlist is not reachable from home screen

2014-03-04 Thread Shantanu Tushar Jha 
Hi Ashish,

Solution 1 isn't very good because it brings unnecessary clutter to the
home screen. Solution 2 is what we should be going for, however to get a
menu item you'll have to create a new backend and this backend will need to
run some QML code to bring up the playlist. Right now backends cannot do
this, so in order to do this you'll have to add this capability to the
backend system.

Cheers,


On Mon, Mar 3, 2014 at 9:14 PM, Ashish Madeti  wrote:

> In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820
>
> I have two solutions to the problem.
>
> 1. We can show the mediaController even on home screen (welcome screen).
> It will have an added advantage (can be implemented in near future) of
> directly playing the last selected playlist by clicking the play button on
> welcome screen.
>
> 2. We can add a menu item for "Browse Playlists" on welcome screen for
> music and videos.
>
> I will try to implement whichever is better.
>
> --
> *Ashish Madeti*
> 2nd Year
> Computer Science & Engineering
> The LNM Institute of Information Technology
> Jaipur, Rajasthan
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>


-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Ashish Madeti 
Hi Shantanu,
If you think the 1st solution bring unnecessary clutter to the home screen
, we can make it auto-hide like on the now playing screen.

Another way to implement Solution 1, like if we presently click the empty
area in the top and there is a media player instance it goes to it, we can
make it go to the playlist page if there is no media player instance.


On 4 March 2014 22:36, Shantanu Tushar Jha  wrote:

> Hi Ashish,
>
> Solution 1 isn't very good because it brings unnecessary clutter to the
> home screen. Solution 2 is what we should be going for, however to get a
> menu item you'll have to create a new backend and this backend will need to
> run some QML code to bring up the playlist. Right now backends cannot do
> this, so in order to do this you'll have to add this capability to the
> backend system.
>
> Cheers,
>
>
> On Mon, Mar 3, 2014 at 9:14 PM, Ashish Madeti  wrote:
>
>>
>> In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820
>>
>> I have two solutions to the problem.
>>
>> 1. We can show the mediaController even on home screen (welcome screen).
>> It will have an added advantage (can be implemented in near future) of
>> directly playing the last selected playlist by clicking the play button on
>> welcome screen.
>>
>> 2. We can add a menu item for "Browse Playlists" on welcome screen for
>> music and videos.
>>
>> I will try to implement whichever is better.
>>
>>
>
>
> --
> Shantanu Tushar(UTC +0530)
> http://www.shantanutushar.com
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>


-- 
*Ashish Madeti*
2nd Year
Computer Science & Engineering
The LNM Institute of Information Technology
Jaipur, Rajasthan
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Shantanu Tushar Jha 
On Wed, Mar 5, 2014 at 2:53 PM, Ashish Madeti  wrote:

> Hi Shantanu,
> If you think the 1st solution bring unnecessary clutter to the home screen
> , we can make it auto-hide like on the now playing screen.
>
> Another way to implement Solution 1, like if we presently click the empty
> area in the top and there is a media player instance it goes to it, we can
> make it go to the playlist page if there is no media player instance.
>

This sounds good, try implementing it and see how it behaves.


>
>
> On 4 March 2014 22:36, Shantanu Tushar Jha  wrote:
>
>> Hi Ashish,
>>
>> Solution 1 isn't very good because it brings unnecessary clutter to the
>> home screen. Solution 2 is what we should be going for, however to get a
>> menu item you'll have to create a new backend and this backend will need to
>> run some QML code to bring up the playlist. Right now backends cannot do
>> this, so in order to do this you'll have to add this capability to the
>> backend system.
>>
>> Cheers,
>>
>>
>> On Mon, Mar 3, 2014 at 9:14 PM, Ashish Madeti wrote:
>>
>>>
>>> In reference to the bug : https://bugs.kde.org/show_bug.cgi?id=322820
>>>
>>> I have two solutions to the problem.
>>>
>>> 1. We can show the mediaController even on home screen (welcome screen).
>>> It will have an added advantage (can be implemented in near future) of
>>> directly playing the last selected playlist by clicking the play button on
>>> welcome screen.
>>>
>>> 2. We can add a menu item for "Browse Playlists" on welcome screen for
>>> music and videos.
>>>
>>> I will try to implement whichever is better.
>>>
>>>
>>
>>
>> --
>> Shantanu Tushar(UTC +0530)
>> http://www.shantanutushar.com
>>
>> ___
>> Plasma-devel mailing list
>> Plasma-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/plasma-devel
>>
>>
>
>
> --
> *Ashish Madeti*
> 2nd Year
> Computer Science & Engineering
> The LNM Institute of Information Technology
> Jaipur, Rajasthan
>
> ___
> Plasma-devel mailing list
> Plasma-devel@kde.org
> https://mail.kde.org/mailman/listinfo/plasma-devel
>
>


-- 
Shantanu Tushar(UTC +0530)
http://www.shantanutushar.com
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Ashish Madeti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---

Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Playlist was not reachable from home screen as reported in Bug 322820 : 
https://bugs.kde.org/show_bug.cgi?id=322820

Default behavior of pmc when user clicks on empty area is to show the media 
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there 
is no media playing, so that user can now access playlists from there.Clicking 
again will hide the controller.

If we want to show the playlist page directly by clicking the empty area (i.e 
no media controller shown) then the 154th line can be changed to :
  pmcPageStack.pushAndFocus(getPlaylist());


Diffs
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116620/diff/


Testing
---

1.On welcome screen, (when no media is playing) clicked on empty area and the 
media controller is showing and it goes into hiding by clicking again in empty 
area.
2.Left the media controller visible on welcome screen and started some media 
and then again went back to welcome screen, media controller is not visible now.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Sinny Kumari 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52206
---


Good work!
Neat and best solution as of whatever we came across till now! From my side, it 
should go ahead. Please wait for some time in case any one has any concern.


shells/newshell/package/contents/ui/mediacenter.qml


Please follow, if-else code format as:
if (condition) {
   // statement
} else {
   // statement
}


- Sinny Kumari


On March 5, 2014, 5:46 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 5, 2014, 5:46 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Ashish Madeti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---

(Updated March 5, 2014, 7:38 p.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Changes
---

Changed the if-else code format as pointed out by Sinny.


Repository: plasma-mediacenter


Description
---

Playlist was not reachable from home screen as reported in Bug 322820 : 
https://bugs.kde.org/show_bug.cgi?id=322820

Default behavior of pmc when user clicks on empty area is to show the media 
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there 
is no media playing, so that user can now access playlists from there.Clicking 
again will hide the controller.

If we want to show the playlist page directly by clicking the empty area (i.e 
no media controller shown) then the 154th line can be changed to :
  pmcPageStack.pushAndFocus(getPlaylist());


Diffs (updated)
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116620/diff/


Testing
---

1.On welcome screen, (when no media is playing) clicked on empty area and the 
media controller is showing and it goes into hiding by clicking again in empty 
area.
2.Left the media controller visible on welcome screen and started some media 
and then again went back to welcome screen, media controller is not visible now.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review5
---


A better way would be to just show the playlist instead of showing the 
controller, because the controller is useless when nothing is playing. See if 
it works good if you simply show the playlist.

- Shantanu Tushar


On March 5, 2014, 7:38 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 5, 2014, 7:38 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Sinny Kumari 


> On March 6, 2014, 5:07 a.m., Shantanu Tushar wrote:
> > A better way would be to just show the playlist instead of showing the 
> > controller, because the controller is useless when nothing is playing. See 
> > if it works good if you simply show the playlist.

Yes! This approach will be more sensible.


- Sinny


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review5
---


On March 5, 2014, 7:38 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 5, 2014, 7:38 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-05 Thread Ashish Madeti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---

(Updated March 6, 2014, 5:20 a.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Changes
---

Now clicking the empty area directly shows the playlist as suggested by 
Shantanu and Sinny.


Repository: plasma-mediacenter


Description
---

Playlist was not reachable from home screen as reported in Bug 322820 : 
https://bugs.kde.org/show_bug.cgi?id=322820

Default behavior of pmc when user clicks on empty area is to show the media 
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there 
is no media playing, so that user can now access playlists from there.Clicking 
again will hide the controller.

If we want to show the playlist page directly by clicking the empty area (i.e 
no media controller shown) then the 154th line can be changed to :
  pmcPageStack.pushAndFocus(getPlaylist());


Diffs (updated)
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116620/diff/


Testing
---

1.On welcome screen, (when no media is playing) clicked on empty area and the 
media controller is showing and it goes into hiding by clicking again in empty 
area.
2.Left the media controller visible on welcome screen and started some media 
and then again went back to welcome screen, media controller is not visible now.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


After going to playlist like this, if you press back you get a blank screen 
with Loading spinner. Expected is the homescreen to come back.

- Shantanu Tushar


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Ashish Madeti 


> On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote:
> > After going to playlist like this, if you press back you get a blank screen 
> > with Loading spinner. Expected is the homescreen to come back.

1.Start PMC
2.Click on empty area (playlist shows)
3.Click back.
I am getting homescreen only after step 3.
Am I missing something here ?


- Ashish


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Bhushan Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52234
---


Sorry but I don't think this is better solution. Not every time I want to go at 
playlist, sometimes we can click in empty area by mistake. So IMHO good 
solution will be button which says Go to Playlist or something like that. May 
be something like toolbox in Plasma at corner which points to the Playlist?

- Bhushan Shah


On March 6, 2014, 10:50 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 10:50 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar 


> On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote:
> > After going to playlist like this, if you press back you get a blank screen 
> > with Loading spinner. Expected is the homescreen to come back.
> 
> Ashish Madeti wrote:
> 1.Start PMC
> 2.Click on empty area (playlist shows)
> 3.Click back.
> I am getting homescreen only after step 3.
> Am I missing something here ?

Hmm I tried your patch again and I still get the empty screen. It might be 
local to me, you should wait for someone else to confirm this works.


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52266
---



shells/newshell/package/contents/ui/mediacenter.qml


You can do it like this-
pmcPageStack.pushAndFocus(mediaPlayerInstance ? getMediaPlayer() : 
getPlaylist())

and then you won't even need braces in onEmptyAreaClicked


- Shantanu Tushar


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar 


> On March 6, 2014, 8:01 a.m., Shantanu Tushar wrote:
> > After going to playlist like this, if you press back you get a blank screen 
> > with Loading spinner. Expected is the homescreen to come back.
> 
> Ashish Madeti wrote:
> 1.Start PMC
> 2.Click on empty area (playlist shows)
> 3.Click back.
> I am getting homescreen only after step 3.
> Am I missing something here ?
> 
> Shantanu Tushar wrote:
> Hmm I tried your patch again and I still get the empty screen. It might 
> be local to me, you should wait for someone else to confirm this works.

Ok this was not due to your patch, it was an unrelated bug that I have now 
fixed. So your patch works fine now.


- Shantanu


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52229
---


On March 6, 2014, 5:20 a.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 5:20 a.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Ashish Madeti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---

(Updated March 6, 2014, 4:17 p.m.)


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Changes
---

Made the code compact (1 line) as Shantanu suggested.


Repository: plasma-mediacenter


Description
---

Playlist was not reachable from home screen as reported in Bug 322820 : 
https://bugs.kde.org/show_bug.cgi?id=322820

Default behavior of pmc when user clicks on empty area is to show the media 
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there 
is no media playing, so that user can now access playlists from there.Clicking 
again will hide the controller.

If we want to show the playlist page directly by clicking the empty area (i.e 
no media controller shown) then the 154th line can be changed to :
  pmcPageStack.pushAndFocus(getPlaylist());


Diffs (updated)
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116620/diff/


Testing
---

1.On welcome screen, (when no media is playing) clicked on empty area and the 
media controller is showing and it goes into hiding by clicking again in empty 
area.
2.Left the media controller visible on welcome screen and started some media 
and then again went back to welcome screen, media controller is not visible now.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Shantanu Tushar 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52285
---

Ship it!


Ship It!

- Shantanu Tushar


On March 6, 2014, 4:17 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 4:17 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Ashish Madeti 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/
---

(Updated March 6, 2014, 5:43 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
Sujith Haridasan.


Repository: plasma-mediacenter


Description
---

Playlist was not reachable from home screen as reported in Bug 322820 : 
https://bugs.kde.org/show_bug.cgi?id=322820

Default behavior of pmc when user clicks on empty area is to show the media 
player instance when some media is playing and if not then it does nothing.
This patch will show the media controller when empty area is clicked and there 
is no media playing, so that user can now access playlists from there.Clicking 
again will hide the controller.

If we want to show the playlist page directly by clicking the empty area (i.e 
no media controller shown) then the 154th line can be changed to :
  pmcPageStack.pushAndFocus(getPlaylist());


Diffs
-

  shells/newshell/package/contents/ui/mediacenter.qml 49ea403 

Diff: https://git.reviewboard.kde.org/r/116620/diff/


Testing
---

1.On welcome screen, (when no media is playing) clicked on empty area and the 
media controller is showing and it goes into hiding by clicking again in empty 
area.
2.Left the media controller visible on welcome screen and started some media 
and then again went back to welcome screen, media controller is not visible now.


Thanks,

Ashish Madeti

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 116620: Bug 322820 - Playlist is not reachable from home screen

2014-03-06 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116620/#review52286
---


This review has been submitted with commit 
67032817d71905261d94a2c9775f033eb62863b1 by Shantanu Tushar to branch master.

- Commit Hook


On March 6, 2014, 4:17 p.m., Ashish Madeti wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116620/
> ---
> 
> (Updated March 6, 2014, 4:17 p.m.)
> 
> 
> Review request for Plasma, Akshay Ratan, Shantanu Tushar, Sinny Kumari, and 
> Sujith Haridasan.
> 
> 
> Repository: plasma-mediacenter
> 
> 
> Description
> ---
> 
> Playlist was not reachable from home screen as reported in Bug 322820 : 
> https://bugs.kde.org/show_bug.cgi?id=322820
> 
> Default behavior of pmc when user clicks on empty area is to show the media 
> player instance when some media is playing and if not then it does nothing.
> This patch will show the media controller when empty area is clicked and 
> there is no media playing, so that user can now access playlists from 
> there.Clicking again will hide the controller.
> 
> If we want to show the playlist page directly by clicking the empty area (i.e 
> no media controller shown) then the 154th line can be changed to :
>   pmcPageStack.pushAndFocus(getPlaylist());
> 
> 
> Diffs
> -
> 
>   shells/newshell/package/contents/ui/mediacenter.qml 49ea403 
> 
> Diff: https://git.reviewboard.kde.org/r/116620/diff/
> 
> 
> Testing
> ---
> 
> 1.On welcome screen, (when no media is playing) clicked on empty area and the 
> media controller is showing and it goes into hiding by clicking again in 
> empty area.
> 2.Left the media controller visible on welcome screen and started some media 
> and then again went back to welcome screen, media controller is not visible 
> now.
> 
> 
> Thanks,
> 
> Ashish Madeti
> 
>

___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel