D10251: [RFC] Use mipmap filtering in window thumbnails

[Kai Uwe Broulik]

broulik closed this revision.
broulik added a comment.


  Committed as 
https://cgit.kde.org/plasma-framework.git/commit/?id=612494e2b2e9265d33ce148332d5f490b024a3bd

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg, davidedmundson
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, ragreen, 
michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Nathaniel Graham]

ngraham added a comment.


  Could we land this?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg, davidedmundson
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Julian Wolff]

progwolff added a comment.


  Thanks!
  
  I tested it with several running applications, including windows with 
different apect ratios and combined previews for multiple instances of the same 
application. Looks great in every case.
  
  +1 from me!

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik updated this revision to Diff 29832.
fredrik added a comment.


  Rebase on master.

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10251?vs=26374=29832

REVISION DETAIL
  https://phabricator.kde.org/D10251

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp
  src/declarativeimports/core/windowthumbnail.h

To: fredrik, #plasma, #vdg
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Julian Wolff]

progwolff added a comment.


  Could you please rebase on current master?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: progwolff, broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik added a comment.


  In D10251#227092 , @broulik wrote:
  
  > What's the state of this? Bug 391915 just cropped up
  
  
  There are still some issues with the cubic filter, and I've been distracted 
by other things lately.
  I think we should consider landing the current version in the meantime, 
because like @ngraham said, it is a big visual win even in its current state.
  
  It would also be nice to get some testing before the release.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Kai Uwe Broulik]

broulik added a comment.


  What's the state of this? Bug 391915 just cropped up

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: broulik, ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Nathaniel Graham]

ngraham added a comment.


  Crisper would definitely be nicer too, but if that's too hard, this is 
already a big visual win even in its current state.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: ngraham, hein, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Eike Hein]

hein added a comment.


  It's definitely nicer, but could we go for the full thing and make it crisper 
too?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik added a comment.


  Before and after:
  F5688790: before-after.png 

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

To: fredrik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10251: [RFC] Use mipmap filtering in window thumbnails

[Fredrik Höglund]

fredrik created this revision.
fredrik added reviewers: Plasma, VDG.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
fredrik requested review of this revision.

REVISION SUMMARY
  Blit the contents of the window texture to a separate mipmap texture, and 
(re)generate the mipmaps on each damage event.
  
  The mipmap filter is the default linear filter, which results in soft images. 
Using a filter with a sharpening kernel, such as a cubic or a windowed sinc 
filter would produce better results, but this is still an improvement over not 
using a mipmap filter at all.
  
  The scaling is gamma-correct when desktop GL is used.
  
  Note that this patch only modifies the GLX path.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10251

AFFECTED FILES
  src/declarativeimports/core/windowthumbnail.cpp
  src/declarativeimports/core/windowthumbnail.h

To: fredrik, #plasma, #vdg
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, ngraham, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart