D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
This revision was automatically updated to reflect the committed changes. Closed by commit R119:2b3f9cd9092f: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11007?vs=28799=28803#toc REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11007?vs=28799=28803 REVISION DETAIL https://phabricator.kde.org/D11007 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
kossebau edited the summary of this revision. kossebau edited the test plan for this revision. REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL https://phabricator.kde.org/D11007 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL https://phabricator.kde.org/D11007 To: kossebau, broulik, hein Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
kossebau updated this revision to Diff 28799. kossebau added a comment. one var per variable REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11007?vs=28776=28799 BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL https://phabricator.kde.org/D11007 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml applets/taskmanager/package/contents/ui/main.qml To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
kossebau marked an inline comment as done. kossebau added inline comments. INLINE COMMENTS > broulik wrote in ContextMenu.qml:169 > In the media controller you do status == "playing" || status == "paused" > whereas here you do status == "stopped"? Yes, in the media controller the status is going for the applet qml state strings, given those are also used around. So there it is for consistency with rest of media controller code. Here there is no QML state, so I used the mpris property state directly with shortest logic. Torn by two consistency attractors. Make a call, please :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11007 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
broulik added a comment.
almost good
INLINE COMMENTS
> ContextMenu.qml:122
> +var playing = (playerData.PlaybackStatus === "Playing"),
> +menuItem = menu.newMenuItem(menu);
> menuItem.text = i18nc("Play previous track", "Previous
> Track");
Do two separate vars
var playing = ...;
var menuItem = ...;
> ContextMenu.qml:169
> +menuItem.enabled = Qt.binding(function() {
> +return playerData.PlaybackStatus !== "Stopped";
> +});
In the media controller you do status == "playing" || status == "paused"
whereas here you do status == "stopped"?
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D11007
To: kossebau, broulik
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
kossebau updated this revision to Diff 28776. kossebau added a comment. push missed update without playpause REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11007?vs=28610=28776 BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL https://phabricator.kde.org/D11007 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml applets/taskmanager/package/contents/ui/main.qml To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
kossebau updated this revision to Diff 28610. kossebau added a comment. cache isPlayingCheck in bool, fix icon update of play/pause menu entry REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11007?vs=28529=28610 BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL https://phabricator.kde.org/D11007 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml applets/taskmanager/package/contents/ui/main.qml To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
kossebau added a dependent revision: D10972: [RFC] Exposing slideshow to MPRIS controllers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11007 To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D11007: [taskmanager applet] Fix MPRIS entries in context menu for CanPause==false
kossebau created this revision. kossebau added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Also disable "Stop" menu entry if there is nothing to stop (separate commit?) TEST PLAN Media player entries Start/Pause & Stop show matching state and trigger expected actions both for VLC & MPRIS-patched Gwenview (CanPause=false). REPOSITORY R119 Plasma Desktop BRANCH fixtaskmanagercontextmenuformpris REVISION DETAIL https://phabricator.kde.org/D11007 AFFECTED FILES applets/taskmanager/package/contents/ui/ContextMenu.qml applets/taskmanager/package/contents/ui/main.qml To: kossebau, broulik Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
