D12481: Add dptr to models

2018-04-30 Thread Nicolas Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R994:0abe8778072a: Add dptr to models (authored by 
nicolasfella).

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32924&id=33315

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol, davidedmundson
Cc: davidedmundson, broulik, apol, drosca, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

2018-04-30 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> broulik wrote in models_p.h:26
> Do we need an explicit `Q_DECL_HIDDEN` or something?

No. That's only needed for when people do

class AbstractModel::Private

where AbstractModel is exported

REPOSITORY
  R994 Pulseaudio Qt Bindings

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol, davidedmundson
Cc: davidedmundson, broulik, apol, drosca, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

2018-04-23 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 32924.
nicolasfella added a comment.


  - Remove unneeded modifier

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32921&id=32924

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

2018-04-23 Thread Nicolas Fella 
nicolasfella added inline comments.

INLINE COMMENTS

> broulik wrote in models.h:81
> Why `void*`?

So we can replace it with a "real" private class when we need it without 
creating a empty one now

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

2018-04-23 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> models.h:47
>  
> -~AbstractModel() override;
> +virtual ~AbstractModel() override;
>  QHash roleNames() const Q_DECL_FINAL;

The `override` is sufficient

> models.h:81
> +private:
> +void *d;
>  };

Why `void*`?

> models_p.h:26
> +
> +class AbstractModelPrivate
> +{

Do we need an explicit `Q_DECL_HIDDEN` or something?

REPOSITORY
  R994 Pulseaudio Qt Bindings

REVISION DETAIL
  https://phabricator.kde.org/D12481

To: nicolasfella, drosca, apol
Cc: broulik, apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

2018-04-23 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 32921.
nicolasfella added a comment.


  - Add license header

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32920&id=32921

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

2018-04-23 Thread Nicolas Fella 
nicolasfella updated this revision to Diff 32920.
nicolasfella added a comment.


  - Coding style

REPOSITORY
  R994 Pulseaudio Qt Bindings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12481?vs=32919&id=32920

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D12481: Add dptr to models

2018-04-23 Thread Nicolas Fella 
nicolasfella created this revision.
nicolasfella added reviewers: drosca, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  Last exported classes without dptr

TEST PLAN
  Builds

REPOSITORY
  R994 Pulseaudio Qt Bindings

BRANCH
  dptr

REVISION DETAIL
  https://phabricator.kde.org/D12481

AFFECTED FILES
  src/models.cpp
  src/models.h
  src/models_p.h

To: nicolasfella, drosca, apol
Cc: apol, drosca, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart