D13255: Make dependency on KF5NetworkManagerQt optional
This revision was automatically updated to reflect the committed changes. Closed by commit R845:42723bb3cb70: Make dependency on KF5NetworkManagerQt optional (authored by arfrever, committed by asturmlechner). REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35985=36035 REVISION DETAIL https://phabricator.kde.org/D13255 AFFECTED FILES CMakeLists.txt kded/CMakeLists.txt kded/config-plasma-vault.cmake kded/service.cpp To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13255: Make dependency on KF5NetworkManagerQt optional
ivan accepted this revision. ivan added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R845 Plasma Vault BRANCH arcpatch-D13255 REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13255: Make dependency on KF5NetworkManagerQt optional
asturmlechner updated this revision to Diff 35985. asturmlechner added a comment. Use Q_UNUSED REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35896=35985 BRANCH arcpatch-D13255 REVISION DETAIL https://phabricator.kde.org/D13255 AFFECTED FILES CMakeLists.txt kded/CMakeLists.txt kded/config-plasma-vault.cmake kded/service.cpp To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13255: Make dependency on KF5NetworkManagerQt optional
ivan added a comment.
Very nice, thanks. If you want I can accept this (after the `Q_UNUSED`
change) and I'll do the UI patch separately.
INLINE COMMENTS
> service.cpp:53
> +{
> +(void)enabled;
> +}
You should use `Q_UNUSED` instead.
REPOSITORY
R845 Plasma Vault
REVISION DETAIL
https://phabricator.kde.org/D13255
To: asturmlechner, #plasma, ivan
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
D13255: Make dependency on KF5NetworkManagerQt optional
asturmlechner updated this revision to Diff 35896. asturmlechner added a comment. Update addressing 2/3 points raised REPOSITORY R845 Plasma Vault CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13255?vs=35291=35896 BRANCH master REVISION DETAIL https://phabricator.kde.org/D13255 AFFECTED FILES CMakeLists.txt kded/CMakeLists.txt kded/config-plasma-vault.cmake kded/service.cpp To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13255: Make dependency on KF5NetworkManagerQt optional
ivan requested changes to this revision. ivan added a comment. This revision now requires changes to proceed. - Would rather have a separate NetworkManager wrapper class implementation (a dummy implementation for when NM is disabled) than this. - Also, instead of a cmake flag, it is more common to find_package and define the flag depending on whether it was found or not. - What about the configuration UI? REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13255: Make dependency on KF5NetworkManagerQt optional
asturmlechner added a comment. (this is me forwarding a Gentoo user contribution) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D13255 To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D13255: Make dependency on KF5NetworkManagerQt optional
asturmlechner created this revision. asturmlechner added reviewers: Plasma, ivan. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. asturmlechner requested review of this revision. REPOSITORY R845 Plasma Vault BRANCH Plasma/5.13 REVISION DETAIL https://phabricator.kde.org/D13255 AFFECTED FILES CMakeLists.txt kded/CMakeLists.txt kded/config-plasma-vault.cmake kded/service.cpp To: asturmlechner, #plasma, ivan Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
