D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd abandoned this revision.
smithjd added a comment.


  Closing this because it breaks at least the settings:// ioslave, and the 
tags:// slave no longer has urls attached to the filename.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  In D13291#314252 , @smithjd wrote:
  
  > This used to work for the Baloo tags:// ioslave,
  
  
  Oh, as you mention it, in future do **not** push to baloo without going 
through review - you have done this several times now, and while the changes 
may be ok, your commit messages are definitely subpar.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd added a comment.


  In D13291#314199 , @bruns wrote:
  
  > In D13291#314195 , @smithjd 
wrote:
  >
  > > kioclient5 ls settings:/
  > > system-administration
  > >
  > > dolphin settings:/
  > >  System Administration
  >
  >
  > In dolphin, you can click on "System Administration". With kioclient5, I 
can use `kioclient5 ls settings:/system-administration` (dito for dolphin). 
Does this still work after your change?
  
  
  No.
  
  "The file or folder System Administration does not exist."
  
  This used to work for the Baloo tags:// ioslave, though it's less useful for 
that now that the slave no longer appends the full url to the filename. The 
working command was something like kioclient5 cp tags:/foo/. ~/bar. This 
successfully duplicated the tagged files and tag folder structure. I can't 
remember if I tested a single file, though if you needed a single file you 
probably wouldn't be digging in the tags:// ioslave anyway...

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  F6211779: Screenshot_20180823_212008.png 

  
  F6211778: Screenshot_20180823_212035.png 

  
  As you can see, as soon as you start to edit the URL, the UDS_NAME is used.
  
  Probably something like
  `kioclient5 ls settings:/network`
  
connectivity   [Verbindungen]
bluetooth  [Bluetooth]
networksettings[Einstellungen]
kcm_networkmanagement  [Verbindungen]
.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  In D13291#314195 , @smithjd wrote:
  
  > kioclient5 ls settings:/
  > system-administration
  >
  > dolphin settings:/
  >  System Administration
  
  
  In dolphin, you can click on "System Administration". With kioclient5, I can 
use `kioclient5 ls settings:/system-administration` (dito for dolphin). Does 
this still work after your change?

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Nathaniel Graham]

ngraham added a comment.


  before-and-after screenshots from Dolphin would also help, as would a 
Bugzilla ticket or steps to reproduce, or anything else. Otherwise it's a bit 
hard to evaluate why this change is desirable.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: ngraham, bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  In D13291#314195 , @smithjd wrote:
  
  > kioclient5 ls settings:/
  > system-administration
  >
  > dolphin settings:/
  >  System Administration
  
  
  That belongs into the test plan, of course with the needed context.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[James Smith]

smithjd added a comment.


  kioclient5 ls settings:/
  system-administration
  
  dolphin settings:/
  System Administration

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Stefan Brüns]

bruns added a comment.


  Can you please give an example?
  
  1. Exact command
  2. Current output
  3. Expected output

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd, #plasma
Cc: bruns, michaelh, plasma-devel, ragreen, Pitel, ZrenBot, ngraham, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13291: [kioclient] Use UDS_DISPLAY_NAME for file names.

[Friedrich W. H. Kossebau]

kossebau resigned from this revision.
kossebau added a comment.


  Myself have not dealt with KIO/UDS for some years, so no clue what is wanted 
here. Also only touched this repo for buildsystem brush-over, so not a good 
reviewer candidate, thus resigning as reviewer.
  
  @smithjd I would recommend to add some description of the motivation to the 
patch message, why is this change from UDS_NAME to UDS_DISPLAYNAME 
needed/wanted here. Does it fix a bug or imprive something?
  
  As reviewers you might want to add the #plasma 
 project, someone there might have a 
better clue about kioclient.

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D13291

To: smithjd
Cc: plasma-devel, ragreen, Pitel, michaelh, ZrenBot, ngraham, bruns, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart