D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham added a comment.


  Ping!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham added a comment.


  Instead of adding another tab, how about putting the shortcuts editor below 
the plugins list?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd updated this revision to Diff 58698.
smithjd added a comment.


  - [Plasma Search KCM] Re-organize the tab and widget layouts.
  - Add edit actions.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15341?vs=41183&id=58698

BRANCH
  master-krunnerkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15341

AFFECTED FILES
  kcms/runners/CMakeLists.txt
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#323730 , @ngraham wrote:
  
  > In D15341#323715 , @smithjd 
wrote:
  >
  > > KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.
  >
  >
  > Can you explain why the fact that KRunner does more than the search fields 
in Kicker/Kickoff and Dolphin is a justification for allowing you to customize 
a small subset of the navigation shortcuts there, but not elsewhere? Help me 
understand where you're coming from. If you'd want to use [ctrl] + [e] and 
[ctrl] + [s]  (etc.) to navigate in KRunner, why wouldn't you want to use them 
elsewhere too? What's the difference?
  
  
  Global in-application shortcuts can already be customized. The problem is 
that often the desired shortcut is already assigned to some other action, such 
as Ctrl+S for saving across all applications. Reassigning Ctrl+S **globally** 
just for one application is terrible from a HIG perspective, so an 
application-specific override must be considered. A welcome side-effect from 
this is the large number of shortcuts now available to KRunner that don't 
impact global actions.
  
  In KRunner a larger percentage of the functionality is derived of text input, 
Dolphin / Kicker / Kickoff aren't similar to bash / KRunner in this regard and 
so wouldn't benefit as much from configurable input navigation shortcuts. The 
global shortcuts will still have the same actions as other applications unless 
the global shortcut is used for a KRunner action.
  
  IMO, this feature should already be a part of KRunner, though it hasn't had 
an outstanding absence. The notion that global shortcuts should be shuffled for 
a single application is wrong. Changing the global shortcut for the same 
//type// of input navigation may suit the user, though this shouldn't be 
encouraged for only a single application. Promoting global shortcuts over an 
application-specific configureability is always wrong, and less right when 
there's already a patch. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham added a comment.


  In D15341#323715 , @smithjd wrote:
  
  > KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.
  
  
  Can you explain why the fact that KRunner does more than the search fields in 
Kicker/Kickoff and Dolphin is a justification for allowing you to customize a 
small subset of the navigation shortcuts there, but not elsewhere? Help me 
understand where you're coming from. If you'd want to use [ctrl] + [e] and 
[ctrl] + [s]  (etc.) to navigate in KRunner, why wouldn't you want to use them 
elsewhere too? What's the difference?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#323704 , @ngraham wrote:
  
  > In D15341#323672 , @smithjd 
wrote:
  >
  > > Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  >
  >
  >
  >
  > 1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, 
with the exception that they have a semi-hardcoded list of enabled runners.
  > 2. Not sure how that would make a difference anyway; the point is, if these 
navigation shortcuts are valuable for the KRunner input field, why wouldn't 
they be useful for every input field?
  
  
  KRunner as a standalone application does much more than search for files. 
Therefore adding independent shortcut configurability isn't so hard to justify. 
Kicker/Kickoff and dolphin search text input shortcuts on the other hand are 
configurable globally already, and only perform a subset of what KRunner does.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham added a comment.


  In D15341#323672 , @smithjd wrote:
  
  > Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  
  
  
  
  1. Kicker/Kickoff actually are: they're full-fledged interfaces to KRunner, 
with the exception that they have a semi-hardcoded list of enabled runners.
  2. Not sure how that would make a difference anyway; the point is, if these 
navigation shortcuts are valuable for the KRunner input field, why wouldn't 
they be useful for every input field?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd added a comment.


  In D15341#322618 , @ngraham wrote:
  
  > I appreciate the patch and the fact that you considered the prior comments 
in D14739 . But I must admit I'm still left 
with a nagging question: "Why?"
  >
  > Why here? Why not elsewhere? How about the search field in Kicker and 
Kickoff? The one in Dolphin? If this should be done at all, shouldn't it be 
done everywhere? And if it can't be done everywhere due to conflicts (i.e. 
because [ctrl] + [a] and [ctrl] + [s] have existing meanings in GUI software), 
then should it be done at all?
  
  
  Kicker/Kickoff and the dolphin search aren't full-fledged launchers like 
KRunner, only search fields for Baloo.
  
  > It just seems sort of random to add this very heavyweight configuration UI 
here in the KCM to change shortcuts for KRunner that basically nobody but you 
would ever want to change. :) > Pretty much the only KRunner-related shortcut 
that your average user might actually want to change in the KCM is the 
activation shortcut, and that's not here--though I would be happy to > see a 
patch to add just that on the main page, without adding another tab. If we 
absolutely must add alternative hidden power user CLI-inspired navigation 
shortcuts to KRunner (which I'm > not yet convinced on), let's just do it, and 
not wrap it in a whole bunch of user-visible configuration UI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  I appreciate the patch and the fact that you considered the prior comments in 
D14739 . But I must admit I'm still left 
with a nagging question: "Why?"
  
  Why here? Why not elsewhere? How about the search field in Kicker and 
Kickoff? The one in Dolphin? If this should be done at all, shouldn't it be 
done everywhere? And if it can't be done everywhere due to conflicts (i.e. 
because [ctrl] + [a] and [ctrl] + [s] have existing meanings in GUI software), 
then should it be done at all? It just seems sort of random to add this very 
heavyweight configuration UI here in the KCM to change shortcuts for KRunner 
that basically nobody but you would ever want to change. :) Pretty much the 
only KRunner-related shortcut that your average user might actually want to 
change in the KCM is the activation shortcut, and that's not here--though I 
would be happy to see a patch to add just that on the main page, without adding 
another tab. If we absolutely must add alternative hidden power user 
CLI-inspired navigation shortcuts to KRunner (which I'm not yet convinced on), 
let's just do it, and not wrap it in a whole bunch of user-visible 
configuration UI.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D15341

To: smithjd, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D15341: [Plasma Search KCM] Add a UI tab for editing shortcuts.

[James Smith]

smithjd created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
smithjd requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master-krunnerkeybindings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D15341

AFFECTED FILES
  kcms/runners/CMakeLists.txt
  kcms/runners/kcm.cpp
  kcms/runners/kcm.h

To: smithjd
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart