D16659: Size according to specified icon width and height

2018-11-04 Thread Alexander Stippich 
astippich created this revision.
astippich added reviewers: Plasma, mart, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
astippich requested review of this revision.

REVISION SUMMARY
  The icon.width and icon.height property were
  not used before for the icon

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  icon_size

REVISION DETAIL
  https://phabricator.kde.org/D16659

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16659: Size according to specified icon width and height

2018-11-04 Thread Aleix Pol Gonzalez 
apol added a comment.


  +1 overall

INLINE COMMENTS

> kquickstyleitem.cpp:193
>  }
> +int iconWidth = m_properties[QStringLiteral("iconWidth")].toInt();
> +int iconHeight = m_properties[QStringLiteral("iconHeight")].toInt();

Can we be a bit smarter here? If the size is present maybe we wouldn't have to 
check the pixelMetric.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D16659

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16659: Size according to specified icon width and height

2018-11-05 Thread Alexander Stippich 
astippich updated this revision to Diff 44936.
astippich added a comment.


  - only query pixelMetric on demand

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16659?vs=44828&id=44936

BRANCH
  icon_size

REVISION DETAIL
  https://phabricator.kde.org/D16659

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16659: Size according to specified icon width and height

2018-11-13 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:66d8bdb32735: Size according to specified icon width and 
height (authored by astippich).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16659?vs=44936&id=45423

REVISION DETAIL
  https://phabricator.kde.org/D16659

AFFECTED FILES
  org.kde.desktop/Button.qml
  plugin/kquickstyleitem.cpp

To: astippich, #plasma, mart, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart