D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c308122688ee: Add alternatives button to applet 
configuration in panel edit mode (authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=56435=56436

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg, davidedmundson, broulik, ngraham
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 updated this revision to Diff 56435.
GB_2 added a comment.


  Move `currentApplet.applet.prepareContextualActions();` to 
`onVisualParentChanged`

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=55960=56435

BRANCH
  arcpatch-D17410

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg, davidedmundson, broulik
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> ConfigOverlay.qml:227
>  
> +currentApplet.applet.prepareContextualActions();
>  handle.x = currentApplet.x;

This is never triggered when you just move the mouse over, you probably want to 
do that in the `onVisualParentChanged` handler below

Ideally this was all done using proper bindings instead of imperative code, 
though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson, broulik
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, jguidon, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  Or we could just leave it how it is now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  It seems like Elisa has a function to do this: 
https://lxr.kde.org/source/extragear/multimedia/elisa/src/elisaapplication.h#0083
  Maybe something like this could be added to KDE/Plasma Franeworks?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#448842 , @davidedmundson 
wrote:
  
  > Toolbutton should be able to take a qicon as a source
  
  
  Nope, when I use `iconSource: plasmoid.action("alternatives").icon` this 
happens:
  `ConfigOverlay.qml:392:21: Unable to assign QIcon to QString`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  Toolbutton should be able to take a qicon as a source

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  in the toolbutton icon source/name property.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#448756 , @davidedmundson 
wrote:
  
  > > It currently returns a QIcon, but I want the name/source of it from QML.
  >
  > What for?
  
  
  So I can use the same icon that is in the context menu

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  > It currently returns a QIcon, but I want the name/source of it from QML.
  
  What for?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 updated this revision to Diff 55960.
GB_2 added a comment.


  Try to fix diff

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=55959=55960

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 updated this revision to Diff 55959.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=55958=55959

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 updated this revision to Diff 55958.
GB_2 edited the summary of this revision.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=55856=55958

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  BTW, @davidedmundson or someone else:
  How do I get the icon name/source here: `iconSource: 
plasmoid.action("alternatives").icon`?
  It currently returns a QIcon, but I want the name/source of it from QML.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 commandeered this revision.
GB_2 edited reviewers, added: davidedmundson; removed: GB_2.
GB_2 added a comment.


  Sure!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg, davidedmundson
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  GB2 do you want to commandeer it back and make those changes?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: davidedmundson, #plasma, #vdg, GB_2
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Nathaniel Graham]

ngraham added a comment.


  And actually maybe we could programmatically get the name and icon from the 
action itself, like the Task Manager does:
  
property QtObject alternativesAction: null

enabled: alternativesAction && alternativesAction.enabled
visible: alternativesAction && alternativesAction.visible

text: alternativesAction ? alternativesAction.text : ""
icon: alternativesAction ? alternativesAction.icon : ""

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: davidedmundson, #plasma, #vdg, GB_2
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  Nice, thank you so much!

INLINE COMMENTS

> ConfigOverlay.qml:392
> +iconSource: "preferences-desktop-default-applications"
> +text: i18n("Alternatives...")
> +enabled: 
> currentApplet.applet.action("alternatives").visible

And this "Show Alternatives..."

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: davidedmundson, #plasma, #vdg, GB_2
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Nathaniel Graham]

ngraham added a comment.


  Nice, it works great!

INLINE COMMENTS

> ConfigOverlay.qml:391
> +Layout.fillWidth: true
> +iconSource: "preferences-desktop-default-applications"
> +text: i18n("Alternatives...")

This should now be `widget-alternatives`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: davidedmundson, #plasma, #vdg, GB_2
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson updated this revision to Diff 55856.
davidedmundson added a comment.


  fix TODO

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=47054=55856

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: davidedmundson, #plasma, #vdg, GB_2
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#446874 , @Codezela wrote:
  
  > This icon have a lot of details for this small size we need more clear one 
I guess
  
  
  The icon was added here: D20367 
  I think it's still ok, but we can discuss how it can be changed in that 
revision or the KDE VDG chat channel.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Hazem Salem]

Codezela added a comment.


  This icon have all of details for this small size we need more clear one I 
guess

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: Codezela, broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, 
#plasma, cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, 
Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, 
cblack, arvidhansson, ian, hannahk, Pixel_Lime, jraleigh, squeakypancakes, 
alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, Pitel, crozbo, 
ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  Ping

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, 
Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, 
trickyricky26, ragreen, mglb, Pitel, crozbo, ZrenBot, firef, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a subscriber: broulik.
GB_2 added a comment.


  It seems like this is quite difficult, me and @broulik couldn't figure it 
out. If someone wants to take over this revision then please do it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: broulik, davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, 
Pixel_Lime, jraleigh, squeakypancakes, alexde, IohannesPetros, GB_2, rooty, 
trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  > Cannot read property 'applet' of null
  
  Which means currentApplet is null.
  
  When is that set? Were you checking if it was visible afterwards?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#374062 , @davidedmundson 
wrote:
  
  > > I'm trying to emit the signal contextualActionsAboutToShow in the (QML) 
onVisualParentChanged function, but it doesn't work...
  >
  > Use console.log to check your code is being called at the right time.
  >  Also search for contextualActionsAboutToShow in other code and then you'll 
have a reference you can copy.
  
  
  It is being called at the right time (I can see the output):
  
onVisualParentChanged: {
if (visualParent) {
...
console.log("Call contextualActionsAboutToShow");
currentApplet.applet.contextualActionsAboutToShow();
}
}
  
  And it should only show the button if there are specific alternatives:
  
PlasmaComponents.ToolButton {
id: alternativesButton
...
visible: currentApplet.applet.action("alternatives").visible
...
}
  
  But it doesn't work, it prints out `Cannot read property 'applet' of null` 
and `currentApplet.applet.action("alternatives").visible` is always `false`.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, 
squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, Pitel, 
crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  > I'm trying to emit the signal contextualActionsAboutToShow in the (QML) 
onVisualParentChanged function, but it doesn't work...
  
  Use console.log to check your code is being called at the right time.
  Also search for contextualActionsAboutToShow in other code and then you'll 
have a reference you can copy.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, 
skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  I'm trying to emit the signal contextualActionsAboutToShow in the (QML) 
onVisualParentChanged function, but it doesn't work...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, 
skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[David Edmundson]

davidedmundson added a comment.


  In general +++
  
  We need to fix that TODO. I added some rough notes, give that a go, it'll 
involve reading the C++ and seeing how that all ties together with the QML.
  
  If you get stuck, comment here.

INLINE COMMENTS

> ConfigOverlay.qml:396
> +tooltip.visible = false;
> +currentApplet.applet.action("alternatives").trigger()
> +}

As for your TODO:

See in plasma-frameworks applet_p.cpp around line 189

Good news: The "visible" property of this action indicates if we have 
alternatives or not.
So in theory we would just need to bind it to the ToolButton's visibility.

Probably also worth taking the text and icon source from there too

Bad news: This property is only updated when it receives the signal: 
contextualActionsAboutToShow

so that needs to be called somewhere.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: davidedmundson, ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, 
IohannesPetros, trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, 
skadinna, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, 
sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 added a comment.


  In D17410#373036 , @ngraham wrote:
  
  > Neat, it seems to generally work well. I notice that when I click the new 
menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we 
could make it not do that, so it would stay in panel edit mode if invoked while 
in panel edit mode.
  
  
  I can't find where that is implemented and I think it shouldn't be included 
here, because it exits the panel edit mode when it looses it's focus.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, 
trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Nathaniel Graham]

ngraham added a comment.


  Neat, it seems to generally work well. I notice that when I click the new 
menu item, it somewhat unexpectedly exits from panel edit mode. I wonder if we 
could make it not do that, so it would stay in panel edit mode if invoked while 
in panel edit mode.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, 
trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Nathaniel Graham]

ngraham added a comment.


  In D17410#373011 , @ndavis wrote:
  
  > I think we should be using a monochrome icon here.
  
  
  I agree.
  
  In D17410#373011 , @ndavis wrote:
  
  > It might be outside the scope of this patch anyway since this means the 
alternatives icon needs to be changed outside the edit mode as well.
  
  
  Exactly. For now, let's follow the existing pattern, and make that change in 
another patch.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: ngraham, ndavis, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, 
trickyricky26, ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Noah Davis]

ndavis added a comment.


  I think we should be using a monochrome icon here. An equivalent monochrome 
icon would be `favorite`, but I don't think "favorite" is a good symbol for 
"alternatives". Maybe `preferences-other`/`application-menu` (same icon) would 
be good? It might be outside the scope of this patch anyway since this means 
the alternatives icon needs to be changed outside the edit mode as well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

To: GB_2, #plasma, #vdg
Cc: ndavis, #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ZrenBot, firef, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 updated this revision to Diff 47054.
GB_2 added a comment.


  Update TODO text.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17410?vs=47051=47054

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart

D17410: Add alternatives button to applet configuration in panel edit mode

[Björn Feber]

GB_2 created this revision.
GB_2 added reviewers: Plasma, VDG.
GB_2 added projects: Plasma, VDG.
Herald added a subscriber: plasma-devel.
GB_2 requested review of this revision.

REVISION SUMMARY
  There is a configure button and an alternatives button in the context menu of 
an applet, but there is no alternatives button in the popup/overlay of an 
applet in the panel edit mode, so this adds that button, to make it more 
consistent and easier to find.
  F6461739: Alternatives Button in Applet Configuration in Panel Edit Mode.png 


TEST PLAN
  Hover over an applet in the panel edit mode.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17410

AFFECTED FILES
  containments/panel/contents/ui/ConfigOverlay.qml

To: GB_2, #plasma, #vdg
Cc: #vdg, plasma-devel, #plasma, alexde, IohannesPetros, trickyricky26, 
ragreen, Pitel, crozbo, ndavis, ZrenBot, firef, skadinna, lesliezhai, 
ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, 
mart