D17934: [Kickoff] Increase Kickoff information label readability

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:510c88f65b76: [Kickoff] Increase Kickoff information 
label readability (authored by Krešimir Čohar , 
committed by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17934?vs=48644&id=48659

REVISION DETAIL
  https://phabricator.kde.org/D17934

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, ngraham, #vdg, #plasma, GB_2
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Björn Feber]

GB_2 accepted this revision.
GB_2 added a comment.
This revision is now accepted and ready to land.


  Looks better now!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  centered-infolabel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma, GB_2
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Root]

rooty updated this revision to Diff 48644.
rooty added a comment.


  Roll back vertical alignment change

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D17934?vs=48578&id=48644

BRANCH
  centered-infolabel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17934

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Andres Betts]

abetts added a comment.


  In D17934#386077 , @ngraham wrote:
  
  > In D17934#386060 , @abetts wrote:
  >
  > > If those are the constraints, we can keep it as you propose, I would only 
make the computer information a lighter gray
  >
  >
  > It's already a light gray; this patch is proposing to make it the same 
color as other text.
  >
  > In D17934#386060 , @abetts wrote:
  >
  > > possibly the same size font as the username, and I would make the 
username label bold or a heavier font weight.
  >
  >
  > That would require a change to the `Heading` items since we shouldn't be 
overriding weights here. E.g. with D17906 
  >
  > FWIW I would support that since I think bold text in headings is 
conceptually correct and looks good.
  
  
  K, cool. That's it for me :D

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Nathaniel Graham]

ngraham added a comment.


  In D17934#386060 , @abetts wrote:
  
  > If those are the constraints, we can keep it as you propose, I would only 
make the computer information a lighter gray
  
  
  It's already a light gray; this patch is proposing to make it the same color 
as other text.
  
  In D17934#386060 , @abetts wrote:
  
  > possibly the same size font as the username, and I would make the username 
label bold or a heavier font weight.
  
  
  That would require a change to the `Heading` items since we shouldn't be 
overriding weights here. E.g. with D17906 
  
  FWIW I would support that since I think bold text in headings is conceptually 
correct and looks good.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Andres Betts]

abetts added a comment.


  In D17934#386059 , @ngraham wrote:
  
  > In D17934#386058 , @abetts wrote:
  >
  > > I can understand that. Are users able to copy the information that 
displays on hover? If so, that would be one way to get the information you need 
and at the same time not replace labels?
  >
  >
  > No, the information is not copyable. It could be selectable, which would 
make it copyable. But this would be a new feature that should go in a new 
patch. :) And I wouldn't want for this string to just be always elided.
  
  
  If those are the constraints, we can keep it as you propose, I would only 
make the computer information a lighter gray, possibly the same size font as 
the username, and I would make the username label bold or a heavier font 
weight. Just so that users don't inadvertently hover and wonder where their 
username went since fonts look very similar.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Nathaniel Graham]

ngraham added a comment.


  In D17934#386058 , @abetts wrote:
  
  > I can understand that. Are users able to copy the information that displays 
on hover? If so, that would be one way to get the information you need and at 
the same time not replace labels?
  
  
  No, the information is not copyable. It could be selectable, which would make 
it copyable. But this would be a new feature that should go in a new patch. :) 
And I wouldn't want for this string to just be always elided.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Andres Betts]

abetts added a comment.


  In D17934#386057 , @ngraham wrote:
  
  > In D17934#386053 , @abetts wrote:
  >
  > > What do you think of having this combination;
  > >
  > > USERNAME (dev@pc, etc, etc, etc)
  > >
  > > On mouseover, just make the rest of the description appear to the right 
of the username label INSTEAD of replacing the USERNAME label with the pc 
information. It will take a little bit more space but might seem more 
streamlined visually IMHO.
  >
  >
  > I tried that when I was redoing the header last time. It doesn't work  
because usernames, computer names, and operating system names can be very long, 
so in practice something is always elided.
  
  
  I can understand that. Are users able to copy the information that displays 
on hover? If so, that would be one way to get the information you need and at 
the same time not replace labels?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Nathaniel Graham]

ngraham added a comment.


  In D17934#386053 , @abetts wrote:
  
  > What do you think of having this combination;
  >
  > USERNAME (dev@pc, etc, etc, etc)
  >
  > On mouseover, just make the rest of the description appear to the right of 
the username label INSTEAD of replacing the USERNAME label with the pc 
information. It will take a little bit more space but might seem more 
streamlined visually IMHO.
  
  
  I tried that when I was redoing the header last time. It doesn't work  
because usernames, computer names, and operating system names can be very long, 
so in practice something is always elided.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Andres Betts]

abetts added a comment.


  In D17934#386050 , @ngraham wrote:
  
  > The opacity change makes sense to me: since this text isn't visible by 
default, there's no reason to make it difficult to read with a low opacity. If 
you go hunting for it and want to see it, you want it to be readable!
  >
  > The alignment change I'm not as sure about. Because the username and 
information label are different sizes, I deliberately used bottom alignment to 
avoid having the system information label appear to jump up when hovering on 
it. With your change, the jumpiness is re-introduced:
  >
  > F6523443: Peek 2019-01-03 14-15.gif 
  >
  > Thoughts/ideas?
  
  
  What do you think of having this combination;
  
  USERNAME (dev@pc, etc, etc, etc)
  
  On mouseover, just make the rest of the description appear to the right of 
the username label INSTEAD of replacing the USERNAME label with the pc 
information. It will take a little bit more space but might seem more 
streamlined visually IMHO.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: abetts, GB_2, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Björn Feber]

GB_2 added a comment.


  In D17934#386050 , @ngraham wrote:
  
  > The opacity change makes sense to me: since this text isn't visible by 
default, there's no reason to make it difficult to read with a low opacity. If 
you go hunting for it and want to see it, you want it to be readable!
  >
  > The alignment change I'm not as sure about. Because the username and 
information label are different sizes, I deliberately used bottom alignment to 
avoid having the system information label appear to jump up when hovering on 
it. With your change, the jumpiness is re-introduced:
  >
  > F6523443: Peek 2019-01-03 14-15.gif 
  >
  > Thoughts/ideas?
  
  
  I agree, it's better if it is left how it was before.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: GB_2, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Nathaniel Graham]

ngraham added a comment.


  The opacity change makes sense to me: since this text isn't visible by 
default, there's no reason to make it difficult to read with a low opacity. If 
you go hunting for it and want to see it, you want it to be readable!
  
  The alignment change I'm not as sure about. Because the username and 
information label are different sizes, I deliberately used bottom alignment to 
avoid having the system information label appear to jump up when hovering on 
it. With your change, the jumpiness is re-introduced:
  
  F6523443: Peek 2019-01-03 14-15.gif 
  
  Thoughts/ideas?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D17934

To: rooty, ngraham, #vdg, #plasma
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D17934: [Kickoff] Increase Kickoff information label readability

[Root]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch vertically centers the information label (infolabel) that appears 
once a user hovers/runs over their username with
  their mouse as well as increases its opacity in favor of better readability.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  centered-infolabel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D17934

AFFECTED FILES
  applets/kickoff/package/contents/ui/Header.qml

To: rooty
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart