D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:684ee0c13bfb: Add a popup search bar to the plasma-nm 
applet (authored by vpilo).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18607?vs=50582=50628

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: abetts, jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Yep, I think this is fine. Shipit!

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma, jgrulich, ngraham
Cc: abetts, jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Looks good to me and also seems to work properly.
  
  Wait for @ngraham if he agrees with this, but I think it's okay in this form 
and it will not bother people by forcing them a search bar when they don't need 
it.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma, jgrulich
Cc: abetts, jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  In D18607#402657 , @abetts wrote:
  
  > Does the hug allow for just a search button and a non-always visible search 
field?
  
  
  Yep, I want to have it visible only when a user opens it manually, it 
shouldn't be visible by default when the list of connections is long and there 
is a scrollbar visible.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: abetts, jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Andres Betts]

abetts added a comment.


  Does the hug allow for just a search button and a non-always visible search 
field?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: abetts, jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  +1, I actually like it now with the search button. I will try it properly 
later and go through your code.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo marked an inline comment as done.
vpilo added inline comments.

INLINE COMMENTS

> PopupDialog.qml:45
>  
> -Toolbar {
> -id: toolbar
> +ColumnLayout {
> +anchors.fill: parent

This is to solve layouting issues when toggling the search bar.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo updated this revision to Diff 50582.
vpilo added a comment.


  - New implementation with a toolbutton
- Also added search reset on Esc keypress, on applet close, on search close
  
  I made a few tests and with all 3 toolbuttons (wifi/mobile/airplane) in 
place, also adding the search bar to the toolbar itself makes it cramped and 
you can't type a lot in it.
  This version IMHO looks neater and I think still pretty unobtrusive, while 
still making the feature discoverable by having a button.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18607?vs=50567=50582

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  Besides, it doesn't seem to work as it should:
  
  1. It removed the button in the top right corner which opens the KCM
  2. When I restart plasmashell, the search bar is visible even when I have 
only 4 connections (no scrollbar), typing some text and clearing it makes it 
disappear correctly
  
  Can you look into placing the search bar into the toolbar? Perhaps making it 
visible also only when there are many connections and when it makes sense to 
search for them. I tried to place it there and it looks ugly when you use 
PlasmaComponents.TextField, maybe just some text field without frame and 
borders should be used.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Nathaniel Graham]

ngraham added a comment.


  In D18607#402549 , @jgrulich wrote:
  
  >   only when you start typing.
  
  
  Not a great idea since there's no way to know you can search if you start 
typing; it would be an invisible UI and nobody would ever find it. Even in 
GNOME where they have this paradigm everywhere, people hate it because it's not 
discoverable when you want it, and annoying when you accidentally activate it.
  
  I liked your idea of putting a stub in the toolbar that expands to the full 
width when clicked in.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  With this approach I will basically see it all the time, you can have just 
one connection hidden and the search bar will pop up, I don't want that and in 
my opinion it doesn't look good. Either should be placed in the toolbar or 
visible only when you start typing.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added inline comments.

INLINE COMMENTS

> davidedmundson wrote in PopupDialog.qml:81
> The connection view changes height depending on the presence of a search bar
> The search bar becomes visible depending on the height of the listview
> 
> I would expect that to be giving binding loops when you're on the edge.

How would I test this?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo updated this revision to Diff 50567.
vpilo added a comment.


  - review
  
  Up, not down
  No label
  Changed search label

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18607?vs=50518=50567

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Nathaniel Graham]

ngraham added a comment.


  BTW regardless of where we put the search field, its placeholder text should 
just be `Search...`.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added a comment.


  Here's my latest change, not submitted yet.
  
  | F6576947: short.png  | F6576946: 
search.png  | F6576945: long.png 
 |
  |
  
  The differences are that I moved the bar to the top, made the label into a 
placeholder text, and added a bit of margin on the textfield sides.
  
  In D18607#402431 , @jgrulich wrote:
  
  > > Putting the search bar in the toolbar on top is an interesting idea. 
There's definitely room on mine. However it does start to feel a bit cramped. 
+1 for the idea of a search field though.
  >
  > My opinion is: I don't want the search bar to take any additional vertical 
space by default, not even when there is many connections, because I don't need 
usually to scroll down to find the connection I need. On the other hand I get 
it might be useful for someone else. What about showing the search bar once 
users start typing?
  
  
  If you usually don't need to scroll down to find a connection you need, then 
you won't see the search bar.
  
  As you can see:
  
  - When the list of connections is short:
- If the user starts typing, then it shows automatically.
- When the field is emptied, then it hides.
  - When the list of connections is long enough to already need a scrollbar:
- The field is always shown, and highlighted.
- You just lose one entry of vertical space that you have to scroll through 
anyway.
  
  In D18607#402444 , @ngraham wrote:
  
  > In D18607#402435 , @jgrulich 
wrote:
  >
  > > Alternatively we can show a small input box just saying "Search ..."  and 
clicking into it to start typing it would hide all the switches in the toolbar 
(wifi, wwan, airplane) and expand across the whole toolbar?
  >
  >
  > That's not a bad idea! And then when the user clicks on the "clear text" on 
the right side of the search field, it would collapse to its prior size.
  
  
  I think my approach is less visually obtrusive, and you can still use 
everything else in the widget while the search field is active.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Nathaniel Graham]

ngraham added a comment.


  In D18607#402435 , @jgrulich wrote:
  
  > Alternatively we can show a small input box just saying "Search ..."  and 
clicking into it to start typing it would hide all the switches in the toolbar 
(wifi, wwan, airplane) and expand across the whole toolbar?
  
  
  That's not a bad idea! And then when the user clicks on the "clear text" on 
the right side of the search field, it would collapse to its prior size.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  > Putting the search bar in the toolbar on top is an interesting idea. 
There's definitely room on mine. However it does start to feel a bit cramped. 
+1 for the idea of a search field though.
  
  Alternatively we can show a small input box just saying "Search ..."  and 
clicking into it to start typing it would hide all the switches in the toolbar 
(wifi, wwan, airplane) and expand across the whole toolbar?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  In D18607#402415 , @ngraham wrote:
  
  > In D18607#402363 , @jgrulich 
wrote:
  >
  > > I guess it's not, maybe this can be configured in Phabricator somehow, no 
idea, I just don't want to miss any plasma-nm review as its maintainer.
  >
  >
  > This is something that Phabricator can do automatically, if it's 
configured. I've asked Sysadmin to do so: T10420: Plasma Network Management 
Applet herald rule 
  
  
  Great!! Thank you for that.
  
  > Putting the search bar in the toolbar on top is an interesting idea. 
There's definitely room on mine. However it does start to feel a bit cramped. 
+1 for the idea of a search field though.
  
  My opinion is: I don't want the search bar to take any additional vertical 
space by default, not even when there is many connections, because I don't need 
usually to scroll down to find the connection I need. On the other hand I get 
it might be useful for someone else. What about showing the search bar once 
users start typing?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Nathaniel Graham]

ngraham added a comment.


  In D18607#402363 , @jgrulich wrote:
  
  > I guess it's not, maybe this can be configured in Phabricator somehow, no 
idea, I just don't want to miss any plasma-nm review as its maintainer.
  
  
  This is something that Phabricator can do automatically, if it's configured. 
I've asked Sysadmin to do so: T10420: Plasma Network Management Applet herald 
rule 
  
  Putting the search bar in the toolbar on top is an interesting idea. There's 
definitely room on mine. However it does start to feel a bit cramped. +1 for 
the idea of a search field though.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  In D18607#402360 , @vpilo wrote:
  
  > In D18607#402261 , @jgrulich 
wrote:
  >
  > > Wouldn't be a small search bar placed next to the aiplane mode enough? 
That way it will not need additional vertical space. Hiding it when there is 
only a small amount of connections is a good idea.
  >
  >
  > Isn't there way too little space for it inside of the toolbar?
  
  
  Hmm, it probably is, it's not in my case but that depends on screen size and 
resolution. I wouldn't definitely put it at the bottom. To be honest, I 
wouldn't add this at all, because the applet is really small. What I would 
prefer is to add some sort of sorting based on connection priority, that way 
you can have relevant connections at the top and you will not need to search 
for them.
  
  > It would need at least 150-200 px, and that's exactly how much I have in 
that screenshot. In my panel nm applet, there's just a tiny bit more space 
(~50px). How could I visually separate it from the other buttons around it?
  > 
  >> PS: Please add me as a reviewer next time for plasma-nm changes.
  > 
  > Sure. Is this kind of info written anywhere?
  
  I guess it's not, maybe this can be configured in Phabricator somehow, no 
idea, I just don't want to miss any plasma-nm review as its maintainer.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added a comment.


  In D18607#402261 , @jgrulich wrote:
  
  > Wouldn't be a small search bar placed next to the aiplane mode enough? That 
way it will not need additional vertical space. Hiding it when there is only a 
small amount of connections is a good idea.
  
  
  Isn't there way too little space for it inside of the toolbar? 
  F6576478: searchbar-searching.png 
  It would need at least 150-200 px, and that's exactly how much I have in that 
screenshot. In my panel nm applet, there's just a tiny bit more space (~50px). 
How could I visually separate it from the other buttons around it?
  
  > PS: Please add me as a reviewer next time for plasma-nm changes.
  
  Sure. Is this kind of info written anywhere?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Jan Grulich]

jgrulich added a comment.


  Wouldn't be a small search bar placed next to the aiplane mode enough? That 
way it will not need additional vertical space. Hiding it when there is only a 
small amount of connections is a good idea.
  
  PS: Please add me as a reviewer next time for plasma-nm changes.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D18607: Add a popup search bar to the plasma-nm applet

[Nathaniel Graham]

ngraham added a comment.


  In D18607#402168 , @vpilo wrote:
  
  > Better just place it at the top above the the connections list, then?
  
  
  I think that would make sense.
  
  In such a limited space, I think it's fine for the search field to only 
appear if the list would otherwise be scrollable.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added a comment.


  Better just place it at the top above the the connections list, then?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> davidedmundson wrote in appletproxymodel.cpp:60
> what happens if you have a filter and the the entry is a slave?

Edit: ignore this.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[David Edmundson]

davidedmundson added a comment.


  Seems niche, but this solution is also unobtrusive, so I like that. I have a 
lot of VPNs searching through them would be quite useful.
  
  Having the search bar on the bottom is a bit weird as when you filter the 
results will be at the top, meaning the user's focus is split all over the 
place.

INLINE COMMENTS

> PopupDialog.qml:81
> +
> +onContentHeightChanged: isConnectionsListLong = height < 
> contentHeight
> +}

The connection view changes height depending on the presence of a search bar
The search bar becomes visible depending on the height of the listview

I would expect that to be giving binding loops when you're on the edge.

> appletproxymodel.cpp:60
> +if (filterRegExp().isEmpty()) {
>  return true;
>  }

what happens if you have a filter and the the entry is a slave?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo created this revision.
vpilo added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
vpilo requested review of this revision.

REVISION SUMMARY
  If there are not enough connections to fill the scrollview, the search bar is 
not displayed by default.
  If there are, the search bar is shown.
  Regardless of that, starting typing will filter the connections list and show 
the search bar.
  
  I'm uncertain whether not hiding it by default would be a good idea, 
usability wise.
  
  BUG: 344789
  BUG: 394290

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  vpilo/searchBar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18607

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  libs/models/appletproxymodel.cpp

To: vpilo, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart