D20086: Fix window height of Screen Locking KCM

2019-03-27 Thread Tigran Gabrielyan 
tigrang created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tigrang requested review of this revision.

REVISION SUMMARY
  An implicitHeight must be set on QML components to prevent window size being 
too small.
  
  BUG: 400355

TEST PLAN
  1. Open Screen Locking settings
  2. Go to Appearance tab
  3. Two rows of thumbnails with labels should be shown
  
  F6727233: screenlocker_kcm.png 

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

AFFECTED FILES
  kcm/wallpaperconfig.qml

To: tigrang
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-28 Thread Filip Fila 
filipf added a comment.


  Good fix, the lack of implicitHeight was leading to confusion before if there 
are even any wallpapers present.
  
  One question though: wouldn't it be better to define the height in 
`units.gridUnit` instead of raw pixels, or even absolutely by doubling the 
height of one grid item? From my understanding, when scaling is changed the 
grid items are also resized so the window won't open showing 2 rows of 
wallpapers anymore, as was desired.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-28 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-28 Thread Tigran Gabrielyan 
tigrang added a comment.


  @filipf Here's a diff with units.gridUnit 
https://phabricator.kde.org/differential/diff/54998/ which doesn't quite work 
out to 2 rows for every scaling factor but is a bit better than hard-coded 
pixel size. I'm not sure how to do doubling the height of one grid item.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-28 Thread David Edmundson 
davidedmundson added a comment.


  Hardcoding pixel size won't impact scaling.
  
  ---
  
  You will never get it spot on two rows with any combination of pixel size or 
units or whatever you add here. The correct size is dependent on the exact 
children.
  The only way you'll get it to be correct is to bind this stack view to 
currentItem.implicitHeight and making sure that the implicit size propagates 
upwards correctly.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson
Cc: abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-29 Thread Nathaniel Graham 
ngraham added a comment.


  @tigrang would you like this landed now, or do you wanna try 
@davidedmundson's idea?
  
  Thanks for the patch!

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson
Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-30 Thread Nathaniel Graham 
ngraham accepted this revision.
ngraham added a comment.


  Let's land this now and then you can try the other approach in another patch 
(if you want to).

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson, ngraham
Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-30 Thread Nathaniel Graham 
This revision was automatically updated to reflect the committed changes.
Closed by commit R133:35864f76ffe8: Fix window height of Screen Locking KCM 
(authored by tigrang, committed by ngraham).

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D20086?vs=54968&id=55083

REVISION DETAIL
  https://phabricator.kde.org/D20086

AFFECTED FILES
  kcm/wallpaperconfig.qml

To: tigrang, davidedmundson, ngraham
Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D20086: Fix window height of Screen Locking KCM

2019-03-31 Thread Tigran Gabrielyan 
tigrang added a comment.


  @ngraham Sorry for the late response.
  
  > Let's land this now and then you can try the other approach in another 
patch (if you want to).
  
  Sounds good.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D20086

To: tigrang, davidedmundson, ngraham
Cc: ngraham, abetts, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart