D24691: Add support for WPA3
This revision was automatically updated to reflect the committed changes. Closed by commit R116:82e187663135: Add support for WPA3 (authored by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24691?vs=68155=70330#toc REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24691?vs=68155=70330 REVISION DETAIL https://phabricator.kde.org/D24691 AFFECTED FILES libs/editor/connectioneditorbase.cpp libs/editor/settings/ui/wifisecurity.ui libs/editor/settings/wifisecurity.cpp libs/editor/settings/wifisecurity.h To: jgrulich, #plasma, meven Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24691: Add support for WPA3
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.
Nice, I am properly not the best reviewer here, but it looks ok to me.
INLINE COMMENTS
> wifisecurity.cpp:118
> +} else if (securityIndex == SAE) {
> +return !m_ui->psk->text().isEmpty() || m_ui->psk->passwordOption()
> == PasswordField::AlwaysAsk;
> }
It is very similar with `securityIndex == WpaPsk) { // WPA` if
`NetworkManager::wpaPskIsValid(m_ui->psk->text())` could be used instead of
`!m_ui->psk->text().isEmpty()` we could use a single if block for both.
As a side note this if block could become a `switch(securityIndex)`
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
wpa3
REVISION DETAIL
https://phabricator.kde.org/D24691
To: jgrulich, #plasma, meven
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24691: Add support for WPA3
jgrulich added a comment. Ping? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D24691 To: jgrulich, #plasma Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24691: Add support for WPA3
jgrulich updated this revision to Diff 68155. jgrulich added a comment. Simplify code REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24691?vs=68036=68155 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691 AFFECTED FILES libs/editor/connectioneditorbase.cpp libs/editor/settings/ui/wifisecurity.ui libs/editor/settings/wifisecurity.cpp libs/editor/settings/wifisecurity.h To: jgrulich, #plasma Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24691: Add support for WPA3
meven added inline comments.
INLINE COMMENTS
> wifisecurity.cpp:403
> {
> -if (index == 0) {
> +if (index == 0) { // None
> m_ui->stackedWidget->setCurrentIndex(0);
It would be nice to convert use SecurityTypeIndex enum instead of hardcoded
values.
It seems to me those values match.
And then change WifiSecurity::securityChanged(int) to
WifiSecurity::securityChanged(SecurityTypeIndex) if possible.
> wifisecurity.cpp:415
> +m_ui->stackedWidget->setCurrentIndex(5);
> +} else if (index == 7) { // WPA3 Personal
> +m_ui->stackedWidget->setCurrentIndex(4);
With an enum this could be merged easily with the WPA/WPA2 Enterprise index ==
5 case.
REPOSITORY
R116 Plasma Network Management Applet
REVISION DETAIL
https://phabricator.kde.org/D24691
To: jgrulich, #plasma
Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24691: Add support for WPA3
jgrulich updated this revision to Diff 68036. jgrulich added a comment. Drop cmake change REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24691?vs=68035=68036 BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691 AFFECTED FILES libs/editor/connectioneditorbase.cpp libs/editor/settings/ui/wifisecurity.ui libs/editor/settings/wifisecurity.cpp libs/editor/settings/wifisecurity.h To: jgrulich, #plasma Cc: plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
D24691: Add support for WPA3
jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R116 Plasma Network Management Applet BRANCH wpa3 REVISION DETAIL https://phabricator.kde.org/D24691 AFFECTED FILES CMakeLists.txt libs/editor/connectioneditorbase.cpp libs/editor/settings/ui/wifisecurity.ui libs/editor/settings/wifisecurity.cpp libs/editor/settings/wifisecurity.h To: jgrulich Cc: plasma-devel, crossi, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
