D24893: [Lock Screen] Add option to hide clock when idle

[Kai Uwe Broulik]

broulik added a comment.


  > Does it make sense to have the option off by default, i.e. hiding the clock 
on idle by default?
  
  "Given that the setting will be off by default," is not true. By default the 
clock is shown, so nothing changes here, also given a static image is also our 
default.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: colomar, mart, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24893: [Lock Screen] Add option to hide clock when idle

[Thomas Pfeiffer]

colomar added a comment.


  In D24893#558506 , @ngraham wrote:
  
  > In D24893#558451 , @mart wrote:
  >
  > > clock "always show" is fine too tough
  >
  >
  > Given that the setting will be off by default, its opposite state is clear 
enough I'd say. It's not the best string ever, but maybe we should start with 
this and massage it later or else this will probably be stuck in limbo 
forever...
  
  
  Does it make sense to have the option off by default, i.e. hiding the clock 
on idle by default?
  I'd expect expect more users wanting to see the clock than users being 
annoyed by it (with the majority probably not caring either way), tbh. The 
slideshow is a very valid usecase for hiding it, but do we expect more users to 
have a slidehsow on their lock screen than users liking to always have a clock 
there?
  
  Why not changing it to "Hide after X seconds of inactivity" and having it off 
by default?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: colomar, mart, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D24893: [Lock Screen] Add option to hide clock when idle

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:56a43f8ee0ad: [Lock Screen] Add option to hide clock when 
idle (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24893?vs=68622&id=69386

REVISION DETAIL
  https://phabricator.kde.org/D24893

AFFECTED FILES
  lookandfeel/contents/components/WallpaperFader.qml
  lookandfeel/contents/lockscreen/config.qml
  lookandfeel/contents/lockscreen/config.xml

To: broulik, #plasma, #vdg, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24893: [Lock Screen] Add option to hide clock when idle

[Nathaniel Graham]

ngraham added a comment.


  In D24893#558451 , @mart wrote:
  
  > clock "always show" is fine too tough
  
  
  Given that the setting will be off by default, its opposite state is clear 
enough I'd say. It's not the best string ever, but maybe we should start with 
this and massage it later or else this will probably be stuck in limbo 
forever...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24893: [Lock Screen] Add option to hide clock when idle

[Marco Martin]

mart added a comment.


  clock "always show" is fine too tough

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24893: [Lock Screen] Add option to hide clock when idle

[Marco Martin]

mart added a comment.


  Instead of explicitly talking about clockwhat about a "Only show wallpaper 
when idle?"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24893: [Lock Screen] Add option to hide clock when idle

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in WallpaperFader.qml:145
> Why are we changing this line?

The clock shadow effectively renders the clock (shader effect with source 
hidden), so it has to be hidden.

> davidedmundson wrote in config.qml:21
> One thing Thomas always used to say was that if you have a checkbox it should 
> be obvious what the opposite action is.
> 
> This currently sounds like if it's off, the clock will randomly start 
> flashing like a 90's html  tag.

Can I have a  clock?
"Show when idle"? (Open to non-jargon suggestions)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> WallpaperFader.qml:145
>  target: clock.shadow
> -opacity: 1
> +opacity: wallpaperFader.alwaysShowClock ? 1 : 0
> +}

Why are we changing this line?

> config.qml:21
> +id: alwaysClock
> +text: i18ndc("plasma_lookandfeel_org.kde.lookandfeel", "verb, to 
> show something", "Always show")
> +}

One thing Thomas always used to say was that if you have a checkbox it should 
be obvious what the opposite action is.

This currently sounds like if it's off, the clock will randomly start flashing 
like a 90's html  tag.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh nice! Shipit! Works great.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This allows to use it for a slideshow or something.

TEST PLAN
  F7658739: Screenshot_20191023_213031.png 

  Option is on by default as before.
  Clock hides in unison with the rest of the UI when unchecked.
  
  Question is what about the mouse cursor? I think it should just always hide 
when idle (no config option) but there was a Qt bug where `MouseArea` wouldn't 
apply the `cursorShape` which was since fixed: 
https://bugreports.qt.io/browse/QTBUG-41045
  So we could resurrect D13207  now but 
without hacks :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

AFFECTED FILES
  lookandfeel/contents/components/WallpaperFader.qml
  lookandfeel/contents/lockscreen/config.qml
  lookandfeel/contents/lockscreen/config.xml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[Kai Uwe Broulik]

broulik added a comment.


  > Is there a way to suppress these settings when you're using a theme that 
doesn't make the clock and media controls optional?
  
  That's the trick! The config comes *from the theme* (similar to how plasmoids 
do it), so only our theme will have those check boxes.

INLINE COMMENTS

> ngraham wrote in config.qml:5
> Make this a FormLayout since it now has multiple rows of items in it

Can't, really, as it has to be aligned wit the non QML bits and other UI 
elements out of the control of this item (see `formAlignment` comment)
(I also didn't bother tbh)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[Nathaniel Graham]

ngraham added a comment.


  This should make a lot of people happy. :)
  
  Is there a way to suppress these settings when you're using a theme that 
doesn't make the clock and media controls optional?

INLINE COMMENTS

> config.qml:5
>  
> -RowLayout {
> +ColumnLayout {
> +property alias cfg_alwaysShowClock: alwaysClock.checked

Make this a FormLayout since it now has multiple rows of items in it

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart