D25175: FormLayout: Fix label height if wide mode is false
This revision was automatically updated to reflect the committed changes. Closed by commit R169:839983aa3604: FormLayout: Fix label height if wide mode is false (authored by jbbgameich). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25175?vs=69355&id=69356 REVISION DETAIL https://phabricator.kde.org/D25175 AFFECTED FILES src/controls/FormLayout.qml To: jbbgameich, #kirigami, #plasma:_mobile, mart Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, hein
D25175: FormLayout: Fix label height if wide mode is false
jbbgameich updated this revision to Diff 69355. jbbgameich edited the test plan for this revision. jbbgameich added a comment. Use implicit height instead of font metrics REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25175?vs=69353&id=69355 BRANCH fix/formlayout-label-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D25175 AFFECTED FILES src/controls/FormLayout.qml To: jbbgameich, #kirigami, #plasma:_mobile Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, hein
D25175: FormLayout: Fix label height if wide mode is false
jbbgameich added inline comments. INLINE COMMENTS > mart wrote in FormLayout.qml:277 > fontmetrics is the default font height, and this being an heading may be more > (when is heading) > does it work if instead you do here > return implicitHeight ? It works but produces a slightly smaller margin. But it looks good as well so I'll update the diff. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25175 To: jbbgameich, #kirigami, #plasma:_mobile Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, hein
D25175: FormLayout: Fix label height if wide mode is false
mart added inline comments.
INLINE COMMENTS
> FormLayout.qml:277
> +} else {
> +return Kirigami.Units.fontMetrics.height
> +}
fontmetrics is the default font height, and this being an heading may be more
(when is heading)
does it work if instead you do here
return implicitHeight ?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D25175
To: jbbgameich, #kirigami, #plasma:_mobile
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,
ahiemstra, davidedmundson, hein
D25175: FormLayout: Fix label height if wide mode is false
jbbgameich created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY previously the height of the label was based on the content's height. However this doesn't work in non wide mode. With this change it preserves the previous behaviour in wide mode were it makes sense but uses a constant height in non-wide mode. TEST PLAN FormLayouts with large content items don't have large margins between the items anymore when wideMode = false. REPOSITORY R169 Kirigami BRANCH fix/formlayout-label-height (branched from master) REVISION DETAIL https://phabricator.kde.org/D25175 AFFECTED FILES src/controls/FormLayout.qml To: jbbgameich Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
