D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

[Cyril Rossi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6ea1971ed13c: Restore notifier on AnimationDurationFactor 
that was lost during KConfig XT port (authored by crossi).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D25843?vs=71183&id=72868#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25843?vs=71183&id=72868

REVISION DETAIL
  https://phabricator.kde.org/D25843

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: crossi, #plasma, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

[Kevin Ottens]

ervin added a comment.


  In D25843#574736 , @davidedmundson 
wrote:
  
  > It's true that's the only user of it right now, so this is technically 
correct.
  >
  > I don't think it's a problem for us to emit changes for the other things. 
KConfigWatcher allows a user to see which things got changed as fine grain 
filtering in the receiver, there's basically no downside.
  
  
  Well, that's still more traffic on the bus for potentially nothing (more 
processing, more processes waking up). It might be negligible here but I'd be 
concerned at having this for all settings all the time.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25843

To: crossi, #plasma, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  It's true that's the only user of it right now, so this is technically 
correct.
  
  I don't think it's a problem for us to emit changes for the other things. 
KConfigWatcher allows a user to see which things got changed as fine grain 
filtering in the receiver, there's basically no downside.
  As a general rule I'm trying to move more of Plasma to use this.
  
  Personally I wouldn't bother changing this, as we'll only have to change it 
back.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25843

To: crossi, #plasma, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25843: Restore notifier on AnimationDurationFactor that was lost during KConfig XT port

[Cyril Rossi]

crossi created this revision.
crossi added reviewers: Plasma, ervin, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
crossi requested review of this revision.

REVISION SUMMARY
  Following D25792  and D25586 
 only AnimationDurationFactor notifies

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25843

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfgc

To: crossi, #plasma, ervin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart