D27525: Support Qt 5.14 on Android

[Volker Krause]

vkrause created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Assets (QML files and icons) are no longer extracted into the file system,
  but now are available in the android_rcc_bundle QRC file.
  
  This is based on Francis' work mentioned in D26749 
, but slightly adjusted
  to also fix icon loading as well.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27525

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: vkrause
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27525: Support Qt 5.14 on Android

[Aleix Pol Gonzalez]

apol added a comment.


  > Assets (QML files and icons) are no longer extracted into the file system,
  >  but now are available in the android_rcc_bundle QRC file.
  
  Meaning that we now need to change all applications to put the resources on 
the rcc file?
  
  The change upstream seems bonkers to me. Whatever, let's get this in. We'll 
possibly need to patch quite many apps for this... :(
  
  Also feels quite weird how the commit message is twice the same text but it 
never says why it's done.
  
  ¯\_(ツ)_/¯

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27525

To: vkrause
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27525: Support Qt 5.14 on Android

[Volker Krause]

vkrause added a comment.


  In D27525#614905 , @apol wrote:
  
  > > Assets (QML files and icons) are no longer extracted into the file system,
  > >  but now are available in the android_rcc_bundle QRC file.
  >
  > Meaning that we now need to change all applications to put the resources on 
the rcc file?
  
  
  No, androiddeployqt does that on its own. So overall the apk still has 
exactly the same content, just the way to access it changed. It is possible 
apps make assumption about this, some of the frameworks definitely do.
  
  > The change upstream seems bonkers to me. Whatever, let's get this in. We'll 
possibly need to patch quite many apps for this... :(
  > 
  > Also feels quite weird how the commit message is twice the same text but it 
never says why it's done. 
https://codereview.qt-project.org/c/qt/qtbase/+/270573/24
  > 
  > ¯\_(ツ)_/¯
  
  It's avoiding duplicating the assets again in the file system, thus needing 
less space and significantly speeding up the first start. So while technically 
going in the right direction I would certainly have preferred to have this as 
something opt-in to not break all existing non-trivial code out there...

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27525

To: vkrause
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27525: Support Qt 5.14 on Android

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:8bf5b4675186: Support Qt 5.14 on Android (authored by 
vkrause).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27525?vs=76060&id=76477

REVISION DETAIL
  https://phabricator.kde.org/D27525

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: vkrause, mart
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein