D28971: Persist state between launches

[Nathaniel Graham]

ngraham added a comment.


  In D28971#652708 , @mart wrote:
  
  > my concern here using qsettings in this place, is  that then it kinda 
clashes when an application uses its own config  like it should, from a 
framework (kconfiggroup, kconfigskeleton etc)
  >  i always refrained from using any form of config read/write here, and i 
think we should continue to do so.
  >  Kirigami is a tier1 framework that should do the kleast possible, is more 
like KGuiAddons/§KWidgetAddons, *not* a full feature kxmlgui, which if we want 
to have something along the lines, we should have a proper framework to do so, 
and not tier1
  
  
  If that's your vision for Kirigami, then we definitely need one, yeah. 
Otherwise our QML apps are going to need to endlessly reinvent this kind of 
wheel.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28971: Persist state between launches

[Carson Black]

cblack added a comment.


  In D28971#652708 , @mart wrote:
  
  > i always refrained from using any form of config read/write here, and i 
think we should continue to do so.
  
  
  Are you referring to the gallery (this patch) or to Kirigami?

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28971: Persist state between launches

[Marco Martin]

mart added a comment.


  my concern here using qsettings in this place, is  that then it kinda clashes 
when an application uses its own config  like it should, from a framework 
(kconfiggroup, kconfigskeleton etc)
  i always refrained from using any form of config read/write here, and i think 
we should continue to do so.
  Kirigami is a tier1 framework that should do the kleast possible, is more 
like KGuiAddons/§KWidgetAddons, *not* a full feature kxmlgui, which if we want 
to have something along the lines, we should have a proper framework to do so, 
and not tier1

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, davidedmundson

D28971: Persist state between launches

[Nathaniel Graham]

ngraham added a comment.


  Window geometry and position is supposed to be saved automatically by 
KXMLGui, at least for widgets apps. If that's not possible to do here, perhaps 
we should have Kirigami do this at the frameworks level so it doesn't need to 
be done by every single app.

REPOSITORY
  R1014 Kirigami Gallery

REVISION DETAIL
  https://phabricator.kde.org/D28971

To: cblack, #kirigami
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart

D28971: Persist state between launches

[Carson Black]

cblack created this revision.
cblack added a reviewer: Kirigami.
Herald added projects: Plasma, Kirigami.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Window geometry and last page will persist between launches.

TEST PLAN
  Change window geometry and navigate through the gallery and restart the app.

REPOSITORY
  R1014 Kirigami Gallery

BRANCH
  cblack/persistence (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28971

AFFECTED FILES
  src/CMakeLists.txt
  src/Config.cpp
  src/Config.h
  src/data/contents/ui/BaseApp.qml
  src/data/contents/ui/MainPage.qml
  src/main.cpp

To: cblack, #kirigami
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, domson, dkardarakos, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, davidedmundson, mart