D29019: Create a hotspot KCM for Plasma Mobile

2020-04-21 Thread Tobias Fella 
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:1c9d021daf4e: Create a hotspot KCM for Plasma Mobile 
(authored by tfella).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D29019?vs=80765=80796#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80765=80796

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich, nicolasfella, cblack
Cc: cblack, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-21 Thread Carson Black 
cblack accepted this revision.
cblack added a comment.


  UI seems fine enough.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich, nicolasfella, cblack
Cc: cblack, nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-21 Thread Tobias Fella 
tfella added a comment.


  F8251937: HotspotKcm.png 

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-21 Thread Tobias Fella 
tfella updated this revision to Diff 80765.
tfella added a comment.


  Use network-wireless-hotspot as icon

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80714=80765

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80714.
tfella marked an inline comment as done.
tfella added a comment.


  Change id

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80689=80714

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Jan Grulich 
jgrulich accepted this revision.
jgrulich added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:39
> +Controls.Switch {
> +id: enabled
> +Kirigami.FormData.label: i18n("Enabled:")

Using adjective as an ID looks weird to me.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich, nicolasfella
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80689.
tfella added a comment.


  fix

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80688=80689

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella added a comment.


  Git/Arc decided to do weird things, I hope I didn't break it

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80688.
tfella marked 6 inline comments as done.
tfella added a comment.


  Fixes

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80683=80688

BRANCH
  mobileHotspotKcm

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Nicolas Fella 
nicolasfella added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> +project (kcm_mobile_hotspot)
> +

remove

> CMakeLists.txt:11
> +KF5::I18n
> +KF5::Plasma
> +KF5::QuickAddons

KF5::Plasma shouldn't be needed

> hotspotsettings.cpp:30
> +{
> +KAboutData* about = new KAboutData("kcm_mobile_hotspot", 
> i18n("Hotspots"),
> +   "0.1", QString(), 
> KAboutLicense::LGPL);

Hotspot singular

> hotspotsettings.h:32
> +HotspotSettings(QObject *parent, const QVariantList );
> +virtual ~HotspotSettings();
> +};

override

> main.qml:28
> +SimpleKCM {
> +id: main
> +

id is unused. check also for others

> main.qml:30
> +
> +title: i18n("Hotspot")
> +

I'm not 100% sure the title is actually getting used

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D29019

To: tfella, #vdg, jgrulich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella updated this revision to Diff 80683.
tfella added a comment.


  Whitespace fix

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29019?vs=80679=80683

BRANCH
  mobileHotspotKcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29019: Create a hotspot KCM for Plasma Mobile

2020-04-20 Thread Tobias Fella 
tfella created this revision.
tfella added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
tfella requested review of this revision.

REVISION SUMMARY
  Implements T12895 . Might include things 
like bluetooth and usb tethering in the future when implemented

TEST PLAN
  Edit SSID and password, start, connect

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileHotspotKcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29019

AFFECTED FILES
  mobile/CMakeLists.txt
  mobile/hotspot/CMakeLists.txt
  mobile/hotspot/Messages.sh
  mobile/hotspot/hotspotsettings.cpp
  mobile/hotspot/hotspotsettings.h
  mobile/hotspot/package/contents/ui/main.qml
  mobile/hotspot/package/metadata.desktop
  mobile/wifi/package/contents/ui/TetheringSetting.qml
  mobile/wifi/package/contents/ui/main.qml

To: tfella, #vdg, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart