D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ltoscano created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fix the reference to KDE (or remove them when not strictly needed). TEST PLAN The code still compiles. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6469 AFFECTED FILES kcms/autostart/advanceddialog.cpp kcms/autostart/autostart.cpp kcms/autostart/autostart.desktop kcms/componentchooser/emailclientconfig_ui.ui kcms/desktoppaths/globalpaths.cpp kcms/fonts/fonts.cpp kcms/keyboard/kcm_keyboard.ui kcms/keyboard/kcmmisc.cpp kcms/knotify/knotify.cpp To: ltoscano Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ltoscano added a comment.
... and few in-line questions for the reviewers.
INLINE COMMENTS
> autostart.cpp:75
> KAboutData* about = new KAboutData(QStringLiteral("Autostart"),
> - i18n("KDE Autostart Manager"),
> + i18n("Session Autostart Manager"),
> QStringLiteral("1.0"),
Should this be "Session" or "Plasma Session"? Aren't the settings changed here
valid for all desktops which follow the XDG spec?
> globalpaths.cpp:127
> " links to applications (shortcuts) that you
> want to have started"
> -" automatically whenever KDE starts. You can
> change the location of this"
> +" automatically whenever the Plasma session
> starts. You can change the location of this"
> " folder if you want to, and the contents will
> move automatically"
I explicitly wrote "Plasma" because this setting seems to be Plasma-specific.
Did I understand it correctly?
> fonts.cpp:680
> " value a better option is explicitly
> configuring it for the whole X server if"
> -" possible (e.g. DisplaySize in xorg.conf or
> adding -dpi value to"
> -" ServerLocalArgs= in
> $KDEDIR/share/config/kdm/kdmrc). When fonts do not render"
> +" possible (e.g. DisplaySize in xorg.conf). When
> fonts do not render"
> " properly with real DPI value better fonts
> should be used or configuration"
Remove references to kdmrc in the meantime.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6469
To: ltoscano
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
lukas added inline comments. INLINE COMMENTS > ltoscano wrote in autostart.cpp:75 > Should this be "Session" or "Plasma Session"? Aren't the settings changed > here valid for all desktops which follow the XDG spec? Yes, it should be valid for all DEs (I'd vote for "Session" only then) > emailclientconfig_ui.ui:12 > > - Kmail is the standard Mail program for the KDE > desktop. > + Kmail is the standard Mail program for the Plasma > desktop. > I'd keep the old one as well, just for a better discoverability > ltoscano wrote in globalpaths.cpp:127 > I explicitly wrote "Plasma" because this setting seems to be Plasma-specific. > Did I understand it correctly? Again, this should be desktop agnostic REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ltoscano added inline comments. INLINE COMMENTS > lukas wrote in emailclientconfig_ui.ui:12 > I'd keep the old one as well, just for a better discoverability Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go away :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
sebas added a comment. Needs to smallish changes, then good to go in. INLINE COMMENTS > ltoscano wrote in emailclientconfig_ui.ui:12 > Do you mean keep KDE somehow? But "KDE desktop" is exactly what should go > away :) Yeah, exactly. The KDE should go away here. > lukas wrote in globalpaths.cpp:127 > Again, this should be desktop agnostic "whenever the session starts" is fine here. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ltoscano updated this revision to Diff 16149. ltoscano added a comment. Remove a Plasma reference (generic session) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6469?vs=16097&id=16149 BRANCH master REVISION DETAIL https://phabricator.kde.org/D6469 AFFECTED FILES kcms/autostart/advanceddialog.cpp kcms/autostart/autostart.cpp kcms/autostart/autostart.desktop kcms/componentchooser/emailclientconfig_ui.ui kcms/desktoppaths/globalpaths.cpp kcms/fonts/fonts.cpp kcms/keyboard/kcm_keyboard.ui kcms/keyboard/kcmmisc.cpp kcms/knotify/knotify.cpp To: ltoscano Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
ltoscano added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D6469 To: ltoscano, davidedmundson Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
D6469: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma
This revision was automatically updated to reflect the committed changes. Closed by commit R119:7f9e7c854936: Terminology fixes in KCMs: KDE-as-the-desktop -> Plasma (authored by ltoscano). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6469?vs=16149&id=17870 REVISION DETAIL https://phabricator.kde.org/D6469 AFFECTED FILES kcms/autostart/advanceddialog.cpp kcms/autostart/autostart.cpp kcms/autostart/autostart.desktop kcms/componentchooser/emailclientconfig_ui.ui kcms/desktoppaths/globalpaths.cpp kcms/fonts/fonts.cpp kcms/keyboard/kcm_keyboard.ui kcms/keyboard/kcmmisc.cpp kcms/knotify/knotify.cpp To: ltoscano, davidedmundson Cc: sebas, lukas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart
