D8321: Only check for legacy system tray icons if we're going to make one
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY On Plasma is a rather pointless check as our QPT uses SNIs so we end up checking something we've already checked, only in a blocking way - and we're going to no-op anyway. BUG: 385371 TEST PLAN killed kded5 created an SNI. It failed into the else branch REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D8321 AFFECTED FILES src/kstatusnotifieritem.cpp To: davidedmundson, #plasma Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8321: Only check for legacy system tray icons if we're going to make one
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL https://phabricator.kde.org/D8321 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8321: Only check for legacy system tray icons if we're going to make one
This revision was automatically updated to reflect the committed changes. Closed by commit R289:800908eaec7a: Only check for legacy system tray icons if we're going to make one (authored by davidedmundson). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8321?vs=20833&id=20889 REVISION DETAIL https://phabricator.kde.org/D8321 AFFECTED FILES src/kstatusnotifieritem.cpp To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8321: Only check for legacy system tray icons if we're going to make one
graesslin added a comment. I'm sorry but it still deadlocks, see https://bugs.kde.org/show_bug.cgi?id=385867 REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8321 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
D8321: Only check for legacy system tray icons if we're going to make one
davidedmundson added a comment. Trace is different, so ...progress! I don't think there's anything specifically wrong with this patch in itself. I'll fix that and review the rest of this class. Sorry, Thanks for the quick feedback. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D8321 To: davidedmundson, #plasma, graesslin Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart