D21027: [Notes] Fix icons being almost invisible with light backgrounds when using dark themes
This revision was automatically updated to reflect the committed changes. Closed by commit R114:84742d8965bd: [Notes] Fix icons being almost invisible with light backgrounds when using dark… (authored by filipf). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21027?vs=59286&id=60197 REVISION DETAIL https://phabricator.kde.org/D21027 AFFECTED FILES applets/notes/package/contents/ui/main.qml To: filipf, #plasma, #vdg, ngraham, davidedmundson Cc: broulik, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 Hugo Pereira Da Costa changed: What|Removed |Added CC||hugo.pereira.da.costa@gmail ||.com Assignee|plasma-devel@kde.org|hugo.pereira.da.costa@gmail ||.com Component|general |QStyle --- Comment #11 from Hugo Pereira Da Costa --- Will fix. Thanks Christoph for the suggested patch, it is a good one. (would have implemented earlier if i had been in the assignee list). -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #10 from Christoph Feck --- (or "QPalette::Shadow" at your convenience...) -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #9 from Christoph Feck --- According to the code, the color that is used to darken the inactive tabs is the WindowText color. With reverse (dark) themes, this color is bright, so instead of darkening, the inactive tabs become lighter. Suggested patch: Change "QPalette::WindowText" to "QPalette::Dark" in breezestyle.cpp, line 5549. -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #8 from Francis Herne --- Tangentially, I looked through the colours in Breeze-dark, and can't find any one that matches the inactive tab colour. It's not clear where this is colour derived from, or how to modify it. (also, I messed up my previous comment slightly; part of one entry is duplicated. It's 2am here, time to sleep...) -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #7 from Janek Bevendorff --- I agree that Breeze is the nicest theme of all those. But the inverted colors are clearly confusing and counter-intuitive. I'm not quite sure where the error lies, though. This weird tab coloring also appears with other dark color schemes, such as various Krita color schemes. So it could either be that they are all just based on each other and inherit the same bug or that it is really an issue with the Breeze widget style. The fact that changing the widget style leads to correct tab coloring lets strongly assume it is. -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #6 from Francis Herne --- Created attachment 102846 --> https://bugs.kde.org/attachment.cgi?id=102846&action=edit Comparison of tabs in different widget styles -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 --- Comment #5 from Francis Herne --- I think your statement is incorrect - no other widget style installed on my system displays tabs with reversed colours, using Breeze-dark or other dark schemes. In the attachment, all using Breeze-dark, top to bottom: - QtCurve (default settings): active tab is lighter, taller and has red close icon. - Oxygen: active tab is lighter, taller all using Breeze-dark, top to bottom: - QtCurve (default settings): active tab is lighter, taller and has red close icon. - Win9x (bleh): active tab has same colour, taller, has red close icon. - Fusion: active tab is lighter and taller. All close buttons identical (red). - Breeze: active tab is much darker, same height. All close buttons identical (grey). To be honest, I find Breeze's tabs clearer than the other variants with this colour scheme - ignoring distinct close-icon colours which make a huge difference - but the inverse-colour behaviour is clearly influenced by Breeze QtStyle and is reversed from all other styles. -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 373088] Current tab highlighting counter-intuitive when using dark themes
https://bugs.kde.org/show_bug.cgi?id=373088 Hugo Pereira Da Costa changed: What|Removed |Added Assignee|hugo.pereira.da.costa@gmail |plasma-devel@kde.org |.com| Component|QStyle |general --- Comment #4 from Hugo Pereira Da Costa --- I mean: either modify the official breeze-dark theme, or you modify the theme you use to something that suits you better. -- You are receiving this mail because: You are the assignee for the bug.
[Breeze] [Bug 343961] Smallest size icons look bad on dark themes
https://bugs.kde.org/show_bug.cgi?id=343961 Martin Klapetek changed: What|Removed |Added Assignee|plasma-devel@kde.org|unassigned-b...@kde.org Component|general |Icons CC||mklape...@kde.org -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
[Breeze] [Bug 343961] New: Smallest size icons look bad on dark themes
https://bugs.kde.org/show_bug.cgi?id=343961 Bug ID: 343961 Summary: Smallest size icons look bad on dark themes Product: Breeze Version: unspecified Platform: Archlinux Packages OS: Linux Status: UNCONFIRMED Severity: major Priority: NOR Component: general Assignee: plasma-devel@kde.org Reporter: hipersaya...@gmail.com Created attachment 90989 --> https://bugs.kde.org/attachment.cgi?id=90989&action=edit I can't see the Konsole and Show Desktop icons, also System Settings icon in clueless Package name: breeze Version: 5.2.0 When configuring the desktop theme to a dark color, like Oxygen or Breeze Dark, I can barely distinguish the Konsole or Show Desktop icons from the background when using Breeze icon themes. -- You are receiving this mail because: You are the assignee for the bug. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Dark themes
Thanks much for the feedback Eike and David. :-) With no noted objections and several thumbs up from our translators, I'll commit the Breeze Dark icon theme to the Plasma/5.1 branch of the breeze repo later this evening. Thanks much, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Dark themes
On 05.10.2014 00:49, Andrew Lake wrote: Thanks much Eike. I'll make the request for an exception if there are no objections to option C from others here. And thanks for the theme work, btw - big fan of the Dark versions :) Much respect, Andrew Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Dark themes
> > Thanks much Eike. I'll make the request for an exception if there are no >> objections to option C from others here. >> > No objections from me. We may as well ask translators anyway. If they say no then we'll at least know what our options are. David ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Dark themes
On Sat, Oct 4, 2014 at 3:35 PM, Eike Hein wrote: > > > On 05.10.2014 00:29, Andrew Lake wrote: > >> C. Further violate the string freeze by pushing the Breeze Dark icon >> theme to the Plasma/5.1 branch to provide a remedy for the icon >> visibility issues with dark application color schemes and with the >> > > I don't think violating string freeze is critical for this. > Our theme selection UIs usually provide visual feedback to > get an idea of what an entry actually is/does, and the name > functions more as, well, a name, or a brand, or however you > want to put it. Realistically, nobody is going to stare at > the screen in puzzlement over what "Dark" means in this > context. > > That said, the standard protocol is to mail kde-i18n-doc > and ask for a string freeze exception - the people with > the relevant opinion here are our translators, not actually > you or me. > > Thanks much Eike. I'll make the request for an exception if there are no objections to option C from others here. Much respect, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Re: Dark themes
On 05.10.2014 00:29, Andrew Lake wrote: C. Further violate the string freeze by pushing the Breeze Dark icon theme to the Plasma/5.1 branch to provide a remedy for the icon visibility issues with dark application color schemes and with the I don't think violating string freeze is critical for this. Our theme selection UIs usually provide visual feedback to get an idea of what an entry actually is/does, and the name functions more as, well, a name, or a brand, or however you want to put it. Realistically, nobody is going to stare at the screen in puzzlement over what "Dark" means in this context. That said, the standard protocol is to mail kde-i18n-doc and ask for a string freeze exception - the people with the relevant opinion here are our translators, not actually you or me. Thanks much for your patience and help, Andrew Cheers, Eike ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
Dark themes
Hello all, I just realized that in pushing the Breeze Dark color scheme to the Plasma/5.1 branch of the breeze repo, it likely violates the string freeze (the name of the color scheme). So when I pushed the new Breeze Dark icon theme I only pushed it to master since the icon theme name and description are new strings. The Breeze Dark icon theme allows the user to select an icon theme that provides appropriate monochrome icon contrast for dark application color schemes and also for the already-available Breeze Dark plasma theme. In the latter case it provides some remedy for the icon visibility issues where icons from the main icon theme are displayed (like on the Application Launcher "Leave" tab, taskbar, etc.). So now I'm not sure what the least bad result is; A. Leave the breeze repo Plasma/5.1 branch as is with no remedy for the main icon theme visibility issues with dark color schemes or the Breeze Dark plasma theme OR B. Revert the Breeze Dark color scheme commit in respect of string freeze with similar downsides as A OR C. Further violate the string freeze by pushing the Breeze Dark icon theme to the Plasma/5.1 branch to provide a remedy for the icon visibility issues with dark application color schemes and with the Breeze Dark plasma theme. OR D. ? Of course the best solution would have been to get these changes in before the string freeze. For that I apologize. But here we are, and I need some help making a decision. Thanks much for your patience and help, Andrew ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
