Re: Fullscreen and skip taskbar window
Hello Martin, On Sat, Feb 10, 2018 at 05:38:25PM +0100, Martin Flöser wrote: > Just remove everything related to the shellsurface. You don't need that as > Qt takes care of creating the shell surface. So I made the changes and commented out the shellsurface related code.. However that again brings me back to where I started, setting fullscreen state makes plasmashell to crash in really weird state. See the wayland_debug log : https://ptpb.pw/xjlR It just shows the top panel and rest of plasmashell gets hidden, I don't get this behavior if kwayland-integration is not installed, so it is something wrong about either kwayland-integration or how the fullscreenpanel code tries to do things.. You can see short gif of what happens at, https://imgur.com/a/JvEYs this has been issue from quite while and workaround we used to apply is not install kwayland-integration, which ofcourse doesn't provide sane OSD sizes, idletime functionality etc.. So would be lovely to have it solved. I've pushed my code at bshah/stuff branch of plasma-phone-components. https://cgit.kde.org/plasma-phone-components.git/tree/components/fullscreenpanel.cpp?h=bshah/stuff#n98 L98 is what makes stuff go boom, if I comment out that window is not fullscreen and e.g window background is not correctly scaled across panels. Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
Re: Fullscreen and skip taskbar window
Am 2018-02-10 14:53, schrieb Bhushan Shah: Hello, so in plasma-phone shell, we have this code, https://cgit.kde.org/plasma-phone-components.git/tree/components/fullscreenpanel.cpp Which essentially sets window to fullscreen and the skiptaskbar, but this results in weird plasmashell "hang" when used on phone with top panel. So I tried to port it to use PlasmaShellInterface and ShellInterface to set it fullscreen and skip taskbar. see, https://commits.kde.org/plasma-phone-components/02fd43edb80f560e7 But turns out this is not easy as I thought, it results in protocol error as both shellinterface and plasmashellinterface can't be used in single surface. Thoughts on how to resolve this? i.e have skiptaskbar and fullscreen window at same time? Maybe we need to add fullscreen in plasmashellsurface? Just remove everything related to the shellsurface. You don't need that as Qt takes care of creating the shell surface. Btw. I suggest to also set a "proper" window type for the window, e.g. make it a Dock to ensure the panel can go above other fullscreen windows. Cheers Martin
Fullscreen and skip taskbar window
Hello, so in plasma-phone shell, we have this code, https://cgit.kde.org/plasma-phone-components.git/tree/components/fullscreenpanel.cpp Which essentially sets window to fullscreen and the skiptaskbar, but this results in weird plasmashell "hang" when used on phone with top panel. So I tried to port it to use PlasmaShellInterface and ShellInterface to set it fullscreen and skip taskbar. see, https://commits.kde.org/plasma-phone-components/02fd43edb80f560e7 But turns out this is not easy as I thought, it results in protocol error as both shellinterface and plasmashellinterface can't be used in single surface. Thoughts on how to resolve this? i.e have skiptaskbar and fullscreen window at same time? Maybe we need to add fullscreen in plasmashellsurface? Thanks -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D signature.asc Description: PGP signature
