[Differential] [Closed] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACE2c868c438033: New new SDDM theme (authored by 
davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D2399?vs=5818&id=5968#toc

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2399?vs=5818&id=5968

REVISION DETAIL
  https://phabricator.kde.org/D2399

AFFECTED FILES
  sddm-theme/ActionButton.qml
  sddm-theme/Background.qml
  sddm-theme/BatteryIcon.qml
  sddm-theme/Clock.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/README.txt
  sddm-theme/SessionButton.qml
  sddm-theme/UserDelegate.qml
  sddm-theme/UserList.qml
  sddm-theme/dummydata/sddm.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Accepted] D2399: New new SDDM theme

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
mart added a comment.
This revision is now accepted and ready to land.


  to me is ok (if is good design-wise for vdg) my only comment is wether is 
possible to make the faces avoiding the custom shader, but is not super 
important

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  sddm_stuff

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma, mart
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Updated] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> bshah wrote in KeyboardButton.qml:13
> I wonder if it ever worked to translate those in SDDM? Given KDeclarative 
> takes care of loading translation domain IIRC.

It used to work.
We don't have the i18n domain set because we're being loaded by SDDM, however 
the i18nd explicitly sets the domain to use.

This has been fixed by 
https://phabricator.kde.org/rPLASMAWORKSPACE0ece53786e1a7ee37f4ce5e01172673b43a1407c
 in plasma-workspace master.

No changes to this patch are needed.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in UserDelegate.qml:85
> It's a bit more complex with the white frame that has to be transparent on 
> the inside.
> 
> So that then needs to be drawn somehow. I guess making an SVG of a circle 
> would work.

Using layers opacity mask, the white circle wouldn't be drawn, it's only used 
to cut a circle out of the user avatar. For the border, could be another 
rectangle rounded to a circle, which only the border is drawn?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Changed Subscribers] D2399: New new SDDM theme

[bshah (Bhushan Shah)]

bshah added inline comments.

INLINE COMMENTS

> davidedmundson wrote in KeyboardButton.qml:13
> It was...though that broke when this folder was moved. Good spot.

I wonder if it ever worked to translate those in SDDM? Given KDeclarative takes 
care of loading translation domain IIRC.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: bshah, mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> mart wrote in KeyboardButton.qml:13
> is this domain valid for sddm as well?

It was...though that broke when this folder was moved. Good spot.

> mart wrote in UserDelegate.qml:85
> this version you have is probably is significantly faster (and in this case 
> i'll shut up :p)
> 
> but wouldn't look cleaner to have something along the lines:
> 
> layer.enabled: true
> 
>   layer.effect: OpacityMask {
>   maskSource: Rectangle {
>   anchors.centerIn: parent
>   width: imageWrapper.width
>   height: width
>   radius: width/2
>   }
>   }

It's a bit more complex with the white frame that has to be transparent on the 
inside.

So that then needs to be drawn somehow. I guess making an SVG of a circle would 
work.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> KeyboardButton.qml:13
>  
> -text: instantiator.objectAt(currentIndex).shortName
> +text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Keyboard Layout: 
> %1", instantiator.objectAt(currentIndex).shortName)
>  implicitWidth: minimumWidth

is this domain valid for sddm as well?

> UserDelegate.qml:85
>  
> -//if copying into another project don't forget to * qt_Opacity. It's 
> just unused here
> -//and connect themeChanged to update()
> +//if copying into another project don't forget to connect 
> themeChanged to update()
> +//but in SDDM that's a bit pointless

this version you have is probably is significantly faster (and in this case 
i'll shut up :p)

but wouldn't look cleaner to have something along the lines:

layer.enabled: true

  layer.effect: OpacityMask {
  maskSource: Rectangle {
  anchors.centerIn: parent
  width: imageWrapper.width
  height: width
  radius: width/2
  }
  }

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2399#45044, @davidedmundson wrote:
  
  > Screenshot as requested.
  >
  > F255167: Spectacle.h20090.png 
  >
  > Note the coloured icons for actions will be changing when Andreas pushes 
some change.
  >
  > Also I have some unresolved comments here: 
https://phabricator.kde.org/M58/178/
  
  
  what about white circles?

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

[mart (Marco Martin)]

mart added a comment.


  In https://phabricator.kde.org/D2399#44873, @apol wrote:
  
  > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.
  
  
  but also working QML code, that means, it must be maintained. if there are 
volunteers, awesome, if it stays there bitrotting, hmm, not so much

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: mart, apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Commented On] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  Screenshot as requested.
  
  F255167: Spectacle.h20090.png 
  
  Note the coloured icons for actions will be changing when Andreas pushes some 
change.
  
  Also I have some unresolved comments here: 
https://phabricator.kde.org/M58/178/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson added a comment.


  In https://phabricator.kde.org/D2399#44873, @apol wrote:
  
  > Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.
  
  
  Maybe, but this patch is against the SDDM theme that was nearly in 5.7, the 
old theme was already deleted. 
  It can be restored, but it's a bit irrelevant wrt to this patch.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Commented On] D2399: New new SDDM theme

[apol (Aleix Pol Gonzalez)]

apol added a comment.


  Shouldn't we be keeping the old theme for nostalgia and such? It's a theme 
after all.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2399

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: apol, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 749 lines] D2399: New new SDDM theme

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Implements the new SDDM theme.
  There's a lot of hardcoded values, but the mockup asks for it.
  It also doesn't match the mockup exactly because all grid unit sizes are just 
wrong and partly because in many cases I opted for just using the
  Plasma default.
  
  Code is written with the intention to easily port the lock screen
  All SDDM related code is now shifted into Main with Login.qml acting as
  an abstraction layer.

TEST PLAN
  Ran it, against the awesome mock data.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

BRANCH
  sddm_stuff

REVISION DETAIL
  https://phabricator.kde.org/D2399

AFFECTED FILES
  sddm-theme/ActionButton.qml
  sddm-theme/Background.qml
  sddm-theme/BatteryIcon.qml
  sddm-theme/KeyboardButton.qml
  sddm-theme/Login.qml
  sddm-theme/Main.qml
  sddm-theme/README.txt
  sddm-theme/SessionButton.qml
  sddm-theme/UserDelegate.qml
  sddm-theme/UserList.qml
  sddm-theme/dummydata/sddm.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: New SDDM Theme

[David Edmundson]

All done here: https://phabricator.kde.org/D1949

just needs a review.

I've double checked there's no i18n changes.
​
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

New SDDM Theme

[Philipp Stefan]

Hello everyone,

as many of you surely have seen by now: the new SDDM theme in the Plasma 
5.7 beta announcement has cause many very negative reactions. After a 
few hours of deliberation and weighting our options the VDG came to the 
conclusion that it is better to postpone the release of the new SDDM 
theme and accompanying artwork to the 5.8 cycle. That mostly means that 
the "old" 5.6 SDDM theme will be used and both SDDM and ksplash will use 
the 5.7 default wallpaper as background.


Please let me explain our reasoning: because of our less than ideal 
communication the new SDDM theme got started very late in the 5.7 cycle. 
Judging by reactions on multiple sites people did not understand that 
the new theme is part of the ongoing project of ours to get a unified 
experience from boot to shutdown. It's likely that users updating to 5.7 
would feel the same. So even if we would manage to bring the new SDDM 
theme as it currently stands to the point envisioned by the design it 
would still be the odd one out in combination with the current logout 
dialogue.


One idea was to simply get rid of the much detested blue background and 
use the default 5.7 one instead while trying to get the UI closer to the 
design i.e. fixing the bugs until the end of the beta phase. However, 
this would still leave us with two clashing UIs as stated above. In 
essence we would go from a similar login and lock screen theme in 5.6 to 
a dissimilar one in 5.7. This would clash with our goal of offering a 
more unified experience, even if it was for just one cycle.


So all in all we think it will be better to land the new UI as a whole 
and not step by step. This will give us much more time to refine the UI 
design than what would be possible in the little time left and also 
present users with a coherent experience from day 1.


Cheers,

Philipp Stefan




___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[Breeze] [Bug 350434] New: SDDM theme does not use Breeze user icons

[Markus S .]

https://bugs.kde.org/show_bug.cgi?id=350434

Bug ID: 350434
   Summary: SDDM theme does not use Breeze user icons
   Product: Breeze
   Version: 5.3.2
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: kamika...@web.de

Compare
http://static.davidedmundson.co.uk/blog/display_managers_finale/breeze_login_screen.png
to
http://i1-news.softpedia-static.com/images/news2/KDE-Plasma-5-1-0-Brings-Back-Some-Old-Features-462226-6.jpg

The user image in the first screenshot is not the Breeze one.

-- 
You are receiving this mail because:
You are the assignee for the bug.
___
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel